Re: [U-Boot-Users] [PATCH] Modifications to video-related files for RRvision.
Hello Gary,
some comments/questions below:
Gary Jennejohn wrote:
> Note that the LOGO_X/LOG_Y macros are defined in RRvision.h to center
> the logo on the screen and might be useful for other boards.
> Signed-off-by: Gary Jennejohn <[EMAIL PROTECTED]>
add empty line between commit message and Signed-off-by line.
> ---
> common/lcd.c |9 +++-
> cpu/mpc8xx/lcd.c | 138
> +---
> cpu/mpc8xx/video.c | 22 -
> 3 files changed, 159 insertions(+), 10 deletions(-)
>
> diff --git a/common/lcd.c b/common/lcd.c
> index ebf377a..e54d4f5 100644
> --- a/common/lcd.c
> +++ b/common/lcd.c
> @@ -70,6 +70,13 @@
> # if (CONSOLE_COLOR_WHITE >= BMP_LOGO_OFFSET)
> # error Default Color Map overlaps with Logo Color Map
> # endif
> +
> +# ifndef CONFIG_LCD_LOGO_X
> +# define CONFIG_LCD_LOGO_X 0
-^^
please, use TAB here.
> +# endif
> +# ifndef CONFIG_LCD_LOGO_Y
> +# define CONFIG_LCD_LOGO_Y 0
-^^
Ditto.
> +# endif
> #endif
>
> DECLARE_GLOBAL_DATA_PTR;
> @@ -768,7 +775,7 @@ static void *lcd_logo (void)
> #endif /* CONFIG_SPLASH_SCREEN */
>
> #ifdef CONFIG_LCD_LOGO
> - bitmap_plot (0, 0);
> + bitmap_plot (CONFIG_LCD_LOGO_X, CONFIG_LCD_LOGO_Y);
> #endif /* CONFIG_LCD_LOGO */
>
> #ifdef CONFIG_MPC823
> diff --git a/cpu/mpc8xx/lcd.c b/cpu/mpc8xx/lcd.c
> index 3c64a9b..aff5465 100644
> --- a/cpu/mpc8xx/lcd.c
> +++ b/cpu/mpc8xx/lcd.c
> @@ -55,6 +55,10 @@
> #undef CONFIG_LCD_INFO
> #endif
>
> +#if defined(CONFIG_RRVISION) && defined(TTTECH_NO_SCREEN_INFO)
> +#undef CONFIG_LCD_INFO
> +#endif
> +
> /*--*/
> #ifdef CONFIG_KYOCERA_KCS057QV1AJ
> /*
> @@ -114,7 +118,7 @@ vidinfo_t panel_info = {
> */
> vidinfo_t panel_info = {
> 640, 480, 212, 158, CFG_HIGH, CFG_HIGH, CFG_LOW, CFG_LOW, CFG_HIGH,
> -3, 0, 0, 1, 1, 144, 2, 0, 33
> +3, 0, 0, 1, 1, 88, 2, 0, 33
> /* wbl, vpw, lcdac, wbf */
> };
> #endif /* CONFIG_NEC_NL6448BC33_54 */
> @@ -122,16 +126,83 @@ vidinfo_t panel_info = {
>
> #ifdef CONFIG_SHARP_LQ104V7DS01
> /*
> - * SHARP LQ104V7DS01. 6.5", 640x480. Active, color, single scan.
> + * SHARP LQ104V7DS01. 10", 640x480. Active, color, single scan.
> */
> vidinfo_t panel_info = {
> -640, 480, 132, 99, CFG_HIGH, CFG_HIGH, CFG_LOW, CFG_LOW, CFG_LOW,
> -3, 0, 0, 1, 1, 25, 1, 0, 33
> +660, 480, 0, 0, CFG_HIGH, CFG_HIGH, CFG_LOW, CFG_LOW, CFG_HIGH,
---^^^
is this intentional or a typo?
> +3, 0, 0, 1, 1, 99, 30, 0, 20
> /* wbl, vpw, lcdac, wbf */
> };
> #endif /* CONFIG_SHARP_LQ104V7DS01 */
> /*--*/
>
> +/*--*/
> +
> +#ifdef CONFIG_SHARP_LQ104V1DG61
> +/*
> + * SHARP LQ104V1DG61. 10", 640x480. Active, color, single scan.
> + */
> +vidinfo_t panel_info = {
> +640, 480, 0, 0, CFG_HIGH, CFG_HIGH, CFG_LOW, CFG_LOW, CFG_HIGH,
> +3, 0, 0, 1, 1, 80, 30, 0, 20
> +
> +};
> +#endif /* CONFIG_SHARP_LQ104V1DG61 */
> +/*--*/
> +
> +/*--*/
> +
> +#ifdef CONFIG_NEC_NL8060BC26
> +#undef LCD_DF
> +#define LCD_DF 4
> +/*
> + * NEC_NL8060BC26. 10.4"", 800x600. Active, color, single scan.
> + */
> +vidinfo_t panel_info = {
> +800, 600, 211, 158, CFG_HIGH, CFG_HIGH, CFG_LOW, CFG_LOW, CFG_HIGH,
> +3, 0, 0, 1, 1, 80, 30, 0, 20
> +};
> +#endif /* CONFIG_NEC_NL8060BC26 */
> +/*--*/
> +
> +/*--*/
> +
> +#ifdef CONFIG_PM070WL3
> +#undef LCD_DF
> +#define LCD_DF 4
> +/*
> + * PM070-WL3. 7"", 800x480. Active, color, single scan.
> + */
> +vidinfo_t panel_info = {
> +800, 480, 153, 92, CFG_HIGH, CFG_HIGH, CFG_LOW, CFG_LOW, CFG_HIGH,
> +3, 0, 0, 1, 1, 80, 30, 0, 20
> +};
> +#endif /* CONFIG_PM070WL3 */
> +/*--*/
> +
> +
remove one empty line above.
> +#ifdef CONFIG_HLD1045AE1
> +vidinfo_t panel_info = {
> +640, 480, 0, 0, CFG_HIGH, CFG_HIGH, CFG_LOW, CFG_LOW, CFG_HIGH,
> +3, 0, 0, 1, 1, 80, 3, 0, 33
> +/* wbl, vpw, lcdac, wbf */
> +};
> +#endif /* CONFIG_HLD1045AE1 */
> +/*--*/
> +
> +#ifdef CONFIG_AUO_T070W1D1
> +#undef LCD_DF
> +#define LCD_DF 12
> +
> +vidinfo_t panel_info = {
> +480, 240, 0, 0, CFG_HIGH, CFG_HIGH, CFG_LOW, CFG_LOW, CFG_HIGH,
> +3, 1, 0, 1, 1, 80, 4, 0, 16
> +/* wbl, vpw, lcdac, wbf */
> +};
> +#define CONFIG_LCD_INFO_BELOW_LOGO
> +#endif /* CONFIG_AUO_T070W1D1 */
> +/*---
Re: [U-Boot-Users] [PATCH] Modifications to video-related files for RRvision.
Hi Rodolfo, > On Tue, Jun 24, 2008 at 05:05:23PM +0200, Gary Jennejohn wrote: >> On Tue, 24 Jun 2008 14:14:23 +0200 >> Rodolfo Giometti <[EMAIL PROTECTED]> wrote: >> >> > On Mon, Jun 23, 2008 at 04:54:38PM +0200, Gary Jennejohn wrote: >> > > >> > > Note that the LOGO_X/LOG_Y macros are defined in RRvision.h to center >> > > the logo on the screen and might be useful for other boards. >> > > Signed-off-by: Gary Jennejohn <[EMAIL PROTECTED]> >> > >> > Nak. This is a multi-patch. >> > >> > Please provide a patch for the LOGO_X/LOG_Y macros and a patch for >> > RRvision board, then send the first to me and the second to the proper >> > maintainer. >> > >> >> Wolfgang Denk imformed me that the lcd/video patches had to go to the >> proper custodian and I only found your name listed for video. >> >> So, who _is_ the proper target for this stuff? Wolfgang doesn't want >> to see it. > > I'm the video custodian, so I can decide about lcd/video stuff, > regarding specific boards modifications you should check the > custodians list. Can you explain that to me? Gary changes three files: common/lcd.c |9 +++- cpu/mpc8xx/lcd.c | 138 +--- cpu/mpc8xx/video.c | 22 - 3 files changed, 159 insertions(+), 10 deletions(-) None of this is specific to a board but really concerns lcd and video handling. If you don't feel responsible for it, the only other custodian could be the 8xx custodian. But he already pointed Gary to you ;) So please, if nobody from the 8xx front NAKs the patches, pull it into your custodian repository. Thanks Detlev -- The continental people think life is a game. The English think cricket is a game. -- George Mikes -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH] Modifications to video-related files for RRvision.
On Tue, Jun 24, 2008 at 05:05:23PM +0200, Gary Jennejohn wrote: > On Tue, 24 Jun 2008 14:14:23 +0200 > Rodolfo Giometti <[EMAIL PROTECTED]> wrote: > > > On Mon, Jun 23, 2008 at 04:54:38PM +0200, Gary Jennejohn wrote: > > > > > > Note that the LOGO_X/LOG_Y macros are defined in RRvision.h to center > > > the logo on the screen and might be useful for other boards. > > > Signed-off-by: Gary Jennejohn <[EMAIL PROTECTED]> > > > > Nak. This is a multi-patch. > > > > Please provide a patch for the LOGO_X/LOG_Y macros and a patch for > > RRvision board, then send the first to me and the second to the proper > > maintainer. > > > > Wolfgang Denk imformed me that the lcd/video patches had to go to the > proper custodian and I only found your name listed for video. > > So, who _is_ the proper target for this stuff? Wolfgang doesn't want > to see it. I'm the video custodian, so I can decide about lcd/video stuff, regarding specific boards modifications you should check the custodians list. Ciao, Rodolfo -- GNU/Linux Solutions e-mail: [EMAIL PROTECTED] Linux Device Driver [EMAIL PROTECTED] Embedded Systems phone: +39 349 2432127 UNIX programming skype: rodolfo.giometti - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH] Modifications to video-related files for RRvision.
On Tue, 24 Jun 2008 14:14:23 +0200 Rodolfo Giometti <[EMAIL PROTECTED]> wrote: > On Mon, Jun 23, 2008 at 04:54:38PM +0200, Gary Jennejohn wrote: > > > > Note that the LOGO_X/LOG_Y macros are defined in RRvision.h to center > > the logo on the screen and might be useful for other boards. > > Signed-off-by: Gary Jennejohn <[EMAIL PROTECTED]> > > Nak. This is a multi-patch. > > Please provide a patch for the LOGO_X/LOG_Y macros and a patch for > RRvision board, then send the first to me and the second to the proper > maintainer. > Wolfgang Denk imformed me that the lcd/video patches had to go to the proper custodian and I only found your name listed for video. So, who _is_ the proper target for this stuff? Wolfgang doesn't want to see it. > Also you have to update the README file by describing the new macros. > OK --- Gary Jennejohn * DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [EMAIL PROTECTED] * - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH] Modifications to video-related files for RRvision.
On Mon, Jun 23, 2008 at 04:54:38PM +0200, Gary Jennejohn wrote: > > Note that the LOGO_X/LOG_Y macros are defined in RRvision.h to center > the logo on the screen and might be useful for other boards. > Signed-off-by: Gary Jennejohn <[EMAIL PROTECTED]> Nak. This is a multi-patch. Please provide a patch for the LOGO_X/LOG_Y macros and a patch for RRvision board, then send the first to me and the second to the proper maintainer. Also you have to update the README file by describing the new macros. Ciao, Rodolfo -- GNU/Linux Solutions e-mail: [EMAIL PROTECTED] Linux Device Driver [EMAIL PROTECTED] Embedded Systems phone: +39 349 2432127 UNIX programming skype: rodolfo.giometti - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
