Re: [U-Boot-Users] Resubmit : [PATCH] Correct ARM Versatile Timer Initialization

2008-08-11 Thread Jean-Christophe PLAGNIOL-VILLARD
On 06:30 Mon 04 Aug , Gururaja Hebbar K R wrote:
 - According to ARM Dual-Timer Module (SP804) TRM (ARM DDI0271), 
  -- Timer Value Register @ TIMER Base + 4 is Read-only. 
  -- Prescale Value (Bits 3-2 of TIMER Control register) 
   can only be one of 00,01,10. 11 is undefined.
 
 Signed-off-by: Gururaja Hebbar [EMAIL PROTECTED]
 ---
  cpu/arm926ejs/versatile/timer.c |3 +--
  1 files changed, 1 insertions(+), 2 deletions(-)
 
 diff --git a/cpu/arm926ejs/versatile/timer.c b/cpu/arm926ejs/versatile/timer.c
 index 32872d2..9659b67 100644
 --- a/cpu/arm926ejs/versatile/timer.c
 +++ b/cpu/arm926ejs/versatile/timer.c
 @@ -50,8 +50,7 @@ static ulong lastdec;
  int timer_init (void)
  {
   *(volatile ulong *)(CFG_TIMERBASE + 0) = CFG_TIMER_RELOAD;  /* 
 TimerLoad */
 - *(volatile ulong *)(CFG_TIMERBASE + 4) = CFG_TIMER_RELOAD;  /* 
 TimerValue */
 - *(volatile ulong *)(CFG_TIMERBASE + 8) = 0x8C;
 + *(volatile ulong *)(CFG_TIMERBASE + 8) = 0x80;

according to datasheet for the register TimerXControl

we are supposed to not modify the bits [31:8] and [4]

so we are suppose to read the register and modify only the others
register.

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] Resubmit : [PATCH] Correct ARM Versatile Timer Initialization

2008-08-01 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote:
 Signed-off-by: Gururaja Hebbar [EMAIL PROTECTED]
 ---
  cpu/arm926ejs/versatile/timer.c |3 +--
  1 files changed, 1 insertions(+), 2 deletions(-)
 
 diff --git a/cpu/arm926ejs/versatile/timer.c
 b/cpu/arm926ejs/versatile/timer.c
 index 32872d2..9659b67 100644
 --- a/cpu/arm926ejs/versatile/timer.c
 +++ b/cpu/arm926ejs/versatile/timer.c
 @@ -50,8 +50,7 @@ static ulong lastdec;
  int timer_init (void)
  {
   *(volatile ulong *)(CFG_TIMERBASE + 0) = CFG_TIMER_RELOAD;
 /* TimerLoad */
^
 - *(volatile ulong *)(CFG_TIMERBASE + 4) = CFG_TIMER_RELOAD;
 /* TimerValue */
^

Just for the record: this patch is once more corrupted due to line
wrapping by the mailer.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
There are three ways to get something  done:  do  it  yourself,  hire
someone, or forbid your kids to do it.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users