Re: [U-Boot] [PATCH 05/15] common/main.c: Fix function readline

2012-01-07 Thread Pali Rohár
On Friday 06 January 2012 15:15:29 Mike Frysinger wrote: On Sunday 18 December 2011 16:34:01 Pali Rohár wrote: * Ignore ANSI escape codes for moving cursor, which are generated by keyboard this probably should be behind an appropriate CONFIG knob. i don't think this is relevant to

Re: [U-Boot] [PATCH V12 04/14] devkit8000/spl: init GPMC for dm9000 in SPL

2012-01-07 Thread Simon Schwarz
Hi Stefano, 2012/1/4 Stefano Babic sba...@denx.de: From: Simon Schwarz simonschwarz...@googlemail.com Linux crashes if the GPMC isn't configured for the dm9000. Signed-off-by: Simon Schwarz simonschwarz...@gmail.com CC: Tom Rini tom.r...@gmail.com CC: Stefano Babic sba...@denx.de CC:

Re: [U-Boot] [PATCH V12 02/14] devki8000: add config for spl command

2012-01-07 Thread Andreas Bießmann
Dear Stefano Babic, I do not want to be pedantic, but the subject line contains 'devki8000' which should be 'devkit8000'. best regards Andreas Bießmann ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v2] common/image.c: align usage of fdt_high with initrd_high

2012-01-07 Thread Shawn Guo
The commit message of a28afca (Add uboot fdt_high enviroment variable) states that fdt_high behaves similarly to the existing initrd_high. But fdt_high actually has an outstanding difference from initrd_high. The former specifies the start address, while the later specifies the end address. As

Re: [U-Boot] [PATCH v7] net: ll_temac: Add LL TEMAC driver to u-boot

2012-01-07 Thread Stephan Linz
Am Donnerstag, den 05.01.2012, 20:19 +0100 schrieb Wolfgang Denk: Dear Stephan Linz, In message 1325783490.7827.45.camel@keto you wrote: Michals latest Microblaze platform patches will enable this driver for board/xilinx/microblaze-generic and we know about a success story on a

Re: [U-Boot] Possible Denx m28evk ethernet problem + solution

2012-01-07 Thread Fabio Estevam
On Fri, Jan 6, 2012 at 3:54 PM, Robert Deliën rob...@delien.nl wrote: Hi Marek, I'm currently working on U-Boot support for the Freescale i.mx28evk board. It started out as an update of the old Freescale supplied U-Boot 2009.08, but it ended up in reconfiguring your work on the Denx

Re: [U-Boot] [PATCH v2 03/17] x86: Remove GDR related magic numbers

2012-01-07 Thread Simon Glass
HI Graeme, On Wed, Jan 4, 2012 at 11:59 AM, Graeme Russ graeme.r...@gmail.com wrote: Signed-off-by: Graeme Russ graeme.r...@gmail.com --- Changes for v2:  - Use an enum  - Add defined for GDT size (previously added in patch 7)  - Use X86_ namespace (as per Linux headers)  

Re: [U-Boot] [PATCH v2 15/17] x86: Move relocation code out of board.c

2012-01-07 Thread Simon Glass
Hi Graeme, On Wed, Jan 4, 2012 at 11:59 AM, Graeme Russ graeme.r...@gmail.com wrote: Signed-off-by: Graeme Russ graeme.r...@gmail.com --- Changes for v2:  - None  arch/x86/lib/Makefile   |    1 +  arch/x86/lib/board.c    |   69 +---  arch/x86/lib/relocate.c |  115

Re: [U-Boot] [PATCH v2 17/17] x86: Convert board_init_f_r to a processing loop

2012-01-07 Thread Simon Glass
Hi Graeme, On Wed, Jan 4, 2012 at 11:59 AM, Graeme Russ graeme.r...@gmail.com wrote: Create an init function array for board_init_f_r - This finalises the migration to a purely array based initialisation mechanism Also tweak a few comments while we are at it so everything is 'correct'

Re: [U-Boot] [RFC PATCH 01/19] Introduce generic global_data

2012-01-07 Thread Simon Glass
Hi Andreas, On Wed, Dec 28, 2011 at 11:47 PM, Andreas Bießmann andreas.de...@googlemail.com wrote: Dear Simon, On 28.12.11 07:35, Simon Glass wrote: We want to unify the global_data structure. Most fields are common across architectures, but there are a fair number of SOC-specific additions.

Re: [U-Boot] initcall revisited - A new idea to discuss

2012-01-07 Thread Simon Glass
Hi Gururaja, On Thu, Jan 5, 2012 at 11:25 PM, Hebbar, Gururaja gururaja.heb...@ti.com wrote: On Fri, Jan 06, 2012 at 12:05:40, Wolfgang Denk wrote: Dear Hebbar, Gururaja, [snip] _after_ the list has been created - If this breaks dependencies that's your problem ;). It is up to you as

Re: [U-Boot] [PATCH 2/9] Fix strict-aliasing warning in dlmalloc

2012-01-07 Thread Simon Glass
Hi Wolfgang, On Fri, Jan 6, 2012 at 3:37 PM, Wolfgang Denk w...@denx.de wrote: Dear Simon, In message capnjgz1oxjjsseodsm-fqtn791mw-uezqwjflqbas-4rbfh...@mail.gmail.com you wrote: Can you please tell me at least one board configuration that throws this error (preferrably ppc, arm or

Re: [U-Boot] [PATCH V3 2/2] ext4fs write support

2012-01-07 Thread Mike Frysinger
On Tuesday 27 December 2011 21:23:27 uma.shan...@samsung.com wrote: From: Uma Shankar uma.shan...@samsung.com Signed-off-by: Uma Shankar uma.shan...@samsung.com Signed-off-by: Manjunatha C Achar a.manjuna...@samsung.com Signed-off-by: Iqbal Shareef iqbal@samsung.com Signed-off-by:

Re: [U-Boot] [PATCH V3 1/2] ext4fs ls load support

2012-01-07 Thread Mike Frysinger
NAK: you missed a bunch of my previous feedback -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] Add a CBFS driver and commands to u-boot

2012-01-07 Thread Mike Frysinger
On Saturday 03 December 2011 06:47:01 Gabe Black wrote: --- /dev/null +++ b/common/cmd_cbfs.c +int do_cbfs_init(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) static + if (argc 2) { + printf(usage: cbfsls [end of rom]\n); + return 0; + }

Re: [U-Boot] [PATCH 2/2] usb/gadget: add the fastboot gadget

2012-01-07 Thread Mike Frysinger
On Monday 21 November 2011 09:09:35 Sebastian Andrzej Siewior wrote: --- a/common/Makefile +++ b/common/Makefile COBJS-y += usb.o COBJS-$(CONFIG_USB_STORAGE) += usb_storage.o endif +COBJS-$(CONFIG_CMD_FASTBOOT) += cmd_fastboot.o + COBJS-$(CONFIG_CMD_XIMG) += cmd_ximg.o no newline

Re: [U-Boot] [PATCH] Remove execute permissions from source files

2012-01-07 Thread Mike Frysinger
On Saturday 07 January 2012 00:56:32 Thomas Weber wrote: 0 files changed, 0 insertions(+), 0 deletions(-) mode change 100755 = 100644 arch/arm/cpu/armv7/imx-common/timer.c mode change 100755 = 100644 drivers/fpga/ivm_core.c mode change 100755 = 100644 include/lattice.h obvious: Acked-by:

Re: [U-Boot] [PATCH] x86: Set up the PCI busses when initializing the coreboot board

2012-01-07 Thread Mike Frysinger
On Monday 05 December 2011 17:12:30 Gabe Black wrote: --- a/board/chromebook-x86/coreboot/coreboot_pci.c +++ b/board/chromebook-x86/coreboot/coreboot_pci.c +static struct pci_config_table pci_coreboot_config_table[] = { const ? -mike signature.asc Description: This is a digitally signed

Re: [U-Boot] [PATCH 2/4] dfu: generic backend parts

2012-01-07 Thread Mike Frysinger
On Wednesday 09 November 2011 04:52:21 Andrzej Pietrasiewicz wrote: --- /dev/null +++ b/drivers/usb/dfu/Makefile +ifdef CONFIG_MMC +COBJS-y += mmc.o +endif + +ifdef CONFIG_CMD_FAT +COBJS-y += fat.o +endif COBJS-$(CONFIG_XXX) += foo.o --- /dev/null +++ b/drivers/usb/dfu/fat.c @@ -0,0

Re: [U-Boot] [PATCH v3] Add 'patman' patch generation, checking and submission script

2012-01-07 Thread Mike Frysinger
On Tuesday 29 November 2011 21:35:46 Simon Glass wrote: tools/scripts/patman/.gitignore |1 + seems like tools/patman/ would be better. i wonder if anyone else here uses it and so would be useful for actually committing ... -mike signature.asc Description: This is a digitally signed

Re: [U-Boot] [PATCH 3/4] x86: Force the lib_sysinfo structure to be in the .data section

2012-01-07 Thread Mike Frysinger
On Wednesday 30 November 2011 01:07:54 Gabe Black wrote: +struct sysinfo_t lib_sysinfo __attribute__((section(.data))); seems like it should be .data.lib_sysinfo or maybe pick a field you always init and set it to something non-zero. struct sysinfo_t lib_sysinfo = { /* force into .data

Re: [U-Boot] [PATCH 01/14] Add AES crypto library

2012-01-07 Thread Mike Frysinger
On Monday 26 December 2011 14:32:54 Simon Glass wrote: --- /dev/null +++ b/lib/aes.c +static u8 sbox[256] = { +static u8 inv_sbox[256] = { +static u8 x2_sbox[256] = { +static u8 x3_sbox[256] = { +static u8 x_time_9[256] = { +static u8 x_time_b[256] = { +static u8 x_time_d[256] = {

Re: [U-Boot] [PATCH 03/14] tegra: Add crypto library for warmboot code

2012-01-07 Thread Mike Frysinger
On Monday 26 December 2011 14:32:56 Simon Glass wrote: --- /dev/null +++ b/arch/arm/cpu/armv7/tegra2/crypto.c +#ifdef DEBUG +static void debug_print_vector(char *name, u32 num_bytes, u8 *data) +{ + u32 i; + + printf(%s [%d] @0x%08x, name, num_bytes, (u32)data); + for (i = 0;

Re: [U-Boot] [PATCH 4/7] tegra: Add I2C driver

2012-01-07 Thread Mike Frysinger
On Monday 26 December 2011 13:11:48 Simon Glass wrote: --- /dev/null +++ b/drivers/i2c/tegra2_i2c.c +static int wait_for_tx_fifo_empty(struct i2c_control *control) ... + while (timeout_us = 0) { ... + }; no semicolon here +static int wait_for_rx_fifo_notempty(struct i2c_control

Re: [U-Boot] [PATCHv2 1/8] Strip mkenvimage

2012-01-07 Thread Mike Frysinger
Acked-by: Mike Frysinger vap...@gentoo.org -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCHv3 3/8] mkenvimage: Correct the includes and add a missing one

2012-01-07 Thread Mike Frysinger
On Thursday 05 January 2012 13:44:54 David Wagner wrote: --- a/tools/mkenvimage.c +++ b/tools/mkenvimage.c +#include stdlib.h -#include compiler.h +#include compiler.h these are fine -#include u-boot/crc.h +#include u-boot/crc.h i don't think this is necessary -mike signature.asc

Re: [U-Boot] [PATCHv2 4/8] mkenvimage: More error handling

2012-01-07 Thread Mike Frysinger
On Thursday 05 January 2012 13:44:55 David Wagner wrote: --- a/tools/mkenvimage.c +++ b/tools/mkenvimage.c datasize = strtol(optarg, NULL, 0); - break; + if (!errno) + break; + +

Re: [U-Boot] [PATCHv3 5/8] mkenvimage: Read/Write from/to stdin/out by default or if the filename is -

2012-01-07 Thread Mike Frysinger
On Thursday 05 January 2012 13:44:56 David Wagner wrote: + bin_fd = creat(bin_filename, S_IRUSR | S_IWUSR | S_IRGRP | + S_IWGRP); this should prob be open() -mike signature.asc Description: This is a digitally signed message part.

Re: [U-Boot] [PATCHv2 6/8] mkenvimage: Use mmap() when reading from a regular file

2012-01-07 Thread Mike Frysinger
On Thursday 05 January 2012 13:44:57 David Wagner wrote: --- a/tools/mkenvimage.c +++ b/tools/mkenvimage.c filesize = txt_file_stat.st_size; - /* Read the raw input file and transform it */ - filebuf = malloc(sizeof(*envptr) * filesize); -

Re: [U-Boot] [PATCH v3] Add 'patman' patch generation, checking and submission script

2012-01-07 Thread Simon Glass
Hi Mike, On Sat, Jan 7, 2012 at 9:17 PM, Mike Frysinger vap...@gentoo.org wrote: On Tuesday 29 November 2011 21:35:46 Simon Glass wrote:  tools/scripts/patman/.gitignore     |    1 + seems like tools/patman/ would be better.  i wonder if anyone else here uses it and so would be useful for

Re: [U-Boot] [PATCH] tools/env: fix cross-compilation

2012-01-07 Thread Mike Frysinger
On Thursday 05 January 2012 18:25:52 Grant Erickson wrote: On Jan 5, 2012, at 3:18 PM, Mike Frysinger wrote: On Thursday 22 December 2011 13:39:35 Grant Erickson wrote: This patch fixes the make infrastructure for the fw_printenv tool such that it is built, by default, as a

Re: [U-Boot] [PATCH 2/2] api: storage: Share attributes with block_dev_desc

2012-01-07 Thread Mike Frysinger
On Friday 21 October 2011 02:31:48 Che-Liang Chiou wrote: struct device_info in api_public.h defined its own subset of attributes of block_dev_desc, which limits the capability of external apps. This patch let struct device_info and block_dev_desc share the same set of attributes so that an