[U-Boot] [PATCH 4/8] fs: add fs_readdir()

2017-08-13 Thread Rob Clark
Needed to support efi file protocol. The fallback.efi loader wants to be able to read the contents of the /EFI directory to find an OS to boot. Modelled after POSIX opendir()/readdir()/closedir(). Unlike the other fs APIs, this is stateful (ie. state is held in the FS_DIR "directory stream"),

[U-Boot] [PATCH 7/8] fat/fs: move ls to generic implementation

2017-08-13 Thread Rob Clark
Add a generic implementation of 'ls' using opendir/readdir/closedir, and replace fat's custom implementation. Other filesystems should move to the generic implementation after they add opendir/readdir/closedir support. Signed-off-by: Rob Clark --- fs/fat/fat.c | 32

Re: [U-Boot] [PATCH 8/8] fs/fat: fix case for FAT shortnames

2017-08-13 Thread Stefan Bruens
On Sonntag, 13. August 2017 12:45:28 CEST Rob Clark wrote: > Noticed when comparing our output to linux. There are some lcase bits > which control whether filename and/or extension should be downcase'd. > > Signed-off-by: Rob Clark > --- > fs/fat/fat.c | 11

[U-Boot] [PATCH] Kconfig: Add EEPROM options to Kconfig when I2C_EEPROM is set

2017-08-13 Thread Adam Ford
Add the following options to drivers/misc/Kconfig: SYS_I2C_EEPROM_ADDR SYS_I2C_EEPROM_BUS SYS_EEPROM_SIZE SYS_EEPROM_PAGE_WRITE_BITS SYS_EEPROM_PAGE_WRITE_DELAY_MS SYS_I2C_EEPROM_ADDR_LEN SYS_I2C_EEPROM_ADDR_OVERFLOW This does not migrate

Re: [U-Boot] [PATCH v3 2/3] efi_loader: open_info in OpenProtocol, CloseProtocol

2017-08-13 Thread Heinrich Schuchardt
On 08/12/2017 03:37 PM, Alexander Graf wrote: > > > On 05.08.17 22:32, Heinrich Schuchardt wrote: >> efi_open_protocol and close_protocol have to keep track of >> opened protocols. >> >> So we add an array open_info to each protocol of each handle. >> >> Cc: Rob Clark >>

Re: [U-Boot] [PATCH 2/2] sf: Preserve QE bit when clearing BP# bits for Macronix flash

2017-08-13 Thread Jagan Teki
Hi Bin, On Wed, Aug 2, 2017 at 3:56 AM, Bin Meng wrote: > Hi Jagan, > > On Wed, Aug 2, 2017 at 12:01 AM, Jagan Teki wrote: >> On Sun, Jul 23, 2017 at 8:14 PM, Bin Meng wrote: >>> On some flash (like Macronix), QE (quad enable)

[U-Boot] [PATCH 2/8] fs/fat: introduce new director iterators

2017-08-13 Thread Rob Clark
Untangle directory traversal into a simple iterator, to replace the existing multi-purpose do_fat_read_at() + get_dentfromdir(). Signed-off-by: Rob Clark --- fs/fat/fat.c | 326 +++ 1 file changed, 326 insertions(+)

[U-Boot] [PATCH 1/8] fs/fat: split out helper to init fsdata

2017-08-13 Thread Rob Clark
Want to re-use this in fat dirent iterator in next patch. Signed-off-by: Rob Clark --- fs/fat/fat.c | 73 +++ include/fat.h | 1 + 2 files changed, 44 insertions(+), 30 deletions(-) diff --git a/fs/fat/fat.c

[U-Boot] [PATCH 0/8] fs/fat: cleanups + readdir implementation

2017-08-13 Thread Rob Clark
Introduce directory traversal iterators, and implement fs_readdir() which is needed by EFI_LOADER. The part re-working fat.c to use the directory iterators itself is nearly a 2:1 negative diffstat, and a pretty big cleanup. I fixed one or two other small issues along the way. It hasn't really

Re: [U-Boot] [PATCH 6/8] fat/fs: remove a bunch of dead code

2017-08-13 Thread Stefan Bruens
On Sonntag, 13. August 2017 12:45:26 CEST Rob Clark wrote: > Spotted by chance, when trying to remove file_fat_ls(), I noticed there > were some dead users of the API. > > Signed-off-by: Rob Clark > --- > fs/fat/Makefile | 4 -- > fs/fat/file.c | 183 >

Re: [U-Boot] [PATCH 1/2] Revert "arm: omap: Unify get_device_type() function"

2017-08-13 Thread Tom Rini
On Sun, Aug 13, 2017 at 05:25:19AM +0300, Siarhei Siamashka wrote: > This reverts commit 00bbe96ebabbc83777cd8d6c6fd2791c5c8cf619. > > There were two major problems with this patch: > 1. It made OMAP3530 devices non-bootable, as reported > and investigated by Derald D. Woods in >

Re: [U-Boot] [PATCH 2/2] arm: Exercise v7_arch_cp15_set_acr even without errata fixups

2017-08-13 Thread Tom Rini
On Sun, Aug 13, 2017 at 05:25:20AM +0300, Siarhei Siamashka wrote: > By applying this patch, we are ensuring that the code paths > responsible for applying errata workarounds are also exercised > on CPU revisions, which actually don't need these workarounds. > > Only CONFIG_ARM_ERRATA_621766,

[U-Boot] [PATCH v2 1/4] test: Fix FIT test to pass again

2017-08-13 Thread Simon Glass
A recent change adjusted a test string so that the test no-longer passes. Fix it. Signed-off-by: Simon Glass Reported-by: Heiko Schocher Fixes: b28c5fcc (test-fit.py: Minor grammar/spelling/clarification tweaks) --- Changes in v2: None test/image/test-fit.py

[U-Boot] [PATCH v2 0/4] test: Port FIT test to a pytest

2017-08-13 Thread Simon Glass
We have a few tests still not part of the pytest framework. This means that they do not run automatically with 'make tests'. This series converts the FIT test to the new framework. Changes in v2: - Rebase to master Simon Glass (4): test: Fix FIT test to pass again test: Indent test-fit.py

Re: [U-Boot] [PATCH 1/6] fdtdec: allow board to provide fdt for CONFIG_OF_SEPARATE

2017-08-13 Thread Simon Glass
Hi, On 7 August 2017 at 07:54, Tom Rini wrote: > On Thu, Aug 03, 2017 at 12:48:30PM -0400, Rob Clark wrote: > >> Similar to CONFIG_OF_BOARD, but in this case the fdt is still built by >> u-boot build. This allows the board to patch the fdt, etc. >> >> In the specific case of

[U-Boot] [PATCH 3/8] fat/fs: convert to directory iterators

2017-08-13 Thread Rob Clark
And drop a whole lot of ugly code! Signed-off-by: Rob Clark --- fs/fat/fat.c | 723 ++ include/fat.h | 6 - 2 files changed, 75 insertions(+), 654 deletions(-) diff --git a/fs/fat/fat.c b/fs/fat/fat.c index

[U-Boot] [PATCH 6/8] fat/fs: remove a bunch of dead code

2017-08-13 Thread Rob Clark
Spotted by chance, when trying to remove file_fat_ls(), I noticed there were some dead users of the API. Signed-off-by: Rob Clark --- fs/fat/Makefile | 4 -- fs/fat/file.c | 183 include/fat.h | 20 --- 3

Re: [U-Boot] [PATCH] usb: kbd: don't fail with iomux (v3)

2017-08-13 Thread Rob Clark
On Sun, Aug 13, 2017 at 11:35 AM, Simon Glass wrote: > Hi Rob, > > On 6 August 2017 at 05:58, Rob Clark wrote: >> >> On Sun, Aug 6, 2017 at 1:16 AM, Simon Glass wrote: >> > On 4 August 2017 at 07:16, Bin Meng wrote:

[U-Boot] [PATCH 5/8] fs/fat: implement opendir/readdir/closedir

2017-08-13 Thread Rob Clark
Implement the readdir interface using the directory iterators. Signed-off-by: Rob Clark --- fs/fat/fat.c | 56 1 file changed, 56 insertions(+) diff --git a/fs/fat/fat.c b/fs/fat/fat.c index a50a10ba47..fe5819315b

[U-Boot] [PATCH 8/8] fs/fat: fix case for FAT shortnames

2017-08-13 Thread Rob Clark
Noticed when comparing our output to linux. There are some lcase bits which control whether filename and/or extension should be downcase'd. Signed-off-by: Rob Clark --- fs/fat/fat.c | 11 --- fs/fat/fat_write.c | 4 ++-- include/fat.h | 3 +++ 3 files

Re: [U-Boot] [PATCH 8/8] fs/fat: fix case for FAT shortnames

2017-08-13 Thread Rob Clark
On Sun, Aug 13, 2017 at 7:25 AM, Stefan Bruens wrote: > On Sonntag, 13. August 2017 12:45:28 CEST Rob Clark wrote: >> Noticed when comparing our output to linux. There are some lcase bits >> which control whether filename and/or extension should be downcase'd. >> >>

Re: [U-Boot] [PATCH 0/8] fs/fat: cleanups + readdir implementation

2017-08-13 Thread Rob Clark
On Sun, Aug 13, 2017 at 7:28 AM, Heinrich Schuchardt wrote: > On 08/13/2017 12:45 PM, Rob Clark wrote: >> Introduce directory traversal iterators, and implement fs_readdir() >> which is needed by EFI_LOADER. >> >> The part re-working fat.c to use the directory iterators

[U-Boot] [PATCH] omap3: omap3_logic: Finish enabling fastboot on MUSB

2017-08-13 Thread Adam Ford
Either the USB and Fastboot were never finished, or somehow it got lost. This puts enough hooks back into omap3logic to enable fastboot and hopefully prepare it for Kconfig conversion. Signed-off-by: Adam Ford --- board/logicpd/omap3som/omap3logic.c | 31

Re: [U-Boot] [PATCH] cmd/bdinfo: correct comment in board_detail

2017-08-13 Thread Simon Glass
On 6 August 2017 at 22:04, Chris Packham wrote: > This appears to be a simple typo that dates back to the original > implementation of board_detail in commit e79394643b26 ("common: Update > cmd_bdinfo for PPC"). > > Signed-off-by: Chris Packham >

Re: [U-Boot] [PATCH] fastboot: mmc: fix pointer size warning in 64bit system

2017-08-13 Thread Simon Glass
On 7 August 2017 at 02:14, Kever Yang wrote: > To fix warning in ARM64: > common/fb_mmc.c: In function ‘fb_mmc_update_zimage’: > common/fb_mmc.c:216:13: warning: cast from pointer to integer of > different size [-Wpointer-to-int-cast] > hdr_addr = (u32)download_buffer

[U-Boot] [PATCH v2 8/8] fs/fat: fix case for FAT shortnames

2017-08-13 Thread Rob Clark
Noticed when comparing our output to linux. There are some lcase bits which control whether filename and/or extension should be downcase'd. Signed-off-by: Rob Clark --- fs/fat/fat.c | 17 - fs/fat/fat_write.c | 4 ++-- include/fat.h | 3 +++ 3

Re: [U-Boot] [PATCH 0/8] fs/fat: cleanups + readdir implementation

2017-08-13 Thread Heinrich Schuchardt
On 08/13/2017 12:45 PM, Rob Clark wrote: > Introduce directory traversal iterators, and implement fs_readdir() > which is needed by EFI_LOADER. > > The part re-working fat.c to use the directory iterators itself is > nearly a 2:1 negative diffstat, and a pretty big cleanup. I fixed > one or two

[U-Boot] [PATCH] omap3_logic: Move CONFIG_SYS_NAND_U_BOOT_OFFS to Kconfig

2017-08-13 Thread Adam Ford
Manually enable SYS_NAND_U_BOOT_LOCATIONS. Set CONFIG_SYS_NAND_U_BOOT_OFFS=0x8 and remove it from header Signed-off-by: Adam Ford --- configs/omap3_logic_defconfig | 4 +++- include/configs/omap3_logic.h | 1 - 2 files changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [U-Boot] [PATCH 2/2] sandbox: Convert SANDBOX_BITS_PER_LONG to Kconfig

2017-08-13 Thread Simon Glass
Hi Bin, On 6 August 2017 at 03:13, Bin Meng wrote: > Hi Simon, > > On Sun, Aug 6, 2017 at 1:16 PM, Simon Glass wrote: >> Hi Bin, >> >> On 3 August 2017 at 18:17, Bin Meng wrote: >>> Hi Simon, >>> >>> On Thu, Aug 3, 2017 at 11:24 PM,

[U-Boot] [PATCH v2 4/4] test: Move the FIT test into the correct place

2017-08-13 Thread Simon Glass
Move this test so that it will run when 'make tests' is used. Signed-off-by: Simon Glass --- Changes in v2: - Rebase to master test/{image/test-fit.py => py/tests/test_fit.py} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename test/{image/test-fit.py =>

[U-Boot] [PATCH v2 2/4] test: Indent test-fit.py to match the next patch

2017-08-13 Thread Simon Glass
We plan to rewrite this script to use the pytest framework. To make it easier to review the changes, indent the code to match the next patch. This gets all of the whitespace changes out of the way. Signed-off-by: Simon Glass --- Changes in v2: None test/image/test-fit.py |

[U-Boot] [PATCH v2 3/4] test: Convert the FIT test to test/py

2017-08-13 Thread Simon Glass
Convert this test to use the pytest framework. Signed-off-by: Simon Glass --- Changes in v2: None test/image/test-fit.py | 229 +++-- 1 file changed, 88 insertions(+), 141 deletions(-) diff --git a/test/image/test-fit.py

Re: [U-Boot] [PATCH] usb: kbd: don't fail with iomux (v3)

2017-08-13 Thread Simon Glass
Hi Rob, On 6 August 2017 at 05:58, Rob Clark wrote: > > On Sun, Aug 6, 2017 at 1:16 AM, Simon Glass wrote: > > On 4 August 2017 at 07:16, Bin Meng wrote: > >> Hi Rob, > >> > >> On Fri, Aug 4, 2017 at 8:51 PM, Rob Clark

[U-Boot] [GIT PULL v2] Please pull u-boot-rockchip/master

2017-08-13 Thread Dr. Philipp Tomsich
Tom, Here’s another pull-request for u-boot-rockchip. This one shows no regressions with Travis after fixing up a few more defconfig files and adjusting the target-list when the mxs-variant of the SPL ldscript should be used. Regards, Phil. The following changes since commit

Re: [U-Boot] [PATCH v3 2/3] efi_loader: open_info in OpenProtocol, CloseProtocol

2017-08-13 Thread Alexander Graf
On 13.08.17 13:09, Heinrich Schuchardt wrote: On 08/12/2017 03:37 PM, Alexander Graf wrote: On 05.08.17 22:32, Heinrich Schuchardt wrote: efi_open_protocol and close_protocol have to keep track of opened protocols. So we add an array open_info to each protocol of each handle. Cc: Rob

[U-Boot] [PATCH] fs: fat: fix fatwrite overflow calculation

2017-08-13 Thread Reno Farnesi
The overflow calculation was incorrect. Adding the start block of the partition is not needed because the sectors are already relative to the beginning of the partition. If you attempted to write a file smaller than cur_part_info.start blocks on a full partition the old calculation fails to catch

Re: [U-Boot] [PATCH v3 3/3] efi_loader: implement OpenProtocolInformation

2017-08-13 Thread Alexander Graf
On 13.08.17 13:17, Heinrich Schuchardt wrote: On 08/12/2017 03:38 PM, Alexander Graf wrote: On 05.08.17 22:32, Heinrich Schuchardt wrote: efi_open_protocol_information provides the agent and controller handles as well as the attributes and open count of an protocol on a handle. Cc: Rob

Re: [U-Boot] [PATCH v3 3/3] efi_loader: implement OpenProtocolInformation

2017-08-13 Thread Heinrich Schuchardt
On 08/13/2017 09:24 PM, Alexander Graf wrote: > > > On 13.08.17 13:17, Heinrich Schuchardt wrote: >> On 08/12/2017 03:38 PM, Alexander Graf wrote: >>> >>> >>> On 05.08.17 22:32, Heinrich Schuchardt wrote: efi_open_protocol_information provides the agent and controller handles as well

[U-Boot] [PATCH] Makefile: honor PYTHON configuration properly

2017-08-13 Thread Clément Bœsch
--- Makefile | 2 +- tools/Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 50a002e72f..1f70144e0a 100644 --- a/Makefile +++ b/Makefile @@ -1378,7 +1378,7 @@ $(timestamp_h): $(srctree)/Makefile FORCE $(call

Re: [U-Boot] [PATCH v4 1/9] dts: renamed FIT_EMBED to MULTI_DTB_FIT and moved it to the dts Kconfig

2017-08-13 Thread Simon Glass
On 7 August 2017 at 04:07, Jean-Jacques Hiblot wrote: > CONFIG_FIT_EMBED might be confused with CONFIG_OF_EMBED, rename it > MULTI_DTB_FIT as it is able to get a DTB from a FIT image containing > multiple DTBs. Also move the option to the Kconfig dedicated to the DTS > options

Re: [U-Boot] [PATCH v4 8/9] spl: dm: Make it possible for the SPL to pick its own DTB from a FIT

2017-08-13 Thread Simon Glass
Hi Jean-Jacques, On 7 August 2017 at 04:07, Jean-Jacques Hiblot wrote: > u-boot can be embedded within a FIT image with multiple DTBs. It then > selects at run-time which one is best suited for the platform. > Use the same principle here for the SPL: put the DTBs in a FIT

Re: [U-Boot] [PATCH 3/5] vsprintf.c: add UTF-16 string (%ls) support

2017-08-13 Thread Simon Glass
On 9 August 2017 at 17:14, Rob Clark wrote: > This is convenient for efi_loader which deals a lot with UTF-16. Only > enabled with CC_SHORT_WCHAR, leaving room to add a UTF-32 version when > CC_SHORT_WCHAR is not enabled. > > Signed-off-by: Rob Clark >

Re: [U-Boot] [PATCH] usb: kbd: don't fail with iomux (v3)

2017-08-13 Thread Simon Glass
Hi Rob, On 13 August 2017 at 12:07, Rob Clark wrote: > On Sun, Aug 13, 2017 at 11:35 AM, Simon Glass wrote: >> Hi Rob, >> >> On 6 August 2017 at 05:58, Rob Clark wrote: >>> >>> On Sun, Aug 6, 2017 at 1:16 AM, Simon Glass

Re: [U-Boot] [PATCH 0/8] fs/fat: cleanups + readdir implementation

2017-08-13 Thread Rob Clark
On Sun, Aug 13, 2017 at 5:13 PM, Tom Rini wrote: > On Sun, Aug 13, 2017 at 06:45:20AM -0400, Rob Clark wrote: > >> Introduce directory traversal iterators, and implement fs_readdir() >> which is needed by EFI_LOADER. >> >> The part re-working fat.c to use the directory

Re: [U-Boot] [U-Boot, RFC, 1/1] omap3: incorrect logical check in do_emif4_init

2017-08-13 Thread Tom Rini
On Sat, Apr 15, 2017 at 04:11:12PM +0200, xypron.g...@gmx.de wrote: > ((readl(_base->sdram_iodft_tlgc) & (1<<10)) == 0x01) > is always false. > This does not match the comment > /*Wait till that bit clears*/ > > The problem was indicated by cppcheck. > > I do not have the hardware to test if

Re: [U-Boot] [U-Boot,2/8] nvme: Add NVM Express driver support

2017-08-13 Thread Tom Rini
On Thu, Aug 03, 2017 at 02:30:57AM -0700, Bin Meng wrote: > From: Zhikang Zhang > > NVM Express (NVMe) is a register level interface that allows host > software to communicate with a non-volatile memory subsystem. This > interface is optimized for enterprise and client

Re: [U-Boot] [U-Boot, 5/8] nvme: Detect devices that are class Storage Express

2017-08-13 Thread Tom Rini
On Thu, Aug 03, 2017 at 02:31:00AM -0700, Bin Meng wrote: > From: Jon Nettleton > > This adds support to detect the catchall PCI class for NVMe devices. > It allows the drivers to work with most NVMe devices that don't need > specific detection due to quirks etc. > > Tested

Re: [U-Boot] [U-Boot, 1/1] arm: mvebu: ddr3_debug: remove self assignments

2017-08-13 Thread Tom Rini
On Sun, Jul 30, 2017 at 09:54:56PM +0200, xypron.g...@gmx.de wrote: > Remove superfluous self assignements. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Stefan Roese Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital

Re: [U-Boot] [U-Boot,1/1] armv7m: mpu_config add missing break

2017-08-13 Thread Tom Rini
On Sun, Jul 30, 2017 at 08:34:20PM +0200, xypron.g...@gmx.de wrote: > For DEVICE_NON_SHARED the newly assigned value of attr > is overwritten due to a missing break. > > The problem was indicated by cppcheck. > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master,

Re: [U-Boot] [U-Boot, 1/1] bcm281xx: clock: avoid possible NULL dereference

2017-08-13 Thread Tom Rini
On Sun, Jul 30, 2017 at 08:27:16PM +0200, xypron.g...@gmx.de wrote: > It does not make sense first to dereference c and then > to check if it is NULL. > > The problem was indicated by cppcheck. > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! --

Re: [U-Boot] [U-Boot,1/1] tpm: add missing va_end

2017-08-13 Thread Tom Rini
On Sun, Jul 30, 2017 at 09:40:37PM +0200, xypron.g...@gmx.de wrote: > va_start must always be matched by va_end. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description:

Re: [U-Boot] [U-Boot, 3/8] nvme: Add show routine to print detailed information

2017-08-13 Thread Tom Rini
On Thu, Aug 03, 2017 at 02:30:58AM -0700, Bin Meng wrote: > From: Zhikang Zhang > > This adds nvme_print_info() to show detailed NVMe controller and > namespace information. > > Signed-off-by: Zhikang Zhang > Signed-off-by: Wenbin Song

[U-Boot] [Patch v2] QE: Set QE_IRAM_READY after uploading firmware

2017-08-13 Thread Zhao Qiang
QE_IRAM_READY should be set only after successfully uploading the firmware. Signed-off-by: Zhao Qiang --- Changes for v2: - modify commit msg to make it more understandable drivers/qe/qe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [U-Boot] [PATCH 0/8] fs/fat: cleanups + readdir implementation

2017-08-13 Thread Tom Rini
On Sun, Aug 13, 2017 at 06:45:20AM -0400, Rob Clark wrote: > Introduce directory traversal iterators, and implement fs_readdir() > which is needed by EFI_LOADER. > > The part re-working fat.c to use the directory iterators itself is > nearly a 2:1 negative diffstat, and a pretty big cleanup. I

Re: [U-Boot] [PATCH v2 3/5] spl: fit: Eanble GZIP support for image decompression

2017-08-13 Thread Simon Glass
Hi York, On 7 August 2017 at 17:16, York Sun wrote: > Add Kconfig option SPL_GZIP and SPL_ZLIB to enable gunzip support for > SPL boot, eg. falcon boot compressed kernel image. > > Signed-off-by: York Sun > > --- > > Changes in v2: > Combine Kconfig change

Re: [U-Boot] [PATCH] common:usb_kbd:Add key values of F1~F12

2017-08-13 Thread Simon Glass
Hi, On 9 August 2017 at 04:33, Dr. Philipp Tomsich wrote: > >> On 08 Aug 2017, at 03:27, Leo Wen wrote: >> >> When you press the F1~F12 button from the USB keyboard, the reference Fn >> key table(usb_kbd_fn_key[]),the key

Re: [U-Boot] [PATCH v2 3/6] power: as3722: fix ldo_get/set_enable for ldo index bigger than 7

2017-08-13 Thread Simon Glass
On 8 August 2017 at 06:42, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > Fix ldo_get_enable() and ldo_set_enable() functions for LDOs with an > index > 7. Turns out there are actually two separate AS3722_LDO_CONTROL > registers

Re: [U-Boot] [PATCH 3/3] rockchip: rk3399: enable preboot for boot mode detect

2017-08-13 Thread Simon Glass
On 9 August 2017 at 04:18, Kever Yang wrote: > We need to get into preboot once we detect that we are not > get into normal boot. > > Signed-off-by: Kever Yang > --- > > include/configs/rk3399_common.h | 2 ++ > 1 file changed, 2

Re: [U-Boot] [PATCH 1/3] apalis_t30: describe pcie ports

2017-08-13 Thread Simon Glass
On 8 August 2017 at 06:43, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > Add some more comments describing the various PCIe ports available. > > Signed-off-by: Marcel Ziswiler > --- > >

Re: [U-Boot] [PATCH v2] dm: core: also parse chosen node

2017-08-13 Thread Simon Glass
Hi Rob, On 7 August 2017 at 13:55, Rob Clark wrote: > This is the node that would contain, for example, the framebuffer setup > by an earlier stage. > > Signed-off-by: Rob Clark > --- > v2: simplify a bit (and fix incorrect handling of pre_reloc_only)

Re: [U-Boot] [PATCH 1/3] rockchip: rk3399: detect boot mode

2017-08-13 Thread Simon Glass
On 9 August 2017 at 04:18, Kever Yang wrote: > U-Boot fastboot, kernel may reboot with parameter which require > bootloader to get into different boot mode, detect it and enter > proper mode. > > Signed-off-by: Kever Yang > --- > >

Re: [U-Boot] [PATCH 0/8] fs/fat: cleanups + readdir implementation

2017-08-13 Thread Tom Rini
On Sun, Aug 13, 2017 at 05:50:39PM -0400, Rob Clark wrote: > On Sun, Aug 13, 2017 at 5:13 PM, Tom Rini wrote: > > On Sun, Aug 13, 2017 at 06:45:20AM -0400, Rob Clark wrote: > > > >> Introduce directory traversal iterators, and implement fs_readdir() > >> which is needed by

Re: [U-Boot] [PATCH 2/2] sf: Preserve QE bit when clearing BP# bits for Macronix flash

2017-08-13 Thread Bin Meng
Hi Jagan, On Mon, Aug 14, 2017 at 1:22 AM, Jagan Teki wrote: > Hi Bin, > > On Wed, Aug 2, 2017 at 3:56 AM, Bin Meng wrote: >> Hi Jagan, >> >> On Wed, Aug 2, 2017 at 12:01 AM, Jagan Teki wrote: >>> On Sun, Jul 23, 2017 at

Re: [U-Boot] [PATCH v3 3/3] efi_loader: implement OpenProtocolInformation

2017-08-13 Thread Alexander Graf
On 13.08.17 21:32, Heinrich Schuchardt wrote: On 08/13/2017 09:24 PM, Alexander Graf wrote: On 13.08.17 13:17, Heinrich Schuchardt wrote: On 08/12/2017 03:38 PM, Alexander Graf wrote: On 05.08.17 22:32, Heinrich Schuchardt wrote: efi_open_protocol_information provides the agent and

Re: [U-Boot] [PATCH 1/3] configs: rockchip: add USB configs for evb-rv1108 board

2017-08-13 Thread Simon Glass
On 8 August 2017 at 21:36, William Wu wrote: > This patch adds USB configs to support the USB OTG port(consist > of DWC2 controller) and the USB Host port(consist of EHCI and OHCI > controllers) on evb-rv1108 board, and also support fastboot over > USB and USB mass

Re: [U-Boot] [PATCH v2 1/2] dm: core: add clocks node scan

2017-08-13 Thread Simon Glass
+Rob Clark who is doing a similar thing with the /chosen node Hi Patrice, On 8 August 2017 at 06:34, wrote: > From: Patrice Chotard > > Currently, all fixed-clock declared in "clocks" node in device tree > can be binded by clk_fixed_rate.c

Re: [U-Boot] [PATCH 3/3] rockchip: evb-rv1108: add usb init function for dwc2 gadget

2017-08-13 Thread Simon Glass
On 8 August 2017 at 21:36, William Wu wrote: > This patch implements board_usb_init() for dwc2 gadget, it > generally called from do_fastboot to do dwc2 udc probe and > support fastboot over USB. > > Signed-off-by: William Wu > --- >

Re: [U-Boot] [PATCH] rockchip: dts: rk3399-evb: remove redundant gmac node

2017-08-13 Thread Simon Glass
On 9 August 2017 at 04:51, Kever Yang wrote: > There are two same gmac node, remove one. > > Signed-off-by: Kever Yang > --- > > arch/arm/dts/rk3399-evb.dts | 16 > 1 file changed, 16 deletions(-) > Reviewed-by: Simon Glass

Re: [U-Boot] [PATCH] fs: add fs_readdir()

2017-08-13 Thread Simon Glass
Hi Rob, On 10 August 2017 at 12:13, Rob Clark wrote: > On Sun, Aug 6, 2017 at 1:16 AM, Simon Glass wrote: >> Hi Rob, >> >> On 3 August 2017 at 13:36, Rob Clark wrote: >>> On Thu, Aug 3, 2017 at 3:10 PM, Brüns, Stefan >>>

Re: [U-Boot] [PATCH 07/12] scripts: spl: Disable DM MMC when SPL DM not enabled

2017-08-13 Thread Simon Glass
Hi Peng, On 9 August 2017 at 03:16, Peng Fan wrote: > Disable DM MMC when SPL DM not enabled. > > Signed-off-by: Peng Fan > Cc: Stefano Babic > Cc: Simon Glass > --- > scripts/Makefile.uncmd_spl | 1 + > 1 file changed, 1

Re: [U-Boot] [PATCH] rockchip: enable rk322x sysreset driver

2017-08-13 Thread Simon Glass
On 9 August 2017 at 05:10, Kever Yang wrote: > The sysreset driver for rk322x is ready but not enabled, > add it to Makefile to make sure it's enabled. > > Signed-off-by: Kever Yang > --- > > drivers/sysreset/Makefile | 1 + > 1 file

Re: [U-Boot] [PATCH] rockchip: rk322x: enable fastboot to set boot mode tag

2017-08-13 Thread Simon Glass
On 9 August 2017 at 05:28, Kever Yang wrote: > To support fastboot "fastboot reboot-bootloader" cmd. > > Signed-off-by: Kever Yang > --- > > arch/arm/mach-rockchip/rk322x-board.c | 15 +++ > 1 file changed, 15 insertions(+)

[U-Boot] [PATCH] Makefile: honor PYTHON configuration properly

2017-08-13 Thread Clément Bœsch
On some systems `python` is `python3` (for instance, Archlinux). The `PYTHON` variable can be used to point to `python2` to have a successful build. The use of `PYTHON` is currently limited in the Makefile and needs to be extended to at 2 other cases: First, pylibfdt is required to be a Python 2

Re: [U-Boot] [U-Boot, 1/1] arm: bcm235xx: avoid possible NULL dereference

2017-08-13 Thread Tom Rini
On Sun, Jul 30, 2017 at 08:15:51PM +0200, xypron.g...@gmx.de wrote: > It does not make sense to first dereference c and then > check if it is NULL. > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital

Re: [U-Boot] [U-Boot,1/1] api: remove superfluous assignment

2017-08-13 Thread Tom Rini
On Sun, Jul 30, 2017 at 07:54:37PM +0200, xypron.g...@gmx.de wrote: > No need to assign a value to sig if the next statement using sig > is itself an assignment of a value to sig. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Simon Glass Applied

Re: [U-Boot] [U-Boot, 1/1] arm: spear: do not return random value from stack

2017-08-13 Thread Tom Rini
On Sun, Jul 30, 2017 at 08:09:38PM +0200, xypron.g...@gmx.de wrote: > If the NOR device is not available do not return > a random value from the stack. > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital

Re: [U-Boot] [U-Boot, 1/1] arm: mvebu: avoid possible NULL dereference

2017-08-13 Thread Tom Rini
On Sun, Jul 30, 2017 at 08:40:43PM +0200, xypron.g...@gmx.de wrote: > It does not make sense to check if info is NULL after > dereferencing it. > > The problem was indicated by cppcheck. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Stefan Roese

Re: [U-Boot] [U-Boot, 1/1] arm: bcm235xx: clk_set_rate avoid possible NULL deref

2017-08-13 Thread Tom Rini
On Sun, Jul 30, 2017 at 08:22:47PM +0200, xypron.g...@gmx.de wrote: > It does not make sense first to dereference c and then > to check if it is NULL. > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital

[U-Boot] Test Environment

2017-08-13 Thread Duncan Hare
1. Try to build the u-boot test environment with the command: ./test/py/test.py --bd sandbox --build Get the error ../include/image.h:1019:27: fatal error: openssl/evp.h: No such file or directory # include   2. Does the Sandbox support the dhcp, tftp and nfs commands so they can go over the

Re: [U-Boot] [PATCH v2] wdt: Update uclass to make clear that the timeout is in ms

2017-08-13 Thread Simon Glass
Hi Maxim, On 7 August 2017 at 11:54, Maxim Sloyko wrote: > On Fri, Aug 4, 2017 at 2:48 PM, Simon Glass wrote: >> From: Andy Shevchenko >> >> Convert name to show explicitly that we are using milliseconds. For a >>

Re: [U-Boot] [PATCH 02/12] power: pmic/regulator allow dm be omited by SPL

2017-08-13 Thread Simon Glass
On 9 August 2017 at 03:16, Peng Fan wrote: > Allow the dm driver be omited by SPL. > > Signed-off-by: Peng Fan > Cc: Jaehoon Chung > Cc: Simon Glass > Cc: Keerthy > Cc: Minkyu Kang

Re: [U-Boot] [PATCH v2 4/5] spl: fit: Support both external and embedded data

2017-08-13 Thread Simon Glass
Hi York, On 7 August 2017 at 17:16, York Sun wrote: > SPL supports U-Boot image in FIT format which has data outside of > FIT structure. This adds support for embedded data for normal FIT > images. > > Signed-off-by: York Sun > > --- > > Changes in v2: >

Re: [U-Boot] [U-Boot, v4, 60/66] rockchip: Kconfig: preset TPL_LDSCRIPT via Kconfig for the RK3368

2017-08-13 Thread Simon Glass
+Philipp On 9 August 2017 at 15:45, Masahiro Yamada wrote: > Hi. > > > 2017-08-07 23:05 GMT+09:00 Tom Rini : >> On Mon, Aug 07, 2017 at 10:48:12AM +0200, Dr. Philipp Tomsich wrote: >>> +Tom >>> >>> Ok, so the problem is

Re: [U-Boot] [UBOOT] [PATCH] cmd: usb: ignore block devices under mass storage device

2017-08-13 Thread Simon Glass
Hi Suneel, On 10 August 2017 at 23:53, Suneel Garapati wrote: > usb tree and info commands may cause crash otherwise > > Signed-off-by: Suneel Garapati > --- > cmd/usb.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > Thank you

Re: [U-Boot] [PATCH v4 1/1] mmc: Add MMC support for stm32h7 Socs

2017-08-13 Thread Simon Glass
On 11 August 2017 at 08:35, wrote: > From: Patrice Chotard > > This patch adds SD/MMC support for STM32H7 SoCs. > > Here is an extraction of SDMMC main features, embedded in > STM32H7 SoCs. > The SD/MMC block include the following: > _ Full

Re: [U-Boot] rk3288: 32KB SPL size restriction

2017-08-13 Thread Simon Glass
Hi Jagan, On 10 August 2017 at 03:07, Jagan Teki wrote: > Hi Simon/Philipp or any, > > I believe rk3288 has 20KB BootRom and 100KB internal SRAM and current > u-boot can archive the maximum size of u-boot-spl-dtb.bin which the > boot ROM will read is 32KB, do we have

Re: [U-Boot] [PATCH 2/5] lib: add some utf16 handling helpers

2017-08-13 Thread Simon Glass
Hi Rob, On 9 August 2017 at 17:14, Rob Clark wrote: > We'll eventually want these in a few places in efi_loader, and also > vsprintf. > > Signed-off-by: Rob Clark > --- > include/charset.h| 55 ++ > lib/Makefile

Re: [U-Boot] [patch v2 10/13] power: pmic.h: include dm/ofnode.h

2017-08-13 Thread Simon Glass
On 9 August 2017 at 06:52, Peng Fan wrote: > Include dm/ofnode.h. > > Signed-off-by: Peng Fan > Cc: Simon Glass > Cc: Stefano Babic > --- > include/power/pmic.h | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Simon

Re: [U-Boot] [PATCH 5/6] moveconfig: Support building a simple config database

2017-08-13 Thread Simon Glass
Hi Chris, On 16 May 2017 at 00:58, Chris Packham wrote: > > > On 15/05/2017 11:47 PM, "Simon Glass" wrote: > > Add a -b option which scans all the defconfigs and builds a database of > all the CONFIG options used by each. This is useful for querying

Re: [U-Boot] [U-Boot,1/1] stm32: remove redundant 'else if'

2017-08-13 Thread Tom Rini
On Sun, Jul 30, 2017 at 08:46:05PM +0200, xypron.g...@gmx.de wrote: > The if in the else branch is superfluous. > We can use a simple if. > > The problem was indicated by cppcheck. > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom

Re: [U-Boot] [U-Boot, 2/2] ARM: OMAP5: Enable support for AVS0 for OMAP5 production devices

2017-08-13 Thread Tom Rini
On Fri, Aug 04, 2017 at 09:42:09PM -0500, Nishanth Menon wrote: > OMAP5432 did go into production with AVS class0 registers which were > mutually exclusive from AVS Class 1.5 registers. > > Most OMAP5-uEVM boards use the pre-production Class1.5 which has > production efuse registers set to 0.

Re: [U-Boot] boot_fit: Change return value from FDT_ERROR to -EINVAL in fdt_offset()

2017-08-13 Thread Tom Rini
On Sat, Aug 05, 2017 at 05:47:02AM +0900, Nobuhiro Iwamatsu wrote: > FDT_ERROR is defined as unsigned long. However, since the return value of > fdt_offset() is int, a warning will occur when compiling. Also, it is better > to use -EINVAL than FDT_ERROR. > This fixes this problem by change return

Re: [U-Boot] [U-Boot, 3/3] test: Move the FIT test into the correct place

2017-08-13 Thread Tom Rini
On Sat, Aug 05, 2017 at 10:28:41AM -0600, Simon Glass wrote: > Move this test so that it will run when 'make tests' is used. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature

Re: [U-Boot] [U-Boot,1/1] arm: mvebu: remove self assignment

2017-08-13 Thread Tom Rini
On Sun, Jul 30, 2017 at 09:51:05PM +0200, xypron.g...@gmx.de wrote: > Assigning dev_num to itself is superfluous. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Stefan Roese Applied to u-boot/master, thanks! -- Tom signature.asc Description:

Re: [U-Boot] [U-Boot, 1/3] test: Indent test-fit.py to match the next patch

2017-08-13 Thread Tom Rini
On Sat, Aug 05, 2017 at 10:28:39AM -0600, Simon Glass wrote: > We plan to rewrite this script to use the pytest framework. To make it > easier to review the changes, indent the code to match the next patch. > This gets all of the whitespace changes out of the way. > > Signed-off-by: Simon Glass

Re: [U-Boot] [PATCH 03/12] Makefile: build FIT image if CONFIG_SPL_FIT_GENERATOR defined

2017-08-13 Thread Peng Fan
Hi Simon, > -Original Message- > From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon Glass > Sent: Monday, August 14, 2017 5:37 AM > To: Peng Fan > Cc: Stefano Babic ; Peng Fan ; U- > Boot Mailing List

Re: [U-Boot] [PATCH v2 2/2] dm: test: replace dm_scan_dt() by of dm_extended_scan_fdt() in dm_do_test

2017-08-13 Thread Simon Glass
On 8 August 2017 at 06:34, wrote: > From: Patrice Chotard > > This allows to scan the DT including all "clocks" node's sub-nodes > in which fixed-clock are defined. > All fixed-clock should be defined inside a clocks node which collect all >

Re: [U-Boot] [PATCH v2 1/1] i2c: add i2c driver for stm32

2017-08-13 Thread Simon Glass
On 9 August 2017 at 06:45, wrote: > From: Patrice Chotard > > Add i2c driver which can be used on both STM32F7 and STM32H7. > This I2C block supports the following features: > _ Slave and master modes > _ Multimaster capability > _

Re: [U-Boot] cmd/bdinfo: correct comment in board_detail

2017-08-13 Thread Tom Rini
On Mon, Aug 07, 2017 at 04:04:14PM +1200, Chris Packham wrote: > This appears to be a simple typo that dates back to the original > implementation of board_detail in commit e79394643b26 ("common: Update > cmd_bdinfo for PPC"). > > Signed-off-by: Chris Packham Applied

Re: [U-Boot] [U-Boot,2/2] Convert CONFIG_OMAP3_SPI to Kconfig

2017-08-13 Thread Tom Rini
On Wed, Jul 26, 2017 at 10:25:30PM -0500, Adam Ford wrote: > This converts the following to Kconfig: >CONFIG_OMAP3_SPI > > Signed-off-by: Adam Ford > > diff --git a/configs/am335x_baltos_defconfig b/configs/am335x_baltos_defconfig > index 09e028f..aa16b25 100644

  1   2   >