Re: [U-Boot] What can cause gpio_request return negative value

2019-08-15 Thread Adam Ford
On Thu, Aug 15, 2019 at 7:46 AM Nemanja Savic wrote: > > Hi all, > > I am struggling with porting our old board init code for a sabre auto based > custom board with i.MX6 DualLite processor. The code used to work in our > older u-boot version, but what I saw in mx6qsabreauto.c is that the new >

[U-Boot] [PATCH 2/8] usb: r8a66597: Make CONFIG_RZA_USB default

2019-08-15 Thread Marek Vasut
No other platforms use this r8a66597 controller but RZ/A1, make RZ/A1 support the default and drop all the other SoC support to remove ifdeffery. Signed-off-by: Marek Vasut Cc: Chris Brandt --- drivers/usb/host/r8a66597-hcd.c | 35 - drivers/usb/host/r8a66597.h

[U-Boot] [PATCH 1/8] usb: r8a66597: Remove CONFIG_SUPERH_ON_CHIP_R8A66597

2019-08-15 Thread Marek Vasut
Remove CONFIG_SUPERH_ON_CHIP_R8A66597 macro, which is unused. Signed-off-by: Marek Vasut Cc: Chris Brandt --- drivers/usb/host/r8a66597-hcd.c | 14 -- drivers/usb/host/r8a66597.h | 12 ++-- 2 files changed, 2 insertions(+), 24 deletions(-) diff --git

[U-Boot] [PATCH 3/8] usb: r8a66597: Replace IO accessors

2019-08-15 Thread Marek Vasut
Replace in{bwl}()/out{bwl}() IO accessors with read{bwl}()/write{bwl}(), to make the driver compile both on SH and ARM. Signed-off-by: Marek Vasut Cc: Chris Brandt --- drivers/usb/host/r8a66597.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

Re: [U-Boot] [EXT] Re: [PATCH v4 1/5] spl: dm: disable SPI DM flash for non-DM SPL

2019-08-15 Thread Lukasz Majewski
On Thu, 15 Aug 2019 07:39:45 + Chuanhua Han wrote: > > -Original Message- > > From: Lukasz Majewski > > Sent: 2019年8月15日 15:15 > > To: Chuanhua Han > > Cc: Jagan Teki ; Xiaowei Bao > > ; U-Boot-Denx ; Pan > > Jiafei ; Jagan Teki ; > > Ruchika Gupta > > Subject: Re: [U-Boot] [EXT]

Re: [U-Boot] kernel-doc vs Doxygen

2019-08-15 Thread Tom Rini
On Wed, Aug 14, 2019 at 09:16:40PM +0300, Sam Protsenko wrote: > Hi everyone, > > Quick question: which comment style is allowed in U-Boot, kernel-doc > or Doxygen one? I have noticed that both are used currently (and I've > sent some patches with doxy comments myself). Please tell me if >

Re: [U-Boot] What can cause gpio_request return negative value

2019-08-15 Thread Nemanja Savic
And to be more precise inside gpio-uclass.c, the function gpio_to_device which is called by gpio_request loops through all gpio objects in order to search for the gpio number provided never loops in my case. puts("gpio-uclass"); for (ret = uclass_first_device(UCLASS_GPIO, ); dev; ret =

[U-Boot] What can cause gpio_request return negative value

2019-08-15 Thread Nemanja Savic
Hi all, I am struggling with porting our old board init code for a sabre auto based custom board with i.MX6 DualLite processor. The code used to work in our older u-boot version, but what I saw in mx6qsabreauto.c is that the new style is by using new driver model which means the gpio should be

Re: [U-Boot] What can cause gpio_request return negative value

2019-08-15 Thread Nemanja Savic
It return -2 which should be -ENOENT. In the comment at the end of gpio_to_device() it is written "No such GPIO". Are there any prerequisites before calling gpio_request regarding device tree or something else? On Thu, Aug 15, 2019 at 3:09 PM Adam Ford wrote: > On Thu, Aug 15, 2019 at 7:46 AM

Re: [U-Boot] [PATCH 1/4 v5] watchdog: Implement generic watchdog_reset() version

2019-08-15 Thread Bin Meng
Hi Stefan, On Thu, Aug 15, 2019 at 2:07 PM Stefan Roese wrote: > > Hi Simon, > > On 14.08.19 21:35, Simon Glass wrote: > > Hi, > > > > On Wed, 14 Aug 2019 at 00:22, Stefan Roese wrote: > >> > >> Hi Simon, > >> > >> (added Simon Glass and Bin to Cc) > >> > >> On 13.08.19 22:16, Simon Goldschmidt

Re: [U-Boot] [PATCH v2] arm: socfpga: gen5: don't zero bss in board_init_f()

2019-08-15 Thread Marek Vasut
On 8/14/19 8:56 PM, Simon Goldschmidt wrote: > Marek, > > Am 12.07.2019 um 20:03 schrieb Simon Goldschmidt: >> The socfpga gen5 SPL manually zeroed bss in board_init_f(). Now that the >> DDR driver does not use bss any more, bss is not used before >> board_init_r() >> and we can remove this hack.

Re: [U-Boot] [PATCH] global_data: Move x86 specific GD flags into common flags

2019-08-15 Thread Stefan Roese
Hi Simon, On 15.08.19 09:35, Simon Goldschmidt wrote: Hi Stefan, On Thu, Aug 15, 2019 at 9:05 AM Stefan Roese wrote: Currently the upper 16 bits of the GD flags are reserved for architecture specific flags. But only x86 uses 2 bits of these 16 bits and sprinkling those flags in multiple

Re: [U-Boot] [PATCH 1/4 v5] watchdog: Implement generic watchdog_reset() version

2019-08-15 Thread Stefan Roese
Hi Simon, On 14.08.19 21:35, Simon Glass wrote: Hi, On Wed, 14 Aug 2019 at 00:22, Stefan Roese wrote: Hi Simon, (added Simon Glass and Bin to Cc) On 13.08.19 22:16, Simon Goldschmidt wrote: Am 25.04.2019 um 09:17 schrieb Stefan Roese: This patch tries to implement a generic

Re: [U-Boot] [PATCH v2 3/6] cbfs: Move static variables into a struct

2019-08-15 Thread Bin Meng
On Thu, Aug 15, 2019 at 9:56 AM Simon Glass wrote: > > At present there are a number of static variables in BSS. This cannot work > with SPL, at least until BSS is available in board_init_r(). > > Move the variables into a struct, so it is possible to malloc() it and use > it before BSS is

Re: [U-Boot] [PATCH] global_data: Move x86 specific GD flags into common flags

2019-08-15 Thread Bin Meng
On Thu, Aug 15, 2019 at 3:05 PM Stefan Roese wrote: > > Currently the upper 16 bits of the GD flags are reserved for > architecture specific flags. But only x86 uses 2 bits of these 16 bits > and sprinkling those flags in multiple headers is confusing and does not > scale. > > This patch now

Re: [U-Boot] [PATCH] global_data: Move x86 specific GD flags into common flags

2019-08-15 Thread Simon Goldschmidt
Hi Stefan, On Thu, Aug 15, 2019 at 9:05 AM Stefan Roese wrote: > > Currently the upper 16 bits of the GD flags are reserved for > architecture specific flags. But only x86 uses 2 bits of these 16 bits > and sprinkling those flags in multiple headers is confusing and does not > scale. > > This

Re: [U-Boot] [PATCH v4 2/2] board: Add support for iMX8QXP AI_ML board

2019-08-15 Thread Lukasz Majewski
Hi Manivannan, > Hi Lukasz, > > Thanks for the review! > > On Wed, Jul 24, 2019 at 10:07:13AM +0200, Lukasz Majewski wrote: > > Hi Manivannan, > > > > > This commit adds initial board support for iMX8QXP AI_ML board > > > from Einfochips. This board is one of the 96Boards Consumer > > >

[U-Boot] [PATCH v3] ram: rk3399: update cap and ddrconfig for each channel after init

2019-08-15 Thread Kever Yang
We need to store all the ram related cap/map info back to register for each channel after all the init has been done in case some of register was reset during the process. Signed-off-by: YouMin Chen Signed-off-by: Kever Yang --- Changes in v3: - update commit message Changes in v2: - fix

Re: [U-Boot] [EXT] Re: [PATCH v4 1/5] spl: dm: disable SPI DM flash for non-DM SPL

2019-08-15 Thread Lukasz Majewski
On Thu, 15 Aug 2019 07:57:00 + Chuanhua Han wrote: > > -Original Message- > > From: Lukasz Majewski > > Sent: 2019年8月15日 15:54 > > To: Chuanhua Han > > Cc: Jagan Teki ; Xiaowei Bao > > ; U-Boot-Denx ; Pan > > Jiafei ; Jagan Teki ; > > Ruchika Gupta > > Subject: Re: [U-Boot] [EXT]

Re: [U-Boot] [PATCH v4 2/2] board: Add support for iMX8QXP AI_ML board

2019-08-15 Thread Lukasz Majewski
On Thu, 15 Aug 2019 13:46:30 +0530 Manivannan Sadhasivam wrote: > Hi Lukasz, > > On Thu, Aug 15, 2019 at 09:51:25AM +0200, Lukasz Majewski wrote: > > Hi Manivannan, > > > > > Hi Lukasz, > > > > > > Thanks for the review! > > > > > > On Wed, Jul 24, 2019 at 10:07:13AM +0200, Lukasz Majewski

[U-Boot] [PATCH v4 1/2] disk: update to use SPL_PARTITIONS for SPL

2019-08-15 Thread Kever Yang
The SPL disk driver can not depends on SPL_FRAMEWORK & PARTITIONS, which will enable the disk driver when we actually not need it. Use a separate Kconfig to control the partition driver in SPL and fix the issue caused by: Fixes: 91ff686562 ("blk: Rework guard around part_init call")

Re: [U-Boot] [PATCH] Convert CONFIG_ARCH_CPU_INIT to Kconfig

2019-08-15 Thread Chris Packham
Hi Adam, On Wed, 2019-08-14 at 08:29 -0500, Adam Ford wrote: > This converts the following to Kconfig: >    CONFIG_ARCH_CPU_INIT > > Signed-off-by: Adam Ford For SBx81LIFKW, SBx81LIFXCAT, db-88f6281-bp, db-88f6820-amc, db-xc3- 24g4xg and x530 Acked-by: Chris Packham

Re: [U-Boot] [EXT] Re: [PATCH v4 1/5] spl: dm: disable SPI DM flash for non-DM SPL

2019-08-15 Thread Lukasz Majewski
On Thu, 15 Aug 2019 03:35:28 + Chuanhua Han wrote: > > -Original Message- > > From: Lukasz Majewski > > Sent: 2019年8月14日 19:39 > > To: Chuanhua Han > > Cc: Jagan Teki ; Xiaowei Bao > > ; U-Boot-Denx ; Pan > > Jiafei ; Jagan Teki ; > > Ruchika Gupta > > Subject: Re: [U-Boot] [EXT]

Re: [U-Boot] [PATCH v4 2/2] board: Add support for iMX8QXP AI_ML board

2019-08-15 Thread Manivannan Sadhasivam
Hi Lukasz, Thanks for the review! On Wed, Jul 24, 2019 at 10:07:13AM +0200, Lukasz Majewski wrote: > Hi Manivannan, > > > This commit adds initial board support for iMX8QXP AI_ML board from > > Einfochips. This board is one of the 96Boards Consumer Edition and AI > > boards of the 96Boards

Re: [U-Boot] [EXT] Re: [PATCH v4 1/5] spl: dm: disable SPI DM flash for non-DM SPL

2019-08-15 Thread Chuanhua Han
> -Original Message- > From: Lukasz Majewski > Sent: 2019年8月15日 15:54 > To: Chuanhua Han > Cc: Jagan Teki ; Xiaowei Bao > ; U-Boot-Denx ; Pan Jiafei > ; Jagan Teki ; Ruchika > Gupta > Subject: Re: [U-Boot] [EXT] Re: [PATCH v4 1/5] spl: dm: disable SPI DM flash > for > non-DM SPL > >

[U-Boot] [PATCH v5 2/2] board: Add support for iMX8QXP AI_ML board

2019-08-15 Thread Manivannan Sadhasivam
This commit adds initial board support for iMX8QXP AI_ML board from Einfochips. This board is one of the 96Boards Consumer Edition and AI boards of the 96Boards family based on i.MX8QXP SoC from NXP/Freescale. This initial supports contains following peripherals which are tested and known to

[U-Boot] [PATCH v2] arm: baltos: switch to driver model for the watchdog timer

2019-08-15 Thread yegorslists
From: Yegor Yefremov Signed-off-by: Yegor Yefremov --- Changes v1 -> v2: rebased to include the ported omap_wdt driver configs/am335x_baltos_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/am335x_baltos_defconfig b/configs/am335x_baltos_defconfig index

Re: [U-Boot] 答复: [PATCH v2 2/4] USB: host: Add the USB3 host driver

2019-08-15 Thread Marek Vasut
On 8/15/19 3:38 AM, Sherry Sun wrote: > Hi Marek, > >> >> On 8/14/19 2:16 PM, sherry sun wrote: >>> From: Sherry Sun >>> >>> Add the USB3 host driver for NXP imx8 platform, and the cadence IP is >>> in it. The USB3 host driver support DM mode, it will probe USB3 host >>> node in dts. >> >> We

[U-Boot] [PATCH] global_data: Move x86 specific GD flags into common flags

2019-08-15 Thread Stefan Roese
Currently the upper 16 bits of the GD flags are reserved for architecture specific flags. But only x86 uses 2 bits of these 16 bits and sprinkling those flags in multiple headers is confusing and does not scale. This patch now moves the x86 flags into the common header and removes the comment

[U-Boot] [PATCH 1/4] rockchip: clk: rk3328: add clk_enable ops for HCLK_HOST0

2019-08-15 Thread Kever Yang
Required to successfully probe the ehci generic driver Signed-off-by: Kever Yang --- drivers/clk/rockchip/clk_rk3328.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/clk/rockchip/clk_rk3328.c b/drivers/clk/rockchip/clk_rk3328.c index a89e2ecc4a..5957a00402 100644

[U-Boot] [PATCH 2/4] rockchip: dts: rk3328-rock64: enable usb3 xhci controller

2019-08-15 Thread Kever Yang
Rock64 has a USB3.0 port, enable the controller so that we can use it. Signed-off-by: Kever Yang --- arch/arm/dts/rk3328-rock64-u-boot.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/dts/rk3328-rock64-u-boot.dtsi b/arch/arm/dts/rk3328-rock64-u-boot.dtsi index

[U-Boot] [PATCH v5 1/2] arm: dts: Add devicetree support for iMXQXP AI_ML board

2019-08-15 Thread Manivannan Sadhasivam
Add devicetree support for iMXQXP AI_ML board from Einfochips. Signed-off-by: Manivannan Sadhasivam Reviewed-by: Peng Fan Reviewed-by: Lukasz Majewski --- arch/arm/dts/Makefile | 1 + arch/arm/dts/fsl-imx8qxp-ai_ml-u-boot.dtsi | 117 +

[U-Boot] [PATCH v5 0/2] Add board support for iMX8QXP AI_ML board

2019-08-15 Thread Manivannan Sadhasivam
Hello, This patchset adds initial board support for iMX8QXP AI_ML board from Einfochips. This board is one of the Consumer Edition and AI boards of the 96Boards family. This initial supports contains following peripherals which are tested and known to work: 1. Debug serial via UART2 2. SD card

Re: [U-Boot] [PATCH v2 3/3] rk8xx: add a sysreset driver for poweroff【请注意,邮件由s...@google.com代发】

2019-08-15 Thread Kever Yang
Simon, Stephen, On 2019/8/15 上午3:35, Simon Glass wrote: Hi Kever, On Tue, 13 Aug 2019 at 20:46, Kever Yang wrote: Hi Urja, Simon, This patch is not able to pass the sandbox_spl test, it reports: [1]26463 segmentation fault (core dumped) ./u-boot The driver looks good to me, no idea

Re: [U-Boot] [PATCH] test/py: Fix MMC/SD block write test dependency

2019-08-15 Thread Michal Simek
On 14. 08. 19 17:51, Stephen Warren wrote: > On 8/14/19 12:12 AM, Michal Simek wrote: >> On 13. 08. 19 23:21, Stephen Warren wrote: >>> On 8/1/19 10:48 PM, Michal Simek wrote: Test is using random command which has own Kconfig symbol CMD_RANDOM which already depends on CMD_MEMORY.

[U-Boot] [PATCH 8/8] usb: r8a66597: Checkpatch cleanup

2019-08-15 Thread Marek Vasut
Fix remaining checkpatch complaints in the driver. Signed-off-by: Marek Vasut Cc: Chris Brandt --- drivers/usb/host/r8a66597-hcd.c | 65 ++--- drivers/usb/host/r8a66597.h | 473 2 files changed, 269 insertions(+), 269 deletions(-) diff --git

[U-Boot] [PATCH 7/8] usb: r8a66597: Add Kconfig entry

2019-08-15 Thread Marek Vasut
Add missing Kconfig entry for the R8A66597 driver. Signed-off-by: Marek Vasut Cc: Chris Brandt --- drivers/usb/host/Kconfig | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index 42046c8062..30c6b69be8 100644 ---

[U-Boot] [PATCH 6/8] usb: r8a66597: Convert to USB DM

2019-08-15 Thread Marek Vasut
Convert the R8A66597 USB driver to DM and add support for DT probing. Drop support for legacy non-DM and non-DT probing, since there are no platform using that. Signed-off-by: Marek Vasut Cc: Chris Brandt --- drivers/usb/host/r8a66597-hcd.c | 193 +--- 1 file

[U-Boot] [PATCH 5/8] usb: r8a66597: Replace R8A66597_BASE0

2019-08-15 Thread Marek Vasut
Replace R8A66597_BASE0 with proper SYSCFG0 accesses, no functional change. Signed-off-by: Marek Vasut Cc: Chris Brandt --- drivers/usb/host/r8a66597-hcd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/r8a66597-hcd.c b/drivers/usb/host/r8a66597-hcd.c

[U-Boot] [PATCH 4/8] usb: r8a66597: Remove BE support

2019-08-15 Thread Marek Vasut
While the USB controller can work both in LE and BE modes, there is no user for the BE mode, so drop it. If there ever is a user for it, it can be easily re-added back. Signed-off-by: Marek Vasut Cc: Chris Brandt --- drivers/usb/host/r8a66597-hcd.c | 6 +++--- 1 file changed, 3 insertions(+),

Re: [U-Boot] [EXT] Re: [PATCH v4 1/5] spl: dm: disable SPI DM flash for non-DM SPL

2019-08-15 Thread Chuanhua Han
> -Original Message- > From: Lukasz Majewski > Sent: 2019年8月15日 15:15 > To: Chuanhua Han > Cc: Jagan Teki ; Xiaowei Bao > ; U-Boot-Denx ; Pan Jiafei > ; Jagan Teki ; Ruchika > Gupta > Subject: Re: [U-Boot] [EXT] Re: [PATCH v4 1/5] spl: dm: disable SPI DM flash > for > non-DM SPL > >

Re: [U-Boot] [PATCH v4 2/2] board: Add support for iMX8QXP AI_ML board

2019-08-15 Thread Manivannan Sadhasivam
Hi Lukasz, On Thu, Aug 15, 2019 at 09:51:25AM +0200, Lukasz Majewski wrote: > Hi Manivannan, > > > Hi Lukasz, > > > > Thanks for the review! > > > > On Wed, Jul 24, 2019 at 10:07:13AM +0200, Lukasz Majewski wrote: > > > Hi Manivannan, > > > > > > > This commit adds initial board support for

[U-Boot] [PATCH 4/4] rockchip: dts: rk3328-rock64: fix usb power supply

2019-08-15 Thread Kever Yang
According to rock64 schemetic, both VCC_HOST1_5V and VCC_HOST_5V are controlled by USB20_HOST_DRV(GPIO0A2), fix it so that we can get correct power supply for USB HOST ports. Signed-off-by: Kever Yang --- arch/arm/dts/rk3328-rock64.dts | 23 ++- 1 file changed, 2

[U-Boot] [PATCH 3/4] rockchip: rk3328: migrate u-boot node to -u-boot.dtsi

2019-08-15 Thread Kever Yang
Move all the nodes only shown in u-boot to -u-boot.dtsi to make rk3328.dtsi clean. Signed-off-by: Kever Yang --- arch/arm/dts/rk3328-evb-u-boot.dtsi| 31 +++--- arch/arm/dts/rk3328-evb.dts| 5 --- arch/arm/dts/rk3328-rock64-u-boot.dtsi | 33 ++-

[U-Boot] [PATCH v4 2/2] part: always enable part_get_info_ptr() for driver

2019-08-15 Thread Kever Yang
The partition driver has its Kconfig option, and the part_get_info_prt() interface are mendatory interface for partition drivers, always enable the macro to make partition driver works correctly. Signed-off-by: Kever Yang --- Changes in v4: - formate commit message to ~75 columns Changes in

Re: [U-Boot] [PATCH] global_data: Move x86 specific GD flags into common flags

2019-08-15 Thread Simon Goldschmidt
Hi Stefan, On Thu, Aug 15, 2019 at 10:06 AM Stefan Roese wrote: > > Hi Simon, > > On 15.08.19 09:35, Simon Goldschmidt wrote: > > Hi Stefan, > > > > On Thu, Aug 15, 2019 at 9:05 AM Stefan Roese wrote: > >> > >> Currently the upper 16 bits of the GD flags are reserved for > >> architecture

Re: [U-Boot] [PATCH 5/6] arm: socfpga: gen5: add readonly clk driver

2019-08-15 Thread Marek Vasut
On 8/15/19 6:57 PM, Simon Goldschmidt wrote: > Am 15.08.2019 um 18:34 schrieb Marek Vasut: >> On 8/15/19 6:22 PM, Simon Goldschmidt wrote: >>> Hi Marek, >>> >>> Am 24.07.2019 um 09:45 schrieb Simon Goldschmidt: On Wed, Jul 24, 2019 at 9:31 AM Marek Vasut wrote: > > On 7/23/19 10:27

[U-Boot] [PATCH v2] cmd: avb: Fix requested partitions list

2019-08-15 Thread Sam Protsenko
The requested_partitions[] array should contain only boot partitions. Usually it's only 'boot' partition, as can be seen in [1]. Also, seems like the requested_partitions[] are only used when there is no 'vbmeta' partition [2], which is not a regular use-case. Make requested_partitions[] contain

Re: [U-Boot] [PATCH 5/6] arm: socfpga: gen5: add readonly clk driver

2019-08-15 Thread Simon Goldschmidt
Am 15.08.2019 um 18:34 schrieb Marek Vasut: On 8/15/19 6:22 PM, Simon Goldschmidt wrote: Hi Marek, Am 24.07.2019 um 09:45 schrieb Simon Goldschmidt: On Wed, Jul 24, 2019 at 9:31 AM Marek Vasut wrote: On 7/23/19 10:27 PM, Simon Goldschmidt wrote: This adds clk-gen5 as a readonly DM_CLK

Re: [U-Boot] [PATCH] cmd: avb: Fix requested partitions list

2019-08-15 Thread Sam Protsenko
Hi Eugeniu, On Mon, Aug 12, 2019 at 4:57 PM Eugeniu Rosca wrote: > > Hi all, > > On Mon, Aug 12, 2019 at 02:13:55PM +0300, Igor Opaniuk wrote: > [..] > > Current snapshot of libavb in U-boot is a bit out-dated (~2 years) and > > before introducing patches that can leverage new features from the

Re: [U-Boot] [PATCH] test/py: Fix MMC/SD block write test dependency

2019-08-15 Thread Stephen Warren
On 8/15/19 12:26 AM, Michal Simek wrote: On 14. 08. 19 17:51, Stephen Warren wrote: On 8/14/19 12:12 AM, Michal Simek wrote: On 13. 08. 19 23:21, Stephen Warren wrote: On 8/1/19 10:48 PM, Michal Simek wrote: Test is using random command which has own Kconfig symbol CMD_RANDOM which already

Re: [U-Boot] [PATCH 1/2] net: dwc_eth_qos: Change eqos_ops function to static

2019-08-15 Thread Joe Hershberger
On Thu, Aug 1, 2019 at 4:31 AM Patrick Delaunay wrote: > > This patch solves many warnings when compiling with W=1: > warning: no previous prototype for '' [-Wmissing-prototypes] > > Signed-off-by: Patrice Chotard > Signed-off-by: Patrick Delaunay Acked-by: Joe Hershberger

Re: [U-Boot] [PATCH 5/6] arm: socfpga: gen5: add readonly clk driver

2019-08-15 Thread Simon Goldschmidt
Hi Marek, Am 24.07.2019 um 09:45 schrieb Simon Goldschmidt: On Wed, Jul 24, 2019 at 9:31 AM Marek Vasut wrote: On 7/23/19 10:27 PM, Simon Goldschmidt wrote: This adds clk-gen5 as a readonly DM_CLK driver that can return clocks for the peripherals. Further changes are: - select DM_CLK for

Re: [U-Boot] Question about GPL v3 font

2019-08-15 Thread Tom Rini
On Tue, Aug 13, 2019 at 03:34:20AM -0600, Simon Glass wrote: > Hi, > > On Fri, 26 Jul 2019 at 11:07, Tom Rini wrote: > > > > On Fri, Jul 26, 2019 at 06:42:47PM +0900, Masahiro Yamada wrote: > > > > > Hi. > > > > > > According to the Kconfig entry, > > >

[U-Boot] [PATCH] image: android: Support boot image v1 and v2

2019-08-15 Thread Sam Protsenko
In new versions of Android Boot Image next fields are added to the header (and corresponding payloads are added to the image itself): - v1: Recovery DTBO - v2: DTB Account for these new fields in next functions: 1. android_image_get_end(): as v1 and v2 have new payloads in the image,

Re: [U-Boot] [PATCH 1/8] usb: r8a66597: Remove CONFIG_SUPERH_ON_CHIP_R8A66597

2019-08-15 Thread Chris Brandt
On Thu, Aug 15, 2019, Marek Vasut wrote: > Signed-off-by: Marek Vasut > Cc: Chris Brandt The series Looks good. Thanks Marek! Chris ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] cmd: avb: Fix requested partitions list

2019-08-15 Thread Sam Protsenko
Hi Eugeniu, On Tue, Aug 13, 2019 at 7:59 PM Eugeniu Rosca wrote: > > Hi Sam, > > On Fri, Aug 09, 2019 at 07:16:03PM +0300, Sam Protsenko wrote: > > The requested_partitions[] array should contain only boot partitions. > > Usually it's only 'boot' partition, as can be seen in [1]. Also, seems > >

Re: [U-Boot] [PATCH 6/8] usb: r8a66597: Convert to USB DM

2019-08-15 Thread Chris Brandt
On Thu, Aug 15, 2019, Marek Vasut wrote: > Convert the R8A66597 USB driver to DM and add support for DT probing. > Drop support for legacy non-DM and non-DT probing, since there are no > platform using that. I like the switch to DM :) Chris ___ U-Boot

Re: [U-Boot] kernel-doc vs Doxygen

2019-08-15 Thread Sam Protsenko
On Thu, Aug 15, 2019 at 4:51 PM Tom Rini wrote: > > On Wed, Aug 14, 2019 at 09:16:40PM +0300, Sam Protsenko wrote: > > > Hi everyone, > > > > Quick question: which comment style is allowed in U-Boot, kernel-doc > > or Doxygen one? I have noticed that both are used currently (and I've > > sent

Re: [U-Boot] [PATCH 5/6] arm: socfpga: gen5: add readonly clk driver

2019-08-15 Thread Simon Goldschmidt
Am 15.08.2019 um 19:07 schrieb Marek Vasut: On 8/15/19 6:57 PM, Simon Goldschmidt wrote: Am 15.08.2019 um 18:34 schrieb Marek Vasut: On 8/15/19 6:22 PM, Simon Goldschmidt wrote: Hi Marek, Am 24.07.2019 um 09:45 schrieb Simon Goldschmidt: On Wed, Jul 24, 2019 at 9:31 AM Marek Vasut wrote:

Re: [U-Boot] [PATCH 5/6] arm: socfpga: gen5: add readonly clk driver

2019-08-15 Thread Marek Vasut
On 8/15/19 6:22 PM, Simon Goldschmidt wrote: > Hi Marek, > > Am 24.07.2019 um 09:45 schrieb Simon Goldschmidt: >> On Wed, Jul 24, 2019 at 9:31 AM Marek Vasut wrote: >>> >>> On 7/23/19 10:27 PM, Simon Goldschmidt wrote: This adds clk-gen5 as a readonly DM_CLK driver that can return

[U-Boot] [PATCH v3 3/4] configs: AST2500 EVB: Enable SD controller

2019-08-15 Thread Eddie James
Enable the MMC subsystem and the Aspeed SD controller. Also enable the use of the device tree for probing the controller. Signed-off-by: Eddie James --- configs/evb-ast2500_defconfig | 8 1 file changed, 8 insertions(+) diff --git a/configs/evb-ast2500_defconfig

[U-Boot] [PATCH v3 0/4] ARM: Aspeed: Add SD host controller driver

2019-08-15 Thread Eddie James
This series adds support for the SD host controller on the Aspeed ast2xxx SocS. It also enables MMC and the SD controller for the ast2500 EVB. Changes since v2: - Remove mmc_initialize call in the ast2500 board init - Add OF_CONTROL to the ast2500 EVB configuration - Fix the clock-getting code

[U-Boot] [PATCH 2/2] libavb: Fix build warnings after updating the lib

2019-08-15 Thread Sam Protsenko
After updating libavb to most recent version from AOSP/master, two new warnings appear: Warning #1: lib/libavb/avb_cmdline.c: In function 'avb_append_options': lib/libavb/avb_cmdline.c:365:15: warning: 'dm_verity_mode' may be used uninitialized in

[U-Boot] [PATCH 6/7] configs: am65x_evm_r5: Activate early console functionality

2019-08-15 Thread Andreas Dannenberg
Activate early console functionality on AM654x devices to allow for an alternate serial port to be used to support UART-based boot. This is so that System Firmware (SYSFW) can get loaded over the serial port prior to the main console being brought up and made available. Signed-off-by: Andreas

[U-Boot] [PATCH v4 1/5] net: mvpp2x: fix traffic stuck after PHY start error

2019-08-15 Thread nhed+uboot
From: Stefan Chulski Issue: - Network stuck if autonegotion fails. Issue root cause: - When autonegotiation fails during port open procedure, the packet processor configuration does not finish and open procedure exits with error. - However, this doesn't prevent u-boot network framework

[U-Boot] [PATCH v4 4/5] net: mvpp2: use new MVMDIO driver

2019-08-15 Thread nhed+uboot
From: Nevo Hed This commit ports mvpp2 to use the recently introduced Marvell MDIO (MVMDIO) driver. It removes direct interaction with the SMI & XSMI busses. This commit is based in part on earlier work by Ken Ma in Marvell's own downstream repo:

[U-Boot] [PATCH v4 3/5] arm: dts: armada-cp110-*dtsi: add xmdio nodes

2019-08-15 Thread nhed+uboot
From: Nevo Hed Based on upstream-linux See https://github.com/torvalds/linux/commit/f66b2aff. However made the XSMI register window 0x16 (22) bytes per my reading of the functional spec. Similar commits in Marvels own repo bump it to 0x200 (512) bytes but I did not see the reasoning for that.

Re: [U-Boot] [PATCH 1/1] easylogo: avoid buffer overrun

2019-08-15 Thread Heinrich Schuchardt
On 8/15/19 11:54 PM, Heinrich Schuchardt wrote: Building easylogo with `HOST_TOOLS_ALL=y make tools` results in a build warning due to a possible buffer overrun: tools/easylogo/easylogo.c:453:4: note: ‘sprintf’ output between 7 and 262 bytes into a destination of size 256 sprintf (str,

Re: [U-Boot] [PATCH 1/1] doc: arch: correct links in x86.rst

2019-08-15 Thread Bin Meng
On Fri, Aug 16, 2019 at 3:21 AM Heinrich Schuchardt wrote: > > Correctly reference uefi/uefi.rst and uefi/u-boot_on_efi.rst. > > Signed-off-by: Heinrich Schuchardt > --- > doc/arch/x86.rst | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Reviewed-by: Bin Meng Tested-by: Bin Meng

[U-Boot] [PATCH 1/1] easylogo: avoid buffer overrun

2019-08-15 Thread Heinrich Schuchardt
Building easylogo with `HOST_TOOLS_ALL=y make tools` results in a build warning due to a possible buffer overrun: tools/easylogo/easylogo.c:453:4: note: ‘sprintf’ output between 7 and 262 bytes into a destination of size 256 sprintf (str, "%s, 0x%02x", app, *dataptr++);

[U-Boot] [PATCH v4 2/5] net: mvpp2: mark phy as invalid in case of missing appropriate driver

2019-08-15 Thread nhed+uboot
From: Grzegorz Jaszczyk If the phy doesn't match with any existing u-boot drivers, the phy framework will connect it to the generic one which uid == 0x. In this case, act as if the phy wouldn't be declared in dts. Otherwise, in case of 3310 (for which the driver doesn't exist) the link

[U-Boot] [PATCH v4 0/5] Switch MVPP2 to use new MVMDIO

2019-08-15 Thread nhed+uboot
From: Nevo Hed This patchset includes a couple of commits form Marvell's downstream repo and a change to replace mvpp2's SMI implementation with the new MVMDIO driver. The mvpp2 change is based partially on Ken Ma's mods against an earlier (his) version of MVMDIO that never made it to upstream

[U-Boot] [PATCH v4 5/5] net: mvpp2: MVPP2 now needs MVMDIO

2019-08-15 Thread nhed+uboot
From: Nevo Hed Changes to mvpp2.c require the MVMDIO module which in turn uses DM_MDIO. Signed-off-by: Nevo Hed --- drivers/net/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 5fd31b03cf..81f39d0928 100644 --- a/drivers/net/Kconfig

Re: [U-Boot] [PATCH 1/1] doc: formatting slimbootloader.rst

2019-08-15 Thread Bin Meng
On Fri, Aug 16, 2019 at 3:02 AM Heinrich Schuchardt wrote: > > Avoid a warning when building the 'make htmldocs' target: > > doc/board/intel/slimbootloader.rst:90: WARNING: Title underline too short. > > Signed-off-by: Heinrich Schuchardt > --- > doc/board/intel/slimbootloader.rst | 2 +- > 1

[U-Boot] [PATCH 1/1] doc: arch: correct links in x86.rst

2019-08-15 Thread Heinrich Schuchardt
Correctly reference uefi/uefi.rst and uefi/u-boot_on_efi.rst. Signed-off-by: Heinrich Schuchardt --- doc/arch/x86.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/arch/x86.rst b/doc/arch/x86.rst index 2eb524cc8f..a441738ad1 100644 --- a/doc/arch/x86.rst +++

[U-Boot] [PATCH v3 1/4] clk: aspeed: Add support for SD clock

2019-08-15 Thread Eddie James
Add code to enable the SD clock on the ast2500 SoC. Reviewed-by: Cédric Le Goater Signed-off-by: Eddie James --- arch/arm/include/asm/arch-aspeed/scu_ast2500.h | 3 +++ drivers/clk/aspeed/clk_ast2500.c | 27 ++ drivers/pinctrl/aspeed/pinctrl_ast2500.c

Re: [U-Boot] [PATCH v2 2/4] mmc: Add Aspeed SD controller driver

2019-08-15 Thread Eddie James
On 8/14/19 10:18 AM, Cédric Le Goater wrote: On 13/08/2019 21:31, Eddie James wrote: Add support for the Aspeed SD host controller engine. It looks correct and simple enough. Some comments below. Signed-off-by: Eddie James --- drivers/mmc/Kconfig| 11 +++

[U-Boot] [PATCH 7/7] board: ti: am65x: Add UART boot procedure in README

2019-08-15 Thread Andreas Dannenberg
am65x ROM support booting over UART. And U-Boot built for am65x EVM supports UART boot as well. Add the UART boot procedure into the README also providing a corresponding example command sequence for execution on a host PC. Signed-off-by: Andreas Dannenberg --- board/ti/am65x/README | 32

[U-Boot] [PATCH 5/7] armv7R: dts: k3: am654: Add MCU_UART0 related definitions

2019-08-15 Thread Andreas Dannenberg
Although we currently use the MAIN_UART0 for R5 SPL console output there are cases where we require access to the MCU_UART0 as well for example in case of UART-based Y-Modem boot. To support these scenarios add related DTS definitions to be able to use that UART early on. Signed-off-by: Andreas

Re: [U-Boot] [PATCH v2 3/4] aspeed: Support SD controller on the ast2500 board

2019-08-15 Thread Eddie James
On 8/14/19 10:23 AM, Cédric Le Goater wrote: On 13/08/2019 21:31, Eddie James wrote: Initialize the MMC subsystem on the ast2500 board. Compile MMC and the Aspeed SD controller on the ast2500 EVB. Signed-off-by: Eddie James --- arch/arm/include/asm/gpio.h | 3 ++-

[U-Boot] [PATCH v3 4/4] ARM: dts: ast2500: Add SDHCI nodes

2019-08-15 Thread Eddie James
Add nodes for the Aspeed SD controllers with their necessary properties. Reviewed-by: Cédric Le Goater Signed-off-by: Eddie James --- arch/arm/dts/ast2500-evb.dts | 14 ++ arch/arm/dts/ast2500-u-boot.dtsi | 16 2 files changed, 30 insertions(+) diff --git

[U-Boot] [PATCH v3 2/4] mmc: Add Aspeed SD controller driver

2019-08-15 Thread Eddie James
Add support for the Aspeed SD host controller engine. Signed-off-by: Eddie James --- arch/arm/include/asm/gpio.h | 3 +- drivers/mmc/Kconfig | 11 ++ drivers/mmc/Makefile| 1 + drivers/mmc/aspeed_sdhci.c | 90 + 4 files changed,

[U-Boot] [PATCH 0/7] Implement UART-based boot of TI K3 AM65x SoCs

2019-08-15 Thread Andreas Dannenberg
This series enables UART-based boot of TI K3 AM65x SoCs by extending the TI K3 System Firmware (SYSFW) loader with support for UART-based loading of SYSFW. This is done by tapping into the existing SPL Y-Modem serial loader framework to accomplish the actual loading functionality. The series also

[U-Boot] [PATCH 1/7] spl: ymodem: Fix FIT loading termination handling

2019-08-15 Thread Andreas Dannenberg
During FIT reading through ymodem_read_fit() the function xyzModem_stream_read() is being used which returns zero once the end of a stream has been reached. This could lead to an premature exit from ymodem_read_fit() with certain-sized FIT images reporting that zero bytes overall were read. Such a

[U-Boot] [PATCH 3/7] arm: K3: common: Allow for early console functionality

2019-08-15 Thread Andreas Dannenberg
Implement an early console functionality in SPL that can be used before the main console is being brought up. This helps in situations where the main console is dependent on System Firmware (SYSFW) being up and running, which is usually not the case during the very early stages of boot. Using this

[U-Boot] [PATCH 4/7] arm: K3: sysfw-loader: Allow loading SYSFW via Y-Modem

2019-08-15 Thread Andreas Dannenberg
In order to allow booting TI K3 family SoCs via Y-Modem add support for loading System Firmware by tapping into the associated SPL core loader function. In this context also make sure a console is available and if not go ahead and activate the early console feature which allows bringing up an

[U-Boot] [PATCH 1/2] libavb: Update libavb to current AOSP master

2019-08-15 Thread Sam Protsenko
Update libavb to commit 5fbb42a189aa in AOSP/master, because new version has support for super partition [1], which we need for implementing Android dynamic partitions. All changes from previous patches for libavb in U-Boot are accounted for in this commit: - commit ecc6f6bea6a2 ("libavb: Handle

[U-Boot] [PATCH 2/7] spl: ymodem: Make SPL Y-Modem loader framework accessible

2019-08-15 Thread Andreas Dannenberg
Expose SPL's Y-Modem core loader function via the common SPL header file so it can be re-used for purposes other than loading U-Boot itself. Signed-off-by: Andreas Dannenberg --- common/spl/spl_ymodem.c | 4 ++-- include/spl.h | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-)

[U-Boot] [PATCH] armv8: fsl-layerscape: Fix a typo of Layerscape PCIe config entry

2019-08-15 Thread Z.q. Hou
From: Hou Zhiqiang The correct config entry is CONFIG_PCIE_LAYERSCAPE, this typo result in skipping the fixup of Linux PCIe DT nodes. Fixes: 4da0e52c9dc0 (armv8: fsl-layerscape: fix config dependency for layerscape pci code) Signed-off-by: Hou Zhiqiang ---

[U-Boot] 答复: [PATCH v2 1/4] USB: gadget: Add the cadence USB3 gadget driver

2019-08-15 Thread Sherry Sun
Hi Marek > > On 8/14/19 2:16 PM, sherry sun wrote: > > From: Sherry Sun > > > > This driver is ported from NXP i.MX U-Boot version imx_v2019.04 and > > some changes have also been made to adapt to U-Boot. > > > > Add the Cadence USB3 IP(CDNS3) driver for the gadget (device mode). > > The CDNS3

Re: [U-Boot] [PATCH] Revert "net: macb: Fixed reading MII_LPA register"

2019-08-15 Thread Anup Patel
On Wed, Aug 14, 2019 at 4:01 PM Bin Meng wrote: > > This reverts commit 1b0c9914cc75d1570359181ebd493cd5746cb0ed. > > Commit 1b0c9914cc75 ("net: macb: Fixed reading MII_LPA register") > causes 100Mbps does not work any more with SiFive FU540 GEM on the > HiFive Unleashed board. Revert it. > >

Re: [U-Boot] [PATCH 1/4 v5] watchdog: Implement generic watchdog_reset() version

2019-08-15 Thread Stefan Roese
Hi Bin, On 15.08.19 16:19, Bin Meng wrote: Hi Stefan, On Thu, Aug 15, 2019 at 2:07 PM Stefan Roese wrote: Hi Simon, On 14.08.19 21:35, Simon Glass wrote: Hi, On Wed, 14 Aug 2019 at 00:22, Stefan Roese wrote: Hi Simon, (added Simon Glass and Bin to Cc) On 13.08.19 22:16, Simon

[U-Boot] Pull request: u-boot-riscv/master

2019-08-15 Thread uboot
Hi Tom, Please pull some riscv updates: - Fix sifive serial y-modem transfer. - Access CSRs using CSR numbers. - Update doc sifive-fu540 - Support big endian hosts and target. https://travis-ci.org/rickchen36/u-boot-riscv/builds/572159567 Thanks Rick The following changes since commit