Hi Robert,
On Wed, 13 Nov 2019 at 12:40, Robert Beckett wrote:
>
> fixes: 8ab452d5877638a97e5bdd521d119403b70b45f5
>
> When compiling list of cover letter cc addresses, using null as a
> separater, then encoding to utf-8 results in lots of "\x00" as
> separators. patman then doesnt understand
On Sun, 27 Oct 2019 at 10:55, Anatolij Gustschin wrote:
>
> s/Subprocress/Subprocess/
> s/easiler/easier/
> s/repositiory/repository/
> s/rangem/range/
> s/Retruns/Returns/
>
> Signed-off-by: Anatolij Gustschin
> ---
> tools/patman/cros_subprocess.py | 4 ++--
> tools/patman/gitutil.py
Hi Kever,
On Thu, Nov 14, 2019 at 1:25 AM Kever Yang
wrote:
> Hi Thomas,
>
> On 2019/11/11 上午12:25, Thomas Hebb wrote:
> > b7abef2ecbcc ("rockchip: rk3399: Migrate to use common spl board file")
> > removed SoC-specific code for RK3399's SPL and in the process introduced
> > two regressions:
>
Hi Robert,
On Wed, 13 Nov 2019 at 12:40, Robert Beckett wrote:
>
> fixes: 8ab452d5877638a97e5bdd521d119403b70b45f5
>
> When compiling list of cover letter cc addresses, using null as a
> separater, then encoding to utf-8 results in lots of "\x00" as
> separators. patman then doesnt understand
On Sun, 27 Oct 2019 at 10:55, Anatolij Gustschin wrote:
>
> s/Subprocress/Subprocess/
> s/easiler/easier/
> s/repositiory/repository/
> s/rangem/range/
> s/Retruns/Returns/
>
> Signed-off-by: Anatolij Gustschin
> ---
> tools/patman/cros_subprocess.py | 4 ++--
> tools/patman/gitutil.py
Hi Robert,
On Wed, 13 Nov 2019 at 12:40, Robert Beckett wrote:
>
> fixes: 8ab452d5877638a97e5bdd521d119403b70b45f5
>
> When compiling list of cover letter cc addresses, using null as a
> separater, then encoding to utf-8 results in lots of "\x00" as
> separators. patman then doesnt understand
On Wed, 23 Oct 2019 at 09:47, Heiko Stuebner wrote:
>
> From: Heiko Stuebner
>
> The loading convention for optee or any other tee on arm64 is as bl32
> parameter to the trusted-firmware. So TF-A gets invoked with the TEE as
> bl32 and main u-boot as bl33. Once it has done its startup TF-A jumps
On Sat, 26 Oct 2019 at 15:17, Heinrich Schuchardt wrote:
>
> Compiling arch/sandbox/cpu/os.c results in an error
>
> ../arch/sandbox/cpu/os.c: In function ‘os_find_text_base’:
> ../arch/sandbox/cpu/os.c:823:12: error: cast to pointer from
> integer of different size [-Werror=int-to-pointer-cast]
On Sat, 26 Oct 2019 at 15:17, Heinrich Schuchardt wrote:
>
> Compiling arch/sandbox/cpu/os.c results in an error
>
> ../arch/sandbox/cpu/os.c: In function ‘os_find_text_base’:
> ../arch/sandbox/cpu/os.c:823:12: error: cast to pointer from
> integer of different size [-Werror=int-to-pointer-cast]
Am Mittwoch, 23. Oktober 2019, 16:46:41 CET schrieb Heiko Stuebner:
> From: Heiko Stuebner
>
> OP-TEE can get supplied with a devicetree and will then insert
> its firmware node and reserved-memory sections into it.
> As this devicetree often is not the one supplied to a later
> loaded kernel, a
Renamed dm_mdio_phy_connect arguments dev to mdiodev and addr to phyaddr
for a bit more clarity and consistency with the following patches.
Also use NULL instead of 0 on error return path.
Signed-off-by: Alex Marginean
---
include/miiphy.h | 6 +++---
net/mdio-uclass.c | 10 +-
2
The patch set introduces dm_eth_phy_connect which takes in an ethernet device
and uses DT information to find the associated PHY and connect the Ethernet
interface to it. This should simplify similar code in ethernet drivers.
A new binding is introduced for scanning an MDIO bus, useful if the bus
This is useful to carry custom information between the driver structure
associated with a specific HW and the driver code.
Signed-off-by: Alex Marginean
---
include/phy.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/phy.h b/include/phy.h
index e50f56b6eb..6ace9b3a0c 100644
---
On 26.08.19 08:43, Fabrice Fontaine wrote:
Le lun. 26 août 2019 à 07:57, Jan Kiszka a écrit :
On 25.08.19 21:11, Fabrice Fontaine wrote:
Le dim. 25 août 2019 à 17:49, Jan Kiszka a écrit :
On 25.08.19 17:13, Fabrice Fontaine wrote:
Le dim. 25 août 2019 à 16:11, Jan Kiszka a écrit :
On
On Sat, 26 Oct 2019 at 15:17, Heinrich Schuchardt wrote:
>
> Compiling arch/sandbox/cpu/os.c results in an error
>
> ../arch/sandbox/cpu/os.c: In function ‘os_find_text_base’:
> ../arch/sandbox/cpu/os.c:823:12: error: cast to pointer from
> integer of different size [-Werror=int-to-pointer-cast]
From: Bartosz Golaszewski
The DM family of DaVinci SoCs is no longer supported. Drop the
irrelevant code from the driver.
Signed-off-by: Bartosz Golaszewski
---
.../mach-davinci/include/mach/sdmmc_defs.h| 6 ---
board/davinci/da8xxevm/omapl138_lcdk.c| 1 -
From: Bartosz Golaszewski
Booting from MMC on omapl138-lcdk is currently broken after we enabled
driver-model in SPL. While I know what's wrong - the bind() callback not
being called - I can't for the life of me figure out how to fix it.
I'm still working on proper changes, but for now, I'd
Drivers currently use XGMII for XFI and USXGMII and, where needed, use
other information to identify the actual protocol on the board. With these
two defined drivers can now rely on DT phy-mode property.
Signed-off-by: Alex Marginean
---
include/phy_interface.h | 4
1 file changed, 4
There are several plaforms that use XFI and/or USXGMII protocols but declare
them as XGMII in U-Boot because that's already defined. These protocols are not
identical and in some cases specific configuration has to be applied for each
of them.
This patch series introduces XFI and USXGMII and
Hi Tom,
On Wed, 13 Nov 2019 at 09:07, Tom Rini wrote:
>
> On Tue, Nov 12, 2019 at 12:42:10PM -0700, Simon Glass wrote:
>
> > These should be moved to driver model, but in the meantime, move them
> > out of the common header to help reduce its size.
> >
> > Signed-off-by: Simon Glass
> > ---
> >
Am Mittwoch, 23. Oktober 2019, 16:46:39 CET schrieb Heiko Stuebner:
> From: Heiko Stuebner
>
> The phandlep pointer returning the phandle to the caller is optional
> and if it is not set when calling fdtdec_add_reserved_memory() it is
> highly likely that the caller is not interested in a phandle
We have CONFIG_ENV_SIZE_IS_REDUND but don't really use it. We have one
board where we can simply multiple CONFIG_ENV_SIZE by two for the same
result. The other place where we could but were not previously using
this is for where env_internal.h checks for if we should set
ENV_IS_EMBEDDED. This
Signed-off-by: Tom Rini
---
board/freescale/t104xrdb/spl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/board/freescale/t104xrdb/spl.c b/board/freescale/t104xrdb/spl.c
index 7b0eb8edf51d..76b5160cf903 100644
--- a/board/freescale/t104xrdb/spl.c
+++ b/board/freescale/t104xrdb/spl.c
@@
From: Bartosz Golaszewski
The MMC boot is currently broken on omapl138-lcdk after enabling the
driver model in SPL. The main problem is the driver's bind callback not
being called after probe in SPL (even with the DM_FLAG_PRE_RELOC flag
specified).
While a proper fix is still being worked on,
From: Bartosz Golaszewski
We don't have full device-tree support in SPL yet - add an appropriate
U_BOOT_DEVICE() to the board file.
Signed-off-by: Bartosz Golaszewski
---
arch/arm/mach-davinci/Kconfig | 1 +
board/davinci/da8xxevm/omapl138_lcdk.c | 9 +
2 files changed, 10
From: Bartosz Golaszewski
struct mmc_config & struct mmc don't need to be exported over platform
data, but can instead be private in the driver.
Remove struct davinci_mmc_plat.
Signed-off-by: Bartosz Golaszewski
---
drivers/mmc/davinci_mmc.c | 14 --
1 file changed, 4
The function connects an ethernet device to a PHY using DT information.
This API is only available for eth devices with an associated device tree
node.
Signed-off-by: Alex Marginean
---
include/miiphy.h | 12
net/mdio-uclass.c | 72 +++
2
Adds an optional mdio-handle property which identifies a MDIO bus which can
be scanned to find the relevant PHY. The property is ignored if phy-handle
is also present.
Signed-off-by: Alex Marginean
---
doc/device-tree-bindings/net/ethernet.txt | 2 ++
1 file changed, 2 insertions(+)
diff
The patch introduces dm_mdio_phy_scan which is a DM wrapper over
phy_find_by_mask. It also updates dm_eth_phy_connect to scan a MDIO bus
for PHYs if the ethernet node contains a mdio-handle property.
Signed-off-by: Alex Marginean
---
include/miiphy.h | 14
net/mdio-uclass.c | 57
It defines that PHY nodes must be children on MDIO bus nodes and defines
the only required property in U-Boot, reg. This property along with the
example provided are copied over from Linux.
Signed-off-by: Alex Marginean
---
doc/device-tree-bindings/net/phy.txt | 24
1
In some cases the link on the system interface of the aquantia PHY comes up
after the link on line interface. The link state loop only checks the line
side, which may result in first packet sent being lost.
Use aquantia_link_is_up instead, which checks both system and line side on
gen 2/3 PHYs to
Aquantia PHYs have a SMBus interface mostly used for debug. The addresses
on this interface are normally set up by PHY firmware, but depending on the
board they may end up not being unique. Add an optional DT property used
to change SMBus address if needed.
Signed-off-by: Alex Marginean
---
The PHY supports XFI and USXGMII, the notable difference being that USX AN
is enabled for USXGMII. Legacy code uses XGMII for any 10G proto and
detects whether USX AN should be enabled or not using a PHY status
register. Keep that functionality too, so we don't break existing drivers.
A couple of optional properties have been introduced for Aquantia PHY
allowing the driver to set up wiring related configuration points that
are otherwise driven by firmware.
Signed-off-by: Alex Marginean
---
doc/device-tree-bindings/net/aquantia-phy.txt | 25 +++
1 file
Uses the data field in phy_driver structure to identify the PHY generation.
This is useful for custom configuration as non-generic PHY registers are
not 100% compatible between generations.
Signed-off-by: Alex Marginean
---
drivers/net/phy/aquantia.c | 11 +++
1 file changed, 11
Hi
On Thu, Nov 14, 2019 at 2:10 PM Kever Yang wrote:
>
> Hi Michael,
>
> There is a similar patch which has been applied few weeks ago:
>
> https://patchwork.ozlabs.org/patch/1178346/
>
Ok thank you
Michael
>
> Thanks,
>
> - Kever
>
> On 2019/11/9 下午8:26, Michael Trimarchi wrote:
> > Fix
LS1028A QDS board supports multiple combinations of SerDes protocols and
multiple add-on cards with Ethernet PHYs. Some of them require specific
configuration in Linux DT, and the plan is to use DT overlays for them.
Signed-off-by: Alex Marginean
---
On Sun, 27 Oct 2019 at 10:55, Anatolij Gustschin wrote:
>
> s/Subprocress/Subprocess/
> s/easiler/easier/
> s/repositiory/repository/
> s/rangem/range/
> s/Retruns/Returns/
>
> Signed-off-by: Anatolij Gustschin
> ---
> tools/patman/cros_subprocess.py | 4 ++--
> tools/patman/gitutil.py
Am Mittwoch, 23. Oktober 2019, 16:46:41 CET schrieb Heiko Stuebner:
> From: Heiko Stuebner
>
> OP-TEE can get supplied with a devicetree and will then insert
> its firmware node and reserved-memory sections into it.
> As this devicetree often is not the one supplied to a later
> loaded kernel, a
Am Mittwoch, 23. Oktober 2019, 16:46:39 CET schrieb Heiko Stuebner:
> From: Heiko Stuebner
>
> The phandlep pointer returning the phandle to the caller is optional
> and if it is not set when calling fdtdec_add_reserved_memory() it is
> highly likely that the caller is not interested in a phandle
Am Mittwoch, 23. Oktober 2019, 16:46:38 CET schrieb Heiko Stuebner:
> From: Heiko Stuebner
>
> The change adding fdtdec_add_reserved_memory() already protected the added
> phandle against the phandlep being NULL - making the phandlep var optional.
>
> But in the early code checking for an already
On Wed, 23 Oct 2019 at 07:44, Patrick Delaunay wrote:
>
> Remove the pinctrl_decode_pin_config() API, because this
> function is unused and not compatible with livetree
> (it uses fdtdec_get_bool instead of ofnode API).
>
> Signed-off-by: Patrick Delaunay
> ---
>
>
Signed-off-by: Tom Rini
---
board/freescale/ls1043aqds/ls1043aqds.c | 2 +-
board/freescale/ls1046aqds/ls1046aqds.c | 2 +-
board/freescale/ls1088a/ls1088a.c | 2 ++
3 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/board/freescale/ls1043aqds/ls1043aqds.c
The board file has a build time check to ensure that we do not have the
redundant environment overwriting the factory data. However,
multiplying the redundant offset by two isn't correct. Since we
correctly confirm that U-Boot itself will not go in to the primary
environment we only need to next
Uses the new dm_eth_phy_connect helper to connect to the PHY to simplify
the code.
Signed-off-by: Alex Marginean
---
drivers/net/fsl_enetc.c | 53 +++--
drivers/net/fsl_enetc.h | 1 +
2 files changed, 10 insertions(+), 44 deletions(-)
diff --git
If PHY is not ready for data by the time _config is called, reconfigure the
PHY system interface to use the proper protocol based on phydev->interface,
just in case the defaults set by PHY firmware don't match current
configuration.
Signed-off-by: Florin Laurentiu Chiculita
Signed-off-by: Alex
Apply 10G PCS init for USXGMII, XFI interface types.
Signed-off-by: Alex Marginean
---
drivers/net/fsl_enetc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/fsl_enetc.c b/drivers/net/fsl_enetc.c
index e1713a3337..c94ba240f8 100644
--- a/drivers/net/fsl_enetc.c
+++
MDI pins up to the RJ45 connector may be reversed on the board and the
default PHY configuration applied by firmware may or may not match that.
Add an optional DT property to configure MDI reversal for this case.
Signed-off-by: Alex Marginean
---
drivers/net/phy/aquantia.c | 39
On Thu, Nov 14, 2019 at 05:28:06PM +0100, Jan Kiszka wrote:
> On 26.08.19 08:43, Fabrice Fontaine wrote:
> > Le lun. 26 août 2019 à 07:57, Jan Kiszka a écrit :
> > >
> > > On 25.08.19 21:11, Fabrice Fontaine wrote:
> > > > Le dim. 25 août 2019 à 17:49, Jan Kiszka a écrit :
> > > > >
> > > > >
Hi Igor,
Thanks for the video link.
Still question is where i need to change in u-boot code ? any patches available
?
Regards,
Pankaj
From: Igor Opaniuk
Sent: 13 November 2019 20:49
To: Pankaj Suryawanshi
Cc: u-boot@lists.denx.de; Pankaj Suryawanshi
Hi Tom,
On 14.11.19 15:54, Tom Rini wrote:
The board file has a build time check to ensure that we do not have the
redundant environment overwriting the factory data. However,
multiplying the redundant offset by two isn't correct. Since we
correctly confirm that U-Boot itself will not go in
On Thu, Nov 14, 2019 at 05:50:19PM +0100, Stefan Roese wrote:
> Hi Tom,
>
> On 14.11.19 15:54, Tom Rini wrote:
> > The board file has a build time check to ensure that we do not have the
> > redundant environment overwriting the factory data. However,
> > multiplying the redundant offset by two
On Thu, Nov 14, 2019 at 05:52:36PM +0100, Jan Kiszka wrote:
> On 14.11.19 17:41, Tom Rini wrote:
> > On Thu, Nov 14, 2019 at 05:28:06PM +0100, Jan Kiszka wrote:
> > > On 26.08.19 08:43, Fabrice Fontaine wrote:
> > > > Le lun. 26 août 2019 à 07:57, Jan Kiszka a écrit :
> > > > >
> > > > > On
Hi,
sorry for being so late..
We're going to try to get this binding accepted in Linux too.
shouldn't we try to get it accepted to linux first? To avoid any
incompatibilities?
-michael
___
U-Boot mailing list
U-Boot@lists.denx.de
Hi Michael,
On 11/14/2019 6:41 PM, Michael Walle wrote:
Hi,
sorry for being so late..
We're going to try to get this binding accepted in Linux too.
shouldn't we try to get it accepted to linux first? To avoid any
incompatibilities?
I can propagate any changes kernel crows asks us to do
On 11/14/2019 7:19 PM, Alexandru Marginean wrote:
Hi Michael,
On 11/14/2019 6:41 PM, Michael Walle wrote:
Hi,
sorry for being so late..
We're going to try to get this binding accepted in Linux too.
shouldn't we try to get it accepted to linux first? To avoid any
incompatibilities?
I can
śr., 13 lis 2019 o 16:46 Adam Ford napisał(a):
>
> Currently, the da850-lcdk uses SPL_OF_PLATDATA and manually loads
> the necessary source code instead of using the auto-generated,
> because the drivers don't properly autogenerate the code.
>
> This patch simply enables the various device tree
On 14.11.19 17:41, Tom Rini wrote:
On Thu, Nov 14, 2019 at 05:28:06PM +0100, Jan Kiszka wrote:
On 26.08.19 08:43, Fabrice Fontaine wrote:
Le lun. 26 août 2019 à 07:57, Jan Kiszka a écrit :
On 25.08.19 21:11, Fabrice Fontaine wrote:
Le dim. 25 août 2019 à 17:49, Jan Kiszka a écrit :
On
The original code enabled link speeds up to 1Gbps, but the interface can
go up to 2.5G, enable that speed to in PHY AN mask.
Signed-off-by: Alex Marginean
---
I have these patches on top of the following two patch sets, they don't apply
cleanly without them:
On some boards MDIO may get stuck if it detects echo on the line. This is
a know hardware issue, there is a board fix for it. In case we're running
on a board that doesn't have the fix, we don't want to loop here forever
and freeze U-Boot.
Signed-off-by: Alex Marginean
---
This reduces the time needed to establish a link as we don't reset the link
each time the interface is used. Our Link capabilities do not change at
run-time so there is no need to re-apply PHY configuration each time.
Signed-off-by: Alex Marginean
---
I have these patches on top of the
On Thu, 2019-11-14 at 12:57 +0530, Anup Patel wrote:
> On Wed, Nov 13, 2019 at 9:13 AM Rick Chen wrote:
> > Hi Lukas
> >
> > > Hi Rick,
> > >
> > > On Mon, 2019-11-11 at 15:19 +0800, Rick Chen wrote:
> > > > Hi Lukas
> > > >
> > > > > Hi Rick,
> > > > >
> > > > > On Fri, 2019-11-08 at 15:27
This is only used by a few files so it should not be in the common header.
Move it out.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
board/alliedtelesis/SBx81LIFKW/sbx81lifkw.c | 1 +
board/atmel/at91sam9261ek/led.c
These don't need to be in common.h so move them out into a new header.
Also add some missing comments.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
cmd/efi.c | 1 +
common/bootstage.c | 1 +
env/common.c
These don't need to be in common.h so move them out.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
board/BuR/brppt1/board.c | 1 +
include/bootcount.h | 10 ++
include/common.h | 4
3 files
These functions belong in serial.h so move them over.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
arch/arm/cpu/arm926ejs/mxs/spl_boot.c | 1 +
board/amarula/vyasa-rk3288/vyasa-rk3288.c | 1 +
This feature is not enabled by any board. Drop it.
Signed-off-by: Simon Glass
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
arch/powerpc/lib/interrupts.c | 13 -
common/cli_readline.c | 6 --
drivers/timer/mpc83xx_timer.c | 4
include/common.h
At present this function sits in its own file but it does not really
justify it. There are similar string functions in vsprintf.h, so move it
there. Also add the missing function comment.
Use the vsprintf.h include file explicitly where needed.
Signed-off-by: Simon Glass
---
Changes in v4:
This function relates to networking, so move it out of the common.h
header file.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
include/common.h | 4
include/net.h| 21 -
2 files changed, 20
These functions belong in time.h so move them over and add comments.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
arch/arm/cpu/armv7/ls102xa/timer.c| 1 +
arch/arm/cpu/armv8/generic_timer.c| 1 +
This function belongs in cpu_func.h so move it over.
Signed-off-by: Simon Glass
---
Changes in v4:
- Use cpu_func.h instead of cpu_legacy.h
Changes in v3: None
Changes in v2: None
arch/powerpc/cpu/mpc83xx/cpu.c | 1 +
arch/powerpc/cpu/mpc8xx/cpu.c| 1 +
Move this function header to serial.h since this function is clearly
related to serial. The function itself stays in console.c since we don't
have a single serial file. DM and non-DM each has a separate file so we
would have to either create a new common serial file, or repeat the
function in both
Add a header file to house the lz4 compression function. Add a comment
while we are here, since it not even clear from the name what the function
actuall does.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
common/image.c
This function is not defined by any boards so the feature is not used.
Drop it.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
cmd/mem.c| 9 ++---
include/common.h | 9 -
2 files changed, 2 insertions(+),
Remove the unwanted space before the bracket.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
arch/arm/lib/cache-cp15.c| 12 ++--
arch/microblaze/cpu/cache.c | 18 +++---
This is not used in U-Boot. Drop it.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
include/common.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/common.h b/include/common.h
index e946e4d9b7..64d0cf542e 100644
Move these functions into the command.h header file which is a better fit.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
arch/arm/mach-kirkwood/cpu.c| 1 +
arch/sandbox/cpu/start.c| 1 +
A number of board function belong in init.h with the others. Move them.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
arch/arm/cpu/armv8/fsl-layerscape/soc.c | 1 +
arch/arm/mach-imx/mx6/opos6ul.c
This function belongs in time.h so move it over and update the comment
style.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
include/common.h | 3 ---
include/time.h | 7 +++
2 files changed, 7 insertions(+), 3
On Wed, Nov 13, 2019 at 4:51 PM Peter Robinson wrote:
>
> Add initial support for Pinebook Pro laptop.
Hi Peter,
> Specification
> - Rockchip RK3399
> - 4GB Dual-Channel LPDDR4
> - SD card slot
> - eMMC socket
> - 128Mb SPI Flash
> - PCIe 4X slot
> - AP6256 for WiFi + BT
> - 1920*1080 screen
>
This series drops the size of common.h down further, by moving things out
into existing and new header files.
It is now down to about 200 lines.
Changes in v4:
- Rename cpu_legacy.h to cpu_func.h
- Use cpu_func.h instead of cpu_legacy.h
- Use irq_func.h instead of irq_legacy.h
Changes in v3:
-
These should be moved to driver model, but in the meantime, move them
out of the common header to help reduce its size.
Signed-off-by: Simon Glass
---
Changes in v4:
- Rename cpu_legacy.h to cpu_func.h
Changes in v3: None
Changes in v2: None
README | 2 +-
These functions belong in cpu_func.h since they do not use driver model.
Move them over. Don't bother adding comments since these functions should
be deleted.
Signed-off-by: Simon Glass
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
arch/arm/cpu/armv8/fsl-layerscape/cpu.c
This function has a similar name to the common wait_ticks(). It is only
used in one place and seems small enough to drop.
Inline it.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
---
Changes in v4: None
Changes in v3:
- Add new patch to inline pxa_wait_ticks()
Changes in v2: None
These functions belong in cpu_func.h so move them over.
Signed-off-by: Simon Glass
---
Changes in v4:
- Use cpu_func.h instead of cpu_legacy.h
Changes in v3: None
Changes in v2: None
arch/arm/cpu/armv7/ls102xa/cpu.c| 1 +
arch/arm/cpu/armv7/virt-v7.c| 1 +
Hi,
I'm new at this, my problem is that I have the kernel, busybox and u-boot
already build for my target platform, I'm not sure what is the most
appropriate way of creating the final ".img" file out of the files that I
already have .
I need to create 2 partitions, 1 vfat/fat32 for the boot and 1
Move this function into the init.h header file.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
---
Changes in v4: None
Changes in v3:
- Add init.h header
Changes in v2:
- Move trap_init() into init.h instead; update commit message
arch/m68k/lib/traps.c | 1 +
arch/mips/lib/traps.c | 1 +
Remove the unwanted space before the bracket.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
arch/arm/cpu/arm11/cpu.c | 2 +-
arch/arm/cpu/arm920t/cpu.c| 2 +-
arch/arm/cpu/arm926ejs/cpu.c |
Drop inclusion of crc.h in common.h and use the correct header directly
instead.
With this we can drop the conflicting definition in fw_env.h and rely on
the crc.h header, which is already included.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
---
Changes in v4: None
Changes in v3: None
There are a few whitespace problems with this code. Tidy them up.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
arch/powerpc/lib/interrupts.c | 2 +-
drivers/misc/status_led.c | 8
include/status_led.h |
It is not good practice to write code in a header file. If it is included
multiple times then the code can cause duplicate functions.
Move the bootcount_store() and bootcount_load() functions into SPL.
Note: bootcount is a bit strange in that it uses driver model but does not
define proper
Create a new rand.h header file and move functions into it, to reduce
the size of common.h
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
include/common.h | 6 --
include/net.h| 1 +
include/rand.h | 40
We have an existing U-Boot header for the one function that this defines.
Use that instead of the linux/ one. Move over the nice comment.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
board/theadorable/theadorable.c | 2 +-
This function is not defined anywhere. Drop it.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
include/common.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/common.h b/include/common.h
index
This function belongs in mii.h so move it over.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 1 +
drivers/net/fsl_mcdmafec.c | 1 +
drivers/net/ldpaa_eth/ls1088a.c
Some of these have a space before the bracket. Drop it to fix the style.
Add some missing function comments while here.
Note that u32 and u8 cannot be used here since crc.h is included on the
host side.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
---
Changes in v4: None
Changes in v3:
Move these two functions into the irq_funcs.h header file. Also move
interrupt_handler_t as this is used by the irq_install_handler() function.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
---
Changes in v4: None
Changes in v3:
- Rename irq_legacy to irq_func to avoid the 'legacy' label
-
The function declarations in serial.h are not in sync with what is
currently used in usbtty. Fix this by updating the header and including
it, to help catch future such problems.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
This function belongs in time.h so move it over and add a comment.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
arch/arm/cpu/arm920t/ep93xx/timer.c| 1 +
arch/arm/cpu/arm920t/imx/timer.c | 1 +
These are used by only one arch and only within a single file. Drop the
declarations from the common file.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
arch/powerpc/cpu/mpc8xx/cpu.c | 130 +-
1 - 100 of 221 matches
Mail list logo
