[PATCH v2 3/3] efi_selftest: substitute ResetSystem() by do_reset()

2020-08-22 Thread Heinrich Schuchardt
If ResetSystem() is not implemented at runtime, call do_reset() after test completion. Signed-off-by: Heinrich Schuchardt --- v2: new patch --- lib/efi_selftest/efi_selftest.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/efi_selftest/efi_selftest.c

[PATCH v2 0/3] efi_loader: rework ResetSystem()

2020-08-22 Thread Heinrich Schuchardt
If the UEFI runtime service ResetSystem() is not implemented at runtime, it should return instead of hanging in an endless loop. Provide tests for ResetSystem() at before and after ExitBootServices(). If ResetSystem() is not implemented at runtime, use do_reset() after UEFI unit tests to reset

[PATCH v2 1/3] efi_loader: ResetSystem() should not hang

2020-08-22 Thread Heinrich Schuchardt
If ResetSystem() is not implemented at runtime, it should return instead of hanging in an endless loop. This allows the operating system to reset the system by other means as Linux does. It also matches what EDK II suggests in comments for functions ResetShutdown() and ResetWarm() in

[PATCH v2 2/3] efi_selftest: add a test for ResetSystem()

2020-08-22 Thread Heinrich Schuchardt
The unit test will reset the system by calling the ResetSystem() runtime service before or after ExitBootServices() according to the users choice by setting environment variable efi_selftest to: * 'reset system' or * 'reset system runtime'. Signed-off-by: Heinrich Schuchardt --- v2:

Re: [PATCH 1/1] lib: rsa: superfluous initialization in rsa_verify()

2020-08-22 Thread Simon Glass
On Thu, 20 Aug 2020 at 12:29, Heinrich Schuchardt wrote: > > Remove initialization of ret with unused value. > > Signed-off-by: Heinrich Schuchardt > --- > lib/rsa/rsa-verify.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass

Re: [PATCH v2 3/4] clk: add clock driver for SCMI agents

2020-08-22 Thread Simon Glass
On Tue, 18 Aug 2020 at 09:44, Etienne Carriere wrote: > > This change introduces a clock driver for SCMI agent devices. When > SCMI agent and SCMI clock drivers are enabled, SCMI agent binds a > clock device for each SCMI clock protocol devices enabled in the FDT. > > SCMI clock driver is

Re: [PATCH 2/2] sandbox: u-boot.lds: Remove bogus __bss_start symbol

2020-08-22 Thread Simon Glass
On Mon, 17 Aug 2020 at 12:30, Ovidiu Panait wrote: > > The sections described in the sandbox linker script are inserted before > data section via "INSERT BEFORE .data;". Running readelf -S on sandbox > u-boot binary shows that the bss section is located after the data > section: > > Section

Re: binman build questions

2020-08-22 Thread Simon Glass
Hi Jan, On Mon, 17 Aug 2020 at 03:54, Jan Kiszka wrote: > > Hi Simon, > > studying the binman integration, some questions/issues popped up: > > # Timestamp file to make sure that binman always runs > .binman_stamp: FORCE > @touch $@ > > A reason is not provided, neither here nor in the

Re: [PATCH v2 3/3] doc: verified-boot: add required-mode information

2020-08-22 Thread Simon Glass
Hi Thirupathaiah, On Sun, 16 Aug 2020 at 22:09, Thirupathaiah Annapureddy wrote: > > > > On 7/28/2020 11:58 AM, Simon Glass wrote: > > Hi Thirupathaiah, > > > > On Fri, 17 Jul 2020 at 21:20, Thirupathaiah Annapureddy > > wrote: > >> > >> Signed-off-by: Thirupathaiah Annapureddy > >> --- > >> >

Re: libfdt: Warnings of signed/unsigned comparison

2020-08-22 Thread Simon Glass
Hi Jan, On Mon, 17 Aug 2020 at 02:35, Jan Kiszka wrote: > > Hi all, > > enabling binman pulls in libfdt, and that seems to have a lot of issues > with comparing signed with unsigned values. Those are present upstream > as well (dtc in general doesn't build with -Wsign-compare). > > Is anyone

Re: [PATCH v7 10/10] asm-generic/u-boot.h: Remove bi_memstart & bi_memsize from bd_info

2020-08-22 Thread Simon Glass
On Wed, 19 Aug 2020 at 22:45, Stefan Roese wrote: > > bi_memstart & bi_memsize are now not referenced any more. This patch > removes their definitions from the bd_info struct. > > Signed-off-by: Stefan Roese > > --- > > (no changes since v4) > > Changes in v4: > - New patch > >

Re: [PATCH v2 5/5] MAINTAINERS: update maintainers file for new files

2020-08-22 Thread Simon Glass
On Thu, 20 Aug 2020 at 09:11, Rayagonda Kokatanur wrote: > > Update MAINTAINERS file for new files. > > Signed-off-by: Rayagonda Kokatanur > --- > MAINTAINERS | 4 > 1 file changed, 4 insertions(+) Reviewed-by: Simon Glass

Re: [PATCH v2 2/5] MAINTAINERS: Add maintainers to XEN section

2020-08-22 Thread Simon Glass
On Fri, 21 Aug 2020 at 03:10, Anastasiia Lukianenko wrote: > > From: Anastasiia Lukianenko > > Signed-off-by: Anastasiia Lukianenko > --- > > Changes since v1: > - removed duplicates from MAINTAINERS file, which mentioned in >board/xen/xenguest_arm64/MAINTAINERS > - change maintainers in

Re: [PATCH v2 3/5] board: xen: Remove CONFIG_CMD_RUN define and clean xenguest_arm64_defconfig

2020-08-22 Thread Simon Glass
On Fri, 21 Aug 2020 at 03:10, Anastasiia Lukianenko wrote: > > From: Anastasiia Lukianenko > > CONFIG_CMD_RUN is set on by default in Kconfig. > Create xenguest_arm64_defconfig by using savedefconfig to avoid unnecessary > options. > > Signed-off-by: Anastasiia Lukianenko > --- > > Changes

Re: [PATCH v1 1/1] board: ns3: check bnxt chimp handshake status

2020-08-22 Thread Simon Glass
Hi Rayagonda, On Thu, 20 Aug 2020 at 11:42, Rayagonda Kokatanur wrote: > > Chimp is a core in Broadcom netxtream controller (bnxt). > Add support to check bnxt's chimp component status. > > Signed-off-by: Rayagonda Kokatanur > --- > board/broadcom/bcmns3/ns3.c | 13 + > 1 file

[PATCH] mmc: pic32: PIC32MZDA SDHCI controller non-functional

2020-08-22 Thread John Robertson
Refresh driver code, remove obsolete DT props and set the max clock rate from the source clock 'base_clk'. Card detect is also broken. The fix implemented for erratum #15 documented in Microchip ref. DS8736D only needs to be done as in the current code (set CDSSEL, clear CDTLVL in SDHCCON1 to

Re: [PATCH v2 08/25] pci: pci-uclass: Add multi entry support for memory regions

2020-08-22 Thread Simon Glass
On Mon, 17 Aug 2020 at 01:08, Stefan Roese wrote: > > From: Suneel Garapati > > Enable PCI memory regions in ranges property to be of multiple entry. > This helps to add support for SoC's like OcteonTX/TX2 where every > peripheral is on PCI bus. > > Signed-off-by: Suneel Garapati > Cc: Simon

Re: [PATCH v1 06/24] pci: pci-uclass: Add multi entry support for memory regions

2020-08-22 Thread Simon Glass
Hi Stefan, On Fri, 14 Aug 2020 at 05:40, Stefan Roese wrote: > > Hi Simon, > > On 04.08.20 17:05, Simon Glass wrote: > > > > >> Changes in v1: > >> - Change patch subject > >> - Enhance Kconfig help descrition > >> - Use if() instead of #if > >> > >>

Re: [PATCH v2 1/5] cmd: broadcom: add bnxt boot command

2020-08-22 Thread Simon Glass
On Thu, 20 Aug 2020 at 09:11, Rayagonda Kokatanur wrote: > > From: Trac Hoang > > Chimp is a core in Broadcom netxtream controller (bnxt). > Add command to load binary to chimp and boot bnxt. > > Signed-off-by: Trac Hoang > Signed-off-by: Rayagonda Kokatanur > --- > Changes from V1: >

Re: [PATCH v2 4/5] board: xen: Remove unnecessary CONFIG_INITRD_TAG and CONFIG_CMDLINE_TAG

2020-08-22 Thread Simon Glass
On Fri, 21 Aug 2020 at 03:10, Anastasiia Lukianenko wrote: > > From: Anastasiia Lukianenko > > Signed-off-by: Anastasiia Lukianenko > --- > include/configs/xenguest_arm64.h | 3 --- > 1 file changed, 3 deletions(-) > Reviewed-by: Simon Glass

Re: [PATCH v2 5/5] xen: Code style conformity

2020-08-22 Thread Simon Glass
On Fri, 21 Aug 2020 at 03:10, Anastasiia Lukianenko wrote: > > From: Anastasiia Lukianenko > > Cleaning up the following: > > ERROR: do not use assignment in if condition > #281: FILE: drivers/xen/pvblock.c:260: > + if ((err = xenbus_switch_state(XBT_NIL, nodename, >

Re: [PATCH v2 04/25] ARM: renesas: Drop unnecessary function ft_board_setup()

2020-08-22 Thread Simon Glass
On Mon, 17 Aug 2020 at 01:08, Stefan Roese wrote: > > Marek explained on IRC, that ft_board_setup() is not used / necessary > at all. So its best to just drop it completely, as it interferes with > the cleanup of CONFIG_MAX_PCI_REGIONS (completely removed). > > Signed-off-by: Stefan Roese >

Re: [PATCH 1/1] lib: rsa: remove redundant check

2020-08-22 Thread Simon Glass
On Thu, 20 Aug 2020 at 13:05, Heinrich Schuchardt wrote: > > On 8/20/20 8:30 PM, George McCollister wrote: > > On Thu, Aug 20, 2020 at 1:25 PM Heinrich Schuchardt > > wrote: > >> > >> No need to check tmp is non-zero twice. > >> > >> Signed-off-by: Heinrich Schuchardt > >> --- > >>

Re: [PATCH v2 02/25] dm: core: Add API to read PCI bus-range property

2020-08-22 Thread Simon Glass
On Mon, 17 Aug 2020 at 01:08, Stefan Roese wrote: > > Add dev_read_pci_bus_range() to read bus-range property values > > Signed-off-by: Stefan Roese > Cc: Simon Glass > > --- > > Changes in v2: > - New patch > > drivers/core/read.c | 17 + > include/dm/read.h | 12

Re: [PATCH v7 07/10] video: cfb_console.c: Use bi_dram[] values on all platforms

2020-08-22 Thread Simon Glass
On Wed, 19 Aug 2020 at 22:45, Stefan Roese wrote: > > All platforms support bi_dram[] since quite some time. Lets remove the > and bi_memsize values completely. > > Signed-off-by: Stefan Roese > > --- > > (no changes since v4) > > Changes in v4: > - New patch > > drivers/video/cfb_console.c | 8

Re: [PATCH 1/1] lib/rsa: correct check after allocation in fdt_add_bignum()

2020-08-22 Thread Simon Glass
On Thu, 20 Aug 2020 at 13:11, Heinrich Schuchardt wrote: > > After allocating to pointer ctx we should check that pointer and not > another pointer already checked above. > > Signed-off-by: Heinrich Schuchardt > --- > lib/rsa/rsa-sign.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH 1/2] board_f: Remove dead code from init_func_i2c

2020-08-22 Thread Simon Glass
On Mon, 17 Aug 2020 at 12:31, Ovidiu Panait wrote: > > Since commit 69153988a6f4 ("i2c: Finish dropping use of CONFIG_I2C_HARD") > init_func_i2c is wrapped only by "#if defined(CONFIG_SYS_I2C)". Because > of this, the second ifdef within becomes pointless: > > #if defined(CONFIG_SYS_I2C) >

Re: [PATCH 1/2] fdtdec: optionally add property no-map to created reserved memory node

2020-08-22 Thread Simon Glass
On Thu, 13 Aug 2020 at 03:47, Patrice Chotard wrote: > > From: Etienne Carriere > > Add boolean input argument @no_map to helper function > fdtdec_add_reserved_memory() to add "no-map" property for an added > reserved memory node. This is needed for example when the reserved > memory relates to

Re: [PATCH v2 1/4] firmware: add new driver for SCMI firmwares

2020-08-22 Thread Simon Glass
Hi Etienne, On Tue, 18 Aug 2020 at 09:44, Etienne Carriere wrote: > > This change introduces SCMI agent driver in U-Boot in the firmware > U-class. > > SCMI agent driver is designed for platforms that embed a SCMI server in > a firmware hosted for example by a companion co-processor or the

Re: [PATCH v2 4/4] reset: add reset controller driver for SCMI agents

2020-08-22 Thread Simon Glass
On Tue, 18 Aug 2020 at 09:44, Etienne Carriere wrote: > > This change introduces a reset controller driver for SCMI agent devices. > When SCMI agent and SCMI reset domain drivers are enabled, SCMI agent > binds a reset controller device for each SCMI reset domain protocol > devices enabled in the

Re: [PATCH v2 05/25] pci: pci-uclass: Dynamically allocate the PCI regions

2020-08-22 Thread Simon Glass
On Mon, 17 Aug 2020 at 01:08, Stefan Roese wrote: > > Instead of using a fixed length pre-allocated array of regions, this > patch moves to dynamically allocating the regions based on the number > of available regions plus the necessary regions for DRAM banks. > > Since MAX_PCI_REGIONS is not

Re: [PATCH v4 20/27] Makefile: Warn against using CONFIG_SPL_FIT_GENERATOR

2020-08-22 Thread Simon Glass
Hi Michal, On Mon, 17 Aug 2020 at 00:49, Michal Simek wrote: > > Hi Simon, > > On 16. 08. 20 5:39, Simon Glass wrote: > > Hi Michal, > > > > On Fri, 14 Aug 2020 at 07:28, Michal Simek wrote: > >> > >> Hi Simon, > >> > >> ne 19. 7. 2020 v 22:06 odesílatel Simon Glass napsal: > >>> > >>> This

Re: [PATCH v7 08/10] powerpc: Remove bi_memstart & bi_memsize assignments in spl.c

2020-08-22 Thread Simon Glass
On Wed, 19 Aug 2020 at 22:45, Stefan Roese wrote: > > Most likely these deprecated (removed) variables are not needed. Lets > remove the assignments completely from all spl.c files. > > Signed-off-by: Stefan Roese > Tested-by: Oleksandr Zhadan and Michael Durrant > > --- > > (no changes since

Re: [PATCH v7 04/10] global: Move from bi_memstart/memsize -> gd->ram_base/ram_size

2020-08-22 Thread Simon Glass
On Wed, 19 Aug 2020 at 22:45, Stefan Roese wrote: > > With the planned removal of bi_memstart & bi_memsize, this patch now > moves the references to the better suiting gd->ram_base/ram_size > variables. > > Signed-off-by: Stefan Roese > > --- > > Changes in v7: > - Reword commit text as

Re: [PATCH 1/1] lib/hashtable: remove superfluous check

2020-08-22 Thread Simon Glass
On Thu, 20 Aug 2020 at 11:57, Heinrich Schuchardt wrote: > > We assign first_deleted = 0. There is no need to check its value without > any further assignment in between. > > Signed-off-by: Heinrich Schuchardt > --- > indicated by cppcheck > --- > lib/hashtable.c | 3 +-- > 1 file changed, 1

Re: [PATCH v7 02/10] image: Use gd->ram_base/_size in env_get_bootm_size()

2020-08-22 Thread Simon Glass
On Wed, 19 Aug 2020 at 22:45, Stefan Roese wrote: > > Use only gd->ram_base/_size in env_get_bootm_size() instead of bi_dram[] > in some cases and bi_memstart in others. > > Signed-off-by: Stefan Roese > > --- > > (no changes since v4) > > Changes in v4: > - New patch > > common/image.c | 9

Re: [PATCH] net: ftgmac100: Add support for board specific PHY interface address

2020-08-22 Thread Cédric Le Goater
On 8/18/20 2:08 AM, Thirupathaiah Annapureddy wrote: > ftgmac100 driver is using hard-coded PHY interface address of zero. > Each board can have different PHY interface address (phy_addr). > This commit modifies the driver to make use of board specific address > by leveraging CONFIG_PHY_ADDR. > >

Re: [PATCH v6 0/7] Add MTK AHCI driver, BPI-R64 dts and USB-Nodes for mt7622>

2020-08-22 Thread Frank Wunderlich
Pcie is already merged and usb is v2 https://patchwork.ozlabs.org/project/uboot/list/?series=195873 regards Frank

[PATCH 0/2][v2] Raspberry pi improvements usb core

2020-08-22 Thread Jason Wessel
The original patches have been refactored. It turns out that one of the problems was a dwc2 specific with a stall after a port reset. This means the generic retry code was dropped. The xhci had a similar problem with a retry required for COMP_TX_ERR, and will be sent to the xhci maintainer. The

Re: Chainloading U-Boot from Fastboot on Tegra30

2020-08-22 Thread Peter Geis
On Fri, Aug 21, 2020 at 7:30 PM Peter Geis wrote: > > On Fri, Aug 21, 2020 at 6:41 PM Stephen Warren wrote: > > > > On 8/21/20 3:39 PM, Tom Rini wrote: > > > On Fri, Aug 21, 2020 at 05:30:54PM -0400, Peter Geis wrote: > > >> On Fri, Aug 21, 2020 at 5:04 PM Tom Rini wrote: > > >>> > > >>> On

[PATCH] ARM: dts: stm32: Pull UART4 RX high on AV96

2020-08-22 Thread Marek Vasut
There is no dedicated pull resistor on the AV96 UART4 (console UART) pin. In case there is no UART adapter installed on the AV96, the line is floating and can trigger reception of garbage characters, which in turn can abort U-Boot autoboot. Add default pull up to mitigate this problem.

Re: [PATCH 3/4] dtoc: Add a setup script for Python

2020-08-22 Thread Simon Glass
Allow dtoc to be installed by adding a suitable setup.py script. Signed-off-by: Simon Glass --- tools/dtoc/setup.py | 12 1 file changed, 12 insertions(+) create mode 100644 tools/dtoc/setup.py Applied to u-boot-dm, thanks!

Re: [PATCH 1/2] board_f: Remove dead code from init_func_i2c

2020-08-22 Thread Simon Glass
On Mon, 17 Aug 2020 at 12:31, Ovidiu Panait wrote: > > Since commit 69153988a6f4 ("i2c: Finish dropping use of CONFIG_I2C_HARD") > init_func_i2c is wrapped only by "#if defined(CONFIG_SYS_I2C)". Because > of this, the second ifdef within becomes pointless: > > #if defined(CONFIG_SYS_I2C) >

Re: [PATCH 2/2] sandbox: u-boot.lds: Remove bogus __bss_start symbol

2020-08-22 Thread Simon Glass
On Mon, 17 Aug 2020 at 12:30, Ovidiu Panait wrote: > > The sections described in the sandbox linker script are inserted before > data section via "INSERT BEFORE .data;". Running readelf -S on sandbox > u-boot binary shows that the bss section is located after the data > section: > > Section

[PATCH] mips: dts: Fix PIC32MZDA GPIO register definitions and dtc warnings

2020-08-22 Thread John Robertson
Currently GPIO operations (e.g. gpio status -a) don't work at all. Signed-off-by: John Robertson --- arch/mips/dts/pic32mzda.dtsi | 58 +--- 1 file changed, 34 insertions(+), 24 deletions(-) diff --git a/arch/mips/dts/pic32mzda.dtsi

[PATCH] ARM: dts: stm32: Adjust PLL4 settings on AV96 again

2020-08-22 Thread Marek Vasut
PLL4Q is supplying both FDCAN and LTDC. In case HDMI is in use, the 50 MHz generated from PLL4Q cannot be divided well enough to produce accurate clock for HDMI pixel clock. Adjust it to generate 74.25 MHz instead. The PLL4P/PLL4R are generating 99 MHz instead of 100 MHz, which is in tolerance for

Re: [PATCH 2/2] test: dm: Add test case for devfdt_get_addr_ptr

2020-08-22 Thread Simon Glass
On Mon, 3 Aug 2020 at 13:21, Ovidiu Panait wrote: > > Add flat tree test case to cover devfdt_get_addr_ptr function. > > Signed-off-by: Ovidiu Panait > --- > > test/dm/test-fdt.c | 18 ++ > 1 file changed, 18 insertions(+) Reviewed-by: Simon Glass Applied to u-boot-dm,

Re: [PATCH v5 4/5] test/py: Update test_bind

2020-08-22 Thread Simon Glass
As bind-test is now binded at sandbox startup and no more by test_bind.py, bind-test nodes are not located at the end of "dm tree" output, but can be located everywhere in the tree, so bind-test output could either be: simple_bus0 [ ] generic_simple_bus|-- bind-test phy 0

Re: [PATCH 1/4] binman: Move GetEntryModules() to control

2020-08-22 Thread Simon Glass
When binman is installed its main program is in a different directory to its modules. This means that __file__ is different and we cannot use it to obtain the path to etype/ from main.py To fix this, move the function to the 'control' module, since it is installed with all the other modules,

Please pull u-boot-dm

2020-08-22 Thread Simon Glass
Hi Tom, https://gitlab.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/4466 The following changes since commit 2e6132d835631946b7a67dedd8f5bc902304b0f9: Merge tag 'xilinx-for-v2020.10-rc3' of https://gitlab.denx.de/u-boot/custodians/u-boot-microblaze (2020-08-20 14:46:43 -0400) are

Re: [PATCH 1/2] dm: core: Fix devfdt_get_addr_ptr return value

2020-08-22 Thread Simon Glass
On Mon, 3 Aug 2020 at 13:21, Ovidiu Panait wrote: > > According to the description of devfdt_get_addr_ptr, this function should > return NULL on failure, but currently it returns (void *)FDT_ADDR_T_NONE. > > Fix this by making devfdt_get_addr_ptr return NULL on failure, as > described in the

Re: [PATCH 2/4] binman: Correct some import statements

2020-08-22 Thread Simon Glass
Some of these were not converted when binman moved to use absolute paths. Fix them. Also drop the import of 'test' which is a directory, not a module. Signed-off-by: Simon Glass --- tools/binman/control.py| 4 ++-- tools/binman/ftest.py | 2 +- tools/binman/image_test.py | 2 +-

Re: [PATCH v5 5/5] doc: add bind/unbind command documentation

2020-08-22 Thread Simon Glass
On Tue, 28 Jul 2020 at 01:13, Patrice Chotard wrote: > > Add documentation in doc/drivel-model for the bind/unbind command. > Part of this documentation is extracted from original patch commit > message: > commit 49c752c93a78 ("cmd: Add bind/unbind commands to bind a device to a > driver from

Re: [PATCH 3/3] treewide: convert devfdt_get_addr_ptr() to dev_read_addr_ptr()

2020-08-22 Thread Simon Glass
On Mon, 3 Aug 2020 at 23:15, Masahiro Yamada wrote: > > When you enable CONFIG_OF_LIVE, you will end up with a lot of > conversions. > > To help this tedious work, this commit converts devfdt_get_addr_ptr() > to dev_read_addr_ptr() by coccinelle. I also removed redundant casts > because

Re: [PATCH 4/4] binman: Add a setup script for Python

2020-08-22 Thread Simon Glass
Allow binman to be installed by adding a suitable setup.py script. Signed-off-by: Simon Glass --- tools/binman/setup.py | 12 1 file changed, 12 insertions(+) create mode 100644 tools/binman/setup.py Applied to u-boot-dm, thanks!

Re: [PATCH v5 3/5] sandbox: dts: Add compatible string for bind-test node

2020-08-22 Thread Simon Glass
On Tue, 28 Jul 2020 at 01:13, Patrice Chotard wrote: > > Usage of lists_bind_fdt() in bind command imposes to add > a compatible string for bind-test node. > > Others impacts are: > - bind-test node is binded at sandbox start, so no need to bind it > in test_bind_unbind_with_node() test. >

Re: [PATCH 1/1] dm: fix ofnode_read_addr/size_cells()

2020-08-22 Thread Simon Glass
On 25.07.20 21:38, Heinrich Schuchardt wrote: > In the case of the live tree ofnode_read_addr_cells() and > ofnode_read_size_cells() return the #address-cells and #size-cells defined > in the parent node. With the patch the same is done for a non-live tree. > > The only consumer of these functions

Re: [PATCH 2/3] ata: mvebu: use dev_read_addr() to get base address

2020-08-22 Thread Simon Glass
On 04.08.20 07:14, Masahiro Yamada wrote: > It is strange to use devfdt_get_addr_ptr(), then cast the pointer > back to ulong because you could use devfdt_get_addr() without casting. > > Convert it to dev_read_addr(), which is capable to CONFIG_OF_LIVE. > > Signed-off-by: Masahiro Yamada > --- >

Re: [PATCH v2] dtoc: add coverage test for unicode error

2020-08-22 Thread Simon Glass
Add an additional test to dtoc in order improve the coverage, specifically to take into account the case of unicode error when scanning drivers. Signed-off-by: Walter Lozano --- Changes in v2: - Add missing files - Extend scan_drivers to use both relative and absolute paths

Re: [PATCH v5 2/5] sandbox: phy: add driver_data for bind test cmd

2020-08-22 Thread Simon Glass
Add driver data to existing compatible string "sandbox,phy". Add an additional compatible string without driver_data This will verify that bind command parses, finds and passes the correct driver data to device_bind_with_driver_data() by using driver_data in the second sandbox_phy_ids table

Re: [PATCH] arm: dts: fix ast2500-evb inclusion for correct target

2020-08-22 Thread Thirupathaiah Annapureddy
On 8/20/2020 5:03 PM, Tom Rini wrote: > On Thu, Aug 20, 2020 at 02:09:55PM -0700, Thirupathaiah Annapureddy wrote: >> Hi Ryan, >> >> Thanks for reviewing the patch. Please see my comment(s): >> >> On 8/19/2020 7:06 PM, Ryan Chen wrote: >>> Hi -Original Message- From: