Re: [RFC 1/1] doc/build/gcc.rst: required packages for Suse

2020-09-22 Thread Heinrich Schuchardt
On 9/22/20 5:57 PM, Matthias Brugger wrote: > Hi Heinrich, > > On 20/09/2020 12:09, Heinrich Schuchardt wrote: >> Describe the packages required to build U-Boot on Suse. >> >> Signed-off-by: Heinrich Schuchardt >> --- >> Hello Matthias, >> >> I would like to add a sub-chapter to our documentation

Re: [PATCH test hooks 1/1] u-boot-hooks: add virtio-rng-pci

2020-09-22 Thread Stephen Warren
On 9/22/20 12:27 PM, Heinrich Schuchardt wrote: > In the UEFI subsystem we test the RNG device. > On QEMU it is provided via '-device virtio-rng-pci'. > > We need to add this PCI device before enable DM_RNG on ARCH_ARM. Applied, thanks.

Re: [PATCH 1/1] arm: enable DM_RNG on QEMU by default

2020-09-22 Thread Heinrich Schuchardt
On 9/22/20 5:26 PM, Tom Rini wrote: > On Sat, Sep 19, 2020 at 07:55:35AM +0200, Heinrich Schuchardt wrote: > >> The EFI_RNG_PROTOCOL is needed for address randomization in Linux. >> We should provide it by default on QEMU. >> >> Reported-by: François Ozog >> Signed-off-by: Heinrich Schuchardt >

Re: [PATCH 1/1] examples: make examples customizable

2020-09-22 Thread Tom Rini
On Tue, Sep 22, 2020 at 08:03:49PM +0200, Heinrich Schuchardt wrote: > Most users don't need the standalone API examples. Distributions like Suse > do not supply libgcc for cross-compiling and we cannot do without on ARMv8 > for building examples/. > > Make examples customizable via symbol

[PATCH v4 07/59] x86: Add a common global NVS structure

2020-09-22 Thread Simon Glass
Add the definition of this structure common to Intel devices. It includes some optional Chrome OS pieces which are used when vboot is integrated. Drop the APL version as it is basically the same. Signed-off-by: Simon Glass --- (no changes since v1) Changes in v1: - Use this file in APL

[PATCH v4 03/59] x86: acpi: apl: Add asl files for Apollo Lake

2020-09-22 Thread Simon Glass
Add Apollo Lake ASL files, taken from coreboot. Signed-off-by: Simon Glass --- (no changes since v1) .../include/asm/arch-apollolake/acpi/dptf.asl | 35 .../asm/arch-apollolake/acpi/globalnvs.asl| 41 .../include/asm/arch-apollolake/acpi/gpio.asl | 191 ++

[PATCH v4 09/59] x86: acpi: Expand the GNVS

2020-09-22 Thread Simon Glass
Expand this to 4KB so that it is possible to add custom information to it. On Chromebooks this is used to pass verified-boot information. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/include/asm/acpi/global_nvs.h | 2 +- arch/x86/include/asm/intel_gnvs.h | 1 + 2 files

[PATCH v4 10/59] x86: coral: Add ACPI tables for coral

2020-09-22 Thread Simon Glass
This device has a large set of ACPI tables. Bring these in from coreboot so that full functionality is available (apart from SMI). Signed-off-by: Simon Glass --- Changes in v4: - Add logging when writinge NHLT - Change table version to 3 Changes in v1: - Add NHLT audio support - Capitalise

[PATCH v4 12/59] acpi: Add support for conditions and return values

2020-09-22 Thread Simon Glass
Add functions to support generating ACPI code for condition checks and return values. Signed-off-by: Simon Glass --- (no changes since v1) include/acpi/acpigen.h | 93 ++ lib/acpi/acpigen.c | 68 ++ test/dm/acpigen.c

[PATCH v4 08/59] x86: acpi: Support external GNVS tables

2020-09-22 Thread Simon Glass
At present U-Boot puts a magic number in the ASL for the GNVS table and searches for it later. Add a Kconfig option to use a different approach, where the ASL files declare the table as an external symbol. U-Boot can then put it wherever it likes, without any magic numbers or searching.

[PATCH v4 27/59] x86: acpi: Add PCT and PTC tables

2020-09-22 Thread Simon Glass
These are needed for the CPU tables. Add them into an x86-specific file since we do not support them on sandbox, or include tests. Signed-off-by: Simon Glass --- (no changes since v1) Changes in v1: - Split PCT and PTC tables into a separate patch arch/x86/include/asm/acpigen.h | 35

[PATCH v4 29/59] x86: acpi: Add common Intel ACPI tables

2020-09-22 Thread Simon Glass
Add various tables that are common to Intel CPUs. These functions can be used by arch-specific CPU code. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/cpu/intel_common/Makefile | 2 + arch/x86/cpu/intel_common/acpi.c | 377 +

[PATCH v4 28/59] acpi: Add more support for generating processor tables

2020-09-22 Thread Simon Glass
This adds tables relating to P-States and C-States. Signed-off-by: Simon Glass --- (no changes since v1) include/acpi/acpigen.h | 162 +++ lib/acpi/acpigen.c | 167 +++ test/dm/acpigen.c | 294 + 3 files

[PATCH v4 30/59] x86: Support Atom SoCs using SWSMISCI rather than the SWSCI

2020-09-22 Thread Simon Glass
Some Atom SoCs use SWSMISCI for SMI control. Add a Kconfig to select this. It is used on Apollo Lake. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/Kconfig| 6 ++ arch/x86/cpu/apollolake/Kconfig | 1 + 2 files changed, 7 insertions(+) diff --git

[PATCH v4 26/59] acpi: Add support for generating processor tables

2020-09-22 Thread Simon Glass
ACPI has a number of CPU-related tables. Add utility functions to write out the basic packages. Signed-off-by: Simon Glass --- (no changes since v1) include/acpi/acpigen.h | 39 +++ lib/acpi/acpigen.c | 55 + test/dm/acpigen.c | 106

[PATCH v4 32/59] x86: apl: Allow reading hostbridge base addresses

2020-09-22 Thread Simon Glass
Add a few functions to permit reading of various useful base addresses provided by the hostbridge. Signed-off-by: Simon Glass --- (no changes since v1) Changes in v1: - Add comments arch/x86/cpu/apollolake/hostbridge.c | 27

Re: [RFC PATCH] dm: add cells_count parameter in *_count_phandle_with_args

2020-09-22 Thread Simon Glass
On Thu, 10 Sep 2020 at 10:44, Patrick Delaunay wrote: > > The cell_count argument is required when cells_name is NULL. > > This patch adds this parameter in live tree API > - of_count_phandle_with_args > - ofnode_count_phandle_with_args > - dev_count_phandle_with_args > > This parameter solves

Re: [PATCH 4/4] configs: smdkv310: get rid of unused EXYNOS4_DEFAULT_UART_OFFSET

2020-09-22 Thread Simon Glass
On Thu, 17 Sep 2020 at 00:52, Andre Heider wrote: > > Unused. > > Signed-off-by: Andre Heider > --- > include/configs/smdkv310.h | 3 --- > 1 file changed, 3 deletions(-) > Reviewed-by: Simon Glass

Re: [PATCH 1/4] treewide: configs: get rid of unused CONFIG_DEFAULT_CONSOLE

2020-09-22 Thread Simon Glass
On Thu, 17 Sep 2020 at 00:52, Andre Heider wrote: > > These are all unused. > > Signed-off-by: Andre Heider > --- > This sets completely removes CONFIG_DEFAULT_CONSOLE from the tree. > Only compile time tested. > > include/configs/arndale.h | 2 -- > include/configs/espresso7420.h | 3 ---

Re: [PATCH 1/1] examples: make examples customizable

2020-09-22 Thread Heinrich Schuchardt
On 9/22/20 8:42 PM, Tom Rini wrote: > On Tue, Sep 22, 2020 at 08:03:49PM +0200, Heinrich Schuchardt wrote: > >> Most users don't need the standalone API examples. Distributions like Suse >> do not supply libgcc for cross-compiling and we cannot do without on ARMv8 >> for building examples/. >> >>

Re: [PATCH 1/2] log: allow for message continuation

2020-09-22 Thread Simon Glass
Hi Heinrich, On Thu, 17 Sep 2020 at 06:19, Heinrich Schuchardt wrote: > > Some drivers use macro pr_cont() for continuing a message sent via printk. > Hence if we want to convert printk messaging to using the logging system, > we must support continuation of log messages too. > > As pr_cont()

[PATCH v4 58/59] acpi: Add more documentation for struct acpi_gpio

2020-09-22 Thread Simon Glass
Add some documentation provided by Andy Shevchenko to describe how to use struct acpi_gpio. Signed-off-by: Simon Glass --- Changes in v4: - Add Andy's documentation to struct acpi_gpio include/acpi/acpi_device.h | 22 ++ 1 file changed, 22 insertions(+) diff --git

[PATCH v4 53/59] x86: fsp: Show FSP-S or FSP-M address in fsp_get_header()

2020-09-22 Thread Simon Glass
At present this function only supports FSP-M but it is also used to read FSP-S, in which case FSP-M may be zero. Add support for showing whichever address is present in the FSP binary. Also change the debug() statements to log_debug() while here. Signed-off-by: Simon Glass Reviewed-by: Bin Meng

Re: [PATCH 1/1] examples: make examples customizable

2020-09-22 Thread Simon Glass
Hi Heinrich, On Tue, 22 Sep 2020 at 12:04, Heinrich Schuchardt wrote: > > Most users don't need the standalone API examples. Distributions like Suse > do not supply libgcc for cross-compiling and we cannot do without on ARMv8 > for building examples/. > > Make examples customizable via symbol

[PATCH v4 59/59] acpi: Use I2cSerialBusV2() instead of I2cSerialBus()

2020-09-22 Thread Simon Glass
Use the correct name of the ACPI structure being created. Signed-off-by: Simon Glass --- Changes in v4: - Add new patch to use I2cSerialBusV2() instead of I2cSerialBus() include/acpi/acpi_device.h | 2 +- lib/acpi/acpi_device.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

Re: Question: Chromebook Flip C100p Uboot build and flash

2020-09-22 Thread Simon Glass
Hi Ning, On Mon, 14 Sep 2020 at 13:26, zhangn1...@outlook.com wrote: > > Hi, Simon > > I find a guide in mainline uboot code, which updated by you. > This guide is for chromebook_jerry, can it apply to Flip C100p (minnie)? > > If it can apply to minnie, my understanding are: > Build

Re: [PATCH v2 1/3] global_data.h: convert GD_FLG_* to enum

2020-09-22 Thread Simon Glass
On Sun, 20 Sep 2020 at 02:04, Heinrich Schuchardt wrote: > > Sphinx documentation is only available for enums not for #defines. > Anyway it is better to keep related definitions in an enum. > > Signed-off-by: Heinrich Schuchardt > --- > v2: > enum gd_flags must not be exposed to

Re: [PATCH v2] arm: rmobile: Use imply for BOARD_EARLY_INIT_F

2020-09-22 Thread Marek Vasut
On 9/22/20 2:06 PM, Biju Das wrote: > Use "imply" instead of "select" for BOARD_EARLY_INIT_F config option, > and then disable it on boards which don't need it. > > Updated grpeach_defconfig to disable CONFIG_BOARD_EARLY_INIT_F option for > RZA1. Applied to sh/next, thanks.

Re: u-boot leaves watchdog enabled by default

2020-09-22 Thread Michael Walle
Hi, Am 2020-09-22 14:36, schrieb Tom Rini: On Tue, Sep 22, 2020 at 08:59:00AM +0200, Michael Walle wrote: Hi, Am 2020-09-22 03:18, schrieb Tom Rini: > On Mon, Sep 21, 2020 at 10:56:14PM +0200, Michael Walle wrote: > > Hi, > > [..] > > > > >>> >> called in the bootefi case. So even if I'd

Re: [PATCH] net: ravb: Remove writeext function call

2020-09-22 Thread Marek Vasut
On 9/22/20 8:51 AM, Biju Das wrote: > The micrel phy driver is already configuring this values from > device tree. So remove the redundant phy configuration call from > this driver. Applied to sh/next, thanks

Re: [PATCH] board: renesas: Remove empty s_init function

2020-09-22 Thread Marek Vasut
On 9/22/20 10:41 AM, Biju Das wrote: > Default s_init weak function available, so remove the > s_init empty function. Applied to sh/next, thanks

Re: [PATCH] arm: mach-rmobile: Mark the default s_init function as weak

2020-09-22 Thread Marek Vasut
On 9/22/20 10:09 AM, Biju Das wrote: > Mark the default s_init function as weak, so that SoC's can > override it if needed, and it will still be discarded if unused. Applied to sh/next, thanks

Re: [PATCH v3 02/57] x86: acpi: Add base asl files for common x86 devices

2020-09-22 Thread Simon Glass
Hi Wolfgang, On Mon, 21 Sep 2020 at 07:50, Wolfgang Wallner wrote: > > Hi Simon, > > -"Simon Glass" schrieb: - > > Betreff: [PATCH v3 02/57] x86: acpi: Add base asl files for common x86 > > devices > > > > Add common x86 ASL files, taken from coreboot. > > > > Signed-off-by: Simon

Re: [PATCH] x86: Drop duplicate declaration of emulator state

2020-09-22 Thread Simon Glass
Hi Bin, On Sun, 20 Sep 2020 at 19:58, Bin Meng wrote: > > Hi Simon, > > On Sun, Sep 6, 2020 at 3:15 AM Simon Glass wrote: > > > > With x86 we can execute an option ROM either natively or using the x86 > > emulator (if enabled with CONFIG_BIOSEMU). Both of these share the > > _X86EMU_env

[PATCH 1/1] examples: make examples customizable

2020-09-22 Thread Heinrich Schuchardt
Most users don't need the standalone API examples. Distributions like Suse do not supply libgcc for cross-compiling and we cannot do without on ARMv8 for building examples/. Make examples customizable via symbol CONFIG_EXAMPLES. It only defaults to yes to ensure that we compile it on Gitlab CI.

[PATCH 1/1] examples: make examples customizable

2020-09-22 Thread Heinrich Schuchardt
Most users don't need the standalone API examples. Distributions like Suse do not supply libgcc for cross-compiling and we cannot do without on ARMv8 for building examples/. Make examples customizable via symbol CONFIG_EXAMPLES. It only defaults to yes to ensure that we compile it on Gitlab CI.

[PATCH test hooks 1/1] u-boot-hooks: add virtio-rng-pci

2020-09-22 Thread Heinrich Schuchardt
In the UEFI subsystem we test the RNG device. On QEMU it is provided via '-device virtio-rng-pci'. We need to add this PCI device before enable DM_RNG on ARCH_ARM. Signed-off-by: Heinrich Schuchardt --- Tested on Gitlab CI:

[PATCH v4 06/59] x86: Add a config for the systemagent PCIEX regions size

2020-09-22 Thread Simon Glass
Add a way to specify the required size for this region. This is used when generating ACPI tables. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/Kconfig| 18 ++ arch/x86/cpu/apollolake/Kconfig | 1 + 2 files changed, 19 insertions(+) diff --git

[PATCH v4 02/59] x86: acpi: Add base asl files for common x86 devices

2020-09-22 Thread Simon Glass
Add common x86 ASL files, taken from coreboot. Signed-off-by: Simon Glass Tested-by: Wolfgang Wallner --- (no changes since v1) arch/x86/include/asm/acpi/chromeos.asl| 108 + arch/x86/include/asm/acpi/cpu.asl | 25 arch/x86/include/asm/acpi/cros_gnvs.asl |

[PATCH v4 05/59] x86: apl: Correct PCIE_ECAM_BASE

2020-09-22 Thread Simon Glass
This value is incorrect and causes problems booting Linux. Fix it. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) board/google/chromebook_coral/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/google/chromebook_coral/Kconfig

[PATCH v4 01/59] x86: acpi: Add cros_ec tables

2020-09-22 Thread Simon Glass
Add ASL files for the Chrome OS EC, taken from coreboot. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/include/asm/acpi/cros_ec/ac.asl | 22 + arch/x86/include/asm/acpi/cros_ec/als.asl | 56 ++ arch/x86/include/asm/acpi/cros_ec/battery.asl | 411 +

[PATCH v4 00/59] dm: Add programatic generation of ACPI tables (part D)

2020-09-22 Thread Simon Glass
Note: This is part D of this effort. With this, Coral includes all required ACPI tables. At present on x86 U-Boot supports creating ACPI (Advanced Configuration and Power Interface) tables using the Intel ACPI Source Language (ASL) compiler. This is good enough for basic operation but some

[PATCH v4 04/59] x86: acpi: Add DPTF asl files

2020-09-22 Thread Simon Glass
Add common DPTF (Intel Dynamic Performance and Thermal Framework) files, taken from coreboot. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/include/asm/acpi/dptf/charger.asl | 65 +++ arch/x86/include/asm/acpi/dptf/cpu.asl | 186

[PATCH v4 46/59] x86: Correct handling of MADT table CPUs

2020-09-22 Thread Simon Glass
At present if hyperthreading is disabled the CPU numbering is not sequential. Fix this. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/lib/acpi_table.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/arch/x86/lib/acpi_table.c

[PATCH v4 47/59] acpi: tpm: Add a TPM2 table

2020-09-22 Thread Simon Glass
This provides information about a v2 TPM in the system. Generate this table if the TPM is present. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/lib/acpi_table.c | 74 +++ include/acpi/acpi_table.h | 11 ++ include/bloblist.h| 1

[PATCH v4 50/59] x86: coral: Add audio descriptor files

2020-09-22 Thread Simon Glass
Add files describing the various audio configurations supported on coral. These are passed to Linux in the ACPI tables. Signed-off-by: Simon Glass --- (no changes since v1) Changes in v1: - Add new patch with coral audio descriptor files .../chromebook_coral/dialog-2ch-48khz-24b.dat| Bin

[PATCH v4 48/59] acpi: tpm: Add a TPM1 table

2020-09-22 Thread Simon Glass
This provides information about a v1 TPM in the system. Generate this table if the TPM is present. Add a required new bloblist type and correct the header order of one header file. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/lib/acpi_table.c | 54

[PATCH v4 49/59] x86: acpi: Set the log category for x86 table generation

2020-09-22 Thread Simon Glass
This file doesn't currently have a log category. Add one so that items are logged correctly. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) arch/x86/lib/acpi_table.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/lib/acpi_table.c

[PATCH v4 52/59] x86: fsp: Add more debugging for silicon init

2020-09-22 Thread Simon Glass
If locating the FSP header hangs for whatever reason it is useful to see where it got stuck. Add a debug print. Also show the address of the FSP-S entry point as a sanity check. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) arch/x86/lib/fsp2/fsp_silicon_init.c |

[PATCH v4 43/59] x86: Notify the FSP of the 'end firmware' event

2020-09-22 Thread Simon Glass
Send this notification when U-Boot is about to boot into Linux, as requested by the FSP. Currently this causes a crash with the APL FSP, so leave it disabled for now. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/cpu/cpu.c| 15 +++

[PATCH v4 45/59] x86: Add a header guard to asm/acpi_table.h

2020-09-22 Thread Simon Glass
This file cannot currently be included in ASL files. Add a header guard to permit this. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) arch/x86/include/asm/acpi_table.h | 4 1 file changed, 4 insertions(+) diff --git a/arch/x86/include/asm/acpi_table.h

Re: [PATCH 3/3] doc: global data pointer

2020-09-22 Thread Simon Glass
On Sat, 19 Sep 2020 at 10:10, Heinrich Schuchardt wrote: > > Add the description of the global data pointer to the generated HTML > documentation. > > Signed-off-by: Heinrich Schuchardt > --- > doc/develop/global_data.rst | 53 + > doc/develop/index.rst

Re: [PATCH 2/2] test: log: test message continuation

2020-09-22 Thread Simon Glass
On Thu, 17 Sep 2020 at 06:19, Heinrich Schuchardt wrote: > > Provide a unit test checking that a continuation message will use the same > log level and log category as the previous message. > > Signed-off-by: Heinrich Schuchardt > --- > test/log/Makefile| 4 +++- > test/log/cont_test.c |

Re: [PATCH 2/4] treewide: configs: fold CONFIG_DEFAULT_CONSOLE

2020-09-22 Thread Simon Glass
On Thu, 17 Sep 2020 at 00:52, Andre Heider wrote: > > In prepartion to remove CONFIG_DEFAULT_CONSOLE, fold the current users. > > Signed-off-by: Andre Heider > --- > include/configs/odroid.h| 7 +-- > include/configs/odroid_xu3.h| 6 +- > include/configs/s5p_goni.h

Re: [PATCH 2/3] global_data.h: add Sphinx documentation

2020-09-22 Thread Simon Glass
On Sat, 19 Sep 2020 at 10:10, Heinrich Schuchardt wrote: > > Add the missing Sphinx documentation for struct global_data and > gd_board_type(). > > Signed-off-by: Heinrich Schuchardt > --- > include/asm-generic/global_data.h | 357 ++ > 1 file changed, 309

Re: [PATCH 1/2] log: allow for message continuation

2020-09-22 Thread Heinrich Schuchardt
On 9/22/20 8:48 PM, Simon Glass wrote: > Hi Heinrich, > > On Thu, 17 Sep 2020 at 06:19, Heinrich Schuchardt wrote: >> >> Some drivers use macro pr_cont() for continuing a message sent via printk. >> Hence if we want to convert printk messaging to using the logging system, >> we must support

[PATCH v4 24/59] x86: acpi: Support generation of the HPET table

2020-09-22 Thread Simon Glass
Add an implementation of the HPET (High Precision Event Timer) ACPI table. Since this is x86-specific, put it in an x86-specific file Signed-off-by: Simon Glass --- (no changes since v1) Changes in v1: - Put this code in an x86-specific place and update commit message

[PATCH v4 25/59] x86: acpi: Support generation of the DBG2 table

2020-09-22 Thread Simon Glass
Add an implementation of the DBG2 (Debug Port Table 2) ACPI table. Adjust one of the header includes to be in the correct order, before adding more. Note that the DBG2 table is generic but the PCI UART is x86-specific at present since it assumes an ns16550 UART. It can be generalised later if

[PATCH v4 22/59] x86: apl: Update iomap for ACPI

2020-09-22 Thread Simon Glass
Add some more definitions to the iomap. These will be used by ACPI-generation code as well as the device tree. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/include/asm/arch-apollolake/iomap.h | 16 1 file changed, 16 insertions(+) diff --git

[PATCH v4 23/59] x86: Add a few common Intel CPU functions

2020-09-22 Thread Simon Glass
Add functions to query CPU information, needed for ACPI. Signed-off-by: Simon Glass --- (no changes since v1) Changes in v1: - Add more comments and rename cpu_get_bus_clock to cpu_get_bus_clock_khz() arch/x86/cpu/intel_common/cpu.c | 64 +++

[PATCH v4 20/59] x86: Add some definitions for SMM

2020-09-22 Thread Simon Glass
U-Boot does not support SMM (System Management Mode) at present, but needs a few definitions to correctly set up the ACPI table. Add these. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/include/asm/smm.h | 27 +++ 1 file changed, 27 insertions(+)

[PATCH v4 57/59] x86: coral: Update config and device tree for ACPI

2020-09-22 Thread Simon Glass
Enable new features and provide require device-tree config so that U-Boot produces the correct ACPI tables on Coral. Signed-off-by: Simon Glass --- Changes in v4: - Correct DPTF enable property - Correct compatible string for gma device Changes in v3: - Rebase to master Changes in v2: -

[PATCH v4 56/59] x86: Move include of bitops out of ACPI region

2020-09-22 Thread Simon Glass
At present linux/bitops.h is included in ACPI code. This is not needed and can cause a problem in fls64.h since BITS_PER_LONG is not defined. Move the #include into the part not used by ACPI. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v2) Changes in v2: - Add new

[PATCH v4 55/59] x86: Add a way to add to the e820 memory table

2020-09-22 Thread Simon Glass
Some boards want to reserve extra regions of memory. Add a 'chosen' property to support this. Reviewed-by: Bin Meng Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/lib/fsp/fsp_dram.c | 17 + doc/device-tree-bindings/chosen.txt | 18 ++ 2

[PATCH v4 54/59] acpi: Use defines for field lengths

2020-09-22 Thread Simon Glass
A few fields have an open-coded length. Use the defines for this purpose instead. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) include/acpi/acpi_table.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/acpi/acpi_table.h

[PATCH v4 51/59] x86: apl: Check low-level init in FSP-S pre-init

2020-09-22 Thread Simon Glass
If U-Boot is not running FSP-S it should not do the pre-init either. Add a condition to handle this. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/cpu/apollolake/fsp_s.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/cpu/apollolake/fsp_s.c

Re: [PATCH 1/1] MAINTAINERS: assign doc/arch/sandbox.rst

2020-09-22 Thread Simon Glass
On Sat, 19 Sep 2020 at 12:05, Heinrich Schuchardt wrote: > > Add doc/arch/sandbox.rst to the scope of SANDBOX. > > Signed-off-by: Heinrich Schuchardt > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Simon Glass

Re: [PATCH 3/4] Remove whitelist entry CONFIG_DEFAULT_CONSOLE

2020-09-22 Thread Simon Glass
On Thu, 17 Sep 2020 at 00:52, Andre Heider wrote: > > There're no users left. > > Signed-off-by: Andre Heider > --- > scripts/config_whitelist.txt | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Simon Glass

Re: [PATCH 1/3] global_data.h: convert GD_FLG_* to enum

2020-09-22 Thread Simon Glass
Hi Heinrich, On Sat, 19 Sep 2020 at 10:05, Heinrich Schuchardt wrote: > > Sphinx documentation is only available for enums not for #defines. > Anyway it is better to keep related definitions in an enum. > > Signed-off-by: Heinrich Schuchardt > --- > include/asm-generic/global_data.h | 104

Re: [PATCH 1/1] doc/arch/sandbox.rst: reformat command line options

2020-09-22 Thread Simon Glass
On Sat, 19 Sep 2020 at 12:05, Heinrich Schuchardt wrote: > > Reformat the command line options chapter so that the command line options > clearly stand out. > > Signed-off-by: Heinrich Schuchardt > --- > doc/arch/sandbox.rst | 57 +--- > 1 file changed,

Re: [PATCH 1/3] global_data.h: convert GD_FLG_* to enum

2020-09-22 Thread Heinrich Schuchardt
On 9/22/20 8:49 PM, Simon Glass wrote: > Hi Heinrich, > > On Sat, 19 Sep 2020 at 10:05, Heinrich Schuchardt wrote: >> >> Sphinx documentation is only available for enums not for #defines. >> Anyway it is better to keep related definitions in an enum. >> >> Signed-off-by: Heinrich Schuchardt >>

[PATCH v4 18/59] x86: apl: Support writing the IntelGraphicsMem table

2020-09-22 Thread Simon Glass
This table is needed by the Linux graphics driver to handle graphics correctly. Write it to ACPI. Signed-off-by: Simon Glass --- (no changes since v1) Changes in v1: - Capitalise ACPI_OPS_PTR - Don't build for SPL arch/x86/Kconfig | 8 +

[PATCH v4 16/59] i2c: Add a generic driver to generate ACPI info

2020-09-22 Thread Simon Glass
Many I2C devices produce roughly the same ACPI data with just things like the GPIO/interrupt information being different. This can be handled by a generic driver along with some information in the device tree. Add a generic i2c driver for this purpose. Signed-off-by: Simon Glass Reviewed-by:

[PATCH v4 14/59] dm: acpi: Use correct GPIO polarity type in acpi_dp_add_gpio()

2020-09-22 Thread Simon Glass
This function currently accepts the IRQ-polarity type. Fix it to use the GPIO type instead. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - add new patch to fix polarity type in acpi_dp_add_gpio() drivers/sound/max98357a.c | 2 +- include/acpi/acpi_dp.h| 2 +-

[PATCH v4 11/59] acpi: Add support for writing a _PRW

2020-09-22 Thread Simon Glass
A 'Power Resource for Wake' list the resources a device depends on for wake. Add a function to generate this. Signed-off-by: Simon Glass --- Changes in v4: - Correct comment for dm_test_acpi_write_prw() include/acpi/acpigen.h | 10 ++ lib/acpi/acpigen.c | 10 ++

[PATCH v4 17/59] x86: Add wake sources for the acpi_gpe driver

2020-09-22 Thread Simon Glass
Some devices can wake the system from sleep, e.g opening the lid on a clamshell or moving a USB mouse. Add a wake to specify this for USB devices and add the settings for Apollo Lake. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/include/asm/arch-apollolake/gpe.h | 135

[PATCH v4 15/59] x86: link: Allow more space for U-Boot

2020-09-22 Thread Simon Glass
The extra ACPI code increases U-Boot above it current size limit. Move the start earlier to provide space. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v2) Changes in v2: - Add new patch to allow more space for U-Boot on link configs/chromebook_link_defconfig | 2

[PATCH v4 13/59] acpi: Support generating a multi-function _DSM for devices

2020-09-22 Thread Simon Glass
Add a function to generate ACPI code for a _DSM method for a device. This includes functions for starting and ending each part of the _DSM. Signed-off-by: Simon Glass --- (no changes since v1) include/acpi/acpi_device.h | 14 + include/acpi/acpigen.h | 99

[PATCH v4 21/59] x86: apl: Add power-management definitions

2020-09-22 Thread Simon Glass
Add SCI and power-state definitions required by ACPI tables. Fix the license to match the original source file. Als update the guard on acpi_pmc.h to avoid an error when buiding ASL. Signed-off-by: Simon Glass --- (no changes since v1) Changes in v1: - Use SHIFT and MASK for defines

[PATCH v4 19/59] x86: acpi: Add a common routine to write WiFi info

2020-09-22 Thread Simon Glass
Intel WiFi chips can use a common routine to write the information needed by linux. Add an implementation of this. Enable it for coral. Signed-off-by: Simon Glass --- (no changes since v1) Changes in v1: - Capitalise ACPI_OPS_PTR - Use acpi,ddn instead of acpi,desc arch/x86/Kconfig

[PATCH v4 38/59] x86: apl: Drop unnecessary code in PMC driver

2020-09-22 Thread Simon Glass
We don't have CONFIG_PCI in TPL but it is present in SPL, etc. So this code is not needed. Drop it, and fix a code-style nit just above. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/cpu/apollolake/pmc.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git

[PATCH v4 34/59] x86: apl: Generate required ACPI tables

2020-09-22 Thread Simon Glass
Add support for generating various ACPI tables for Apollo Lake. Add a few S3 definitions that are needed. Signed-off-by: Simon Glass --- (no changes since v1) Changes in v1: - Drop unnecessary callbacks arch/x86/cpu/apollolake/Makefile| 1 + arch/x86/cpu/apollolake/acpi.c

[PATCH v4 37/59] x86: apl: Generate ACPI table for LPC

2020-09-22 Thread Simon Glass
Add an ACPI table for the LPC on Apollo Lake. Signed-off-by: Simon Glass --- (no changes since v1) Changes in v1: - Capitalise ACPI_OPS_PTR arch/x86/cpu/apollolake/lpc.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/x86/cpu/apollolake/lpc.c

[PATCH v4 35/59] x86: apl: Add support for hostbridge ACPI generation

2020-09-22 Thread Simon Glass
Support generating a DMAR table and add a few helper routines as well. Also set up NHLT so that audio works. Signed-off-by: Simon Glass --- Changes in v4: Drop extra acpi_align() in apl_acpi_hb_write_tables() Changes in v1: - Add support for NHLT table - Capitalise ACPI_OPS_PTR - Move the

[PATCH v4 31/59] x86: acpi: Add support for additional Intel tables

2020-09-22 Thread Simon Glass
Apollo Lake needs to generate a few more table types used on Intel SoCs. Add support for these into the x86 ACPI code. Signed-off-by: Simon Glass --- (no changes since v1) Changes in v1: - Move this code into an x86-specific file - Update commit message - Use OEM_TABLE_ID instead of

[PATCH v4 40/59] x86: fsp: Update the FSP API with the end-firmware method

2020-09-22 Thread Simon Glass
This new method is intended to be called when UEFI shuts down the 'boot services', i.e. any lingering code in the boot loader that might be used by the OS. Add a definition for this new method and update the comments a little. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes

[PATCH v4 44/59] x86: Correct the assembly guard in e820.h

2020-09-22 Thread Simon Glass
This is currently in the wrong place, so including the file in the device tree fails. Fix it. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) Changes in v1: - Update commit message with a comma arch/x86/include/asm/e820.h | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH v4 42/59] x86: Sort the MTRR table

2020-09-22 Thread Simon Glass
At present the MTRR registers are programmed with the list the U-Boot builds up in the same order. In some cases this list may be out of order. It looks better in Linux to have the registers in order, so sort them, Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/cpu/mtrr.c | 12

[PATCH v4 39/59] tpm: cr50: Add ACPI support

2020-09-22 Thread Simon Glass
Generate ACPI information for this device so that Linux can use it correctly. Signed-off-by: Simon Glass --- (no changes since v1) Changes in v1: - Capitalise ACPI_OPS_PTR - Update for acpi_device_write_i2c_dev() return-value change - Use acpi,ddn instead of acpi,desc drivers/tpm/cr50_i2c.c

[PATCH v4 41/59] x86: cpu: Report address width from cpu_get_info()

2020-09-22 Thread Simon Glass
Add support for this new field in the common code used by most x86 CPU drivers. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/cpu/i386/cpu.c | 23 +++ arch/x86/cpu/intel_common/cpu.c | 1 + arch/x86/cpu/x86_64/cpu.c | 5 +

[PATCH v4 36/59] x86: apl: Generate CPU tables

2020-09-22 Thread Simon Glass
Add ACPI generation to the APL CPU driver. Signed-off-by: Simon Glass --- (no changes since v1) Changes in v1: - Capitalise ACPI_OPS_PTR - Handle table generation without callbacks arch/x86/cpu/apollolake/cpu.c | 77 ++ arch/x86/lib/Makefile | 3

[PATCH v4 33/59] p2sb: Add some definitions used for ACPI

2020-09-22 Thread Simon Glass
Allow this header to be included in ASL files by adding a header guard and a few definitions that are needed. Signed-off-by: Simon Glass --- (no changes since v1) include/p2sb.h | 8 1 file changed, 8 insertions(+) diff --git a/include/p2sb.h b/include/p2sb.h index

RE: [PATCH 1/2] arm: rmobile: Add RZ/G2M SoC

2020-09-22 Thread Biju Das
Hi Marek, > -Original Message- > From: Biju Das > Sent: 21 September 2020 18:30 > To: Marek Vasut ; Nobuhiro Iwamatsu > > Cc: u-boot@lists.denx.de; Chris Paterson ; > Prabhakar Mahadev Lad > Subject: RE: [PATCH 1/2] arm: rmobile: Add RZ/G2M SoC > > > Hi Marek, > > Thanks for the

[PATCH] board: renesas: draak: Drop CA57 reset

2020-09-22 Thread Biju Das
Renesas Draak board based on R-Car D3 has single CA53. This patch drops check for cputype from reset_cpu() and also drops the corresponding CA57 macros. While at it also dropped RST_RSTOUTCR macro which is unused. Signed-off-by: Biju Das Reviewed-by: Lad Prabhakar ---

[PATCHv6 18/18] configs: enable DM_MDIO for LS1021A-TWR and LS1021A-TSN

2020-09-22 Thread Zhiqiang Hou
From: Vladimir Oltean The tsec driver now requires DM_MDIO when DM_ETH is enabled. To avoid build errors, enable DM_MDIO in these boards' configs before we actually add DM_MDIO support to tsec. Signed-off-by: Vladimir Oltean Signed-off-by: Hou Zhiqiang --- V6: - No code change, just move it

[PATCHv6 16/18] dts: powerpc: p2020rdb: Add eTSEC DT nodes

2020-09-22 Thread Zhiqiang Hou
From: Hou Zhiqiang P2020RDB implements 3 enhanced three-speed Ethernet controllers, and the connection is shown below: eTSEC1: Connected to RGMII switch VSC7385 eTSEC2: Connected to SGMII PHY VSC8221 eTSEC3: Connected to SGMII PHY AR8021 Signed-off-by: Hou Zhiqiang --- V6: - No

[PATCHv6 15/18] configs: P1010RDB: Enable DM_ETH config

2020-09-22 Thread Zhiqiang Hou
From: Hou Zhiqiang Enable the DM_ETH and DM_MDIO config. Signed-off-by: Hou Zhiqiang --- V6: - No change. configs/P1010RDB-PA_36BIT_NAND_defconfig | 2 ++ configs/P1010RDB-PA_36BIT_NOR_defconfig | 2 ++ configs/P1010RDB-PA_36BIT_SDCARD_defconfig | 2 ++

Re: [PATCH v3 53/57] x86: fsp: Show FSP-S or FSP-M address in fsp_get_header()

2020-09-22 Thread Bin Meng
On Mon, Sep 7, 2020 at 5:45 AM Simon Glass wrote: > > At present this function only supports FSP-M but it is also used to read > FSP-S, in which case FSP-M may be zero. Add support for showing whichever > address is present in the FSP binary. > > Also change the debug() statements to log_debug()

Re: [PATCH v3 49/57] x86: acpi: Set the log category for x86 table generation

2020-09-22 Thread Bin Meng
On Mon, Sep 7, 2020 at 5:44 AM Simon Glass wrote: > > This file doesn't currently have a log category. Add one so that items > are logged correctly. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > arch/x86/lib/acpi_table.c | 2 ++ > 1 file changed, 2 insertions(+) >

Re: [PATCH v3 52/57] x86: fsp: Add more debugging for silicon init

2020-09-22 Thread Bin Meng
On Mon, Sep 7, 2020 at 5:45 AM Simon Glass wrote: > > If locating the FSP header hangs for whatever reason it is useful to see > where it got stuck. Add a debug print. Also show the address of the FSP-S > entry point as a sanity check. > > Signed-off-by: Simon Glass > --- > > (no changes since

  1   2   3   >