Re: [PATCH 1/4] IPQ40xx: clk: use dev_read_addr()

2020-11-19 Thread Robert Marko
On Wed, Oct 28, 2020 at 1:56 PM Robert Marko wrote: > > Lets convert the driver to use dev_read_addr() instead of the > devfdt_get_addr(). > > While we are here, lets also alphabetise the includes. > > Signed-off-by: Robert Marko > Cc: Luka Perkov > --- > arch/arm/mach-ipq40xx/clock-ipq4019.c

[PATCH v1] linux/compat.h: Remove debug() from spin_lock_irqsave()

2020-11-19 Thread Andy Shevchenko
It seems nobody tested the debug() option in spin_lock_irqsave(). Currently, when #define DEBUG, it spoils the compiler with In file included from drivers/usb/dwc3/gadget.c:18: drivers/usb/dwc3/gadget.c: In function ‘dwc3_gadget_set_selfpowered’: include/log.h:235:4: warning: ‘flags’ is used

Re: [PATCH v2 3/4] efi_selftest: implement exception test for sandbox

2020-11-19 Thread Heinrich Schuchardt
On 17.11.20 00:53, Simon Glass wrote: > On Wed, 11 Nov 2020 at 16:30, Heinrich Schuchardt wrote: >> >> Provide a unit test that causes an illegal instruction to occur. >> >> The test can be run with the following commands: >> >> => setenv efi_selftest exception >> => bootefi selftest >>

Re: [PATCH v2 1/4] sandbox: add handler for exceptions

2020-11-19 Thread Heinrich Schuchardt
On 17.11.20 00:53, Simon Glass wrote: > Hi Heinrich, > > On Wed, 11 Nov 2020 at 16:30, Heinrich Schuchardt wrote: >> >> Add a handler for SIGILL, SIGBUS, SIGSEGV. >> >> When an exception occurs print the program counter and the loaded >> UEFI binaries and reset the system if

Re: [BUG] U-boot does not detect emmc card in odroid-c2 for newer U-boot as 2020.04

2020-11-19 Thread Anand Moon
Hi Otto, On Thu, 19 Nov 2020 at 21:23, Otto Meier wrote: > > Hi, > > I have extended the previous post. > > > > with these modifications i get: > > U-Boot 2021.01-rc2-00047-g9324c9a823-dirty (Nov 19 2020 - 15:33:00 > +0100) odroid-c2 > > Model: Hardkernel ODROID-C2 > SoC: Amlogic Meson GXBB

[PATCH 1/1] efi_loader: parameter check in GetNextVariableName()

2020-11-19 Thread Heinrich Schuchardt
If GetNextVariableName() is called with a non-existing combination of VariableName and VendorGuid, return EFI_INVALID_PARAMETER. If GetNextVariableName() is called with a string that is not zero terminated, return EFI_INVALID_PARAMETER. Reformat a line over 80 characters. Signed-off-by:

Re: [linux-sunxi] [PATCH] sunxi: Add arm64 FEL support

2020-11-19 Thread Priit Laes
On Thu, Nov 19, 2020 at 10:54:42AM +, Andre Przywara wrote: > So far we did not support the BootROM based FEL USB debug mode on the > 64-bit builds for Allwinner SoCs: The BootROM is using AArch32, but the > SPL runs in AArch64. > Returning back to AArch32 was not working as expected, since

[PATCH 7/8] xhci: translate virtual addresses into the bus's address space

2020-11-19 Thread Nicolas Saenz Julienne
So far we've been content with passing physical addresses when configuring memory addresses into XHCI controllers, but not all platforms have buses with transparent mappings. Specifically the Raspberry Pi 4 might introduce an offset to memory accesses incoming from its PCIe port. Introduce

[PATCH 2/8] rpi: Add identifier for the new CM4

2020-11-19 Thread Nicolas Saenz Julienne
The Raspberry Pi Foundation released the new Compute Module 4which we want to detect, so we can enable Ethernet on it and know the correct device tree file name. Note that this sets the Ethernet option to true since the official CM4 IO board has an Ethernet port. But that might not be the case

[PATCH 6/8] dm: Introduce dev_phys_to_bus()/dev_bus_to_phys()

2020-11-19 Thread Nicolas Saenz Julienne
These functions, instead of relying on hard-coded platform-specific address translations, make use of the DMA constraints provided by the DM core. This allows for per-device translations. Signed-off-by: Nicolas Saenz Julienne --- include/phys2bus.h | 16 1 file changed, 16

[PATCH 4/8] dm: Introduce xxx_get_dma_range()

2020-11-19 Thread Nicolas Saenz Julienne
Add the follwing functions to get a specific device's DMA ranges: - dev_get_dma_range() - ofnode_get_dma_range() - of_get_dma_range() - fdt_get_dma_range() They are specially useful in oder to be able validate a physical address space range into a bus's and to convert addresses from and to

[PATCH 8/8] mmc: Introduce mmc_phys_to_bus()/mmc_bus_to_phys()

2020-11-19 Thread Nicolas Saenz Julienne
This will allow us to use DM variants of phys_to_bus()/bus_to_phys() when relevant. Signed-off-by: Nicolas Saenz Julienne --- drivers/mmc/sdhci.c | 7 --- include/mmc.h | 10 ++ 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/sdhci.c

[PATCH 0/8] Raspberry Pi 400/Compute Module 4 support

2020-11-19 Thread Nicolas Saenz Julienne
This series could be split into at least two or even three parts, but I kept it as is for now as it contains all the changes needed in order to have u-boot working on the new Raspberry Pi 400 and Raspberry Pi Compute Module 4. There are core changes, specifically with regard to cpu to bus address

[PATCH 5/8] dm: Introduce DMA constraints into the core device model

2020-11-19 Thread Nicolas Saenz Julienne
Calculating the DMA offset between a bus address space and CPU's every time we call phys_to_bus() and bus_to_phys() isn't ideal performance wise. This information is static and available before initializing the devices so parse it before the probe call an provide the DMA offset it in 'struct

[PATCH 3/8] pci: pcie-brcmstb: Fix inbound window configurations

2020-11-19 Thread Nicolas Saenz Julienne
So far we've assumed a fixed configuration for inbound windows as we had a single user for this controller. But the controller's DMA constraints were improved starting with BCM2711's B1 revision of the SoC, notably available in CM4 and Pi400. They allow for wider inbound windows. We can now cover

[PATCH 1/8] rpi: Add identifier for the new RPi400

2020-11-19 Thread Nicolas Saenz Julienne
The Raspberry Pi Foundation released the new RPi400 which we want to detect, so we can enable Ethernet on it and know the correct device tree file name. So far the Raspberry Pi foundation is using the RPi4b device-tree file to boot RPi400. I see no reason not to do the same as they are completely

Re: [PATCH v1] linux/compat.h: Remove debug() from spin_lock_irqsave()

2020-11-19 Thread Andy Shevchenko
Update Tom's address On Thu, Nov 19, 2020 at 9:26 PM Andy Shevchenko wrote: > > It seems nobody tested the debug() option in spin_lock_irqsave(). > Currently, when #define DEBUG, it spoils the compiler with > > In file included from drivers/usb/dwc3/gadget.c:18: > drivers/usb/dwc3/gadget.c: In

Re: [PATCH] tools: image-host.c: use random instead of rand

2020-11-19 Thread Tom Rini
On Fri, Nov 13, 2020 at 04:37:46PM +0100, Philippe Reynes wrote: > According to the manpage of rand, it is recommended > to use random instead of rand. This commit updates > the function get_random_data to use random. > > Reported-by: Coverity (CID: 312953) > Signed-off-by: Philippe Reynes >

Re: [PATCH v3] arm: vexpress: don't reset flags in board_init to avoid losing previous ones

2020-11-19 Thread Tom Rini
On Sun, Nov 15, 2020 at 12:54:10PM +0100, Arnaud Aujon Chevallier wrote: > Re-submitted because of missing description and signed-off. > > flags reset in board_init caused bugs when executing command like editenv > because the reallocated flag was lost. > > Tested-by: Michael Opdenacker >

Re: [PATCH v2 25/28] fs/squashfs: sqfs_read: don't write beyond buffer size

2020-11-19 Thread Tom Rini
On Tue, Nov 03, 2020 at 12:11:23PM +0100, Richard Genoud wrote: > The length of the buffer wasn't taken into account when writing to the > given buffer. > > Signed-off-by: Richard Genoud Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 26/28] fs/squashfs: sqfs_read: remove buggy offset functionality

2020-11-19 Thread Tom Rini
On Tue, Nov 03, 2020 at 12:11:24PM +0100, Richard Genoud wrote: > offset is the offset in the file read, not the offset in the destination > buffer. > If the offset is not null, this will lead to a memory corruption. > So, for now, we are returning an error if the offset is used. > >

Re: [PATCH] tools: image-host.c: use correct variable for strerrno

2020-11-19 Thread Tom Rini
On Fri, Nov 13, 2020 at 03:15:18PM +0100, Philippe Reynes wrote: > In the function get_random_data, strerrno is called with > the variable ret (which is the return of the function > clock_gettime). It should be called with errnor. This > commit fixes this mistake. > > Reported-by: Coverity (CID:

Re: [PATCH v2 24/28] fs/squashfs: sqfs_probe: use sqfs_decompressor_init() return value

2020-11-19 Thread Tom Rini
On Tue, Nov 03, 2020 at 12:11:22PM +0100, Richard Genoud wrote: > sqfs_decompressor_init() returns a value, so it's better to use it than > to force the return value to EINVAL (it could be ENOMEM) > > Reviewed-by: Joao Marcos Costa > Signed-off-by: Richard Genoud Applied to u-boot/master,

Re: [PATCH v2 28/28] fs/squashfs: implement exists() function

2020-11-19 Thread Tom Rini
On Tue, Nov 03, 2020 at 12:11:26PM +0100, Richard Genoud wrote: > This permits to find a file and use the distro_bootcmd > > Reviewed-by: Joao Marcos Costa > Signed-off-by: Richard Genoud Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

[PATCH] Add optional salt to AUTOBOOT_STOP_STR_SHA256

2020-11-19 Thread Joel Peshkin
From: Joel Peshkin Adds an optional SALT value to AUTOBOOT_STOP_STR_SHA256. If a string followed by a ":" is prepended to the sha256, the portion to the left of the colon will be used as a salt and the password will be appended to the salt before the sha256 is computed and compared.

Re: [PATCH v5] env: mmc: Correct partition comparison in mmc_offset_try_partition

2020-11-19 Thread Tom Rini
On Tue, Nov 17, 2020 at 12:32:08PM +0900, Hoyeonjiki Kim wrote: > The function mmc_offset_try_partition searches the MMC partition for > locating environment data, by comparing the partition names with config > "u-boot,mmc-env-parition". However, it only compares the first word-size > bytes (size

Re: [PATCH] common: fit: add missing newline

2020-11-19 Thread Tom Rini
On Mon, Nov 16, 2020 at 10:01:31PM +0100, Michael Walle wrote: > The debug statement doesn't end with a newline. Add it. > > Signed-off-by: Michael Walle Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

[PATCH] power: regulator: Kconfig: add a dependency for POWER_SUPPORT for SPL

2020-11-19 Thread Nishanth Menon
power/regulator will not be built if just CONFIG_SPL_DM_REGULATOR is enabled. It needs CONFIG_SPL_POWER_SUPPORT to be enabled as well. For example, if we just need a GPIO regulator in SPL: CONFIG_DM_REGULATOR=y CONFIG_SPL_DM_REGULATOR=y CONFIG_DM_REGULATOR_GPIO=y CONFIG_SPL_DM_REGULATOR_GPIO=y

Re: [PATCH v2 22/28] fs/squashfs: sqfs_close/sqfs_read_sblk: set ctxt.sblk to NULL after free

2020-11-19 Thread Tom Rini
On Tue, Nov 03, 2020 at 12:11:20PM +0100, Richard Genoud wrote: > This will prevent a double free error if sqfs_close() is called twice. > > Signed-off-by: Richard Genoud This change causes the test.py squashfs tests to fail. I am unsure if the problem is with the tests or this exposing

Re: [PATCH v2 18/28] fs/squashfs: sqfs_get_abs_path: fix error check

2020-11-19 Thread Tom Rini
On Tue, Nov 03, 2020 at 12:11:16PM +0100, Richard Genoud wrote: > the return value of sqfs_tokenize(rel_tokens, rc, rel); wasn't checked. > (but "ret" value was !) > This is obviouly a typo. > > Reviewed-by: Joao Marcos Costa > Signed-off-by: Richard Genoud Applied to u-boot/master, thanks!

Re: [PATCH v2 23/28] fs/squashfs: sqfs_probe: reset cur_dev/cur_part_info to NULL on error

2020-11-19 Thread Tom Rini
On Tue, Nov 03, 2020 at 12:11:21PM +0100, Richard Genoud wrote: > Resetting the context on error will prevent some checks like: > if (!ctx.cur_dev) > To pass when the probe method has failed > > Signed-off-by: Richard Genoud Applied to u-boot/master, thanks! -- Tom signature.asc

Re: [PATCH v2 20/28] fs/squashfs: sqfs_read: fix memory leak on finfo.blk_sizes

2020-11-19 Thread Tom Rini
On Tue, Nov 03, 2020 at 12:11:18PM +0100, Richard Genoud wrote: > finfo.blk_sizes may not be freed in case of error in the for loop > Setting it to null and freeing it at the end makes prevents that from > happening. > > Reviewed-by: Joao Marcos Costa > Signed-off-by: Richard Genoud Applied

Re: [PATCH v2 17/28] fs/squashfs: sqfs_frag_lookup: simplify error handling

2020-11-19 Thread Tom Rini
On Tue, Nov 03, 2020 at 12:11:15PM +0100, Richard Genoud wrote: > For consistency with other functions. > > Reviewed-by: Joao Marcos Costa > Signed-off-by: Richard Genoud Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 21/28] fs/squashfs: sqfs_probe: fix possible memory leak on error

2020-11-19 Thread Tom Rini
On Tue, Nov 03, 2020 at 12:11:19PM +0100, Richard Genoud wrote: > If SquashFS magic number is invalid, there's a memory leak. > > Reviewed-by: Joao Marcos Costa > Signed-off-by: Richard Genoud Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 16/28] fs/squashfs: sqfs_read: fix another memory leak

2020-11-19 Thread Tom Rini
On Tue, Nov 03, 2020 at 12:11:14PM +0100, Richard Genoud wrote: > data_buffer was allocated in a loop and freed only once. > > Signed-off-by: Richard Genoud Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 10/28] fs/squashfs: sqfs_concat_tokens: check if malloc succeeds

2020-11-19 Thread Tom Rini
On Tue, Nov 03, 2020 at 12:11:08PM +0100, Richard Genoud wrote: > memory allocation should always be checked > > Reviewed-by: Joao Marcos Costa > Signed-off-by: Richard Genoud Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 12/28] fs/squashfs: sqfs_size: remove useless sqfs_closedir()

2020-11-19 Thread Tom Rini
On Tue, Nov 03, 2020 at 12:11:10PM +0100, Richard Genoud wrote: > as sqfs_opendir failed, there's no need to call sqfs_closedir > > Signed-off-by: Richard Genoud Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 06/28] fs/squashfs: sqfs_read_directory_table: fix memory leak

2020-11-19 Thread Tom Rini
On Tue, Nov 03, 2020 at 12:11:04PM +0100, Richard Genoud wrote: > pos_list wasn't freed on every error > > Reviewed-by: Joao Marcos Costa > Signed-off-by: Richard Genoud Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 08/28] fs/squashfs: sqfs_search_dir: fix memory leaks

2020-11-19 Thread Tom Rini
On Tue, Nov 03, 2020 at 12:11:06PM +0100, Richard Genoud wrote: > path, target, res, rem and sym_tokens were not free on error nor success. > > Reviewed-by: Joao Marcos Costa > Signed-off-by: Richard Genoud Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 09/28] fs/squashfs: sqfs_read_inode_table: fix dangling pointer

2020-11-19 Thread Tom Rini
On Tue, Nov 03, 2020 at 12:11:07PM +0100, Richard Genoud wrote: > inode_table should not be left dangling as it may be freed in sqfs_opendir > > Signed-off-by: Richard Genoud Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 07/28] fs/squashfs: sqfs_search_dir: fix dangling pointer

2020-11-19 Thread Tom Rini
On Tue, Nov 03, 2020 at 12:11:05PM +0100, Richard Genoud wrote: > dirs->entry shouldn't be left dangling as it could be freed twice. > > Signed-off-by: Richard Genoud Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 1/4] fs: btrfs: inode: handle uninitialized type before returning it

2020-11-19 Thread Tom Rini
On Sat, Oct 31, 2020 at 09:07:49AM +0800, Qu Wenruo wrote: > In btrfs_lookup_path() the local variable @type should always be updated > after we hit any file/dir. > > But if @filename is NULL from the very beginning, then we don't > initialize it and return it directly. > > To prevent such

Re: [PATCH] drivers: led: bcm6858: set the correct led polarity register

2020-11-19 Thread Tom Rini
On Thu, Oct 29, 2020 at 06:27:34PM +0100, Steven Lawrance wrote: > This change sets the output (hardware) polarity register instead of the > input (software) polarity register for the bcm6858 LED controller. The > logic was inverted (a LED configued active high behaved as active low). > >

Re: [PATCH] km/ppc: use Kconfig for MEMTEST configuration

2020-11-19 Thread Tom Rini
On Thu, Oct 29, 2020 at 01:54:54PM +0100, Holger Brunck wrote: > Also change back SYS_MEMTEST_END to 0x00f0. 0xe0 was wrong and > introduced due to the global Kconfig migration of this option in u-boot. > > CC: Heiko Schocher > CC: Tom Rini > Signed-off-by: Holger Brunck Applied to

Re: [PATCH v2 11/28] fs/squashfs: sqfs_size: fix dangling pointer dirs->entry

2020-11-19 Thread Tom Rini
On Tue, Nov 03, 2020 at 12:11:09PM +0100, Richard Genoud wrote: > dirs->entry shouldn't be left dangling as it could be freed twice. > > Signed-off-by: Richard Genoud Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 15/28] fs/squashfs: sqfs_read: fix memory leak

2020-11-19 Thread Tom Rini
On Tue, Nov 03, 2020 at 12:11:13PM +0100, Richard Genoud wrote: > sqfs_closedir() should be called to free memory allocated by > sqfs_opendir() > > Reviewed-by: Joao Marcos Costa > Signed-off-by: Richard Genoud Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP

Re: [PATCH v2 19/28] fs/squashfs: sqfs_get_abs_path: fix possible memory leak on error

2020-11-19 Thread Tom Rini
On Tue, Nov 03, 2020 at 12:11:17PM +0100, Richard Genoud wrote: > if sqfs_tokenize(rel_tokens, rc, rel); fails, the function exits > without freeing the array base_tokens. > > Reviewed-by: Joao Marcos Costa > Signed-off-by: Richard Genoud Applied to u-boot/master, thanks! -- Tom

Re: [PATCH v2 13/28] fs/squashfs: sqfs_read: fix dangling pointer dirs->entry

2020-11-19 Thread Tom Rini
On Tue, Nov 03, 2020 at 12:11:11PM +0100, Richard Genoud wrote: > dirs->entry shouldn't be left dangling as it could be freed twice. > > Signed-off-by: Richard Genoud Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 14/28] fs/squashfs: sqfs_read: remove useless sqfs_closedir()

2020-11-19 Thread Tom Rini
On Tue, Nov 03, 2020 at 12:11:12PM +0100, Richard Genoud wrote: > as sqfs_opendir failed, there's no need to call sqfs_closedir > > Signed-off-by: Richard Genoud Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 7/8] xhci: translate virtual addresses into the bus's address space

2020-11-19 Thread Bin Meng
+Stefan On Fri, Nov 20, 2020 at 1:49 AM Nicolas Saenz Julienne wrote: > > So far we've been content with passing physical addresses when > configuring memory addresses into XHCI controllers, but not all > platforms have buses with transparent mappings. Specifically the > Raspberry Pi 4 might

Re: [PATCH v2 27/28] fs/squashfs: sqfs_read: fragmented files are not supported

2020-11-19 Thread Tom Rini
On Tue, Nov 03, 2020 at 12:11:25PM +0100, Richard Genoud wrote: > The code for reading a fragmented file is not functionnal. > It's better to signal this to the user. > > Signed-off-by: Richard Genoud This change causes the test.py squashfs tests to fail. I am unsure if the problem is with

Re: [PATCH] km: replace hardcoded address for imported environment

2020-11-19 Thread Tom Rini
On Thu, Oct 29, 2020 at 01:48:01PM +0100, Holger Brunck wrote: > From: Matteo Ghidoni > > Instead of using an hard coded address, make use of an > already defined address for importing the environment > for ramfs and nfs boot. This allows boards having different > mapping to use the same code.

Re: [PATCH] fs/squashfs: Fix index off by 1 for inode SQFS_LDIR_TYPE

2020-11-19 Thread Tom Rini
On Fri, Oct 30, 2020 at 01:41:58PM +, Gerard Koskamp wrote: > I've created a squashfs file system with Yocto (it use squashfs-tools) > and u-boot command sqfsls give the error:'Error while searching inode: > unknown type.' > After some digging in the code I found that the index is off by 1. >

Re: [PATCH] tools: dumpimage: Remove remaining mentions of the -i option

2020-11-19 Thread Tom Rini
On Mon, Oct 26, 2020 at 10:40:24AM -0500, Tyler Hicks wrote: > The -i option of the dumpimage tool has been removed so it should no > longer be documented in the README file. Refer readers to the tool's > help output rather than maintain a copy of the usage in the README. > > Finally, adjust the

Re: [PATCH v2 02/28] fs/squashfs: sqfs_opendir: fix some memory leaks and dangling pointers

2020-11-19 Thread Tom Rini
On Tue, Nov 03, 2020 at 12:11:00PM +0100, Richard Genoud wrote: > When trying to load an non-existing file, the cpu hangs! > > Signed-off-by: Richard Genoud Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 3/4] fs: btrfs: initialize @ret to 0 to prevent uninitialized return value

2020-11-19 Thread Tom Rini
On Sat, Oct 31, 2020 at 09:07:51AM +0800, Qu Wenruo wrote: > In show_dir() if we hit a ROOT_ITEM, we can exit with uninitialized > @ret. > > Fix it by initializing it to 0. > > Reported-by: Coverity CID 312955 > Signed-off-by: Qu Wenruo > Reviewed-by: Marek Behún Applied to u-boot/master,

Re: [PATCH 1/1] env: typo enougth

2020-11-19 Thread Tom Rini
On Fri, Oct 30, 2020 at 06:11:12AM +0100, Heinrich Schuchardt wrote: > %s/enougth/enough/ > > Signed-off-by: Heinrich Schuchardt > Acked-by: Joe Hershberger Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 03/28] fs/squashfs: sqfs_opendir: simplify error handling

2020-11-19 Thread Tom Rini
On Tue, Nov 03, 2020 at 12:11:01PM +0100, Richard Genoud wrote: > Using only one label permits to prevents bugs when moving code around. > > Reviewed-by: Joao Marcos Costa > Signed-off-by: Richard Genoud Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 01/28] fs/squashfs: fix board hang-up when calling .exists()

2020-11-19 Thread Tom Rini
On Tue, Nov 03, 2020 at 12:10:59PM +0100, Richard Genoud wrote: > add missing squashfs function to prevent dangling or null pointers. > For exemple, when calling test [ -e somefile ], squashfs.exists may be > called. > > Signed-off-by: Richard Genoud > Reviewed-by: Joao Marcos Costa Applied

Re: [PATCH v2 05/28] fs/squashfs: sqfs_split_path: fix memory leak and dangling pointers

2020-11-19 Thread Tom Rini
On Tue, Nov 03, 2020 at 12:11:03PM +0100, Richard Genoud wrote: > *file and *dir were not freed on error > > Reviewed-by: Joao Marcos Costa > Signed-off-by: Richard Genoud Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 04/28] fs/squashfs: sqfs_closedir: fix memory leak

2020-11-19 Thread Tom Rini
On Tue, Nov 03, 2020 at 12:11:02PM +0100, Richard Genoud wrote: > sqfs_dirs wasn't freed anywhere. > > Reviewed-by: Joao Marcos Costa > Signed-off-by: Richard Genoud Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 7/8] xhci: translate virtual addresses into the bus's address space

2020-11-19 Thread Stefan Roese
Hi Bin, Hi Nicolas, On 20.11.20 01:31, Bin Meng wrote: +Stefan On Fri, Nov 20, 2020 at 1:49 AM Nicolas Saenz Julienne wrote: So far we've been content with passing physical addresses when configuring memory addresses into XHCI controllers, but not all platforms have buses with transparent

[PATCH 2/3] test: correct the test prefix in ut cmd_mem

2020-11-19 Thread Patrick Delaunay
Align the prefix used in cmd_ut_category function and name of tests for ut mem. This patch solves the issues detected by "make qcheck" after previous patch. Fixes: 550a9e7902ce ("cmd: Update the memory-search command") Signed-off-by: Patrick Delaunay --- test/cmd/mem.c | 2 +- 1 file changed,

[PATCH 1/3] test: cmd_ut_category: raise a error when the test is not found

2020-11-19 Thread Patrick Delaunay
Raise an error when test is not found, for example with manual test with bad test name, as following, doesn't raise an error => ut lib bad Failures: 0 After the patch: => ut lib bad lib test bad not found Failures: 1 This patch allows also to detect tests which don't respect the expected

[PATCH 3/3] test: correct the test prefix in ut str

2020-11-19 Thread Patrick Delaunay
Align the prefix used in cmd_ut_category function and name of tests for ut str. This patch solves the issues detected by "make qcheck" after previous patch. Fixes: fdc79a6b125d ("lib: Add a function to convert a string to upper case") Signed-off-by: Patrick Delaunay --- test/str_ut.c | 4 ++--

Re: Booting on RK3399[Please note, mail behalf by s...@google.com]

2020-11-19 Thread Kever Yang
Hi Piotr, On 2020/11/16 下午10:55, Piotr Lobacz wrote: Hi all, i also have a firefly-rk3399 and got problems booting atf >= 1.4 with whatever optee i use. Only rockchip blob is working for me. I know that i'm doing something wrong but dunno what. The command for building atf is: # make

Re: [PATCH 0/2] rockchip: Fix SPI boot on Pinebook Pro and RK3399-ROC-PC

2020-11-19 Thread Kever Yang
Hi Hugh,     After this patch set, only one board is still using the "spi0 = " alias, could you correct it at the same time? rk3399-puma-haikou-u-boot.dtsi Thanks, - Kever On 2020/11/15 上午2:06, Hugh Cole-Baker wrote: Commit c4cea2bbf995 ("rockchip: Enable building a SPI ROM image on

Re: [PATCH] riscv: fix the wrong swap value register

2020-11-19 Thread Leo Liang
On Fri, Nov 13, 2020 at 08:47:51PM +0900, Brad Kim wrote: > Not s2 register, t1 register is correct > Fortunately, it works because t1 register has a garbage value > > Signed-off-by: Brad Kim > Reviewed-by: Lukas Auer > --- > arch/riscv/cpu/start.S | 2 +- > 1 file changed, 1 insertion(+), 1

[PATCH] sunxi: Add arm64 FEL support

2020-11-19 Thread Andre Przywara
So far we did not support the BootROM based FEL USB debug mode on the 64-bit builds for Allwinner SoCs: The BootROM is using AArch32, but the SPL runs in AArch64. Returning back to AArch32 was not working as expected, since the RMR reset into 32-bit mode always starts execution in the BootROM, but

RE: [RESEND v2 08/22] arm: socfpga: Restructure Stratix10 and Agilex handoff code

2020-11-19 Thread Tan, Ley Foon
> -Original Message- > From: Lim, Elly Siew Chin > Sent: Tuesday, November 10, 2020 2:44 PM > To: u-boot@lists.denx.de > Cc: Marek Vasut ; Tan, Ley Foon > ; See, Chin Liang ; > Simon Goldschmidt ; Chee, Tien Fong > ; Westergreen, Dalon > ; Simon Glass ; Gan, > Yau Wai ; Lim, Elly Siew

RE: [PATCH] common/board_r: make sure to call initr_dm() before initr_trace()

2020-11-19 Thread Pragnesh Patel
>-Original Message- >From: Simon Glass >Sent: 18 November 2020 20:07 >To: Pragnesh Patel >Cc: Heinrich Schuchardt ; U-Boot Mailing List b...@lists.denx.de> >Subject: Re: [PATCH] common/board_r: make sure to call initr_dm() before >initr_trace() > >[External Email] Do not click links or

RE: [RESEND v2 09/22] arm: socfpga: Add handoff data support for Diamond Mesa

2020-11-19 Thread Tan, Ley Foon
> -Original Message- > From: Lim, Elly Siew Chin > Sent: Tuesday, November 10, 2020 2:44 PM > To: u-boot@lists.denx.de > Cc: Marek Vasut ; Tan, Ley Foon > ; See, Chin Liang ; > Simon Goldschmidt ; Chee, Tien Fong > ; Westergreen, Dalon > ; Simon Glass ; Gan, > Yau Wai ; Lim, Elly Siew

Re: [BUG] U-boot does not detect emmc card in odroid-c2 for newer U-boot as 2020.04

2020-11-19 Thread Jaehoon Chung
Hi, On 11/19/20 12:54 AM, Otto Meier wrote: > Hi, > > i have reverted the commit fe95905ffed57d617cad81a71ac419d53aaa1ebf > and  set regulator-allways-on in meson-gxbb-odroidc2.dts. > > And i also applied "PATCH V2] mmc: display an error number to debug" > from list and disabled

[PATCH 1/1] fs: fat: avoid NULL dereference when root dir is full

2020-11-19 Thread Heinrich Schuchardt
When trying to create a file in the full root directory of a FAT32 filesystem a NULL dereference can be observed. When the root directory of a FAT16 filesystem is full fill_dir_slot() must return -1 to signal that a new directory entry could not be allocated. Fixes: cd2d727fff7e ("fs: fat:

Re: [PATCH v3] arm: vexpress: don't reset flags in board_init to avoid losing previous ones

2020-11-19 Thread Michael Opdenacker
Tested-by: Michael Opdenacker -- Michael Opdenacker, CEO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: Booting on RK3399[Please note, mail behalf by s...@google.com]

2020-11-19 Thread Piotr Lobacz
Hi Kever, thanks for your reply, so i should change baud rate in bl31 to see it? how can i handle it? Best Regards Piotr -- Sent from: http://u-boot.10912.n7.nabble.com/

Re: [PATCH v2] time: Fix get_ticks being non-monotonic

2020-11-19 Thread Michael Opdenacker
Hi, Sorry, no messaging quoting, I was not subscribed to the list at that time. Merging this change into master actually broke the SPL on Atmel/Microchip SAMA5D3, at least booting from MMC: RomBOOT Could not initialize timer (err -11) Could not initialize timer (err -11) Could not

RE: [PATCH 2/3] log: use debug uart to output trace before LOG init

2020-11-19 Thread Patrick DELAUNAY
Hi Simon, > From: Simon Glass > Sent: mercredi 11 novembre 2020 15:32 > To: Patrick DELAUNAY ; Heinrich Schuchardt > > +Heinrich Schuchardt OK > On Fri, 6 Nov 2020 at 10:55, Patrick Delaunay wrote: > > > > Use the debug uart functions to output the traces before the log > > initialization

Re: [BUG] U-boot does not detect emmc card in odroid-c2 for newer U-boot as 2020.04

2020-11-19 Thread Otto Meier
Hi, with these modifications i get: U-Boot 2021.01-rc2-00047-g9324c9a823-dirty (Nov 19 2020 - 15:33:00 +0100) odroid-c2 Model: Hardkernel ODROID-C2 SoC:   Amlogic Meson GXBB (S905) Revision 1f:c (0:1) DRAM:  2 GiB MMC:   mmc@72000: 0, mmc@74000: 1 In:    serial Out:   serial Err:   serial

Re: [PATCH v1 2/7] board: toradex: add apalis-imx8x 2gb wb it v1.1a module support

2020-11-19 Thread Oliver Graute
On 22/10/20, Igor Opaniuk wrote: > From: Igor Opaniuk > > * With the SCU FW from the latest Toradex BSP 5.0.0 (SCU FW 1.5.1) > ETH PHY encounters bring up problems after reset, this will be fixed > soon on SCU FW side. Hello Igor, are these ETH Phy problems also in NXP provided SCU FW 1.5.1/

Re: [BUG] U-boot does not detect emmc card in odroid-c2 for newer U-boot as 2020.04

2020-11-19 Thread Otto Meier
Hi, I have extended the previous post. with these modifications i get: U-Boot 2021.01-rc2-00047-g9324c9a823-dirty (Nov 19 2020 - 15:33:00 +0100) odroid-c2 Model: Hardkernel ODROID-C2 SoC:   Amlogic Meson GXBB (S905) Revision 1f:c (0:1) DRAM:  2 GiB MMC:   mmc@72000: 0, mmc@74000: 1 In: