Re: [PATCH 3/4] Drop CONFIG_USB_EHCI_KIRKWOOD

2021-10-15 Thread Tom Rini
On Sat, Oct 09, 2021 at 03:27:34PM +0200, Marek Behún wrote: > From: Marek Behún > > This config option doesn't do anything. > > nas220 uses USB_EHCI_MARVELL. > > Signed-off-by: Marek Behún Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 2/4] Convert CONFIG_USB_EHCI_MXS to Kconfig

2021-10-15 Thread Tom Rini
On Sat, Oct 09, 2021 at 03:27:33PM +0200, Marek Behún wrote: > From: Marek Behún > > This option is only used for > mx23evk_defconfig > mx23_olinuxino_defconfig > which are the only i.MX23 boards. > > Add depend on ARCH_MX23 and default to y. > > Signed-off-by: Marek Behún Applied to

Re: [PATCH 4/4] Convert CONFIG_USB_EHCI_IS_TDI to Kconfig

2021-10-15 Thread Tom Rini
On Sat, Oct 09, 2021 at 03:27:35PM +0200, Marek Behún wrote: > From: Marek Behún > > On mvebu this is defined if and only if !ARM64. > > Otherwise it is defined for boards with ARCH_MX23, ARCH_TEGRA and > ARCH_ZYNQ, and also for SOC_AR934X (tplink_wdr4300). > > Signed-off-by: Marek Behún

Re: [PATCH 1/4] Rename CONFIG_EHCI_IS_TDI to CONFIG_USB_EHCI_IS_TDI

2021-10-15 Thread Tom Rini
On Sat, Oct 09, 2021 at 03:27:32PM +0200, Marek Behún wrote: > From: Marek Behún > > In preparation for moving this option to Kconfig, rename it to be > consistent with other USB EHCI Kconfig options. > > Signed-off-by: Marek Behún Applied to u-boot/master, thanks! -- Tom signature.asc

[PATCH v2] board_f: Copy GD to new GD even if relocation disabled

2021-10-15 Thread marek . vasut
From: Marek Vasut Even if U-Boot has relocation disabled via GD_FLG_SKIP_RELOC , the relocated stage of U-Boot still picks GD from new_gd location. The U-Boot itself is not relocated, but GD might be, so copy the GD to new GD location even if relocation is disabled. Signed-off-by: Marek Vasut

Re: [PATCH] loads: Block writes into LMB reserved areas of U-Boot

2021-10-15 Thread Marek Vasut
On 10/14/21 5:10 PM, Simon Glass wrote: [...] @@ -137,6 +138,7 @@ static int do_load_serial(struct cmd_tbl *cmdtp, int flag, int argc, static ulong load_serial(long offset) { + struct lmb lmb; charrecord[SREC_MAXRECLEN + 1]; /* buffer for one S-Record */

Re: [PATCH] board_f: Copy GD to new GD even if relocation disabled

2021-10-15 Thread Marek Vasut
On 10/14/21 3:52 AM, Peng Fan (OSS) wrote: [...] diff --git a/common/board_f.c b/common/board_f.c index 3dc0eaa59c..2161a7411d 100644 --- a/common/board_f.c +++ b/common/board_f.c @@ -674,6 +674,7 @@ static int reloc_bloblist(void)   static int setup_reloc(void)   {   if (gd->flags &

Re: [PATCH 1/2] arm64: Add missing GD_FLG_SKIP_RELOC handling

2021-10-15 Thread Marek Vasut
On 10/14/21 3:55 AM, Peng Fan (OSS) wrote: [...] diff --git a/arch/arm/lib/crt0_64.S b/arch/arm/lib/crt0_64.S index 680e674fa3..28c8356aee 100644 --- a/arch/arm/lib/crt0_64.S +++ b/arch/arm/lib/crt0_64.S @@ -104,6 +104,10 @@ ENTRY(_main)   bic    sp, x0, #0xf    /* 16-byte alignment for ABI

Re: HiFive Unmatched: U-Boot stuck when loading Ramdisk

2021-10-15 Thread Tom Rini
On Fri, Oct 15, 2021 at 06:29:09PM +0300, David Abdurachmanov wrote: > On Fri, Oct 15, 2021 at 6:02 PM Sören Tempel wrote: > > > > Hello, > > > > I hope this is the right way to report u-boot issues. I tried to reach > > out to the RISC-V subsystem maintainer beforehand but didn't receive a > >

Re: [PATCH] loads: Block writes into LMB reserved areas of U-Boot

2021-10-15 Thread Marek Vasut
On 10/15/21 6:09 PM, Tom Rini wrote: [...] This code looks OK but I don't know what lmb_reserve() and lmb_free() do. Can you add comments to the header file? Not here, the entire LMB stuff needs (better) documentation, that's where (all) such clarification should go. Is that you saying

Re: [PATCH v2] board: gateworks: venice: add imx8mn-gw7902 support

2021-10-15 Thread Jan Kiszka
On 15.10.21 19:06, Tim Harvey wrote: > A grep for SERIAL_SUPPORT (which was renamed to SERIAL) shows all the > boards in your master-next that got merged like mine that currently > likely need fixups: > $ git grep SERIAL_SUPPORT configs/ >

Re: [PATCH 2/6] am33x: Remove unused define CONFIG_MUSB_HOST

2021-10-15 Thread Tom Rini
On Mon, Oct 04, 2021 at 11:59:51AM +0200, Patrick Delaunay wrote: > This define was left over from a previous revision, and was never used. > > Signed-off-by: Patrick Delaunay > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 3/6] Remove unused CONFIG_NO_RELOCATION

2021-10-15 Thread Tom Rini
On Mon, Oct 04, 2021 at 11:59:52AM +0200, Patrick Delaunay wrote: > Remove the latest reference of CONFIG_NO_RELOCATION in code > > Signed-off-by: Patrick Delaunay > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 4/6] Remove unused CONFIG_SYS_FLASH_AMD_CHECK_DQ7

2021-10-15 Thread Tom Rini
On Mon, Oct 04, 2021 at 11:59:53AM +0200, Patrick Delaunay wrote: > Remove the latest reference of CONFIG_SYS_FLASH_AMD_CHECK_DQ7 in code > > Signed-off-by: Patrick Delaunay > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 5/6] Remove unused CONFIG_CONS_NONE

2021-10-15 Thread Tom Rini
On Mon, Oct 04, 2021 at 11:59:54AM +0200, Patrick Delaunay wrote: > Remove the latest reference of CONFIG_CONS_NONE in code > > Signed-off-by: Patrick Delaunay > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

[PATCH1/1]sqfs: sqfs_tokenize() should fill the tokens list instead of free items

2021-10-15 Thread Jincheng Wang
We can delete two lines of code to avoid double free bug, but still a wild pointers bug. A test for wild pointers: sqfsls host 0 1//2/3//4/5 Fill the tokens list can solve it well. Signed-off-by: Jincheng Wang --- fs/squashfs/sqfs.c | 5 +++-- 1 file changed, 3 insertions(+), 2

[PATCH v7 1/7] sandbox: Drop distro_boot

2021-10-15 Thread Simon Glass
This is a complicated set of #defines and it is painful to convert to a text file. We can (once pending patches are applied) provide the same functionality with bootmethod. Drop this for sandbox to allow conversion to a text-file environment. Signed-off-by: Simon Glass --- (no changes since v1)

[PATCH v7 0/7] env: Allow environment in text files

2021-10-15 Thread Simon Glass
One barrier to completing the 7-year-long Kconfig migration is that the default environment is implemented using ad-hoc CONFIG options. At present U-Boot environment variables, and thus scripts, are defined by CONFIG_EXTRA_ENV_SETTINGS. It is not really feasible to move the environment to Kconfig

Re: External dts building

2021-10-15 Thread Simon Glass
Hi Giulio, On Thu, 14 Oct 2021 at 21:06, Giulio Benetti wrote: > > Hi Simon, > > > Il giorno 15 ott 2021, alle ore 02:53, Simon Glass ha > > scritto: > > > > Hi Giulio, > > > >> On Thu, 14 Oct 2021 at 15:12, Giulio Benetti > >> wrote: > >> > >> Hi Simon, > >> > >> Il giorno 14 ott 2021, alle

[PATCH v7 2/7] doc: Move environment documentation to rST

2021-10-15 Thread Simon Glass
Move this from the README to rST format. Drop i2cfast since it is obviously obsolete and breaks the formatting. Other changes and improvements are in a following patch. Signed-off-by: Simon Glass --- (no changes since v6) Changes in v6: - Move all updates to a separate patch Changes in v5: -

[PATCH v7 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-15 Thread Simon Glass
At present U-Boot environment variables, and thus scripts, are defined by CONFIG_EXTRA_ENV_SETTINGS. It is painful to add large amounts of text to this file and dealing with quoting and newlines is harder than it should be. It would be better if we could just type the script into a text file and

[PATCH v7 7/7] bootm: Tidy up use of autostart env var

2021-10-15 Thread Simon Glass
This has different semantics in different places. Go with the bootm method and put it in a common function so that the behaviour is consistent in U-Boot. Update the docs. To be clear, this changes the way that 'bootelf' and standalone boot work. Before, if autostart was set to "fred" or "YES",

[PATCH v7 6/7] doc: Improve environment documentation

2021-10-15 Thread Simon Glass
Make various updates suggested during review of the rST conversion. Signed-off-by: Simon Glass Suggested-by: Wolfgang Denk --- Changes in v7: - A few more tweaks Changes in v6: - Move all updates to a separate patch - More updates and improvements Changes in v5: - Minor updates as suggested

[PATCH v7 4/7] sandbox: Use a text-based environment

2021-10-15 Thread Simon Glass
Use a text file for the environment instead of the #define settings. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch to use a text-based environment for sandbox board/sandbox/sandbox.env | 25 + include/configs/sandbox.h | 29

[PATCH v7 5/7] doc: Mention CONFIG_DEFAULT_ENV_FILE

2021-10-15 Thread Simon Glass
Add mention of this option this it does a similar thing to the text environment. Suggested-by: Rasmus Villemoes Signed-off-by: Simon Glass --- Changes in v7: - Add new patch to explain the relationship with DEFAULT_ENV_FILE doc/usage/environment.rst | 15 +++ 1 file changed, 15

Re: [PATCH] image: fix select_ramdisk for raw initrd

2021-10-15 Thread Art Nikpal
Hi Simon plz ignore this patch proper solution problem there > https://patchwork.ozlabs.org/project/uboot/patch/20211016051915.4157293-1-...@khadas.com/ On Fri, Oct 15, 2021 at 6:15 PM Artem Lapkin wrote: > > Problem > > We have unbootable raw initrd images because, select_ramdisk for raw >

Re: [PATCH v3 01/18] Create a new boot/ directory

2021-10-15 Thread Art Nikpal
> rename {common => boot}/image-board.c (100%) Before accepting this series we need to fix common/image-board.c which have mistakes! patch there > https://patchwork.ozlabs.org/project/uboot/patch/20211016051915.4157293-1-...@khadas.com/ On Fri, Oct 15, 2021 at 2:48 AM Simon Glass wrote: > >

Re: [PATCH 1/2] cmd: kaslrseed: add command to generate value from hwrng

2021-10-15 Thread Heinrich Schuchardt
Am 15. Oktober 2021 14:54:03 MESZ schrieb Kever Yang : >Reviewed-by: Kever Yang > > >Thanks, >- Kever > >Chris Morgan 于2021年8月26日周四 上午12:23写道: >> >> From: Chris Morgan >> >> Allow the kaslr-seed value in the chosen node to be set from a hardware >> rng source. >> >> Tested on a Rockchip PX30

[PATCH] image-board: fix wrong implementation ram disk address setup from cmdline

2021-10-15 Thread Artem Lapkin
Problem Wrong implementation logic: ramdisk cmdline image address always ignored! Next block { rd_addr = hextoul(select, NULL) } unusable for raw initrd. We have unbootable raw initrd images because, select_ramdisk for raw initrd images ignore submited select addr and setup rd_datap value to 0

Re: [PATCH 1/1] efi_loader: avoid multiple local copies of lf2_initrd_guid

2021-10-15 Thread Ilias Apalodimas
On Fri, Oct 15, 2021 at 02:36:36AM +0200, Heinrich Schuchardt wrote: > Create the GUID as a global variable. > > Signed-off-by: Heinrich Schuchardt > --- > cmd/efidebug.c | 3 +-- > include/efi_load_initrd.h| 1 + > lib/efi_loader/efi_helper.c | 5 + >

Re: [PATCH 1/1] efi_loader: efi_dp_from_lo() unused parameter size

2021-10-15 Thread Ilias Apalodimas
On Fri, Oct 15, 2021 at 02:09:33AM +0200, Heinrich Schuchardt wrote: > Parameter size is never used in function efi_dp_from_lo(). Remove it. > > Signed-off-by: Heinrich Schuchardt > --- > cmd/efidebug.c | 3 +-- > include/efi_loader.h | 1 - >

Re: [PATCH 1/1] efi_loader: efi_dp_from_lo() should skip VenMedia node

2021-10-15 Thread Ilias Apalodimas
On Fri, Oct 15, 2021 at 03:38:15AM +0200, Heinrich Schuchardt wrote: > The 'efidebug boot dump' command should not display the VenMedia() device > path node preceding the device path of the initial ram disk. > > By letting efi_dp_from_lo() skip the VenMedia() device path node we can > simplify

[PATCH] colibri-imx6ull: fix setup of nand gpmi clock

2021-10-15 Thread Philippe Schenker
NXP used to setup the gpmi clock root from gpmi_clk in early versions in their downstream BSP. [1] However on mainline the gpmi clock root was always setup from enfc since the beginning of the i.MX 6 series SoCs, which is still the same today. [2] NXP followed the mainline approach at some point

[PATCH v2] lmb: Reserve U-Boot separately if relocation is disabled

2021-10-15 Thread marek . vasut
From: Marek Vasut In case U-Boot starts with GD_FLG_SKIP_RELOC, the U-Boot code is not relocated, however the stack and heap is at the end of DRAM after relocation. Reserve a LMB area for the non-relocated U-Boot code so it won't be overwritten. Signed-off-by: Marek Vasut Cc: Simon Glass Cc:

Re: [PATCH] loads: Block writes into LMB reserved areas of U-Boot

2021-10-15 Thread Tom Rini
On Fri, Oct 15, 2021 at 04:23:27PM +0200, Marek Vasut wrote: > On 10/14/21 5:10 PM, Simon Glass wrote: > [...] > > > @@ -137,6 +138,7 @@ static int do_load_serial(struct cmd_tbl *cmdtp, int > > > flag, int argc, > > > > > > static ulong load_serial(long offset) > > > { > > > + struct

Re: [PATCH 1/6 v4] serial: qcom: add support for GENI serial driver

2021-10-15 Thread Dzmitry Sankouski
чт, 14 окт. 2021 г. в 18:10, Simon Glass : > Hi Dzmitry, > > On Fri, 8 Oct 2021 at 00:46, Dzmitry Sankouski > wrote: > > > > Generic Interface (GENI) Serial Engine (SE) based uart > > can be found on newer qualcomm SOCs, starting from SDM845. > > Tested on Samsung SM-G9600(starqltechn) > > by

Re: [PATCH 1/6] scripts: remove some configs in config_whitelist.txt

2021-10-15 Thread Tom Rini
On Mon, Oct 04, 2021 at 11:59:50AM +0200, Patrick Delaunay wrote: > Remove some config finishing by _ badly added by > scripts/build-whitelist.sh when joker is used in comments. > > for example: > doc/uImage.FIT/command_syntax_extensions.txt: > ... #ifdef CONFIG_OF_* |... > >

Re: [PATCH 00/16] fdt: Make OF_BOARD a boolean option

2021-10-15 Thread Simon Glass
Hi all, On Thu, 14 Oct 2021 at 09:28, Tom Rini wrote: > > On Thu, Oct 14, 2021 at 09:17:52AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Thu, 14 Oct 2021 at 08:56, Tom Rini wrote: > > > > > > On Wed, Oct 13, 2021 at 12:06:02PM -0600, Simon Glass wrote: > > > > Hi François, > > > > > > > >

Re: [PATCH 1/1 RFC] treewide: Deprecate OF_PRIOR_STAGE

2021-10-15 Thread Thomas Fitzsimmons
Hi Tom, Tom Rini writes: > On Wed, Oct 13, 2021 at 01:36:00PM -0400, Thomas Fitzsimmons wrote: >> Simon Glass writes: >> >> [...] >> >> > On Wed, 13 Oct 2021 at 10:26, Thomas Fitzsimmons >> > wrote: >> >> >> >> Simon Glass writes: >> >> >> >> [...] >> >> >> >> >> > I think one option is

Re: [PATCH 2/2] env: mmc: Add support for redundant env in both eMMC boot partitions

2021-10-15 Thread Tom Rini
On Wed, Oct 06, 2021 at 06:29:54PM +0200, Marek Vasut wrote: > Currently the MMC environment driver supports storing redundant environment > only in one eMMC partition at different offsets. This is sub-optimal, since > if this one boot partition is erased, both copies of environment are lost. >

Re: [PATCH v2] board: gateworks: venice: add imx8mn-gw7902 support

2021-10-15 Thread Tim Harvey
On Wed, Oct 6, 2021 at 4:45 PM Tim Harvey wrote: > > The GW7902 is based on the i.MX 8M Mini / Nano SoC featuring: > - LPDDR4 DRAM > - eMMC FLASH > - Gateworks System Controller > - LTE CAT M1 modem > - USB 2.0 HUB > - M.2 Socket with USB2.0, PCIe, and dual-SIM > - IMX8M FEC > - PCIe

Pull request, u-boot-tegra/master

2021-10-15 Thread Tom Warren
Tom, Please pull u-boot-tegra/master into U-Boot/master. Thanks. The following changes since commit 10cd8efe1a7eacd63907ba95bd8442bc2cdce461: Merge branch '2021-10-12-assorted-fixes-and-updates' (2021-10-13 10:14:35 -0400) are available in the git repository at:

Re: Broken build with disabling OpenSSL crypto

2021-10-15 Thread Pali Rohár
On Friday 15 October 2021 09:35:43 Alex G. wrote: > On 10/15/21 6:34 AM, Pali Rohár wrote: > > On Wednesday 06 October 2021 17:05:24 Alex G. wrote: > > > Hi Jernej, > > > > > > On 10/6/21 4:27 PM, Jernej Škrabec wrote: > > > > Hi everyone! > > > > > > > > Commit cb9faa6f98ae ("tools: Use a

[PATCH v1 2/2] x86: edison: Don't take SD card detect pin into consideration

2021-10-15 Thread Andy Shevchenko
There are two PCB designs in the wild which use the opposite signaling for SD card detect. This makes U-Boot working in one case and failing in the other. Quirk this out by disconnecting SD card detect pin from the PCB by switching to mode 3. BugLink:

[PATCH v1 1/2] x86: tangier: Enable support for SD/SDIO family in the pinmux driver

2021-10-15 Thread Andy Shevchenko
We would need to quirk out Card Detect case and for that we allow configuring SD/SDIO family of pins. Signed-off-by: Andy Shevchenko --- arch/x86/cpu/tangier/pinmux.c | 39 ++- 1 file changed, 34 insertions(+), 5 deletions(-) diff --git

Re: Double free vulnerability in sqfs commands ("sqfsls" and "sqfsload")

2021-10-15 Thread Jincheng Wang
Yes, I will submit a patch to fix the bug. Regards, Jincheng Tom Rini 于2021年10月15日周五 上午1:46写道: > On Tue, Oct 12, 2021 at 04:07:43PM +0800, Jincheng Wang wrote: > > > Hello U-Boot lists! > > I had been doing a fuzz testing in U-Boot . > > There is a double free bug in U-Boot, in

Re: Broken build with disabling OpenSSL crypto

2021-10-15 Thread Pali Rohár
On Wednesday 06 October 2021 17:05:24 Alex G. wrote: > Hi Jernej, > > On 10/6/21 4:27 PM, Jernej Škrabec wrote: > > Hi everyone! > > > > Commit cb9faa6f98ae ("tools: Use a single target-independent config to > > enable > > OpenSSL") recently introduced option to disable usage of OpenSSL via > >

Re: [PATCH] CI: Update to LLVM-13

2021-10-15 Thread Tom Rini
On Tue, Oct 05, 2021 at 01:51:38PM -0400, Tom Rini wrote: > - Switch sources and CI scripts to install and use LLVM-13 > - Update to latest "focal" tag. > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] pytest: Shorten traceback length by default

2021-10-15 Thread Tom Rini
On Tue, Oct 05, 2021 at 08:18:00PM -0600, Simon Glass wrote: > This produces a lot of code output which is not very helpful and is quite > annoying to wade through. Use the short format by default. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc

Re: [PATCH 1/5] pci: Skip configuring PCI Rom Address for unsupported header types

2021-10-15 Thread Tom Rini
On Thu, Oct 07, 2021 at 02:50:57PM +0200, Pali Rohár wrote: > PCI Rom Address is currently supported only for Normal (0x00) and > Bridge (0x01) header types. Fix code accordingly. > > Signed-off-by: Pali Rohár > Reviewed-by: Stefan Roese Applied to u-boot/master, thanks! -- Tom

Re: [PATCH 3/5] pci: Fix configuring BARs

2021-10-15 Thread Tom Rini
On Thu, Oct 07, 2021 at 02:50:59PM +0200, Pali Rohár wrote: > Number of BARs is defined by header type, not by class code. > > Signed-off-by: Pali Rohár > Reviewed-by: Stefan Roese Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [RFC PATCH 1/2] fpga_load: pass compatible string

2021-10-15 Thread Jorge Ramirez-Ortiz, Foundries
On 14/10/21, Simon Glass wrote: > Hi Jorge, > > On Tue, 5 Oct 2021 at 05:13, Jorge Ramirez-Ortiz wrote: > > > > Instead of ignoring the mandatory fpga compatible string, let the > > different implementations decide how to handle it > > > > Signed-off-by: Jorge Ramirez-Ortiz > > --- > >

Re: [PATCH] clk: introduce u-boot,ignore-clk-defaults

2021-10-15 Thread Peng Fan (OSS)
Simon, On 2021/10/14 23:11, Simon Glass wrote: On Wed, 13 Oct 2021 at 03:00, Peng Fan (OSS) wrote: From: Peng Fan Current code has a force clk_set_defaults in multiple stages, U-Boot reuse the same device tree and Linux Kernel device tree, but we not register all the clks as Linux Kernel,

Re: [PATCH 1/2] arm: imx: move spl_imx_romapi.c to imx8m/ subdirectory

2021-10-15 Thread Rasmus Villemoes
On 15/10/2021 11.02, Peng Fan (OSS) wrote: > > > On 2021/10/14 20:52, Rasmus Villemoes wrote: >> Currently, if one builds for an iMX platform != imx8m and selects >> CONFIG_SPL_BOOTROM_SUPPORT, the build breaks because some >> definitions (struct rom_api, the enum boot_dev_type_e and various >>

[PATCH] image: fix select_ramdisk for raw initrd

2021-10-15 Thread Artem Lapkin
Problem We have unbootable raw initrd images because, select_ramdisk for raw initrd images ignore submited select addr and setup rd_datap value to 0 Solution: setup rd_datap value from select Signed-off-by: Artem Lapkin --- common/image-board.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v3 00/18] pxe: Refactoring to tidy up and prepare for bootflow

2021-10-15 Thread Art Nikpal
hi Simon I am still testing this patchset for master branch! need more time (but looks like works) BTW: i have get some problems from prev your commits for example unbootable raw initrd images https://patchwork.ozlabs.org/project/uboot/patch/20211015101501.4091141-1-...@khadas.com/ i have send

Re: [PATCH] cmd: pxe_utils: Check fdtcontroladdr in label_boot

2021-10-15 Thread Andre Przywara
On Thu, 14 Oct 2021 12:24:45 -0600 Simon Glass wrote: Hi Simon, > On Thu, 14 Oct 2021 at 02:40, Peter Hoyes wrote: > > > > From: Peter Hoyes > > > > If using OF_CONTROL, fdtcontroladdr is set to the fdt used to configure > > U-Boot. When using PXE, if no fdt is defined in the menu file, and >

Re: [PATCH 1/2] arm: imx: move spl_imx_romapi.c to imx8m/ subdirectory

2021-10-15 Thread Peng Fan (OSS)
On 2021/10/14 20:52, Rasmus Villemoes wrote: Currently, if one builds for an iMX platform != imx8m and selects CONFIG_SPL_BOOTROM_SUPPORT, the build breaks because some definitions (struct rom_api, the enum boot_dev_type_e and various QUERY_* macros) are only exposed by the sys_proto.h header

[PATCHv2] fpga_load: pass compatible string

2021-10-15 Thread Jorge Ramirez-Ortiz
Instead of ignoring the mandatory fpga compatible string, let the different implementations decide how to handle it Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Simon Glass --- RFC v1->v2: added function comment cmd/fpga.c | 8 common/image.c | 4 ++--

[PATCH] lib: rsa: rsa-verify: also check that padding is not NULL

2021-10-15 Thread Philippe Reynes
This commit adds a check on the padding in the function rsa_verify_key to avoid using a NULL pointer. Signed-off-by: Philippe Reynes --- lib/rsa/rsa-verify.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rsa/rsa-verify.c b/lib/rsa/rsa-verify.c index

[PATCH] common: Kconfig.boot: add config SPL_FIT_RSASSA_PSS

2021-10-15 Thread Philippe Reynes
The padding pss is only supported on u-boot and tools since commit 2bbed3ff8c7f ("image: Use Kconfig to enable FIT_RSASSA_PSS on host") This commit adds the config SPL_FIT_RSASSA_PSS to support the padding pss in the SPL. Signed-off-by: Philippe Reynes --- common/Kconfig.boot | 7 +++ 1

[PATCH v3] sandbox: Remove OF_HOSTFILE

2021-10-15 Thread Ilias Apalodimas
OF_HOSTFILE is used on sandbox configs only. Although it's pretty unique and rarely causes confusion, we are better of having simpler config options for the DTB. So let's replace that with the existing OF_BOARD. U-Boot would then have only three config options for the DTB origin. -

[PATCH] mmc: rockchip_sdhci: enable strobe line for HS400

2021-10-15 Thread Yifeng Zhao
The default configuration of rk3399 EMMC PHY does not enable the strobe line, and EMMC controller will got data transmission error at HS400 mode. Signed-off-by: Yifeng Zhao --- drivers/mmc/rockchip_sdhci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mmc/rockchip_sdhci.c

Re: [PATCH v2] sandbox: Remove OF_HOSTFILE

2021-10-15 Thread Ilias Apalodimas
> > [...] > > This patch does not apply cleanly on top you your other series. > > Can you please resend it? Done! Cheers /Ilias > > Regards, > Simon

Re: [PATCH v3 1/4] tools: Separate image types which depend on OpenSSL

2021-10-15 Thread Pali Rohár
Hello! I did more investigation for this topic during working on kwboot improvements, which resulted in this patch series: https://lore.kernel.org/u-boot/20210924210716.29752-1-ka...@kernel.org/ The result is that kwbimage is used only for: Kirkwood, Dove, A370, AXP, A375, A38x, A39x and MSYS.

Re: [PATCH v2] pytest: Show a message when sandbox crashes

2021-10-15 Thread Tom Rini
On Fri, Oct 08, 2021 at 09:15:23AM -0600, Simon Glass wrote: > When a test hands on a real board there is no way on the console to obtain > any information about why it hung. > > With sandbox we can actually find out that it died and get a signal or > exit code. Add this to make it easier to

Re: [PATCH 5/5] pci: Fix showing registers

2021-10-15 Thread Tom Rini
On Thu, Oct 07, 2021 at 02:51:01PM +0200, Pali Rohár wrote: > Header type is 7-bit number so use all 7 bits when detecting header type > and not only 2 bits. > > Signed-off-by: Pali Rohár > Reviewed-by: Stefan Roese Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP

Re: [PATCH 4/5] pci: Fix showing bars

2021-10-15 Thread Tom Rini
On Thu, Oct 07, 2021 at 02:51:00PM +0200, Pali Rohár wrote: > Header type is 7-bit number so properly clear upper 8th bit which > indicates multifunction device. > > And do not try to show bars for unsupported header types. > > Signed-off-by: Pali Rohár > Reviewed-by: Stefan Roese Applied to

Re: [PATCH 2/5] pci: Skip configuring invalid P2P bridge devices

2021-10-15 Thread Tom Rini
On Thu, Oct 07, 2021 at 02:50:58PM +0200, Pali Rohár wrote: > Function dm_pci_hose_probe_bus() expects that bus is valid PCI device with > Bridge header type (0x01). So add check before touching PCI config space to > prevent misconfiguring some non-standard device. > > Signed-off-by: Pali Rohár

Re: [PATCH] pci: Fix printf format for regions

2021-10-15 Thread Tom Rini
On Fri, Oct 08, 2021 at 05:01:24PM +0200, Pali Rohár wrote: > Correct printf format for unsigned long long is %llx and not %llxx. > > Signed-off-by: Pali Rohár > Reviewed-by: Stefan Roese Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] board/km: update MAINTAINERS files

2021-10-15 Thread Tom Rini
On Tue, Oct 12, 2021 at 08:50:38AM +0200, Holger Brunck wrote: > Update the e-mail addresses and person responsible. > > Signed-off-by: Holger Brunck > CC: Aleksandar Gerasimovski > CC: Rainer Boschung Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-15 Thread Wolfgang Denk
Dear Simon Glass, In message <20211014122254.v6.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> you wrote: > At present U-Boot environment variables, and thus scripts, are defined > by CONFIG_EXTRA_ENV_SETTINGS. It is painful to add large amounts of text > to this file and dealing with

Re: Broken build with disabling OpenSSL crypto

2021-10-15 Thread Alex G.
On 10/15/21 6:34 AM, Pali Rohár wrote: On Wednesday 06 October 2021 17:05:24 Alex G. wrote: Hi Jernej, On 10/6/21 4:27 PM, Jernej Škrabec wrote: Hi everyone! Commit cb9faa6f98ae ("tools: Use a single target-independent config to enable OpenSSL") recently introduced option to disable usage of

Re: [PATCH] mmc: rockchip_sdhci: enable strobe line for HS400

2021-10-15 Thread Kever Yang
On 2021/10/15 下午4:41, Yifeng Zhao wrote: The default configuration of rk3399 EMMC PHY does not enable the strobe line, and EMMC controller will got data transmission error at HS400 mode. Signed-off-by: Yifeng Zhao Reviewed-by: Kever Yang Thanks, - Kever ---

Re: [PATCH v2] clk: rockchip: rk3568: update clks

2021-10-15 Thread Kever Yang
On 2021/10/12 下午4:43, Elaine Zhang wrote: fix up ppll init freq. support tclk_emmc. add freq (26M) for mmc device. fix up the sfc clk rate unit error. Change in V2: remove change id. Signed-off-by: Elaine Zhang Reviewed-by: Kever Yang Thanks, - Kever ---

Re: [PATCH 2/2] rockchip: board: remove SCLK_GPU from U-Boot DT

2021-10-15 Thread Kever Yang
Reviewed-by: Kever Yang Thanks, - Kever Chris Morgan 于2021年8月6日周五 上午12:49写道: > > From: Chris Morgan > > Starting with commit 92f1e9a4b31c ("clk: Detect failure to set > defaults") the clk driver for the PX30 would fail to probe for the > Odroid Go Advance. This patch is to remove the clock

[PATCH] arm64: zynqmp: Fix sgmii clock input freq for p-a2197

2021-10-15 Thread Michal Simek
Input frequency for sgmii is 125MHz on all Xilinx designs. Signed-off-by: Michal Simek --- arch/arm/dts/zynqmp-p-a2197-00-revA.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/dts/zynqmp-p-a2197-00-revA.dts b/arch/arm/dts/zynqmp-p-a2197-00-revA.dts index

Re: [PATCH] rockchip: rk33xx: Drop ROCKCHIP_USB2_PHY on boards without it

2021-10-15 Thread Kever Yang
Reviewed-by: Kever Yang Thanks, - Kever Peter Robinson 于2021年8月12日周四 下午5:11写道: > > The 64 bit rk33xx chips don't have the ROCKCHIP_USB2_PHY IP so > drop the configs as they were likely copied over from other > boards during enablement. > > Signed-off-by: Peter Robinson > --- >

Re: [PATCH] rockchip: px30: sync serial flash controller bindings with mainline

2021-10-15 Thread Kever Yang
Reviewed-by: Kever Yang Thanks, - Kever Chris Morgan 于2021年8月21日周六 上午9:47写道: > > From: Chris Morgan > > The devicetree submitted and approved for the mainline linux kernel is > slightly different than the one present here. This syncs both > devicetrees (for the Rockchip SFC node at least)

Re: [PATCH 1/2] cmd: kaslrseed: add command to generate value from hwrng

2021-10-15 Thread Kever Yang
Reviewed-by: Kever Yang Thanks, - Kever Chris Morgan 于2021年8月26日周四 上午12:23写道: > > From: Chris Morgan > > Allow the kaslr-seed value in the chosen node to be set from a hardware > rng source. > > Tested on a Rockchip PX30 (Odroid Go Advance), you must have loaded > the devicetree first and

[PATCH] net: gem: Disable broadcast setting

2021-10-15 Thread Michal Simek
There is no need for GEM to accepts broadcast packets because they are not handled by u-boot anyway. That's why use HW IP feature and don't waste time on these packats which will be dropped anyway. Signed-off-by: Michal Simek --- drivers/net/zynq_gem.c | 2 ++ 1 file changed, 2 insertions(+)

[PATCH v2 3/9] armv8: fsl-layerscape: rework the dwc3 snooping enable code

2021-10-15 Thread Michael Walle
Instead of looking at all USB (host) devices, just search all DWC3 device tree nodes. This will (1) fix a panic if of_match is zero and (2) also apply the fixup if the controller is in peripheral mode. Both happen when the DWC3 USB controller driver is used. Signed-off-by: Michael Walle ---

[PATCH v2 2/9] test: dm: add test for ofnode_for_each_compatible_node()

2021-10-15 Thread Michael Walle
Check that all matching nodes have the correct compatible and that there is at least one match. Signed-off-by: Michael Walle --- test/dm/ofnode.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/test/dm/ofnode.c b/test/dm/ofnode.c index 49efabe871..cea0746bb3 100644 ---

[PATCH v2 0/9] usb: dwc3: add Layerscape SoC support

2021-10-15 Thread Michael Walle
Primarily, this will add support for peripheral mode on Layerscape SoCs. For this to work, we have to backport two fixes from linux and fix the fixup code for the DWC3 controller (which enables snooping because the SoC has wrong startup defaults). As a first user of the driver, enable it on the

[PATCH v2 1/9] dm: core: add ofnode_for_each_compatible_node()

2021-10-15 Thread Michael Walle
Add a helper to iterate over all nodes with a given compatible string. Signed-off-by: Michael Walle Reviewed-by: Simon Glass --- include/dm/ofnode.h | 24 1 file changed, 24 insertions(+) diff --git a/include/dm/ofnode.h b/include/dm/ofnode.h index

[PATCH v4 4/4] arm: zynqmp: Enable PWM command and cadence ttc pwm driver

2021-10-15 Thread Michal Simek
Enable PWM ttc driver and command in generic image. Signed-off-by: Michal Simek --- Changes in v4: - New patch in the series configs/xilinx_zynqmp_virt_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configs/xilinx_zynqmp_virt_defconfig b/configs/xilinx_zynqmp_virt_defconfig

[PATCH v4 2/4] timer: cadence: Add bind function to driver

2021-10-15 Thread Michal Simek
When DT node has pwm-cells property it shouldn't be bind as timer driver but as PWM driver. That's why make sure that this property is checked. Signed-off-by: Michal Simek Reviewed-by: Sean Anderson Reviewed-by: Simon Glass --- Changes in v4: - Add reviewed-by tags Changes in v3: - New patch

[PATCH v4 3/4] pwm: Add driver for cadence TTC

2021-10-15 Thread Michal Simek
TTC has three modes of operations. Timer, PWM and input counters. There is already driver for timer under CADENCE_TTC_TIMER which is used for ZynqMP R5 configuration. This driver is targeting PWM which is for example configuration which can be used for fan control. The driver has been tested on

[PATCH v4 1/4] dm: core: Bind another driver with the same compatible string

2021-10-15 Thread Michal Simek
When one IP can have multiple configurations (like timer and PWM) covered by multiple drivers. Because it is the same IP it should also have the same compatible string. Current code look for the first driver which matches compatible string and call bind function. If this is not the right driver

[PATCH v2 9/9] board: sl28: enable USB periheral support and gadgets

2021-10-15 Thread Michael Walle
Enable support to update the board via the DFU protocol and make it possible to export the block devices via USB mass storage protocol. This will not work out of the box, yet. You have to change the dr_mode of the usb0 controller to peripheral manually to make it work. True, OTG support will

Re: [PATCH v2 09/13] env: Use string pointer instead of indexes in env_get_f()

2021-10-15 Thread Marek Behún
Hi Simon, On Thu, 14 Oct 2021 18:40:02 -0600 Simon Glass wrote: > > -static int env_match(const char *env, const char *s1, int i2) > > +static const char *matching_name_get_value(const char *p, const > > char *name) > > OK so this is the function where I would like a nice comment, please.

Re: [PATCH 1/2] rockchip: px30: add support for setting cpll clock

2021-10-15 Thread Kever Yang
Reviewed-by: Kever Yang Thanks, - Kever Chris Morgan 于2021年8月6日周五 上午12:49写道: > > From: Chris Morgan > > Starting with commit 92f1e9a4b31c ("clk: Detect failure to set > defaults") the clk driver for the PX30 for the Odroid Go Advance would > no longer probe correctly, because setting the

Re: [PATCH 1/2] doc: rockchip: sort rockchip support list for rk3188

2021-10-15 Thread Kever Yang
Reviewed-by: Kever Yang Thanks, - Kever Johan Jonker 于2021年8月21日周六 上午1:33写道: > > In the list of mainline U-boot supported Rockchip boards > rk3188 is placed below under the name rv3188. Give back it's > original name and sort the list in alphabetical order. > > Signed-off-by: Johan Jonker >

Re: [PATCH 2/2] doc: rockchip: write all brand names with a capital

2021-10-15 Thread Kever Yang
Reviewed-by: Kever Yang Thanks, - Kever Johan Jonker 于2021年8月21日周六 上午1:33写道: > > Brand names are supposed to be written with a capital, > so change them all. > > Signed-off-by: Johan Jonker > --- > doc/board/rockchip/rockchip.rst | 16 > 1 file changed, 8 insertions(+), 8

Re: [PATCH 1/1] rockchip: px30: add support for HW RNG for Odroid Go Advance

2021-10-15 Thread Kever Yang
Reviewed-by: Kever Yang Thanks, - Kever Chris Morgan 于2021年8月26日周四 上午12:24写道: > > From: Chris Morgan > > The Odroid Go Advance has a hardware random number generator present. > The device does not have an upstream Linux driver, but does have a > U-Boot driver. Add the appropriate node so

[PATCH v2 7/9] usb: dwc3: add layerscape support

2021-10-15 Thread Michael Walle
Add support for the proper dwc3 device tree binding support as specified in the offical device tree spec. Initially, add support for the LS1028A support. Other SoCs should be easy to add by just adding the corresponding compatible string. Unfortunately, the device trees of all other layerscape

[PATCH v2 6/9] usb: dwc3: Enable undefined length INCR burst type

2021-10-15 Thread Michael Walle
[backport from linux commit d9612c2f0449e24983a8b689603210486a930c90] Enable the undefined length INCR burst type and set INCRx. Different platform may has the different burst size type. In order to get best performance, we need to tune the burst size to one special value, instead of the default

[PATCH v2 5/9] usb: dwc3: Add frame length adjustment quirk

2021-10-15 Thread Michael Walle
[backport from linux commit db2be4e9e30c6e43e48c5749d3fc74cee0a6bbb3] Add adjust_frame_length_quirk for writing to fladj register which adjusts (micro)frame length to value provided by "snps,quirk-frame-length-adjustment" property thus avoiding USB 2.0 devices to time-out over a longer run

[PATCH v2 8/9] board: sl28: switch to dwc3 driver

2021-10-15 Thread Michael Walle
Now that the DWC3 USB driver has support for the layerscape platform, use it. This will have the benefit that peripheral mode will work. Signed-off-by: Michael Walle --- configs/kontron_sl28_defconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH v2 4/9] usb: common: silence dubious errors

2021-10-15 Thread Michael Walle
Both dr_mode and maximum-speed properties are usually optional. Drivers will still try to fetch the properties nonetheless, which leads to error messages, although they are no errors. Change pr_err() to pr_debug(). Signed-off-by: Michael Walle --- drivers/usb/common/common.c | 4 ++-- 1 file

  1   2   >