Re: [PATCH 2/4] tools: kwbimage: Align BIN header executable code to 128-bit boundary

2021-10-22 Thread Stefan Roese
On 21.10.21 16:46, Pali Rohár wrote: ARM executable code inside the BIN header on some mvebu platforms (e.g. A370, AXP) must always be aligned with the 128-bit boundary. This requirement can be met by inserting dummy arguments into BIN header. Signed-off-by: Pali Rohár Reviewed-by: Stefan

Re: [PATCH 1/4] tools: kwboot: Align UART baudrate change code in BIN header to 128-bit boundary

2021-10-22 Thread Stefan Roese
On 21.10.21 16:46, Pali Rohár wrote: ARM executable code inside the BIN header on some mvebu platforms (e.g. A370, AXP) must always be aligned with the 128-bit boundary. This requirement can be met by inserting dummy arguments into BIN header. Signed-off-by: Pali Rohár Reviewed-by: Stefan

Re: [RFC PATCH] tools: kwbimage: Allow to disable compilation of kwbimage on non-mvebu platforms

2021-10-22 Thread Pali Rohár
Hello! On Thursday 21 October 2021 20:48:22 Samuel Holland wrote: > Hi, > > Thanks for sending this patch! > > On 10/21/21 4:33 AM, Pali Rohár wrote: > > kwbimage depends on libcrypto. 32-bit mvebu platforms (except Orion and > > Discovery, which are not in mach-mvebu) require kwimage for

Re: [PATCH v1 0/2] board: toradex: improve env badblock management for NAND variant boards

2021-10-22 Thread Francesco Dolcini
Hello Stefano, On Thu, Oct 21, 2021 at 01:08:16PM +0200, Francesco Dolcini wrote: > On Thu, Oct 21, 2021 at 12:16:33PM +0200, Stefano Babic wrote: > > On 01.09.21 09:48, Francesco Dolcini wrote: > > > > > > Use the complete 512kb (4 blocks) nand partition reserved for u-boot > > > environment

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-22 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > > > i.e. > > > var+=value > > > appends value to var, while > > > var\+=value > > > sets variable with name "var+" > > My first preference is to disallow + at the end of an end var. Perhaps > we can start printing a warning if people do it, for a few

Re: [PATCH 4/4] mmc: sunxi: Use DM_GPIO flags to set pull-up

2021-10-22 Thread Jaehoon Chung
Hi Andre, On 10/22/21 6:00 PM, Andre Przywara wrote: > On Fri, 22 Oct 2021 06:58:48 +0900 > Jaehoon Chung wrote: > > Hi Jaehoon, > > thanks for having a look! > >> Hi, >> >> On 10/21/21 1:52 PM, Samuel Holland wrote: >>> Now that the sunxi_gpio driver handles pull-up/down via the driver >>>

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-22 Thread Heinrich Schuchardt
On 10/21/21 15:00, Marek Behún wrote: BTW, wouldn't it be enough to simply imply TOOLS_LIBCRYPTO for mvebu platform in Kconfig? We should only use 'imply' for suggested settings and never for hard requirements. TOOLS_LIBCRYPTO already defaults to 'Y'. So implying it for mvebu would be

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-22 Thread Rasmus Villemoes
On 21/10/2021 18.03, Tom Rini wrote: > On Thu, Oct 21, 2021 at 09:59:38AM -0600, Simon Glass wrote: >> Hi Marek, >> >> On Thu, 21 Oct 2021 at 07:28, Marek Behún wrote: >>> >>> On Thu, 21 Oct 2021 15:25:37 +0200 >>> Marek Behún wrote: >>> Hello, On Thu, 21 Oct 2021 15:06:51 +0200

[PATCH v2] board: toradex: add verdin imx8m plus support

2021-10-22 Thread Marcel Ziswiler
From: Marcel Ziswiler This adds initial support for the Toradex Verdin iMX8M Plus Quad 4GB WB IT V1.0B module. They are strapped to boot from eFuses which are factory fused to properly boot from their on-module eMMC. U-Boot supports booting from the on-module eMMC only, SDP support is disabled

Re: [PATCH u-boot-marvell v3 00/39] kwboot higher baudrate

2021-10-22 Thread Pali Rohár
On Friday 22 October 2021 10:38:16 Stefan Roese wrote: > Hi Marek, Hi Pali, > > since now all is merged into master, I'm testing on my AXP target > again. Please see below. > > On 01.10.21 12:45, Marek Behún wrote: > > On Fri, 1 Oct 2021 12:40:29 +0200 > > Stefan Roese wrote: > > > > > U-Boot

Re: [PATCH 4/4] mmc: sunxi: Use DM_GPIO flags to set pull-up

2021-10-22 Thread Andre Przywara
On Fri, 22 Oct 2021 06:58:48 +0900 Jaehoon Chung wrote: Hi Jaehoon, thanks for having a look! > Hi, > > On 10/21/21 1:52 PM, Samuel Holland wrote: > > Now that the sunxi_gpio driver handles pull-up/down via the driver > > model, pin configuration does not need a platform-specific function. >

[PATCH] board: stmp32mp1: split board and SOC STM32MP15 configuration

2021-10-22 Thread Patrick Delaunay
Add a configuration file "stm32mp15_st_common.h" to handle the STMicroelectronics boards configuration and rename stm32mp1.h to "stm32mp15_common.h" to handle the generic STM32MP15x series configuration. The configuration file "dh_stm32mp1.h" is also renamed to "stm32mp15_dh_dhcom" for the

Re: [PATCH v6 2/2] board: kontron: pitx-imx8m: Add Kontron pitx-imx8m board support

2021-10-22 Thread Heiko Thiery
Hi Stefano, Hi Simon, Am Do., 21. Okt. 2021 um 15:57 Uhr schrieb Heiko Thiery : > > Hi Stefano, Hi Simon, > > > Am Do., 21. Okt. 2021 um 15:29 Uhr schrieb Stefano Babic : > > > > On 21.10.21 15:17, Heiko Thiery wrote: > > > Hi Stefano, > > > > > > > > > Am Do., 21. Okt. 2021 um 13:31 Uhr schrieb

Re: [PATCH v3 2/3] efi_loader: add UEFI GPT measurement

2021-10-22 Thread Masahisa Kojima
Hi Simon, On Sat, 2 Oct 2021 at 00:23, Simon Glass wrote: > > Hi Masahisa, > > On Fri, 1 Oct 2021 at 05:19, Masahisa Kojima > wrote: > > > > This commit adds the UEFI GPT disk partition topology > > measurement required in TCG PC Client PFP Spec. > > > > Signed-off-by: Masahisa Kojima > > ---

Re: [PATCH v1 0/2] board: toradex: improve env badblock management for NAND variant boards

2021-10-22 Thread Stefano Babic
Hi Francesco, On 22.10.21 09:59, Francesco Dolcini wrote: Hello Stefano, On Thu, Oct 21, 2021 at 01:08:16PM +0200, Francesco Dolcini wrote: On Thu, Oct 21, 2021 at 12:16:33PM +0200, Stefano Babic wrote: On 01.09.21 09:48, Francesco Dolcini wrote: Use the complete 512kb (4 blocks) nand

Re: [PATCH v3 3/3] efi_loader: add DeployedMode and AuditMode variable measurement

2021-10-22 Thread Masahisa Kojima
Hi Heinrich, On Mon, 4 Oct 2021 at 11:30, Masahisa Kojima wrote: > > On Sat, 2 Oct 2021 at 01:43, Heinrich Schuchardt wrote: > > > > > > > > On 10/1/21 13:18, Masahisa Kojima wrote: > > > This commit adds the DeployedMode and AuditMode variable > > > measurement required in TCG PC Client PFP

Re: [PATCH 3/4] arm: mvebu: Add documentation for save_boot_params() function

2021-10-22 Thread Stefan Roese
On 21.10.21 16:46, Pali Rohár wrote: Important detail is availability of kwbimage BIN header arguments passed via r0 and r1 registers by BootROM. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- arch/arm/mach-mvebu/lowlevel_spl.S | 9 + 1 file changed, 9

Re: [PATCH 4/4] arm: mvebu: Remove dummy BIN header arguments for SPL binary

2021-10-22 Thread Stefan Roese
On 21.10.21 16:46, Pali Rohár wrote: U-Boot SPL binary does not read BIN header arguments, so passing some dummy values 005b and 0068 has no effect for U-Boot SPL code. Probably these two values comes from old Marvell DDR training code which was separated from U-Boot and used it for

Re: [PATCH] arm: mvebu: turris_omnia: Fix MTD partitions order for Linux

2021-10-22 Thread Stefan Roese
On 21.10.21 17:55, Pali Rohár wrote: Linux enumerates MTD partitions in DTB order, while the fdt_add_subnode() function puts a new subnode at the beginning. To fix this, put MTD partitions into DTB in reverse order. Fixes: 92f36c8e74c1 ("arm: mvebu: turris_omnia: fixup MTD partitions in Linux'

serial download on imx8mp

2021-10-22 Thread Rasmus Villemoes
Hi I'm having trouble getting serial download to work on an imx8mp evk. I'm building on top of v2021.10. The SPL + U-Boot proper that I build work fine when I write them to an SD card and boot from that, also boot from eMMC with the same binaries works fine. I can also succesfully get the SPL

breakpoint not working in do_mmc_read (using qemu)

2021-10-22 Thread Chan Kim
Hello, u-boot experts, I need to modify a proprietary SD card host controller driver to be used in u-boot and I wanted to see the driver interface with the u-boot using qemu. Trying to run u-boot on qemu with SD card, I found this nice question :

Re: [PATCH u-boot-marvell v3 00/39] kwboot higher baudrate

2021-10-22 Thread Stefan Roese
Hi Marek, Hi Pali, since now all is merged into master, I'm testing on my AXP target again. Please see below. On 01.10.21 12:45, Marek Behún wrote: On Fri, 1 Oct 2021 12:40:29 +0200 Stefan Roese wrote: U-Boot SPL 2021.10-rc5-00431-g6c96332441cf-dirty (Oct 01 2021 - 12:38:55 +0200) High

[PATCH] arm: mvebu: Fix comments about kwbimage structures

2021-10-22 Thread Pali Rohár
kwbimage v1 is used on more SoCs. Signed-off-by: Pali Rohár --- arch/arm/mach-mvebu/spl.c | 2 +- cmd/mvebu/bubt.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-mvebu/spl.c b/arch/arm/mach-mvebu/spl.c index b798c797cc27..04d9640b142d 100644 ---

Re: [PATCH v2] board: toradex: add verdin imx8m plus support

2021-10-22 Thread Francesco Dolcini
On Fri, Oct 22, 2021 at 09:31:04AM +0200, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > This adds initial support for the Toradex Verdin iMX8M Plus Quad 4GB WB > IT V1.0B module. They are strapped to boot from eFuses which are factory > fused to properly boot from their on-module eMMC.

Re: [PATCH 4/4] mmc: sunxi: Use DM_GPIO flags to set pull-up

2021-10-22 Thread Andre Przywara
On Fri, 22 Oct 2021 19:10:20 +0900 Jaehoon Chung wrote: > Hi Andre, > > On 10/22/21 6:00 PM, Andre Przywara wrote: > > On Fri, 22 Oct 2021 06:58:48 +0900 > > Jaehoon Chung wrote: > > > > Hi Jaehoon, > > > > thanks for having a look! > > > >> Hi, > >> > >> On 10/21/21 1:52 PM, Samuel

Re: [PATCH v10 3/9] env: Allow U-Boot scripts to be placed in a .env file

2021-10-22 Thread Wolfgang Denk
Dear Simon, In message <20211021210847.v10.3.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> you wrote: > At present U-Boot environment variables, and thus scripts, are defined > by CONFIG_EXTRA_ENV_SETTINGS. It is painful to add large amounts of text > to this file and dealing with quoting

Re: [PATCH u-boot-marvell v3 00/39] kwboot higher baudrate

2021-10-22 Thread Stefan Roese
Hi Pali, On 22.10.21 10:48, Pali Rohár wrote: On Friday 22 October 2021 10:38:16 Stefan Roese wrote: Hi Marek, Hi Pali, since now all is merged into master, I'm testing on my AXP target again. Please see below. On 01.10.21 12:45, Marek Behún wrote: On Fri, 1 Oct 2021 12:40:29 +0200 Stefan

[PATCH 1/3] tools: kwbimage: Add support for NAND_PAGE_SIZE command also for v1 images

2021-10-22 Thread Pali Rohár
The NAND_PAGE_SIZE command is already supported by mkimage for v0 images, but not for v1 images. A38x and A39x BootROM supports reading NAND flash page size from v1 image in the same way as Kirkwood BootROM from v0 image. It it documented in A38x and A39x Functional Specification. Signed-off-by:

[PATCH 0/3] arm: mvebu: nandpagesize support for kwbimage v1

2021-10-22 Thread Pali Rohár
This patch series updates mvebu code which handles nandpagesize in kwbimage v1. Pali Rohár (3): tools: kwbimage: Add support for NAND_PAGE_SIZE command also for v1 images tools: kwboot: Patch nandpagesize to zero also for v1 image arm: mvebu: Update name of kwbimage v1 field at offset

[PATCH 2/3] tools: kwboot: Patch nandpagesize to zero also for v1 image

2021-10-22 Thread Pali Rohár
kwbimage v1 has also nandpagesize field. So set it to zero for both image versions when image is not signed. Signed-off-by: Pali Rohár --- tools/kwboot.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/tools/kwboot.c b/tools/kwboot.c index

[PATCH 3/3] arm: mvebu: Update name of kwbimage v1 field at offset 0x2-0x3

2021-10-22 Thread Pali Rohár
At this offset is stored nand page size. Signed-off-by: Pali Rohár --- arch/arm/mach-mvebu/spl.c | 2 +- cmd/mvebu/bubt.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-mvebu/spl.c b/arch/arm/mach-mvebu/spl.c index 04d9640b142d..cad3f0a48893 100644

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-22 Thread Wolfgang Denk
Dear Tom, In message <20211021160311.GC3577824@bill-the-cat> you wrote: > > How bad does it make the parser look if we allow trailing + in variable > names, by escaping them? It's seemingly the substantive objection at > this point. Any escape character is also a legal name character. Best

Pull request for efi-2022-01-rc1

2021-10-22 Thread Heinrich Schuchardt
The following changes since commit fb1018106a7bbb1a0d723029f6760b1b1b4d306d: Merge branch '2021-10-19-assorted-changes' (2021-10-19 20:45:12 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-efi.git tags/efi-2022-01-rc1 for you to fetch changes

Re: Please pull u-boot-dm

2021-10-22 Thread Tom Rini
On Thu, Oct 21, 2021 at 07:36:44PM -0600, Simon Glass wrote: > Hi Tom, > > https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/9563 > > > > The following changes since commit f200a4bcecf1be6d8b546f0eb6af6403c93d80dd: > > Merge

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-22 Thread Marek Behún
Hello Wolfgang, On Fri, 22 Oct 2021 10:06:55 +0200 Wolfgang Denk wrote: > For the '+=' case, there is no way to escape the '+', as all > commonly used escapes are valid characters in the variable name, > too. We can define that backslash is to be also escaped if it is to be used as variable

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-22 Thread Marek Behún
On Fri, 22 Oct 2021 12:09:19 +0200 Heinrich Schuchardt wrote: > On 10/21/21 15:00, Marek Behún wrote: > > BTW, wouldn't it be enough to simply imply TOOLS_LIBCRYPTO for mvebu > > platform in Kconfig? > > > > We should only use 'imply' for suggested settings and never for hard >

Re : Re: Commit 76c2ff3e broke backlight on Chromebook snow

2021-10-22 Thread Guillaume GARDET
Hi Dario, - Dario Binacchi a écrit : > Hi Guillaume, > > > Il 21/10/2021 16:47 Guillaume GARDET ha scritto: > > > > > > Hi, > > > > Commit 76c2ff3e [0] broke backlight on Chromebook snow. > > A revert on top of 2021.10 restores the backlight. > > Not sure why it breaks on Chromebook

[PATCH 03/14] env: sf: Put ENV_INVALID into gd->env_valid on CRC failure

2021-10-22 Thread Marek Behún
From: Marek Behún env_sf_init_addr() says the environment is valid even if it is assigning default environment due to CRC failure. Change this to ENV_INVALID and let the generic env_init() function, which calls this initializer, assign the default environment. Signed-off-by: Marek Behún ---

[PATCH 04/14] env: nand: Put ENV_INVALID into gd->env_valid if default environment

2021-10-22 Thread Marek Behún
From: Marek Behún env_nand_init() says the environment is valid even if it is assigning default environment due to not being able to access nand pre-reloaction (determined by macro values). Change this to ENV_INVALID and let the generic env_init() function, which calls this initializer, assign

[PATCH 09/14] env: flash: Let generic env_init() assign default environment

2021-10-22 Thread Marek Behún
From: Marek Behún env_flash_init() (both implementations) assigns default environment if ENV_INVALID, but this is done in the generic env_init() function, which calls this initializer, so drop it from here. Signed-off-by: Marek Behún --- env/flash.c | 3 --- 1 file changed, 3 deletions(-)

[PATCH 01/14] env: sf: Cosmetic fix in env_sf_init_addr()

2021-10-22 Thread Marek Behún
From: Marek Behún In the if clause we use tabs and in the else clause spaces. Let's use spaces in the if clause too. Signed-off-by: Marek Behún --- env/sf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/env/sf.c b/env/sf.c index e4b7ca9e04..4096e18387 100644 ---

[PATCH 05/14] env: nvram: Let generic env_init() assign default environment

2021-10-22 Thread Marek Behún
From: Marek Behún env_nvram_init() assigns default environment if ENV_INVALID, but this is done in the generic env_init() function, which calls this initializer, so drop it from here. Signed-off-by: Marek Behún --- env/nvram.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-22 Thread Tom Rini
On Fri, Oct 22, 2021 at 04:59:22PM +0200, Marek Behún wrote: > On Fri, 22 Oct 2021 12:09:19 +0200 > Heinrich Schuchardt wrote: > > > On 10/21/21 15:00, Marek Behún wrote: > > > BTW, wouldn't it be enough to simply imply TOOLS_LIBCRYPTO for mvebu > > > platform in Kconfig? > > > > > > > We

Re: [PATCH v3 1/2] lib: uuid: use RNG device if present

2021-10-22 Thread Patrick DELAUNAY
Hi On 12/18/20 10:28 AM, matthias@kernel.org wrote: From: Matthias Brugger When calculating a random UUID we use a weak seed. Use a RNG device if present to increase entropy. Signed-off-by: Matthias Brugger --- Changes in v3: - use IS_ENABLED instead of #if - use 4 byte for entropy

Re: [PATCH v6 2/2] board: kontron: pitx-imx8m: Add Kontron pitx-imx8m board support

2021-10-22 Thread Simon Glass
Hi Heiko, On Fri, 22 Oct 2021 at 07:24, Heiko Thiery wrote: > > Hi, > > Am Fr., 22. Okt. 2021 um 14:37 Uhr schrieb Stefano Babic : > > > > Hi Heiko, > > > > On 22.10.21 10:19, Heiko Thiery wrote: > > > Hi Stefano, Hi Simon, > > > > > > Am Do., 21. Okt. 2021 um 15:57 Uhr schrieb Heiko Thiery > >

Re: [PATCH 01/14] env: sf: Cosmetic fix in env_sf_init_addr()

2021-10-22 Thread Simon Glass
On Fri, 22 Oct 2021 at 07:47, Marek Behún wrote: > > From: Marek Behún > > In the if clause we use tabs and in the else clause spaces. Let's use > spaces in the if clause too. > > Signed-off-by: Marek Behún > --- > env/sf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-22 Thread Tom Rini
On Fri, Oct 22, 2021 at 04:56:09PM +0100, Andre Przywara wrote: > On Fri, 22 Oct 2021 11:09:27 -0400 > Tom Rini wrote: > > Hi, > > > On Fri, Oct 22, 2021 at 04:59:22PM +0200, Marek Behún wrote: > > > On Fri, 22 Oct 2021 12:09:19 +0200 > > > Heinrich Schuchardt wrote: > > > > > > > On

[PATCH] efi_loader: add EFI_TCG2_PROTOCOL.SubmitCommand

2021-10-22 Thread Masahisa Kojima
This commit adds the EFI_TCG2_PROTOCOL.SubmitCommand required in the TCG PC Client PFP spec. SubmitCommand enables to send the raw command to the TPM device. To implement this api, tpm2_submit_command() is added into tpm-v2.c. Signed-off-by: Masahisa Kojima --- include/tpm-v2.h | 15

[PATCH v1 1/5] riscv: dts: Split Microchip device tree

2021-10-22 Thread Padmarao Begari
The device tree split into .dtsi and .dts files, common device node for eMMC/SD, enable I2C1, UART1 for console instead of UART0, enable the DDR 2GB memory and in that 288MB memory is reserved for fabric buffer. Signed-off-by: Padmarao Begari --- arch/riscv/dts/microchip-mpfs-icicle-kit.dts |

[PATCH v1 3/5] i2c: Add Microchip PolarFire SoC I2C driver

2021-10-22 Thread Padmarao Begari
Add I2C driver code for the Microchip PolarFire SoC. This driver supports I2C data transfer and probe for I2C slave addresses. Signed-off-by: Padmarao Begari --- drivers/i2c/Kconfig | 6 + drivers/i2c/Makefile| 1 + drivers/i2c/i2c-microchip.c | 482

[PATCH v1 4/5] net: macb: Compatible as per device tree

2021-10-22 Thread Padmarao Begari
Update compatible as per Microchip PolarFire SoC ethernet device node. Signed-off-by: Padmarao Begari --- drivers/net/macb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/macb.c b/drivers/net/macb.c index 8c6461e717..1b867bd5c2 100644 --- a/drivers/net/macb.c

[PATCH v1 2/5] riscv: Update Microchip MPFS Icicle Kit support

2021-10-22 Thread Padmarao Begari
This patch updates Microchip MPFS Icicle Kit support. For now, add Microchip I2C driver, set environment variables for mac addesses and default build for SBI_V02. Signed-off-by: Padmarao Begari --- board/microchip/mpfs_icicle/Kconfig | 5 + board/microchip/mpfs_icicle/mpfs_icicle.c |

[PATCH v1 5/5] doc: board: Update Microchip MPFS Icicle Kit doc

2021-10-22 Thread Padmarao Begari
UART1 uses for U-BOOT and Linux console instead of UART0 and UART0 is reserved for Hart Software Services(HSS). Signed-off-by: Padmarao Begari --- doc/board/microchip/mpfs_icicle.rst | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git

[PATCH 14/14] env: Use static_assert() to check if default_environment is too large

2021-10-22 Thread Marek Behún
From: Marek Behún Check sizeof(default_environment) against ENV_SIZE in a static_assert() instead of runtime. Only check if !USE_HOSTCC (for in fw_env tool ENV_SIZE expands to a variable, and cannot be checked statically) nad !DEFAULT_ENV_INSTANCE_EMBEDDED, for in that case the

[PATCH 8/8] pci: pci_mvebu: Fix comment about driver class name

2021-10-22 Thread Pali Rohár
This is a pci driver, not an eth driver. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún --- drivers/pci/pci_mvebu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/pci_mvebu.c b/drivers/pci/pci_mvebu.c index b0c673d8c472..ed151a05a4bf 100644 ---

[PATCH 5/8] pci: pci_mvebu: Fix place of link up detection

2021-10-22 Thread Pali Rohár
PCI Bridge is always accessible also when link is down. So move detection of link up from mvebu_pcie_of_to_plat() function to mvebu_pcie_valid_addr() function which is used when accessing PCI config space. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún --- drivers/pci/pci_mvebu.c | 14

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-22 Thread Andre Przywara
On Fri, 22 Oct 2021 11:09:27 -0400 Tom Rini wrote: Hi, > On Fri, Oct 22, 2021 at 04:59:22PM +0200, Marek Behún wrote: > > On Fri, 22 Oct 2021 12:09:19 +0200 > > Heinrich Schuchardt wrote: > > > > > On 10/21/21 15:00, Marek Behún wrote: > > > > BTW, wouldn't it be enough to simply imply

Re: [PATCH 12/14] board: freescale: various boards: Let env subsystem set gd->env_addr

2021-10-22 Thread Simon Glass
On Fri, 22 Oct 2021 at 07:47, Marek Behún wrote: > > From: Marek Behún > > Various freescale boards set gd->env_addr to default_environment in > board_init(), conditional on CONFIG_ENV_IS_NOWHERE, but this is > redundant, since it is done by env_init() before board_init() is called. > > Let the

Re: [PATCH 04/14] env: nand: Put ENV_INVALID into gd->env_valid if default environment

2021-10-22 Thread Simon Glass
On Fri, 22 Oct 2021 at 07:47, Marek Behún wrote: > > From: Marek Behún > > env_nand_init() says the environment is valid even if it is assigning > default environment due to not being able to access nand pre-reloaction > (determined by macro values). Change this to ENV_INVALID and let the >

Re: [PATCH 11/14] board: synquacer: developerbox: Don't set gd->env_addr to default_environment

2021-10-22 Thread Simon Glass
On Fri, 22 Oct 2021 at 07:47, Marek Behún wrote: > > From: Marek Behún > > This board sets gd->env_addr to default_environment in board_init(), but > the board has environment in SPI flash according to defconfig. Let the > env API handle environment automatically. > > Signed-off-by: Marek Behún

Re: [PATCH 08/14] env: nowhere: Cosmetic fix

2021-10-22 Thread Simon Glass
On Fri, 22 Oct 2021 at 07:47, Marek Behún wrote: > > From: Marek Behún > > Use spaces instead of tabs in assignments, since there are no lines to > align assignment values to. > > Signed-off-by: Marek Behún > --- > env/nowhere.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH 10/14] env: flash: Cosmetic fix

2021-10-22 Thread Simon Glass
On Fri, 22 Oct 2021 at 07:47, Marek Behún wrote: > > From: Marek Behún > > Change tab to space in env_flash_init(). > > Signed-off-by: Marek Behún > --- > env/flash.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Simon Glass Feel free to do these code-style all in

[PATCH 1/2] efi_loader: add missing const qualifier

2021-10-22 Thread Masahisa Kojima
This commit fixes the following compilation warning of boottime->install_configuration_table() function. --- lib/efi_selftest/efi_selftest_tcg2.c:475:46: warning: passing argument 1 of ‘boottime->install_configuration_table’ discards ‘const’ qualifier from pointer target type

[PATCH 0/2] add selftest for EFI_TCG2_PROTOCOL and Measured Boot

2021-10-22 Thread Masahisa Kojima
This patch series adds the selftest for the EFI_TCG2_PROTOCOL and Measured Boot flow. This selftest is verified on qemu with swtpm. This covers most of the functionalities, but there are some limitations and TODO items. [Limitation] - tcg2 selftest must run at the beginning of the efi_selftest

Re: Commit 76c2ff3e broke backlight on Chromebook snow

2021-10-22 Thread Dario Binacchi
Hi Guillaume, > Il 21/10/2021 16:47 Guillaume GARDET ha scritto: > > > Hi, > > Commit 76c2ff3e [0] broke backlight on Chromebook snow. > A revert on top of 2021.10 restores the backlight. > Not sure why it breaks on Chromebook snow yet. Dario, any idea how to fix > this? Is it possible

Re: [PATCH v6 2/2] board: kontron: pitx-imx8m: Add Kontron pitx-imx8m board support

2021-10-22 Thread Stefano Babic
Hi Heiko, On 22.10.21 10:19, Heiko Thiery wrote: Hi Stefano, Hi Simon, Am Do., 21. Okt. 2021 um 15:57 Uhr schrieb Heiko Thiery : Hi Stefano, Hi Simon, Am Do., 21. Okt. 2021 um 15:29 Uhr schrieb Stefano Babic : On 21.10.21 15:17, Heiko Thiery wrote: Hi Stefano, Am Do., 21. Okt. 2021 um

Re: [PATCH 13/14] env: Always use char for default_environment

2021-10-22 Thread Simon Glass
On Fri, 22 Oct 2021 at 07:47, Marek Behún wrote: > > From: Marek Behún > > Sometimes we use uchar and sometimes char for the default environment > array. By always using char, we can get rid of some explicit casts. > > Signed-off-by: Marek Behún > --- > board/Marvell/mvebu_armada-37xx/board.c

Re: [PATCH 09/14] env: flash: Let generic env_init() assign default environment

2021-10-22 Thread Simon Glass
On Fri, 22 Oct 2021 at 07:47, Marek Behún wrote: > > From: Marek Behún > > env_flash_init() (both implementations) assigns default environment if > ENV_INVALID, but this is done in the generic env_init() function, which > calls this initializer, so drop it from here. > > Signed-off-by: Marek

Re: [PATCH 14/14] env: Use static_assert() to check if default_environment is too large

2021-10-22 Thread Simon Glass
On Fri, 22 Oct 2021 at 07:48, Marek Behún wrote: > > From: Marek Behún > > Check sizeof(default_environment) against ENV_SIZE in a static_assert() > instead of runtime. > Only check if !USE_HOSTCC (for in fw_env tool ENV_SIZE expands to a > variable, and cannot be checked statically) nad >

Re: [PATCH 07/14] env: nowhere: Let generic env_init() assign default environment

2021-10-22 Thread Simon Glass
On Fri, 22 Oct 2021 at 07:47, Marek Behún wrote: > > From: Marek Behún > > env_nowhere_init() assigns default environment if ENV_INVALID, but this > is done in the generic env_init() function, which calls this > initializer, so drop it from here. > > Signed-off-by: Marek Behún > --- >

Re: [PATCH v6 2/2] board: kontron: pitx-imx8m: Add Kontron pitx-imx8m board support

2021-10-22 Thread Heiko Thiery
Hi, Am Fr., 22. Okt. 2021 um 14:37 Uhr schrieb Stefano Babic : > > Hi Heiko, > > On 22.10.21 10:19, Heiko Thiery wrote: > > Hi Stefano, Hi Simon, > > > > Am Do., 21. Okt. 2021 um 15:57 Uhr schrieb Heiko Thiery > > : > >> > >> Hi Stefano, Hi Simon, > >> > >> > >> Am Do., 21. Okt. 2021 um 15:29 Uhr

[PATCH 07/14] env: nowhere: Let generic env_init() assign default environment

2021-10-22 Thread Marek Behún
From: Marek Behún env_nowhere_init() assigns default environment if ENV_INVALID, but this is done in the generic env_init() function, which calls this initializer, so drop it from here. Signed-off-by: Marek Behún --- env/nowhere.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 10/14] env: flash: Cosmetic fix

2021-10-22 Thread Marek Behún
From: Marek Behún Change tab to space in env_flash_init(). Signed-off-by: Marek Behún --- env/flash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/env/flash.c b/env/flash.c index 77d4c030a5..b928880502 100644 --- a/env/flash.c +++ b/env/flash.c @@ -229,7 +229,7 @@

[PATCH 11/14] board: synquacer: developerbox: Don't set gd->env_addr to default_environment

2021-10-22 Thread Marek Behún
From: Marek Behún This board sets gd->env_addr to default_environment in board_init(), but the board has environment in SPI flash according to defconfig. Let the env API handle environment automatically. Signed-off-by: Marek Behún Cc: Masami Hiramatsu ---

[PATCH 08/14] env: nowhere: Cosmetic fix

2021-10-22 Thread Marek Behún
From: Marek Behún Use spaces instead of tabs in assignments, since there are no lines to align assignment values to. Signed-off-by: Marek Behún --- env/nowhere.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/env/nowhere.c b/env/nowhere.c index dc93b6f2e4..9ebc357dbd

[PATCH 06/14] env: nvram: Cosmetic fix in env_nvram_init()

2021-10-22 Thread Marek Behún
From: Marek Behún Use spaces consistently in assignments instead of tabs. Signed-off-by: Marek Behún --- env/nvram.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/env/nvram.c b/env/nvram.c index 297573c4ed..fb265235af 100644 --- a/env/nvram.c +++ b/env/nvram.c @@

[PATCH 2/8] pci: pci_mvebu: Fix read_config() with PCI_SIZE_8 or PCI_SIZE_16

2021-10-22 Thread Pali Rohár
When reading 8 or 16 bits from config space, use appropriate readb() or readw() calls. This ensures that PCIe controller does not read more bits from endpoint card as asked by read_config() function. Technically there should not be an issue with reading data from config space which are not later

[PATCH 1/8] pci: pci_mvebu: Fix write_config() with PCI_SIZE_8 or PCI_SIZE_16

2021-10-22 Thread Pali Rohár
Current implementation of write_config() is broken for PCI_SIZE_8 or PCI_SIZE_16 as it always uses writel(), which means that write operation is always 32-bit, so upper 24 bits for PCI_SIZE_8 and upper 16 bits for PCI_SIZE_16 are cleared. Fix this by using writeb() and writew(), respectively.

[PATCH 02/14] env: sf: Use ENV_VALID enum names instead of literals

2021-10-22 Thread Marek Behún
From: Marek Behún The function env_sf_init_addr() assigns number literals (1) instead of ENV_VALID to gd->env_valid. Fix this. Signed-off-by: Marek Behún --- env/sf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/env/sf.c b/env/sf.c index 4096e18387..c251d076d7

[PATCH 00/14] Some more env fixes

2021-10-22 Thread Marek Behún
From: Marek Behún Hello Tom, Simon and others, here are some various fixes for env. More are to follow after this, the code is horrible and I want to implement something there. Marek Behún (14): env: sf: Cosmetic fix in env_sf_init_addr() env: sf: Use ENV_VALID enum names instead of

[PATCH 12/14] board: freescale: various boards: Let env subsystem set gd->env_addr

2021-10-22 Thread Marek Behún
From: Marek Behún Various freescale boards set gd->env_addr to default_environment in board_init(), conditional on CONFIG_ENV_IS_NOWHERE, but this is redundant, since it is done by env_init() before board_init() is called. Let the env subsystem handle this. Signed-off-by: Marek Behún Cc:

[PATCH 13/14] env: Always use char for default_environment

2021-10-22 Thread Marek Behún
From: Marek Behún Sometimes we use uchar and sometimes char for the default environment array. By always using char, we can get rid of some explicit casts. Signed-off-by: Marek Behún --- board/Marvell/mvebu_armada-37xx/board.c | 2 +- env/common.c| 6 +++---

Re: [PATCH v10 3/9] env: Allow U-Boot scripts to be placed in a .env file

2021-10-22 Thread Tom Rini
On Fri, Oct 22, 2021 at 10:29:26AM +0200, Wolfgang Denk wrote: > Dear Simon, > > In message > <20211021210847.v10.3.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> you > wrote: > > At present U-Boot environment variables, and thus scripts, are defined > > by CONFIG_EXTRA_ENV_SETTINGS. It is

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-22 Thread Tom Rini
On Fri, Oct 22, 2021 at 10:06:55AM +0200, Wolfgang Denk wrote: > Dear Simon, > > In message > you > wrote: > > > > > > i.e. > > > > var+=value > > > > appends value to var, while > > > > var\+=value > > > > sets variable with name "var+" > > > > My first preference is to disallow + at the

[PATCH] lib: uuid: fix the test on RNG device presence

2021-10-22 Thread Patrick Delaunay
Correct the test on RNG device presence,when ret is equal to 0, before to call dm_rng_read function. Without this patch the RNG device is not used when present (when ret == 0) or a data abort occurs in dm_rng_read when CONFIG_DM_RNG is activated but the RNG device is not present in device tree

Question: LTO and failing objcopy in "u-boot-initial-env" target

2021-10-22 Thread Patrick DELAUNAY
Hi, I made tests with LTO option activated on stm32mp15 boards but if have a issue with the U-Boot target  "u-boot-initial-env" (this command used by YOCTO) $> make u-boot-initial-env ... GENENV  u-boot-initial-env arm-none-linux-gnueabihf-objcopy: env/common.o: can't dump section

Re: [PATCH 05/14] env: nvram: Let generic env_init() assign default environment

2021-10-22 Thread Simon Glass
On Fri, 22 Oct 2021 at 07:47, Marek Behún wrote: > > From: Marek Behún > > env_nvram_init() assigns default environment if ENV_INVALID, but this is > done in the generic env_init() function, which calls this initializer, > so drop it from here. > > Signed-off-by: Marek Behún > --- >

Re: [PATCH 06/14] env: nvram: Cosmetic fix in env_nvram_init()

2021-10-22 Thread Simon Glass
On Fri, 22 Oct 2021 at 07:47, Marek Behún wrote: > > From: Marek Behún > > Use spaces consistently in assignments instead of tabs. > > Signed-off-by: Marek Behún > --- > env/nvram.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Simon Glass

Re: [PATCH 02/14] env: sf: Use ENV_VALID enum names instead of literals

2021-10-22 Thread Simon Glass
On Fri, 22 Oct 2021 at 07:47, Marek Behún wrote: > > From: Marek Behún > > The function env_sf_init_addr() assigns number literals (1) instead of > ENV_VALID to gd->env_valid. Fix this. > > Signed-off-by: Marek Behún > --- > env/sf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH 03/14] env: sf: Put ENV_INVALID into gd->env_valid on CRC failure

2021-10-22 Thread Simon Glass
On Fri, 22 Oct 2021 at 07:47, Marek Behún wrote: > > From: Marek Behún > > env_sf_init_addr() says the environment is valid even if it is assigning > default environment due to CRC failure. Change this to ENV_INVALID and > let the generic env_init() function, which calls this initializer, >

[PATCH 2/2] efi_selftest: add selftest for EFI_TCG2_PROTOCOL and Measured Boot

2021-10-22 Thread Masahisa Kojima
This commit adds the missing EFI_TCG2_PROTOCOL selftest and Measured Boot selftest in lib/efi_selftest. Signed-off-by: Masahisa Kojima --- lib/efi_selftest/Makefile | 10 + .../efi_selftest_miniapp_measuredboot.c | 93 ++ lib/efi_selftest/efi_selftest_tcg2.c

[PATCH v1 0/5] Update Microchip PolarFire SoC support

2021-10-22 Thread Padmarao Begari
This patch set updates Microchip PolarFire SoC Icicle Kit support of RISC-V U-Boot. The patches are based upon latest U-Boot tree (https://source.denx.de/u-boot/u-boot) at commit id f200a4bcecf1be6d8b546f0eb6af6403c93d80dd The device tree split into .dtsi and .dts files, UART1 uses for console

[PATCH 3/8] pci: pci_mvebu: Properly configure and use PCI Bridge (PCIe Root Port)

2021-10-22 Thread Pali Rohár
The mysterious "Memory controller" PCI device which is present in PCI config space is improperly configured and crippled PCI Bridge which acts as PCIe Root Port for endpoint PCIe card. This PCI Bridge reports in PCI config space incorrect Class Code (Memory Controller) and incorrect Header Type

[PATCH 0/8] pci: pci_mvebu: Fix access to config space and PCIe Root Port

2021-10-22 Thread Pali Rohár
This patch series fixes access to config space and fixes issues with the mysterious "Memory controller" PCI device (which is PCIe Root Port). Tested on Armada 385 Turris Omnia device which has 3 mPCIe slots. PCIe Root Port device is available for each slot on separate bus and has PCI Bridge class

[PATCH 4/8] pci: pci_mvebu: Remove unused functions

2021-10-22 Thread Pali Rohár
Functions mvebu_pcie_get_local_bus_nr() and mvebu_pcie_get_local_dev_nr() are not used, so remove them. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún --- drivers/pci/pci_mvebu.c | 16 1 file changed, 16 deletions(-) diff --git a/drivers/pci/pci_mvebu.c

[PATCH 7/8] pci: pci_mvebu: Setup PCI controller to Root Complex mode

2021-10-22 Thread Pali Rohár
Root Complex should be the default mode, let's set it explicitly. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún --- drivers/pci/pci_mvebu.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/pci/pci_mvebu.c b/drivers/pci/pci_mvebu.c index e43fa12d3819..b0c673d8c472 100644

[PATCH 6/8] pci: pci_mvebu: Do not automatically enable bus mastering on PCI Bridge

2021-10-22 Thread Pali Rohár
Now that PCI Bridge is working, U-Boot's CONFIG_PCI_PNP code automatically enables memory access and bus mastering when it is needed. So do not prematurely enable memory access and bus mastering. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún --- drivers/pci/pci_mvebu.c | 8 1

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-22 Thread Tom Rini
On Fri, Oct 22, 2021 at 10:08:05AM +0200, Wolfgang Denk wrote: > Dear Tom, > > In message <20211021160311.GC3577824@bill-the-cat> you wrote: > > > > How bad does it make the parser look if we allow trailing + in variable > > names, by escaping them? It's seemingly the substantive objection at >

[PATCH] cmd: pxe_utils: sysboot: add label override support

2021-10-22 Thread Amjad Ouled-Ameur
This will allow consumers to choose a pxe label at runtime instead of having to prompt the user. One good use-case for this, is choosing whether or not to apply a dtbo depending on the hardware configuration. e.g: for TI's AM335x EVM, it would be convenient to apply a particular dtbo only when the

Re: [PATCH 6/6] scripts: remove CONFIG_IS_ENABLED in config_whitelist.txt

2021-10-22 Thread Patrick DELAUNAY
Hi Simon On 10/14/21 5:09 PM, Simon Glass wrote: Hi Patrick, On Mon, 4 Oct 2021 at 04:00, Patrick Delaunay wrote: Redefine the macro CONFIG_IS_ENABLED is not allowed, so this entry can be removed in whitelist file. Signed-off-by: Patrick Delaunay --- scripts/config_whitelist.txt | 1 -

  1   2   >