Re: [PATCH] netconsole: various improvements

2023-03-20 Thread Pali Rohár
On Sunday 19 March 2023 16:25:25 Tony Dinh wrote: > Hi Pali, > > On Sun, Mar 19, 2023 at 12:36 PM Pali Rohár wrote: > > > > On Saturday 18 March 2023 14:46:25 Tony Dinh wrote: > > > - When Netconsole is running, stdin/stdout/stderr are set to nc. Reset > > > stdin/stdout/stderr to serial (a sane

Re: [PATCH 3/4] phy: Add .set_mode and .set_speed callbacks

2023-03-20 Thread Patrice CHOTARD
Hi Marek On 3/19/23 18:09, Marek Vasut wrote: > Add two new callbacks matching the Linux ones. The .set_mode is used to set > PHY mode and submode, where mode is either USB, Ethernet, and so on, while > submode is e.g. for Ethernet case RGMII, RMII, and so on. The .set_speed is > used to

Re: [PATCH RFC u-boot-mvebu 0/2] arm: mvebu: Fix eMMC boot

2023-03-20 Thread Martin Rowe
On Sun, 19 Mar 2023 at 16:22, Pali Rohár wrote: > On Sunday 19 March 2023 00:32:01 Martin Rowe wrote: > > On Mon, 6 Mar 2023 at 11:53, Pali Rohár wrote: > > > > > Could you try to print mmc->part_config (ideally as early as possible)? > > > > > > > In SPL mmc->part_config is 255 > > In main

Re: [PATCH 1/2] efi_loader: move dp_alloc() to efi_alloc()

2023-03-20 Thread Ilias Apalodimas
On Mon, Mar 20, 2023 at 10:15:21AM +0100, Heinrich Schuchardt wrote: > On 3/20/23 08:38, Ilias Apalodimas wrote: > > Hi Heinrich, > > > > On Sun, Mar 19, 2023 at 09:20:22AM +0100, Heinrich Schuchardt wrote: > > > The incumbent function efi_alloc() is unused. > > > > > > Replace dp_alloc() by a new

RE: [EXT] [PATCH] image-fit: aligned output of hash calculation

2023-03-20 Thread Gaurav Jain
Hi > -Original Message- > From: Christoph Fritz > Sent: Monday, March 20, 2023 1:19 PM > To: u-boot > Cc: Gaurav Jain ; Meenakshi Aggarwal > > Subject: [EXT] [PATCH] image-fit: aligned output of hash calculation > > Caution: EXT Email > > When calculating the hash of a FIT image, the

[PATCH] include: configs: am62ax: Change to using .env

2023-03-20 Thread Nikhil M Jain
Move to using .env file for setting up environment variables for am62ax. This patch depends on https://lore.kernel.org/all/20230315052745.110502-1-n-fran...@ti.com/ Signed-off-by: Nikhil M Jain --- board/ti/am62ax/am62ax.env | 33 +

Re: [PATCH 2/2] efi_loader: fix device-path for USB devices

2023-03-20 Thread Simon Glass
Hi Heinrich, On Mon, 20 Mar 2023 at 09:58, Heinrich Schuchardt wrote: > > > > On 3/19/23 20:29, Simon Glass wrote: > > Hi Heinrich, > > > > On Mon, 20 Mar 2023 at 04:25, Heinrich Schuchardt > > wrote: > >> > >> EFI device paths for block devices must be unique. If a non-unique device > >> path

[PATCH] net: rswitch: Add Renesas Ethernet Switch

2023-03-20 Thread Marek Vasut
From: Phong Hoang This patch adds Ethernet Switch support that found on R-Car S4 (r8a779f0) SoC. This is extracted from multiple patches from downstream BSP, with additional rework of the network device registration. Signed-off-by: Hai Pham Signed-off-by: Marek Vasut Signed-off-by: Phong

[PATCH] net: phy: gmii2rgmii: Support external rgmii-id phy

2023-03-20 Thread Stefan Herbrechtsmeier
From: Stefan Herbrechtsmeier Read the phy mode of the external phy from the device tree if available. Signed-off-by: Stefan Herbrechtsmeier --- drivers/net/phy/xilinx_gmii2rgmii.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/xilinx_gmii2rgmii.c

[PATCH v4 0/1] CMD commands improvements

2023-03-20 Thread Svyatoslav Ryhel
- add ability for 'ums' command to interrupt run of usb mass storage with any key. This is especially useful on devices with limited input capabilities like tablets and smatphones which have only gpio keys in direct access. Current implementation uses Kconfig entry. Changelog from v3 - re-send

[PATCH v4 1/1] cmd: ums: abort mounting by pressing any key

2023-03-20 Thread Svyatoslav Ryhel
This patch introduses config which allows interrupt run of usb mass storage with any key. This is especially useful on devices with limited input capabilities like tablets and smatphones which have only gpio keys in direct access. Signed-off-by: Svyatoslav Ryhel --- cmd/Kconfig| 6

Re: kwboot: Marvell Dove UART booting

2023-03-20 Thread Pali Rohár
Hello! After longer time I have something new in this area. On Wednesday 16 February 2022 20:18:31 Tony Dinh wrote: > Hi Pali, > > Please see below. > > On Tue, Feb 15, 2022 at 3:02 PM Pali Rohár wrote: > > > > Hello! > > > > On Wednesday 22 December 2021 20:08:56 Tony Dinh wrote: > > > ***

Re: kwboot: Marvell Dove UART booting

2023-03-20 Thread Tony Dinh
Hi Pali, On Mon, Mar 20, 2023 at 1:33 PM Pali Rohár wrote: > > Hello! After longer time I have something new in this area. > > On Wednesday 16 February 2022 20:18:31 Tony Dinh wrote: > > Hi Pali, > > > > Please see below. > > > > On Tue, Feb 15, 2022 at 3:02 PM Pali Rohár wrote: > > > > > >

Re: [PATCH RFC u-boot-mvebu 0/6] arm: mvebu: Fix boot mode detection

2023-03-20 Thread Pali Rohár
On Monday 20 March 2023 18:45:01 Pali Rohár wrote: > On Monday 20 March 2023 12:01:03 Martin Rowe wrote: > > On Sun, 19 Mar 2023 at 18:20, Pali Rohár wrote: > > > > > On Sunday 19 March 2023 17:47:57 Pali Rohár wrote: > > > > On Sunday 19 March 2023 03:30:33 Martin Rowe wrote: > > > > > On Sun,

[PATCH v2 0/2] rockchip: fix efuse/otp misc_read return values

2023-03-20 Thread John Keeping
Fix the return value for misc_read() in the two Rockchip nvmem drivers so that they return the number of bytes read. In v2 the rockchip-efuse patch is change to correctly handle block_size > 1 and the rockchip-otp patch is new. John Keeping (2): rockchip: efuse: fix misc_read() return values

[PATCH v2 1/2] rockchip: efuse: fix misc_read() return values

2023-03-20 Thread John Keeping
The documentation for misc_read() says: Return: number of bytes read if OK (may be 0 if EOF), -ve on error The Rockchip efuse driver implements this so it should return the number of bytes read rather than zero on success. Fix this so that the driver follows the usual contract for read

[PATCH v2 2/2] rockchip: otp: fix misc_read() return values

2023-03-20 Thread John Keeping
The documentation for misc_read() says: Return: number of bytes read if OK (may be 0 if EOF), -ve on error The Rockchip efuse driver implements this so it should return the number of bytes read rather than zero on success. Fix this so that the driver follows the usual contract for read

Re: [PATCH v2 4/4] test: exit: fix run_commandf() warnings

2023-03-20 Thread Simon Glass
On Mon, 20 Mar 2023 at 21:23, Evgeny Bachinin wrote: > > Fix warnings after adding printf-like attribute format for > run_commandf(): > warning: too many arguments for format [-Wformat-extra-args] > > Signed-off-by: Evgeny Bachinin > Reviewed-by: Simon Glass > --- > test/cmd/exit.c | 18

Re: [PATCH] image-fit: aligned output of hash calculation

2023-03-20 Thread Simon Glass
Hi Christopher, On Mon, 20 Mar 2023 at 20:49, Christoph Fritz wrote: > > When calculating the hash of a FIT image, the result is being stored in > an unaligned memory location. This causes problems (wrong hash) with the > fsl_hash CAAM engine on i.mx7ulp. > > To fix the issue, this patch

Re: [PATCH 29/33] doc: boards: amlogic: update documentation for WeTek Core2

2023-03-20 Thread Simon Glass
Hi Christian, On Tue, 21 Mar 2023 at 06:05, Christian Hewitt wrote: > > Improve documentation. > > Signed-off-by: Christian Hewitt > --- > doc/board/amlogic/wetek-core2.rst | 83 +-- > 1 file changed, 47 insertions(+), 36 deletions(-) This should really move to

Re: [PATCH v2 2/4] unit-test: cover run_commandf() by test-cases

2023-03-20 Thread Simon Glass
On Mon, 20 Mar 2023 at 21:23, Evgeny Bachinin wrote: > > As run_commandf() is variadic version of run_command() and just a wrapper, > hence apply similar run_command's test-cases. > > Let's avoid warning about empty string passing: > warning: zero-length gnu_printf format string

Re: [PATCH v4 16/17] riscv: dts: jh7110: Add initial StarFive VisionFive v2 board device tree

2023-03-20 Thread Conor Dooley
On Thu, Mar 16, 2023 at 10:53:31AM +0800, Yanhong Wang wrote: > Add initial device tree for StarFive VisionFive v2 board. > > Signed-off-by: Yanhong Wang > Tested-by: Conor Dooley btw, are you running some sort of cc suppression argument to send-email? There's not much reason to do so for

[PATCH] efi_loader: define allow_unaligned as 'asm volatile'

2023-03-20 Thread Ilias Apalodimas
Tom reports that compiling with LTO & EFI breaks armv7 and arm11* builds. The reason is that LTO (maybe a binutils bug?) replaces the asm version of allow_unaligned() with the __weak definition of the function. As a result EFI code ends up running with unaligned accesses disabled and eventually

Re: [PATCH] fs: fat: do not mangle short filenames

2023-03-20 Thread Tom Rini
On Fri, Mar 17, 2023 at 01:04:13PM +0100, Stefan Herbrechtsmeier wrote: > From: Stefan Herbrechtsmeier > > Do not mangle lower or mixed case filenames which fit into the upper > case 8.3 short filename. This ensures FAT standard compatible short > filenames (SFN) to support systems without long

Re: [PATCH] fs: ext4: fix files seen as symlink during deletion

2023-03-20 Thread Tom Rini
On Fri, Mar 17, 2023 at 01:15:12PM +0100, Corentin GUILLEVIC wrote: > The deletion process handles special case for symlinks whose target are > small enough that it fits in struct ext2_inode.b.symlink. So no block had > been allocated. But the check of file type wrongly considered regular > files

Re: [PATCH RFC u-boot-mvebu 0/6] arm: mvebu: Fix boot mode detection

2023-03-20 Thread Pali Rohár
On Monday 20 March 2023 12:01:03 Martin Rowe wrote: > On Sun, 19 Mar 2023 at 18:20, Pali Rohár wrote: > > > On Sunday 19 March 2023 17:47:57 Pali Rohár wrote: > > > On Sunday 19 March 2023 03:30:33 Martin Rowe wrote: > > > > On Sun, 5 Mar 2023 at 11:55, Pali Rohár wrote: > > > > > > > > > On

[PATCH] rockchip: efuse: fix misc_read() return values

2023-03-20 Thread John Keeping
The documentation for misc_read() says: Return: number of bytes read if OK (may be 0 if EOF), -ve on error The Rockchip efuse driver implements this so it should return the number of bytes read rather than zero on success. Fix this so that the driver follows the usual contract for read

[PATCH] ARM: renesas: Enable rswitch, serdes and PHY driver on R8A779F0 S4 Spider

2023-03-20 Thread Marek Vasut
Enable Renesas RSwitch driver, matching SERDES PHY driver and Marvell 10G ethernet PHY driver in R8A779F0 S4 Spider board configuration to make ethernet available via the RSwitch ports. Signed-off-by: Marek Vasut --- Cc: Hai Pham Cc: Joe Hershberger Cc: Marek Vasut Cc: Peng Fan Cc: Ramon

Re: [PATCH] netconsole: various improvements

2023-03-20 Thread Tony Dinh
Hi Pali, On Mon, Mar 20, 2023 at 1:00 AM Pali Rohár wrote: > > On Sunday 19 March 2023 16:25:25 Tony Dinh wrote: > > Hi Pali, > > > > On Sun, Mar 19, 2023 at 12:36 PM Pali Rohár wrote: > > > > > > On Saturday 18 March 2023 14:46:25 Tony Dinh wrote: > > > > - When Netconsole is running,

[PATCH] travis-ci: Add m68k M5208EVBE machine

2023-03-20 Thread Marek Vasut
Add m68k M5208EVBE machine configured to test U-Boot m68k support. Signed-off-by: Marek Vasut --- Cc: Angelo Dureghello Cc: Stephen Warren Cc: Tom Rini --- bin/travis-ci/conf.M5208EVBE_qemu | 27 +++ .../u_boot_boardenv_M5208EVBE_qemu.py | 6 + 2

Re: kwboot: Marvell Dove UART booting

2023-03-20 Thread Pali Rohár
On Monday 20 March 2023 13:48:35 Tony Dinh wrote: > Hi Pali, > > On Mon, Mar 20, 2023 at 1:33 PM Pali Rohár wrote: > > > > Hello! After longer time I have something new in this area. > > > > On Wednesday 16 February 2022 20:18:31 Tony Dinh wrote: > > > Hi Pali, > > > > > > Please see below. > >

Re: [PATCH] rockchip: efuse: fix misc_read() return values

2023-03-20 Thread Jonas Karlman
Hi John, On 2023-03-20 17:38, John Keeping wrote: > The documentation for misc_read() says: > > Return: number of bytes read if OK (may be 0 if EOF), -ve on error > > The Rockchip efuse driver implements this so it should return the number > of bytes read rather than zero on success. Fix

[PATCH] board: ti: am62x: am62x: Include K3 common .env files

2023-03-20 Thread Nikhil M Jain
Include ti_armv7_common.env and ti/mmc.env, which includes' K3 common environment variables used across different K3 boards. This patch depends on https://lore.kernel.org/all/20230315052745.110502-1-n-fran...@ti.com/ Signed-off-by: Nikhil M Jain --- board/ti/am62x/am62x.env | 74

Re: [PATCH v2 1/4] cli: run_commandf(): small fixups

2023-03-20 Thread Simon Glass
On Mon, 20 Mar 2023 at 21:23, Evgeny Bachinin wrote: > > * vsnprintf() can truncate cmd, hence it makes no sense to launch such > command (it's broken). Moreover, it's better to signalize to the caller > about such case (for facilitating debugging or bug hunting). > > * Fix kernel-doc warnings: >

Re: [PATCH v2 2/2] rockchip: otp: fix misc_read() return values

2023-03-20 Thread Simon Glass
On Tue, 21 Mar 2023 at 06:18, John Keeping wrote: > > The documentation for misc_read() says: > > Return: number of bytes read if OK (may be 0 if EOF), -ve on error > > The Rockchip efuse driver implements this so it should return the number > of bytes read rather than zero on success. Fix

Re: [PATCH v2 1/2] rockchip: efuse: fix misc_read() return values

2023-03-20 Thread Simon Glass
On Tue, 21 Mar 2023 at 06:18, John Keeping wrote: > > The documentation for misc_read() says: > > Return: number of bytes read if OK (may be 0 if EOF), -ve on error > > The Rockchip efuse driver implements this so it should return the number > of bytes read rather than zero on success. Fix

Re: [PATCH v2 3/4] test: fdt: fix run_commandf() warnings

2023-03-20 Thread Simon Glass
On Mon, 20 Mar 2023 at 21:23, Evgeny Bachinin wrote: > > Fix warnings both for 32bit and 64bit architecture after adding > printf-like attribute format for run_commandf(): > warning: format ‘%x’ expects argument of type ‘unsigned int’, but > argument 2 has type ‘ulong {aka long unsigned int}’

Re: [PATCH 03/13] input: Only reset the keyboard when running bare metal

2023-03-20 Thread Simon Glass
Hi Bin, On Mon, 20 Mar 2023 at 19:32, Bin Meng wrote: > > Hi Simon, > > On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > > > If U-Boot is not the first-stage bootloader we should not init the > > keyboard, since it has already been done. Check for this. > > But re-init does no harm,

Re: [PATCH RFC u-boot-mvebu 0/6] arm: mvebu: Fix boot mode detection

2023-03-20 Thread Pali Rohár
On Monday 20 March 2023 12:01:03 Martin Rowe wrote: > Dedicated UART still works, patching an MMC for UART with kwboot still > hangs after finishing transfer; no change. One more question. Did you set boot mode HW switches to UART position? Or are they in MMC position and magic boot pattern from

Re: [PATCH RFC u-boot-mvebu 0/2] arm: mvebu: Fix eMMC boot

2023-03-20 Thread Pali Rohár
On Monday 20 March 2023 11:48:59 Martin Rowe wrote: > On Sun, 19 Mar 2023 at 16:22, Pali Rohár wrote: > > > On Sunday 19 March 2023 00:32:01 Martin Rowe wrote: > > > On Mon, 6 Mar 2023 at 11:53, Pali Rohár wrote: > > > > > > > Could you try to print mmc->part_config (ideally as early as

[PATCH v2 1/1] input: button_kbd: make driver complementary to gpio buttons

2023-03-20 Thread Svyatoslav Ryhel
Remove need of dts binding for button keyboard since it reuses gpio-keys binding. Select gpio-keys driver if button keyboard is selected since button keyboard can not operate on its own. Tested-by: Svyatoslav Ryhel # HTC One X T30 Signed-off-by: Svyatoslav Ryhel Reviewed-by: Simon Glass ---

[PATCH v2 0/1] GPIO buttons keyboard driver update

2023-03-20 Thread Svyatoslav Ryhel
Remove need of dts binding for button keyboard since it reuses gpio-keys binding. Select gpio-keys driver if button keyboard is selected since button keyboard can not operate on its own. Changes from v1: - add reviewed-by - re-send after month Svyatoslav Ryhel (1): input: button_kbd: make

Re: [PATCH v2] gpio: rockchip: Add support for RK3568 and RK3588 banks

2023-03-20 Thread Kever Yang
On 2023/3/20 02:39, Jonas Karlman wrote: The GPIO V2 controller on RK3568 and RK3588 works very similar to prior generation, main difference is the use of a write mask in the upper 16 bits and register address offset have changed. GPIO_VER_ID is a new register at 0x0078 that is used to

Re: [PATCH 1/3] clk: scmi: Add Kconfig option for SPL

2023-03-20 Thread Kever Yang
On 2023/3/18 03:16, Jonas Karlman wrote: Building U-Boot SPL with CLK_SCMI and SCMI_FIRMWARE Kconfig options enabled and SPL_FIRMWARE disabled result in the following error. drivers/clk/clk_scmi.o: in function `scmi_clk_gate': drivers/clk/clk_scmi.c:84: undefined reference to

Re: [PATCH v4] pinctrl: rockchip: support rk3588 pinctrl

2023-03-20 Thread Kever Yang
On 2023/3/15 23:32, Eugen Hristev wrote: From: Jianqun Xu Add support for Rockchip rk3588 variant of pinctrl. The driver is adapted from the Linux driver. Signed-off-by: Jianqun Xu [eugen.hris...@collabora.com: port to latest U-boot, bring more changes from Linux use translated pull

Re: [PATCH v2 5/7] arm: dts: rockchip: rk3288: partial sync vop/lvds/mipi/hdmi nodes

2023-03-20 Thread Kever Yang
On 2023/3/16 02:34, Johan Jonker wrote: In order to better compare the Linux rk3288.dtsi version 6.3 -rc2 with the U-Boot version partial sync the vop/lvds/mipi/hdmi nodes. Signed-off-by: Johan Jonker Reviewed-by: Simon Glass Tested-by: Simon Glass # chromebook-jerry Reviewed-by: Kever

Re: [PATCH v2 4/7] arm: dts: rockchip: rk3288: partial sync edp node

2023-03-20 Thread Kever Yang
On 2023/3/16 02:33, Johan Jonker wrote: The rk3288 edp node has a phy node in Linux with a clock property while current U-Boot driver expects this clock on position index 1. Move U-Boot-specific DT clock properties to rk3288-u-boot.dtsi and partially sync the edp node. Signed-off-by: Johan

Re: [PATCH v2 7/7] arm: dts: rockchip: rk3288: partial sync pwm nodes

2023-03-20 Thread Kever Yang
On 2023/3/16 02:34, Johan Jonker wrote: In order to better compare the Linux rk3288.dtsi version 6.3 -rc2 with the U-Boot version partial sync the pwm nodes. Signed-off-by: Johan Jonker Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3288.dtsi | 18 +- 1

Re: [PATCH v2 6/7] clk: rockchip: clk_rk3288: add PCLK_RKPWM

2023-03-20 Thread Kever Yang
On 2023/3/16 02:34, Johan Jonker wrote: The rk3288 pwm nodes synced from Linux make use of PCLK_RKPWM instead of PCLK_PWM. They have the same pclk_cpu parent, so add PCLK_RKPWM to rk3288_clk_get_rate(). Signed-off-by: Johan Jonker Reviewed-by: Simon Glass Tested-by: Simon Glass #

Re: [PATCH 03/13] input: Only reset the keyboard when running bare metal

2023-03-20 Thread Bin Meng
Hi Simon, On Tue, Mar 21, 2023 at 2:40 AM Simon Glass wrote: > > Hi Bin, > > On Mon, 20 Mar 2023 at 19:32, Bin Meng wrote: > > > > Hi Simon, > > > > On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > > > > > If U-Boot is not the first-stage bootloader we should not init the > > > keyboard,

Re: [PATCH v2 4/6] arm: dts: rockchip: sync rk3066/rk3188 DT files from linux-next v6.2-rc4

2023-03-20 Thread Kever Yang
On 2023/3/19 23:05, Johan Jonker wrote: Sync rk3066/rk3188 DT files from Linux. This is the state as of linux-next v6.2-rc4. New nfc node for MK808 rk3066a. CRU nodes now have a clock property. To prefend dtoc errors a fixed clock must also be included for tpl/spl in the rk3xxx-u-boot.dtsi

Re: [PATCH v2 5/6] rockchip: configs: mk808: change CONFIG_TPL_TEXT_BASE

2023-03-20 Thread Kever Yang
On 2023/3/19 23:06, Johan Jonker wrote: Currently the Rockchip rk3066a u-boot-tpl.bin file needs to add the characters "RK30", while the other SoCs replace the first 4 bytes. Bring this in line with the rest by lowering CONFIG_TPL_TEXT_BASE and update rockchip.rst instructions. Signed-off-by:

Re: [PATCH v2 2/6] arm: dts: rockchip: rk3066a-u-boot: add gpio-ranges

2023-03-20 Thread Kever Yang
On 2023/3/19 23:05, Johan Jonker wrote: The gpio node names are made generic, but without gpio bank ID. Add gpio-ranges to rk3066a-u-boot.dtsi for now till a better method is found. Disable gpio6 as the driver gives an error code on return as status. Signed-off-by: Johan Jonker Reviewed-by:

Re: [PATCH v2 6/6] rockchip: configs: mk808: enable usb support

2023-03-20 Thread Kever Yang
On 2023/3/19 23:06, Johan Jonker wrote: Enable usb support in the mk808_defconfig. Signed-off-by: Johan Jonker Reviewed-by: Simon Glass Reviewed-by: Kever Yang Thanks, - Kever --- configs/mk808_defconfig | 10 ++ 1 file changed, 10 insertions(+) diff --git

Re: [PATCH v2 1/6] rockchip: gpio: rk_gpio: use ROCKCHIP_GPIOS_PER_BANK as divider

2023-03-20 Thread Kever Yang
On 2023/3/19 23:02, Johan Jonker wrote: The current divider to calculate the bank ID can change. Given the Rockchip TRM not all gpio-banks have 32 pins per bank. The "gpio-ranges" syntax allows multiple items with variable number of pins. Use a constant ROCKCHIP_GPIOS_PER_BANK as fixed

Re: [PATCH v2 3/6] arm: dts: rockchip: rk3188-u-boot: add gpio-ranges

2023-03-20 Thread Kever Yang
On 2023/3/19 23:05, Johan Jonker wrote: The gpio node names are made generic, but without gpio bank ID. Add gpio-ranges to rk3188-u-boot.dtsi for now till a better method is found. Signed-off-by: Johan Jonker Reviewed-by: Simon Glass Reviewed-by: Kever Yang Thanks, - Kever ---

Re: [PATCH v2 2/7] arm: dts: rockchip: rk3288: partial sync grf and pmu nodes

2023-03-20 Thread Kever Yang
On 2023/3/16 02:33, Johan Jonker wrote: In order to better compare the Linux rk3288.dtsi version 6.3 -rc2 with the U-Boot version partial sync the grf and pmu nodes. Signed-off-by: Johan Jonker Reviewed-by: Simon Glass Tested-by: Simon Glass # chromebook-jerry Reviewed-by: Kever Yang

Re: [PATCH v2 1/7] arm: dts: rockchip: rk3288: move io-domains nodes

2023-03-20 Thread Kever Yang
On 2023/3/16 02:31, Johan Jonker wrote: In order to better compare the Linux rk3288.dtsi version with the U-Boot version move the io-domains nodes. Signed-off-by: Johan Jonker Reviewed-by: John Keeping Reviewed-by: Simon Glass Tested-by: Simon Glass # chromebook-jerry Reviewed-by: Kever

Re: [PATCH v2 3/7] video: rockchip: rk_vop: add rk3288-dp compare string

2023-03-20 Thread Kever Yang
On 2023/3/16 02:33, Johan Jonker wrote: In the current rk3288.dtsi file the compatible string for the DisplayPort(DP) node ends with "edp". The string in the binding ends with "dp" which conflicts with "cdn-dp" as a search term. Add "rk3288-dp" as compare string to select vop_id.

Re: [PATCH] board: ti: am62x: am62x: Include K3 common .env files

2023-03-20 Thread Tom Rini
rn Mon, Mar 20, 2023 at 10:53:56PM +0530, Nikhil M Jain wrote: > Include ti_armv7_common.env and ti/mmc.env, which includes' K3 common > environment variables used across different K3 boards. > > This patch depends on > https://lore.kernel.org/all/20230315052745.110502-1-n-fran...@ti.com/ > >

Re: [PATCH] travis-ci: Add m68k M5208EVBE machine

2023-03-20 Thread Tom Rini
On Mon, Mar 20, 2023 at 08:46:47PM +0100, Marek Vasut wrote: > Add m68k M5208EVBE machine configured to test U-Boot m68k support. > > Signed-off-by: Marek Vasut Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

Re: [PATCH v3 1/5] cmd: read: use part_get_info_by_dev_and_name_or_num() instead of open-coded dev_part parsing

2023-03-20 Thread Tom Rini
On Thu, Mar 02, 2023 at 09:12:21AM +0100, Rasmus Villemoes wrote: > Use the helper part_get_info_by_dev_and_name_or_num() for parsing a > dev[:part] string and obtaining the partition info in one go, instead > of open-coding all that. > > As a bonus, this will automatically allow using the

Re: [PATCH] configs: am62ax: enable secure device configs by default

2023-03-20 Thread Tom Rini
On Fri, Mar 17, 2023 at 06:37:11PM -0500, Bryan Brattlof wrote: > TI's security enforcing SoCs will authenticate each binary it loads by > comparing it's signature with keys etched into the SoC during the boot > up process. The am62ax family of SoCs by default will have some level of > security

Re: [PATCH] include: configs: am62ax: Change to using .env

2023-03-20 Thread Tom Rini
On Mon, Mar 20, 2023 at 10:32:08PM +0530, Nikhil M Jain wrote: > Move to using .env file for setting up environment variables for am62ax. > > This patch depends on > https://lore.kernel.org/all/20230315052745.110502-1-n-fran...@ti.com/ > > Signed-off-by: Nikhil M Jain Reviewed-by: Tom Rini

Re: [PATCH v4 17/17] configs: starfive: add starfive_visionfive2_defconfig

2023-03-20 Thread yanhong wang
On 2023/3/20 22:28, Andreas Schwab wrote: > On Mär 16 2023, Yanhong Wang wrote: > >> This is the initial basic config for StarFive VisionFive v2 board. It >> includes consol, Norflash, sdio, ddr etc. > > Are you also planning to add a config for the 1.2a version? > Except for

Re: [PATCH 0/3] rockchip: gpio: Add support for RK3568 and RK3588

2023-03-20 Thread Kever Yang
Hi Jonas, On 2023/3/19 07:56, Jonas Karlman wrote: This series adds support for RK3568 and RK3588 in the rk gpio driver. It also reverts the use of gpio-ranges to set gpio bank id and instead add gpio aliases and instead use the alias sequence as the bank id. There is another patch set from

Re: [PATCH 2/2] configs: rockchip: rock5b-rk3588: add pinctrl to SPL

2023-03-20 Thread Kever Yang
On 2023/3/13 20:53, Eugen Hristev wrote: Add pinctrl driver in SPL. Do not remove pinctrl properties for SPL dtb. Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- configs/rock5b-rk3588_defconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

Re: [PATCH 1/2] ARM: dts: rk3588-rock-5b-u-boot: add u-boot, dm-spl to pinctrl for sdmmc

2023-03-20 Thread Kever Yang
On 2023/3/13 20:53, Eugen Hristev wrote: To be able to initialize the pinctrl correctly at SPL level and read u-boot proper from SD-Card, the pinctrl must be initialized. Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3588-rock-5b-u-boot.dtsi |

[PULL] u-boot-sh/master

2023-03-20 Thread Marek Vasut
A single reset controller driver (part of the clock driver) fix for v2023.04 release. The following changes since commit 318af47668aa2347ca9bbf2114cb9af1d8739aca: Merge branch 'master' of https://source.denx.de/u-boot/custodians/u-boot-coldfire (2023-03-15 12:03:17 -0400) are available in

Re: [PATCH 2/3] rockchip: rk3588: Add support for sdmmc clocks in SPL

2023-03-20 Thread Kever Yang
On 2023/3/18 03:16, Jonas Karlman wrote: Booting from sdmmc on RK3588 currently works because of a workaround in the device tree, clocks are reordered so that the driver use ciu-sample instead of ciu, and the BootRom initializes sdmmc clocks before SPL is loaded into DRAM. The sdmmc clocks

Re: [PATCH 3/3] rockchip: rk3588: Sync sdmmc node from linux-next

2023-03-20 Thread Kever Yang
On 2023/3/18 03:16, Jonas Karlman wrote: Sync the sdmmc node from linux-next, include required nodes in SPL and imply Kconfig options required for functional sdmmc clk in SPL and U-Boot proper. This make it possible for both SPL and U-Boot proper to configure sdmmc clocks. In SPL, before TF-A

[PATCH 2/3] boards: tqma6: enable DM for MDIO / PHY

2023-03-20 Thread Markus Niebel
Since this works with current device trees, enabled these. Signed-off-by: Markus Niebel --- configs/tqma6dl_mba6_mmc_defconfig | 3 +++ configs/tqma6dl_mba6_spi_defconfig | 3 +++ configs/tqma6q_mba6_mmc_defconfig | 3 +++ configs/tqma6q_mba6_spi_defconfig | 3 +++

[PATCH 3/3] boards: tqma6: enable DM_THERMAL

2023-03-20 Thread Markus Niebel
Enabling this gives some informal output at boot time. Signed-off-by: Markus Niebel --- configs/tqma6dl_mba6_mmc_defconfig | 2 ++ configs/tqma6dl_mba6_spi_defconfig | 2 ++ configs/tqma6q_mba6_mmc_defconfig | 2 ++ configs/tqma6q_mba6_spi_defconfig | 2 ++ configs/tqma6s_mba6_mmc_defconfig

[PATCH 1/3] boards: tqma6: switch to DM_SERIAL

2023-03-20 Thread Markus Niebel
Usage without DM_SERIAL is deprecated. Fix this. Signed-off-by: Markus Niebel --- configs/tqma6dl_mba6_mmc_defconfig | 2 +- configs/tqma6dl_mba6_spi_defconfig | 2 +- configs/tqma6q_mba6_mmc_defconfig | 2 +- configs/tqma6q_mba6_spi_defconfig | 2 +- configs/tqma6s_mba6_mmc_defconfig | 2 +-

[PATCH 0/3] boards: tqma6: defconfig updates

2023-03-20 Thread Markus Niebel
Update defconfigs for TQMa6x family of boards. Primary goal is to do the overdue switch to DM_SERIAL. While at it, use also DM for MDIO / PHY and enable DM_THERMAL. Markus Niebel (3): boards: tqma6: switch to DM_SERIAL boards: tqma6: enable DM for MDIO / PHY boards: tqma6: enable DM_THERMAL

Re: [PATCH 03/13] input: Only reset the keyboard when running bare metal

2023-03-20 Thread Bin Meng
Hi Simon, On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > If U-Boot is not the first-stage bootloader we should not init the > keyboard, since it has already been done. Check for this. But re-init does no harm, right? > > Signed-off-by: Simon Glass > --- > > drivers/input/i8042.c | 13

Re: [PATCH v2] disk: Use a helper function to reduce duplication

2023-03-20 Thread Ilias Apalodimas
Hi Simon, Patch looks good, but isn't the new function name a bit misleading? Something like blk_part_find_start() sounds a bit more descriptive, or am I missing something? Cheers /Ilias On Mon, Mar 20, 2023 at 08:29:57AM +1300, Simon Glass wrote: > Reduce the duplicated code slightly by using

[PATCH] image-fit: aligned output of hash calculation

2023-03-20 Thread Christoph Fritz
When calculating the hash of a FIT image, the result is being stored in an unaligned memory location. This causes problems (wrong hash) with the fsl_hash CAAM engine on i.mx7ulp. To fix the issue, this patch introduces a use of memalign() to allocate memory for the hash value so that it is

Re: [PATCH 06/13] x86: Allow locating UARTs by device ID

2023-03-20 Thread Bin Meng
+Andy Hi Simon, On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > When coreboot does not pass a UART in its sysinfo struct, there is no > easy way to find it out. Add a way to specify known UARTs so we can > find them without needing help from coreboot. > > Since coreboot does not actually

Re: [PATCH 10/13] x86: coreboot: Document how to enable the debug UART

2023-03-20 Thread Bin Meng
On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > This is not obvious so add a little note about how it works. > > Signed-off-by: Simon Glass > --- > > doc/board/coreboot/coreboot.rst | 29 + > 1 file changed, 29 insertions(+) > Reviewed-by: Bin Meng

[PATCH v2 2/4] unit-test: cover run_commandf() by test-cases

2023-03-20 Thread Evgeny Bachinin
As run_commandf() is variadic version of run_command() and just a wrapper, hence apply similar run_command's test-cases. Let's avoid warning about empty string passing: warning: zero-length gnu_printf format string [-Wformat-zero-length] assert(run_commandf("") == 0); Signed-off-by: Evgeny

[PATCH v2 4/4] test: exit: fix run_commandf() warnings

2023-03-20 Thread Evgeny Bachinin
Fix warnings after adding printf-like attribute format for run_commandf(): warning: too many arguments for format [-Wformat-extra-args] Signed-off-by: Evgeny Bachinin Reviewed-by: Simon Glass --- test/cmd/exit.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff

[PATCH v2 1/4] cli: run_commandf(): small fixups

2023-03-20 Thread Evgeny Bachinin
* vsnprintf() can truncate cmd, hence it makes no sense to launch such command (it's broken). Moreover, it's better to signalize to the caller about such case (for facilitating debugging or bug hunting). * Fix kernel-doc warnings: include/command.h:264: info: Scanning doc for run_commandf

[PATCH v2 3/4] test: fdt: fix run_commandf() warnings

2023-03-20 Thread Evgeny Bachinin
Fix warnings both for 32bit and 64bit architecture after adding printf-like attribute format for run_commandf(): warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘ulong {aka long unsigned int}’ [-Wformat=] ret = run_commandf("fdt addr -c %08x", addr);

Re: [PATCH 2/4] phy: Fix kerneldoc alignment

2023-03-20 Thread Patrice CHOTARD
Hi Marek On 3/19/23 18:09, Marek Vasut wrote: > Insert missing space in front of asterisk to avoid checkpatch warning. > Replace 'beeing' with 'being' as well, to fix another checkpatch warning. > > Signed-off-by: Marek Vasut > --- > Cc: Jim Liu > Cc: Neil Armstrong > Cc: Patrice Chotard >

Re: [PATCH 01/13] mtrr: Don't show an invalid CPU number

2023-03-20 Thread Bin Meng
Hi Simon, On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > When U-Boot did not do the MP init, we don't get an actual CPU number > here. Skip printing it in that case. > > Signed-off-by: Simon Glass > --- > > cmd/x86/mtrr.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >

Re: [PATCH 02/13] x86: Adjust search range for sysinfo table

2023-03-20 Thread Bin Meng
Hi Simon, On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > Avoid searching starting at 0 since this memory may not be available Please describe in more detail why memory address 0 is not available? > and the table cannot be there anyway. Start at 0x400 instead. > > Signed-off-by: Simon

Re: [PATCH 1/1] efi_loader: move struct efi_device_path to efi.h

2023-03-20 Thread Ilias Apalodimas
Hi Heinrich, On Sun, Mar 19, 2023 at 08:59:33AM +0100, Heinrich Schuchardt wrote: > Avoid forward declaration of struct efi_device_path. > > Signed-off-by: Heinrich Schuchardt > --- > include/efi.h | 13 - > include/efi_api.h | 6 -- > 2 files changed, 12 insertions(+), 7

Re: [PATCH 1/2] efi_loader: support for Ctrl() device path node

2023-03-20 Thread Ilias Apalodimas
On Sun, Mar 19, 2023 at 04:18:08PM +0100, Heinrich Schuchardt wrote: > * Add the definitions for Ctrl() device path nodes. > * Implement Ctrl() nodes in the device path to text protocol. > > Signed-off-by: Heinrich Schuchardt > --- > include/efi_api.h| 6 ++ >

Re: [PATCH 1/2] efi_loader: move dp_alloc() to efi_alloc()

2023-03-20 Thread Ilias Apalodimas
Hi Heinrich, On Sun, Mar 19, 2023 at 09:20:22AM +0100, Heinrich Schuchardt wrote: > The incumbent function efi_alloc() is unused. > > Replace dp_alloc() by a new function efi_alloc() that we can use more > widely. [...] > #include > #include > +#include > #include > #include >

Re: [PATCH] i2c: correct I2C deblock logic

2023-03-20 Thread Heiko Schocher
Hi! On 13.03.23 03:55, Bough Chen wrote: >> -Original Message- >> From: Bough Chen >> Sent: 2023年2月10日 17:27 >> To: h...@denx.de; al.koc...@gmail.com; ma...@denx.de >> Cc: u-boot@lists.denx.de; dl-uboot-imx ; >> xypron.g...@gmx.de; Bough Chen >> Subject: [PATCH] i2c: correct I2C deblock

Re: [PATCH 05/13] x86: coreboot: Collect the address of the ACPI tables

2023-03-20 Thread Bin Meng
Hi Simon, On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > Pick this up from the sysinfo tables and display it with the cbsysinfo > command. This allows the 'acpi list' command to work when booting from > coreboot. > > Signed-off-by: Simon Glass > --- > >

Re: [PATCH v3 8/9] rockchip: Move to standard boot

2023-03-20 Thread Jonas Karlman
Hi Simon, On 2023-03-20 06:48, Simon Glass wrote: > Drop the distro-boot scripts and use standard boot instead. > > Signed-off-by: Simon Glass > --- > > Changes in v3: > - Update rk3588 boards too > > Changes in v2: > - Add new patch to move rockchip to standard boot > > arch/arm/Kconfig

Re: [PATCH 09/13] x86: coreboot: Use a memory-mapped UART

2023-03-20 Thread Bin Meng
On Mon, Mar 20, 2023 at 4:08 PM Bin Meng wrote: > > Hi Simon, > > On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > > > This is much more common on modern hardware, so default to using it. > > > > Signed-off-by: Simon Glass > > --- > > > > include/configs/coreboot.h | 2 ++ > > 1 file

Re: [PATCH 11/13] x86: coreboot: Scan PCI after relocation

2023-03-20 Thread Bin Meng
On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > Enable this so that PCI devices can be used correctly without needing > to do a manual scan. > > Signed-off-by: Simon Glass > --- > > configs/coreboot_defconfig | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Bin Meng

Re: [PATCH 12/13] x86: coreboot: Log function names and line numbers

2023-03-20 Thread Bin Meng
On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > Turn these options on to make it easier to debug things. > > Also enable dhrystone so we can get some measure of performance. > > Signed-off-by: Simon Glass > --- > > configs/coreboot_defconfig | 4 > 1 file changed, 4 insertions(+) >

[PATCH v2 0/4] cli: run_commandf() coverage and small fixups

2023-03-20 Thread Evgeny Bachinin
Our company has been using custom variadic version of run_command() since the beginning of the 2022Y. Recently, we had started upstreaming activity and figured out, that similar functionality already exists. Thanks, it's very helpful, because our code uses such variadic API. Let me share

Re: [PATCH 1/4] phy: Add empty generic_phy_configure() implementation for PHY disabled case

2023-03-20 Thread Patrice CHOTARD
Hi Marek On 3/19/23 18:09, Marek Vasut wrote: > In case PHY is not enabled, the generic_phy_configure() implementation is > missing. Add an empty one so that the list of empty functions is complete. > > Fixes: f8da8a82c57 ("generic-phy: add configure op") > Signed-off-by: Marek Vasut > --- >

Re: [EXTERNAL] Re: [PATCH 0/2] add support for hs bootflows on am62 devices

2023-03-20 Thread Kamlesh Gurudasani
Tom Rini writes: > On Fri, Mar 17, 2023 at 02:21:16PM +0530, Kamlesh Gurudasani wrote: >> Tom Rini writes: >> ... >> >> Hi Tom, >> >> >> >> Could you please review and merge this patches as these are bug fixes to >> >> get HS devices working. >> > >> > Is this a regression fix vs v2023.01 or

Re: [PATCH 1/2] efi_loader: move dp_alloc() to efi_alloc()

2023-03-20 Thread Heinrich Schuchardt
On 3/20/23 08:38, Ilias Apalodimas wrote: Hi Heinrich, On Sun, Mar 19, 2023 at 09:20:22AM +0100, Heinrich Schuchardt wrote: The incumbent function efi_alloc() is unused. Replace dp_alloc() by a new function efi_alloc() that we can use more widely. [...] #include #include +#include

  1   2   >