Re: [U-Boot] [RFC PATCH v2 12/20] fastboot: net: Convert command lookup to a table

2018-05-04 Thread Alex Kiernan
On Thu, May 3, 2018 at 10:08 PM Joe Hershberger <joe.hershber...@ni.com> wrote: > On Mon, Apr 30, 2018 at 3:32 AM, Alex Kiernan <alex.kier...@gmail.com> wrote: > > Change command lookup to use a lookup table so it matches the existing > > USB fastboot code. > >

Re: [U-Boot] [RFC PATCH v2 20/20] fastboot: net: Split fastboot protocol out from net

2018-05-04 Thread Alex Kiernan
On Thu, May 3, 2018 at 10:30 PM Joe Hershberger <joe.hershber...@ni.com> wrote: > On Mon, Apr 30, 2018 at 3:32 AM, Alex Kiernan <alex.kier...@gmail.com> wrote: > > Separate the fastboot protocol handling from the fastboot UDP code in > > preparation for reusing it in t

Re: [U-Boot] [RFC PATCH v2 13/20] fastboot: Merge reboot-bootloader handling

2018-05-04 Thread Alex Kiernan
On Thu, May 3, 2018 at 10:16 PM Joe Hershberger <joe.hershber...@ni.com> wrote: > On Mon, Apr 30, 2018 at 3:32 AM, Alex Kiernan <alex.kier...@gmail.com> wrote: > > Extract fb_set_reboot_flag() from USB code and ensure all the overides > > are included, then make the U

[U-Boot] [PATCH v3 03/13] fastboot: Refactor fastboot_okay/fail to take response

2018-05-14 Thread Alex Kiernan
Add the response string as a parameter to fastboot_okay/fail, instead of modifying a global, to match the contract expected by the AOSP U-Boot code. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes in v3

[U-Boot] [PATCH v3 02/13] fastboot: Switch dependencies on FASTBOOT to USB_FUNCTION_FASTBOOT

2018-05-14 Thread Alex Kiernan
Anyone who wants FASTBOOT before this series wants USB_FUNCTION_FASTBOOT. Split USB_FUNCTION_FASTBOOT from FASTBOOT so they retain their existing behaviour. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes i

[U-Boot] [PATCH v3 04/13] fastboot: Extract fastboot_okay/fail to fb_common.c

2018-05-14 Thread Alex Kiernan
-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes in v3: - Merge subsequent patch for formatting response strings into this one - allow NULL to fastboot_okay() when there's no message to send Changes in v2: None drivers/fastb

[U-Boot] [PATCH v3 05/13] fastboot: Correct dependencies in FASTBOOT_FLASH

2018-05-14 Thread Alex Kiernan
/DOS_PARTITION enabled. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes in v3: - guard FASTBOOT_GPT_NAME/FASTBOOT_MBR_NAME with EFI/DOS_PARTITION Changes in v2: None arch/arm/mach-omap2/utils.c | 4 ++-- driv

[U-Boot] [PATCH v3 06/13] fastboot: Add missing newlines

2018-05-14 Thread Alex Kiernan
Add newlines so we format our output correctly. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Acked-by: Joe Hershberger <joe.hershber...@ni.com> Reviewed-by: Jocelyn Bohr <b...@google.com> --- Changes in v3: None Changes in v2: None drivers/fast

[U-Boot] [PATCH v3 08/13] fastboot: Fix parameter types in _fb_nand_write

2018-05-14 Thread Alex Kiernan
(struct mtd_info *mtd, loff_t offset, size_t *length, ^~~ Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> --- Changes in v3: - new Changes in v2: None drivers/fastboot/fb_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/fastboot/fb_

[U-Boot] [PATCH v3 10/13] fastboot: Extract common definitions from USB fastboot

2018-05-14 Thread Alex Kiernan
Move strcmp_l1() to include/common.h so we can can call it from elsewhere. Move FASTBOOT_VERSION to include/fastboot.h so when we merge the UDP code we only have one definition. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> --- Changes in v3: - new Changes in v2: None drive

[U-Boot] [PATCH v3 09/13] fastboot: Rename fb_set_reboot_flag to fastboot_set_reboot_flag

2018-05-14 Thread Alex Kiernan
call it from non-USB fastboot code. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> --- Changes in v3: - new Changes in v2: None arch/arm/mach-omap2/boot-common.c | 4 ++-- arch/arm/mach-rockchip/rk3128-board.c | 4 ++-- arch/arm/mach-rockchip/rk322x-board.c | 4 ++-- board/amaz

[U-Boot] [PATCH v3 11/13] ti: fastboot: Move weak overrides to board files

2018-05-14 Thread Alex Kiernan
Overriding fastboot_set_reboot_flag() in arch/arm/mach-omap2/boot-common.c leaves it applying all boards that derive from this, not just the ones which have support for Android bootloader flow. Move the weak function override to the relevant board files. Signed-off-by: Alex Kiernan <alex.k

[U-Boot] [PATCH v3 07/13] fastboot: Remove FIXME for CONFIG_FASTBOOT_...NAME

2018-05-14 Thread Alex Kiernan
CONFIG_FASTBOOT_GPT_NAME and CONFIG_FASTBOOT_MBR_NAME are always defined by Kconfig if you're compiling this code, so remove these redundant defaults. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> --- Changes in v3: - new Changes in v2: None drivers/fastboot/fb_mmc.

[U-Boot] [PATCH v3 13/13] net: fastboot: Merge AOSP UDP fastboot

2018-05-14 Thread Alex Kiernan
Merge UDP fastboot support from AOSP: https://android.googlesource.com/platform/external/u-boot/+/android-o-mr1-iot-preview-8 Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Signed-off-by: Alex Deymo <de...@google.com> Signed-off-by: Jocelyn Bohr <b...@google.com>

[U-Boot] [PATCH v3 12/13] fs: Add fs_get_type_name to return current filesystem name

2018-05-14 Thread Alex Kiernan
Add fs_get_type_name so we can get the current filesystem type. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> --- Changes in v3: - new Changes in v2: None fs/fs.c | 5 + include/fs.h | 5 + 2 files changed, 10 insertions(+) diff --git a/fs/fs.c b/fs/fs.c index 9

[U-Boot] [RFC PATCH] usb: fastboot: Convert USB f_fastboot to shared fastboot

2018-05-14 Thread Alex Kiernan
Convert USB fastboot code to use shared fastboot protocol. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> --- drivers/usb/gadget/f_fastboot.c | 310 +--- 1 file changed, 36 insertions(+), 274 deletions(-) diff --git a/drivers/usb/gadget/f_fastbo

[U-Boot] [RFC PATCH 0/1] Convert USB fastboot code to use shared protocol

2018-05-14 Thread Alex Kiernan
This builds on the fastboot UDP support and migrates the USB fastboot code to the shared code. It's currently untested, other than passing in Travis: https://travis-ci.org/akiernan/u-boot/builds/378475039 Alex Kiernan (1): usb: fastboot: Convert USB f_fastboot to shared fastboot drivers

[U-Boot] [PATCH v3 01/13] fastboot: Move fastboot to drivers/fastboot

2018-05-14 Thread Alex Kiernan
Separate CMD_FASTBOOT from FASTBOOT and move code and configuration to drivers/fastboot. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Simon Glass <s...@chromium.org> --- Changes in v3: - move imply ANDROID_BOOT_IMAGE, CMD_FASTBOOT to FASTBOOT from USB_FUNCT

[U-Boot] [PATCH v3 00/13] Add fastboot UDP support

2018-05-14 Thread Alex Kiernan
sure fastboot syntax is backward compatible - 'fastboot 0' means 'fastboot usb 0' Alex Kiernan (13): fastboot: Move fastboot to drivers/fastboot fastboot: Switch dependencies on FASTBOOT to USB_FUNCTION_FASTBOOT fastboot: Refactor fastboot_okay/fail to take response fastboot: Extrac

Re: [U-Boot] [U-Boot,3/3] mmc: support writing sparse images

2018-05-14 Thread Alex Kiernan
nd add a separate guard for it (LIB_IMAGE_SPARSE?) which can be selected by both FASTBOOT and a new command symbol (CMD_MMC_SWRITE)? This is all overlapping with the UDP fastboot code I've been posting, so I'd kinda like it to fit nicely with that, rather than have to refactor it to fit something different! -- Alex Kiernan ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v3 13/13] net: fastboot: Merge AOSP UDP fastboot

2018-05-14 Thread Alex Kiernan
On Mon, May 14, 2018 at 8:53 PM Simon Glass <s...@chromium.org> wrote: > Hi Alex, > On 14 May 2018 at 03:09, Alex Kiernan <alex.kier...@gmail.com> wrote: > > Merge UDP fastboot support from AOSP: > > > > https://android.googlesource.com/platform/external/

Re: [U-Boot] [U-Boot,3/3] mmc: support writing sparse images

2018-05-14 Thread Alex Kiernan
On Mon, May 14, 2018 at 9:50 PM Tom Rini <tr...@konsulko.com> wrote: > On Mon, May 14, 2018 at 05:14:42PM +0100, Alex Kiernan wrote: > > On Mon, May 14, 2018 at 3:47 PM Tom Rini <tr...@konsulko.com> wrote: > > > > > On Mon, May 14, 2018 at 06:42:41PM +05

Re: [U-Boot] [PATCH v3 10/13] fastboot: Extract common definitions from USB fastboot

2018-05-14 Thread Alex Kiernan
On Mon, May 14, 2018 at 8:53 PM Simon Glass <s...@chromium.org> wrote: > Hi, > On 14 May 2018 at 03:09, Alex Kiernan <alex.kier...@gmail.com> wrote: > > Move strcmp_l1() to include/common.h so we can can call it from elsewhere. > > Move FASTBOOT_VERSION to inclu

Re: [U-Boot] [PATCH v5 3/7] bootcount: Add function wrappers to handle bootcount increment and error checking

2018-05-07 Thread Alex Kiernan
here the bootcount is stored in ext4? > +#if defined(CONFIG_SPL_BUILD) && !defined(CONFIG_SPL_BOOTCOUNT_LIMIT) > +void bootcount_store(ulong a) {}; > +ulong bootcount_load(void) { return 0; } > +#endif /* CONFIG_SPL_BUILD && !CONFIG_SPL_BOOTCOUNT_LIMIT */ > +#else > +static inline int bootcount_error(void) { return 0; } > +static inline void bootcount_inc(void) {} > +#endif /* CONFIG_SPL_BOOTCOUNT_LIMIT || CONFIG_BOOTCOUNT_LIMIT */ > #endif /* _BOOTCOUNT_H__ */ > -- > 2.11.0 -- Alex Kiernan ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH] Convert CONFIG_SUPPORT_EMMC_RPMB to Kconfig

2018-05-07 Thread Alex Kiernan
Convert CONFIG_SUPPORT_EMMC_RPMB to Kconfig. Split the command handling from the underlying support and expose this through CMD_MMC_RPMB. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> --- README | 4 cmd/Kconfig| 7 ++

Re: [U-Boot] [PATCH v5 4/7] bootcount: Rewrite autoboot to use wrapper functions from bootcount.h

2018-05-07 Thread Alex Kiernan
-by: Tom Rini <tr...@konsulko.com> Reviewed-by: Alex Kiernan <alex.kier...@gmail.com> > --- > Changes in v5: > - None > Changes in v4: > - Use global data pointer (gd_t *) instead of bootcount specific enum > Changes in v3: > - New patch > Changes in v2: None >

Re: [U-Boot] [PATCH v5 2/7] bootcount: Add include guards into bootcount.h file

2018-05-07 Thread Alex Kiernan
NT_H__ > #include > #include > @@ -38,3 +40,4 @@ static inline u32 raw_bootcount_load(volatile u32 *addr) > return in_be32(addr); > } > #endif > +#endif /* _BOOTCOUNT_H__ */ > -- > 2.11.0 -- Alex Kiernan ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v5 1/7] bootcount: spl: Enable bootcount support in SPL

2018-05-07 Thread Alex Kiernan
; falcon boot mode. > Signed-off-by: Lukasz Majewski <lu...@denx.de> > Reviewed-by: Stefan Roese <s...@denx.de> > Reviewed-by: Tom Rini <tr...@konsulko.com> Reviewed-by: Alex Kiernan <alex.kier...@gmail.com> > --- > Changes in v5: > - None > Chan

Re: [U-Boot] [RFC PATCH v2 16/20] fastboot: net: Add NAND support

2018-05-08 Thread Alex Kiernan
On Tue, May 8, 2018 at 8:20 AM Joe Hershberger <joe.hershber...@ni.com> wrote: > On Tue, May 8, 2018 at 1:53 AM, Jocelyn Bohr <b...@verily.com> wrote: > > On Mon, Apr 30, 2018 at 1:33 AM Alex Kiernan <alex.kier...@gmail.com> wrote: > > > >> Add NAND su

Re: [U-Boot] [RFC PATCH v2 15/20] fastboot: Merge boot common across USB and UDP

2018-05-08 Thread Alex Kiernan
otcmd" is > > ambiguous as there can be multiple env variable commands related to > > fastboot. > Seems like a good suggestion to me. Yes. I'll pick it up in v3. -- Alex Kiernan ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [RFC PATCH v2 11/20] fastboot: net: Change 'continue' so it matches USB fastboot

2018-05-08 Thread Alex Kiernan
On Thu, May 3, 2018 at 9:58 PM Joe Hershberger <joe.hershber...@ni.com> wrote: > On Mon, Apr 30, 2018 at 3:32 AM, Alex Kiernan <alex.kier...@gmail.com> wrote: > > Change the behaviour of 'continue' so that we simply exit the fastboot > > server and leave the calle

Re: [U-Boot] [PATCH v5 3/7] bootcount: Add function wrappers to handle bootcount increment and error checking

2018-05-08 Thread Alex Kiernan
On Tue, May 8, 2018 at 8:41 AM Lukasz Majewski <lu...@denx.de> wrote: > On Tue, 08 May 2018 05:15:13 +0000 > Alex Kiernan <alex.kier...@gmail.com> wrote: > > On Wed, May 2, 2018 at 3:11 PM Lukasz Majewski <lu...@denx.de> wrote: > > > > > Those two fu

Re: [U-Boot] [RFC PATCH v2 07/20] net: fastboot: Merge AOSP UDP fastboot

2018-05-08 Thread Alex Kiernan
On Thu, May 3, 2018 at 9:39 PM Joe Hershberger <joe.hershber...@ni.com> wrote: > On Mon, Apr 30, 2018 at 3:32 AM, Alex Kiernan <alex.kier...@gmail.com> wrote: > > +/** > > + * Constructs and sends a packet in response to received fastboot packet >

Re: [U-Boot] [PATCH v5 3/7] bootcount: Add function wrappers to handle bootcount increment and error checking

2018-05-08 Thread Alex Kiernan
On Tue, May 8, 2018 at 10:21 AM Lukasz Majewski <lu...@denx.de> wrote: > Hi Alex, > > On Tue, May 8, 2018 at 8:41 AM Lukasz Majewski <lu...@denx.de> wrote: > > > > > On Tue, 08 May 2018 05:15:13 + > > > Alex Kiernan <alex.kier...@gmail.com>

Re: [U-Boot] [PATCH v5 3/7] bootcount: Add function wrappers to handle bootcount increment and error checking

2018-05-08 Thread Alex Kiernan
On Tue, May 8, 2018 at 6:15 AM Alex Kiernan <alex.kier...@gmail.com> wrote: > On Wed, May 2, 2018 at 3:11 PM Lukasz Majewski <lu...@denx.de> wrote: > > Those two functions can be used to provide easy bootcount management. > > Signed-off-by: Lukasz Majewski <lu...@

Re: [U-Boot] [PATCH v5 3/7] bootcount: Add function wrappers to handle bootcount increment and error checking

2018-05-08 Thread Alex Kiernan
On Tue, May 8, 2018 at 8:11 AM Stefan Roese <s...@denx.de> wrote: > On 08.05.2018 08:58, Alex Kiernan wrote: > > >>> +static inline void bootcount_inc(void) > >>> +{ > >>> + unsigned long bootcount = bootcount_load(); >

Re: [U-Boot] [RFC PATCH v1 0/5] Add fastboot UDP support

2018-04-27 Thread Alex Kiernan
ndling) > into /drivers/fastboot and have only small glue code for USB and NET. > I'm working towards that. I'm starting with the command implementations, then I'll look at the protocol. Hopefully I'll get an RFCv2 out sometime over the weekend with the first bits done. -- Alex Kiernan

Re: [U-Boot] [RFC PATCH v1 0/5] Add fastboot UDP support

2018-04-27 Thread Alex Kiernan
Hi Sam, On Fri, Apr 27, 2018 at 8:10 PM, Sam Protsenko <semen.protse...@linaro.org> wrote: > On 24 April 2018 at 12:37, Alex Kiernan <alex.kier...@gmail.com> wrote: >> >> This series merges the fastboot UDP support from AOSP into mainline >> U-Boot. >> >

[U-Boot] [PATCH] bootcount: Add bootcount command

2018-05-11 Thread Alex Kiernan
Add a command to manipulate the bootcounter. This is useful if you can run device recovery from inside U-Boot and need to reset the bootcounter after executing that process as part of altbootcmd. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> --- cmd/Kconfig | 7 +++ cmd/Ma

[U-Boot] [PATCH] net: cpsw: ti: Reap completed packets before stopping interface

2018-05-12 Thread Alex Kiernan
from the call to cpdma_process() as we weren't using them on their return. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> --- drivers/net/cpsw.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/net/cpsw.c b/drivers/net/cpsw.c index e

Re: [U-Boot] [RFC PATCH v2 07/20] net: fastboot: Merge AOSP UDP fastboot

2018-05-08 Thread Alex Kiernan
On Tue, May 8, 2018 at 4:24 PM Joe Hershberger <joe.hershber...@ni.com> wrote: > On Tue, May 8, 2018 at 4:11 AM, Alex Kiernan <alex.kier...@gmail.com> wrote: > > On Thu, May 3, 2018 at 9:39 PM Joe Hershberger <joe.hershber...@ni.com> > > wrote: > > >

[U-Boot] [PATCH v4 05/14] fastboot: Correct dependencies in FASTBOOT_FLASH

2018-05-15 Thread Alex Kiernan
/DOS_PARTITION enabled. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes in v4: None Changes in v3: - guard FASTBOOT_GPT_NAME/FASTBOOT_MBR_NAME with EFI/DOS_PARTITION Changes in v2: None arch/arm/mach-omap2/util

[U-Boot] [PATCH v4 07/14] fastboot: Remove FIXME for CONFIG_FASTBOOT_...NAME

2018-05-15 Thread Alex Kiernan
CONFIG_FASTBOOT_GPT_NAME and CONFIG_FASTBOOT_MBR_NAME are always defined by Kconfig if you're compiling this code, so remove these redundant defaults. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Simon Glass <s...@chromium.org> --- Changes in v4: None Changes

[U-Boot] [PATCH v4 02/14] fastboot: Switch dependencies on FASTBOOT to USB_FUNCTION_FASTBOOT

2018-05-15 Thread Alex Kiernan
Anyone who wants FASTBOOT before this series wants USB_FUNCTION_FASTBOOT. Split USB_FUNCTION_FASTBOOT from FASTBOOT so they retain their existing behaviour. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes in v4:

[U-Boot] [PATCH v4 04/14] fastboot: Extract fastboot_okay/fail to fb_common.c

2018-05-15 Thread Alex Kiernan
-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes in v4: - add docbook comments Changes in v3: - Merge subsequent patch for formatting response strings into this one - allow NULL to fastboot_okay() when there's no message to send C

[U-Boot] [PATCH v4 14/14] net: fastboot: Merge AOSP UDP fastboot

2018-05-15 Thread Alex Kiernan
Merge UDP fastboot support from AOSP: https://android.googlesource.com/platform/external/u-boot/+/android-o-mr1-iot-preview-8 Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Signed-off-by: Alex Deymo <de...@google.com> Signed-off-by: Jocelyn Bohr <b...@google.com>

[U-Boot] [PATCH v4 12/14] fs: Add fs_get_type_name to return current filesystem name

2018-05-15 Thread Alex Kiernan
Add fs_get_type_name so we can get the current filesystem type. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Simon Glass <s...@chromium.org> --- Changes in v4: - add docbook comments Changes in v3: - new Changes in v2: None fs/fs.c | 13 +

[U-Boot] [PATCH v4 03/14] fastboot: Refactor fastboot_okay/fail to take response

2018-05-15 Thread Alex Kiernan
Add the response string as a parameter to fastboot_okay/fail, instead of modifying a global, to match the contract expected by the AOSP U-Boot code. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes in v4: None C

[U-Boot] [PATCH v4 10/14] fastboot: Extract common definitions from USB fastboot

2018-05-15 Thread Alex Kiernan
Move FASTBOOT_VERSION to include/fastboot.h so when we merge the UDP code we only have one definition. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> --- Changes in v4: - leave strcmp_l1() in USB fastboot as we don't need it in UDP path Changes in v3: - new Changes in v2: None d

[U-Boot] [PATCH v4 06/14] fastboot: Add missing newlines

2018-05-15 Thread Alex Kiernan
Add newlines so we format our output correctly. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Acked-by: Joe Hershberger <joe.hershber...@ni.com> Reviewed-by: Jocelyn Bohr <b...@google.com> --- Changes in v4: None Changes in v3: None Changes in v2: None drivers/fast

[U-Boot] [PATCH v4 09/14] fastboot: Rename fb_set_reboot_flag to fastboot_set_reboot_flag

2018-05-15 Thread Alex Kiernan
call it from non-USB fastboot code. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Simon Glass <s...@chromium.org> --- Changes in v4: None Changes in v3: - new Changes in v2: None arch/arm/mach-omap2/boot-common.c | 4 ++-- arch/arm/mach-rockchip/rk3128-

[U-Boot] [PATCH v4 08/14] fastboot: Fix parameter types in _fb_nand_write

2018-05-15 Thread Alex Kiernan
(struct mtd_info *mtd, loff_t offset, size_t *length, ^~~ Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Simon Glass <s...@chromium.org> --- Changes in v4: None Changes in v3: - new Changes in v2: None drivers/fastboot/fb_nand.c | 2 +- 1 fil

[U-Boot] [PATCH v4 11/14] ti: fastboot: Move weak overrides to board files

2018-05-15 Thread Alex Kiernan
Overriding fastboot_set_reboot_flag() in arch/arm/mach-omap2/boot-common.c leaves it applying all boards that derive from this, not just the ones which have support for Android bootloader flow. Move the weak function override to the relevant board files. Signed-off-by: Alex Kiernan <alex.k

Re: [U-Boot] [UBOOT PATCH] env: mmc: Fix misaligned buffer address when saving envvars to FAT

2018-05-17 Thread Alex Kiernan
al information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately. > ____

Re: [U-Boot] [RFC PATCH v2 1/2] usb: fastboot: Convert USB f_fastboot to shared fastboot

2018-05-19 Thread Alex Kiernan
On Fri, May 18, 2018 at 10:42 PM Alex Kiernan <alex.kier...@gmail.com> wrote: > Hi Sam > On Fri, May 18, 2018 at 7:32 PM Sam Protsenko <semen.protse...@linaro.org> > wrote: > > On 17 May 2018 at 19:13, Alex Kiernan <alex.kier...@gmail.com> wrote: > > &g

[U-Boot] [PATCH v5 09/16] fastboot: Extract common definitions from USB fastboot

2018-05-17 Thread Alex Kiernan
Move FASTBOOT_VERSION to include/fastboot.h so when we merge the UDP code we only have one definition. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Simon Glass <s...@chromium.org> Acked-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes in v5:

[U-Boot] [PATCH v5 10/16] fastboot: Rename public fb_ functions to fastboot_

2018-05-17 Thread Alex Kiernan
Rename fb_mmc_flash_write/fb_mmc_erase/fb_nand_flash_write/fb_nand_erase to fastboot_... as they form a public interface Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> --- Changes in v5: - new Changes in v4: None Changes in v3: None Changes in v2: None drivers/fastboot/fb

[U-Boot] [PATCH v5 06/16] fastboot: Remove FIXME for CONFIG_FASTBOOT_...NAME

2018-05-17 Thread Alex Kiernan
CONFIG_FASTBOOT_GPT_NAME and CONFIG_FASTBOOT_MBR_NAME are always defined by Kconfig if you're compiling this code, so remove these redundant defaults. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Simon Glass <s...@chromium.org> Acked-by: Joe Hershberger &

[U-Boot] [PATCH v5 08/16] fastboot: Rename fb_set_reboot_flag to fastboot_set_reboot_flag

2018-05-17 Thread Alex Kiernan
call it from non-USB fastboot code. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Simon Glass <s...@chromium.org> Acked-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes in v5: None Changes in v4: None Changes in v3: - new Changes in v2: None arch/a

[U-Boot] [PATCH v5 15/16] net: fastboot: Merge AOSP UDP fastboot

2018-05-17 Thread Alex Kiernan
Merge UDP fastboot support from AOSP: https://android.googlesource.com/platform/external/u-boot/+/android-o-mr1-iot-preview-8 Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Signed-off-by: Alex Deymo <de...@google.com> Signed-off-by: Jocelyn Bohr <b...@google.com>

[U-Boot] [PATCH v5 07/16] fastboot: Fix parameter types in _fb_nand_write

2018-05-17 Thread Alex Kiernan
(struct mtd_info *mtd, loff_t offset, size_t *length, ^~~ Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Simon Glass <s...@chromium.org> Acked-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes in v5: None Changes in v4: None Ch

[U-Boot] [PATCH v5 05/16] fastboot: Add missing newlines

2018-05-17 Thread Alex Kiernan
Add newlines so we format our output correctly. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Acked-by: Joe Hershberger <joe.hershber...@ni.com> Reviewed-by: Jocelyn Bohr <b...@google.com> --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in

[U-Boot] [RFC PATCH v2 0/2] Convert USB fastboot code to use shared protocol

2018-05-17 Thread Alex Kiernan
() function Alex Kiernan (2): usb: fastboot: Convert USB f_fastboot to shared fastboot fastboot: Update fastboot documentation doc/README.android-fastboot | 80 ++ drivers/fastboot/Makefile | 4 +- drivers/usb/gadget/f_fastboot.c | 318

[U-Boot] [RFC PATCH v2 1/2] usb: fastboot: Convert USB f_fastboot to shared fastboot

2018-05-17 Thread Alex Kiernan
Convert USB fastboot code to use shared fastboot protocol. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> --- Changes in v2: - remove redundant version.h - use new fastboot_get_bytes_remaining() function drivers/fastboot/Makefile | 4 +- drivers/usb/gadget/f_fastboot.c

[U-Boot] [PATCH v5 02/16] fastboot: Refactor fastboot_okay/fail to take response

2018-05-17 Thread Alex Kiernan
Add the response string as a parameter to fastboot_okay/fail, instead of modifying a global, to match the contract expected by the AOSP U-Boot code. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes in v5: None C

[U-Boot] [PATCH v5 11/16] ti: fastboot: Move weak overrides to board files

2018-05-17 Thread Alex Kiernan
Overriding fastboot_set_reboot_flag() in arch/arm/mach-omap2/boot-common.c leaves it applying all boards that derive from this, not just the ones which have support for Android bootloader flow. Move the weak function override to the relevant board files. Signed-off-by: Alex Kiernan <alex.k

[U-Boot] [PATCH v5 13/16] fastboot: Migrate FASTBOOT_FLASH_NAND_TRIMFFS to Kconfig

2018-05-17 Thread Alex Kiernan
Add FASTBOOT_FLASH_NAND_TRIMFFS to Kconfig; note there are no in-tree users of it. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> --- Changes in v5: - new Changes in v4: None Changes in v3: None Changes in v2: None drivers/fastboot/Kconfig | 6 ++ scripts/config_whiteli

[U-Boot] [PATCH v5 12/16] fs: Add fs_get_type_name to return current filesystem name

2018-05-17 Thread Alex Kiernan
Add fs_get_type_name so we can get the current filesystem type. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Simon Glass <s...@chromium.org> Reviewed-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes in v5: None Changes in v4: - add docbook comme

[U-Boot] [PATCH v5 16/16] fastboot: Add support for 'oem format' command

2018-05-17 Thread Alex Kiernan
Introduce 'oem format' which matches the USB implementation, guard this with CONFIG_FASTBOOT_CMD_OEM_FORMAT so that you can configure it out. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> --- Changes in v5: - new Changes in v4: None Changes in v3: None Changes in v2: None d

[U-Boot] [PATCH v5 04/16] fastboot: Correct dependencies in FASTBOOT_FLASH

2018-05-17 Thread Alex Kiernan
/DOS_PARTITION enabled. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes in v5: None Changes in v4: None Changes in v3: - guard FASTBOOT_GPT_NAME/FASTBOOT_MBR_NAME with EFI/DOS_PARTITION Changes in v2: None arch/ar

[U-Boot] [PATCH v5 03/16] fastboot: Extract fastboot_okay/fail to fb_common.c

2018-05-17 Thread Alex Kiernan
-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes in v5: - fix docbook formatting Changes in v4: - add docbook comments Changes in v3: - Merge subsequent patch for formatting response strings into this one - allow NULL to fastboot

Re: [U-Boot] [PATCH v3 13/13] net: fastboot: Merge AOSP UDP fastboot

2018-05-16 Thread Alex Kiernan
On Tue, May 15, 2018 at 5:05 PM Simon Glass <s...@chromium.org> wrote: > Hi Alex, > On 15 May 2018 at 07:11, Alex Kiernan <alex.kier...@gmail.com> wrote: > > On Mon, May 14, 2018 at 8:53 PM Simon Glass <s...@chromium.org> wrote: > > > >> Hi Alex, &

Re: [U-Boot] [PATCH v4 00/14] Add fastboot UDP support

2018-05-16 Thread Alex Kiernan
Hi Sam On Tue, May 15, 2018 at 5:52 PM Sam Protsenko <semen.protse...@linaro.org> wrote: > On 15 May 2018 at 17:48, Alex Kiernan <alex.kier...@gmail.com> wrote: > > > > This series merges the fastboot UDP support from AOSP into mainline > > U-Boot. > &g

[U-Boot] [PATCH v4 13/14] mmc: Separate "mmc swrite" from fastboot

2018-05-15 Thread Alex Kiernan
Introduce CONFIG_IMAGE_SPARSE and CONFIG_CMD_MMC_SWRITE so the "mmc swrite" command is separated from the fastboot code. Move image-sparse from common to lib so it's clear it's library code. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> --- Changes in v4: - new Cha

[U-Boot] [PATCH v4 01/14] fastboot: Move fastboot to drivers/fastboot

2018-05-15 Thread Alex Kiernan
Separate CMD_FASTBOOT from FASTBOOT and move code and configuration to drivers/fastboot. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Simon Glass <s...@chromium.org> --- Changes in v4: None Changes in v3: - move imply ANDROID_BOOT_IMAGE, CMD_FASTBOOT to F

[U-Boot] [PATCH v4 00/14] Add fastboot UDP support

2018-05-15 Thread Alex Kiernan
astboot process ends. - Separate the fastboot protocol handling from the fastboot UDP code in preparation for reusing it in the USB code. Changes in v2: - ensure fastboot syntax is backward compatible - 'fastboot 0' means 'fastboot usb 0' Alex Kiernan (14): fastboot: Move fastboot to drivers

[U-Boot] [RFC PATCH v2 2/2] fastboot: Update fastboot documentation

2018-05-17 Thread Alex Kiernan
Update fastboot documentation to reflect merged USB/UDP implementation. Bring in current Android fastboot protocol document. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> --- Changes in v2: - new doc/README.android-fastboot | 80 +++--

Re: [U-Boot] [PATCH v4 13/14] mmc: Separate "mmc swrite" from fastboot

2018-05-16 Thread Alex Kiernan
On Wed, May 16, 2018 at 5:17 PM Joe Hershberger <joe.hershber...@ni.com> wrote: > On Wed, May 16, 2018 at 12:00 AM, Alex Kiernan <alex.kier...@gmail.com> wrote: > > On Wed, May 16, 2018 at 12:20 AM Joe Hershberger <joe.hershber...@ni.com > > wrote: > > > &

Re: [U-Boot] [RESEND][PATCH] cmd: nvedit: add whitelist option for env import

2018-05-15 Thread Alex Kiernan
se 'w': > > + wl = 1; > > + wl_count = 1; > > + > > + str = env_get("whitelisted_vars"); > I don't like how this is grabbing the list from the env. I think a > comma-separated list should be a parameter following the '-w'. I posted a patch, independently in that vein as I hadn't spotted Quentin's patch: http://patchwork.ozlabs.org/patch/891422/ I could clean it up to take parameters in an option. -- Alex Kiernan ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 1/2] cmd: nvedit: add whitelist option for env import

2018-05-21 Thread Alex Kiernan
gt; use-case-specific variable name than whitelisted_vars in order to describe > > why those variables are "whitelisted". > This has been raised in the previous version of the patch[1] (of which > you weren't in the mail recipients) and a similar patch[2] made by Alex > Kiernan

Re: [U-Boot] [PATCH v2 1/2] cmd: nvedit: add whitelist option for env import

2018-05-21 Thread Alex Kiernan
On Mon, May 21, 2018 at 1:06 PM Quentin Schulz <quentin.sch...@bootlin.com> wrote: > Hi Alex, > On Mon, May 21, 2018 at 12:56:04PM +0100, Alex Kiernan wrote: > > On Mon, May 21, 2018 at 9:02 AM Quentin Schulz < quentin.sch...@bootlin.com> > > wrote: > > > &

Re: [U-Boot] [PATCH v2 1/2] cmd: nvedit: add whitelist option for env import

2018-05-21 Thread Alex Kiernan
On Mon, May 21, 2018 at 1:06 PM Quentin Schulz <quentin.sch...@bootlin.com> wrote: > Hi Alex, > On Mon, May 21, 2018 at 12:56:04PM +0100, Alex Kiernan wrote: > > On Mon, May 21, 2018 at 9:02 AM Quentin Schulz < quentin.sch...@bootlin.com> > > wrote: > > > &

Re: [U-Boot] [PATCH v2 1/2] cmd: nvedit: add whitelist option for env import

2018-05-21 Thread Alex Kiernan
On Mon, May 21, 2018 at 1:34 PM Quentin Schulz <quentin.sch...@bootlin.com> wrote: > On Mon, May 21, 2018 at 01:26:11PM +0100, Alex Kiernan wrote: > > On Mon, May 21, 2018 at 1:06 PM Quentin Schulz < quentin.sch...@bootlin.com> > > wrote: > > > > > Hi Ale

[U-Boot] [PATCH v6 15/18] net: fastboot: Merge AOSP UDP fastboot

2018-05-22 Thread Alex Kiernan
Merge UDP fastboot support from AOSP: https://android.googlesource.com/platform/external/u-boot/+/android-o-mr1-iot-preview-8 Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Signed-off-by: Alex Deymo <de...@google.com> Signed-off-by: Jocelyn Bohr <b...@google.com>

[U-Boot] [PATCH v6 17/18] usb: fastboot: Convert USB f_fastboot to shared fastboot

2018-05-22 Thread Alex Kiernan
Convert USB fastboot code to use shared fastboot protocol. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> --- Changes in v6: - merged from RFC USB fastboot series - when entering the DATA phase ensure we actually install the correct handler - on completion of DATA ca

[U-Boot] [PATCH v6 16/18] fastboot: Add support for 'oem format' command

2018-05-22 Thread Alex Kiernan
Introduce 'oem format' which matches the USB implementation, guard this with CONFIG_FASTBOOT_CMD_OEM_FORMAT so that you can configure it out. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> --- Changes in v6: None Changes in v5: - new Changes in v4: None Changes in v3: None Changes

[U-Boot] [PATCH v6 13/18] fastboot: Migrate FASTBOOT_FLASH_NAND_TRIMFFS to Kconfig

2018-05-22 Thread Alex Kiernan
Add FASTBOOT_FLASH_NAND_TRIMFFS to Kconfig; note there are no in-tree users of it. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Simon Glass <s...@chromium.org> --- Changes in v6: None Changes in v5: - new Changes in v4: None Changes in v3: None Changes in v2: No

[U-Boot] [PATCH v6 11/18] ti: fastboot: Move weak overrides to board files

2018-05-22 Thread Alex Kiernan
Overriding fastboot_set_reboot_flag() in arch/arm/mach-omap2/boot-common.c leaves it applying all boards that derive from this, not just the ones which have support for Android bootloader flow. Move the weak function override to the relevant board files. Signed-off-by: Alex Kiernan <alex.k

[U-Boot] [PATCH v6 14/18] mmc: Separate "mmc swrite" from fastboot

2018-05-22 Thread Alex Kiernan
to Kconfig. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Acked-by: Jassi Brar <jaswinder.si...@linaro.org> --- Changes in v6: None Changes in v5: - rename CONFIG_FASTBOOT_FLASH_FILLBUF_SIZE to CONFIG_IMAGE_SPARSE_FILLBUF_SIZE and migrate it to Kconfig. Changes in v4: - ne

[U-Boot] [PATCH v6 05/18] fastboot: Add missing newlines

2018-05-22 Thread Alex Kiernan
Add newlines so we format our output correctly. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Acked-by: Joe Hershberger <joe.hershber...@ni.com> Reviewed-by: Jocelyn Bohr <b...@google.com> --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3:

[U-Boot] [PATCH v6 12/18] fs: Add fs_get_type_name to return current filesystem name

2018-05-22 Thread Alex Kiernan
Add fs_get_type_name so we can get the current filesystem type. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Simon Glass <s...@chromium.org> Reviewed-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes in v6: None Changes in v5: None Changes in

[U-Boot] [PATCH v6 09/18] fastboot: Extract common definitions from USB fastboot

2018-05-22 Thread Alex Kiernan
Move FASTBOOT_VERSION to include/fastboot.h so when we merge the UDP code we only have one definition. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Simon Glass <s...@chromium.org> Acked-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes in v6: None C

[U-Boot] [PATCH v6 03/18] fastboot: Extract fastboot_okay/fail to fb_common.c

2018-05-22 Thread Alex Kiernan
-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes in v6: None Changes in v5: - fix docbook formatting Changes in v4: - add docbook comments Changes in v3: - Merge subsequent patch for formatting response strings into this one

[U-Boot] [PATCH v6 04/18] fastboot: Correct dependencies in FASTBOOT_FLASH

2018-05-22 Thread Alex Kiernan
/DOS_PARTITION enabled. Delete redundant FASTBOOT_FLASH_NAND_DEV from Kconfig - it was only ever used as a guard and the value was ignored in all cases, we're using FASTBOOT_FLASH_NAND as the guard now. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Joe Hershberger <joe

[U-Boot] [PATCH v6 01/18] fastboot: Move fastboot to drivers/fastboot

2018-05-22 Thread Alex Kiernan
behaviour. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Simon Glass <s...@chromium.org> Acked-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes in v6: - accomodate master change and switch dependency on imx6dl_mamoj from FASTBOOT to USB_FUNCTION_FASTB

[U-Boot] [PATCH v6 10/18] fastboot: Rename public fb_ functions to fastboot_

2018-05-22 Thread Alex Kiernan
Rename fb_mmc_flash_write/fb_mmc_erase/fb_nand_flash_write/fb_nand_erase to fastboot_... as they form a public interface Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Simon Glass <s...@chromium.org> --- Changes in v6: - add docbook comments Changes in v5: -

[U-Boot] [PATCH v6 06/18] fastboot: Remove FIXME for CONFIG_FASTBOOT_...NAME

2018-05-22 Thread Alex Kiernan
CONFIG_FASTBOOT_GPT_NAME and CONFIG_FASTBOOT_MBR_NAME are always defined by Kconfig if you're compiling this code, so remove these redundant defaults. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Simon Glass <s...@chromium.org> Acked-by: Joe Hershberger &

[U-Boot] [PATCH v6 07/18] fastboot: Fix parameter types in _fb_nand_write

2018-05-22 Thread Alex Kiernan
(struct mtd_info *mtd, loff_t offset, size_t *length, ^~~ Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Simon Glass <s...@chromium.org> Acked-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes in v6: None Changes in v5: None Changes i

[U-Boot] [PATCH v6 00/18] Add fastboot UDP support

2018-05-22 Thread Alex Kiernan
not booted, control is returned to U-Boot and the fastboot process ends. - Separate the fastboot protocol handling from the fastboot UDP code in preparation for reusing it in the USB code. Changes in v2: - ensure fastboot syntax is backward compatible - 'fastboot 0' means 'fastboot usb

[U-Boot] [PATCH v6 02/18] fastboot: Refactor fastboot_okay/fail to take response

2018-05-22 Thread Alex Kiernan
Add the response string as a parameter to fastboot_okay/fail, instead of modifying a global, to match the contract expected by the AOSP U-Boot code. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes in v6: None C

  1   2   3   4   5   >