[U-Boot] [u-boot] spi/arm-pl022: Add support for ARM PL022 spi controller

2013-06-03 Thread Armando Visconti
This patch adds the support for the ARM PL022 SPI controller for the standard variant (0x00041022), which has a 16bit wide and 8 locations deep TX/RX FIFO. Signed-off-by: Armando Visconti Signed-off-by: Vipin Kumar --- This driver has been tested on the ST SPEAr1340 evaluation board. Patch

Re: [U-Boot] [u-boot] spi/arm-pl022: Add support for ARM PL022 spi controller

2013-06-03 Thread Armando Visconti
On 06/03/2013 11:48 AM, Jagan Teki wrote: Hi, Is this the v4? I sent some comment for v3 on same driver. Sorry, I completely lost the original thread... I will re-start from V3... Pls discard this noisy thread, Armando ___ U-Boot mailing list

Re: [U-Boot] [u-boot] spi/arm-pl022: Add support for ARM PL022 spi controller

2013-06-05 Thread Armando Visconti
On 06/03/2013 12:10 PM, Jagan Teki wrote: I completely lost the original thread... I will re-start from V3... Pls discard this noisy thread, Please check the below thread for earlier v3 http://patchwork.ozlabs.org/patch/205814/ Thx Jagan, I have a v4 ready, where I just corrected the chec

[U-Boot] [u-boot V4] spi/arm-pl022: Add support for ARM PL022 spi controller

2013-06-07 Thread Armando Visconti
This patch adds the support for the ARM PL022 SPI controller for the standard variant (0x00041022), which has a 16bit wide and 8 locations deep TX/RX FIFO. Signed-off-by: Armando Visconti Signed-off-by: Vipin Kumar Acked-by: Stefan Roese --- v3->v4 Just removed all warnings when runn

[U-Boot] [u-boot V5] spi: arm-pl022: Add support for ARM PL022 spi controller

2013-06-12 Thread Armando Visconti
This patch adds the support for the ARM PL022 SPI controller for the standard variant (0x00041022), which has a 16bit wide and 8 locations deep TX/RX FIFO. Signed-off-by: Armando Visconti Signed-off-by: Vipin Kumar Acked-by: Stefan Roese --- V4->V5: Changed the commit message to a m

Re: [U-Boot] [u-boot V5] spi: arm-pl022: Add support for ARM PL022 spi controller

2013-06-12 Thread Armando Visconti
On 06/12/2013 10:56 AM, Jagan Teki wrote: Hi, Your patch looks good to me, but the same time I have sent some comments on v4 patch http://patchwork.ozlabs.org/patch/249603/ I think you might respond to above thread before sending v5, may be your missing my earlier comments? Yes, I missed them

Re: [U-Boot] [u-boot V4] spi/arm-pl022: Add support for ARM PL022 spi controller

2013-06-12 Thread Armando Visconti
mando Visconti wrote: This patch adds the support for the ARM PL022 SPI controller for the standard variant (0x00041022), which has a 16bit wide and 8 locations deep TX/RX FIFO. Signed-off-by: Armando Visconti Signed-off-by: Vipin Kumar Acked-by: Stefan Roese --- v3->v4 Just removed all warni

Re: [U-Boot] [u-boot V4] spi/arm-pl022: Add support for ARM PL022 spi controller

2013-06-12 Thread Armando Visconti
return 1; + + return 0; +} If you see return 1 is code block, so prior to this if ends. OK, I'll do it in this way even if it may generate warnings. Give me few mins and I'll send a v6 patch! Thx, Arm -- -- "Every step appears to be the unavoidable consequence

Re: [U-Boot] [u-boot V4] spi/arm-pl022: Add support for ARM PL022 spi controller

2013-06-12 Thread Armando Visconti
Please use the commit header as "spi: pl022_spi: " as you haven't use the same on v5 i guess, please check. OK, Jagan, I'll do it! Armando ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v6] spi: pl022_spi: Add support for ARM PL022 spi controller

2013-06-12 Thread Armando Visconti
This patch adds the support for the ARM PL022 SPI controller for the standard variant (0x00041022), which has a 16bit wide and 8 locations deep TX/RX FIFO. Signed-off-by: Armando Visconti Signed-off-by: Vipin Kumar Acked-by: Stefan Roese --- v5->v6 1. Make use of spi_alloc_slave() macro.

Re: [U-Boot] [PATCH v6] spi: pl022_spi: Add support for ARM PL022 spi controller

2013-06-12 Thread Armando Visconti
nce of the -- preceding one." (A. Einstein) -- Armando Visconti Mobile: (+39) 346 8879146 Senior SW EngineerFax:(+39) 02 93519290 CPG Work: (+39) 02 93519683 Computer System Division e-mail: armando.visco...@st.com ST M

Re: [U-Boot] [PATCH v6] spi: pl022_spi: Add support for ARM PL022 spi controller

2013-06-12 Thread Armando Visconti
But if you prefer to be on safer side I think we need to re-do some checks on a spare 1340 board... OK, maybe it is better to re-check again. I need to find some time and a spare board... I'll let you know, Arm ___ U-Boot mailing list U-Boot@lists

Re: [U-Boot] [PATCH v6] spi: pl022_spi: Add support for ARM PL022 spi controller

2013-06-12 Thread Armando Visconti
On 06/12/2013 05:29 PM, Jagan Teki wrote: On Wed, Jun 12, 2013 at 8:49 PM, Armando Visconti wrote: But if you prefer to be on safer side I think we need to re-do some checks on a spare 1340 board... OK, maybe it is better to re-check again. I need to find some time and a spare board

Re: [U-Boot] [PATCH v6] spi: pl022_spi: Add support for ARM PL022 spi controller

2014-01-08 Thread Armando Visconti
/concerns. On Wed, Jun 12, 2013 at 7:55 PM, Jagan Teki wrote: Thanks for v6 sent. Have you tested this? on which board, include/configs/*.h file? -- Thanks, Jagan. On Wed, Jun 12, 2013 at 6:17 PM, Armando Visconti wrote: This patch adds the support for the ARM PL022 SPI controller for the

Re: [U-Boot] [PATCH 00/46] Enhance spear support

2012-11-30 Thread Armando Visconti
On 11/21/2012 10:24 AM, Wolfgang Denk wrote: Dear Vipin, In message<50a0d0eb.4080...@st.com> you wrote: The ssh key is as below THnaks a lot. The repository should be ready for your use now. Sorry it took so long. Please feel free to contact me directly if there should be any problems.

Re: [U-Boot] [PATCH 00/46] Enhance spear support

2012-11-30 Thread Armando Visconti
On 11/30/2012 01:34 PM, Wolfgang Denk wrote: Dear Armando Visconti, In message<50b89534.6040...@st.com> you wrote: Not sure what are next steps for this patchset. Is someone going to review it, or part of it? Or is Vipin expected to do something on the repository assigned to him (ma

[U-Boot] [PATCH 2/3] designware_i2c: Added s/w generation of stop bit

2012-12-05 Thread Armando Visconti
extra 0x0 byte sent as data, the IC_STOP command must be sent along with the last IC_CMD. This patch always writes bit[9] of ic_data_cmd even in the older versions, assuming that it is a noop there. Signed-off-by: Armando Visconti --- drivers/i2c/designware_i2c.c | 11 --- drivers/i2c

[U-Boot] [PATCH 3/3] designware_i2c: Fixed the setting of the i2c bus speed

2012-12-05 Thread Armando Visconti
There are three couple (hcnt/lcnt) of registers for each speed (SS/FS/HS). The driver needs to set the proper couple of regs according to what speed we are setting. Signed-off-by: Armando Visconti --- drivers/i2c/designware_i2c.c | 28 +--- 1 files changed, 13

[U-Boot] [PATCH 1/3] designware_i2c.c: Added the support for MULTI_BUS

2012-12-05 Thread Armando Visconti
This patch adds the capability to switch between 10 different I2C busses (from 0 to 9). Signed-off-by: Armando Visconti --- drivers/i2c/designware_i2c.c | 82 +- 1 files changed, 81 insertions(+), 1 deletions(-) diff --git a/drivers/i2c

[U-Boot] [PATCH 0/3] I2C designware patches

2012-12-05 Thread Armando Visconti
patch may be included in the work you are preparing on your own repo, but I rebased this work on the Heiko's u-boot-i2c.git repo. Thx, Arm Armando Visconti (3): designware_i2c.c: Added the support for MULTI_BUS designware_i2c: Added s/w generation of stop bit designware_i2c: Fixe

[U-Boot] [PATCH V2 4/5] designware_i2c.h: Fixed the correct values for SCL low/high time

2012-12-06 Thread Armando Visconti
Signed-off-by: Armando Visconti --- drivers/i2c/designware_i2c.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/designware_i2c.h b/drivers/i2c/designware_i2c.h index e004152..0dc8884 100644 --- a/drivers/i2c/designware_i2c.h +++ b/drivers/i2c

[U-Boot] [PATCH V2 5/5] designware_i2c.h: Define IC_CLK only if not already defined in config file

2012-12-06 Thread Armando Visconti
Signed-off-by: Armando Visconti --- drivers/i2c/designware_i2c.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/i2c/designware_i2c.h b/drivers/i2c/designware_i2c.h index 0dc8884..2faf4a8 100644 --- a/drivers/i2c/designware_i2c.h +++ b/drivers/i2c

[U-Boot] [PATCH V2 1/5] designware_i2c.c: Added the support for MULTI_BUS

2012-12-06 Thread Armando Visconti
This patch adds the capability to switch between 10 different I2C busses (from 0 to 9). Signed-off-by: Armando Visconti --- drivers/i2c/designware_i2c.c | 82 +- 1 files changed, 81 insertions(+), 1 deletions(-) diff --git a/drivers/i2c

[U-Boot] [PATCH V2 0/5] I2C designware patches

2012-12-06 Thread Armando Visconti
Changes from V1: Added two patches that I missed to send... Armando Visconti (5): designware_i2c.c: Added the support for MULTI_BUS designware_i2c: Added s/w generation of stop bit designware_i2c: Fixed the setting of the i2c bus speed designware_i2c.h: Fixed the correct values for SCL

[U-Boot] [PATCH V2 3/5] designware_i2c: Fixed the setting of the i2c bus speed

2012-12-06 Thread Armando Visconti
There are three couple (hcnt/lcnt) of registers for each speed (SS/FS/HS). The driver needs to set the proper couple of regs according to what speed we are setting. Signed-off-by: Armando Visconti --- drivers/i2c/designware_i2c.c | 28 +--- 1 files changed, 13

[U-Boot] [PATCH V2 2/5] designware_i2c: Added s/w generation of stop bit

2012-12-06 Thread Armando Visconti
extra 0x0 byte sent as data, the IC_STOP command must be sent along with the last IC_CMD. This patch always writes bit[9] of ic_data_cmd even in the older versions, assuming that it is a noop there. Signed-off-by: Armando Visconti --- drivers/i2c/designware_i2c.c | 11 --- drivers/i2c

Re: [U-Boot] [PATCH resend] spi/arm-pl022: Add support for ARM PL022 spi controller

2012-12-12 Thread Armando Visconti
+ +/* SSP registers mapping */ +#define SSP_CR00x000 +#define SSP_CR10x004 +#define SSP_DR 0x008 +#define SSP_SR 0x00C +#define SSP_CPSR 0x010 +#define SSP_IMSC 0x014 +#define SSP_RIS0x018 +#define SSP_MIS0

Re: [U-Boot] [PATCH v2] spi/arm-pl022: Add support for ARM PL022 spi controller

2012-12-12 Thread Armando Visconti
Ciao Vipin, On 12/12/2012 01:04 PM, Vipin KUMAR wrote: From: Armando Visconti This patch adds the support for the ARM PL022 SPI controller for the standard variant (0x00041022), which has a 16bit wide and 8 locations deep TX/RX FIFO. Have you tested this patch on the new variant as well

Re: [U-Boot] [PATCH v3] spi/arm-pl022: Add support for ARM PL022 spi controller

2012-12-13 Thread Armando Visconti
On 12/13/2012 12:41 PM, Vipin KUMAR wrote: From: Armando Visconti This patch adds the support for the ARM PL022 SPI controller for the standard variant (0x00041022), which has a 16bit wide and 8 locations deep TX/RX FIFO. Signed-off-by: Armando Visconti Signed-off-by: Vipin Kumar --- Changes

Re: [U-Boot] [PATCH resend] armv7/ltimer: Add support for local timer on armv7 cpus

2012-12-17 Thread Armando Visconti
Ciao Vipin, Yes, I agree about the need to have the generic local_timer support in u-boot. Internally I was not able to give comment about this part. So, see my comments now. On 12/06/2012 10:22 AM, Vipin KUMAR wrote: Certain ARMV7 cpus eg. CortexA9 contains a local and a global timer within t

Re: [U-Boot] [PATCH 0/9] Support for SPEAr SoCs

2009-12-16 Thread Armando VISCONTI
All, Just fyi SPEAr is an ARM based family of SoC designed by us here in STMicro. THx for your help in reviewing. Regards, Arm Vipin KUMAR wrote: > This patchset contains the support for 4 SoCs from SPEAr family > SPEAr300 > SPEAr310 > SPEAr320 > SPEAr600 > > It also contains the drivers needed

Re: [U-Boot] [PATCH 5/9] SPEAr600 SoC support added

2009-12-16 Thread Armando VISCONTI
t hurt:) > > Best, > Peter > > ___ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot > -- -- "Every step appears to be the unavoidable consequence of the -- preceding one." (A

Re: [U-Boot] [PATCH v2 0/9] Added support for SPEAr SoCs

2010-01-07 Thread Armando VISCONTI
x27;t create > build/board/spear/spear300/../common/spr_lowlevel_init.o: No such file or > directory > > The way i test MAKEALL is to define the BUILD_DIR to be something that is not > the source directory. Please rerun MAKEALL this way and resolve these errors. > > I will do a more

Re: [U-Boot] [PATCH v5 00/12] Support for SPEAr SoCs

2010-01-19 Thread Armando VISCONTI
63.html >>> >>> >> I saw these comments. >> I did not see any explicit ack's >> > > I thought it was explicit enough... > so again: Acked-by: Remy Bohmer > > Remy > > -- -- "Every step appears to be the unavoidable cons

Re: [U-Boot] [STATUS] Merge Window closed, waiting for pull requests

2010-01-21 Thread Armando VISCONTI
(+49)-8142-66989-80 Email: w...@denx.de >> The faster I go, the behinder I get. -- Lewis Carroll >> ___ >> U-Boot mailing list >> U-Boot@lists.denx.de >> http://lists.denx.de/mailman/listinfo/u-boot >> >> > _

Re: [U-Boot] [PATCH RFC 0/2] dcache on ARM

2010-01-26 Thread Armando VISCONTI
___ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot > -- -- "Every step appears to be the unavoidable consequence of the -- preceding one." (A. Einstein) -- Armando Visconti Mobile: (+39) 346 8879146 Senior

Re: [U-Boot] [PATCH RFC 0/2] dcache on ARM

2010-01-26 Thread Armando VISCONTI
/verify it :-( Thx, Arm -- -- "Every step appears to be the unavoidable consequence of the -- preceding one." (A. Einstein) -- Armando Visconti Mobile: (+39) 346 8879146 Senior SW EngineerFax:(+39) 02 93519290 CPG Work:

[U-Boot] cpu/cortex_a9

2009-10-06 Thread Armando VISCONTI
Dears, I'm not able to find the code for Cortex A9, but in some discussion I saw it is (maybe) planned to be in cpu/cortex_a9. Is this correct? Anyway, can you possibly update me about the current status? Thx, Armando ___ U-Boot mailing list U-Boot

Re: [U-Boot] [PATCH 07/17] SPEAr : Network driver support added

2010-04-23 Thread Armando VISCONTI
Ben, I have a specific question on the way we handle phy address in SPEAr. >> + >> +static u8 find_phy(struct eth_device *dev) >> +{ >> +u8 phy_addr = 0; >> +u16 ctrl, oldctrl; >> + >> +do { >> +eth_mdio_read(dev, phy_addr, PHY_BMCR,&ctrl); >> +oldctrl = ctrl&

Re: [U-Boot] [PATCH 07/17] SPEAr : Network driver support added

2010-04-26 Thread Armando VISCONTI
d a V2 of the driver, which is still in the old way. Vipin, can you possibly provide your comments? Thanks, Arm -- -- "Every step appears to be the unavoidable consequence of the -- preceding one." (A. Einstein) -- Armando Visconti Mobile: (+39) 346 8879146 Senio

[U-Boot] working with the Custodian's GIT

2009-07-07 Thread Armando VISCONTI
Hello everybody, We are a team of developers that would like to post a series of patches for the support in u-boot of a new ARM platform (SPEAr). I have one questions regarding the GIT. Do we really require to have a public GIT repository to publish our work so that others can watch at it? Or i

Re: [U-Boot] [PATCH 00/46] Enhance spear support

2012-11-12 Thread Armando Visconti
Vipin can be the custodian also for other stm devices... Vipin, do you agree with that? Rgds, Arm -- -- "Every step appears to be the unavoidable consequence of the -- preceding one." (A. Einstein) -- Armando Visconti Mobile: (+39) 346 8879146 Senior SW Engineer

[U-Boot] SPEAr (ARM) patchset inclusion for u-boot

2010-06-22 Thread Armando VISCONTI
e/linux/mtd/fsmc_nand.h | 104 >>>>>>> include/netdev.h |1 + >>>>>>> include/usb/{spr_udc.h => designware_udc.h}|6 +- >>>>>>> 56 files changed, 2993 insertions(+), 418 deletions(-) >>>>

Re: [U-Boot] SPEAr (ARM) patchset inclusion for u-boot

2010-06-22 Thread Armando VISCONTI
On 6/22/2010 10:30 PM, Wolfgang Denk wrote: > Dear Armando VISCONTI, > Ciao Wolfgang, > In message<4c20d70c.2050...@st.com> you wrote: > >> As the patchset has already been acked by the proper people >> in the community and since it has been floating a

Re: [U-Boot] SPEAr (ARM) patchset inclusion for u-boot

2010-06-25 Thread Armando VISCONTI
Vipin, > I have already sent a patch v4 specifically for Network subpatches and > got an ack from Ben for both the patches > > Please have a look at > http://www.mail-archive.com/u-boot@lists.denx.de/msg33153.html > http://www.mail-archive.com/u-boot@lists.denx.de/msg33152.html > OK, good. So,

Re: [U-Boot] [PATCH v5 00/18] Network support for spear platforms and SPEAr1300

2010-06-30 Thread Armando VISCONTI
Tom, Wolfgang, THis time everything should be ok. Thks for your attention, Arm Vipin KUMAR wrote: > Dear Wolfgang, Tom, > > The following set of patches is the fifth iteration of patches for the > following > changes > -> Network device driver for synopsys designware peripheral > -> SPEAr1300

Re: [U-Boot] [PATCH 1/2] spi: add support for ARM PL022 SPI controller

2018-08-09 Thread Armando Visconti
were borrowed from the Linux kernel driver. Cc: Armando Visconti Cc: Vipin Kumar Signed-off-by: Quentin Schulz --- Based on "[PATCH v6] spi: pl022_spi: Add support for ARM PL022 spi controller" from Armando Visconti sent about 5 years ago. Modifications: - use readw/writew instea

Re: [U-Boot] [PATCH v6] spi: pl022_spi: Add support for ARM PL022 spi controller

2016-09-14 Thread Armando Visconti
Ciao Michael, On 09/08/2016 04:21 PM, Michael Brandl wrote: Dear U-Boot (SPI) Developers, this patch seems to be my only chance to get spi working without/before Linux. I wrote and used this code for u-boot for a asic specified by one of our customers. The patch was generic enough to be pushe

Re: [U-Boot] [PATCH v6] spi: pl022_spi: Add support for ARM PL022 spi controller

2016-09-19 Thread Armando Visconti
2_spi.o + ifdef CONFIG_DM_SPI obj-y += spi-uclass.o obj-$(CONFIG_SANDBOX) += spi-emul-uclass.o diff --git a/drivers/spi/pl022_spi.c b/drivers/spi/pl022_spi.c index e69de29..e80fed3 100644 --- a/drivers/spi/pl022_spi.c +++ b/drivers/spi/pl022_spi.c @@ -0,0 +1,321 @@ +/* + * (C) Copyright 2012 + * Armand