Re: [U-Boot] dfu: dfu and UBI Volumes

2013-05-28 Thread Benoît Thébaudeau
Dear Pantelis Antoniou, On Tuesday, May 28, 2013 5:05:12 PM, Pantelis Antoniou wrote: > Hi Tom, > > On May 28, 2013, at 6:01 PM, Tom Rini wrote: > > > On Tue, May 28, 2013 at 07:50:46AM +0200, Wolfgang Denk wrote: > >> Dear Tom, > >> > >> In message <20130527233735.GZ17119@bill-the-cat> you wro

Re: [U-Boot] dfu: dfu and UBI Volumes

2013-05-28 Thread Benoît Thébaudeau
Hi Pantelis, On Tuesday, May 28, 2013 6:43:06 PM, Pantelis Antoniou wrote: > Hi Benoît > > On May 28, 2013, at 7:31 PM, Benoît Thébaudeau wrote: > > > Dear Pantelis Antoniou, > > > > On Tuesday, May 28, 2013 5:05:12 PM, Pantelis Antoniou wrote: > >> Hi T

Re: [U-Boot] [PATCH v2 1/6] arm: ensure u-boot only uses relative relocations

2013-05-28 Thread Benoît Thébaudeau
Hi Albert, On Tuesday, May 28, 2013 9:01:46 AM, Albert ARIBAUD wrote: > Add a Makefile target ('checkarmreloc') which > fails of the ELF binary contains relocation records ^ if Sorry to have missed that in my review of v1. > of types other than R_ARM_RELATIVE. The rest of the pa

Re: [U-Boot] [PATCH v2 4/6] arm: make __image_copy_{start, end} compiler-generated

2013-05-28 Thread Benoît Thébaudeau
Hi Albert, On Tuesday, May 28, 2013 9:01:49 AM, Albert ARIBAUD wrote: > This change is only done where needed: some linker > scripts may contain __image_copy_{start,end} yet > remain unchanged. > > Also, __image_copy_end needs its own section; putting > it in relocation sections changes their fla

Re: [U-Boot] [PATCH v4 1/7] arm: vf610: Add IOMUX support for Vybrid VF610

2013-05-28 Thread Benoît Thébaudeau
Hi Alison, On Tuesday, May 28, 2013 10:55:41 AM, Alison Wang wrote: > This patch adds the IOMUX support for Vybrid VF610 platform. > > There is a little difference for IOMUXC module between VF610 and i.MX > platform, the muxmode and pad configuration share one 32bit register on > VF610, but they

Re: [U-Boot] [PATCH v4 2/7] arm: vf610: Add Vybrid VF610 CPU support

2013-05-28 Thread Benoît Thébaudeau
Hi Alison, On Tuesday, May 28, 2013 10:55:42 AM, Alison Wang wrote: > This patch adds generic codes to support Freescale's Vybrid VF610 CPU. > > It aligns Vybrid VF610 platform with i.MX platform. As there are > some differences between VF610 and i.MX platforms, the specific > codes are in the ar

Re: [U-Boot] [PATCH v4 3/7] net: fec_mxc: Add support for Vybrid VF610

2013-05-28 Thread Benoît Thébaudeau
is already done in fec_reg_setup(), so this piece of > code could just leave untouched the FEC_RCNTRL_RGMII / FEC_RCNTRL_RMII / > FEC_RCNTRL_MII_MODE bits. [...] Reviewed-by: Benoît Thébaudeau Best regards, Benoît ___ U-Boot mailing list U-Bo

Re: [U-Boot] [PATCH v4 2/7] arm: vf610: Add Vybrid VF610 CPU support

2013-05-28 Thread Benoît Thébaudeau
Hi Alison, On Tuesday, May 28, 2013 9:16:20 PM, Benoît Thébaudeau wrote: > Hi Alison, > > On Tuesday, May 28, 2013 10:55:42 AM, Alison Wang wrote: > > This patch adds generic codes to support Freescale's Vybrid VF610 CPU. > > > > It aligns Vybrid VF610 platform

Re: [U-Boot] [PATCH v4 7/7] arm: vf610: Add basic support for Vybrid VF610TWR board

2013-05-28 Thread Benoît Thébaudeau
Hi Alison, On Tuesday, May 28, 2013 10:55:47 AM, Alison Wang wrote: > VF610TWR is a board based on Vybrid VF610 SoC. > > This patch adds basic support for Vybrid VF610TWR board. > > Signed-off-by: Alison Wang > Signed-off-by: Jason Jin > Signed-off-by: TsiChung Liew [...] > diff --git a/inc

Re: [U-Boot] [PATCH v4 2/7] arm: vf610: Add Vybrid VF610 CPU support

2013-05-29 Thread Benoît Thébaudeau
Hi Alison, On Wednesday, May 29, 2013 7:37:32 AM, Wang Huan-B18965 wrote: > Hi, Benoit, > > > > > diff --git a/doc/README.vf610 b/doc/README.vf610 new file mode > > > > 100644 index 000..38cf5cf > > > > --- /dev/null > > > > +++ b/doc/README.vf610 > > > > @@ -0,0 +1,10 @@ > > > > +U-Boot for

Re: [U-Boot] [PATCH v4 7/7] arm: vf610: Add basic support for Vybrid VF610TWR board

2013-05-29 Thread Benoît Thébaudeau
> command args > > */ > > > +#define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE > > > + > > > +#define CONFIG_CMD_MEMTEST > > > +#define CONFIG_SYS_MEMTEST_START 0x8001 > > > +#define CONFIG_SYS_MEMTEST_END 0x87C0 > &

Re: [U-Boot] [PATCH v4 1/7] arm: vf610: Add IOMUX support for Vybrid VF610

2013-05-29 Thread Benoît Thébaudeau
ery very long. > > Agree. This is a property of the processor and should be automatically > set. It should not flow into board config file, and having a family of > processor we cannot use ifdef CONFIG_VF610. > > IMHO the patch is ok. > > Acked-by: Stefano Babic I agree: Reviewed-by: Benoît Thébaudeau Best regards, Benoît ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v4 2/7] arm: vf610: Add Vybrid VF610 CPU support

2013-05-31 Thread Benoît Thébaudeau
Hi Stefano, On Friday, May 31, 2013 10:59:03 AM, Stefano Babic wrote: > On 29/05/2013 16:46, Benoît Thébaudeau wrote: > > Hi Alison, > > > > Hi Benoit, > > >>> I have just noticed that this was actually in 6/7. Why are you putting > >>> this i

Re: [U-Boot] [PATCH v4 6/7] arm: vf610: Add Vybrid VF610 to mxc_ocotp document

2013-05-31 Thread Benoît Thébaudeau
ontroller (OCOTP) > on MXC > > This IP can be found on the following SoCs: > + - Vybrid VF610, > - i.MX6. > > Note that this IP is different from albeit similar to the IPs of the same > name Reviewed-by: Benoît Thébaudeau Best regards, Benoît ___

Re: [U-Boot] imx: Vybrid VF610 mac address issue

2013-06-05 Thread Benoît Thébaudeau
Hi Andy, Fabio, On Wednesday, June 5, 2013 11:13:52 PM, Fabio Estevam wrote: > Hi Andy, > > On Wed, Jun 5, 2013 at 5:54 PM, Andy Voltz wrote: > > I recently tried booting the VF610 support on the Tower board, but the mac > > address is reversed in Linux userspace. DHCP/BOOTP seems to work proper

Re: [U-Boot] [PATCH] vf610twr: Drop unneeded 'or' operator

2013-06-05 Thread Benoît Thébaudeau
Hi Fabio, On Wednesday, June 5, 2013 11:17:45 PM, Fabio Estevam wrote: > From: Fabio Estevam > > No need to use the or operator, so just remove it. > > Signed-off-by: Fabio Estevam > --- > board/freescale/vf610twr/vf610twr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --

Re: [U-Boot] imx: Vybrid VF610 mac address issue

2013-06-05 Thread Benoît Thébaudeau
On Wednesday, June 5, 2013 11:16:17 PM, Benoît Thébaudeau wrote: > Hi Andy, Fabio, > > On Wednesday, June 5, 2013 11:13:52 PM, Fabio Estevam wrote: > > Hi Andy, > > > > On Wed, Jun 5, 2013 at 5:54 PM, Andy Voltz wrote: > > > I recently tried booting the VF610

Re: [U-Boot] imx: Vybrid VF610 mac address issue

2013-06-06 Thread Benoît Thébaudeau
Hi Alison, On Thursday, June 6, 2013 5:36:23 AM, Wang Huan-B18965 wrote: > Hi, Benoit, > > > -Original Message- > > From: Benoît Thébaudeau [mailto:benoit.thebaud...@advansee.com] > > Sent: Thursday, June 06, 2013 5:46 AM > > To: Fabio Estevam > >

Re: [U-Boot] [PATCH v3 0/6] Optimize ARM relocation

2013-06-12 Thread Benoît Thébaudeau
/lib/sections.c > > 6. relocate_code is optimized based on the fact that > symbol references are now always valid even before > relcation, and that only R_ARM_RELATIVE relocations > will be met. > > Changes in v3: > - fix commit message typo (of -> if) > - fix com

Re: [U-Boot] [PATCH v2 1/2] doc: README.fuse: Add an example on how to use the fuse API on mx6q

2013-12-21 Thread Benoît Thébaudeau
Hi Fabio, On Friday, December 20, 2013 9:46:37 PM, Fabio Estevam wrote: > From: Fabio Estevam > > When using the fuse API in U-boot user must calculate the 'bank' and 'word' > values. > > Provide a real example on how to calculate such values for the mx6q. > > Signed-off-by: Fabio Estevam > -

Re: [U-Boot] [PATCH v3 1/2] doc: README.fuse: Add an example on how to use the fuse API on mx6q

2013-12-23 Thread Benoît Thébaudeau
or the mx6quad case, please check the "46.5 OCOTP Memory > Map/Register > +Definition" from the "i.MX 6Dual/6Quad Applications Processor Reference > Manual, > +Rev. 1, 04/2013" document. For example, for the MAC fuses we have: > + > +Address: > +21

Re: [U-Boot] [PATCH v5 2/3] arm: make _end compiler-generated

2014-01-30 Thread Benoît Thébaudeau
Hi Albert, On Thursday, January 30, 2014 11:02:46 AM, Albert ARIBAUD wrote: > This prevents references to _end from generating absolute > relocation records. > > This change is binary invariant for ARM targets. > > Signed-off-by: Albert ARIBAUD > --- > > Changes in v5: > - Rebase onto u-boot-a

Re: [U-Boot] Unused video drivers

2015-02-13 Thread Benoît Thébaudeau
Dear Nikita Kiryanov, Fabio, all, On Fri, Feb 13, 2015 at 1:49 PM, Nikita Kiryanov wrote: > I noticed we have a lot of unused video drivers, specifically: > > CONFIG_EXYNOS_PWM_BL > CONFIG_L5F31188 > CONFIG_SED156X > CONFIG_VIDEO_COREBOOT > CONFIG_VIDEO_IMX25LCDC Fabio, do you think that this on

Re: [U-Boot] [PATCH 0/8] zmx25: Add hardware support

2014-08-04 Thread Benoît Thébaudeau
Hi Thomas, On Mon, Aug 4, 2014 at 7:59 AM, Thomas Diener wrote: > Hi folks, > do you have any comments or statements for this patches? You already have received replies to 1, 3, 4 and 8 / 8 in May: http://lists.denx.de/pipermail/u-boot/2014-May/179759.html http://lists.denx.de/pipermail/u-boot/2

[U-Boot] [PATCH] arm: fix missing exception handling

2014-08-19 Thread Benoît Thébaudeau
Commit 41623c9 'arm: move exception handling out of start.S files' missed some linker scripts. Hence, some boards no longer had exception handling linked since this commit. Restore the original behavior by adding the .vectors section to these linker scripts. Signed-off-by: Benoît Théb

Re: [U-Boot] SPL broken on i.mx31 platforms

2014-08-19 Thread Benoît Thébaudeau
Hi Magnus, all, On Fri, Aug 15, 2014 at 7:45 PM, Magnus Lilja wrote: > Hi > > On 13 August 2014 14:01, Helmut Raiger wrote: >> On 08/05/2014 02:32 PM, Magnus Lilja wrote: >>> >>> Hi Fabio, >>> >>> On 5 August 2014 14:28, Fabio Estevam wrote: Hi Magnus, >>> I would expect Helmut t

Re: [U-Boot] [PATCH] arm: fix missing exception handling

2014-08-20 Thread Benoît Thébaudeau
Christian, On Wed, Aug 20, 2014 at 9:21 AM, Christian Riesch wrote: > Benoît, > > On Tue, Aug 19, 2014 at 8:35 PM, Benoît Thébaudeau > wrote: >> Commit 41623c9 'arm: move exception handling out of start.S files' missed >> some >> linker scripts. He

[U-Boot] [PATCH v2] arm: Add missing .vectors section to linker scripts

2014-08-21 Thread Benoît Thébaudeau
Commit 41623c9 'arm: move exception handling out of start.S files' missed some linker scripts. Hence, some boards no longer had exception handling linked since this commit. Restore the original behavior by adding the .vectors section to these linker scripts. Signed-off-by: Benoît Théb

Re: [U-Boot] [PATCH] arm: fix missing exception handling

2014-08-21 Thread Benoît Thébaudeau
On Thu, Aug 21, 2014 at 8:36 AM, Christian Riesch wrote: > Benoît, > > On Wed, Aug 20, 2014 at 12:47 PM, Benoît Thébaudeau > wrote: >> On Wed, Aug 20, 2014 at 9:21 AM, Christian Riesch >> wrote: >>> On Tue, Aug 19, 2014 at 8:35 PM, Benoît Thébaudeau >>&

Re: [U-Boot] [PATCH] mx6: Fix cacheline size

2014-08-21 Thread Benoît Thébaudeau
Hi Fabio, On Thu, Aug 21, 2014 at 9:11 PM, Fabio Estevam wrote: > On Thu, Aug 21, 2014 at 2:14 PM, Marek Vasut wrote: >> On Thursday, August 21, 2014 at 07:10:02 PM, Fabio Estevam wrote: >>> mx6 is an armv7 which has 64-byte cacheline size. >>> >>> Without this fix we are not able to get the FEC

Re: [U-Boot] SPL broken on i.mx31 platforms

2014-09-02 Thread Benoît Thébaudeau
Hi Helmut, all, On Tue, Aug 19, 2014 at 10:55 PM, Benoît Thébaudeau wrote: > On Fri, Aug 15, 2014 at 7:45 PM, Magnus Lilja wrote: >> On 13 August 2014 14:01, Helmut Raiger wrote: >>> On 08/05/2014 02:32 PM, Magnus Lilja wrote: >>>> I would expect Helmut to create

[U-Boot] [PATCH 2/2] arm: Fix _start for CONFIG_SYS_DV_NOR_BOOT_CFG

2014-09-03 Thread Benoît Thébaudeau
definition of the _start symbol after the CONFIG_SYS_DV_NOR_BOOT_CFG word. This new commit fixes this issue by restoring the original behavior, i.e. by defining the _start symbol before the CONFIG_SYS_DV_NOR_BOOT_CFG word. Signed-off-by: Benoît Thébaudeau Cc: Albert Aribaud Cc: Manfred Rudigie

[U-Boot] [PATCH 1/2] arm: Make reset position-independent

2014-09-03 Thread Benoît Thébaudeau
he boot of mx31pdk and tx25. Signed-off-by: Benoît Thébaudeau Reported-by: Helmut Raiger Cc: Albert Aribaud Cc: Magnus Lilja Cc: John Rigby --- arch/arm/lib/vectors.S |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/lib/vectors.S b/arch/arm/lib/vectors.S ind

Re: [U-Boot] [PATCH 1/2] arm: Make reset position-independent

2014-09-03 Thread Benoît Thébaudeau
On Wed, Sep 3, 2014 at 11:32 PM, Benoît Thébaudeau wrote: > Some boards, like mx31pdk and tx25, require the beginning of the SPL > code to be position-independent. For these two boards, this is because > they use the i.MX external NAND boot, which starts by executing the > first NAN

Re: [U-Boot] [PATCH 1/2] arm: Make reset position-independent

2014-09-03 Thread Benoît Thébaudeau
On Wed, Sep 3, 2014 at 11:32 PM, Benoît Thébaudeau wrote: > Some boards, like mx31pdk and tx25, require the beginning of the SPL > code to be position-independent. For these two boards, this is because > they use the i.MX external NAND boot, which starts by executing the > first NAN

Re: [U-Boot] SPL broken on i.mx31 platforms

2014-09-04 Thread Benoît Thébaudeau
Hi Magnus, On Thu, Sep 4, 2014 at 9:12 PM, Magnus Lilja wrote: > On 3 September 2014 03:13, Tom Rini wrote: >> On Wed, Sep 03, 2014 at 02:53:17AM +0200, Benoît Thébaudeau wrote: >>> > IMHO, the 'b reset' and the 'nop nop nop' are two different issue

[U-Boot] [PATCH] part_mac: dcache: allocate cacheline-aligned buffers

2012-07-13 Thread Benoît Thébaudeau
This patch forces the correct alignment for DMA operations of buffers used by part_mac.c. Signed-off-by: Benoît Thébaudeau Cc: Wolfgang Denk --- {u-boot.orig => u-boot}/disk/part_mac.c | 68 +++ 1 file changed, 34 insertions(+), 34 deletions(-) diff --gi

[U-Boot] i.MX dcache issues

2012-07-14 Thread Benoît Thébaudeau
Hi all, Has anyone tested i.MX25 or i.MX35 with dcache on? I'm working with U-Boot 2012.04.01 on several custom platforms using these processors. With dcache off, everything works fine, but slowly. With dcache on, it's much faster (e.g. mtest), but it's impossible to read files through the eSDH

Re: [U-Boot] i.MX dcache issues

2012-07-14 Thread Benoît Thébaudeau
On Sat, Jul 14, 2012 at 11:28:03PM +0200, Benoît Thébaudeau wrote: > Shouldn't the MMC/eSDHC drivers flush/invalidate the dcache ranges > that they use > for DMA operations? Not doing so would explain why stack-allocated > buffers are > more affected than buffers in unused R

Re: [U-Boot] i.MX dcache issues

2012-07-15 Thread Benoît Thébaudeau
On Sun, Jul 15, 2012 at 08:56:35AM +0200, Dirk Behme wrote: > On 15.07.2012 00:08, Benoît Thébaudeau wrote: > > On Sat, Jul 14, 2012 at 11:28:03PM +0200, Benoît Thébaudeau wrote: > >> Shouldn't the MMC/eSDHC drivers flush/invalidate the dcache ranges > >> that they

Re: [U-Boot] i.MX dcache issues

2012-07-15 Thread Benoît Thébaudeau
On 15/07/2012 15:45, Stefano Babic wrote: > On 14/07/2012 23:28, Benoît Thébaudeau wrote: > > Hi all, > > > > Hi, > > > Has anyone tested i.MX25 or i.MX35 with dcache on? > > > > I'm working with U-Boot 2012.04.01 on several custom platforms >

[U-Boot] [PATCH] net: link_local: fix build

2012-07-19 Thread Benoît Thébaudeau
Fix comment within comment build error. Signed-off-by: Benoît Thébaudeau Cc: Joe Hershberger --- .../net/link_local.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git u-boot-66714b1.orig/net/link_local.c u-boot-66714b1/net/link_local.c

[U-Boot] [PATCH] net: bootp: fix build

2012-07-19 Thread Benoît Thébaudeau
Fix NetSetState function name used with CONFIG_BOOTP_MAY_FAIL. Signed-off-by: Benoît Thébaudeau Cc: Joe Hershberger --- .../net/bootp.c|2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git u-boot-66714b1.orig/net/bootp.c u-boot-66714b1/net

[U-Boot] [PATCH] ARM1136: Fix cache range checks

2012-07-19 Thread Benoît Thébaudeau
, and it fixes the interpretation of its return value by other functions. The chosen naming is the same as for ARM926EJ-S in order to be consistent. Signed-off-by: Benoît Thébaudeau Cc: Albert Aribaud --- .../arch/arm/cpu/arm1136/cpu.c |6 +++--- 1 file changed, 3 insertions

Re: [U-Boot] i.MX dcache issues

2012-07-19 Thread Benoît Thébaudeau
Hi all, On Tue, Jul 17, 2012 at 12:30:22AM +0200, Marek Vasut wrote: > Dear Dirk Behme, > > > On 15.07.2012 00:08, Benoît Thébaudeau wrote: > > > On Sat, Jul 14, 2012 at 11:28:03PM +0200, Benoît Thébaudeau > > > wrote: > > >> Shouldn't th

[U-Boot] [PATCH 1/2] net: fec_mxc: Fix setting of RCR for xMII

2012-07-19 Thread Benoît Thébaudeau
that, but there has been no need for it so far. Signed-off-by: Benoît Thébaudeau Cc: Joe Hershberger Cc: Stefano Babic --- .../drivers/net/fec_mxc.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git u-boot-66714b1.orig/drivers/net/fec_mxc

[U-Boot] [PATCH 2/2] net: fec_mxc: Fix MDC for xMII

2012-07-19 Thread Benoît Thébaudeau
The MDC signal is available on all xMII (i.e. 'not 7-wire') interfaces, so mii_speed has to be set for all these interfaces, and not only for MII. Signed-off-by: Benoît Thébaudeau Cc: Joe Hershberger Cc: Stefano Babic --- .../drivers/net/fec_mxc.c |2

[U-Boot] [PATCH 1/5] ehci: cosmetic: Define the number of qt_buffers

2012-07-19 Thread Benoît Thébaudeau
Signed-off-by: Benoît Thébaudeau Cc: Marek Vasut Cc: Ilya Yanok Cc: Stefan Herbrechtsmeier --- .../drivers/usb/host/ehci-hcd.c|4 ++-- .../drivers/usb/host/ehci.h| 11 ++- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git u

[U-Boot] [PATCH 2/5] ehci-hcd: Boost transfer speed

2012-07-19 Thread Benoît Thébaudeau
more than 100 kB for a transfer length of 65535 packets of 512 bytes. Tested on i.MX25 and i.MX35. In my test conditions, the speedup was about 15x using page-aligned buffers, which is really appreciable when accessing large files. Signed-off-by: Benoît Thébaudeau Cc: Marek Vasut Cc: Ilya Yanok

[U-Boot] [PATCH 3/5] usb_storage: Remove EHCI constraints

2012-07-19 Thread Benoît Thébaudeau
Now that the EHCI driver allocates its qTDs from the heap, the MSC driver is only limited by the SCSI commands it uses. Signed-off-by: Benoît Thébaudeau Cc: Marek Vasut Cc: Ilya Yanok Cc: Stefan Herbrechtsmeier --- .../common/usb_storage.c | 31

[U-Boot] [PATCH 4/5] usb_storage: Restore non-EHCI support

2012-07-19 Thread Benoît Thébaudeau
The commit 5dd95cf made the MSC driver EHCI-specific. This patch restores a basic support of non-EHCI HCDs, like before that commit. The fallback transfer size is certainly not optimal, but at least it should work like before. Signed-off-by: Benoît Thébaudeau Cc: Marek Vasut Cc: Ilya Yanok Cc

[U-Boot] [PATCH 5/5] usb_storage: Adjust time-outs

2012-07-19 Thread Benoît Thébaudeau
Adjust time-out value for the new EHCI mechanism. Signed-off-by: Benoît Thébaudeau Cc: Marek Vasut Cc: Ilya Yanok Cc: Stefan Herbrechtsmeier --- .../common/usb_storage.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git u-boot-usb-1b4bd0e.orig

[U-Boot] [PATCH 1/7] FAT: get_fatent: Fix FAT boundary check

2012-07-19 Thread Benoît Thébaudeau
startblock must be taken into account in order not to read past the end of the FAT. Signed-off-by: Benoît Thébaudeau Cc: Wolfgang Denk --- .../fs/fat/fat.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git u-boot-66714b1.orig/fs/fat

[U-Boot] [PATCH 2/7] FAT: cosmetic: Remove useless assignment

2012-07-19 Thread Benoît Thébaudeau
fatlength is not used after this assignment, so it is useless and can be removed. Signed-off-by: Benoît Thébaudeau Cc: Wolfgang Denk --- .../fs/fat/fat.c |1 - 1 file changed, 1 deletion(-) diff --git u-boot-66714b1.orig/fs/fat/fat.c u-boot-66714b1/fs/fat

[U-Boot] [PATCH 3/7] FAT: Fix redundant sector read

2012-07-19 Thread Benoît Thébaudeau
With the previous code, the remaining prefetched sectors were read again after each sector. With this patch, each sector is read only once, thus making the prefetch useful. Signed-off-by: Benoît Thébaudeau Cc: Wolfgang Denk --- .../fs/fat/fat.c | 59

[U-Boot] [PATCH 4/7] FAT: Fix file contents listed as directory

2012-07-19 Thread Benoît Thébaudeau
With: fatls mmc 0 /dir/file dir: regular directory file: regular file The previous code read the contents of file as if it were directory entries to list. This patch refuses to list file contents as if it were a folder. Signed-off-by: Benoît Thébaudeau Cc: Wolfgang Denk --- .../fs/fat/fat.c

[U-Boot] [PATCH 5/7] FAT: get_cluster: Add buffer bouncing

2012-07-19 Thread Benoît Thébaudeau
Add a buffer bouncing mechanism to get_cluster. This can be useful for misaligned applicative buffers passed through get_contents. This is required for the following patches in the case of data aligned differently relatively to buffers and clusters. Signed-off-by: Benoît Thébaudeau Cc: Wolfgang

[U-Boot] [PATCH 6/7] FAT: Simplify get_contents

2012-07-19 Thread Benoît Thébaudeau
One call to get_cluster can be factorized with another, so avoid duplicating code. Signed-off-by: Benoît Thébaudeau Cc: Wolfgang Denk --- .../fs/fat/fat.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git u-boot-66714b1.orig/fs

[U-Boot] [PATCH 7/7] FAT: Make it possible to read from any file position

2012-07-19 Thread Benoît Thébaudeau
read files from a given position. Signed-off-by: Benoît Thébaudeau Cc: Wolfgang Denk --- .../fs/fat/fat.c | 90 1 file changed, 72 insertions(+), 18 deletions(-) diff --git u-boot-66714b1.orig/fs/fat/fat.c u-boot-66714b1/fs/fat/fat.c

Re: [U-Boot] [PATCH 7/7] FAT: Make it possible to read from any file position

2012-07-19 Thread Benoît Thébaudeau
On Friday 20 July 2012 00:44:52 Mike Frysinger wrote: > On Thursday 19 July 2012 18:03:06 Benoît Thébaudeau wrote: > > --- u-boot-66714b1.orig/fs/fat/fat.c > > +++ u-boot-66714b1/fs/fat/fat.c > > > > +__u8 get_contents_vfatname_block[MAX_CLUSTSIZE] > > + __al

Re: [U-Boot] [PATCH 5/7] FAT: get_cluster: Add buffer bouncing

2012-07-19 Thread Benoît Thébaudeau
On Friday 20 July 2012 00:48:26 Mike Frysinger wrote: > On Thursday 19 July 2012 18:02:37 Benoît Thébaudeau wrote: > > + if ((unsigned long)buffer & (ARCH_DMA_MINALIGN - 1)) { > > ALLOC_CACHE_ALIGN_BUFFER(__u8, tmpbuf, mydata->sect_size); > > > >

[U-Boot] [PATCH v2 2/5] ehci-hcd: Boost transfer speed

2012-07-20 Thread Benoît Thébaudeau
more than 100 kB for a transfer length of 65535 packets of 512 bytes. Tested on i.MX25 and i.MX35. In my test conditions, the speedup was about 15x using page-aligned buffers, which is really appreciable when accessing large files. Signed-off-by: Benoît Thébaudeau Cc: Marek Vasut Cc: Ilya Yanok

Re: [U-Boot] [PATCH v2 2/5] ehci-hcd: Boost transfer speed

2012-07-20 Thread Benoît Thébaudeau
On Friday 20 July 2012 13:37:37 Stefan Herbrechtsmeier wrote: > Am 20.07.2012 13:26, schrieb Benoît Thébaudeau: > > + int xfr_bytes = min(left_length, > > + (QT_BUFFER_CNT * 4096 - > > +

[U-Boot] [PATCH v2 1/9] FAT: cosmetic: Remove extra spaces

2012-07-20 Thread Benoît Thébaudeau
Remove spaces before opening parentheses in function calls. Signed-off-by: Benoît Thébaudeau Cc: Wolfgang Denk --- Changes for v2: - New patch for this version of the series. .../fs/fat/fat.c | 44 ++-- 1 file changed, 21 insertions(+), 23

[U-Boot] [PATCH v2 2/8] FAT: get_fatent: Fix FAT boundary check

2012-07-20 Thread Benoît Thébaudeau
startblock must be taken into account in order not to read past the end of the FAT. Signed-off-by: Benoît Thébaudeau Cc: Wolfgang Denk --- Changes for v2: - Patch renumbering because of the new v2 1/8. - Possible code style changes due to the new v2 1/8. .../fs/fat/fat.c

[U-Boot] [PATCH v2 3/8] FAT: cosmetic: Remove useless assignment

2012-07-20 Thread Benoît Thébaudeau
fatlength is not used after this assignment, so it is useless and can be removed. Signed-off-by: Benoît Thébaudeau Cc: Wolfgang Denk --- Changes for v2: - Patch renumbering because of the new v2 1/8. - Possible code style changes due to the new v2 1/8. .../fs/fat/fat.c

[U-Boot] [PATCH v2 4/8] FAT: Fix redundant sector read

2012-07-20 Thread Benoît Thébaudeau
With the previous code, the remaining prefetched sectors were read again after each sector. With this patch, each sector is read only once, thus making the prefetch useful. Signed-off-by: Benoît Thébaudeau Cc: Wolfgang Denk --- Changes for v2: - Patch renumbering because of the new v2 1/8

[U-Boot] [PATCH v2 5/8] FAT: Fix file contents listed as directory

2012-07-20 Thread Benoît Thébaudeau
With: fatls mmc 0 /dir/file dir: regular directory file: regular file The previous code read the contents of file as if it were directory entries to list. This patch refuses to list file contents as if it were a folder. Signed-off-by: Benoît Thébaudeau Cc: Wolfgang Denk --- Changes for v2

[U-Boot] [PATCH v2 6/8] FAT: get_cluster: Add buffer bouncing

2012-07-20 Thread Benoît Thébaudeau
Add a buffer bouncing mechanism to get_cluster. This can be useful for misaligned applicative buffers passed through get_contents. This is required for the following patches in the case of data aligned differently relatively to buffers and clusters. Signed-off-by: Benoît Thébaudeau Cc: Wolfgang

[U-Boot] [PATCH v2 7/8] FAT: Simplify get_contents

2012-07-20 Thread Benoît Thébaudeau
One call to get_cluster can be factorized with another, so avoid duplicating code. Signed-off-by: Benoît Thébaudeau Cc: Wolfgang Denk --- Changes for v2: - Patch renumbering because of the new v2 1/8. - Possible code style changes due to the new v2 1/8. .../fs/fat/fat.c

[U-Boot] [PATCH v2 8/8] FAT: Make it possible to read from any file position

2012-07-20 Thread Benoît Thébaudeau
read files from a given position. Signed-off-by: Benoît Thébaudeau Cc: Wolfgang Denk --- Changes for v2: - Patch renumbering because of the new v2 1/8. - Possible code style changes due to the new v2 1/8. - Add missing vairable renaming to fat_write.c. .../fs/fat/fat.c

Re: [U-Boot] [PATCH v2 1/9] FAT: cosmetic: Remove extra spaces

2012-07-20 Thread Benoît Thébaudeau
Argh, it was 1/8 actually, not 1/9... - Original Message - > From: "Benoît Thébaudeau" > To: u-boot@lists.denx.de > Cc: "Wolfgang Denk" , "Mike Frysinger" > Sent: Friday, July 20, 2012 3:18:44 PM > Subject: [PATCH v2 1/9] FAT: cosmetic:

[U-Boot] [PATCH] md5: Export step-by-step API

2012-07-20 Thread Benoît Thébaudeau
Export the MD5 step-by-step API so that it is possible for the lib users to digest files by chunks. This is especially useful for very large files that would not fit into the embedded RAM. Signed-off-by: Benoît Thébaudeau Cc: Wolfgang Denk --- .../include/u-boot/md5.h

Re: [U-Boot] [PATCH v2 2/5] ehci-hcd: Boost transfer speed

2012-07-20 Thread Benoît Thébaudeau
Dear Marek Vasut, On Friday 20 July 2012 15:44:01 Marek Vasut wrote: > > On Friday 20 July 2012 13:37:37 Stefan Herbrechtsmeier wrote: > > > Am 20.07.2012 13:26, schrieb Benoît Thébaudeau: > > > > + int

[U-Boot] [PATCH] rtc: pcf8563: Make century compatible with Linux

2012-07-20 Thread Benoît Thébaudeau
ort the RTC8564, make this driver compatible with Linux's by giving the opposite meaning to the century bit. Signed-off-by: Benoît Thébaudeau Cc: Wolfgang Denk --- .../drivers/rtc/pcf8563.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[U-Boot] [PATCH] rtc: imxdi: Initial support

2012-07-20 Thread Benoît Thébaudeau
Add support for Freescale's i.MX DryIce RTC, present on i.MX25. Signed-off-by: Benoît Thébaudeau Cc: Wolfgang Denk Cc: Stefano Babic --- .../drivers/rtc/Makefile |1 + /dev/null => u-boot-66714b1/drivers/rtc/imxdi.c| 224 2 files

Re: [U-Boot] [PATCH v2 2/5] ehci-hcd: Boost transfer speed

2012-07-20 Thread Benoît Thébaudeau
On Friday 20 July 2012 16:51:33 Stefan Herbrechtsmeier wrote: > Am 20.07.2012 15:56, schrieb Benoît Thébaudeau: > > Dear Marek Vasut, > > > > On Friday 20 July 2012 15:44:01 Marek Vasut wrote: > >>> On Friday 20 July 2012 13:37:37 Stefan Herbrechtsmeier wrote: &g

Re: [U-Boot] [PATCH v2 2/5] ehci-hcd: Boost transfer speed

2012-07-20 Thread Benoît Thébaudeau
On Friday 20 July 2012 17:15:13 Stefan Herbrechtsmeier wrote: > Am 20.07.2012 17:03, schrieb Benoît Thébaudeau: > > On Friday 20 July 2012 16:51:33 Stefan Herbrechtsmeier wrote: > >> Am 20.07.2012 15:56, schrieb Benoît Thébaudeau: > >>> Dear Marek Vasut, > >>

Re: [U-Boot] [PATCH 1/2] net: fec_mxc: Fix setting of RCR for xMII

2012-07-21 Thread Benoît Thébaudeau
Hi Andy, On Fri, Jul 20, 2012 at 07:35:30AM, Duan Fugang-B38611 wrote: > The changes is reasonable. Thanks! > > Best Regards, > Andy The change for MII_MODE is clear. As to FCE, this can be discussed, and it depends on the hardware support. Actually, fec_open enables full-duplex in TCR regardle

Re: [U-Boot] [PATCH v2 2/5] ehci-hcd: Boost transfer speed

2012-07-23 Thread Benoît Thébaudeau
On Monday 23 July 2012 15:35:25 Stefan Herbrechtsmeier wrote: > Am 20.07.2012 17:35, schrieb Benoît Thébaudeau: > > On Friday 20 July 2012 17:15:13 Stefan Herbrechtsmeier wrote: > >> Am 20.07.2012 17:03, schrieb Benoît Thébaudeau: > >>> On Friday 20 July 2012 16:51:3

Re: [U-Boot] [PATCH 1/2] net: fec_mxc: Fix setting of RCR for xMII

2012-07-23 Thread Benoît Thébaudeau
Hi Andy, On Mon, Jul 23, 2012 at 04:11:22AM, Duan Fugang-B38611 wrote: > With flow control (FCE) feature, it depends on the hardware support. > I.MX serial Ethernet ip (FEC, enet) can support the features, and it > don't need to enable flow control in 100Mbps transition in fact. > As our test resu

Re: [U-Boot] usb_stor_BBB_transport 5 ms delay - performance

2012-07-26 Thread Benoît Thébaudeau
Hi Jim, On Thu, Jul 26, 2012 at 10:20:48 PM, Jim Shimer wrote: > I'm seeing a 5ms delay in usb_stor_BBB_transport, which occurs every > 10K of > data for fatload usb or 500ms of delay per 1MB of image size. This > adds up > to quite a bit of delay if you're loading a large ramdisk. > > Does anyo

Re: [U-Boot] [PATCH 2/5] ehci-hcd: Boost transfer speed

2012-07-27 Thread Benoît Thébaudeau
5. In my test conditions, the speedup was > > about > > 15x using page-aligned buffers, which is really appreciable when > > accessing > > large files. > > > > Signed-off-by: Benoît Thébaudeau > > Cc: Marek Vasut > > Cc: Ilya Yanok > > Cc: St

Re: [U-Boot] [PATCH 4/5] usb_storage: Restore non-EHCI support

2012-07-27 Thread Benoît Thébaudeau
Dear Marek, On Fri, Jul 27, 2012 at 02:55:38 PM, Marek Vasut wrote: > > The commit 5dd95cf made the MSC driver EHCI-specific. This patch > > restores a > > basic support of non-EHCI HCDs, like before that commit. > > > > The fallback transfer size is certainly not optimal, but at least > > it sho

Re: [U-Boot] [PATCH 5/5] usb_storage: Adjust time-outs

2012-07-27 Thread Benoît Thébaudeau
Dear Marek, On Fri, Jul 27, 2012 at 02:56:50 PM, Marek Vasut wrote: > > Adjust time-out value for the new EHCI mechanism. > > > [...] > > Ok, I really like this set. Nice to read. > I believe it's only one or two reposts > away from > upstream and I'd love to have it in next release (not this

Re: [U-Boot] usb_stor_BBB_transport 5 ms delay - performance

2012-07-27 Thread Benoît Thébaudeau
Dear Marek, On Fri, Jul 27, 2012 at 02:59:29 PM, Marek Vasut wrote: > > Hi Jim, > > > > On Thu, Jul 26, 2012 at 10:20:48 PM, Jim Shimer wrote: > > > I'm seeing a 5ms delay in usb_stor_BBB_transport, which occurs > > > every > > > 10K of > > > data for fatload usb or 500ms of delay per 1MB of imag

Re: [U-Boot] [PATCH 2/5] ehci-hcd: Boost transfer speed

2012-07-27 Thread Benoît Thébaudeau
Dear Marek, On Fri, Jul 27, 2012 at 04:01:11 PM, Marek Vasut wrote: > > Do you think > > using PAGE_SIZE from would be fine since these > > 4096 are > > nothing more than page sizes? > > Isn't that intel-specific? I don't know. The code does not say so. What is sure is that page sizes should be

Re: [U-Boot] [PATCH v2 2/5] ehci-hcd: Boost transfer speed

2012-07-27 Thread Benoît Thébaudeau
Dear Marek, On Fri, Jul 27, 2012 at 04:07:01 PM, Marek Vasut wrote: > > + qtd = memalign(USB_DMA_MINALIGN, qtd_count * sizeof(struct qTD)); > > + if (qtd == NULL) { > > + printf("unable to allocate TDs\n"); > > + return -1; > > + } > > + > > memset(qh, 0, sizeof(struc

Re: [U-Boot] usb_stor_BBB_transport 5 ms delay - performance

2012-07-27 Thread Benoît Thébaudeau
Dear Marek, On Fri, Jul 27, 2012 at 04:09:42 PM, Marek Vasut wrote: > [...] > > > > Your suggestion is interesting and might be a complement to my > > > > series. I > > > > don't have time to check its correctness right now, but I'll > > > > try > > > > soon. > > > > > > Will you two have time to

Re: [U-Boot] [PATCH v2 1/9] FAT: cosmetic: Remove extra spaces

2012-07-27 Thread Benoît Thébaudeau
Dear Mike, On Sat, Jul 21, 2012 at 07:23:57 PM, Mike Frysinger wrote: > Acked-by: Mike Frysinger If it's ack'ed, why does nobody apply it? What is the normal life cycle of patches like these that don't have a custodian? Regards, Benoît ___ U-Boot mail

Re: [U-Boot] [PATCH v2 2/5] ehci-hcd: Boost transfer speed

2012-07-28 Thread Benoît Thébaudeau
Dear Stefan, Sorry for the delay. I'm very busy, and there is much to tell on this topic. On Tue, Jul 24, 2012 at 03:02:00 PM, Stefan Herbrechtsmeier wrote: > Am 23.07.2012 19:15, schrieb Benoît Thébaudeau: > > On Monday 23 July 2012 15:35:25 Stefan Herbrechtsmeier wrote: > &g

Re: [U-Boot] [PATCH 2/5] ehci-hcd: Boost transfer speed

2012-07-28 Thread Benoît Thébaudeau
Dear Marek, On Fri, Jul 27, 2012 at 04:13:45 PM, Benoît Thébaudeau wrote: > On Fri, Jul 27, 2012 at 04:01:11 PM, Marek Vasut wrote: > > [...] > > > > > + token = (toggle << 31) | > > > > > + (xfr_bytes <&

Re: [U-Boot] usb_stor_BBB_transport 5 ms delay - performance

2012-07-28 Thread Benoît Thébaudeau
Dear Marek, On Fri, Jul 27, 2012 at 07:44:04 PM, Marek Vasut wrote: > > I did see a flags field but thought having a new one was > > conservative (I > > had no real reason to have a new field). As for the typecasts I > > was > > following the API which tests for device ready (Monkey See Monkey >

Re: [U-Boot] [PATCH 2/5] ehci-hcd: Boost transfer speed

2012-07-29 Thread Benoît Thébaudeau
Dear Marek Vasut, On Sun, Jul 29, 2012 at 03:40:32 AM, Marek Vasut wrote: > > On Fri, Jul 27, 2012 at 04:13:45 PM, Benoît Thébaudeau wrote: > > > On Fri, Jul 27, 2012 at 04:01:11 PM, Marek Vasut wrote: > > > > [...] > > > > > > >

Re: [U-Boot] [PATCH v2 2/5] ehci-hcd: Boost transfer speed

2012-07-30 Thread Benoît Thébaudeau
Dear Marek Vasut, On Tue, Jul 31, 2012 at 12:38:54 AM, Marek Vasut wrote: > [...] > > > > > Can you explain where this gain would come from? In both cases, > > > > the > > > > data in USB > > > > transfers would be organized in the same way, and it would be > > > > accessed in memory > > > > also

Re: [U-Boot] [PATCH v5] Corrupted NAND Flash access on KARO TX25 modules.

2012-08-02 Thread Benoît Thébaudeau
Dear Daniel, On Thu, Aug 2, 2012 at 01:17:07 PM, Daniel Gachet wrote: > The mxc_nand driver uses the symmetric mode to access the NAND Flash, > but the > devices populated on the KARO TX25 only support ann asymmetic mode > (MX25: bit 8 within NAND_FLAHS_CONFIG1 register cleared). > > This patch e

Re: [U-Boot] [PATCH v5] Corrupted NAND Flash access on KARO TX25 modules.

2012-08-02 Thread Benoît Thébaudeau
Dear Daniel, Scott, On Thu, Aug 2, 2012 at 01:28:08 PM, Benoît Thébaudeau wrote: > On Thu, Aug 2, 2012 at 01:17:07 PM, Daniel Gachet wrote: > > The mxc_nand driver uses the symmetric mode to access the NAND > > Flash, > > but the > > devices populated on the KARO TX25

Re: [U-Boot] [PATCH v5] Corrupted NAND Flash access on KARO TX25 modules.

2012-08-03 Thread Benoît Thébaudeau
Dear Daniel, Scott, On Thu, Aug 2, 2012 at 03:55:51 PM, Benoît Thébaudeau wrote: > On Thu, Aug 2, 2012 at 01:28:08 PM, Benoît Thébaudeau wrote: > > On Thu, Aug 2, 2012 at 01:17:07 PM, Daniel Gachet wrote: > > > The mxc_nand driver uses the symmetric mode to access the NAND >

Re: [U-Boot] [PATCH v2 2/5] ehci-hcd: Boost transfer speed

2012-08-03 Thread Benoît Thébaudeau
Dear Marek Vasut, On Tue, Jul 31, 2012 at 03:06:00 AM, Benoît Thébaudeau wrote: > > > Marek, what do you think? > > > > Had a good evening with the EHCI r10 spec, hope I answered most of > > your > > questions. > > Yes, thanks. Sorry again for the del

Re: [U-Boot] [PATCH] part_mac: dcache: allocate cacheline-aligned buffers

2012-08-03 Thread Benoît Thébaudeau
On Fri, Jul 13, 2012 at 09:31:03 PM, Benoît Thébaudeau wrote: > This patch forces the correct alignment for DMA operations of buffers > used by > part_mac.c. > > Signed-off-by: Benoît Thébaudeau > Cc: Wolfgang Denk > --- > {u-boot.orig => u-b

  1   2   3   4   5   6   7   8   9   10   >