Re: [U-Boot] [PATCH] ARM: aspeed: Add SD host controller driver

2019-08-13 Thread Eddie James
drivers for Aspeed chips. Signed-off-by: Eddie James --- arch/arm/include/asm/arch-aspeed/scu_ast2500.h | 3 + arch/arm/include/asm/gpio.h| 3 +- arch/arm/mach-aspeed/ast2500-board.c | 3 + drivers/clk/aspeed/clk_ast2500.c | 27 + drivers

[U-Boot] [PATCH v2 2/4] mmc: Add Aspeed SD controller driver

2019-08-13 Thread Eddie James
Add support for the Aspeed SD host controller engine. Signed-off-by: Eddie James --- drivers/mmc/Kconfig| 11 +++ drivers/mmc/Makefile | 1 + drivers/mmc/aspeed_sdhci.c | 78 ++ 3 files changed, 90 insertions(+) create mode 100644

[U-Boot] [PATCH v2 0/4] ARM: aspeed: Add SD host controller driver

2019-08-13 Thread Eddie James
This series adds support for the SD host controller on Aspeed ast2XXX SocS. It also enables MMC and the SD controller on the ast2500 EVB. Changes since v1: - split the patch up - Add defconfig and dts changes Eddie James (4): clk: aspeed: Add support for SD clock mmc: Add Aspeed SD

[U-Boot] [PATCH v2 1/4] clk: aspeed: Add support for SD clock

2019-08-13 Thread Eddie James
Add code to enable the SD clock on the ast2500 SoC. Signed-off-by: Eddie James --- arch/arm/include/asm/arch-aspeed/scu_ast2500.h | 3 +++ drivers/clk/aspeed/clk_ast2500.c | 27 ++ drivers/pinctrl/aspeed/pinctrl_ast2500.c | 2 ++ 3 files changed, 32

[U-Boot] [PATCH v2 4/4] ARM: dts: ast2500: Add SDHCI nodes

2019-08-13 Thread Eddie James
Add nodes for the Aspeed SD controllers with their necessary properties. Signed-off-by: Eddie James --- arch/arm/dts/ast2500-evb.dts | 14 ++ arch/arm/dts/ast2500-u-boot.dtsi | 16 2 files changed, 30 insertions(+) diff --git a/arch/arm/dts/ast2500-evb.dts b

[U-Boot] [PATCH v2 3/4] aspeed: Support SD controller on the ast2500 board

2019-08-13 Thread Eddie James
Initialize the MMC subsystem on the ast2500 board. Compile MMC and the Aspeed SD controller on the ast2500 EVB. Signed-off-by: Eddie James --- arch/arm/include/asm/gpio.h | 3 ++- arch/arm/mach-aspeed/ast2500-board.c | 3 +++ configs/evb-ast2500_defconfig| 6 ++ 3 files

[U-Boot] [PATCH v3 3/4] configs: AST2500 EVB: Enable SD controller

2019-08-15 Thread Eddie James
Enable the MMC subsystem and the Aspeed SD controller. Also enable the use of the device tree for probing the controller. Signed-off-by: Eddie James --- configs/evb-ast2500_defconfig | 8 1 file changed, 8 insertions(+) diff --git a/configs/evb-ast2500_defconfig b/configs/evb

[U-Boot] [PATCH v3 0/4] ARM: Aspeed: Add SD host controller driver

2019-08-15 Thread Eddie James
in the driver probe function Changes since v1: - Split the patch up - Add defconfig and devicetree changes Eddie James (4): clk: aspeed: Add support for SD clock mmc: Add Aspeed SD controller driver configs: AST2500 EVB: Enable SD controller ARM: dts: ast2500: Add SDHCI nodes arch/arm

[U-Boot] [PATCH v3 1/4] clk: aspeed: Add support for SD clock

2019-08-15 Thread Eddie James
Add code to enable the SD clock on the ast2500 SoC. Reviewed-by: Cédric Le Goater Signed-off-by: Eddie James --- arch/arm/include/asm/arch-aspeed/scu_ast2500.h | 3 +++ drivers/clk/aspeed/clk_ast2500.c | 27 ++ drivers/pinctrl/aspeed/pinctrl_ast2500.c

Re: [U-Boot] [PATCH v2 2/4] mmc: Add Aspeed SD controller driver

2019-08-15 Thread Eddie James
On 8/14/19 10:18 AM, Cédric Le Goater wrote: On 13/08/2019 21:31, Eddie James wrote: Add support for the Aspeed SD host controller engine. It looks correct and simple enough. Some comments below. Signed-off-by: Eddie James --- drivers/mmc/Kconfig| 11 +++ drivers/mmc

Re: [U-Boot] [PATCH v2 3/4] aspeed: Support SD controller on the ast2500 board

2019-08-15 Thread Eddie James
On 8/14/19 10:23 AM, Cédric Le Goater wrote: On 13/08/2019 21:31, Eddie James wrote: Initialize the MMC subsystem on the ast2500 board. Compile MMC and the Aspeed SD controller on the ast2500 EVB. Signed-off-by: Eddie James --- arch/arm/include/asm/gpio.h | 3 ++- arch/arm/mach

[U-Boot] [PATCH v3 4/4] ARM: dts: ast2500: Add SDHCI nodes

2019-08-15 Thread Eddie James
Add nodes for the Aspeed SD controllers with their necessary properties. Reviewed-by: Cédric Le Goater Signed-off-by: Eddie James --- arch/arm/dts/ast2500-evb.dts | 14 ++ arch/arm/dts/ast2500-u-boot.dtsi | 16 2 files changed, 30 insertions(+) diff --git

[U-Boot] [PATCH v3 2/4] mmc: Add Aspeed SD controller driver

2019-08-15 Thread Eddie James
Add support for the Aspeed SD host controller engine. Signed-off-by: Eddie James --- arch/arm/include/asm/gpio.h | 3 +- drivers/mmc/Kconfig | 11 ++ drivers/mmc/Makefile| 1 + drivers/mmc/aspeed_sdhci.c | 90 + 4 files changed

[U-Boot] [PATCH] ARM: aspeed: Add SD host controller driver

2019-08-12 Thread Eddie James
Add support for the Aspeed SD host controller engine. This involves adding an MMC SDHCI driver and various additions to the clock and reset drivers for Aspeed chips. Signed-off-by: Eddie James --- arch/arm/include/asm/arch-aspeed/scu_ast2500.h | 3 + arch/arm/include/asm/gpio.h

[U-Boot] [PATCH v4 2/4] mmc: Add Aspeed SD controller driver

2019-08-27 Thread Eddie James
Add support for the Aspeed SD host controller engine. Signed-off-by: Eddie James Reviewed-by: Cédric Le Goater --- Changes since v3: - Rebase on master arch/arm/include/asm/gpio.h | 3 +- drivers/mmc/Kconfig | 11 ++ drivers/mmc/Makefile| 1 + drivers/mmc/aspeed_sdhci.c

Re: [U-Boot] [PATCH v3 2/4] mmc: Add Aspeed SD controller driver

2019-08-27 Thread Eddie James
support for the Aspeed SD host controller engine. Signed-off-by: Eddie James --- arch/arm/include/asm/gpio.h | 3 +- drivers/mmc/Kconfig | 11 ++ drivers/mmc/Makefile| 1 + drivers/mmc/aspeed_sdhci.c | 90 + 4 files changed, 104