Re: [PATCH v3 1/3] fdtdec: optionally add property no-map to created reserved memory node

2020-09-04 Thread Etienne Carriere
Hello Heinrich, On Tue, 25 Aug 2020 at 16:50, Heinrich Schuchardt wrote: > > On 25.08.20 13:42, Patrice Chotard wrote: > > From: Etienne Carriere > > > > Add boolean input argument @no_map to helper function > > fdtdec_add_reserved_memory() to add "no-map&

Re: [PATCH v3 3/8] firmware: scmi: support Arm SMCCC transport

2020-09-09 Thread Etienne Carriere
On Tue, 8 Sep 2020 at 17:21, Simon Glass wrote: > > Hi Etienne, > > On Mon, 7 Sep 2020 at 08:50, Etienne Carriere > wrote: > > > > This change implements a SMCCC transport for SCMI exchanges. This > > implementation follows the Linux kernel as references im

Re: [PATCH v3 6/8] firmware: scmi: sandbox test for SCMI clocks

2020-09-09 Thread Etienne Carriere
On Tue, 8 Sep 2020 at 17:21, Simon Glass wrote: > > Hi Etienne, > > On Mon, 7 Sep 2020 at 08:50, Etienne Carriere > wrote: > > > > Add tests for SCMI clocks. A test device driver sandbox-scmi_devices.c > > is used to get clock resources, allowing further c

Re: [PATCH v3 2/8] firmware: scmi: mailbox/smt agent device

2020-09-09 Thread Etienne Carriere
On Tue, 8 Sep 2020 at 17:21, Simon Glass wrote: > > Hi Etienne, > > On Mon, 7 Sep 2020 at 08:50, Etienne Carriere > wrote: > > > > This change implements a mailbox transport using SMT format for SCMI > > exchanges. This implementation follows the Lin

[PATCH v4 2/8] firmware: scmi: mailbox/smt agent device

2020-09-09 Thread Etienne Carriere
are defined in the Linux kernel DT bindings since v4.17. Links: [1] https://github.com/ARM-software/SCP-firmware Signed-off-by: Etienne Carriere Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla --- Changes in v4: - Replace __arm__ with CONFIG_ARM. - Remove cast for priv reference hence remove

[PATCH v4 3/8] firmware: scmi: support Arm SMCCC transport

2020-09-09 Thread Etienne Carriere
DT bindings since v5.8. SMCCC with SMT is implemented in OP-TEE from tag 3.9.0 [2]. Links: [2] https://github.com/OP-TEE/optee_os/commit/a58c4d706d23 Signed-off-by: Etienne Carriere Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla --- Changes in v4: - Update CONFIG_SCMI_FIRMWARE dependencies

[PATCH v4 1/8] firmware: add SCMI agent uclass

2020-09-09 Thread Etienne Carriere
in the Linux kernel source tree regarding SCMI agent description since v5.8. Links: [1] https://developer.arm.com/architectures/system-architectures/software-standards/scmi Signed-off-by: Etienne Carriere Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla Reviewed-by: Simon Glass --- Changes

Re: [PATCH v3 6/8] firmware: scmi: sandbox test for SCMI clocks

2020-09-09 Thread Etienne Carriere
On Wed, 9 Sep 2020 at 16:35, Simon Glass wrote: > > Hi Etienne, > > On Wed, 9 Sep 2020 at 03:58, Etienne Carriere > wrote: > > > > On Tue, 8 Sep 2020 at 17:21, Simon Glass wrote: > > > > > > Hi Etienne, > > > > > > On Mon, 7 Sep 20

[PATCH v4 6/8] firmware: scmi: sandbox test for SCMI clocks

2020-09-09 Thread Etienne Carriere
with load/remove test sequences factorized by {load|remove}_sandbox_scmi_test_devices() helper functions. Signed-off-by: Etienne Carriere Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla --- Changes in v4: - Move SCMI test devices instances from BSS to test device private data and update test/dm

[PATCH v4 7/8] reset: add reset controller driver for SCMI agents

2020-09-09 Thread Etienne Carriere
. If enabled, CONFIG_SCMI_AGENT is also enabled. SCMI Reset Domain protocol is defined in the SCMI specification [1]. Links: [1] https://developer.arm.com/architectures/system-architectures/software-standards/scmi Signed-off-by: Etienne Carriere Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla

[PATCH v4 4/8] dt-bindings: arm: SCMI bindings documentation

2020-09-09 Thread Etienne Carriere
Dump SCMI DT bindings documentation from Linux kernel source tree v5.8-rc1. Signed-off-by: Etienne Carriere Reviewed-by: Simon Glass --- No change in v4. No change in v3. Changes in v2: - No change but added R-b tag. - Yet a question: do we need to add this binding doc in U-Boot since

[PATCH v4 8/8] firmware: smci: sandbox test for SCMI reset controllers

2020-09-09 Thread Etienne Carriere
-off-by: Etienne Carriere Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla --- Changes in v4: - Rebase in the series without major conflict. - Rename test/dm/scmi.c local variables rc to ret for consistency. Changes in v3: - New commit in the series, addresses review comments on test support

[PATCH v4 5/8] clk: add clock driver for SCMI agents

2020-09-09 Thread Etienne Carriere
enabled. SCMI Clock protocol is defined in the SCMI specification [1]. Links: [1] https://developer.arm.com/architectures/system-architectures/software-standards/scmi Signed-off-by: Etienne Carriere Cc: Lukasz Majewski Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla --- Changes in v4

[PATCH v3 6/8] firmware: scmi: sandbox test for SCMI clocks

2020-09-07 Thread Etienne Carriere
with load/remove test sequences factorized by {load|remove}_sandbox_scmi_test_devices() helper functions. Signed-off-by: Etienne Carriere Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla --- Changes in v3: - New commit in the series, addresses review comments on test support. ut_dm_scmi_clocks

[PATCH v3 7/8] reset: add reset controller driver for SCMI agents

2020-09-07 Thread Etienne Carriere
. If enabled, CONFIG_SCMI_AGENT is also enabled. SCMI Reset Domain protocol is defined in the SCMI specification [1]. Links: [1] https://developer.arm.com/architectures/system-architectures/software-standards/scmi Signed-off-by: Etienne Carriere Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla

[PATCH v3 5/8] clk: add clock driver for SCMI agents

2020-09-07 Thread Etienne Carriere
enabled. SCMI Clock protocol is defined in the SCMI specification [1]. Links: [1] https://developer.arm.com/architectures/system-architectures/software-standards/scmi Signed-off-by: Etienne Carriere Cc: Lukasz Majewski Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla --- Changes in v3: Changes

[PATCH v3 8/8] firmware: smci: sandbox test for SCMI reset controllers

2020-09-07 Thread Etienne Carriere
-off-by: Etienne Carriere Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla --- Changes in v3: - New commit in the series, addresses review comments on test support. ut_dm_scmi_resets() tests SCMI resources are found and behave as expected for the implemented reset uclass methods. --- arch

[PATCH v3 3/8] firmware: scmi: support Arm SMCCC transport

2020-09-07 Thread Etienne Carriere
DT bindings since v5.8. SMCCC with SMT is implemented in OP-TEE from tag 3.9.0 [2]. Links: [2] https://github.com/OP-TEE/optee_os/commit/a58c4d706d23 Signed-off-by: Etienne Carriere Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla --- Changes in v3: - This is a followup of the SCMI agent patches

[PATCH v3 4/8] dt-bindings: arm: SCMI bindings documentation

2020-09-07 Thread Etienne Carriere
Dump SCMI DT bindings documentation from Linux kernel source tree v5.8-rc1. Signed-off-by: Etienne Carriere Reviewed-by: Simon Glass --- No change in v3. Changes in v2: - No change but added R-b tag. - Yet a question: do we need to add this binding doc in U-Boot since already existing

Re: [RFC PATCH 0/7]

2020-09-07 Thread Etienne Carriere
On Fri, 4 Sep 2020 at 14:25, Ard Biesheuvel wrote: > > On Fri, 4 Sep 2020 at 13:51, Patrick Delaunay wrote: > > > > arm: cache: cp15: don't map reserved region with no-map property > > > > Hi, > > > > On STM32MP15x platform we can use OP-TEE, loaded in DDR in a region > > protected > > by a

[PATCH v3 1/8] firmware: add SCMI agent uclass

2020-09-07 Thread Etienne Carriere
in the Linux kernel source tree regarding SCMI agent description since v5.8. Links: [1] https://developer.arm.com/architectures/system-architectures/software-standards/scmi Signed-off-by: Etienne Carriere Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla --- Changes in v3: - Address comments

[PATCH v3 2/8] firmware: scmi: mailbox/smt agent device

2020-09-07 Thread Etienne Carriere
are defined in the Linux kernel DT bindings since v4.17. Links: [1] https://github.com/ARM-software/SCP-firmware Signed-off-by: Etienne Carriere Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla --- Changes in v3: - This is a followup of the SCMI agent patches posted in https

Re: [Uboot-stm32] [PATCH 0/7] arm: cache: cp15: don't map reserved region with no-map property

2020-10-07 Thread Etienne Carriere
Hello all, On Wed, 7 Oct 2020 at 15:16, Ard Biesheuvel wrote: > > On Wed, 7 Oct 2020 at 13:53, Ahmad Fatoum wrote: > > > > Hello, > > > > On 10/7/20 1:23 PM, Ahmad Fatoum wrote: > > > My findings[1] back then were that U-Boot did set the eXecute Never bit > > > only on > > > OMAP, but not for

Re: [Uboot-stm32] [PATCH 0/7] arm: cache: cp15: don't map reserved region with no-map property

2020-10-07 Thread Etienne Carriere
On Wed, 7 Oct 2020 at 17:08, Ard Biesheuvel wrote: > > On Wed, 7 Oct 2020 at 16:55, Etienne Carriere > wrote: > > > > Hello all, > > > > On Wed, 7 Oct 2020 at 15:16, Ard Biesheuvel wrote: > > > > > > On Wed, 7 Oct 2020 at 13:53, Ahmad Fatoum

Re: [Uboot-stm32] [PATCH 0/7] arm: cache: cp15: don't map reserved region with no-map property

2020-10-12 Thread Etienne Carriere
On Fri, 9 Oct 2020 at 19:13, Ahmad Fatoum wrote: > > Hello Patrick, > > On 10/9/20 5:52 PM, Patrick DELAUNAY wrote: > > I checked DACR behavior and CheckDomain / CheckPermission > > > > In my case the cortex A7 try to access to part of DDR / mapped cacheable > > and bufferable, protected by

Re: [Uboot-stm32] [PATCH 0/7] arm: cache: cp15: don't map reserved region with no-map property

2020-10-12 Thread Etienne Carriere
On Mon, 12 Oct 2020 at 11:20, Ard Biesheuvel wrote: > > On Mon, 12 Oct 2020 at 11:09, Etienne Carriere > wrote: > > > > On Fri, 9 Oct 2020 at 19:13, Ahmad Fatoum wrote: > > > > > > Hello Patrick, > > > > > > On 10/9/20 5:52 PM

Re: [PATCH v2 1/4] firmware: add new driver for SCMI firmwares

2020-08-23 Thread Etienne Carriere
Hello Simon, > > This change introduces SCMI agent driver in U-Boot in the firmware > > U-class. > > (...) > > Changes in v2: > > (...) > > > > Note: review comments on defining a uclass and sandbox for SCMI > > transport drivers are NOT addressed in this v2. Main issue is that > > there is no

Re: [PATCH 3/4] clk: add clock driver for SCMI agents

2020-08-18 Thread Etienne Carriere
Hello Simon and all, On Sun, 26 Jul 2020 at 16:54, Simon Glass wrote: > > Hi Etienne, > > On Fri, 17 Jul 2020 at 09:43, Etienne Carriere > wrote: > > > > This change introduces a clock driver for SCMI agent devices. When > > SCMI agent and SCMI clock driv

Re: [PATCH v2 1/4] firmware: add new driver for SCMI firmwares

2020-08-18 Thread Etienne Carriere
Hello Sudeep, On Tue, 18 Aug 2020 at 17:44, Etienne Carriere wrote: > > This change introduces SCMI agent driver in U-Boot in the firmware > U-class. > (...) > --- a/drivers/firmware/Kconfig > +++ b/drivers/firmware/Kconfig > @@ -1,6 +1,26 @@ > config FIRMWARE >

[PATCH v2 1/4] firmware: add new driver for SCMI firmwares

2020-08-18 Thread Etienne Carriere
will implement dedicated driver (i.e. an SCMI clock driver or an SCMI reset controller driver) and add bind supported SCMI protocols in scmi_agent_bind(). Links: [1] https://developer.arm.com/architectures/system-architectures/software-standards/scmi Signed-off-by: Etienne Carriere Cc: Simon Glass Cc

[PATCH v2 4/4] reset: add reset controller driver for SCMI agents

2020-08-18 Thread Etienne Carriere
. If enabled, CONFIG_SCMI_AGENT is also enabled. SCMI Reset Domain protocol is defined in the SCMI specification [1]. Links: [1] https://developer.arm.com/architectures/system-architectures/software-standards/scmi Signed-off-by: Etienne Carriere Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla

[PATCH v2 3/4] clk: add clock driver for SCMI agents

2020-08-18 Thread Etienne Carriere
enabled. SCMI Clock protocol is defined in the SCMI specification [1]. Links: [1] https://developer.arm.com/architectures/system-architectures/software-standards/scmi Signed-off-by: Etienne Carriere Cc: Lukasz Majewski Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla --- Changes in v2

[PATCH v2 2/4] dt-bindings: arm: SCMI bindings documentation

2020-08-18 Thread Etienne Carriere
Dump SCMI DT bindings documentation from Linux kernel source tree v5.8-rc1. Signed-off-by: Etienne Carriere Reviewed-by: Simon Glass --- Changes in v2: - No change but added R-b tag. - Yet a question: do we need to add this binding doc in U-Boot since already existing in Linux DT bindings

Re: STM32MP1: Adding TF-A causes kernel errors

2020-09-30 Thread Etienne Carriere
Hi Yann, Tom and all, On Wed, 30 Sep 2020 at 15:06, Tom Rini wrote: > > On Wed, Sep 30, 2020 at 12:03:06PM +0200, Marek Vasut wrote: > > On 9/30/20 11:51 AM, Jan Kiszka wrote: > > > [BCC'ed TF-A only, migrating to u-boot, including folks involved there] > > > > > > On 30.09.20 11:20, Yann

Re: [PATCH 1/4] firmware: add new driver for SCMI firmwares

2020-08-04 Thread Etienne Carriere
Hello Simon, Thanks for the feedback, I'll fix the changes in my v2. and sorry for these delayed answers. On Sun, 26 Jul 2020 at 16:55, Simon Glass wrote: > > Hi Etienne, > > On Fri, 17 Jul 2020 at 09:38, Etienne Carriere > wrote: > > > > This change introduces

Re: [PATCH 3/4] clk: add clock driver for SCMI agents

2020-07-24 Thread Etienne Carriere
Hi Peng, On Mon, 20 Jul 2020 at 04:06, Peng Fan wrote: > > > > Subject: [PATCH 3/4] clk: add clock driver for SCMI agents > > > > This change introduces a clock driver for SCMI agent devices. When SCMI > > agent and SCMI clock drivers are enabled, SCMI agent binds a clock device > > for > >

Re: [PATCH 1/4] firmware: add new driver for SCMI firmwares

2020-07-24 Thread Etienne Carriere
midata=02%7C01%7Cpeng.fan%40nxp.com%7C39c55064be5 > > 04bf248a708d82a6775cd%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7 > > C0%7C637305971142916174sdata=5kCgz3kzzk4qHy598u79zz3hV17yV > > zdPxM531sOAnUs%3Dreserved=0 > > Signed-off-by: Etienne Carriere > > --- >

Re: [PATCH 2/4] dt-bindings: arm: SCMI bindings documentation

2020-07-24 Thread Etienne Carriere
v2. Thanks, Etienne > Regards, > Peng. > > > > > Dump SCMI DT bindings documentation from Linux kernel source tree > > v5.8-rc1. > > > > Signed-off-by: Etienne Carriere > > --- > > > > doc/device-tree-bindings/arm/arm,scmi.txt | 197 >

[PATCH 3/4] clk: add clock driver for SCMI agents

2020-07-17 Thread Etienne Carriere
enabled. SCMI Clock protocol is defined in the SCMI specification [1]. Links: [1] https://developer.arm.com/architectures/system-architectures/software-standards/scmi Signed-off-by: Etienne Carriere --- drivers/clk/Kconfig | 8 +++ drivers/clk/Makefile| 1 + drivers/clk/clk_scmi.c

[PATCH 2/4] dt-bindings: arm: SCMI bindings documentation

2020-07-17 Thread Etienne Carriere
Dump SCMI DT bindings documentation from Linux kernel source tree v5.8-rc1. Signed-off-by: Etienne Carriere --- doc/device-tree-bindings/arm/arm,scmi.txt | 197 ++ 1 file changed, 197 insertions(+) create mode 100644 doc/device-tree-bindings/arm/arm,scmi.txt diff --git

[PATCH 1/4] firmware: add new driver for SCMI firmwares

2020-07-17 Thread Etienne Carriere
will implement dedicated driver (i.e. an SCMI clock driver or an SCMI reset controller driver) and add bind supported SCMI protocols in scmi_agent_bind(). Links: [1] https://developer.arm.com/architectures/system-architectures/software-standards/scmi Signed-off-by: Etienne Carriere --- drivers

[PATCH 4/4] reset: add reset controller driver for SCMI agents

2020-07-17 Thread Etienne Carriere
. If enabled, CONFIG_SCMI_AGENT is also enabled. SCMI Reset Domain protocol is defined in the SCMI specification [1]. Links: [1] https://developer.arm.com/architectures/system-architectures/software-standards/scmi Signed-off-by: Etienne Carriere --- drivers/firmware/scmi.c| 3 ++ drivers

[PATCH] lib/efi_loader: fix ABI in efi_mm_communicate_header

2020-11-21 Thread Etienne Carriere
/MmCommunication.h#L21 Fixes: 23a397d2e2fb ("efi_loader: Add headers for EDK2 StandAloneMM communication") Signed-off-by: Etienne Carriere --- include/mm_communication.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/mm_communication.h b/include/mm_communication.h index

Re: stm32mp: The purpose of "!tee_find_device()"

2020-11-03 Thread Etienne Carriere
On Tue, 3 Nov 2020 at 16:53, Alex G. wrote: > > On 10/30/20 3:28 AM, Etienne Carriere wrote: > > On Thu, 29 Oct 2020 at 15:33, Alex G. wrote: > >> > >> On 9/30/20 6:03 PM, Alex G. wrote: > >>> Hi > >>> > >>> I'

Re: [Uboot-stm32] [PATCH 0/7] arm: cache: cp15: don't map reserved region with no-map property

2020-10-29 Thread Etienne Carriere
> > > when ‘100’ UNPREDICTABLE; > > > > when ‘101’ abort = !ispriv || iswrite; > > > > when ‘110’ abort = iswrite; > > > > when

Re: stm32mp: The purpose of "!tee_find_device()"

2020-10-30 Thread Etienne Carriere
On Thu, 29 Oct 2020 at 15:33, Alex G. wrote: > > On 9/30/20 6:03 PM, Alex G. wrote: > > Hi > > > > I'm trying to wrap my head around the purpose of the following lines in > > ft_system_setup(): > > > > if (!CONFIG_IS_ENABLED(OPTEE) || > > !tee_find_device(NULL, NULL, NULL, NULL)) >

Re: stm32mp: The purpose of "!tee_find_device()"

2020-11-04 Thread Etienne Carriere
Hi Alex, On Wed, 4 Nov 2020 at 20:55, Alex G. wrote: > > > > On 11/4/20 1:07 AM, Etienne Carriere wrote: > > On Tue, 3 Nov 2020 at 16:53, Alex G. wrote: > >> > >> On 10/30/20 3:28 AM, Etienne Carriere wrote: > >>> On Thu, 29 Oct 2020 at 15:33,

Re: [Uboot-stm32] [PATCH 0/7] arm: cache: cp15: don't map reserved region with no-map property

2020-10-29 Thread Etienne Carriere
On Thu, 29 Oct 2020 at 12:26, Ard Biesheuvel wrote: > > On Thu, 29 Oct 2020 at 11:40, Etienne Carriere > wrote: > > > > Dear all, > > > > CC some fellow OP-TEE guys for this secure memory description topic. > > > > > > On Wed, 28 Oct 2020 at

Re: [Uboot-stm32] [PATCH 0/7] arm: cache: cp15: don't map reserved region with no-map property

2020-10-29 Thread Etienne Carriere
On Thu, 29 Oct 2020 at 17:35, Jerome Forissier wrote: > > > > On 10/29/20 5:06 PM, Etienne Carriere wrote: > > On Thu, 29 Oct 2020 at 12:26, Ard Biesheuvel wrote: > >> The point I made before was that secure and non-secure are two > >> disjoint address spac

Re: [PATCH v5 4/4] test: dm: tee: extend with RPC test

2021-01-21 Thread Etienne Carriere
Hello Igor, On Wed, 20 Jan 2021 at 18:56, Igor Opaniuk wrote: > > From: Igor Opaniuk > > Extend existing DM tee tests adding test coverage for reverse RPC calls. > Currently this commit only adds tests for I2C requests from TEE driver > to TEE supplicant, for instance reading/writing data to

Re: [PATCH v5 3/4] drivers: tee: sandbox: add rpc test ta emulation

2021-01-20 Thread Etienne Carriere
Hi Igor, On Wed, 20 Jan 2021 at 18:56, Igor Opaniuk wrote: > > From: Igor Opaniuk > > This adds support for RPC test trusted application emulation, which > permits to test reverse RPC calls to TEE supplicant. Currently it covers > requests to the I2C bus from TEE. > > Signed-off-by: Igor

Re: [PATCH v7 4/4] test: dm: tee: extend with RPC test

2021-01-23 Thread Etienne Carriere
by the way, Acked-by: Etienne Carriere fwiw br, etienne On Fri, 22 Jan 2021 at 18:06, Igor Opaniuk wrote: > > From: Igor Opaniuk > > Extend existing DM tee tests adding test coverage for reverse RPC calls. > Currently this commit only adds tests for I2C requests from TEE

Re: [PATCH v7 3/4] drivers: tee: sandbox: add rpc test ta emulation

2021-01-23 Thread Etienne Carriere
ned-off-by: Igor Opaniuk > Reviewed-by: Simon Glass > Reviewed-by: Jens Wiklander > Acked-by: Etienne Carriere > --- > > drivers/tee/Makefile| 2 + > drivers/tee/optee/Kconfig | 9 ++ > drivers/tee/sandbox.c | 142 +

Re: [PATCH v5 3/4] drivers: tee: sandbox: add rpc test ta emulation

2021-01-22 Thread Etienne Carriere
Hi Igor > HI Etienne, > > On Thu, Jan 21, 2021 at 9:39 AM Etienne Carriere > wrote: > > > > Hi Igor, > > > > On Wed, 20 Jan 2021 at 18:56, Igor Opaniuk wrote: > > > > > > From: Igor Opaniuk > > > > > > This adds support

Re: [PATCH v6 3/4] drivers: tee: sandbox: add rpc test ta emulation

2021-01-22 Thread Etienne Carriere
Hi Igor, With comment addressed: Acked-by: Etienne Carriere Cheers, Etienne On Fri, 22 Jan 2021 at 12:51, Igor Opaniuk wrote: > > From: Igor Opaniuk > > This adds support for RPC test trusted application emulation, which > permits to test reverse RPC calls to TEE suppli

Re: [PATCH v6 1/4] drivers: tee: i2c trampoline driver

2021-01-22 Thread Etienne Carriere
Hi Igor, With comment addressed or not: Reviewed-by: Etienne Carriere On Fri, 22 Jan 2021 at 12:51, Igor Opaniuk wrote: > > From: Jorge Ramirez-Ortiz > > This commit gives the secure world access to the I2C bus so it can > communicate with I2C slaves (typically those would be

Re: [PATCH 2/2] tee: optee: support session login as REE kernel

2021-05-17 Thread Etienne Carriere
On Mon, 17 May 2021 at 08:08, Jens Wiklander wrote: > > On Wed, May 12, 2021 at 5:06 PM Etienne Carriere > wrote: > > > > OP-TEE supports an API extension to allow client to open a TEE session > > as REE kernel which OP-TEE uses to differentiate client applicati

[PATCH 1/2] tee: define session login identifiers

2021-05-12 Thread Etienne Carriere
TEE header file defines a clnt_login field in struct tee_open_session_arg but does not define the values expected. This change define identifiers for the field using a enumerated type. Back end TEE driver is expected to convert these IDs into IDs meaningful to the TEE. Signed-off-by: Etienne

[PATCH] tee: optee: sync cache on pre-reloc OP-TEE invocation

2021-05-12 Thread Etienne Carriere
This change ensures both U-Boot and OP-TEE see the same content from shared memory when OP-TEE is invoked prior U-Boot relocation. This change is required since U-Boot may execute with data cahce off while OP-TEE always enables cache on memory shared with U-Boot. Signed-off-by: Etienne Carriere

[PATCH 2/2] tee: optee: support session login as REE kernel

2021-05-12 Thread Etienne Carriere
access kernel client specific services. Signed-off-by: Etienne Carriere --- drivers/tee/optee/core.c | 24 +++- drivers/tee/optee/optee_msg.h | 2 ++ 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c index

[PATCH 2/2] firmware: scmi: fix sandbox and related test since clock discovery

2021-05-12 Thread Etienne Carriere
-by: Etienne Carriere --- arch/sandbox/dts/test.dts | 4 +- arch/sandbox/include/asm/scmi_test.h | 2 - drivers/firmware/scmi/sandbox-scmi_agent.c | 102 ++--- test/dm/scmi.c | 29 -- 4 files changed, 113 insertions(+), 24

[PATCH 1/2] clk: scmi: register all scmi clock by name with CCF

2021-05-12 Thread Etienne Carriere
From: Patrick Delaunay This patch implements SCMI APIs to retrieve the number and the name of SCMI clocks using SCMI_PROTOCOL_ATTRIBUTES messages. Signed-off-by: Gabriel Fernandez Signed-off-by: Patrick Delaunay Signed-off-by: Etienne Carriere --- drivers/clk/clk_scmi.c | 101

Re: [PATCH v2 2/2] tee: optee: support session login as REE kernel

2021-05-21 Thread Etienne Carriere
On Thu, 20 May 2021 at 16:56, Jens Wiklander wrote: > > On Wed, May 19, 2021 at 4:27 PM Etienne Carriere > wrote: > > > > Remove unused OPTEE_MSG_LOGIN_* IDs and rely on the ones introduced in > > tee.h. Change optee core to treat invalid client IDs as publi

Re: [PATCH v2 1/2] tee: define session login identifiers

2021-05-21 Thread Etienne Carriere
On Thu, 20 May 2021 at 16:50, Jens Wiklander wrote: > > On Wed, May 19, 2021 at 4:27 PM Etienne Carriere > wrote: > > > > Define identifiers for clnt_login field in struct tee_open_session_arg > > based in GlobalPlatform Device TEE IDs and on the REE_KERNEL identifie

[PATCH v2 1/2] clk: scmi: register all scmi clock by name with CCF

2021-06-02 Thread Etienne Carriere
From: Patrick Delaunay This patch implements SCMI APIs to retrieve the number and the name of SCMI clocks using SCMI_PROTOCOL_ATTRIBUTES messages. Signed-off-by: Gabriel Fernandez Signed-off-by: Patrick Delaunay Signed-off-by: Etienne Carriere --- Changes since v1: - remove use of ERR_PTR

[PATCH v2 2/2] firmware: scmi: fix sandbox and related test since clock discovery

2021-06-02 Thread Etienne Carriere
-by: Etienne Carriere Reviewed-by: Simon Glass --- Changes since v1: - Review tag applied --- arch/sandbox/dts/test.dts | 4 +- arch/sandbox/include/asm/scmi_test.h | 2 - drivers/firmware/scmi/sandbox-scmi_agent.c | 102 ++--- test/dm/scmi.c

[PATCH v2 1/2] tee: define session login identifiers

2021-05-19 Thread Etienne Carriere
Define identifiers for clnt_login field in struct tee_open_session_arg based in GlobalPlatform Device TEE IDs and on the REE_KERNEL identifier extension from OP-TEE OS. Signed-off-by: Etienne Carriere --- Changes since v1: - Rename macros to TEE_LOGIN_* and use same inline description as made

[PATCH v2 2/2] tee: optee: support session login as REE kernel

2021-05-19 Thread Etienne Carriere
Remove unused OPTEE_MSG_LOGIN_* IDs and rely on the ones introduced in tee.h. Change optee core to treat invalid client IDs as public login. Signed-off-by: Etienne Carriere --- Changes since v1: - Remove ID conversion. I kept the sanitation of login ID for optee. --- drivers/tee/optee/core.c

[PATCH v2] tee: optee: sync cache on pre-reloc OP-TEE invocation

2021-05-19 Thread Etienne Carriere
This change ensures both U-Boot and OP-TEE see the same content from shared memory when OP-TEE is invoked prior U-Boot relocation. This change is required since U-Boot may execute with data cahce off while OP-TEE always enables cache on memory shared with U-Boot. Signed-off-by: Etienne Carriere

Re: [PATCH] dm: core: Add address translation in fdt_get_resource

2021-04-06 Thread Etienne Carriere
9e ("dm: core: Add dev_read_resource() to read device > resources") > Signed-off-by: Patrick Delaunay > --- > Acked-by: Etienne Carriere Regards, Etienne > > This patch allows to remove the workaround in smci/smt.c > introduced by [1]. > > But it

Re: [PATCH] scmi: correctly configure MMU for SCMI buffer

2021-03-16 Thread Etienne Carriere
); > + > mmu_set_region_dcache_behaviour(ALIGN_DOWN((uintptr_t)smt->buf, > MMU_SECTION_SIZE), > + ALIGN(smt->size, > MMU_SECTION_SIZE), > + DCACHE_OFF); > + > #end

Re: [PATCH v3 1/4] firmware: scmi: voltage regulator

2021-03-04 Thread Etienne Carriere
Hello Patrick, On Wed, 3 Mar 2021 at 11:09, Patrick DELAUNAY wrote: > > Hi Etienne, > > On 2/22/21 8:27 AM, Etienne Carriere wrote: > > Implement voltage regulators interfaced by the SCMI voltage domain > > protocol. The DT bindings are defined in the Linux kernel since

[PATCH v4 1/5] firmware: scmi: voltage regulator

2021-03-08 Thread Etienne Carriere
/0f80fcec08e9c50b8d2992cf26495673765ebaba Link: [2] https://github.com/torvalds/linux/commit/2add5cacff3531e54c50b0832128299faa9f0563 Signed-off-by: Etienne Carriere --- Changes in v4: - define a device for SCMI voltage protocol that binds the SCMI regulators as suggested by Patrick. - removed Simon and Jaehoon tags since

[PATCH v4 3/5] firmware: scmi: fix inline comments and minor coding style issues

2021-03-08 Thread Etienne Carriere
Fix inline comments and empty line in scmi driver and test files. Remove test on IS_ENABLED(CONFIG_*_SCMI) in test/dm/scmi.c since these configuration are expected enabled when CONFIG_FIRMWARE_SCMI is enabled in sandbox configuration. Signed-off-by: Etienne Carriere Reviewed-by: Simon Glass

[PATCH v4 5/5] regulator: scmi: fix header file inclusion order

2021-03-08 Thread Etienne Carriere
Fix header file inclusion order in SCMI regulators driver. Signed-off-by: Etienne Carriere --- Changes in v4 - new change added to the series. --- drivers/firmware/scmi/scmi_agent-uclass.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/firmware/scmi/scmi_agent

[PATCH v4 2/5] firmware: scmi: sandbox test for voltage regulator

2021-03-08 Thread Etienne Carriere
Implement sandbox regulator devices for SCMI voltage domains and test them in DM scmi tests. Signed-off-by: Etienne Carriere Reviewed-by: Simon Glass Reviewed-by: Jaehoon Chung --- Changes in v4: - no change Changes in v3: - applied review tags Changes in v2: - don't test IS_ENABLED

[PATCH v4 4/5] test: scmi: add local variables for scmi agent reference

2021-03-08 Thread Etienne Carriere
Add local variables agent0/agent1 to refer to SCMI sandbox context agent and ease readability of the test. For consistency, rename regul_dev to regul0_dev and remove sandbox_voltd in dm_test_scmi_voltage_domains(). Signed-off-by: Etienne Carriere --- Changes in v4 - no change Changes in v3

[PATCH 1/3] firmware: scmi: voltage regulator

2021-02-18 Thread Etienne Carriere
/0f80fcec08e9c50b8d2992cf26495673765ebaba Link: [2] https://github.com/torvalds/linux/commit/2add5cacff3531e54c50b0832128299faa9f0563 Signed-off-by: Etienne Carriere --- doc/device-tree-bindings/arm/arm,scmi.txt | 34 + drivers/firmware/scmi/scmi_agent-uclass.c | 35 - drivers/power/regulator/Kconfig | 8

[PATCH 2/3] firmware: scmi: sandbox test for voltage regulator

2021-02-18 Thread Etienne Carriere
Implement sandbox regulator devices for SCMI voltage domains and test them in DM scmi tests. Signed-off-by: Etienne Carriere --- arch/sandbox/dts/test.dts| 23 +++ arch/sandbox/include/asm/scmi_test.h | 20 ++ configs/sandbox_defconfig| 1

[PATCH 3/3] firmware: scmi: fix inline comments and minor coding style issues

2021-02-18 Thread Etienne Carriere
Fix inline comments and empty line in scmi driver and test files. Condition SCMI clock and reset tests to U-Boot configuration. Change-Id: Iac37398cedc1942cf1cc114fc60cbe04c599313e Signed-off-by: Etienne Carriere --- arch/sandbox/include/asm/scmi_test.h | 5 +++-- drivers/firmware/scmi

Re: [PATCH v2 2/3] firmware: scmi: sandbox test for voltage regulator

2021-02-21 Thread Etienne Carriere
On Sat, 20 Feb 2021 at 12:55, Simon Glass wrote: > > On Fri, 19 Feb 2021 at 06:34, Etienne Carriere > wrote: > > > > Implement sandbox regulator devices for SCMI voltage domains > > and test them in DM scmi tests. > > > > Signed-off-by: Etienne Carriere

[PATCH v3 1/4] firmware: scmi: voltage regulator

2021-02-21 Thread Etienne Carriere
/0f80fcec08e9c50b8d2992cf26495673765ebaba Link: [2] https://github.com/torvalds/linux/commit/2add5cacff3531e54c50b0832128299faa9f0563 Signed-off-by: Etienne Carriere Reviewed-by: Simon Glass Reviewed-by: Jaehoon Chung --- Changes in v3: - applied review tags Changes in v2: - no change --- doc/device-tree-bindings/arm/arm

[PATCH v3 2/4] firmware: scmi: sandbox test for voltage regulator

2021-02-21 Thread Etienne Carriere
Implement sandbox regulator devices for SCMI voltage domains and test them in DM scmi tests. Signed-off-by: Etienne Carriere Reviewed-by: Simon Glass Reviewed-by: Jaehoon Chung --- Changes in v3: - applied review tags Changes in v2: - don't test IS_ENABLED(CONFIG_DM_REGULATOR_SCMI) in test

[PATCH v3 4/4] test: scmi: add local variables for scmi agent reference

2021-02-21 Thread Etienne Carriere
Add local variables agent0/agent1 to refer to SCMI sandbox context agent and ease readability of the test. For consistency, rename regul_dev to regul0_dev and remove sandbox_voltd in dm_test_scmi_voltage_domains(). Signed-off-by: Etienne Carriere --- Changes in v3 - new change added

[PATCH v3 3/4] firmware: scmi: fix inline comments and minor coding style issues

2021-02-21 Thread Etienne Carriere
Fix inline comments and empty line in scmi driver and test files. Remove test on IS_ENABLED(CONFIG_*_SCMI) in test/dm/scmi.c since these configuration are expected enabled when CONFIG_FIRMWARE_SCMI is enabled in sandbox configuration. Signed-off-by: Etienne Carriere Reviewed-by: Simon Glass

Re: [PATCH 3/3] firmware: scmi: fix inline comments and minor coding style issues

2021-02-18 Thread Etienne Carriere
Hello Simon, On Fri, 19 Feb 2021 at 05:52, Simon Glass wrote: > > Hi Etienne, > > On Thu, 18 Feb 2021 at 05:55, Etienne Carriere > wrote: > > > > Fix inline comments and empty line in scmi driver and test files. > > Condition SCMI clock and reset tests to U-Boot

[PATCH v2 2/3] firmware: scmi: sandbox test for voltage regulator

2021-02-19 Thread Etienne Carriere
Implement sandbox regulator devices for SCMI voltage domains and test them in DM scmi tests. Signed-off-by: Etienne Carriere --- Changes in v2: - don't test IS_ENABLED(CONFIG_DM_REGULATOR_SCMI) in test/dm/scmi.c, it's expected enabled when CONFIG_FIRMWARE_SCMI is enabled in sandbox

[PATCH v2 1/3] firmware: scmi: voltage regulator

2021-02-19 Thread Etienne Carriere
/0f80fcec08e9c50b8d2992cf26495673765ebaba Link: [2] https://github.com/torvalds/linux/commit/2add5cacff3531e54c50b0832128299faa9f0563 Signed-off-by: Etienne Carriere --- Changes in v2: - no change --- doc/device-tree-bindings/arm/arm,scmi.txt | 34 + drivers/firmware/scmi/scmi_agent-uclass.c | 35 - drivers/power

[PATCH v2 3/3] firmware: scmi: fix inline comments and minor coding style issues

2021-02-19 Thread Etienne Carriere
Fix inline comments and empty line in scmi driver and test files. Remove test on IS_ENABLED(CONFIG_*_SCMI) in test/dm/scmi.c since these configuration are expected enabled when CONFIG_FIRMWARE_SCMI is enabled in sandbox configuration. Signed-off-by: Etienne Carriere --- Changes in v2

Re: [PATCH 1/2] lib: optee: remove the duplicate CONFIG_OPTEE

2021-09-04 Thread Etienne Carriere
Hello Alex and Patrick, (my apologies for my previous malformed post) On Fri, 3 Sept 2021 at 18:43, Alex G. wrote: > > Hi Patrick > > On 9/2/21 4:56 AM, Patrick Delaunay wrote: > > The configuration CONFIG_OPTEE is defined 2 times: > > 1- in lib/optee/Kconfig for support of OPTEE images loaded

Re: [PATCH 10/10] stm32mp1: spl: Copy optee nodes to target FDT for OP-TEE payloads

2021-09-02 Thread Etienne Carriere
Hello, On Wed, 1 Sept 2021 at 17:10, Alex G. wrote: > Hi Patrick, > > On 8/31/21 12:24 PM, Patrick DELAUNAY wrote: > > Hi, > > > > On 8/26/21 11:42 PM, Alexandru Gagniuc wrote: > >> OP-TEE does not take a devicetree for its own use. However, it does > >> pass the devicetree to the normal world

Re: [RFC PATCH] stm32mp1: Replace STM32IMAGE config with TFABOOT_FIP

2021-09-06 Thread Etienne Carriere
Hello Alex, Thanks for sharing your thoughts. On Fri, 3 Sept 2021 at 19:47, Alex G. wrote: > > On 9/3/21 10:32 AM, Marek Vasut wrote: > > On 9/1/21 11:07 AM, Patrick DELAUNAY wrote: > >> On 8/31/21 6:42 PM, Marek Vasut wrote: > > >>> I would argue that the U-Boot crypto code went through

Re: [PATCH 2/2] tee: add a stub for tee_find_device

2021-09-03 Thread Etienne Carriere
+ const void > *data), > + const void *data, > + struct tee_version_data > *vers) > +{ > + return NULL; > +} > +#endif > > /** > * tee_get_version() - Query capabilities of TEE device > -- > 2.25.1 > > Acked-by: Etienne Carriere

Re: [PATCH 4/5] firmware: scmi: add configs to select the supported agents

2021-10-28 Thread Etienne Carriere
Hello Patrick, Acked-by: Etienne Carriere for the series with typo fixed in patch 4/5 (see below). On Thu, 28 Oct 2021 at 15:01, Patrick Delaunay wrote: > > Add two configs CONFIG_SCMI_AGENT_MAILBOX and CONFIG_SCMI_AGENT_SMCCC > to select the supported agents as all t

Re: [PATCH 5/5] firmware: scmi: Add OP-TEE transport

2021-11-09 Thread Etienne Carriere
On Tue, 9 Nov 2021 at 15:39, Patrick DELAUNAY wrote: > > Hi Etienne, > > one missing remark, don't see in my first review. > > On 11/4/21 3:14 PM, Etienne Carriere wrote: > > This change implements an SCMI transport for agent interfacing the > > OP-TEE SCMI servic

[PATCH v2 1/5] tee: define session login identifiers

2021-11-09 Thread Etienne Carriere
Define identifiers for clnt_login field in struct tee_open_session_arg based in GlobalPlatform Device TEE IDs and on the REE_KERNEL identifier extension from OP-TEE OS. Cc: Jens Wiklander Reviewed-by: Patrick Delaunay Reviewed-by: Jens Wiklander Signed-off-by: Etienne Carriere --- Changes

[PATCH v2 5/5] firmware: scmi: Add OP-TEE transport

2021-11-09 Thread Etienne Carriere
Cc: Wolfgang Denk Signed-off-by: Etienne Carriere --- Changes since v1: - Correct error trace message on missing DT node property. --- drivers/firmware/scmi/Kconfig | 14 +- drivers/firmware/scmi/Makefile | 1 + drivers/firmware/scmi/optee_agent.c | 312

[PATCH v2 3/5] tee: optee: define TEE error code TEE_ERROR_SHORT_BUFFER

2021-11-09 Thread Etienne Carriere
Adds TEE_ERROR_SHORT_BUFFER as TEE error code. This error code is commonly used by TEEs to inform caller that the buffer(s) it provided is too small for the desired operation. Cc: Jens Wiklander Reviewed-by: Patrick Delaunay Reviewed-by: Jens Wiklander Signed-off-by: Etienne Carriere

[PATCH v2 2/5] tee: optee: remove unused duplicated login Id macros

2021-11-09 Thread Etienne Carriere
Remove unused OPTEE_MSG_LOGIN_* ID macros as suitable TEE_LOGIN_* ID macros are already defined tee.h. Cc: Jens Wiklander Reviewed-by: Patrick Delaunay Reviewed-by: Jens Wiklander Signed-off-by: Etienne Carriere --- Changes since v1: - Apply review tags Added info for v1: This change

[PATCH v2 4/5] dt-bindings: arm: scmi: OP-TEE as transport channel for SCMI messages

2021-11-09 Thread Etienne Carriere
shared memory buffer identified by the DT. These bindings were posted to the Linux kernel DT bindings mailing list and acked by maintainer [1]. Link: [1] https://lore.kernel.org/linux-arm-kernel/20211029102118.GG6526@e120937-lin/T/ Cc: Jaehoon Chung Reviewed-by: Patrick Delaunay Signed-off-

  1   2   3   4   >