Re: [PATCH] clk: at91: sam9x60: change parent clock from mck_pres to mck_div

2022-09-06 Thread Eugen.Hristev
On 8/18/22 12:07 PM, Claudiu Beznea - M18063 wrote: > On 17.08.2022 10:04, Eugen Hristev wrote: >> From: Mihai Sain >> >> ddrck and qspick should have mck_div as parent clocks to be in sync with >> linux driver. >> >> Signed-off-by: Mihai Sain > > Reviewed-by: Claudiu Beznea > > Applied to

Re: [PATCH 0/4] Align sama5 and sama7 DT's with Linux

2022-09-19 Thread Eugen.Hristev
On 9/1/22 5:22 PM, Sergiu Moga wrote: > This has been done in order to align the DT of U-Boot with the DT > of Linux. In Linux, a phandle from a '-gpio' DT property is linked > to the pinctrl driver, a single driver that handles both pinctrl > settings and offers GPIO API to callers. On the other h

[PULL next] u-boot-at91-2023.01-a

2022-09-19 Thread Eugen.Hristev
Hello Tom, Please pull tag u-boot-2023.01-a , the first set of new at91 features for the next cycle 2023.01 . This feature set includes the important update on PIO4 pinctrl driver that solves a long time mismatch between Linux and U-boot, related on the unification of pinctrl and gpio driver s

Re: [PATCH] mmc: atmel_sdhci: re-enable sdhci after SD Card re-insertion

2022-08-16 Thread Eugen.Hristev
On 7/8/22 3:40 PM, Eugen Hristev - M18282 wrote: > On 6/22/22 4:30 PM, Sergiu Moga wrote: >> Whenever the SD Card would be removed and then re-inserted while in the >> U-Boot command line, the `SDBPWR` bit of the `SDMMC_PCR` register would >> remain unset afterwards. In order for the bit to be set

Re: [PATCH 0/3] sam9x60_curiosity PDA detection support

2022-08-16 Thread Eugen.Hristev
On 7/7/22 2:10 PM, Durai Manickam KR wrote: > This patch series adds the PDA detection support for sam9x60_curiosity rev4 > boards. In rev4, the raspberry-pi display is replaced by PDA display. > > Durai Manickam KR (3): >configs: sama9x60_curiosity: add onewire and eeprom drivers >board:

Re: [PATCH v2 0/9] Add DM support for atmel NAND driver

2022-08-30 Thread Eugen.Hristev
On 8/30/22 5:30 AM, Simon Glass wrote: > Hi, > > On Mon, 29 Aug 2022 at 00:41, Michael Nazzareno Trimarchi > wrote: >> >> Hi >> >> On Mon, Aug 29, 2022 at 8:19 AM Balamanikandan Gunasundar >> wrote: >>> >>> Change include: >>> >>> - Adapt GPIO descriptor apis for U-Boot. Use >>>gpio_request_

Re: [PATCH v2 8/9] ARM: dts: at91: sam9x60ek: Enable NAND support

2022-08-31 Thread Eugen.Hristev
On 8/31/22 4:14 PM, Michael Nazzareno Trimarchi wrote: > Hi > > On Mon, Aug 29, 2022 at 8:20 AM Balamanikandan Gunasundar > wrote: >> >> Enable the EBI and NAND flash controller. Define the pinctrl and >> partition table >> >> Signed-off-by: Balamanikandan Gunasundar >> >> --- >> arch/arm/dts

Re: [PATCH v2 8/9] ARM: dts: at91: sam9x60ek: Enable NAND support

2022-08-31 Thread Eugen.Hristev
On 8/31/22 5:19 PM, Michael Nazzareno Trimarchi wrote: > Hi > > On Wed, Aug 31, 2022 at 3:31 PM wrote: >> >> On 8/31/22 4:14 PM, Michael Nazzareno Trimarchi wrote: >>> Hi >>> >>> On Mon, Aug 29, 2022 at 8:20 AM Balamanikandan Gunasundar >>> wrote: Enable the EBI and NAND flash controll

Re: [PATCH v2 1/9] nand: atmel: Add DM based NAND driver

2022-09-05 Thread Eugen.Hristev
On 8/29/22 9:19 AM, Balamanikandan Gunasundar wrote: > This implementation is ported from the rework done by Boris Brezillon > in Linux. This porting is done based on linux-5.4-at91. The driver is > tested in sam9x60ek, sama5d3_xplained, sam9x75eb and sama7g54-ddr3-eb. > > Changes done includes >

Re: [PATCH v2] ARM: dts: at91: sama5d3: add u-boot properties to sama5d3 pit timer

2021-04-19 Thread Eugen.Hristev
On 4/7/21 12:39 PM, Manuel Luís Reis wrote: > Great, thanks for your help. > > Cheers > Manuel > > M. Luís Reis MSc MIET Chartered Engineer > > > > On Wed, 7 Apr 2021 at 10:31, wrote: >> >> On 4/7/21 12:16 PM, Manuel Luís Reis wrote: >>> Hi, >>> >>> @Derald: Thanks for trying this out. >>> >>

Re: [PATCH 1/2] gpio: atmel_pio4: add support for sama7g5 pio4 version with 5 banks

2021-04-19 Thread Eugen.Hristev
On 4/7/21 11:39 AM, Eugen Hristev wrote: > Add support for sama7g5 pinctrl variant, with 5 banks with a degraded > 8 line only 5th bank. > Based on Linux Kernel implementation. > > Signed-off-by: Eugen Hristev > --- > drivers/gpio/atmel_pio4.c | 22 ++ > 1 file changed, 22

[PULL] u-boot-atmel-2021.07-b

2021-04-19 Thread Eugen.Hristev
Hello Tom, Please pull tag u-boot-atmel-2021.07-b , the second set of atmel features for the 2021.07 cycle. This small feature set include support for 5th PIO bank on pio4 pinctrl driver and a fix for the SPL on sama5d3. Thanks, Eugen The following changes since commit 3a9aaefcaa3efc2a1cef86f

Re: [PATCH v2] board:pm9261 - Enable DM_ETH

2021-04-21 Thread Eugen.Hristev
On 4/19/21 4:37 PM, Ilko Iliev wrote: > This patch remove the network support for PM9261 because > currently there is no DM suport for Davicom D9000. > > Signed-off-by: Ilko Iliev > --- Hi, If I look at the commit message, I would expect something is enabled, but in fact something is removed.

Re: [PATCH] board:pm9263 - Enable DM_ETH

2021-04-21 Thread Eugen.Hristev
On 4/19/21 4:37 PM, Ilko Iliev wrote: > Signed-off-by: Ilko Iliev > --- Hi, Could you please add a commit message explaining what you are changing and why ? Also take into consideration the comments from your other patch about pm9261 which also apply here. Eugen > board/ronetix/pm9263/pm926

Re: [PATCH v2] board:pm9261 - Enable DM_ETH

2021-04-23 Thread Eugen.Hristev
On 4/23/21 12:19 PM, Ilko Iliev wrote: > On 21.04.21 08:50, eugen.hris...@microchip.com wrote: >> On 4/19/21 4:37 PM, Ilko Iliev wrote: >>> This patch remove the network support for PM9261 because >>> currently there is no DM suport for Davicom D9000. >>> >>> Signed-off-by: Ilko Iliev >>> --- >> H

Re: [PATCH v2] arm: at91: gardena-smart-gateway-at91sam: Adjust to production values

2021-05-06 Thread Eugen.Hristev
On 4/15/21 9:59 AM, Reto Schneider wrote: > From: Reto Schneider > > This commit updates the default config with the values that are actually > used "in the wild" and which are close to what is used on the MediaTek > MT7688 based, 2nd generation of the GARDENA smart gateway: > - Reduce startup

Re: [PATCH] lds: align u-boot-nodtb with 8 bytes boundary

2022-12-15 Thread Eugen.Hristev
On 12/15/22 16:24, Simon Glass wrote: > Hi Eugen, > > On Thu, 15 Dec 2022 at 03:58, Eugen Hristev > wrote: >> >> Newer DTC require that the DTB start address is aligned at 8 bytes. >> In the u-boot.bin case, the u-boot-nodtb.bin is concatenated with the >> DTB, but there is no alignment/padding

Re: [PATCH] lds: align u-boot-nodtb with 8 bytes boundary

2022-12-21 Thread Eugen.Hristev
On 12/18/22 01:59, Pali Rohár wrote: > On Saturday 17 December 2022 23:54:40 Pali Rohár wrote: >> On Saturday 17 December 2022 23:04:08 Pali Rohár wrote: >>> On Saturday 17 December 2022 14:40:44 Simon Glass wrote: Hi Pali, On Thu, 15 Dec 2022 at 16:13, Pali Rohár wrote: > >

Re: [PATCH] ARM: mach-at91: add support for sama7g5 chip id and extended id definition

2022-12-21 Thread Eugen.Hristev
On 12/2/22 09:47, Mihai Sain wrote: > Add SAMA7G5 series chip id definitions to align with linux SoC driver. > Add support for SAMA7G5 System-In-Package (SIP): > SAMA7G54D1G, SAMA7G54D2G, SAMA7G54D4G. > > Signed-off-by: Mihai Sain > --- Applied to u-boot-at91/next , thanks !

Re: [PATCH] ARM: dts: at91: sama5d2: fix wrong interrupt-cells property

2022-12-21 Thread Eugen.Hristev
On 12/12/22 12:07, Claudiu Beznea - M18063 wrote: > On 12.12.2022 11:59, Eugen Hristev wrote: >> The PMC node is not an interrupt provider, so it must not have >> interrupt-cells. >> >> This fixes the warning (on newer DTC): >> arch/arm/dts/sama5d2.dtsi:82.22-602.6: Warning (interrupt_provider): >

Re: [PATCH 1/3] dt-bindings: mfd: add at91-usart.h from Linux

2022-12-21 Thread Eugen.Hristev
On 11/25/22 10:29, Claudiu Beznea - M18063 wrote: > On 25.11.2022 09:54, Eugen Hristev wrote: >> Copy include file dt-bindings/mfd/at91-usart.h from Linux >> >> Signed-off-by: Eugen Hristev > > Reviewed-by: Claudiu Beznea > Applied series to u-boot-at91/next , thanks !

Re: [PATCH v5 00/19] Add USB on SAM9X60, SAMA7G5 and SAMA5D2 boards

2022-12-22 Thread Eugen.Hristev
On 12/22/22 18:11, Marek Vasut wrote: > On 12/22/22 16:54, sergiu.m...@microchip.com wrote: >> On 22.12.2022 15:36, Marek Vasut wrote: >>> On 12/22/22 11:53, Sergiu Moga wrote: This series of patches is meant to add support for USB Mass Storage on SAM9X60, SAMA7G5 and SAMA5D2 boards and r

Re: [PATCH v2 1/9] ARM: dts: sam9x60: Add OHCI and EHCI DT nodes

2023-01-03 Thread Eugen.Hristev
On 1/3/23 18:00, Marek Vasut wrote: > On 1/3/23 16:56, sergiu.m...@microchip.com wrote: >> On 03.01.2023 17:47, Marek Vasut wrote: >>> On 1/3/23 16:35, Sergiu Moga wrote: Add the OHCI and EHCI DT nodes for the sam9x60 SoC's. Signed-off-by: Sergiu Moga --- v1 -> v2: >>

Re: [PATCH 1/6] ARM: dts: sam9x60: Add OHCI and EHCI DT nodes

2023-01-03 Thread Eugen.Hristev
On 1/3/23 01:12, Marek Vasut wrote: > On 12/23/22 13:33, Sergiu Moga wrote: >> Add the OHCI and EHCI DT nodes for the sam9x60 boards. >> >> Signed-off-by: Sergiu Moga >> --- >>   arch/arm/dts/at91-sam9x60_curiosity.dts | 21 + >>   arch/arm/dts/sam9x60.dtsi   | 18 ++

Re: [[PATCH] board: at91: sam9x60: set blue led on at boot time

2023-01-03 Thread Eugen.Hristev
On 12/23/22 08:39, Mihai Sain wrote: > Set blue led on at boot time in order to highlight that u-boot is loaded. > This is done for all sam9x60 based boards which contain an RGB led. > > Signed-off-by: Mihai Sain > --- Applied to u-boot-at91/next, thanks !

Re: [PATCH] configs: sam9x60: add mmc config for sdmmc1

2023-01-03 Thread Eugen.Hristev
On 12/23/22 08:43, Mihai Sain wrote: > Add new config for storing environment from SDMMC1. > > Signed-off-by: Mihai Sain > --- Applied to u-boot-at91/next, thanks !

Re: [PATCH] ARM: dts: at91: sam9x60: add sdhci1 node and pinctrl

2023-01-03 Thread Eugen.Hristev
On 12/23/22 08:47, Mihai Sain wrote: > Add node for sdhci1 controller and its pinctrl. > > Signed-off-by: Mihai Sain > --- Applied to u-boot-at91/next, thanks !

Re: [PATCH v2 0/9] Add DT USB definitions for SAM9X60, SAMA5D2 and SAMA7

2023-01-04 Thread Eugen.Hristev
On 1/3/23 17:35, Sergiu Moga wrote: > This patch series originates from the bigger patch series: > https://lists.denx.de/pipermail/u-boot/2022-December/502865.html > > Add the basic DT USB definitions for SAM9X60, SAMA5D2 and SAMA7. The > required pinctrl definitions have been added as well as add

Re: [PATCH 1/6] ARM: dts: sam9x60: Add OHCI and EHCI DT nodes

2023-01-04 Thread Eugen.Hristev
On 1/4/23 11:38, Marek Vasut wrote: > On 1/4/23 08:30, eugen.hris...@microchip.com wrote: >> On 1/3/23 01:12, Marek Vasut wrote: >>> On 12/23/22 13:33, Sergiu Moga wrote: Add the OHCI and EHCI DT nodes for the sam9x60 boards. Signed-off-by: Sergiu Moga ---    arch/arm/dts/

Re: [PATCH v3 0/9] Add DT USB definitions for SAM9X60, SAMA5D2 and SAMA7

2023-01-05 Thread Eugen.Hristev
On 1/4/23 16:04, Sergiu Moga wrote: > This patch series originates from the bigger patch series: > https://lists.denx.de/pipermail/u-boot/2022-December/502865.html > > Add the basic DT USB definitions for SAM9X60, SAMA5D2 and SAMA7. The > required pinctrl definitions have been added as well as add

Re: [PATCH v2 0/2] Add basic reset driver for assert/deassert operations

2023-01-05 Thread Eugen.Hristev
On 1/4/23 16:03, Sergiu Moga wrote: > This patch series originates from: > https://lists.denx.de/pipermail/u-boot/2022-December/502865.html > > Implement a basic driver to enable assert/deassert operations. > > v1 -> v2: > - rebase on u-boot next > > Cristian Birsan (1): >ARM: at91: add sama

[PULL next] u-boot-at91-2023.04-a

2023-01-05 Thread Eugen.Hristev
Hello Tom, Please pull tag u-boot-at91-2023.04-a , the first set of at91 features for the next cycle 2023.04. This feature set includes the new DM-based NAND flash driver (old non-DM driver is still kept for backwards compatibility), and the move to DM NAND flash driver for sam9x60ek board. Fe

Re: [PATCH] arm: at91: configs: Enable CONFIG_SYS_NAND_USE_FLASH_BBT on all boards

2021-01-07 Thread Eugen.Hristev
On 26.11.2020 14:16, Alexander Dahl wrote: > Hello, > > Am Donnerstag, 26. November 2020, 09:21:35 CET schrieb Eugen Hristev: >> From: Nicolas Ferre >> >> As highlighted by Stefan in the commit e074d0f79b2e ("arm: at91: >> gardena-smart-gateway-at91sam: Enable CONFIG_SYS_NAND_USE_FLASH_BBT") >> i

Re: [PATCH v2 00/34] Sama7g5 Evaluation Kit support

2021-01-07 Thread Eugen.Hristev
On 05.12.2020 12:02, Eugen Hristev wrote: > Hello, > > This series adds support for sama7g5 SoC DT and the sama7g5ek board. > I kept the original incremental development for this board, with each > commit's author and designated change, for traceability and for easier > reviewing. > > The series

[PULL] u-boot-atmel-2021.04-a

2021-01-12 Thread Eugen.Hristev
Hello Tom, Please pull tag u-boot-atmel-2021.04-a , the first set of new features for the 2021.04 cycle. This feature set includes the new board SAMA7G5 EK, the new evaluation kit for Microchip AT91 SAMA7G5 SoC . The current board support includes two configurations for booting from eMMC (SDMMC

Re: [PATCH 0/2] add support for dll setup on ksz9131

2021-01-14 Thread Eugen.Hristev
On 03.12.2020 11:18, Claudiu Beznea wrote: > Hi, > > KSZ9131 has an internal DLL used to add proper delay on TX/RX lines > to confirm with RGMII timings. The series add support for this. Along > with this I included a typo patch. > > Thank you, > Claudiu Beznea > > Claudiu Beznea (2): >net:

Re: [PATCH 1/6] net: macb: use dummy descriptor for RBQP

2021-01-14 Thread Eugen.Hristev
On 17.12.2020 07:22, Padmarao Begari - I30397 wrote: > Hi Eugen, > > This series of patches break my side of work(patches) so you need to > create patches after my patches are going into master branch because my > patches are already reviewed and tested. Hi, Could you please detail the breakag

Re: [PATCH 2/2] board: atmel: Add SAMA5D27 giant board

2021-01-15 Thread Eugen.Hristev
On 11.01.2021 09:10, Greg Gallagher wrote: > Giant board is a tiny SBC based on the Adafruit Feather form factor, > created by groboards it contains a SAMA5D2 processor (SAMA5D27), > 128 MB of RAM and a microSD card for storage. > > Signed-off-by: Greg Gallagher Hi Greg, > --- > > arch/arm/

Re: [PATCH 1/6] net: macb: use dummy descriptor for RBQP

2021-01-15 Thread Eugen.Hristev
On 15.01.2021 06:02, Padmarao Begari wrote: > Hi Eugen, > > On Thu, Jan 14, 2021 at 4:50 PM > wrote: > > On 17.12.2020 07:22, Padmarao Begari - I30397 wrote: > > Hi Eugen, > > > > This series of patches break my side of work(patches) so you

Re: [PATCH 1/6] net: macb: use dummy descriptor for RBQP

2021-01-15 Thread Eugen.Hristev
On 15.01.2021 14:26, Padmarao Begari wrote: > Hi Eugen, > > On Fri, Jan 15, 2021 at 1:34 PM > wrote: > > On 15.01.2021 06:02, Padmarao Begari wrote: > > Hi Eugen, > > > > On Thu, Jan 14, 2021 at 4:50 PM

Re: [PATCH v2 0/6] add support for sama7g5 ethernet interfaces

2021-01-19 Thread Eugen.Hristev
On 03.12.2020 15:59, Claudiu Beznea wrote: > Hi, > > This series add support for SAMA7G5 ethernet interfaces: one > gigabit interface and one 10/100Mbps interface. > > Thank you, > Claudiu Beznea > > Changes in v2: > - fix compilation error on patch 6/6 for wb50n_defconfig > > Claudiu Beznea (6

Re: [PATCH 1/2] board: Atmel: Add SAMA5D27 giant board

2021-01-21 Thread Eugen.Hristev
On 21.01.2021 00:38, Greg Gallagher wrote: > Giant board is a tiny SBC based on the Adafruit Feather form factor, > created by groboards it contains a SAMA5D2 processor (SAMA5D27), > 128 MB of RAM and a microSD card for storage. > > Signed-off-by: Greg Gallagher > --- Hi Greg, This patch [1/2]

Re: [PATCH v2 08/21] clk: at91: move clock code to compat.c

2020-09-07 Thread Eugen.Hristev
On 05.08.2020 18:11, Claudiu Beznea wrote: > Move clock code to compat.c to allow switching to CCF > without mixing CCF code with non CCF code. This prepares the > field for next commits. > > Signed-off-by: Claudiu Beznea > --- Hi Claudiu, I want to apply these, but meanwhile, there are some c

Re: [PATCH v2 4/6] mmc: atmel-sdhci: do not check clk_set_rate return value

2020-09-07 Thread Eugen.Hristev
On 28.08.2020 08:37, Peng Fan wrote: >> Subject: [PATCH v2 4/6] mmc: atmel-sdhci: do not check clk_set_rate return >> value >> >> clk_set_rate will return rate in case of success and zero in case of error, >> however it can also return -ev, but it's an ulong function. >> To avoid any issues, disreg

Re: [PATCH v3 00/21] clk: at91: add sama7g5 support

2020-09-08 Thread Eugen.Hristev
On 07.09.2020 17:46, Claudiu Beznea wrote: > The purpose of this series is to add clock support for SAMA7G5. > Along with this, clock drivers were switched to CCF and aligned > with their corresponding versions present in Linux. > Some changes were done for CCF, patches 1, 3, 4, 5 (I don't know > i

Re: [PATCH] board: atmel: common: introduce at91_set_eth1addr for second interface

2020-09-08 Thread Eugen.Hristev
On 05.08.2020 15:30, Eugen Hristev wrote: > We already have a function to retrieve the mac address from one EEPROM. > For boards with a second Ethernet interface, however, we would > require another EEPROM with a second unique MAC address. > Introduce at91_set_eth1addr which will look for a second

Re: [PATCH] ARM: at91: common: guard ATMEL_PIT code by ifdef

2020-09-08 Thread Eugen.Hristev
On 20.08.2020 16:11, Eugen Hristev wrote: > Atmel PIT timer is not available for next products that > have another timer hardware block. > To be able to use the common at91 code, guard the code that uses PIT > by ifdefs. > > Signed-off-by: Eugen Hristev > --- Applied to u-boot-atmel/next

Re: [PATCH] Fix data abort in startup for at91 machines based on ARM926EJS

2021-03-18 Thread Eugen.Hristev
Hello Martin, I reviewed things a bit, and, as it looks to me, and according to AAPCS, we can still use r4, as this is scratch space, but we need to save it and restore it before and after the code of lowlevel_init. Because r6 is also scratch, with your patch , we lose the data in r6, in case s

Re: [PATCH] Fix data abort in startup for at91 machines based on ARM926EJS

2021-03-19 Thread Eugen.Hristev
Yes, please, try like this, continue to use r4 as it was done initially, but save r4 to stack and restore before returning. Let's see if this solution works for you. I will wait for your v2 of the patch. Thanks ! Eugen On 3/18/21 10:31 PM, Martin Townsend wrote: > Hi Eugen, > > Pop and push ge

Re: [PATCH] Fix data abort in startup for at91 machines based on ARM926EJS

2021-03-22 Thread Eugen.Hristev
Hello Martin, Okay, I get it. Thanks for testing this. I applied your patch as it was original, and I updated a bit the commit short message to match requirements. also, Reviewed-by: Eugen Hristev Applied to u-boot-atmel/next On 3/20/21 1:07 PM, Martin Townsend wrote: > Hi Eugen, > > It d

Re: SAMA5D3 Xplained: SPL broken after panic added to /lib/time.c:94

2021-03-23 Thread Eugen.Hristev
Hi, Can you please check if this commit is in your tree, or, if the same has to be applied in your case (sama5d3), to make it work ? Here is the commit : https://source.denx.de/u-boot/custodians/u-boot-atmel/-/commit/786f35b619ddbfb88e4532d11a56413f5dab473f On 3/23/21 1:06 PM, Manuel Luís R

Re: SAMA5D3 Xplained: SPL broken after panic added to /lib/time.c:94

2021-03-23 Thread Eugen.Hristev
On 3/23/21 1:28 PM, Manuel Luís Reis wrote: > Hi, > > Thanks for your reply. > > > Can you please check if this commit is in your tree, or, if the same has > > to be applied in your case (sama5d3), to make it work ? > > I've got that change in my tree, but I'm still getting the error message.

Re: SAMA5D3 Xplained: SPL broken after panic added to /lib/time.c:94

2021-03-23 Thread Eugen.Hristev
On 3/23/21 6:08 PM, Manuel Luís Reis wrote: > Hi again, > > FYI: As a small test I commented out the change you mentioned but got > the same mistake. Begs to wonder if it is >  related to the issue at hand. > > Going back to > http://u-boot.10912.n7.nabble.com/PATCH-v2-time-Fix-get-ticks-being

[PULL next] u-boot-atmel-2021.07-a

2021-03-30 Thread Eugen.Hristev
Hello Tom, Please pull tag u-boot-atmel-2021.07-a , the first set of features for the next cycle 2021.07 . This small feature set includes the implementation of the slew rate for the PIO4 pin controller device, and a fix for arm926ejs-based microprocessors that avoids a crash. Thanks, Eugen

Re: SAMA5D3 Xplained: SPL broken after panic added to /lib/time.c:94

2021-04-05 Thread Eugen.Hristev
On 4/4/21 7:25 PM, Manuel Reis wrote: > Hi again, > > I guess I misunderstood things a bit. Apologies for that. > Nevertheless, timer_init in board_init_f is pointing to the weak > timer_init in /lib/time.c, which is empty. > > Is there a way we can force start the pit timer? > Any pointer would

Re: SAMA5D3 Xplained: SPL broken after panic added to /lib/time.c:94

2021-04-05 Thread Eugen.Hristev
On 4/5/21 3:47 PM, Manuel Luís Reis wrote: > Hi Eugen, > >> As Sean Anderson pointed out : the call to timer must have not worked at >> all before this change that now breaks things. >> Have you tried removing the call to the timer from this mem_init, to see >> if this makes the board boot corre

Re: SAMA5D3 Xplained: SPL broken after panic added to /lib/time.c:94

2021-04-05 Thread Eugen.Hristev
On 4/5/21 6:42 PM, Manuel Luís Reis wrote: > Hi Eugen, > > > Does the node have the property > > > > u-boot,dm-pre-reloc; > > > > Maybe try to add this and see if it changes anything ? > > Thanks. Indeed it didn't have those properties. I have added them and > also had to remove the udelay

Re: [PATCH] add u-boot properties to sama5d3 pit timer

2021-04-06 Thread Eugen.Hristev
Hi Manuel, Subject should be like this : ARM: dts: at91: sama5d3: ... On 4/5/21 8:46 PM, Manuel Reis wrote: > pit timer node requires u-boot properties to be recognized could you be more specific, where it's required, like we discussed, in the early boot process of the SPL , it's not found if t

Re: [PATCH v2] ARM: dts: at91: sama5d3: add u-boot properties to sama5d3 pit timer

2021-04-07 Thread Eugen.Hristev
On 4/7/21 1:16 AM, Derald Woods wrote: > On Tue, Apr 6, 2021 at 4:40 AM Manuel Reis > wrote: > > in the early SPL boot stage whenever there is a call to udelay, > dm_timer_init fails to find the pit timer whenever it traverses > the device tree, if this pr

Re: [PATCH v2] ARM: dts: at91: sama5d3: add u-boot properties to sama5d3 pit timer

2021-04-07 Thread Eugen.Hristev
On 4/7/21 12:16 PM, Manuel Luís Reis wrote: > Hi, > > @Derald: Thanks for trying this out. > > @Eugen: For what is worth, I can also confirm that I also tried with > the latest version v2021.04 and the board boots OK out of the box with > this patch only. > Ok, great news ! Thanks. Until this

Re: [PATCH] board: atmel: Fix compiler warning 'board_usb_hw_init()' not used

2020-05-06 Thread Eugen.Hristev
On 17.04.2020 10:32, Josef Lusticky wrote: > Wrap definition of board_usb_hw_init() around with #ifdef CONFIG_CMD_USB > to avoid warning: 'board_usb_hw_init' defined but not used > [-Wunused-function] when compiling without CONFIG_CMD_USB. > > This patch makes sama5d27_som1_ek, sama5d2_ptc_ek and

Re: [PATCH] misc: i2c_eeprom: implement different probe test eeprom offset

2020-05-07 Thread Eugen.Hristev
On 06.05.2020 19:47, Baruch Siach wrote: > Hi Eugen, > > On Wed, May 06 2020, Eugen Hristev wrote: >> Because of this commit : >> 5ae84860b0 ("misc: i2c_eeprom: verify that the chip is functional at >> probe()") >> at probe time, each eeprom is tested for read at offset 0. >> >> The Atmel AT24MAC

Re: [PATCH] arm: dtsi: sama5d2: Add uart4 definition to sama5d2.dtsi

2020-05-07 Thread Eugen.Hristev
On 07.05.2020 07:43, Tiaki Rice wrote: > This patch adds support for uart4 to the processor level device tree include > file. > > > Signed-off-by: Tiaki Rice > Cc: Eugen Hristev > --- Hi, Thanks for contributing ! I have an issue with this patch missing from patchwork. Anyone has any idea w

Re: [PATCH] misc: i2c_eeprom: implement different probe test eeprom offset

2020-05-07 Thread Eugen.Hristev
On 07.05.2020 13:00, Heiko Schocher wrote: > Hello Baruch, > > Am 06.05.2020 um 18:47 schrieb Baruch Siach: >> Hi Eugen, >> >> On Wed, May 06 2020, Eugen Hristev wrote: >>> Because of this commit : >>> 5ae84860b0 ("misc: i2c_eeprom: verify that the chip is functional at >>> probe()") >>> at probe

Re: [PATCH] arm: dtsi: sama5d2: Add uart4 definition to sama5d2.dtsi

2020-05-07 Thread Eugen.Hristev
On 07.05.2020 12:21, Tiaki Rice wrote: > Hello Eugen, > > I'm new to this whole mailing list patchwork thingy so I suspect I didn't > quite submit the patch correctly, maybe you can point me in the right > direction. > > What I did: > - Made the changes on master and locally commited them > -

Re: [PATCH] arm: dtsi: sama5d2: Add uart4 definition to sama5d2.dtsi

2020-05-07 Thread Eugen.Hristev
On 07.05.2020 14:32, Tiaki Rice wrote: > Eugen, > > Thanks for the speedy reply, I did not know about this script! I must have > glossed over it in the uboot patch documentation page. > > The commit line is 82 characters which is longer than the preferred max of > 75. Oops. Don't think this war

Re: [PATCH] arm: dtsi: sama5d2: Add uart4 definition to sama5d2.dtsi

2020-05-07 Thread Eugen.Hristev
On 07.05.2020 17:23, Tiaki Rice wrote: > Eugen, > > Ah, I suspect the issue might be might be because I changed the subject > inside the file but the did not change the filename. I shouldn't have done it > that way anyway. Regarding windows vs linux, doing a diff between them showed > no differ

Re: [PATCH v2] misc: i2c_eeprom: implement different probe test eeprom offset

2020-05-07 Thread Eugen.Hristev
On 07.05.2020 18:02, Baruch Siach wrote: > Hi Heiko, > > On Thu, May 07 2020, Heiko Schocher wrote: >> Am 07.05.2020 um 10:53 schrieb Eugen Hristev: >>> Because of this commit : >>> 5ae84860b0 ("misc: i2c_eeprom: verify that the chip is functional at >>> probe()") >>> at probe time, each eeprom i

Re: [PATCH v3] board:pm9261 - Remove network support

2021-05-13 Thread Eugen.Hristev
On 4/23/21 4:06 PM, Ilko Iliev wrote: > The network support is removed because there is > no DM for Davicom DM9000. > > Signed-off-by: Ilko Iliev > --- > board/ronetix/pm9261/pm9261.c | 54 --- > configs/pm9261_defconfig | 4 +-- > include/configs/pm9261.

Re: [PATCH v2 1/2] board:pm9263 - Switch to use DM_ETH

2021-05-13 Thread Eugen.Hristev
On 4/23/21 4:41 PM, Ilko Iliev wrote: > - Enable CONFIG_DM_ETH in configs/pm9263_defconfig > - Drop legacy initialization in board/ronetix/pm9263.c > - Remove network related setting from include/configs/pm9263.h > > Signed-off-by: Ilko Iliev > --- > Changes to v2: > - improve commit message >

Re: [PATCH v2 2/2] board:pm9263 - Fix some typos in comments

2021-05-13 Thread Eugen.Hristev
On 4/23/21 4:41 PM, Ilko Iliev wrote: > Signed-off-by: Ilko Iliev > --- > board/ronetix/pm9263/pm9263.c | 10 +- > include/configs/pm9263.h | 2 +- > 2 files changed, 6 insertions(+), 6 deletions(-) > Applied with minor commit message change to u-boot-atmel/next, thanks !

Re: [PATCH] configs: sama7g5ek: increase bootm len

2021-05-21 Thread Eugen.Hristev
On 4/29/21 3:00 PM, Eugen Hristev wrote: > Increase the BOOTM_LEN to 32M . This would allow a bigger kernel image to be > booted, for example the multi_v7_defconfig. > > Loading Kernel Image > Image too large: increase CONFIG_SYS_BOOTM_LEN > Must RESET board to recover > resetting ... > > Sig

Re: [PATCH] configs: sama5d27_wlsom1_ek_mmc: add default bootargs

2021-06-02 Thread Eugen.Hristev
On 5/18/21 12:02 PM, Eugen Hristev wrote: > Add default bootarguments with booting from mmc0 for this configuration. > This will allow a default Linux boot for this board. > > Suggested-by: Jarvis Chen > Signed-off-by: Eugen Hristev > --- > configs/sama5d27_wlsom1_ek_mmc_defconfig | 1 + > 1

Re: [PATCH 1/3] Revert "sama5d3: Fix Galois Field Table offsets"

2021-06-07 Thread Eugen.Hristev
On 5/21/21 11:52 AM, Tudor Ambarus wrote: > This reverts commit 786f888b743e9b83c9095cb9b5548ebe2e29afc5. > > Looks like the datasheet at > https://ww1.microchip.com/downloads/en/DeviceDoc/SAMA5D3-Series-Data-sheet-DS60001609b.pdf > is wrong, and the testing was poorly done, because the PMECC did

Re: [PATCH] configs: sam boards: add hash command

2021-06-14 Thread Eugen.Hristev
On 5/26/21 4:19 PM, Eugen Hristev wrote: > Add hash and hash verify commands. These would be useful for > verifying copied data. > > Signed-off-by: Eugen Hristev > --- > configs/sam9x60ek_mmc_defconfig| 2 ++ > configs/sam9x60ek_nandflash_defconfig | 2 ++ > configs/s

Re: [PATCH] board: sama5d3_xplained: add Falcon boot support

2021-06-14 Thread Eugen.Hristev
On 6/1/21 12:23 AM, Michael Opdenacker wrote: > This supports Falcon boot support for Microchip SAMA5D3 Xplained, > tested on raw MMC, and on raw NAND. > > spl_start_uboot() is has the simplest possible implementation. > It doesn't test the environment because enabling environment support > curren

[PULL next] u-boot-atmel-2021.10-a

2021-06-17 Thread Eugen.Hristev
Hello Tom, Please pull tag u-boot-atmel-2021.10-a , the first set of atmel features for the next cycle 2021.10 . This feature set converts the boards pm9261 and pm9263 Ethernet support to DM; enables hash command for all SAM boards; fixes the NAND pmecc bit-flips correction; adds Falcon boot f

Re: [PATCH 1/2] w1: w1-gpio: claim the gpio with correct initial flag

2021-07-06 Thread Eugen.Hristev
On 6/23/21 5:20 PM, Eugen Hristev wrote: > gpio_request_by_name should be called with proper flags. > The 0 value flag is invalid, and causes bad initialization of the gpio. > > Signed-off-by: Eugen Hristev > --- > drivers/w1/w1-gpio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

[PULL] u-boot-atmel-fixes-2021.10-a

2021-07-07 Thread Eugen.Hristev
Hello Tom, Please pull tag u-boot-atmel-fixes-2021.10-a , the first set of atmel fixes for the 2021.10 cycle. This small fixes set is dedicated to fixing the onewire subsystem for the at91 boards which was broken since 2020.04. Thanks, Eugen The following changes since commit 1311dd37ecf476be

[PULL] u-boot-atmel-2021.04-b

2021-01-25 Thread Eugen.Hristev
Hi Tom, Please pull tag u-boot-atmel-2021.04-b , the second set of new atmel features for 2021.04 cycle. This feature set includes macb updates for all interfaces and new sama7g5 variant support; micrel ksz9031 DLL support; a new board from Giant based on Adafruit feather form factor which con

Re: [PATCH v3 0/5] add support for sama7g5 ethernet interfaces

2021-01-25 Thread Eugen.Hristev
On 19.01.2021 13:26, Claudiu Beznea wrote: > Hi, > > This series add support for SAMA7G5 ethernet interfaces: one > gigabit interface and one 10/100Mbps interface. > > Thank you, > Claudiu Beznea > > Changes in v3: > - get rid of patch 1/6 from v2 as it was already integrated from patch series >

Re: [PATCH 1/3] board: Atmel: Add SAMA5D27 giant board

2021-01-25 Thread Eugen.Hristev
On 21.01.2021 18:55, Greg Gallagher wrote: > Giant board is a tiny SBC based on the Adafruit Feather form factor, > created by groboards it contains a SAMA5D2 processor (SAMA5D27), > 128 MB of RAM and a microSD card for storage. > > Signed-off-by: Greg Gallagher > --- > > arch/arm/dts/Makefile

Re: [PATCH 0/4] at91: Fix NAND PMECC on various SoCs/boards

2021-01-25 Thread Eugen.Hristev
On 08.01.2021 14:40, Tudor Ambarus wrote: > Fix the Galois Field Table offsets for sama5d3 and sam9x60 SoCs. > PMECC could not correct errors. > > Fix the involuntarily disablement of NAND PMECC on some boards, > and fix some wrong definitions for CONFIG_PMECC_CAP. > > Tested on sam9x60ek and sam

Re: [PATCH 04/11] dm: Remove uses of device_bind_offset()

2021-01-31 Thread Eugen.Hristev
On 10.12.2020 02:26, Simon Glass wrote: > This function is not needed since the standard device_bind() can be used > instead. > > Signed-off-by: Simon Glass > --- > > arch/x86/cpu/apollolake/spl.c | 2 +- > drivers/clk/at91/compat.c | 20 >

Re: [PATCH 04/11] dm: Remove uses of device_bind_offset()

2021-02-01 Thread Eugen.Hristev
On 31.01.2021 17:37, Simon Glass wrote: > Hi Eugen, > > On Sun, 31 Jan 2021 at 02:18, wrote: >> >> On 10.12.2020 02:26, Simon Glass wrote: >>> This function is not needed since the standard device_bind() can be used >>> instead. >>> >>> Signed-off-by: Simon Glass >>> --- >>> >>>arch/x86/cpu/

Re: [PATCH 04/11] dm: Remove uses of device_bind_offset()

2021-02-01 Thread Eugen.Hristev
On 01.02.2021 14:02, Simon Glass wrote: > Hi Eugen, > > On Mon, 1 Feb 2021 at 01:13, wrote: >> >> On 31.01.2021 17:37, Simon Glass wrote: >>> Hi Eugen, >>> >>> On Sun, 31 Jan 2021 at 02:18, wrote: On 10.12.2020 02:26, Simon Glass wrote: > This function is not needed since the stand

Re: [PATCH] clk: at91: compat: partially revert "dm: Remove uses of device_bind_offset()"

2021-02-11 Thread Eugen.Hristev
On 03.02.2021 14:59, Simon Glass wrote: > On Tue, 2 Feb 2021 at 01:48, Eugen Hristev > wrote: >> >> Revert changes in at91 compat.c that cause u-boot to fail booting on >> sama5d4_xplained and sama5d2_xplained >> >> Log below: >> >> >> No serial driver found >> Could not initialize timer (err -1

Re: [PATCH] ARM: dts: at91: sama7g5ek: enable pull-up for serial debug line

2021-02-11 Thread Eugen.Hristev
On 28.01.2021 10:14, Eugen Hristev wrote: > If the serial tx/rx are floating, it can happen that bogus characters > are detected on the line at boot time. This leads to U-boot accidentally > thinking someone pressed a key to stop autoboot, thus stopping booting > process. > This can happen if the

[PULL] u-boot-atmel-fixes-2021.04-a

2021-02-12 Thread Eugen.Hristev
Hello Tom, Please pull tag u-boot-atmel-fixes-2021.04-a , the first set of fixes for atmel for 2021.04 cycle. This small PR includes just two fixes but very important: one revert in the clk subsystem which fixes the boot on many old boards (sama5d2_xplained, sama5d4_xplained), which currently

Re: [PATCH 2/2] pinctrl: at91-pio4: add support for slew-rate

2021-02-23 Thread Eugen.Hristev
On 27.01.2021 15:00, Claudiu Beznea wrote: > SAMA7G5 supports slew rate configuration. Adapt the driver for this. > For switching frequencies lower than 50MHz the slew rate needs to > be enabled. Since most of the pins on SAMA7G5 fall into this category > enabled the slew rate by default. > > Sign

Re: [PATCH 0/2] pinctrl: at91-pio4: add support for slew-rate

2021-02-26 Thread Eugen.Hristev
On 27.01.2021 15:00, Claudiu Beznea wrote: > Hi, > > This series adds support for slew rate on AT91 PIO4 driver. > The support is enabled on SAMA7G5. > > Thank you, > Claudiu Beznea > > Claudiu Beznea (2): >dt-bindings: pinctrl: at91-pio4: add slew-rate >pinctrl: at91-pio4: add support f

Re: [PATCH] Fix data abort in startup for at91 machines based on ARM926EJS

2021-03-01 Thread Eugen.Hristev
Hi, On 26.02.2021 10:44, Martin Townsend wrote: > The startup code in arm/cpu/arm926ejs preserves the link register across > the call to lowlevel_init by using r4: > > mov r4, lr /* perserve link reg across call */ > bl lowlevel_init /* go setup pll,mux,memory */ > mov lr,

[PULL] u-boot-atmel-2020.10-a

2020-07-07 Thread Eugen.Hristev
Hello Tom, Please pull tag u-boot-atmel-2020.10-a , the first set of features for the 2020.10 cycle. This set includes device tree warning fixes and cleanup for separate BSS on some boards. Thanks ! Eugen The following changes since commit e411a090cf7162626d54d72dfc4530986c788cdb: Prepare

Re: [PATCH 1/2] board: sama5d3_xplained: Fix SPL DTB read from NAND

2020-03-10 Thread Eugen.Hristev
On 25.02.2020 10:16, Eugen Hristev wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > From: Fabien Lehoussel > > SPL boot cannot find dtb if CONFIG_SPL_SEPARATE_BSS is disabled : > > CONFIG_SPL_SEPARATE_BSS=n > > RomBOOT > Missing DTB >

[PULL] u-boot-atmel-fixes-2020.04-a

2020-03-10 Thread Eugen.Hristev
Hello Tom, Please pull tag u-boot-atmel-fixes-2020.04-a , the first set of fixes for the 2020.04 cycle. Includes two small configuration fixes that will solve the SPL booting on sama5d3_xplained board. Thanks! Eugen The following changes since commit 548ce227d3d852455c6395c0cec30af0cda77b09:

Re: [U-Boot] [PATCH] gpio: at91_gpio: Add bank names

2019-11-18 Thread Eugen.Hristev
On 15.11.2019 19:35, James Byrne wrote: > Make the at91_gpio driver set sensible GPIO bank names in the platform > data. This makes the 'gpio status' command a lot more useful. > > Signed-off-by: James Byrne > > --- > > drivers/gpio/at91_gpio.c | 29 ++--- > 1 file

Re: [U-Boot] [PATCH] gpio: at91_gpio: Add bank names

2019-11-19 Thread Eugen.Hristev
On 19.11.2019 16:17, James Byrne wrote: > > Hi Eugen, > > On 18/11/2019 08:59, eugen.hris...@microchip.com wrote: >>> @@ -582,14 +604,15 @@ static int at91_gpio_probe(struct udevice *dev) >>> >>>   clk_free(&clk); >>> >>> -   uc_priv->bank_name = plat->bank_name; >>> -   uc_priv

Re: [U-Boot] [PATCH v2] gpio: at91_gpio: Add bank names

2019-11-19 Thread Eugen.Hristev
On 19.11.2019 17:56, James Byrne wrote: > Make the at91_gpio driver set sensible GPIO bank names in the platform > data. This makes the 'gpio status' command a lot more useful. > > Signed-off-by: James Byrne > > --- Reviewed-by: Eugen Hristev ___ U

[U-Boot] [PATCH] net: phy: micrel: make sure the factory test bit is cleared

2019-10-23 Thread Eugen.Hristev
From: Nicolas Ferre The KSZ8081 PHY has a factory test mode which is set at the de-assertion of the reset line based on the RXER (KSZ8081RNA/RND) or TXC (KSZ8081MNX/RNB) pin. If a pull-down is missing, or if the pin has a pull-up, the factory test mode should be cleared by manually writing a 0 (a

Re: [U-Boot] [PATCH 1/6] misc: microchip_flexcom: introduce microchip_flexcom driver

2019-10-24 Thread Eugen.Hristev
On 09.10.2019 12:23, Eugen Hristev - M18282 wrote: > From: Eugen Hristev > > The Microchip Flexcom is just a wrapper which embeds a SPI controller, > an I2C controller and an USART. > Only one function can be used at a time and is chosen at boot time according > to the device tree. > The bindin

  1   2   3   4   >