[PATCH 0/5] Add spi boot support to am335x-icev2

2020-09-02 Thread Faiz Abbas
The following patches add spi boot support to TI's am335x-icev2 platform Faiz Abbas (5): arm: dts: am335x-icev2: Add spi node configs: Add spiboot support for am335x spi: spi-uclass: Block dm_scan_fdt_dev with OF_CONTROL to prevent build failures spi: omap3_spi: Read platform da

[PATCH 1/5] arm: dts: am335x-icev2: Add spi node

2020-09-02 Thread Faiz Abbas
Add spi and spi nor flash nodes for am335x-icev2. Signed-off-by: Faiz Abbas --- arch/arm/dts/am335x-icev2.dts | 50 +++ 1 file changed, 50 insertions(+) diff --git a/arch/arm/dts/am335x-icev2.dts b/arch/arm/dts/am335x-icev2.dts index 37484cb6f5..2a1b3a53e9

[PATCH 3/5] spi: spi-uclass: Block dm_scan_fdt_dev with OF_CONTROL to prevent build failures

2020-09-02 Thread Faiz Abbas
There are devices which don't use OF_CONTROL or OF_PLATDATA but instead rely on statically defined platdata. Block dm_scan_fdt_dev() with both configs to avoid build failures under this condition. Signed-off-by: Faiz Abbas --- drivers/spi/spi-uclass.c | 2 +- 1 file changed, 1 insertion(

[PATCH 2/5] configs: Add spiboot support for am335x

2020-09-02 Thread Faiz Abbas
am335x internal SRAM is too small to support the addition of SPI bootmode to the default defconfig. Add a separate spiboot_defconfig Signed-off-by: Faiz Abbas --- configs/am335x_evm_spiboot_defconfig | 93 1 file changed, 93 insertions(+) create mode 100644 configs

[PATCH 4/5] spi: omap3_spi: Read platform data in ofdata_to_platdata()

2020-09-02 Thread Faiz Abbas
Add an ofdata_to_platdata() callback to access dts in U-boot and access all platform data in it. This prepares the driver for supporting both device tree as well as static platform data structures in SPL. Signed-off-by: Faiz Abbas --- drivers/spi/omap3_spi.c | 37

[PATCH 5/5] arm: mach-omap2: am33xx: Add device structure for spi

2020-09-02 Thread Faiz Abbas
Add platform data and a device structure for the spi device present on am335x-icev2. This requires moving all omap3_spi platform data structures and symbols to an omap3_spi.h so that the board file can access them. Signed-off-by: Faiz Abbas --- arch/arm/mach-omap2/am33xx/board.c | 12

Re: [PATCH 5/5] arm: mach-omap2: am33xx: Add device structure for spi

2020-09-07 Thread Faiz Abbas
Hi Lokesh, On 07/09/20 12:08 pm, Lokesh Vutla wrote: > > > On 02/09/20 4:48 pm, Faiz Abbas wrote: >> Add platform data and a device structure for the spi device >> present on am335x-icev2. This requires moving all omap3_spi >> platform data structures and symbol

Re: [PATCH 5/5] arm: mach-omap2: am33xx: Add device structure for spi

2020-09-07 Thread Faiz Abbas
Hi Vignesh, On 07/09/20 1:48 pm, Vignesh Raghavendra wrote: > > > On 9/7/20 12:36 PM, Faiz Abbas wrote: >> Hi Lokesh, >> >> On 07/09/20 12:08 pm, Lokesh Vutla wrote: >>> >>> >>> On 02/09/20 4:48 pm, Faiz Abbas wrote: >>>> Add pl

Re: [PATCH 5/5] arm: mach-omap2: am33xx: Add device structure for spi

2020-09-08 Thread Faiz Abbas
Hi Vignesh, On 07/09/20 5:49 pm, Vignesh Raghavendra wrote: > Hi, > > On 9/7/20 4:02 PM, Faiz Abbas wrote: >> Hi Vignesh, >> >> On 07/09/20 1:48 pm, Vignesh Raghavendra wrote: >>> >>> >>> On 9/7/20 12:36 PM, Faiz Abbas wrote: >>>

Re: [PATCH 0/5] Add spi boot support to am335x-icev2

2020-09-10 Thread Faiz Abbas
Hi Lokesh, On 11/09/20 8:16 am, Lokesh Vutla wrote: > > > On 02/09/20 4:47 pm, Faiz Abbas wrote: >> The following patches add spi boot support to TI's am335x-icev2 platform > > > Can you post v2 with comments addressed? I am waiting on this for sending a PR >

[PATCH v2 3/5] arm: mach-omap2: am33xx: Add device structure for spi

2020-09-13 Thread Faiz Abbas
Add platform data and a device structure for the spi device present on am335x-icev2. This requires moving all omap3_spi platform data structures and symbols to an omap3_spi.h so that the board file can access them. Signed-off-by: Faiz Abbas --- arch/arm/mach-omap2/am33xx/board.c | 18

[PATCH v2 2/5] spi: spi-uclass: Block dm_scan_fdt_dev with OF_CONTROL to prevent build failures

2020-09-13 Thread Faiz Abbas
There are devices which don't use OF_CONTROL or OF_PLATDATA but instead rely on statically defined platdata. Block dm_scan_fdt_dev() with both configs to avoid build failures under this condition. Signed-off-by: Faiz Abbas Reviewed-by: Jagan Teki --- drivers/spi/spi-uclass.c | 2 +- 1

[PATCH v2 0/5] Add spi boot support to am335x-icev2

2020-09-13 Thread Faiz Abbas
The following patches add spi boot support to TI's am335x-icev2 platform v2: 1. Changed order of patches to avoid breaking build 2. Changed SPI_OFFSET to SPI0_OFFSET and moved the define arch/arm/mach-omap2/am335x/board.c 3. Updated MAINTAINERS list with the new defconfig. Faiz Abb

[PATCH v2 1/5] arm: dts: am335x-icev2: Add spi node

2020-09-13 Thread Faiz Abbas
Add spi and spi nor flash nodes for am335x-icev2. Signed-off-by: Faiz Abbas --- arch/arm/dts/am335x-icev2.dts | 50 +++ 1 file changed, 50 insertions(+) diff --git a/arch/arm/dts/am335x-icev2.dts b/arch/arm/dts/am335x-icev2.dts index 37484cb6f5..2a1b3a53e9

[PATCH v2 4/5] spi: omap3_spi: Read platform data in ofdata_to_platdata()

2020-09-13 Thread Faiz Abbas
Add an ofdata_to_platdata() callback to access dts in U-boot and access all platform data in it. This prepares the driver for supporting both device tree as well as static platform data structures in SPL. Signed-off-by: Faiz Abbas --- drivers/spi/omap3_spi.c | 37

[PATCH v2 5/5] configs: Add spiboot support for am335x

2020-09-13 Thread Faiz Abbas
am335x internal SRAM is too small to support the addition of SPI bootmode to the default defconfig. Add a separate spiboot_defconfig Signed-off-by: Faiz Abbas --- board/ti/am335x/MAINTAINERS | 1 + configs/am335x_evm_spiboot_defconfig | 93 2 files changed

Re: [PATCH v5 1/4] omap: mmc: Avoid using libfdt with of-platdata

2020-05-04 Thread Faiz Abbas
Hi, On 04/05/20 6:44 pm, Simon Glass wrote: > Hi Bart, > > On Mon, 4 May 2020 at 01:10, Bartosz Golaszewski wrote: >> >> pt., 1 maj 2020 o 20:32 Tom Rini napisał(a): >>> >>> On Thu, Apr 30, 2020 at 01:43:30PM +0200, Bartosz Golaszewski wrote: >>>

Re: Bisected: omap_hsmmc 3.3V IO voltage incompatible with N900 (Was: Re: Bisected: mmc cause reboot loops on N900)

2020-05-07 Thread Faiz Abbas
ers/mmc/mmc.c >> index 523c055967..d07c7745da 100644 >> --- a/drivers/mmc/mmc.c >> +++ b/drivers/mmc/mmc.c >> @@ -2786,18 +2786,7 @@ int mmc_get_op_cond(struct mmc *mmc) >>MMC_QUIRK_RETRY_APP_CMD; >> #endif >> >> -

Re: [PATCH v5 1/4] omap: mmc: Avoid using libfdt with of-platdata

2020-05-14 Thread Faiz Abbas
Simon, On 05/05/20 12:20 pm, Faiz Abbas wrote: > Hi, > > On 04/05/20 6:44 pm, Simon Glass wrote: >> Hi Bart, >> >> On Mon, 4 May 2020 at 01:10, Bartosz Golaszewski wrote: >>> >>> pt., 1 maj 2020 o 20:32 Tom Rini napisał(a): >>>&g

Re: [PATCH v5 1/4] omap: mmc: Avoid using libfdt with of-platdata

2020-05-14 Thread Faiz Abbas
Hi Tom, On 14/05/20 8:29 pm, Tom Rini wrote: > On Thu, May 14, 2020 at 01:49:37PM +0530, Faiz Abbas wrote: >> Simon, >> >> On 05/05/20 12:20 pm, Faiz Abbas wrote: >>> Hi, >>> >>> On 04/05/20 6:44 pm, Simon Glass wrote: >>>> Hi Bart

[PATCH] arm: mach-k3: j721e_init: Add support for backup boot modes

2020-05-16 Thread Faiz Abbas
the ROM code performed the boot using the primary or backup boot mode, and if booted from the backup boot mode, decode the bootmode settings into the appropriate U-Boot mode accordingly so that the boot can proceed. Signed-off-by: Andreas Dannenberg Signed-off-by: Faiz Abbas --- .../arm/mach-k3

Re: Bisected: omap_hsmmc 3.3V IO voltage incompatible with N900 (Was: Re: Bisected: mmc cause reboot loops on N900)

2020-07-02 Thread Faiz Abbas
Hi Pali, On 01/07/20 2:02 pm, Pali Rohár wrote: > On Friday 12 June 2020 15:03:06 Pali Rohár wrote: >> On Tuesday 26 May 2020 19:49:54 Pali Rohár wrote: >>> On Thursday 07 May 2020 17:19:38 Pali Rohár wrote: >>>> On Thursday 07 May 2020 19:10:14 Faiz Abbas wrote: &

[PATCH 02/13] spl: usb: Only init usb once

2020-07-02 Thread Faiz Abbas
usb_init() may be called multiple times for fetching multiple images from SPL. Skip reinitializing USB if its already been done Signed-off-by: Faiz Abbas --- common/spl/spl_usb.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/common/spl/spl_usb.c b/common/spl

[PATCH 04/13] arm: mach-k3: sysfw-loader: Add support to load SYSFW from USB

2020-07-02 Thread Faiz Abbas
Add support for loading system firmware from a USB mass storage device Signed-off-by: Faiz Abbas --- arch/arm/mach-k3/sysfw-loader.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/mach-k3/sysfw-loader.c b/arch/arm/mach-k3/sysfw-loader.c index 513be09c68..0ebd8c56a7

[PATCH 00/13] Add support for USB host and peripheral bootmodes on am65x-idk

2020-07-02 Thread Faiz Abbas
USB subsystem which is a longer term effort Faiz Abbas (13): spl: usb: Create an API spl_usb_load() spl: usb: Only init usb once armv7R: K3: am654: Use full malloc in SPL both pre and post reloc arm: mach-k3: sysfw-loader: Add support to load SYSFW from USB arm: mach-k3: am6_init: Gate mmc

[PATCH 03/13] armv7R: K3: am654: Use full malloc in SPL both pre and post reloc

2020-07-02 Thread Faiz Abbas
go ahead and enable the use of the full malloc by manually initializing the required functionality inside board_init_f by creating a full malloc pool inside the pre-relocation malloc pool. Signed-off-by: Faiz Abbas --- arch/arm/mach-k3/am6_init.c | 18 ++ 1 file changed, 18

[PATCH 01/13] spl: usb: Create an API spl_usb_load()

2020-07-02 Thread Faiz Abbas
Create a new API spl_usb_load() that takes the filename as a parameter instead of taking the default U-boot PAYLOAD_NAME Signed-off-by: Faiz Abbas --- common/spl/spl_usb.c | 20 +--- include/spl.h| 14 ++ 2 files changed, 27 insertions(+), 7 deletions

[PATCH 05/13] arm: mach-k3: am6_init: Gate mmc related configurations with the appropriate config

2020-07-02 Thread Faiz Abbas
Gate mmc related system related configurations with DM_MMC to avoid build errors when MMC is not enabled Signed-off-by: Faiz Abbas --- arch/arm/mach-k3/am6_init.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-k3/am6_init.c b/arch/arm/mach-k3/am6_init.c

[PATCH 07/13] arm: mach-k3: am6_init: Add support for USB boot mode

2020-07-02 Thread Faiz Abbas
Add support for identifying USB host and device boot modes Signed-off-by: Faiz Abbas --- arch/arm/mach-k3/am6_init.c | 5 + arch/arm/mach-k3/include/mach/am6_hardware.h | 2 ++ arch/arm/mach-k3/include/mach/am6_spl.h | 3 ++- 3 files changed, 9 insertions(+), 1

[PATCH 06/13] arm: mach-k3: am6_init: Do USB fixups to facilitate host and device boot modes

2020-07-02 Thread Faiz Abbas
ed for accessing the interface at USB 2.0 speeds Signed-off-by: Faiz Abbas --- arch/arm/mach-k3/am6_init.c | 68 +++-- 1 file changed, 66 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-k3/am6_init.c b/arch/arm/mach-k3/am6_init.c index 42d13a39f8..b65860fe

[PATCH 08/13] arm: dts: k3-am654-r5-base-board: Add USB0 nodes

2020-07-02 Thread Faiz Abbas
Add USB0 nodes and set them to host mode to support USB host and peripheral boot modes Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-am654-r5-base-board.dts | 35 + 1 file changed, 35 insertions(+) diff --git a/arch/arm/dts/k3-am654-r5-base-board.dts b/arch/arm/dts/k3

[PATCH 09/13] arm: dts: k3-am654-base-board: Add support for USB0 in SPL

2020-07-02 Thread Faiz Abbas
Add nodes for USB0 in SPL to enable USB host boot mode Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-am654-base-board-u-boot.dtsi | 27 1 file changed, 27 insertions(+) diff --git a/arch/arm/dts/k3-am654-base-board-u-boot.dtsi b/arch/arm/dts/k3-am654-base-board-u

[PATCH 11/13] configs: am65x_evm_a53: Enable USB Mass storage and DFU boot modes

2020-07-02 Thread Faiz Abbas
Enable configs to facilitate booting from USB Mass Storage devices as well as USB peripheral boot Signed-off-by: Faiz Abbas --- configs/am65x_evm_a53_defconfig | 9 + include/configs/am65x_evm.h | 2 ++ 2 files changed, 11 insertions(+) diff --git a/configs/am65x_evm_a53_defconfig

[PATCH 12/13] configs: Add new config for supporting USB mass storage boot

2020-07-02 Thread Faiz Abbas
Because of space constraints, create a new USB defconfig for R5 to faciliate booting from USB mass storage devices Signed-off-by: Faiz Abbas --- configs/am65x_evm_r5_usbmsc_defconfig | 119 ++ 1 file changed, 119 insertions(+) create mode 100644 configs

[PATCH 13/13] configs: Add defconfig for USB DFU bootmode

2020-07-02 Thread Faiz Abbas
Because of space constraints, create a new USB defconfig for R5 to faciliate booting in USB peripheral (DFU) bootmode Signed-off-by: Faiz Abbas --- configs/am65x_evm_r5_usbdfu_defconfig | 119 ++ 1 file changed, 119 insertions(+) create mode 100644 configs

[PATCH 10/13] configs: am65x_evm: Add support for DFU related configs

2020-07-02 Thread Faiz Abbas
Add offset and environment related configs used for booting from DFU. Signed-off-by: Faiz Abbas --- include/configs/am65x_evm.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/include/configs/am65x_evm.h b/include/configs/am65x_evm.h index 19d861d402..5435ef85c7

Re: [PATCH] mmc: omap_hsmmc: Set 3.3V for IO voltage on all places

2020-07-05 Thread Faiz Abbas
gt; This patch fixes that problematic commit and changes 3.0V to 3.3V on all > remaining places in omap_hsmmc driver. > > Fixes: d2c05f50e12f ("mmc: omap_hsmmc: Set 3.3V for IO voltage") > Signed-off-by: Pali Rohár > --- Reviewed-by: Faiz Abbas Thanks, Faiz

Re: [PATCH v2 04/10] mmc: sdhci: Expose sdhci_init() as non-static

2020-02-17 Thread Faiz Abbas
Jaehoon, On 17/02/20 5:47 pm, Jaehoon Chung wrote: > Hi, > > On 2/5/20 4:33 PM, Faiz Abbas wrote: >> Hi Peng, >> >> On 05/02/20 12:58 pm, Peng Fan wrote: >>>> Subject: Re: [PATCH v2 04/10] mmc: sdhci: Expose sdhci_init() as non-static >>>

Re: [PATCH v2 04/10] mmc: sdhci: Expose sdhci_init() as non-static

2020-02-17 Thread Faiz Abbas
Jaehoon, On 18/02/20 4:54 am, Jaehoon Chung wrote: > Hi Faiz, > > On 2/18/20 7:35 AM, Jaehoon Chung wrote: >> Hi Faiz, >> >> On 2/17/20 9:42 PM, Faiz Abbas wrote: >>> Jaehoon, >>> >>> On 17/02/20 5:47 pm, Jaehoon Chung wrote: >>>>

[PATCH v3 00/11] Add Support for eMMC boot in AM65x and J721e

2020-02-26 Thread Faiz Abbas
e and sdhci layers respectively. 3. Fixed up config_pm_pre_callback() call order in patch 9. v2: 1. Reordered the patches according to Lokesh's preference 2. Fixed patch 2 breaking platforms where DM_MMC is not enabled. Faiz Abbas (11): mmc: Add a saved_clock member mmc: Add a deferred_p

[PATCH v3 01/11] mmc: Add a saved_clock member

2020-02-26 Thread Faiz Abbas
Add a saved_clock member to struct mmc to store the previous clock speed in the clock needs to be stopped for some time. Signed-off-by: Faiz Abbas Signed-off-by: Lokesh Vutla --- include/mmc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/mmc.h b/include/mmc.h index 71e2e1735a

[PATCH v3 02/11] mmc: Add a deferred_probe() API

2020-02-26 Thread Faiz Abbas
Add a deferred_probe() API for platforms that want to do some configurations just before starting to enumerate the device. Signed-off-by: Faiz Abbas --- drivers/mmc/mmc-uclass.c | 15 +++ drivers/mmc/mmc.c| 4 +++- include/mmc.h| 10 ++ 3 files changed

[PATCH v3 06/11] mmc: am654_sdhci: Implement workaround for card detect

2020-02-26 Thread Faiz Abbas
uch a long time. Signed-off-by: Faiz Abbas Signed-off-by: Lokesh Vutla --- drivers/mmc/am654_sdhci.c | 109 -- 1 file changed, 68 insertions(+), 41 deletions(-) diff --git a/drivers/mmc/am654_sdhci.c b/drivers/mmc/am654_sdhci.c index 92e7100f56..ca76e1f559 10

[PATCH v3 04/11] mmc: Merge SD_LEGACY and MMC_LEGACY bus modes

2020-02-26 Thread Faiz Abbas
MMC_LEGACY & SD_LEGACY are not differentiated timings in the spec and don't have any meaningful differences. Therefore, get rid of all references to SD_LEGACY and use MMC_LEGACY to mean both of them. Signed-off-by: Faiz Abbas Signed-off-by: Lokesh Vutla --- drivers/mmc/fsl_esdhc_i

[PATCH v3 07/11] spl: mmc: Fix spl_mmc_get_uboot_raw_sector() implementation

2020-02-26 Thread Faiz Abbas
The call to spl_mmc_get_uboot_raw_sector() completely ignores and overwrites the raw_sect value passed from the caller of spl_mmc_load(). Fix this by passing raw_sect to the function and returning the same value in the default case. Signed-off-by: Faiz Abbas Signed-off-by: Lokesh Vutla

[PATCH v3 03/11] sdhci: Add sdhci_deferred_probe() API

2020-02-26 Thread Faiz Abbas
Add the sdhci_deferred_probe() function to register as the deferred_probe() callback to the mmc core. It will in turn call the deferred_probe() callback of the platform drivers as declared in the sdhci_ops. Signed-off-by: Faiz Abbas --- drivers/mmc/sdhci.c | 15 +++ include/sdhci.h

[PATCH v3 05/11] mmc: am654_sdhci: Update output tap delay writes

2020-02-26 Thread Faiz Abbas
With the latest RIOT, there is a different otap delay value for each speed mode. Add a new binding with every supported speed mode. Also disable a given speed mode in the host caps if its corresponding otap-del-sel is not present. Signed-off-by: Faiz Abbas Signed-off-by: Lokesh Vutla --- arch

[PATCH v3 10/11] configs: am65x_evm: Add CONFIG_SUPPORT_EMMC_BOOT

2020-02-26 Thread Faiz Abbas
With CONFIG_SUPPORT_EMMC_BOOT moved to Kconfig, move it to defconfig files. Signed-off-by: Faiz Abbas Signed-off-by: Lokesh Vutla --- configs/am65x_evm_a53_defconfig | 1 + configs/am65x_evm_r5_defconfig | 1 + include/configs/am65x_evm.h | 2 -- 3 files changed, 2 insertions(+), 2

[PATCH v3 08/11] arm: K3: sysfw-loader: Add a config_pm_pre_callback()

2020-02-26 Thread Faiz Abbas
eMMC clock before power management and restart it after it is done. Signed-off-by: Faiz Abbas Signed-off-by: Lokesh Vutla --- arch/arm/mach-k3/am6_init.c | 33 +++- arch/arm/mach-k3/include/mach/sysfw-loader.h | 2 +- arch/arm/mach-k3/j721e_init.c

[PATCH v3 09/11] arm: dts: k3-j721e-r5-common-proc-board: Use unique names for dummy clocks

2020-02-26 Thread Faiz Abbas
Update the dummy clock names to use unique identifiers. Otherwise the previous node just gets overwitten by the next one with the same name. This fixes eMMC boot not working on J721e-evm. Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-j721e-r5-common-proc-board.dts | 4 ++-- 1 file changed, 2

[PATCH v3 11/11] configs: j721e_evm: Add Support for eMMC boot

2020-02-26 Thread Faiz Abbas
Enable configs to support eMMC boot. Signed-off-by: Faiz Abbas Signed-off-by: Lokesh Vutla --- configs/j721e_evm_a72_defconfig | 3 +++ configs/j721e_evm_r5_defconfig | 3 +++ 2 files changed, 6 insertions(+) diff --git a/configs/j721e_evm_a72_defconfig b/configs/j721e_evm_a72_defconfig

Re: [PATCH v3 00/11] Add Support for eMMC boot in AM65x and J721e

2020-03-03 Thread Faiz Abbas
Peng, On 26/02/20 4:31 pm, Jaehoon Chung wrote: > Hi Faiz, > > On 2/26/20 5:14 PM, Faiz Abbas wrote: >> The following patches add support for eMMC boot in TI's Am65x and J721e >> devices. > > About adding deferred_probe(), i want to know Peng's opinion. &g

[U-Boot] [PATCH] thermal: ti-bandgap: Fix adc value datatype

2019-11-11 Thread Faiz Abbas
The CORE_TEMP_SENSOR_MPU register gives a raw adc value which needs to be indexed into a lookup table to get the actual temperature. Fix the naming and datatype of the adc value variable. Signed-off-by: Faiz Abbas --- drivers/thermal/ti-bandgap.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[U-Boot] [PATCH] net: cpsw: Add NULL pointer check

2019-11-11 Thread Faiz Abbas
Add null pointer check to take care of out of memory errors. Signed-off-by: Faiz Abbas --- drivers/net/ti/cpsw.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ti/cpsw.c b/drivers/net/ti/cpsw.c index 4a990be93e..b710ae4053 100644 --- a/drivers/net/ti/cpsw.c +++ b/drivers/net

[U-Boot] [PATCH] regmap: Fix potential memory leaks

2019-11-11 Thread Faiz Abbas
Free allocated memory in case of an error in regmap_init_mem() and regmap_init_mem_index(). Signed-off-by: Faiz Abbas --- drivers/core/regmap.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/core/regmap.c b/drivers/core/regmap.c index e9e55c9d16

Re: [U-Boot] [RESEND PATCH v2 12/13] davinci: omapl138-lcdk: enable driver-model in SPL

2019-11-11 Thread Faiz Abbas
Hi Bartosz, On 08/11/19 9:20 PM, Bartosz Golaszewski wrote: > pt., 25 paź 2019 o 18:10 Bartosz Golaszewski napisał(a): >> >> czw., 26 wrz 2019 o 01:21 Faiz Abbas napisał(a): >>> >>> Hi, >>> >>> On 29/07/19 12:28 PM, Bartosz Golaszewski wrot

[U-Boot] [PATCH 0/8] Add Support for MMC/SD in J721e

2019-11-19 Thread Faiz Abbas
The following patches add support for MMC/SD in J721e. Currently, SD card is capped at 25 MBps and eMMC is capped at 50 MBps. Support for higher speeds and eMMC boot support will be added in futures series. Faiz Abbas (8): mmc: am654_sdhci: Get Xin clock by name mmc: am654_sdhci: Add Support

[U-Boot] [PATCH 1/8] mmc: am654_sdhci: Get Xin clock by name

2019-11-19 Thread Faiz Abbas
Get clk_xin by name instead of by index to avoid having to put clocks in the same order in all devices. Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-am654-base-board-u-boot.dtsi | 3 ++- drivers/mmc/am654_sdhci.c| 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff

[U-Boot] [PATCH 2/8] mmc: am654_sdhci: Add Support for configuring PHY in J721e

2019-11-19 Thread Faiz Abbas
compared to 4 bit wide for AM65x. Add yet another flag to indicate this difference. Strobe select is used only for HS400 speed mode, support for which has not been added in AM65x. Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 127 +- 1 file changed, 98

[U-Boot] [PATCH 3/8] arm: dts: k3-j721e-common-proc-board: Remove voltage-ranges from sdhci nodes

2019-11-19 Thread Faiz Abbas
voltage-ranges properties are NOP. Remove them. Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-j721e-common-proc-board.dts | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/dts/k3-j721e-common-proc-board.dts b/arch/arm/dts/k3-j721e-common-proc-board.dts index c978cabd13..f5c65f244f

[U-Boot] [PATCH 4/8] arm: dts: k3-j721e-common-proc-board: Add pinmux for SD card

2019-11-19 Thread Faiz Abbas
Add pinmux for sdhci1 node connected to the SD card. Signed-off-by: Faiz Abbas --- .../k3-j721e-common-proc-board-u-boot.dtsi| 4 arch/arm/dts/k3-j721e-common-proc-board.dts | 20 ++- .../arm/dts/k3-j721e-r5-common-proc-board.dts | 16 +++ 3 files changed

[U-Boot] [PATCH 5/8] configs: j721e_evm: Add configs for ADMA Support

2019-11-19 Thread Faiz Abbas
Add configs for ADMA Support. Signed-off-by: Faiz Abbas --- configs/j721e_evm_a72_defconfig | 2 ++ configs/j721e_evm_r5_defconfig | 1 + 2 files changed, 3 insertions(+) diff --git a/configs/j721e_evm_a72_defconfig b/configs/j721e_evm_a72_defconfig index f9396e612b..b8e8ce310e 100644 --- a

[U-Boot] [PATCH 6/8] configs: j721e_evm_a72: Enable FAT_WRITE

2019-11-19 Thread Faiz Abbas
Enable CONFIG_FAT_WRITE Signed-off-by: Faiz Abbas --- configs/j721e_evm_a72_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/j721e_evm_a72_defconfig b/configs/j721e_evm_a72_defconfig index b8e8ce310e..1b69817732 100644 --- a/configs/j721e_evm_a72_defconfig +++ b/configs

[U-Boot] [PATCH 7/8] configs: j721e_evm_a72: Add Support for GPT partitions

2019-11-19 Thread Faiz Abbas
Add CONFIG_CMD_GPT to help write GPT partitions to the eMMC. Also introduce a default GPT partition table. Signed-off-by: Faiz Abbas --- configs/j721e_evm_a72_defconfig | 1 + include/configs/j721e_evm.h | 6 ++ 2 files changed, 7 insertions(+) diff --git a/configs

[U-Boot] [PATCH 8/8] configs: j721e_evm_r5: Add configs for environment in eMMC

2019-11-19 Thread Faiz Abbas
Add config to save and read back environment from eMMC. Signed-off-by: Faiz Abbas --- configs/j721e_evm_a72_defconfig | 3 +++ include/configs/j721e_evm.h | 9 + 2 files changed, 12 insertions(+) diff --git a/configs/j721e_evm_a72_defconfig b/configs/j721e_evm_a72_defconfig index

[U-Boot] [PATCH] configs: am65x_evm: Add Support for ADMA

2019-11-19 Thread Faiz Abbas
Add Support for ADMA in a53 and r5 defconfigs. Signed-off-by: Faiz Abbas --- configs/am65x_evm_a53_defconfig | 2 ++ configs/am65x_evm_r5_defconfig | 1 + 2 files changed, 3 insertions(+) diff --git a/configs/am65x_evm_a53_defconfig b/configs/am65x_evm_a53_defconfig index 027e0a5948

Re: [PATCH v5 1/4] omap: mmc: Avoid using libfdt with of-platdata

2020-04-28 Thread Faiz Abbas
+Bartosz On 28/04/20 9:47 am, Lokesh Vutla wrote: > +Faiz, > > On 28/04/20 12:29 AM, Tom Rini wrote: >> On Mon, Apr 27, 2020 at 05:33:41AM +, Peng Fan wrote: Subject: [PATCH v5 1/4] omap: mmc: Avoid using libfdt with of-platdata At present this driver is enabled in SPL on omapl

[U-Boot] [PATCH v2 00/11] Add Support for UFS subsystem for TI's J721e

2019-10-15 Thread Faiz Abbas
S device driver. References: [1] JESD220D UFS 3.0: https://www.jedec.org/standards-documents/docs/jesd220c [2] JESD223D UFS Host Controller Interface (UFSHCI) version 3.0: https://www.jedec.org/standards-documents/docs/jesd223c Faiz Abbas (11): scsi: Simplify scsi_read()/_writ

[U-Boot] [PATCH v2 04/11] scsi: Add dma direction member to command structure

2019-10-15 Thread Faiz Abbas
Some SCSI devices like UFS use DMA for executing scsi commands and hence need to know the direction of transfer of the dma. Add a dma_dir element to the command structure to facilitate this. Signed-off-by: Faiz Abbas --- drivers/scsi/scsi.c | 4 include/scsi.h | 3 +++ 2 files changed

[U-Boot] [PATCH v2 01/11] scsi: Simplify scsi_read()/_write()

2019-10-15 Thread Faiz Abbas
With no non-DM driver using scsi_read()/_write() APIs, remove the legacy implementations. Signed-off-by: Faiz Abbas --- drivers/scsi/scsi.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c index 48cb2a2818..009d80faa7 100644

[U-Boot] [PATCH v2 03/11] scsi: Retry inquiry 3 times to overcome Unit Attention condition

2019-10-15 Thread Faiz Abbas
The UFS SCSI device LUNs are observed to return failure the first time a unit ready inquiry is sent and pass on the second try. Send this inquiry 3 times to make sure device is ready. Signed-off-by: Faiz Abbas --- drivers/scsi/scsi.c | 12 +--- 1 file changed, 9 insertions(+), 3

[U-Boot] [PATCH v2 06/11] ufs: Add Support for Cadence platform UFS driver

2019-10-15 Thread Faiz Abbas
Add Support for the platform driver for the Cadence device present on TI's J721e device. Signed-off-by: Faiz Abbas --- drivers/ufs/Kconfig | 8 +++ drivers/ufs/Makefile| 1 + drivers/ufs/cdns-platform.c | 122 3 files changed

[U-Boot] [PATCH v2 07/11] ufs: Add glue layer driver for TI J721E devices

2019-10-15 Thread Faiz Abbas
Add glue layer driver for the controller present on TI's J721E devices. Signed-off-by: Faiz Abbas --- drivers/ufs/Kconfig| 6 drivers/ufs/Makefile | 1 + drivers/ufs/ti-j721e-ufs.c | 71 ++ 3 files changed, 78 insertions(+) create

[U-Boot] [PATCH v2 09/11] cmd: Add Support for UFS commands

2019-10-15 Thread Faiz Abbas
Add Support for commands to initialize and configure UFS devices. TODO: Add Support for commands to resize and reconfigure LUNs Signed-off-by: Faiz Abbas --- cmd/Kconfig | 7 +++ cmd/Makefile | 2 +- cmd/ufs.c| 37 + 3 files changed, 45 insertions

[U-Boot] [PATCH v2 02/11] scsi: Add max_bytes_per_req to scsi_platdata

2019-10-15 Thread Faiz Abbas
Add max_bytes_per_req to scsi_platdata to enable the host driver to limit the number of bytes that can be read/written per request. Signed-off-by: Faiz Abbas --- drivers/scsi/scsi.c | 45 ++--- include/scsi.h | 2 ++ 2 files changed, 28 insertions

[U-Boot] [PATCH v2 05/11] ufs: Add Initial Support for UFS subsystem

2019-10-15 Thread Faiz Abbas
from Linux Kernel v5.2 (drivers/scsi/ufs/ufshcd.c) and ported to U-boot. Signed-off-by: Faiz Abbas --- MAINTAINERS |5 + drivers/Kconfig |2 + drivers/Makefile |1 + drivers/ufs/Kconfig |9 + drivers/ufs/Makefile |6 + drivers/ufs/ufs

[U-Boot] [PATCH v2 11/11] configs: j721e_evm_a72: Enable configs for UFS

2019-10-15 Thread Faiz Abbas
Enable SCSI and UFS related configs. Signed-off-by: Faiz Abbas --- configs/j721e_evm_a72_defconfig | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/configs/j721e_evm_a72_defconfig b/configs/j721e_evm_a72_defconfig index 6729e03620..bfb7c15cae 100644 --- a/configs

[U-Boot] [PATCH v2 08/11] arm: dts: k3-j721e-main: Add UFS nodes

2019-10-15 Thread Faiz Abbas
Add TI UFS glue layer and Cadence UFS Host controller DT nodes. Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-j721e-main.dtsi | 24 1 file changed, 24 insertions(+) diff --git a/arch/arm/dts/k3-j721e-main.dtsi b/arch/arm/dts/k3-j721e-main.dtsi index 6bd59bac52

[U-Boot] [PATCH v2 10/11] env: ti: Add environment variables to boot from UFS

2019-10-15 Thread Faiz Abbas
Add environment variables to boot kernel from a filesystem contained in the 2nd UFS LUN. The user can boot from a ufs filesystem just by entering the following commands. => setenv boot ufs => boot Signed-off-by: Faiz Abbas --- include/configs/j721e_evm.h | 4 +++- include/environm

Re: [U-Boot] [PATCH v2 00/11] Add Support for UFS subsystem for TI's J721e

2019-10-23 Thread Faiz Abbas
Tom, On 15/10/19 6:24 PM, Faiz Abbas wrote: > The following patches add support for the Universal Flash Storage (UFS) > subsystem and its implementation on TI's J721e platform. > > The UFS Application Layer (UAP) uses SCSI SAM-4 command set for > communication with the de

Re: [PATCH 2/7] mmc: zynq_sdhci: Define timing macro's

2020-06-10 Thread Faiz Abbas
Hi Ashok, On 10/06/20 2:48 pm, Ashok Reddy Soma wrote: > Hi Faiz, > >> -Original Message----- >> From: Faiz Abbas >> Sent: Wednesday, May 27, 2020 12:28 PM >> To: Jaehoon Chung ; Michal Simek >> ; u-boot@lists.denx.de; git >> Cc: Ashok Reddy So

Re: am654_sdhci: mmc fail to send stop cmd

2020-07-21 Thread Faiz Abbas
Jan, On 21/07/20 12:06 pm, Jan Kiszka wrote: > On 21.07.20 01:23, Jaehoon Chung wrote: >> On 7/20/20 10:21 AM, Peng Fan wrote: >>> Hi Jan, >>> Subject: am654_sdhci: mmc fail to send stop cmd Hi all, on one device with one specific SD-card (possibly an aging one), I'm seein

Re: am654_sdhci: mmc fail to send stop cmd

2020-07-22 Thread Faiz Abbas
Jan, On 21/07/20 10:52 pm, Jan Kiszka wrote: > On 21.07.20 19:03, Faiz Abbas wrote: >> Jan, >> >> On 21/07/20 12:06 pm, Jan Kiszka wrote: >>> On 21.07.20 01:23, Jaehoon Chung wrote: >>>> On 7/20/20 10:21 AM, Peng Fan wrote: >>>>> Hi Jan,

[PATCH] mmc: sdhci: Enable high speed conditional on the correspnding bit

2020-07-22 Thread Faiz Abbas
The capabilities register has a field to indicate whether the host supports high speed mode or not. Add high speed host_caps based on this bit instead of enabling it by default. Signed-off-by: Faiz Abbas --- drivers/mmc/sdhci.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

Re: am654_sdhci: mmc fail to send stop cmd

2020-07-22 Thread Faiz Abbas
Jan, On 23/07/20 8:55 am, Faiz Abbas wrote: > Jan, > > On 21/07/20 10:52 pm, Jan Kiszka wrote: >> On 21.07.20 19:03, Faiz Abbas wrote: >>> Jan, >>> >>> On 21/07/20 12:06 pm, Jan Kiszka wrote: >>>> On 21.07.20 01:23, Jaehoon Chung wrote: &g

Re: [PATCH 14/18] mmc: am654_sdhci: Add support for J7200 devices

2020-07-23 Thread Faiz Abbas
Hi Lokesh, On 23/07/20 2:17 pm, Lokesh Vutla wrote: > From: Faiz Abbas > > Add support for SDHCI controllers present on the J7200 device > > Signed-off-by: Faiz Abbas > --- This patch is not required. Lets have both j721e and j7200 compatibles in the dt and use only j721e

Re: [PATCH 15/18] arm: dts: k3-j7200: Add dts support

2020-07-23 Thread Faiz Abbas
ra > Signed-off-by: Vishal Mahaveer > Signed-off-by: Faiz Abbas > --- > arch/arm/dts/Makefile | 4 +- > .../k3-j7200-common-proc-board-u-boot.dtsi| 92 + > arch/arm/dts/k3-j7200-common-proc-board.dts | 94 ++ > arc

[PATCH] mmc: am654_sdhci: Use MMC_MODES_END value instead of hardcoded value

2020-07-28 Thread Faiz Abbas
The hardcoded array size leads to array overflows with changes in speed modes enum in mmc core. Use MMC_MODES_END for otap_del_sel array declaration to fix this. Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH] mmc: sdhci: Setup HS modes based on HISPD bit

2020-07-29 Thread Faiz Abbas
Hi, On 29/07/20 8:27 pm, Michal Simek wrote: > There is no reason to setup HS modes by default without checking bit in > capability register. > Setting up HS mode by default breaks option to disable HS mode via > sdhci-caps-mask DT property. > > Disabling HS mode can be done via DT as: > sdhci-ca

[PATCH v2 02/13] spl: usb: Only init usb once

2020-08-02 Thread Faiz Abbas
usb_init() may be called multiple times for fetching multiple images from SPL. Skip reinitializing USB if its already been done Signed-off-by: Faiz Abbas --- common/spl/spl_usb.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/common/spl/spl_usb.c b/common/spl

[PATCH v2 00/13] Add support for USB host and peripheral bootmodes on am65x-idk

2020-08-02 Thread Faiz Abbas
USB subsystem which is a longer term effort v2: Using fdtdec_board_setup() function override in patch 6 instead of open coding spl_common_init() Faiz Abbas (13): spl: usb: Create an API spl_usb_load() spl: usb: Only init usb once armv7R: K3: am654: Use full malloc in SPL both pre and post

[PATCH v2 01/13] spl: usb: Create an API spl_usb_load()

2020-08-02 Thread Faiz Abbas
Create a new API spl_usb_load() that takes the filename as a parameter instead of taking the default U-boot PAYLOAD_NAME Signed-off-by: Faiz Abbas --- common/spl/spl_usb.c | 20 +--- include/spl.h| 14 ++ 2 files changed, 27 insertions(+), 7 deletions

[PATCH v2 03/13] armv7R: K3: am654: Use full malloc in SPL both pre and post reloc

2020-08-02 Thread Faiz Abbas
go ahead and enable the use of the full malloc by manually initializing the required functionality inside board_init_f by creating a full malloc pool inside the pre-relocation malloc pool. Signed-off-by: Faiz Abbas --- arch/arm/mach-k3/am6_init.c | 18 ++ 1 file changed, 18

[PATCH v2 06/13] arm: mach-k3: am6_init: Do USB fixups to facilitate host and device boot modes

2020-08-02 Thread Faiz Abbas
speeds. Signed-off-by: Faiz Abbas --- arch/arm/mach-k3/am6_init.c | 40 + 1 file changed, 40 insertions(+) diff --git a/arch/arm/mach-k3/am6_init.c b/arch/arm/mach-k3/am6_init.c index 42d13a39f8..c6d4f05a01 100644 --- a/arch/arm/mach-k3/am6_init.c ++

[PATCH v2 04/13] arm: mach-k3: sysfw-loader: Add support to load SYSFW from USB

2020-08-02 Thread Faiz Abbas
Add support for loading system firmware from a USB mass storage device Signed-off-by: Faiz Abbas --- arch/arm/mach-k3/sysfw-loader.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/mach-k3/sysfw-loader.c b/arch/arm/mach-k3/sysfw-loader.c index 513be09c68..0ebd8c56a7

[PATCH v2 05/13] arm: mach-k3: am6_init: Gate mmc related configurations with the appropriate config

2020-08-02 Thread Faiz Abbas
Gate mmc related system related configurations with DM_MMC to avoid build errors when MMC is not enabled Signed-off-by: Faiz Abbas --- arch/arm/mach-k3/am6_init.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-k3/am6_init.c b/arch/arm/mach-k3/am6_init.c

[PATCH v2 07/13] arm: mach-k3: am6_init: Add support for USB boot mode

2020-08-02 Thread Faiz Abbas
Add support for identifying USB host and device boot modes Signed-off-by: Faiz Abbas --- arch/arm/mach-k3/am6_init.c | 5 + arch/arm/mach-k3/include/mach/am6_hardware.h | 2 ++ arch/arm/mach-k3/include/mach/am6_spl.h | 3 ++- 3 files changed, 9 insertions(+), 1

[PATCH v2 11/13] configs: am65x_evm_a53: Enable USB Mass storage and DFU boot modes

2020-08-02 Thread Faiz Abbas
Enable configs to facilitate booting from USB Mass Storage devices as well as USB peripheral boot Signed-off-by: Faiz Abbas --- configs/am65x_evm_a53_defconfig | 10 ++ include/configs/am65x_evm.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/configs

[PATCH v2 12/13] configs: Add defconfig for USB DFU bootmode

2020-08-02 Thread Faiz Abbas
Because of space constraints, create a new USB defconfig for R5 to faciliate booting in USB peripheral (DFU) bootmode Signed-off-by: Faiz Abbas --- configs/am65x_evm_r5_usbdfu_defconfig | 120 ++ 1 file changed, 120 insertions(+) create mode 100644 configs

[PATCH v2 10/13] configs: am65x_evm: Add support for DFU related configs

2020-08-02 Thread Faiz Abbas
Add offset and environment related configs used for booting from DFU. Signed-off-by: Faiz Abbas --- include/configs/am65x_evm.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/configs/am65x_evm.h b/include/configs/am65x_evm.h index 19d861d402..902b5ba398 100644

  1   2   3   4   5   6   >