Re: [U-Boot] [PATCH v3 00/25] dm: Introduce Rockchip RK3288 support

2015-06-24 Thread Heiko Stübner
Am Mittwoch, 24. Juni 2015, 09:54:07 schrieb Kevin Hilman: Simon Glass s...@chromium.org writes: The Rockchip RK3288 is based on a quad-core Cortex-A17 CPU and has a good set of peripherals. Various full-featured U-Boot ports are available and this is an attempt to bring those features into

Re: [U-Boot] [PATCH] mips: fix DTC unit warnings

2016-04-15 Thread Heiko Stübner
Am Freitag, 15. April 2016, 12:30:58 schrieb Tom Rini: > On Fri, Apr 15, 2016 at 05:23:54PM +0200, Andreas Färber wrote: > > Am 15.04.2016 um 12:59 schrieb Heiko Schocher: > > > Fix following warnings for all mips based boards: > > > mips: + pic32mzdask > > > > > > +Warning

Re: [U-Boot] [PATCH v2 7/8] rockchip: rk3188: add core support

2016-07-22 Thread Heiko Stübner
Am Freitag, 22. Juli 2016, 23:51:11 schrieb Heiko Stuebner: > Add the core architecture code for the rk3188. > It doesn't support the SPL yet, as because of some > unknown error it doesn't start yet. > > Signed-off-by: Heiko Stuebner > --- > arch/arm/dts/rk3188.dtsi

Re: [U-Boot] [PATCH v2 0/8] basic rockchip rk3188 support

2016-07-28 Thread Heiko Stübner
Hi Simon, Am Mittwoch, 27. Juli 2016, 21:42:47 schrieb Simon Glass: > On 22 July 2016 at 15:51, Heiko Stuebner wrote: > > Second version. Simon already applied the cleanup patches from my > > first version. I've tried to address Simons comments and hopefully > > haven't

Re: [U-Boot] [PATCH 9/9] rockchip: rk3188: Add clock driver

2016-07-17 Thread Heiko Stübner
Am Sonntag, 17. Juli 2016, 08:13:58 schrieb Simon Glass: > Hi Heiko, > > On 15 July 2016 at 16:17, Heiko Stuebner wrote: > > Add a driver for setting up and modifying the various PLLs and peripheral > > clocks on the RK3188. > > > > Signed-off-by: Heiko Stuebner

Re: [U-Boot] [PATCH 0/9] rockchip: cosmetics, a fix and first steps on the rk3188

2016-07-17 Thread Heiko Stübner
Am Sonntag, 17. Juli 2016, 08:14:06 schrieb Simon Glass: > Hi Heiko, > > On 15 July 2016 at 16:17, Heiko Stuebner wrote: > > I've made some nice progress on using mainline uboot on the rk3188 > > and would like to dump some first results. > > > > Right now I can use uboot on

Re: [U-Boot] [PATCH 7/9] rockchip: rk3188: Add pinctrl driver

2016-07-17 Thread Heiko Stübner
Hi Simon, Am Sonntag, 17. Juli 2016, 08:13:51 schrieb Simon Glass: > On 15 July 2016 at 16:17, Heiko Stuebner wrote: > > Add a driver which supports pin multiplexing setup for the most commonly > > used peripherals. > > > > Signed-off-by: Heiko Stuebner > >

Re: [U-Boot] [PATCH 0/9] rockchip: cosmetics, a fix and first steps on the rk3188

2016-07-18 Thread Heiko Stübner
Hi Simon, Am Montag, 18. Juli 2016, 06:16:33 schrieb Simon Glass: > On 17 July 2016 at 09:27, Simon Glass <s...@chromium.org> wrote: > > On 17 July 2016 at 09:20, Heiko Stübner <he...@sntech.de> wrote: > >> Am Sonntag, 17. Juli 2016, 08:14:06 schri

Re: [U-Boot] [PATCH 2/2] ARM64: rockchip: Add initial support for RK3368 based GeekBox

2016-07-18 Thread Heiko Stübner
Hi Andreas, Am Montag, 18. Juli 2016, 03:06:07 schrieb Andreas Färber: > The RK3368 is an octa-core Cortex-A53 SoC from Rockchip. > > The GeekBox is a TV box from GeekBuying, based on an MXM3 module. > The module can be used with base boards such as the GeekBox Landingship. > > This adds basic

Re: [U-Boot] [PATCH v3 0/5] add support for rk3399 soc and evb

2016-07-15 Thread Heiko Stübner
Hi Kever, Am Freitag, 15. Juli 2016, 16:42:08 schrieb Kever Yang: > This patchset add support for rk3399 with ATF based on > Rockchip miniloader as secondary bootloader instead of > u-boot SPL. > > Rockchip miniloader init the DRAM and load the ATF and > u-boot to runing address, and then jump

Re: [U-Boot] [PATCH] rockchip: fix rk3036 SPL build

2016-07-23 Thread Heiko Stübner
Hi Simon, Am Freitag, 22. Juli 2016, 20:31:36 schrieb Simon Glass: > On 20 July 2016 at 19:47, Kever Yang wrote: > > Simon apply my V4 patch which still have some problem, he said that he > > > > will rebase > > with a new patch set either if I send a new version

Re: [U-Boot] [PATCH v3 00/16] rk3188 uboot support

2017-02-16 Thread Heiko Stübner
Hi Simon, Am Donnerstag, 16. Februar 2017, 13:43:45 CET schrieb Simon Glass: > On 3 February 2017 at 09:09, Heiko Stuebner wrote: > > this is meant as a status update and possible discussion for > > the core parts if needed. > > > > After talking with Simon and Tom the order is

Re: [U-Boot] [PATCH v3 01/16] dm: allow limiting pre-reloc markings to spl or tpl

2017-02-16 Thread Heiko Stübner
Hi Simon, Am Montag, 6. Februar 2017, 07:34:54 CET schrieb Simon Glass: > On 3 February 2017 at 08:09, Heiko Stuebner wrote: > > Right now the u-boot,dm-pre-reloc flag will make each marked node > > always appear in both spl and tpl. But systems needing an additional > > tpl

Re: [U-Boot] [PATCH] pwm: add MACRO to limit some code which only for rk3288

2016-09-21 Thread Heiko Stübner
Hi, Am Donnerstag, 28. Juli 2016, 21:46:04 schrieb Doug Anderson: > On Mon, Jul 11, 2016 at 7:45 PM, Kever Yang wrote: > > Hi Simon, > > > > CC Doug for this topic. > > > > On 07/12/2016 07:54 AM, Simon Glass wrote: > >> Hi Kever, > >> > >> On 11 July 2016 at

Re: [U-Boot] [PATCH v3 0/9] From Simon:

2016-11-29 Thread Heiko Stübner
Hi Simon, Am Sonntag, 27. November 2016, 10:01:40 schrieb Simon Glass: > This v3 patch is an update on Sjoerd's original v2 series from Feburary. > I have dealt with the changes requested at the time, and adjusted the way > that the speed change is handled. > > Tested on firefly-rk3288, rock2.

Re: [U-Boot] Rockchip RK3288 u-boot with mainline kernel

2016-11-29 Thread Heiko Stübner
Am Dienstag, 29. November 2016, 14:40:49 schrieb Simon Glass: > Hi Rick, > > On 29 November 2016 at 11:22, Rick Bronson wrote: > > Hi Heiko and Simon, > > > > Thank you both for your help, I really appreciate it. > > > > No, I do not have the Linux mainline running yet as I

Re: [U-Boot] [PATCH v3 7/9] rockchip: evb-rk3339: Enable DHCP

2016-11-29 Thread Heiko Stübner
Hi Simon, Am Sonntag, 27. November 2016, 10:01:47 schrieb Simon Glass: > This is the only RK3288 device without DHCP. Enable it so that we ^^ rk3288/rk3399? > can use a common BOOT_TARGET_DEVICES setting. It is likely useful to be > able to use USB networking, at least. Full

Re: [U-Boot] Rockchip RK3288 u-boot with mainline kernel

2016-11-29 Thread Heiko Stübner
Hi Rick, Am Montag, 28. November 2016, 15:09:05 schrieb Simon Glass: > + A few rockchip people and linux-rockchip > > Hi Rick, > > On 25 November 2016 at 11:20, Rick Bronson wrote: > > Hi All, > > > > I've got unsupported RK3288 hardware running the latest git u-boot to > > >

Re: [U-Boot] [PATCH v3 0/9] From Simon:

2016-12-01 Thread Heiko Stübner
Am Mittwoch, 30. November 2016, 19:20:30 schrieb Simon Glass: > Hi Heiko, > > On 30 November 2016 at 04:52, Heiko Stübner <he...@sntech.de> wrote: > > Am Dienstag, 29. November 2016, 19:47:10 schrieb Simon Glass: > >> Hi Heiko, > >> > >>

Re: [U-Boot] [PATCH v3 0/9] From Simon:

2016-11-30 Thread Heiko Stübner
Hi Simon, Am Mittwoch, 30. November 2016, 12:52:22 schrieb Heiko Stübner: > Am Dienstag, 29. November 2016, 19:47:10 schrieb Simon Glass: > > On 29 November 2016 at 16:45, Heiko Stübner <he...@sntech.de> wrote: > > > Am Sonntag, 27. November 2016, 10:01:40 schrieb Sim

Re: [U-Boot] [PATCH v3 0/9] From Simon:

2016-11-30 Thread Heiko Stübner
Am Dienstag, 29. November 2016, 19:47:10 schrieb Simon Glass: > Hi Heiko, > > On 29 November 2016 at 16:45, Heiko Stübner <he...@sntech.de> wrote: > > Hi Simon, > > > > Am Sonntag, 27. November 2016, 10:01:40 schrieb Simon Glass: > >> This v3 patch i

Re: [U-Boot] [PATCH 6/8] rockchip: rk3188: Switch to new i2c IP blocks

2017-03-24 Thread Heiko Stübner
Am Donnerstag, 23. März 2017, 21:28:08 CET schrieb Simon Glass: > Hi Heiko, > > On 20 March 2017 at 05:40, Heiko Stuebner wrote: > > The rk3066/rk3188 introduced new i2c IP blocks but kept the old ones > > around just in case. The default also points to these old controllers. >

Re: [U-Boot] [PATCH v4 19/20] rockchip: rk3188: Add Radxa Rock board

2017-03-23 Thread Heiko Stübner
Hi Simon, Am Donnerstag, 23. März 2017, 10:18:31 CET schrieb Simon Glass: > On 21 February 2017 at 13:35, Simon Glass wrote: > > On 18 February 2017 at 11:46, Heiko Stuebner wrote: > >> The Rock is a RK3188 based single board computer by Radxa. > >> Currently

Re: [U-Boot] [PATCH v2 0/5] Patches to reduce TPL code size

2017-04-04 Thread Heiko Stübner
Am Sonntag, 2. April 2017, 09:50:27 CEST schrieb Simon Glass: > With the rockchip 'rock' board some build and code size problems have come > to light with TPL. This series provides a few ideas to improve things. great stuff! With these patches applied, rk3188-rock still boots and the TPL has

Re: [U-Boot] [PATCH v2 1/5] string: Provide a slimmed-down memset()

2017-04-04 Thread Heiko Stübner
Am Sonntag, 2. April 2017, 09:50:28 CEST schrieb Simon Glass: > Most of the time the optimised memset() is what we want. For extreme > situations such as TPL it may be too large. For example on the 'rock' > board, using a simple loop saves a useful 48 bytes. With gcc 4.9 and > the rodata bug, this

Re: [U-Boot] [PATCH v2 2/6] dm: core: Allow multiple drivers to bind for a single node

2017-03-13 Thread Heiko Stübner
Hi Simon, Am Sonntag, 12. März 2017, 14:21:35 CET schrieb Simon Glass: > On 3 March 2017 at 03:52, Dr. Philipp Tomsich > wrote: > > On 03 Mar 2017, at 05:52, Simon Glass wrote: > > On 22 February 2017 at 13:47, Philipp Tomsich > >

[U-Boot] rockchip breakage with "spl: Remove overwrite of relocated malloc limit"

2017-03-06 Thread Heiko Stübner
Hi, I just realized patch b3d2861eb20a ("spl: Remove overwrite of relocated malloc limit") introduces breakage in my rk3188 uboot code (and should most likely also affect the very similar other rockchip spl boards). The boards call spl_init in their board_init_f functions because they need the

Re: [U-Boot] rockchip breakage with "spl: Remove overwrite of relocated malloc limit"

2017-03-07 Thread Heiko Stübner
be resolved right away. not for the rk3188 - as it is not part of a release yet, but if you look at Eddie's patches, it seems like it of course affects rk3288. Although I'd think there must be a nicer way than duplicating spl_init to fix that issue :-) . Heiko > > On 03/07/2017 08:

Re: [U-Boot] [PATCH 00/52] Support OF_PLATDATA in TPL, enable RK3368 DRAM init and add RK3368-uQ7

2017-07-24 Thread Heiko Stübner
Am Montag, 24. Juli 2017, 16:38:52 CEST schrieb Andy Yan: > Hi Philipp: > > On 2017年07月21日 18:55, Dr. Philipp Tomsich wrote: > >> On 21 Jul 2017, at 04:33, Andy Yan wrote: > >> > >> Hi: > >> > >> On 2017年07月19日 04:35, Philipp Tomsich wrote: > >>> Here's a series that

Re: [U-Boot] [PATCH 00/52] Support OF_PLATDATA in TPL, enable RK3368 DRAM init and add RK3368-uQ7

2017-07-24 Thread Heiko Stübner
Hi Łukasz, Am Montag, 24. Juli 2017, 11:23:05 CEST schrieb Łukasz Majewski: > On 07/24/2017 10:59 AM, Heiko Stübner wrote: > > Am Montag, 24. Juli 2017, 16:38:52 CEST schrieb Andy Yan: > >> Hi Philipp: > >> > >> On 2017年07月21日 18:55, Dr. Philipp Tomsich wr

Re: [U-Boot] [PATCH 0/5] fix the boot issue of Rockchip RK3036

2017-07-04 Thread Heiko Stübner
Hi Andy, Am Montag, 3. Juli 2017, 16:02:59 CEST schrieb Andy Yan: > On 2017年06月30日 16:14, Dr. Philipp Tomsich wrote: > >> On 30 Jun 2017, at 09:47, Andy Yan wrote: > >> As Kever mentioned in [0], the RK3036 based boards could't > >> bootup for a long time. > >> After a

Re: [U-Boot] [PATCH] rockchip: doc: update latest info to document

2017-05-15 Thread Heiko Stübner
Hi Kever, Am Montag, 15. Mai 2017, 21:18:00 CEST schrieb Kever Yang: > - Add some rk3399 and rk3328 boards; > - use rkdeveloptool instead of rkflashtool; > - use opensource.rock-chips.com instead of wikidot; > - other update. > > Signed-off-by: Kever Yang > --- > >

Re: [U-Boot] [PATCH 05/13] rockchip: rk3066: add rk3066 platform devicetree file

2017-06-08 Thread Heiko Stübner
Am Mittwoch, 7. Juni 2017, 17:12:24 CEST schrieb Paweł Jarosz: > Hi Simon, > > W dniu 06.06.2017 o 23:10, Simon Glass pisze: > > Hi Pawel, > > > > On 6 June 2017 at 12:50, Paweł Jarosz wrote: > >> rk3066 peripherials include usb, i2c, pwm, gpio, sdio, sdmmc, emmc,

Re: [U-Boot] [PATCH 0/7] rockchip: Split sdram common function into sdram_common.c

2017-06-13 Thread Heiko Stübner
Am Dienstag, 13. Juni 2017, 11:31:53 CEST schrieb Dr. Philipp Tomsich: > Kever, > > thanks a lot! I had just started to work on RK3368 SPL code and the DDR > controller would have been next on the list… > You saved me quite a bit of work there. Although the sdram drivers for rk3328 and rk3368

Re: [U-Boot] [PATCH v2 0/5] rockchip: back-to-bootrom: replace assembly-implementation with C-code

2017-09-19 Thread Heiko Stübner
Am Dienstag, 19. September 2017, 11:10:29 CEST schrieb Dr. Philipp Tomsich: > Andy, > > > On 19 Sep 2017, at 09:19, Andy Yan wrote: > > > > Hi Philipp: > > > > On 2017年09月19日 10:06, Andy Yan wrote: > >> Hi Philipp: > >> > >> On 2017年09月19日 02:18, Philipp Tomsich

Re: [U-Boot] [PATCH v3 0/6] rockchip: back-to-bootrom: replace assembly-implementation with C-code

2017-09-21 Thread Heiko Stübner
Am Donnerstag, 21. September 2017, 12:25:17 CEST schrieb Dr. Philipp Tomsich: > > On 21 Sep 2017, at 11:44, Heiko Stuebner wrote: > > > > Am Donnerstag, 21. September 2017, 11:09:49 CEST schrieb Heiko Stuebner: > >> Am Donnerstag, 21. September 2017, 10:19:23 CEST schrieb

Re: [U-Boot] u-boot Boot issue about rk3188

2017-09-21 Thread Heiko Stübner
Hi Andy, Am Donnerstag, 21. September 2017, 22:03:32 CEST schrieb Andy Yan: > Hi Heiko: > I try to boot the upstream u-boot-rockchip branch on my rk3188 board > with(rock_defconfig) > > But I got this error: > early_init() > nit_and_scan() returned error -22 > early_init() failed: -22 > ERROR

Re: [U-Boot] rk3188/rock_defconfig sdmmc failures

2017-09-05 Thread Heiko Stübner
Hi Artturi, Am Mittwoch, 6. September 2017, 01:50:38 CEST schrieb Artturi Alm: > So, being optimistic, i added compatible found from > arch/arm/dts/rk3xxx.dtsi, included by rk3188: > > diff --git a/drivers/mmc/rockchip_dw_mmc.c b/drivers/mmc/rockchip_dw_mmc.c > index e7fcf89..a879fcd 100644 >

Re: [U-Boot] [PATCH v2 13/19] ARM: dts: rockchip: prefer u-boot, dm-pre-reloc rather than u-boot, dm-spl

2017-09-06 Thread Heiko Stübner
Hi Pawel, Am Freitag, 11. August 2017, 22:57:29 CEST schrieb Paweł Jarosz: > rk3xxx.dtsi is used by rk3188 and rk3066. rk3188 uses alocated data in spl > but rk3066 needs it in tpl. > > Signed-off-by: Paweł Jarosz > --- > Changes since v1: > - none > >

Re: [U-Boot] u-boot Boot issue about rk3188

2017-09-25 Thread Heiko Stübner
Am Montag, 25. September 2017, 19:49:01 CEST schrieb Andy Yan: > Hi Heiko: > > On 2017年09月25日 18:29, Heiko Stübner wrote: > > Hi Andy, > > > > Am Montag, 25. September 2017, 17:45:03 CEST schrieb Andy Yan: > >> On 2017年09月22日 13:56, Heiko Stuebner wrote: >

Re: [U-Boot] [PATCH 00/10] rockchip: add tpl and OPTEE support for rk3229

2017-11-20 Thread Heiko Stübner
Hi Kever, Am Mittwoch, 6. September 2017, 10:14:27 CET schrieb Kever Yang: > Add some generic options for TPL support for arm 32bit, and then > and TPL support for rk3229(cortex-A7), and then add OPTEE support > in SPL. I was now finally able to test this series and I'm getting mixed results. I

Re: [U-Boot] [PATCH 4/4] dw_mmc: turn on the IO supply

2019-03-29 Thread Heiko Stübner
Am Freitag, 22. März 2019, 20:14:36 CET schrieb Urja Rannikko: > Fixes the microSD slot on the ASUS C201. > > Signed-off-by: Urja Rannikko > --- > drivers/mmc/dw_mmc.c | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c > index

Re: [U-Boot] [PATCH 0/4] Veyron Speedy / ASUS C201 fixes

2019-03-31 Thread Heiko Stübner
Am Sonntag, 31. März 2019, 21:34:00 CEST schrieb Urja Rannikko: > Hi, > > On Fri, Mar 29, 2019 at 1:56 PM Heiko Stübner wrote: > > > > In my u-boot list archive I only see the list itself als recipient. > > You may want to resend your series with actu

Re: [U-Boot] [PATCH] optee: support rockchip optee binary release

2019-03-31 Thread Heiko Stübner
Hi Kever, Am Freitag, 29. März 2019, 13:16:26 CET schrieb Kever Yang: > On 03/29/2019 07:25 PM, Philipp Tomsich wrote: > >> On 29.03.2019, at 12:21, Kever Yang wrote: > >> > >> Rockchip provide tee binary release in 'rkbin' repository: > >> https://github.com/rockchip-linux/rkbin > >> For some

Re: [U-Boot] rk3288 SPL size

2019-04-05 Thread Heiko Stübner
Hi, Am Freitag, 5. April 2019, 12:10:21 CEST schrieb Wadim Egorov: > it seems the new common rockchip pinctrl driver does not really fit into > our phycore-rk3288 SPL setup. It works for every other rk3288 based > board because they don't need special power configurations at the SPL stage. > >

Re: [U-Boot] [PATCH 0/4] Veyron Speedy / ASUS C201 fixes

2019-03-29 Thread Heiko Stübner
Hi Urja, Am Freitag, 22. März 2019, 20:14:32 CET schrieb Urja Rannikko: > Just saying: I'm not familiar with this stuff so i might've misunderstood > something in my commit messages, but anyways i managed to make it boot. > > There's more stuff than just these, but i decided I'd keep it short...

Re: [U-Boot] [PATCH] optee: support rockchip optee binary release

2019-03-31 Thread Heiko Stübner
Am Montag, 1. April 2019, 04:32:28 CEST schrieb Kever Yang: > Hi Heiko, > > > On 04/01/2019 05:02 AM, Heiko Stübner wrote: > > Hi Kever, > > > > Am Freitag, 29. März 2019, 13:16:26 CET schrieb Kever Yang: > >> On 03/29/2019 07:25 PM, Philipp Tomsich wrote

Re: [U-Boot] [PATCH] optee: support rockchip optee binary release

2019-04-01 Thread Heiko Stübner
Hi Kever, Am Montag, 1. April 2019, 11:49:35 CEST schrieb Kever Yang: > On 04/01/2019 01:42 PM, Heiko Stübner wrote: > > Am Montag, 1. April 2019, 04:32:28 CEST schrieb Kever Yang: > >> On 04/01/2019 05:02 AM, Heiko Stübner wrote: > >>> Am Freitag, 29. März 2019, 1

Re: [U-Boot] [BUG] booting on the Tinker Board (tinker-rk3288_defconfig) is broken

2019-02-28 Thread Heiko Stübner
Hi David, Am Montag, 18. Februar 2019, 02:05:12 CET schrieb David Wu: > Hi Heinrich and Michael, > > Another thing i see is that I missed a patch, for the 3288 gpio0, its > iomux is special, there is no high 16-bit write-enabled bit. For Tinker > board, it uses I2C0, the current driver will

Re: [U-Boot] [BUG] booting on the Tinker Board (tinker-rk3288_defconfig) is broken

2019-02-28 Thread Heiko Stübner
Am Donnerstag, 28. Februar 2019, 13:36:52 CET schrieb Philipp Tomsich: > > On 28.02.2019, at 11:50, Heiko Stübner wrote: > > > > Hi David, > > > > Am Montag, 18. Februar 2019, 02:05:12 CET schrieb David Wu: > >> Hi Heinrich and Michael, > >> &

Re: [U-Boot] [BUG] booting on the Tinker Board (tinker-rk3288_defconfig) is broken

2019-02-28 Thread Heiko Stübner
Hi Philipp, Am Donnerstag, 28. Februar 2019, 13:46:44 CET schrieb Heiko Stübner: > Am Donnerstag, 28. Februar 2019, 13:36:52 CET schrieb Philipp Tomsich: > > > On 28.02.2019, at 11:50, Heiko Stübner wrote: > > > > > > Hi David, > > > > > > A

Re: [U-Boot] [PATCH 1/3] rockchip: rk3399: add tpl support

2019-04-18 Thread Heiko Stübner
Am Donnerstag, 18. April 2019, 08:35:49 CEST schrieb Philipp Tomsich: > Simon, > > > On 18.04.2019, at 06:32, Simon Glass wrote: > > > > Hi Kever, > > > > On Mon, 1 Apr 2019 at 02:21, Kever Yang wrote: > >> > >> Rockchip platform suppose to use TPL(run in SRAM) as dram init and > >> SPL(run

Re: [U-Boot] [PATCH 2/3] bouncebuf: Add DMA validation check to addr_aligned().【请注意,邮件由u-boot-boun...@lists.denx.de代发】 addr_aligned().

2019-07-04 Thread Heiko Stübner
Hi Simon, Am Dienstag, 4. Juni 2019, 05:23:14 CEST schrieb Kever Yang: > On 05/19/2019 12:08 AM, Simon Glass wrote: > > On Tue, 7 May 2019 at 03:05, Christoph Muellner > > wrote: > >> Currently addr_aligned() performs an alignment and a length check > >> to validate the DMA address. However,

Re: [U-Boot] [PATCH] rockchip: derive ethaddr from cpuid

2019-07-10 Thread Heiko Stübner
Hi Rohan, Am Mittwoch, 10. Juli 2019, 14:08:31 CEST schrieb Rohan Garg: > Hey Heiko > > Also, that code looks pretty much like the same in rk3399-puma. > > > > So maybe it might be good to have this in a common location so > > more boards can access common code instead of duplicating that > >

Re: [U-Boot] [PATCH 3/3] common: bouncebuf: handle address in sram for rockchip platform

2019-04-09 Thread Heiko Stübner
Hi Kever, Am Dienstag, 2. April 2019, 10:46:54 CEST schrieb Kever Yang: > Rockchip SOC's mmc controller does not support read data > from mmc to sram, we need a bounce buffer(in sdram), and then > copy to sram. > > Signed-off-by: Kever Yang > --- > > common/bouncebuf.c | 12 > 1

Re: [U-Boot] [PATCH] rockchip: derive ethaddr from cpuid

2019-07-10 Thread Heiko Stübner
Hi Rohan, Kever, Am Mittwoch, 10. Juli 2019, 08:37:33 CEST schrieb Kever Yang: > Hi Rohan, > > The code change looks good to me, but could you help to separate > the rock pi config update into another patch? Also, that code looks pretty much like the same in rk3399-puma. So maybe it might

Re: [U-Boot] [PATCH 1/2] rockchip: clk: rv1108: remove duplicate reset init

2019-11-07 Thread Heiko Stübner
Hi Kever, Am Donnerstag, 7. November 2019, 10:03:19 CET schrieb Kever Yang: > On 2019/10/24 上午1:45, Heiko Stuebner wrote: > > rockchip_reset_bind() already does the needed init for the reset > > registers, only referenced the wrong cru structure. > > > > So we can get rid of the open-coded reset

Re: [U-Boot] [PATCH v3 1/4] fdtdec: protect against another NULL phandlep in fdtdec_add_reserved_memory()

2019-11-08 Thread Heiko Stübner
Am Mittwoch, 23. Oktober 2019, 16:46:38 CET schrieb Heiko Stuebner: > From: Heiko Stuebner > > The change adding fdtdec_add_reserved_memory() already protected the added > phandle against the phandlep being NULL - making the phandlep var optional. > > But in the early code checking for an

Re: [U-Boot] [PATCH v3 4/4] tests: add OP-TEE test suite

2019-11-08 Thread Heiko Stübner
Am Mittwoch, 23. Oktober 2019, 16:46:41 CET schrieb Heiko Stuebner: > From: Heiko Stuebner > > OP-TEE can get supplied with a devicetree and will then insert > its firmware node and reserved-memory sections into it. > As this devicetree often is not the one supplied to a later > loaded kernel, a

Re: [U-Boot] [PATCH v3 2/4] fdtdec: only create phandle if caller wants it in fdtdec_add_reserved_memory()

2019-11-08 Thread Heiko Stübner
Am Mittwoch, 23. Oktober 2019, 16:46:39 CET schrieb Heiko Stuebner: > From: Heiko Stuebner > > The phandlep pointer returning the phandle to the caller is optional > and if it is not set when calling fdtdec_add_reserved_memory() it is > highly likely that the caller is not interested in a

Re: [U-Boot] [PATCH 11/12] rockchip: add px30 architecture core

2019-10-25 Thread Heiko Stübner
Hi Kever, Am Freitag, 25. Oktober 2019, 04:49:54 CEST schrieb Kever Yang: > On 2019/10/25 上午7:28, Heiko Stuebner wrote: > > From: Kever Yang > > > > Add core architecture code to support the px30 soc. > > This includes a separate tpl board file due to very limited > > sram size as well as a

Re: [U-Boot] [PATCH 3/3] image: fdt: copy possible optee nodes to a loaded devicetree

2019-10-22 Thread Heiko Stübner
Hi Simon, Am Dienstag, 22. Oktober 2019, 02:17:00 CEST schrieb Simon Glass: > On Mon, 7 Oct 2019 at 18:22, Heiko Stuebner wrote: > > > > The loading convention for optee or any other tee on arm64 is as bl32 > > parameter to the trusted-firmware. So TF-A gets invoked with the TEE as > > bl32 and

Re: [U-Boot] [PATCH 3/3] image: fdt: copy possible optee nodes to a loaded devicetree

2019-10-22 Thread Heiko Stübner
Hi Simon, Am Dienstag, 22. Oktober 2019, 14:08:04 CEST schrieb Heiko Stübner: > Am Dienstag, 22. Oktober 2019, 02:17:00 CEST schrieb Simon Glass: > > On Mon, 7 Oct 2019 at 18:22, Heiko Stuebner wrote: > > > > > > The loading convention for optee or any ot

Re: [U-Boot] [PATCH v2 3/4] image: fdt: copy possible optee nodes to a loaded devicetree

2019-10-23 Thread Heiko Stübner
Hi Patrick, Am Mittwoch, 23. Oktober 2019, 09:10:52 CEST schrieb Patrick DELAUNAY: > Hi Jens and Heiko, > > > From: U-Boot On Behalf Of Jens Wiklander > > Sent: mercredi 23 octobre 2019 08:46 > > > > On Tue, Oct 22, 2019 at 09:04:27PM +0200, Heiko Stuebner wrote: > > > From: Heiko Stuebner >

Re: [U-Boot] [PATCH v2 2/2] rockchip: px30: enable spl-fifo-mode for both emmc and sdmmc on evb

2019-11-28 Thread Heiko Stübner
Hi Patrick, Am Donnerstag, 28. November 2019, 00:38:45 CET schrieb Patrick Wildt: > On Tue, Nov 19, 2019 at 12:04:02PM +0100, Heiko Stuebner wrote: > > From: Heiko Stuebner > > > > As part of loading trustedfirmware, the SPL is required to place portions > > of code into the socs sram but the

Re: [U-Boot] [PATCH v2 1/2] rockchip: make_fit_atf.py: allow inclusion of a tee binary

2019-11-04 Thread Heiko Stübner
Hi Simon, Am Mittwoch, 30. Oktober 2019, 02:49:46 CET schrieb Simon Glass: > On Tue, 22 Oct 2019 at 03:45, Kever Yang wrote: > > On 2019/10/22 上午7:46, Simon Glass wrote: > > > On Mon, 14 Oct 2019 at 03:07, Kever Yang > > > wrote: > > >> > > >> On 2019/10/7 上午2:10, Heiko Stuebner wrote: > > >>>

Re: [U-Boot] [PATCH 1/2] rockchip: make_fit_atf.py: allow inclusion of a tee binary

2019-10-10 Thread Heiko Stübner
Hi Simon, Am Donnerstag, 10. Oktober 2019, 19:06:12 CEST schrieb Simon Glass: > On Tue, 1 Oct 2019 at 14:23, Heiko Stuebner wrote: > > A trusted execution environment should also get loaded as loadable from > > a fit image, so add the possibility to present a tee.elf to make_fit_atf.py > > that

Re: [PATCH 7/7] rockchip: make_fit_atf: add signature handling

2020-04-20 Thread Heiko Stübner
Hi Simon, Am Montag, 20. April 2020, 01:38:20 CEST schrieb Simon Glass: > On Fri, 17 Apr 2020 at 16:07, Heiko Stuebner wrote: > > > > From: Heiko Stuebner > > > > If the newly added fit-generator key-options are found, append needed > > signature nodes to all generated image blocks, so that

Re: [PATCH v2 7/7] rockchip: make_fit_atf: add signature handling

2020-05-03 Thread Heiko Stübner
Hi Kever, Am Freitag, 1. Mai 2020, 12:32:23 CEST schrieb Kever Yang: > On 2020/4/21 上午8:23, Heiko Stuebner wrote: > > From: Heiko Stuebner > > > > If the newly added fit-generator key-options are found, append needed > > signature nodes to all generated image blocks, so that they can get > >

Re: [PATCH] rsa: fix alignment issue when getting public exponent

2020-05-04 Thread Heiko Stübner
Am Montag, 4. Mai 2020, 16:17:52 CEST schrieb Simon Glass: > +Tom Rini > > On Sun, 3 May 2020 at 05:26, Heiko Stuebner wrote: > > > > From: Heiko Stuebner > > > > To fill the exponent field of the rsa_public_key struct, rsa_mod_exp_sw > > did a cast to uint64_t of the key_prop->public_exponent

Re: [PATCH 4/8] usb: dwc3: add make compatible for rockchip platform

2020-04-28 Thread Heiko Stübner
Am Dienstag, 28. April 2020, 11:21:07 CEST schrieb Marek Vasut: > On 4/28/20 11:05 AM, Frank Wang wrote: > > Hi Marek, > > > > On 2020/4/28 16:27, Marek Vasut wrote: > >> On 4/28/20 8:27 AM, Frank Wang wrote: > >>> RK3399 Type-C PHY is required that must hold whole USB3.0 OTG controller > >>> in

Re: [PATCH v2 5/7] spl: fit: enable signing a generated u-boot.itb

2020-04-30 Thread Heiko Stübner
Hi Kever, Am Donnerstag, 30. April 2020, 11:03:38 CEST schrieb Kever Yang: > This patch will cause build fail on sandbox_spl_defconfig: > > dtc: option requires an argument -- 'p' sandbox_spl is confusing on first glance, it enables the spl_fit-options but does not define any fit sources. But

Re: [PATCH 1/2] rockchip: spl: do full dram_init instead of only probing

2020-05-15 Thread Heiko Stübner
Hi Kever, Am Freitag, 15. Mai 2020, 04:07:41 CEST schrieb Kever Yang: > > On 2020/5/12 下午6:34, Heiko Stuebner wrote: > > From: Heiko Stuebner > > > > Parts of later SPL may need RAM information as well, so do full > > dram_init() call, which includes the existing dram probing but also > >

Re: [PATCH v2 7/7] rockchip: make_fit_atf: add signature handling

2020-05-06 Thread Heiko Stübner
Hi Kever, Am Freitag, 1. Mai 2020, 12:32:23 CEST schrieb Kever Yang: > > On 2020/4/21 上午8:23, Heiko Stuebner wrote: > > From: Heiko Stuebner > > > > If the newly added fit-generator key-options are found, append needed > > signature nodes to all generated image blocks, so that they can get > >

Re: [PATCH] ram: rockchip: px30: add a config-based ddr selection

2020-10-02 Thread Heiko Stübner
Hi Simon, Am Freitag, 2. Oktober 2020, 07:58:35 CEST schrieb Heiko Stübner: > Am Freitag, 2. Oktober 2020, 04:09:56 CEST schrieb Simon Glass: > > On Thu, 1 Oct 2020 at 12:40, Heiko Stuebner wrote: > > > > > > From: Heiko Stuebner > > > > > > T

Re: [PATCH] ram: rockchip: px30: add a config-based ddr selection

2020-10-01 Thread Heiko Stübner
Hi Simon, Am Freitag, 2. Oktober 2020, 04:09:56 CEST schrieb Simon Glass: > Hi Heiko, > > On Thu, 1 Oct 2020 at 12:40, Heiko Stuebner wrote: > > > > From: Heiko Stuebner > > > > The SRAM on the PX30 is not big enough to hold multiple DDR configs > > so it needs to be selected during build. > >

Re: [PATCH v5 5/8] lib: rsa: free local arrays after use in rsa_gen_key_prop()

2020-05-25 Thread Heiko Stübner
Am Freitag, 22. Mai 2020, 16:19:34 CEST schrieb Heiko Stuebner: > From: Heiko Stuebner > > n, rr and rrtmp are used for internal calculations, but in the end > the results are copied into separately allocated elements of the > actual key_prop, so the n, rr and rrtmp elements are not used anymore

Re: [PATCH v5 2/8] lib: rsa: take spl/non-spl into account when building rsa_verify_with_pkey()

2020-05-25 Thread Heiko Stübner
Am Freitag, 22. Mai 2020, 16:19:31 CEST schrieb Heiko Stuebner: > From: Heiko Stuebner > > Right now in multiple places there are only checks for the full > CONFIG_RSA_VERIFY_WITH_PKEY option, not split into main,spl,tpl variants. > > This breaks when the rsa functions get enabled for SPL, for

Re: [PATCH v5 6/8] lib: rsa: add documentation to padding_pss_verify to document limitations

2020-05-25 Thread Heiko Stübner
Am Freitag, 22. Mai 2020, 16:19:35 CEST schrieb Heiko Stuebner: > From: Heiko Stuebner > > padding_pss_verify only works with the default pss salt setting of -2 > (length to be automatically determined based on the PSS block structure) > not -1 (salt length set to the maximum permissible value),

Re: [PATCH v5 4/8] lib: rsa: fix allocated size for rr and rrtmp in rsa_gen_key_prop()

2020-05-25 Thread Heiko Stübner
Am Freitag, 22. Mai 2020, 16:19:33 CEST schrieb Heiko Stuebner: > From: Heiko Stuebner > > When calculating rrtmp/rr rsa_gen_key_prop() tries to make > (((rlen + 31) >> 5) + 1) steps in the rr uint32_t array and > (((rlen + 7) >> 3) + 1) / 4 steps in uint32_t rrtmp[] > with rlen being num_bits *

Re: [PATCH v5 3/8] lib: rsa: bring exp_len in line when generating a key_prop

2020-05-25 Thread Heiko Stübner
Am Freitag, 22. Mai 2020, 16:19:32 CEST schrieb Heiko Stuebner: > From: Heiko Stuebner > > The exponent field of struct key_prop gets allocated an uint64_t, > and the contents are positioned from the back, so an exponent of > "0x01 0x00 0x01" becomes 0x0 0x0 0x0 0x0 0x0 0x1 0x0 0x1" > > Right

Re: [PATCH v4 6/6] rockchip: make_fit_atf: add signature handling

2020-06-30 Thread Heiko Stübner
Hi Tom, Am Dienstag, 30. Juni 2020, 14:36:40 CEST schrieb Tom Rini: > On Fri, Jun 19, 2020 at 12:45:50PM +0200, Heiko Stuebner wrote: > > > From: Heiko Stuebner > > > > If the newly added fit-generator key-options are found, append needed > > signature nodes to all generated image blocks, so

Re: [PATCH v6 1/8] lib: rsa: distinguish between tpl and spl for CONFIG_RSA_VERIFY

2020-06-30 Thread Heiko Stübner
Am Donnerstag, 18. Juni 2020, 16:23:21 CEST schrieb Heiko Stuebner: > From: Heiko Stuebner > > While the SPL may want to do signature checking this won't be > the case for TPL in all cases, as TPL is mostly used when the > amount of initial memory is not enough for a full SPL. > > So on a

Re: [BUG] ut lib lib_rsa_verify_valid crashes on qemu_arm if RSA_VERIFY_WITH_PKEY=y

2020-06-09 Thread Heiko Stübner
Am Dienstag, 9. Juni 2020, 12:22:36 CEST schrieb Heinrich Schuchardt: > On 09.06.20 12:11, Heiko Stübner wrote: > > Hi Akashi, > > > > Am Dienstag, 9. Juni 2020, 11:22:35 CEST schrieb AKASHI Takahiro: > >> Heinrich, > >> > >> On Tue, Jun 09, 202

Re: [BUG] ut lib lib_rsa_verify_valid crashes on qemu_arm if RSA_VERIFY_WITH_PKEY=y

2020-06-09 Thread Heiko Stübner
Hi Akashi, Am Dienstag, 9. Juni 2020, 11:22:35 CEST schrieb AKASHI Takahiro: > Heinrich, > > On Tue, Jun 09, 2020 at 03:54:44AM +, Heinrich Schuchardt wrote: > > Am June 9, 2020 1:42:14 AM UTC schrieb AKASHI Takahiro > > : > > >Heinrich, > > > > > >On Mon, Jun 08, 2020 at 11:08:53PM +0200,

Re: [PATCH v1] rockchip: rk3188-cru-common: sync clock dt-binding header from Linux

2021-06-21 Thread Heiko Stübner
Am Montag, 21. Juni 2021, 09:39:20 CEST schrieb Johan Jonker: > In order to update the DT for rk3066 and rk3188 > sync the clock dt-binding header. > This is the state as of v5.12 in Linux. > > Signed-off-by: Johan Jonker Reviewed-by: Heiko Stuebner > --- >

Re: [PATCH] arm: dts: rk3399-puma: re-add vdd_log for uboot

2022-01-03 Thread Heiko Stübner
Hi Quentin, Am Montag, 3. Januar 2022, 13:26:09 CET schrieb Quentin Schulz: > Hi Heiko, > > On 12/26/21 13:45, Heiko Stuebner wrote: > > The rk3399-puma board needs a 950mV vdd_log to work stable. > > This was already added in > > commit 77012e79ffc3 ("rockchip: rk3399-puma: Set VDD_LOG to 950

macb clock handling (Was: [PATCH v1 4/5] net: macb: Compatible as per device tree)

2021-11-11 Thread Heiko Stübner
Hi, not wanting to hijack this too much, but does the mac driver also need some sort of clock handling? Because on the Icicle I have here, I'm running into "TX timeout" errors: RISC-V # dhcp ethernet@20112000: PHY present at 9 ethernet@20112000: Starting autonegotiation... ethernet@20112000:

Re: macb clock handling (Was: [PATCH v1 4/5] net: macb: Compatible as per device tree)

2021-11-25 Thread Heiko Stübner
Hi, Am Donnerstag, 11. November 2021, 10:41:46 CET schrieb Heiko Stübner: > not wanting to hijack this too much, but does the mac driver also need > some sort of clock handling? > > Because on the Icicle I have here, I'm running into "TX timeout" errors: > > RISC-

Re: [PATCH v2 1/2] rockchip: ringneck-px30: always reset STM32 companion controller on boot

2023-11-03 Thread Heiko Stübner
Am Freitag, 3. November 2023, 10:28:12 CET schrieb Quentin Schulz: > From: Quentin Schulz > > It's happened that glitches on the STM32_RST and STM32_BOOT lines have > put the STM32 companion microcontroller into DFU mode making it not boot > its FW, rendering it useless for the user. > >

Re: [PATCH 1/2] rockchip: ringneck-px30: always reset STM32 companion controller on boot

2023-10-25 Thread Heiko Stübner
Hi Quentin, Am Mittwoch, 25. Oktober 2023, 11:51:14 CEST schrieb Quentin Schulz: > From: Quentin Schulz > > It's happened that glitches on the STM32_RST and STM32_BOOT lines have > put the STM32 companion microcontroller into DFU mode making it not boot > its FW, rendering it useless for the

Re: [PATCH 2/2] rockchip: ringneck-px30: enable SPL_BOARD_INIT

2023-10-25 Thread Heiko Stübner
Am Mittwoch, 25. Oktober 2023, 11:51:15 CEST schrieb Quentin Schulz: > From: Quentin Schulz > > Now that Ringneck requires some board-specific code (namely resetting > the MCU companion controller) to be run during SPL stage, let's enable > SPL_BOARD_INIT. > > Cc: Quentin Schulz >

Re: [PATCH] rockchip: ringneck-px30: enable i2c command

2023-10-25 Thread Heiko Stübner
Am Mittwoch, 25. Oktober 2023, 13:17:12 CEST schrieb Quentin Schulz: > From: Quentin Schulz > > This is a useful tool to check the presence of a device on a specific > i2c bus, so let's enable it. > > Cc: Quentin Schulz > Signed-off-by: Quentin Schulz Reviewed-by: Heiko Stuebner

Re: [PATCH] riscv: Fix build against binutils 2.38

2022-06-23 Thread Heiko Stübner
Am Freitag, 28. Januar 2022, 14:47:13 CEST schrieb Alexandre Ghiti: > The following description is copied from the equivalent patch for the > Linux Kernel proposed by Aurelien Jarno: > > From version 2.38, binutils default to ISA spec version 20191213. This > means that the csr read/write

Re: [PATCH] riscv: fix compitible with binutils 2.38

2022-06-23 Thread Heiko Stübner
Hi, Am Montag, 23. Mai 2022, 14:05:27 CEST schrieb Coelacanthus: > commit 6df2a016c0c8a3d0933ef33dd192ea6606b115e3 from linux kernel > > Since binutils 2.38, default ISA spec version switch to 20191213, > in this version, original I extension be split into I, Zicsr and Zifencei. > Zicsr is csr