Re: [U-Boot] [PATCH] video:lcd:cfb_console: cm_t35: Add CONFIG_SPLASH_SCREEN_PREPARE support to CONFIG_VIDEO

2013-06-03 Thread Igor Grinberg
Hi Robert, On 06/03/13 20:20, Robert Winkler wrote: > Also change splash_screen_prepare to a weak function. You should be able to make a commit message a bit better. Also, personally, I see here two functional changes and it would be better to separate them into two patches: 1) Make the splash_sc

Re: [U-Boot] [PATCH] video:lcd:cfb_console: cm_t35: Add CONFIG_SPLASH_SCREEN_PREPARE support to CONFIG_VIDEO

2013-06-05 Thread Igor Grinberg
Hi Robert, On 06/04/13 21:11, Robert Winkler wrote: > Adding Anatolij to the CC list. > > On Tue, Jun 4, 2013 at 8:10 AM, Robert Winkler > wrote: >> Hi Igor, >> >> On Mon, Jun 3, 2013 at 11:10 PM, Igor Grinberg >> wrote: >>> Hi Robert, &g

Re: [U-Boot] [PATCH] video:lcd:cfb_console: cm_t35: Add CONFIG_SPLASH_SCREEN_PREPARE support to CONFIG_VIDEO

2013-06-09 Thread Igor Grinberg
On 06/06/13 22:06, Robert Winkler wrote: > Hi All, > > On Wed, Jun 5, 2013 at 1:31 AM, Igor Grinberg wrote: >> Hi Robert, >> >> On 06/04/13 21:11, Robert Winkler wrote: >>> Adding Anatolij to the CC list. >>> >>> On Tue, Jun 4, 20

Re: [U-Boot] Please pull u-boot-ti/master

2013-06-09 Thread Igor Grinberg
Hi Lubomir, On 06/08/13 23:43, Lubomir Popov wrote: > Hi Tom, Michael, > >> Hello, >> >> The following changes since commit 3da0e5750b24a9491058df6126c7be577a276c09: >> >> arm: factorize relocate_code routine (2013-05-30 20:24:38 +0200) >> >> are available in the git repository at: >> >> git:

Re: [U-Boot] [PATCH v3] usb: omap: ulpi: fix ulpi transceiver access

2013-06-10 Thread Igor Grinberg
ly to check if the >>>>>> transaction is done or still running and the reading and >>>>>> writing operation have different offset and have different >>>>>> values. What we need to do at the end of a transaction is >>>>>> leave

Re: [U-Boot] [PATCH] usb: omap: ulpi: fix ulpi reading/writing functions

2013-06-10 Thread Igor Grinberg
dd a +1 fix the problem > > Signed-off-by: Michael Trimarchi Acked-by: Igor Grinberg > --- > drivers/usb/ulpi/omap-ulpi-viewport.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/ulpi/omap-ulpi-viewport.c > b/drivers/usb/ul

Re: [U-Boot] [PATCH 1/2] video: lcd: Add CONFIG_SPLASH_SCREEN_PREPARE support to CONFIG_VIDEO

2013-06-16 Thread Igor Grinberg
Hi Robert, On 06/14/13 20:00, Robert Winkler wrote: > Create splash.c/h to put the function and any future common > splash screen code in. > > Signed-off-by: Robert Winkler Thanks for the effort! Several comments below... > --- > common/Makefile | 1 + > common/lcd.c

Re: [U-Boot] [PATCH 0/2] video: lcd: splash screen prepare changes

2013-06-16 Thread Igor Grinberg
On 06/14/13 20:00, Robert Winkler wrote: > These 2 patches are the result of discussion in these threads: > http://lists.denx.de/pipermail/u-boot/2013-May/155463.html > http://lists.denx.de/pipermail/u-boot/2013-June/155630.html > http://lists.denx.de/pipermail/u-boot/2013-June/155632.html > > The

Re: [U-Boot] [PATCH] cm_t35: Fix cm_t35 for weak splash_screen_prepare

2013-06-16 Thread Igor Grinberg
Hi Robert, We lack a commit message here... On 06/14/13 22:31, Robert Winkler wrote: > Signed-off-by: Robert Winkler > --- Also, I would write here (not a part of commit message) that this patch should be applied only in case the patch: "video: lcd: Make splash_screen_prepare weak, remove confi

Re: [U-Boot] [PATCH 3/3] arm: omap3: Add SPL support to cm_t35

2013-06-17 Thread Igor Grinberg
Hi Stefan, On 06/14/13 11:55, Stefan Roese wrote: > Add SPL U-Boot support to replace x-loader on the Compulab cm_t35 > board. Currently only the 256MiB SDRAM board versions are supported. > > Tested by booting via MMC and NAND. > > Signed-off-by: Stefan Roese > Cc:

Re: [U-Boot] [PATCH 3/3] arm: omap3: Add SPL support to cm_t35

2013-06-17 Thread Igor Grinberg
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/17/13 15:38, Tom Rini wrote: > On Mon, Jun 17, 2013 at 02:53:27PM +0300, Igor Grinberg wrote: >> Hi Stefan, >> >> On 06/14/13 11:55, Stefan Roese wrote: >>> Add SPL U-Boot support to replace x-loader on the Compul

Re: [U-Boot] [PATCH 1/2] video: lcd: Add CONFIG_SPLASH_SCREEN_PREPARE support to CONFIG_VIDEO

2013-06-17 Thread Igor Grinberg
On 06/17/13 20:08, Robert Winkler wrote: > Hi Igor, > > On Sun, Jun 16, 2013 at 10:34 PM, Igor Grinberg > wrote: >> Hi Robert, >> >> On 06/14/13 20:00, Robert Winkler wrote: >>> Create splash.c/h to put the function and any future common >>&

Re: [U-Boot] [PATCH 1/3 v2] video: lcd: Add CONFIG_SPLASH_SCREEN_PREPARE support to CONFIG_VIDEO

2013-06-17 Thread Igor Grinberg
Hi Robert, On 06/17/13 21:31, Robert Winkler wrote: > Create splash.c/h to put the function and any future common splash > screen code in. > > Signed-off-by: Robert Winkler Acked-by: Igor Grinberg > --- > v2 changes: > remove superfluous comments > remove debu

Re: [U-Boot] [PATCH 2/3] video: lcd: Make splash_screen_prepare weak, remove config macro

2013-06-17 Thread Igor Grinberg
On 06/17/13 21:31, Robert Winkler wrote: > Remove CONFIG_SPLASH_SCREEN_PREPARE from README > Add doc/README.splashprepare to document functionality > > Signed-off-by: Robert Winkler Acked-by: Igor Grinberg > --- > README | 8 > common/s

Re: [U-Boot] [PATCH 3/3] omap: cm_t35: Fix cm_t35 for weak splash_screen_prepare

2013-06-17 Thread Igor Grinberg
On 06/17/13 21:31, Robert Winkler wrote: > Signed-off-by: Robert Winkler Usually, we add something to the commit message, otherwise Acked-by: Igor Grinberg > --- > board/compulab/cm_t35/cm_t35.c | 2 +- > include/configs/cm_t35.h | 1 - > 2 files changed, 1 insertion(

Re: [U-Boot] [PATCH 3/3] omap: cm_t35: Fix cm_t35 for weak splash_screen_prepare

2013-06-18 Thread Igor Grinberg
message. > > On Mon, Jun 17, 2013 at 11:26 PM, Igor Grinberg > wrote: >> >> On 06/17/13 21:31, Robert Winkler wrote: >>> Signed-off-by: Robert Winkler >> >> Usually, we add something to the commit message, otherwise >> Acked-by: Igor Grinberg >&

Re: [U-Boot] [PATCH] arm: omap: cm_t35: enable gpio bank 5 clocks explicitly

2013-12-31 Thread Igor Grinberg
y for > scf0403 lcd support. > > Enable GPIO bank 5 clocks. > > Signed-off-by: Nikita Kiryanov > Cc: Igor Grinberg > Cc: Tom Rini Acked-by: Igor Grinberg > --- > include/configs/cm_t35.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/conf

Re: [U-Boot] [PATCH] cm-t35: add I2C multi-bus support

2012-04-21 Thread Igor Grinberg
Hi Tom, On 04/20/12 20:27, Tom Rini wrote: > On Mon, Apr 2, 2012 at 5:29 AM, Igor Grinberg wrote: >> From: Nikita Kiryanov >> >> Enable I2C multi-bus support and config I2C muxes for I2C2 and I2C3. >> >> Signed-off-by: Nikita Kiryanov >> Signed-off-by: I

Re: [U-Boot] [PATCH RESEND] ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue

2012-05-04 Thread Igor Grinberg
On 05/04/12 12:06, Russ Dill wrote: > On Thu, May 3, 2012 at 11:03 PM, Igor Grinberg > wrote: >> Hi Russ, >> >> On 05/03/12 22:08, Russ Dill wrote: >>> On Wed, May 2, 2012 at 3:38 AM, Raja, Govindraj >>> wrote: >>>> On Wed, May 2, 2012 at

[U-Boot] [PATCH 0/7] common/lcd cleanup

2012-05-24 Thread Igor Grinberg
From: Nikita Kiryanov This patch series attempts to simplify #ifdef complexity in common/lcd.c. It preceeds my future work of adding splash screen support for omap. It was compile tested on Arm and PowerPC using MAKEALL, and is dependant on the following patches: http://patchwork.ozlabs.org/pat

[U-Boot] [PATCH 2/7] common lcd: simplify #ifdefs

2012-05-24 Thread Igor Grinberg
From: Nikita Kiryanov Simplify #ifdefs by slightly changing the order of operations Signed-off-by: Nikita Kiryanov Signed-off-by: Igor Grinberg --- common/lcd.c | 20 1 files changed, 8 insertions(+), 12 deletions(-) diff --git a/common/lcd.c b/common/lcd.c index

[U-Boot] [PATCH 3/7] common lcd: simplify bitmap_plot

2012-05-24 Thread Igor Grinberg
From: Nikita Kiryanov Simplify bitmap_plot in terms of number of #ifdefs by making some of the code into an external macro Signed-off-by: Nikita Kiryanov Signed-off-by: Igor Grinberg --- common/lcd.c | 26 ++ 1 files changed, 14 insertions(+), 12 deletions(-) diff

[U-Boot] [PATCH 1/7] common lcd: minor coding style changes

2012-05-24 Thread Igor Grinberg
From: Nikita Kiryanov No functional changes Signed-off-by: Nikita Kiryanov Signed-off-by: Igor Grinberg --- checkpatch reports a warning: 0001: line over 80 chars Since the original line was over 80 characters already, and there's no good way of shortening it, I left it

[U-Boot] [PATCH 4/7] common lcd: simplify lcd_logo

2012-05-24 Thread Igor Grinberg
From: Nikita Kiryanov Simplify lcd_logo by extracting bmp unzip into its own function. Signed-off-by: Nikita Kiryanov Signed-off-by: Igor Grinberg --- common/lcd.c | 30 -- 1 files changed, 20 insertions(+), 10 deletions(-) diff --git a/common/lcd.c b/common

[U-Boot] [PATCH 5/7] common lcd: simplify lcd_display

2012-05-24 Thread Igor Grinberg
From: Nikita Kiryanov Simplify lcd_display by centralizing code into a funciton Signed-off-by: Nikita Kiryanov Signed-off-by: Igor Grinberg --- common/lcd.c | 27 ++- 1 files changed, 18 insertions(+), 9 deletions(-) diff --git a/common/lcd.c b/common/lcd.c index

[U-Boot] [PATCH 6/7] common lcd: simplify core functions

2012-05-24 Thread Igor Grinberg
From: Nikita Kiryanov Move highly platform dependant code into its own function to reduce the number of #ifdefs in the bigger functions Signed-off-by: Nikita Kiryanov Signed-off-by: Igor Grinberg --- checkpatch reports a warning: 0006: WARNING: use of volatile is usually wrong Since

[U-Boot] [PATCH 7/7] common lcd: simplify lcd_display_bitmap

2012-05-24 Thread Igor Grinberg
From: Nikita Kiryanov Move highly platform dependant code into its own functions to reduce the number of #ifdefs in lcd_display_bitmap Signed-off-by: Nikita Kiryanov Signed-off-by: Igor Grinberg --- common/lcd.c | 44 +++- 1 files changed, 27

[U-Boot] [PATCH 2/4] cm-t35: fix incorrect BOARD_REV_SIZE value

2012-05-24 Thread Igor Grinberg
From: Nikita Kiryanov Non-legacy layouts have an extended revision field, but only the first 2 bytes are the PCB revision. Signed-off-by: Nikita Kiryanov Signed-off-by: Igor Grinberg --- board/cm_t35/eeprom.c | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a

[U-Boot] [PATCH 0/4] cm-t35 updates and non-critical fixes

2012-05-24 Thread Igor Grinberg
This patch set fixes various board revsion related issues, adds the PCB revision information printing and reduces the environment size. Igor Grinberg (1): cm-t35: reduce the environment size Nikita Kiryanov (3): cm-t35: fix incorrect BOARD_REV_SIZE value cm-t35: fix legacy board revision

[U-Boot] [PATCH 1/4] cm-t35: reduce the environment size

2012-05-24 Thread Igor Grinberg
Reduce the environment size (128KB => 16KB) to improve the environment operations time (e.g. reading, ecc calculation). Also, remove the unused CONFIG_SYS_ENV_SECT_SIZE. Signed-off-by: Igor Grinberg --- include/configs/cm_t35.h |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) d

[U-Boot] [PATCH 4/4] cm-t35: print PCB revision information

2012-05-24 Thread Igor Grinberg
From: Nikita Kiryanov Buffer the PCB revision to avoid multiple eeprom accesses for the same data and print it as a part of board information. Signed-off-by: Nikita Kiryanov Signed-off-by: Igor Grinberg --- board/cm_t35/cm_t35.c | 22 ++ board/cm_t35/eeprom.c |6

[U-Boot] [PATCH 3/4] cm-t35: fix legacy board revision representation

2012-05-24 Thread Igor Grinberg
representation with the semantic one. Signed-off-by: Nikita Kiryanov Signed-off-by: Igor Grinberg --- board/cm_t35/eeprom.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/board/cm_t35/eeprom.c b/board/cm_t35/eeprom.c index 6053811..4986b23 100644 --- a/board

Re: [U-Boot] [PATCH 4/4] cm-t35: print PCB revision information

2012-05-24 Thread Igor Grinberg
Hi Tom, On 05/24/12 21:11, Tom Rini wrote: > On Thu, May 24, 2012 at 05:01:24PM +0300, Igor Grinberg wrote: >> From: Nikita Kiryanov >> >> Buffer the PCB revision to avoid multiple eeprom accesses >> for the same data and print it as a part of board information.

Re: [U-Boot] [PATCH V2] tegra: Compulab TrimSlice board support

2012-05-31 Thread Igor Grinberg
On 05/30/12 19:22, Stephen Warren wrote: > On 05/30/2012 09:35 AM, Konstantin Sinyuk wrote: >> Hi Stephen, >> >> Thanks for doing this! >> We highly appreciate your help. >> We (Igor and me) have several comments below... >> >> >> On 05/17/2012 07:03 PM, Stephen Warren wrote: > >>> diff --git a/bo

Re: [U-Boot] [PATCH] tegra: trimslice: fix a couple typos

2012-05-31 Thread Igor Grinberg
On 05/30/12 19:45, Stephen Warren wrote: > From: Stephen Warren > > Fix the .dts file USB unit addresses not to duplicate each-other. > > Fix the board name string to indicate the vendor is Compulab not NVIDIA. > > Signed-off-by: Stephen Warren Acked-by: I

Re: [U-Boot] [PATCH] tegra: remove CONFIG_USB_ETHER_SMSC95XX from boards without it

2012-05-31 Thread Igor Grinberg
such a chip is > actually present on the board. > > The asix option remains, since it's a popular chip, and I actively use a > dongle containing this. > > Signed-off-by: Stephen Warren For trimslice: Acked-by: Igor Grinberg -- Regards, Igor.

Re: [U-Boot] [PATCH] tegra: trimslice: fix a couple typos

2012-05-31 Thread Igor Grinberg
On 05/31/12 19:50, Stephen Warren wrote: > On 05/31/2012 04:13 AM, Marek Vasut wrote: >> Dear Igor Grinberg, >> >>> On 05/30/12 19:45, Stephen Warren wrote: >>>> From: Stephen Warren >>>> >>>> Fix the .dts file USB unit addresses not to

Re: [U-Boot] [PATCH V2] tegra: Compulab TrimSlice board support

2012-05-31 Thread Igor Grinberg
Hi Tom, On 05/31/12 19:17, Tom Warren wrote: > Igor, > >> -Original Message----- >> From: Igor Grinberg [mailto:grinb...@compulab.co.il] >> Sent: Thursday, May 31, 2012 1:45 AM >> To: Stephen Warren >> Cc: Konstantin Sinyuk; Tom Warren; u-boot@lists.denx.d

Re: [U-Boot] [PATCH] tegra: trimslice: fix a couple typos

2012-06-02 Thread Igor Grinberg
On 06/01/12 18:45, Marek Vasut wrote: > Dear Stephen Warren, > >> On 06/01/2012 12:38 AM, Igor Grinberg wrote: >>> On 05/31/12 19:50, Stephen Warren wrote: >>>> On 05/31/2012 04:13 AM, Marek Vasut wrote: >>>>> Dear Igor Grinberg, >>>>&g

Re: [U-Boot] [PATCH 0/7] common/lcd cleanup

2012-06-08 Thread Igor Grinberg
gentle ping... On 05/24/12 14:42, Igor Grinberg wrote: > From: Nikita Kiryanov > > This patch series attempts to simplify #ifdef complexity in common/lcd.c. It > preceeds my future work of adding splash screen support for omap. > > It was compile tested on Arm and PowerPC

[U-Boot] [PATCH] arm: omap3: cm-t35: minor comment and printf change

2012-06-13 Thread Igor Grinberg
Fix the comment to reflect the actual function call time. Change the printf message to look nicer in the context it might be printed. Signed-off-by: Igor Grinberg --- board/cm_t35/cm_t35.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/board/cm_t35/cm_t35.c b/board

Re: [U-Boot] [PATCH v4 3/3] dm:gpio:mxc add DT support

2015-02-09 Thread Igor Grinberg
These will be done in future patches by step. > > Signed-off-by: Peng Fan Acked-by: Igor Grinberg -- Regards, Igor. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2] mx6: Rework s_init to be spl_board_init() and gate_ungate_all_mx6_pfds()

2015-02-11 Thread Igor Grinberg
nction. The cm_fx6 platform already > has a spl_board_init() so make that call the new function as well. > > Cc: Marek Vasut > Cc: Stefano Babic > Cc: Igor Grinberg > Cc: Nikita Kiryanov > Signed-off-by: Tom Rini Acked-by: I

Re: [U-Boot] [PATCH] omap3: ARM Cortex-A8 errata workarounds config option

2015-02-22 Thread Igor Grinberg
Hi Paul, On 02/22/15 13:36, Paul Kocialkowski wrote: > Workarounds applied in omap3_setup_aux_cr are only necessary for ARM core > revisions prior to r3p2 (such as OMAP35xx but apparently not OMAP36xx and > DM37xx) If this is true, I can see some (potential) problems with the patch. Please, check

Re: [U-Boot] [PATCH] arm: omap: cm_t35: Fix: Re-add GPMC_NAND_ECC_LP_x8_LAYOUT

2014-03-11 Thread Igor Grinberg
defines are needed, > the x16 defines are the default). Without it the NAND subsystem is > not configured correctly and booting into U-Boot does not work. > > Signed-off-by: Stefan Roese > Cc: Pekon Gupta > Cc: Nikita Kiryanov > Cc: Igor Grinberg > Cc: Tom Rini Acked-

Re: [U-Boot] [PATCH 1/1] env_mmc: support env partition setup in runtime

2014-07-29 Thread Igor Grinberg
c_switch_part() return value into init_mmc_for_env() instead >> of -1 in case of failure. >> >> Signed-off-by: Dmitry Lifshitz >> Signed-off-by: Igor Grinberg >> --- >> common/env_mmc.c | 35 +++ >> 1 files changed, 23 insertions

Re: [U-Boot] [PATCH 18/18] arm: mx6: cm_fx6: add sata support

2014-08-04 Thread Igor Grinberg
Hi Marek, On 08/03/14 17:10, Marek Vasut wrote: > On Sunday, August 03, 2014 at 09:34:48 AM, Nikita Kiryanov wrote: >> Add support for SATA. >> >> Cc: Igor Grinberg >> Cc: Stefano Babic >> Cc: Tom Rini >> Signed-off-by: Nikita Kiryanov > > I'

Re: [U-Boot] [PATCH 18/18] arm: mx6: cm_fx6: add sata support

2014-08-04 Thread Igor Grinberg
On 08/04/14 11:27, Marek Vasut wrote: > On Monday, August 04, 2014 at 09:23:12 AM, Igor Grinberg wrote: >> Hi Marek, >> >> On 08/03/14 17:10, Marek Vasut wrote: >>> On Sunday, August 03, 2014 at 09:34:48 AM, Nikita Kiryanov wrote: >>>> Add support for

Re: [U-Boot] [RFC PATCH v2 0/2] Make Python scripts compatible with older versions

2014-08-04 Thread Igor Grinberg
Hi Masahiro, On 08/04/14 13:23, Masahiro Yamada wrote: > > It was reported by Miao Yan that the kconfig-related Python scripts > are not working on Python 2.4. > > Do we have any consensus in terms of Python version requirement? > > This series avoids using "with ... as ..." and "except ... as

Re: [U-Boot] [RFC PATCH v2 0/2] Make Python scripts compatible with older versions

2014-08-04 Thread Igor Grinberg
Hi Masahiro, On 08/04/14 15:59, Masahiro Yamada wrote: > Hi. > >> >>> It seems that those scripts only work on Python versions 2.6 - 2.7? > > > > I took a quick look and I found Python 3.x is not comatible 2.x at all. > > 3.x requires the "print" is called like > print(msg, file=sys.stderr)

Re: [U-Boot] [PATCH] tools, scripts: refactor error-out statements of Python scripts

2014-08-06 Thread Igor Grinberg
Hi Masahiro, On 08/07/14 06:51, Masahiro Yamada wrote: > In Python, sys.exit() function can also take an object other > than an integer. > > If an integer is given to the argument, Python exits with the return > code of it. If a non-integer argument is given, Python output it > to stderr and exi

Re: [U-Boot] [RFC PATCH v2 0/2] Make Python scripts compatible with older versions

2014-08-07 Thread Igor Grinberg
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/07/14 13:57, Tom Rini wrote: > On Mon, Aug 04, 2014 at 04:17:00PM +0300, Igor Grinberg wrote: >> Hi Masahiro, >> >> On 08/04/14 15:59, Masahiro Yamada wrote: >>> Hi. >>> >>>> >>>>

Re: [U-Boot] [PATCH V2 2/9] mx6: add clock enabling functions

2014-08-07 Thread Igor Grinberg
Hi Nikita, On 08/07/14 16:05, Nikita Kiryanov wrote: > Add functions to enable/disable clocks for UART, SPI, ENET, and MMC. > > Cc: Stefano Babic > Signed-off-by: Nikita Kiryanov > --- > Changes in V2: > - No changes. > > arch/arm/cpu/armv7/mx6/clock.c| 99 > +++

Re: [U-Boot] [RFC PATCH v2 0/2] Make Python scripts compatible with older versions

2014-08-10 Thread Igor Grinberg
On 08/07/14 20:33, Stephen Warren wrote: > On 08/07/2014 10:57 AM, Tom Rini wrote: >> On Thu, Aug 07, 2014 at 04:17:21PM +0300, Igor Grinberg wrote: >>> On 08/07/14 13:57, Tom Rini wrote: > .. >>>> we just need >>>> /usr/bin/env python2 as how we

Re: [U-Boot] [PATCH V2 00/18] Introduce cm-fx6 board (partial V2 cont.)

2014-08-11 Thread Igor Grinberg
Hi Simon, On 08/11/14 03:11, Simon Glass wrote: > Hi Nikita, > > On 10 August 2014 11:12, Nikita Kiryanov wrote: >> This partial V2 completes the previous partial V2. It contains some final >> preparational steps, and the introduction of cm-fx6 board. >> >> Changes in V2: >> - Update com

Re: [U-Boot] [RFC PATCH v2 0/2] Make Python scripts compatible with older versions

2014-08-11 Thread Igor Grinberg
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/10/14 14:14, Tom Rini wrote: > On Sun, Aug 10, 2014 at 11:49:12AM +0300, Igor Grinberg wrote: >> >> >> On 08/07/14 20:33, Stephen Warren wrote: >>> On 08/07/2014 10:57 AM, Tom Rini wrote: >>>> On T

Re: [U-Boot] [PATCH V3 2/9] mx6: add clock enabling functions

2014-08-11 Thread Igor Grinberg
On 08/11/14 17:22, Nikita Kiryanov wrote: > Add functions to enable/disable clocks for UART, SPI, ENET, and MMC. > > Cc: Stefano Babic > Cc: Igor Grinberg > Signed-off-by: Nikita Kiryanov Acked-by: Igor Grinberg Thanks! -- Regards, Igor. __

Re: [U-Boot] Call for participation in the U-Boot Mini Summit 2014

2014-08-12 Thread Igor Grinberg
Hi, On 08/12/14 03:49, Marek Vasut wrote: > On Tuesday, August 12, 2014 at 02:02:55 AM, Masahiro YAMADA wrote: >> Hi. > > Hey, it's been a while :) > >> 2014-08-12 6:08 GMT+09:00 Tom Rini : >>> I think there were a few other requests, off-list. Also, we might want >>> to extend the deadline sli

Re: [U-Boot] Confusion when starting storage subsystems

2014-08-12 Thread Igor Grinberg
Hi, On 08/12/14 09:35, Alexander Holler wrote: > Hello, > > It would make me wonder if nobody else noticed it, but having to use > > sata init > usb start > mmc rescan > > to initialize storage subsystems isn't very convenient (or orthogonal in a > more knowledgable looking speak). ;) Yep, I

Re: [U-Boot] [RFC PATCH v2 0/2] Make Python scripts compatible with older versions

2014-08-12 Thread Igor Grinberg
On 08/11/14 19:58, Stephen Warren wrote: > On 08/10/2014 02:49 AM, Igor Grinberg wrote: >> >> >> On 08/07/14 20:33, Stephen Warren wrote: >>> On 08/07/2014 10:57 AM, Tom Rini wrote: >>>> On Thu, Aug 07, 2014 at 04:17:21PM +0300, Igor Grinberg wrot

Re: [U-Boot] [PATCH V2 10/18] arm: mx6: ddr: configure MMDC for slow_pd

2014-08-12 Thread Igor Grinberg
> Configure MMDC for slow pd. > > Cc: Stefano Babic > Cc: Tim Harvey > Signed-off-by: Nikita Kiryanov Acked-by: Igor Grinberg > --- > Changes in V2: > - Updated commit message to explain what bits in what registers > correspond to what settings. >

Re: [U-Boot] Newbies list?

2014-08-12 Thread Igor Grinberg
On 08/12/14 14:35, Jonathan Ben Avraham wrote: > On Tue, 12 Aug 2014, David Nelson wrote: > >> Date: Tue, 12 Aug 2014 01:14:55 -0600 >> From: David Nelson >> To: Donald Dade , u-boot@lists.denx.de >> Subject: Re: [U-Boot] Newbies list? >> >> On Aug 12, 2014 12:36 AM, "Donald Dade" wrote: >>> >>>

Re: [U-Boot] Newbies list?

2014-08-12 Thread Igor Grinberg
On 08/12/14 15:32, Jonathan Ben Avraham wrote: > On Tue, 12 Aug 2014, Igor Grinberg wrote: > >> Date: Tue, 12 Aug 2014 15:09:41 +0300 >> From: Igor Grinberg >> To: Jonathan Ben Avraham , David Nelson >> >> Cc: u-boot@lists.denx.de >> Subject: Re: [

Re: [U-Boot] [PATCH V3 12/18] arm: mx6: add support for Compulab cm-fx6 CoM

2014-08-13 Thread Igor Grinberg
Hi Nikita, Several comments below in addition to Simon's. On 08/11/14 19:22, Nikita Kiryanov wrote: > Add initial support for Compulab CM-FX6 CoM. > Support includes MMC, SPI flash, and SPL with dynamic DRAM detection. > > Cc: Igor Grinberg > Cc: Stefano Babic > Cc

Re: [U-Boot] [PATCH V2 14/18] arm: mx6: cm_fx6: add ethernet support

2014-08-13 Thread Igor Grinberg
On 08/10/14 20:12, Nikita Kiryanov wrote: > Add ethernet support for Compulab CM-FX6 CoM > > Cc: Igor Grinberg > Cc: Stefano Babic > Cc: Tom Rini > Signed-off-by: Nikita Kiryanov Acked-by: Igor Grinberg -- Regards, Igor. ___ U

Re: [U-Boot] [PATCH V2 15/18] arm: mx6: cm_fx6: add usb support

2014-08-13 Thread Igor Grinberg
On 08/10/14 20:12, Nikita Kiryanov wrote: > Add USB and USB OTG host support for Compulab CM-FX6 CoM. > > Cc: Igor Grinberg > Cc: Stefano Babic > Cc: Tom Rini > Signed-off-by: Nikita Kiryanov > --- > Changes in V2: > - No changes > > bo

Re: [U-Boot] [PATCH V2 13/18] arm: mx6: cm_fx6: add nand support

2014-08-13 Thread Igor Grinberg
On 08/10/14 20:12, Nikita Kiryanov wrote: > Add NAND support for Compulab CM-FX6 CoM. > > Cc: Igor Grinberg > Cc: Stefano Babic > Cc: Tom Rini > Signed-off-by: Nikita Kiryanov Acked-by: Igor Grinberg -- Regards, Igor. ___ U-B

Re: [U-Boot] [PATCH V2 16/18] arm: mx6: cm_fx6: add i2c support

2014-08-13 Thread Igor Grinberg
On 08/10/14 20:12, Nikita Kiryanov wrote: > Add support for all 3 I2C busses on Compulab CM-FX6 CoM. > > Cc: Igor Grinberg > Cc: Stefano Babic > Cc: Tom Rini > Signed-off-by: Nikita Kiryanov Acked-by: Igor Grinberg -- Regards, Igor.

Re: [U-Boot] [PATCH V2 17/18] arm: mx6: cm_fx6: use eeprom

2014-08-14 Thread Igor Grinberg
On 08/10/14 20:12, Nikita Kiryanov wrote: > Use Compulab eeprom module to obtain revision number, serial number, and > mac address from the EEPROM. > > Cc: Igor Grinberg > Cc: Stefano Babic > Cc: Tom Rini > Signed-off-by: Nikita Kiryanov > --- > Changes in V2: >

Re: [U-Boot] [PATCH V2 18/18] arm: mx6: cm_fx6: add sata support

2014-08-14 Thread Igor Grinberg
Hi Nikita, On 08/10/14 20:13, Nikita Kiryanov wrote: > Add support for SATA. > > Cc: Igor Grinberg > Cc: Stefano Babic > Cc: Tom Rini > Signed-off-by: Nikita Kiryanov > --- > Changes in V2: > - No changes > > bo

Re: [U-Boot] [PATCH V3 12/18] arm: mx6: add support for Compulab cm-fx6 CoM

2014-08-14 Thread Igor Grinberg
On 08/13/14 15:55, Igor Grinberg wrote: > Hi Nikita, > > Several comments below in addition to Simon's. > > On 08/11/14 19:22, Nikita Kiryanov wrote: >> Add initial support for Compulab CM-FX6 CoM. >> Support includes MMC, SPI flash, and SPL with dynamic DRAM de

Re: [U-Boot] [PATCH 0/3] cm-t54: misc board fixes, convert to generic board

2014-08-17 Thread Igor Grinberg
Gentle ping... On 07/31/14 14:30, Dmitry Lifshitz wrote: > Fix MAC address data read (from EEPROM) issue and boot mode check. > Convert to generic board. > > Dmitry Lifshitz (3): > cm-t54: fix EEPROM read return value check > cm-t54: fix eMMC boot mode check > cm-t54: convert to generic boa

Re: [U-Boot] [PATCH v2] kconfig: convert Kconfig helper script into a shell script

2014-08-18 Thread Igor Grinberg
tion, this commit revives "_config" target that is > equivalent to "_defconfig" for backwards compatibility. > It is annoying to adjust various projects which use U-Boot. > > Signed-off-by: Masahiro Yamada > Suggested-by: Igor Grinberg > Cc: Tom Rini > Cc:

Re: [U-Boot] [RFC PATCH] arm: mx6: Clamp MMDC and DDR3 clocks for timing calculations

2015-04-21 Thread Igor Grinberg
mem_speed (1333, 1600 MT/s) for > calculating the DDR timings, and uses fixed clock (528 or 400 MHz) which > doesn't take into account DDR3 memory limitations. > > Signed-off-by: Nikolay Dimitrov > Cc: Fabio Estevam > Cc: Stefano Babic > Cc: Tim Harvey > Cc: Eric Nel

Re: [U-Boot] single build of uboot supporting env stored in dynamically detected boot device

2015-04-21 Thread Igor Grinberg
Hi Tim, Sorry for that late reply. I guess better late then never... On 04/10/15 19:39, Simon Glass wrote: > Hi Tim, > > On 10 April 2015 at 09:42, Tim Harvey wrote: >> On Thu, Apr 9, 2015 at 11:07 PM, Stefan Roese wrote: >>> Hi Tim, >>> >>> (added Igor to cc) >>> >>> >>> On 10.04.2015 00:58,

Re: [U-Boot] [PATCH v3] env_mmc: correct fini partition to match init partition

2014-09-09 Thread Igor Grinberg
Hi Peter, On 09/03/14 20:22, Peter A. Bigot wrote: > The code to set the MMC partition uses an weak function to obtain the > correct partition number. Use that instead of the compile-time default > when deciding whether it needs to switch back. > > Fixes: 6e7b7df4df43574 ("env_mmc: support env p

Re: [U-Boot] A minor question on a Driver Model function

2014-09-15 Thread Igor Grinberg
Hi, On 09/14/14 21:28, Simon Glass wrote: > Hi Masahiro, > > On 12 September 2014 05:25, Masahiro Yamada wrote: >> Hi Simon, >> >> >> I have a qustion about lists_driver_lookup_name() function. >> >> >> >> for (entry = drv; entry != drv + n_ents; entry++) { >> if (strncmp

Re: [U-Boot] [PATCH 06/10] dm: imx: Use gpio_request() to request GPIOs

2014-09-15 Thread Igor Grinberg
Hi Simon, On 09/15/14 15:57, Simon Glass wrote: > GPIOs should be requested before use. Without this, driver model will not > permit the GPIO to be used. Right. That should have been done from the start... Sorry for that... A question below though.. > > Signed-off-by: Simon Glass > --- > > a

Re: [U-Boot] [PATCH 07/10] imximage.cfg: Remove copyright header

2014-09-15 Thread Igor Grinberg
On 09/15/14 15:57, Simon Glass wrote: > This seems to break mkimage: > > Invalid imximage commands Type - valid names are: BOOT_FROM, BOOT_OFFSET, > DATA, CSF, IMAGE_VERSION > Error: board/compulab/cm_fx6/imximage.cfg[1] - Invalid command(/*) That is really strange, because there are multiple im

Re: [U-Boot] [PATCH 08/10] dm: imx: gpio: Support driver model in MXC gpio driver

2014-09-15 Thread Igor Grinberg
Hi Simon, On 09/15/14 15:57, Simon Glass wrote: > Add driver model support with this driver. In this case the platform data > is in the driver. It would be better to put this into an SOC-specific file, > but this is best attempted when more boards are moved over to use driver > model. > > Signed-

Re: [U-Boot] [PATCH 06/10] dm: imx: Use gpio_request() to request GPIOs

2014-09-15 Thread Igor Grinberg
On 09/15/14 21:04, Simon Glass wrote: > Hi Igor, > > On 15 September 2014 11:13, Igor Grinberg wrote: >> Hi Simon, >> >> On 09/15/14 15:57, Simon Glass wrote: >>> GPIOs should be requested before use. Without this, driver model will not >>> permit

Re: [U-Boot] [PATCH 10/10] dm: imx: Move cm_fx6 to use driver model for serial and GPIO

2014-09-15 Thread Igor Grinberg
On 09/15/14 15:57, Simon Glass wrote: > Now that serial and GPIO are available for iMX.6, move cm_fx6 over as an > example. > > Signed-off-by: Simon Glass > --- > > board/compulab/cm_fx6/cm_fx6.c | 10 ++ > include/configs/cm_fx6.h | 11 +++ > 2 files changed, 21 insertion

Re: [U-Boot] [PATCH v2 04/11] initcall: Display error number when an error occurs

2014-09-17 Thread Igor Grinberg
Hi Simon, On 09/17/14 06:51, Simon Glass wrote: > Now that some initcall functions return a useful error number, display it > when something goes wrong. > > Signed-off-by: Simon Glass This is a great addition! Thanks! Acked-by: Igor Grinberg -- R

Re: [U-Boot] [PATCH v2 07/11] dm: imx: Add error checking to setup_i2c()

2014-09-17 Thread Igor Grinberg
Hi Simon, On 09/17/14 06:51, Simon Glass wrote: > Since this function can fail, check its return value. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Add new patch to add error checking to setup_i2c() > > arch/arm/imx-common/i2c-mxv7.c| 24 - > ar

Re: [U-Boot] [PATCH v2 08/11] dm: imx: Use gpio_request() to request GPIOs

2014-09-17 Thread Igor Grinberg
Hi Simon, On 09/17/14 06:51, Simon Glass wrote: > GPIOs should be requested before use. Without this, driver model will not > permit the GPIO to be used. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Check return values of gpio_request() > > arch/arm/imx-common/i2c-mxv7.c | 24 +

Re: [U-Boot] [PATCH v2 09/11] dm: imx: gpio: Support driver model in MXC gpio driver

2014-09-17 Thread Igor Grinberg
On 09/17/14 06:51, Simon Glass wrote: > Add driver model support with this driver. In this case the platform data > is in the driver. It would be better to put this into an SOC-specific file, > but this is best attempted when more boards are moved over to use driver > model. > > Signed-off-by: Sim

Re: [U-Boot] [PATCH v2 11/11] dm: imx: Move cm_fx6 to use driver model for serial and GPIO

2014-09-17 Thread Igor Grinberg
On 09/17/14 06:51, Simon Glass wrote: > Now that serial and GPIO are available for iMX.6, move cm_fx6 over as an > example. > > Signed-off-by: Simon Glass Thanks for doing this. Acked-by: Igor Grinberg > --- > > Changes in v2: > - Use the correct namespace for the p

Re: [U-Boot] A minor question on a Driver Model function

2014-09-17 Thread Igor Grinberg
On 09/17/14 11:18, Masahiro Yamada wrote: > Hi Igor, > > > > On Mon, 15 Sep 2014 11:04:20 +0300 > Igor Grinberg wrote: > >> Hi, >> >> On 09/14/14 21:28, Simon Glass wrote: >>> Hi Masahiro, >>> >>> On 12 September 2014 05:25, M

Re: [U-Boot] [PATCH] compulab: eeprom: add default eeprom bus

2014-09-17 Thread Igor Grinberg
On 09/17/14 15:59, Nikita Kiryanov wrote: > Add default eeprom bus setting. > This addresses the trimslice compile error that was introduced > with the addition of this setting. > > Cc: Albert ARIBAUD > Cc: Igor Grinberg > Signed-off-by: Nikita Kiryanov Acked-by: Igor Gr

Re: [U-Boot] [PATCH v2 07/11] dm: imx: Add error checking to setup_i2c()

2014-09-17 Thread Igor Grinberg
Hi Simon, On 09/17/14 16:56, Simon Glass wrote: > Hi Igor, > > On 17 September 2014 02:37, Igor Grinberg <mailto:grinb...@compulab.co.il>> wrote: > > Hi Simon, > > On 09/17/14 06:51, Simon Glass wrote: > > Since this funct

Re: [U-Boot] [PATCH v2 08/11] dm: imx: Use gpio_request() to request GPIOs

2014-09-17 Thread Igor Grinberg
On 09/17/14 17:00, Simon Glass wrote: > Hi Igor, > > On 17 September 2014 06:13, Igor Grinberg <mailto:grinb...@compulab.co.il>> wrote: > > Hi Simon, > > On 09/17/14 06:51, Simon Glass wrote: > > GPIOs should be requested before use. Wi

Re: [U-Boot] [PATCH v2 09/11] dm: imx: gpio: Support driver model in MXC gpio driver

2014-09-17 Thread Igor Grinberg
On 09/17/14 17:03, Simon Glass wrote: > Hi Igor, > > On 17 September 2014 07:00, Igor Grinberg <mailto:grinb...@compulab.co.il>> wrote: > > On 09/17/14 06:51, Simon Glass wrote: > > Add driver model support with this driver. In this case the platform >

Re: [U-Boot] [PATCH v2 08/11] dm: imx: Use gpio_request() to request GPIOs

2014-09-18 Thread Igor Grinberg
On 09/17/14 17:34, Simon Glass wrote: > Hi Igor, > > On 17 September 2014 08:31, Igor Grinberg <mailto:grinb...@compulab.co.il>> wrote: > > On 09/17/14 17:00, Simon Glass wrote: > > Hi Igor, > > > > On 17 September 2014 06:13, Igor

Re: [U-Boot] [PATCH v3 07/11] imx: Add error checking to setup_i2c()

2014-09-18 Thread Igor Grinberg
On 09/17/14 18:02, Simon Glass wrote: > Since this function can fail, check its return value. > > Signed-off-by: Simon Glass Thanks! Acked-by: Igor Grinberg -- Regards, Igor. ___ U-Boot mailing list U-Boot@lists.denx.de http://list

Re: [U-Boot] [PATCH v3 08/11] dm: imx: Use gpio_request() to request GPIOs

2014-09-18 Thread Igor Grinberg
On 09/17/14 18:02, Simon Glass wrote: > GPIOs should be requested before use. Without this, driver model will not > permit the GPIO to be used. > > Signed-off-by: Simon Glass Acked-by: Igor Grinberg -- Regards, Igor. ___ U-Boot mailing

Re: [U-Boot] [PATCH v3 09/11] dm: imx: gpio: Support driver model in MXC gpio driver

2014-09-18 Thread Igor Grinberg
> Signed-off-by: Simon Glass Acked-by: Igor Grinberg -- Regards, Igor. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] A minor question on a Driver Model function

2014-09-18 Thread Igor Grinberg
Hi Bill, On 09/17/14 18:25, Bill Pringlemeir wrote: > >> On 12 September 2014 05:25, Masahiro Yamada >> wrote: > >> I have a qustion about lists_driver_lookup_name() function. > >> for (entry = drv; entry != drv + n_ents; entry++) { >> if (strncmp(name, entry->name, len)) >> c

Re: [U-Boot] compulab trimslice build error due to 52658fda7abc ("compulab: eeprom: add support for defining eeprom i2c bus")

2014-09-18 Thread Igor Grinberg
Hi Stephen, On 09/18/14 20:21, Stephen Warren wrote: > After commit 52658fda7abc ("compulab: eeprom: add support for defining eeprom > i2c bus"), the trimslice board fails to build with: > > .../board/compulab/common/eeprom.c: In function ‘cl_eeprom_read’: > .../board/compulab/common/eeprom.c:37

Re: [U-Boot] A minor question on a Driver Model function

2014-09-18 Thread Igor Grinberg
On 09/18/14 18:46, Bill Pringlemeir wrote: > On 12 September 2014 05:25, Masahiro Yamada wrote: >>> I have a qustion about lists_driver_lookup_name() function. > >> On 09/14/14 21:28, Simon Glass wrote: >>> >> I would suggest still using strncmp as it is safer, >>

Re: [U-Boot] A minor question on a Driver Model function

2014-09-19 Thread Igor Grinberg
On 09/19/14 09:54, Masahiro Yamada wrote: > > On Fri, 19 Sep 2014 09:34:53 +0300 > Igor Grinberg wrote: > >> On 09/18/14 18:46, Bill Pringlemeir wrote: >>> >>>>>> On 12 September 2014 05:25, Masahiro Yamada >>>>>> wrote: &

  1   2   3   4   5   6   7   8   >