[RESEND][PATCH 1/3] usb_kbd: succeed even if no interrupt is pending

ervice was changed to a nonblocking operation for the controllers that support this. With the patch applied, the rpi3 and rpi4 work well with the more complex keyboard devices. Signed-off-by: Jason Wessel --- common/usb_kbd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --gi

[RESEND][PATCH 0/3] Raspberry pi improvements usb core

The commit 57805f2270c4 ("net: bcmgenet: Don't set ID_MODE_DIS when not using RGMII") needed to be extended for the case of using the rgmii-rxid. The latest version of the Rasbperry Pi4 dtb files for the 5.4 now specify the rgmii-rxid. Signed-off-by: Jason Wessel Commit 9a21770

[RESEND][PATCH 3/3] usb.c: Add a retry in the usb_prepare_device()

function properly. Signed-off-by: Jason Wessel --- common/usb.c | 9 + 1 file changed, 9 insertions(+) diff --git a/common/usb.c b/common/usb.c index 0eb5d40a2d..39bae86a11 100644 --- a/common/usb.c +++ b/common/usb.c @@ -1032,6 +1032,7 @@ static int usb_prepare_device(struct usb_device

[RESEND][PATCH 2/3] common/usb.c: Work around keyboard reporting "USB device not accepting new address"

continuing allows the usb keyboard and other usb devices to work function. Signed-off-by: Jason Wessel --- common/usb.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/common/usb.c b/common/usb.c index aad13fd9c5..0eb5d40a2d 100644 --- a/common/usb.c +++ b/common/usb.c

Re: [RESEND][PATCH 1/3] usb_kbd: succeed even if no interrupt is pending

On 8/18/20 10:05 AM, Marek Vasut wrote: > On 8/18/20 4:34 PM, Jason Wessel wrote: >> After the initial configuration some USB keyboard+mouse devices never >> return any kind of event on the interrupt line. In particular, the >> device identified by "Cypress Cypress U

Re: [RESEND][PATCH 3/3] usb.c: Add a retry in the usb_prepare_device()

e devices... 1 Storage Device(s) found The only way I found to make it work reliably was to have it retry in the usb_prepare_device(). Jason. On 8/18/20 10:08 AM, Marek Vasut wrote: > On 8/18/20 4:34 PM, Jason Wessel wrote: >> I have found through testing some USB 2 composite mouse/keyb

Re: [RESEND][PATCH 2/3] common/usb.c: Work around keyboard reporting "USB device not accepting new address"

On 8/18/20 10:08 AM, Marek Vasut wrote: > On 8/18/20 4:34 PM, Jason Wessel wrote: >> When resetting the rpi3 board sometimes it will display: >> USB device not accepting new address (error=0) >> >> After the message appears, the usb keyboard will not

Re: [RESEND][PATCH 1/3] usb_kbd: succeed even if no interrupt is pending

On 8/18/20 12:20 PM, Marek Vasut wrote: > On 8/18/20 6:54 PM, Jason Wessel wrote: >> >> >> On 8/18/20 10:05 AM, Marek Vasut wrote: >>> On 8/18/20 4:34 PM, Jason Wessel wrote: >>>> After the initial configuration some USB keyboard+mouse devices

[PATCH 0/2][v2] Raspberry pi improvements usb core

new patches allow for a wider variety of usb keyboards to be used with u-boot. Jason Wessel (2): usb_kbd: Remove the initial interrupt request dwc2: Retry when a usb_stall occurs. common/usb_kbd.c| 10 +- drivers/usb/host/dwc2.c | 3 +++ 2 files changed, 8 insertions

Re: [PATCH 5/9] xhci-ring.c: Add the poll_pend state to properly abort transactions

On 8/20/20 3:26 AM, Bin Meng wrote: > Hi Jason, > > On Sat, Jul 25, 2020 at 5:51 AM Jason Wessel > wrote: >> >> xhci_trl_tx and xhchi_bulk_tx can be called synchronously by other >> drivers such as the usb storage or network, while the keyboard driver >&g

[PATCH v2 1/4] xhci.c: Add retry in xhci_address_device()

for devices... Device not responding to set address. USB device not accepting new address (error=8000) Signed-off-by: Jason Wessel --- drivers/usb/host/xhci.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index

[PATCH v2 4/4] xhci-ring.c: Fix crash when issuing "usb reset"

ing u-boot from a null dereference. Signed-off-by: Jason Wessel --- drivers/usb/host/xhci-ring.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index 00a0491771..bbb4410908 100644 --- a/drivers/usb

[PATCH 0/4][v2] xhci fixes for rpi4

. Jason Wessel (4): xhci.c: Add retry in xhci_address_device() xhci.c: Add polling support for USB keyboards xhci-ring.c: Add poll pending state to properly abort transactions xhci-ring.c: Fix crash when issuing "usb reset" drivers/usb/host/xhci-ri

[PATCH v2 2/4] xhci.c: Add polling support for USB keyboards

state was added to quickly return instead of blocking for up to 5 seconds waiting for an event before timing out. Signed-off-by: Jason Wessel --- drivers/usb/host/xhci-ring.c | 26 +- drivers/usb/host/xhci.c | 11 ++- include/usb/xhci.h | 5 +++-

[PATCH v2 3/4] xhci-ring.c: Add poll pending state to properly abort transactions

a series of commands and responses from a specific device. Signed-off-by: Jason Wessel --- drivers/usb/host/xhci-ring.c | 80 include/usb/xhci.h | 5 +++ 2 files changed, 69 insertions(+), 16 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b

[RFC PATCH v2 2/5] usb_kbd: Do not fail the keyboard if it does not have an interrupt pending

all to the interrupt service was changed to a nonblocking operation for the controllers that support this. With the patch applied, the rpi3 and rpi4 work well with the more complex keyboard devices. Signed-off-by: Jason Wessel --- common/usb_kbd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletio

[RFC PATCH v2 1/5] xhci: Add polling support for USB keyboards

state was added to quickly return instead of blocking for up to 5 seconds waiting for an event before timing out. Signed-off-by: Jason Wessel --- drivers/usb/host/xhci-ring.c | 26 +- drivers/usb/host/xhci.c | 11 ++- include/usb/xhci.h | 5 +++-

[RFC PATCH v2 0/5] Improve USB Keyboard support for rpi3/rpi4

and mouse without any issues. ---- Jason Wessel (5): xhci: Add polling support for USB keyboards usb_kbd: Do not fail the keyboard if it does not have an interrupt pending common/usb.c: Work around keyboard reporting "U

[RFC PATCH v2 3/5] common/usb.c: Work around keyboard reporting "USB device not accepting new address"

continuing allows the usb keyboard and other usb devices to work function. Signed-off-by: Jason Wessel --- common/usb.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/common/usb.c b/common/usb.c index aad13fd9c5..ba83bb960b 100644 --- a/common/usb.c +++ b/common/usb.c

[RFC PATCH v2 4/5] xhci-ring.c: Add the poll_pend state to properly abort transactions

. Signed-off-by: Jason Wessel --- drivers/usb/host/xhci-ring.c | 86 +--- 1 file changed, 70 insertions(+), 16 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index b7b2e16410..1c00f2d496 100644 --- a/drivers/usb/host/xhci-ring.c

[RFC PATCH v2 5/5] xhci-ring: Fix crash when issuing "usb reset"

lag should be cleared. Signed-off-by: Jason Wessel --- drivers/usb/host/xhci-ring.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index 1c00f2d496..ed0dea9fca 100644 --- a/drivers/usb/host/xhci-ri

[RFC PATCH v3 2/6] usb_kbd: Do not fail the keyboard if it does not have an interrupt pending

all to the interrupt service was changed to a nonblocking operation for the controllers that support this. With the patch applied, the rpi3 and rpi4 work well with the more complex keyboard devices. Signed-off-by: Jason Wessel --- common/usb_kbd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletio

[RFC PATCH v3 4/6] xhci-ring.c: Add the poll_pend state to properly abort transactions

. Signed-off-by: Jason Wessel --- drivers/usb/host/xhci-ring.c | 86 +--- 1 file changed, 70 insertions(+), 16 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index b7b2e16410..1c00f2d496 100644 --- a/drivers/usb/host/xhci-ring.c

[RFC PATCH v3 3/6] common/usb.c: Work around keyboard reporting "USB device not accepting new address"

continuing allows the usb keyboard and other usb devices to work function. Signed-off-by: Jason Wessel --- common/usb.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/common/usb.c b/common/usb.c index aad13fd9c5..ba83bb960b 100644 --- a/common/usb.c +++ b/common/usb.c

[RFC PATCH v3 1/6] xhci: Add polling support for USB keyboards

state was added to quickly return instead of blocking for up to 5 seconds waiting for an event before timing out. Signed-off-by: Jason Wessel --- drivers/usb/host/xhci-ring.c | 26 +- drivers/usb/host/xhci.c | 11 ++- include/usb/xhci.h | 5 +++-

[RFC PATCH v3 6/6] usb.c: Add a retry in the usb_prepare_device()

function properly. Signed-off-by: Jason Wessel --- common/usb.c | 9 + 1 file changed, 9 insertions(+) diff --git a/common/usb.c b/common/usb.c index ba83bb960b..fb091440cc 100644 --- a/common/usb.c +++ b/common/usb.c @@ -1054,6 +1054,15 @@ static int usb_prepare_device(struct

[RFC PATCH v3 0/6] Improve USB Keyboard support for rpi3/rpi4

nges are in the core USB functions. I performed tests with a number of usb modules attached including storage, ethernet, serial, wifi, keyboard, and mouse without any issues. ---- Jason Wessel (6): xhci: Add polling support for

[RFC PATCH v3 5/6] xhci-ring: Fix crash when issuing "usb reset"

lag should be cleared. Signed-off-by: Jason Wessel --- drivers/usb/host/xhci-ring.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index 1c00f2d496..ed0dea9fca 100644 --- a/drivers/usb/host/xhci-ri

[PATCH 0/6] Improve USB Keyboard support for all rpi boards

l to read an event. This causes major problems for the sleep function as well as for ethernet downloads where a keyboard poll for interrupting the download blocks for 5 seconds. ---- Jason Wessel (6): xhci: Add polling support for

[PATCH 3/6] common/usb.c: Work around keyboard reporting "USB device not accepting new address"

continuing allows the usb keyboard and other usb devices to work function. Signed-off-by: Jason Wessel --- common/usb.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/common/usb.c b/common/usb.c index aad13fd9c5..0eb5d40a2d 100644 --- a/common/usb.c +++ b/common/usb.c

[PATCH 4/6] xhci-ring.c: Add the poll_pend state to properly abort transactions

. Signed-off-by: Jason Wessel --- drivers/usb/host/xhci-ring.c | 86 +--- 1 file changed, 70 insertions(+), 16 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index b7b2e16410..d6339f4f0a 100644 --- a/drivers/usb/host/xhci-ring.c

[PATCH 2/6] usb_kbd: succeed even if no interrupt is pending

ervice was changed to a nonblocking operation for the controllers that support this. With the patch applied, the rpi3 and rpi4 work well with the more complex keyboard devices. Signed-off-by: Jason Wessel --- common/usb_kbd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --gi

[PATCH 5/6] xhci-ring: Fix crash when issuing "usb reset"

lag should be cleared. Signed-off-by: Jason Wessel --- drivers/usb/host/xhci-ring.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index d6339f4f0a..f2a07204cd 100644 --- a/drivers/usb/host/xhci-ri

[PATCH 1/6] xhci: Add polling support for USB keyboards

state was added to quickly return instead of blocking for up to 5 seconds waiting for an event before timing out. Signed-off-by: Jason Wessel --- drivers/usb/host/xhci-ring.c | 26 +- drivers/usb/host/xhci.c | 11 ++- include/usb/xhci.h | 5 +++-

[PATCH 6/6] usb.c: Add a retry in the usb_prepare_device()

function properly. Signed-off-by: Jason Wessel --- common/usb.c | 9 + 1 file changed, 9 insertions(+) diff --git a/common/usb.c b/common/usb.c index 0eb5d40a2d..39bae86a11 100644 --- a/common/usb.c +++ b/common/usb.c @@ -1032,6 +1032,7 @@ static int usb_prepare_device(struct usb_device

Re: [PATCH] bcmgenet: fix DMA buffer management

On 7/9/20 3:11 AM, etienne.du...@gmail.com wrote: > From: Etienne Dublé > > This commit fixes a serious issue occuring when several network > commands are run on a raspberry pi 4 board: for instance a "dhcp" > command and then one or several "tftp" commands. In this case, > packet recv callbacks

Re: [PATCH] bcmgenet: fix DMA buffer management

On 7/16/20 7:02 AM, Jason Wessel wrote: > On 7/9/20 3:11 AM, etienne.du...@gmail.com wrote: >> From: Etienne Dublé >> >> This commit fixes a serious issue occuring when several network >> commands are run on a raspberry pi 4 board: for instance a "dhcp" >

Re: [PATCH] bcmgenet: fix DMA buffer management

On 7/16/20 11:02 AM, Jason Wessel wrote: > > > On 7/16/20 7:02 AM, Jason Wessel wrote: >> On 7/9/20 3:11 AM, etienne.du...@gmail.com wrote: >>> From: Etienne Dublé >>> >>> This commit fixes a serious issue occuring when several network >>&

[PATCH 1/2] bcmgenet: fix DMA buffer management

ide, and a few variables had to be reset accordingly (c_index, tx_index, rx_index). The rx_index and tx_index have only 256 entries so the bottom 8 bits must be masked off. Originated-by: Etienne Dublé Signed-off-by: Jason Wessel --- drivers/net/bcmgenet.c | 17 + 1 file changed, 9 ins

[PATCH 2/2] bcmgenet: Add support for rgmii-rxid

The commit 57805f2270c4 ("net: bcmgenet: Don't set ID_MODE_DIS when not using RGMII") needed to be extended for the case of using the rgmii-rxid. The latest version of the Rasbperry Pi4 dtb files for the 5.4 now specify the rgmii-rxid. Signed-off-by: Jason Wessel --- drivers/net

[PATCH] fs/fat.c: Do not perform zero block reads if there are no blocks left

30 20 72 6f 6f 74 77 61 69 74 0a le=0 rootwait. ----- Signed-off-by: Jason Wessel --- fs/fat/fat.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/fat/fat.c b/fs/fat/fat.c index 7fd29470c1..8233a74620 100644 --- a/fs/fat/fat.

[PATCH] fs/fat/fat.c: Do not perform zero block reads if there are no blocks left

70 6d 5f 65 6e 61 62dwc_otg.lpm_enab 40080010: 6c 65 3d 30 20 72 6f 6f 74 77 61 69 74 0a le=0 rootwait. ----- Signed-off-by: Jason Wessel --- fs/fat/fat.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/fat/fat.c b/fs/fat/fat.c index 7f

[PATCH] fs/fat.c: Do not perform zero block reads if there are no blocks left

30 20 72 6f 6f 74 77 61 69 74 0a le=0 rootwait. ----- Signed-off-by: Jason Wessel --- fs/fat/fat.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/fat/fat.c b/fs/fat/fat.c index 7fd29470c1..8233a74620 100644 --- a/fs/fat/fat.

[PATCH v3] fs/fat/fat.c: Do not perform zero block reads if there are no blocks left

30 20 72 6f 6f 74 77 61 69 74 0a le=0 rootwait. ----- Signed-off-by: Jason Wessel Signed-off-by: Jason Wessel --- fs/fat/fat.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/fat/fat.c b/fs/fat/fat.c index 7fd29470c1..dfad1e910b

[RFC PATCH 3/3] common/usb.c: Work around keyboard reporting "USB device not accepting new address"

continuing allows the usb keyboard and other usb devices to work function. Signed-off-by: Jason Wessel --- common/usb.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/common/usb.c b/common/usb.c index aad13fd9c5..2f7f205444 100644 --- a/common/usb.c +++ b/common/usb.c

[RFC PATCH 0/3] Improve USB Keyboard support for rpi3/rpi4

, serial, wifi, keyboard, and mouse without any issues. Jason Wessel (3): xhci: Add polling support for USB keyboards usb_kbd: Do not fail the keyboard if it does not have an interrupt pending common/usb.c: Work around

[RFC PATCH 1/3] xhci: Add polling support for USB keyboards

state was added to quickly return instead of blocking for up to 5 seconds waiting for an event before timing out. Signed-off-by: Jason Wessel --- drivers/usb/host/xhci-ring.c | 24 +++- drivers/usb/host/xhci.c | 10 +- include/usb/xhci.h | 5 +++-- 3 fil

[RFC PATCH 2/3] usb_kbd: Do not fail the keyboard if it does not have an interrupt pending

all to the interrupt service was changed to a nonblocking operation for the controllers that support this. With the patch applied, the rpi3 and rpi4 work well with the more complex keyboard devices. Signed-off-by: Jason Wessel --- common/usb_kbd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletio

[PATCH 3/9] usb_kbd: succeed even if no interrupt is pending

ervice was changed to a nonblocking operation for the controllers that support this. With the patch applied, the rpi3 and rpi4 work well with the more complex keyboard devices. Signed-off-by: Jason Wessel --- common/usb_kbd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --gi

[PATCH 4/9] common/usb.c: Work around keyboard reporting "USB device not accepting new address"

continuing allows the usb keyboard and other usb devices to work function. Signed-off-by: Jason Wessel --- common/usb.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/common/usb.c b/common/usb.c index aad13fd9c5..0eb5d40a2d 100644 --- a/common/usb.c +++ b/common/usb.c

[PATCH 6/9] xhci-ring: Fix crash when issuing "usb reset"

lag should be cleared. Signed-off-by: Jason Wessel --- drivers/usb/host/xhci-ring.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index d6339f4f0a..f2a07204cd 100644 --- a/drivers/usb/host/xhci-ri

[PATCH 9/9] bcmgenet: Add support for rgmii-rxid

The commit 57805f2270c4 ("net: bcmgenet: Don't set ID_MODE_DIS when not using RGMII") needed to be extended for the case of using the rgmii-rxid. The latest version of the Rasbperry Pi4 dtb files for the 5.4 now specify the rgmii-rxid. Signed-off-by: Jason Wessel --- drivers/net

[PATCH 2/9] xhci: Add polling support for USB keyboards

state was added to quickly return instead of blocking for up to 5 seconds waiting for an event before timing out. Signed-off-by: Jason Wessel --- drivers/usb/host/xhci-ring.c | 26 +- drivers/usb/host/xhci.c | 11 ++- include/usb/xhci.h | 5 +++-

[PATCH 5/9] xhci-ring.c: Add the poll_pend state to properly abort transactions

. Signed-off-by: Jason Wessel --- drivers/usb/host/xhci-ring.c | 86 +--- 1 file changed, 70 insertions(+), 16 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index b7b2e16410..d6339f4f0a 100644 --- a/drivers/usb/host/xhci-ring.c

[PATCH 7/9] usb.c: Add a retry in the usb_prepare_device()

function properly. Signed-off-by: Jason Wessel --- common/usb.c | 9 + 1 file changed, 9 insertions(+) diff --git a/common/usb.c b/common/usb.c index 0eb5d40a2d..39bae86a11 100644 --- a/common/usb.c +++ b/common/usb.c @@ -1032,6 +1032,7 @@ static int usb_prepare_device(struct usb_device

[PATCH 1/9] fs/fat/fat.c: Do not perform zero block reads if there are no blocks left

30 20 72 6f 6f 74 77 61 69 74 0a le=0 rootwait. ----- Signed-off-by: Jason Wessel Reviewed-by: Tom Rini --- fs/fat/fat.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/fat/fat.c b/fs/fat/fat.c index 9578b74bae..28aa5aaa9f 10064

[PULL][PATCH 0/9] Raspberry pi improvements qemu/usb/ethernet

5.4 now specify the rgmii-rxid. Signed-off-by: Jason Wessel Commit 9a21770 #35: Rpi master Branch master -- End Travis CI checks -- Prior to this patch set, I had just a small number of USB keyboards function properly with the Rasbpberry Pi boards. Nearly every composite USB keyboard/mouse

[PATCH 8/9] bcmgenet: fix DMA buffer management

ide, and a few variables had to be reset accordingly (c_index, tx_index, rx_index). The rx_index and tx_index have only 256 entries so the bottom 8 bits must be masked off. Originated-by: Etienne Dublé Signed-off-by: Jason Wessel --- drivers/net/bcmgenet.c | 17 + 1 file changed, 9 ins