[U-Boot] [PATCH v2] rockchip: rk3288: Fix pinctrl for GPIO bank 0

2016-07-25 Thread John Keeping
e top half of the register is reserved. Take the same approach as the Linux driver to update the value via read-modify-write but setting the mask for only the bits that have changed. The PMU registers ignore the top 16 bits so this works for both GRF and PMU iomux registers. Signed-off-by: John

[U-Boot] [PATCH] rockchip: rk3288: Fix pinctrl for GPIO bank 0

2016-07-21 Thread John Keeping
e top half of the register is reserved. Take the same approach as the Linux driver to update the value via read-modify-write but setting the mask for only the bits that have changed. The PMU registers ignore the top 16 bits so this works for both GRF and PMU iomux registers. Signed-off-by: John

[U-Boot] [PATCH v2] rockchip: sdram: Fix register layout for Linux

2016-07-15 Thread John Keeping
but parenthese have been added to apply the mask correctly when reading the "bw" setting and a couple of minor style issues have been fixed to keep check_patch.pl happy. Signed-off-by: John Keeping <j...@metanate.com> --- Changes in v2: - Reword the commit message to not be "R

[U-Boot] [PATCH] Revert "Revert "rockchip: rk3288: correct sdram setting""

2016-07-15 Thread John Keeping
The original commit was correct, except fot the priority of the mask when extracting "bw" to calculate the SDRAM size. Add the necessary parentheses so that we can apply the original fix. This reverts commit b525556e6325aa71427c0519f36247981cd444df. Signed-off-by: John

[U-Boot] [PATCH 2/2] power: pmic: act8846: add missing newline to debug statements

2016-08-07 Thread John Keeping
Signed-off-by: John Keeping <j...@metanate.com> --- drivers/power/pmic/act8846.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/power/pmic/act8846.c b/drivers/power/pmic/act8846.c index ff096b3..e8164bf 100644 --- a/drivers/power/pmic/act8846.c +++ b/d

[U-Boot] [PATCH 1/2] power: regulator: act8846: fix reading values

2016-08-07 Thread John Keeping
The voltage and control registers need to be looked up from the value in driver_data. Adjust the get_value and get_enable functions to match the corresponding set_* functions. Signed-off-by: John Keeping <j...@metanate.com> --- drivers/power/regulator/act8846.c | 4 ++-- 1 file chan

[U-Boot] [PATCH] regulator: fixed: obey startup delay

2016-08-22 Thread John Keeping
When enabling a fixed regulator, it may take some time to rise to the correct voltage. If we do not delay here then subsequent operations will fail. Signed-off-by: John Keeping <j...@metanate.com> --- doc/device-tree-bindings/regulator/fixed.txt | 1 + drivers/power/regulator/f

Re: [U-Boot] [PATCH v3 3/5] regulator: fixed: honour optionality of enable gpio

2016-09-15 Thread John Keeping
On Thu, 15 Sep 2016 09:27:22 +0200, Marcel Ziswiler wrote: > According to the binding documentation the fixed regulator enable GPIO > is optional. However so far registration thereof failed if no enable > GPIO was specified. Fix this by making it entirely optional whether an > enable GPIO is

[U-Boot] [PATCH] fastboot: avoid printing invalid data

2016-09-19 Thread John Keeping
There is no guarantee that commands are null-terminated in the USB request buffer, so limit the length of data that is printed. Signed-off-by: John Keeping <j...@metanate.com> --- drivers/usb/gadget/f_fastboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[U-Boot] [PATCH 2/3] rockchip: i2c: move register write out of inner loop

2016-08-18 Thread John Keeping
There is no point in writing intermediate values to the txdata registers. Also add padding to the debug logging to make it easier to read when there are leading zeroes. Signed-off-by: John Keeping <j...@metanate.com> --- drivers/i2c/rk_i2c.c | 4 ++-- 1 file changed, 2 insertions

[U-Boot] [PATCH 1/3] rockchip: i2c: use named constant when appropriate

2016-08-18 Thread John Keeping
Make it clear that we are using the same value in two adjacent lines. Signed-off-by: John Keeping <j...@metanate.com> --- drivers/i2c/rk_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/rk_i2c.c b/drivers/i2c/rk_i2c.c index 63b1418..2597970

[U-Boot] [PATCH 3/3] rockchip: i2c: fix >32 byte writes

2016-08-18 Thread John Keeping
The special handling of the chip address and register address must only happen before we send the data buffer, otherwise we will end up inserting both of these every 32 bytes. Signed-off-by: John Keeping <j...@metanate.com> --- I'm not entirely sure about this; it's the smallest

[U-Boot] [PATCH 0/3] rockchip: i2c: fix >32 byte writes

2016-08-18 Thread John Keeping
The first two patches are just cleanup that I noticed while in the area, the point of the series is the final patch which fixes an error when trying to write more than 32 bytes via the Rockchip I2C driver. John Keeping (3): rockchip: i2c: use named constant when appropriate rockchip: i2c

[PATCH] fit: Allow external data for FDTs

2021-06-25 Thread John Keeping
Switch to fit_image_get_data_and_size() for consistency with all other data loaded from FIT. Signed-off-by: John Keeping --- common/image-fit.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/common/image-fit.c b/common/image-fit.c index 94501b1071..4c5a24806d 100644

Re: [PATCH] fit: Fix verification of images with external data

2021-05-19 Thread John Keeping
On Tue, 20 Apr 2021 19:19:44 +0100 John Keeping wrote: > The "-E" option to mkimage generates a FIT with external data using the > data-size and data-offset properties which must both be ignored when > verifying a signature. > > Add "data-offset" to the list o

[PATCH] spl: use CONFIG_IS_ENABLED(LOAD_FIT_FULL)

2021-05-19 Thread John Keeping
is checked. Signed-off-by: John Keeping --- common/spl/spl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/spl/spl.c b/common/spl/spl.c index a0a608fd77..c4019d2bfc 100644 --- a/common/spl/spl.c +++ b/common/spl/spl.c @@ -198,7 +198,7 @@ void

[PATCH] fit: Fix verification of images with external data

2021-04-20 Thread John Keeping
, re-format the list to one-per-line and make it static since the data is constant. Signed-off-by: John Keeping --- common/image-fit-sig.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/common/image-fit-sig.c b/common/image-fit-sig.c index 55ddf1879e..b979cd2a4b 10064

[PATCH] rockchip: boot_mode: fix fastboot command

2021-11-25 Thread John Keeping
The USB controller index must be separated from the type argument, otherwise the preboot command fails with the error: Error: Wrong USB controller index format Add the missing space to fix fastboot mode here. Signed-off-by: John Keeping --- arch/arm/mach-rockchip/boot_mode.c | 2

[PATCH] mmc: dwmmc: return a proper error code when busy

2021-12-07 Thread John Keeping
When failing to send a command because the hardware is busy, return EBUSY to indicate the cause instead of just -1. Signed-off-by: John Keeping --- drivers/mmc/dw_mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c index

Re: [PATCH] mmc: dwmmc: return a proper error code when busy

2022-01-12 Thread John Keeping
On Wed, Jan 12, 2022 at 08:38:01AM +0900, Jaehoon Chung wrote: > On 1/12/22 7:12 AM, Jaehoon Chung wrote: > > On 1/12/22 1:15 AM, John Keeping wrote: > >> When failing to send a command because the hardware is busy, return > >> EBUSY to indicate the cause instead of

[PATCH] misc: mark write buffer const

2022-01-11 Thread John Keeping
The write operation in misc_ops already takes a "const void *" buffer, but misc_write() takes a mutable "void *". There's no reason for this, so make misc_write() consistent with the standard write() prototype. Signed-off-by: John Keeping --- drivers/misc/misc-uclass.c |

[PATCH] mmc: dwmmc: return a proper error code when busy

2022-01-11 Thread John Keeping
When failing to send a command because the hardware is busy, return EBUSY to indicate the cause instead of just -1. Signed-off-by: John Keeping --- drivers/mmc/dw_mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c index

Re: [PATCH] adc: rockchip-saradc: add support for getting reference voltage value

2022-02-03 Thread John Keeping
the ADC's > reference voltage regulator, so clients can translate sampled ADC values > to voltage. > > Signed-off-by: Peter Cai > Cc: Simon Glass > Cc: Philipp Tomsich > Cc: Kever Yang One code style nit below, but: Reviewed-by: John Keeping Tested-by: John Keeping The result

[PATCH] fdt: don't set linux,phandle

2022-04-20 Thread John Keeping
ember 2017 with the justification that the new style had already been supported for 7 years by that point (see dtc commit 0016f8c ("dtc: change default phandles to ePAPR style instead of both")). Signed-off-by: John Keeping --- common/fdt_support.c | 8 1 file changed, 8 dele

[PATCH] rockchip: rk3308: fix rockchip_dnl_key_pressed() on roc-cc

2022-07-14 Thread John Keeping
full name including the address. Signed-off-by: John Keeping --- board/firefly/firefly-rk3308/roc_cc_rk3308.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/firefly/firefly-rk3308/roc_cc_rk3308.c b/board/firefly/firefly-rk3308/roc_cc_rk3308.c index 28dcc2a690..bdf3cc0

[PATCH] rockchip: rk3308: fix same-as-spl boot order

2022-07-14 Thread John Keeping
Rockchip SoCs need the boot_devices array defined in order to map the bootloader's value to a U-Boot device. Implement this for rk3308. Signed-off-by: John Keeping --- arch/arm/mach-rockchip/rk3308/rk3308.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/mach-rockchip/rk3308

[PATCH/RFC] rockchip: derive GPIO bank from alias if available

2022-07-26 Thread John Keeping
t method if no alias is defined. Signed-off-by: John Keeping --- I'm not sure if it would be better just to use dev_seq(dev) unconditionally here. If no aliases are defined, then the device tree nodes are in the right order for all Rockchip SoCs anyway so the sequence numbers will be sensible. But this f

[PATCH v2] boot: allow bootmeth-distro without CONFIG_NET

2022-07-28 Thread John Keeping
Remove the dependency on CMD_PXE from BOOTMETH_DISTRO by introducing a new hidden kconfig symbol to control whether pxe_utils is compiled, allowing bootstd's distro method to be compiled without needing networking support enabled. Signed-off-by: John Keeping --- v2: - Fix MENU dependency

[PATCH] boot: allow bootmeth-distro without CONFIG_NET

2022-07-21 Thread John Keeping
Remove the dependency on CMD_PXE from BOOTMETH_DISTRO by introducing a new hidden kconfig symbol to control whether pxe_utils is compiled, allowing bootstd's distro method to be compiled without needing networking support enabled. Signed-off-by: John Keeping --- boot/Kconfig | 7 ++- boot

[PATCH] video: dw_mipi_dsi: fix vsync active vs back porch

2022-07-22 Thread John Keeping
Signed-off-by: John Keeping --- drivers/video/dw_mipi_dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/dw_mipi_dsi.c b/drivers/video/dw_mipi_dsi.c index a5b38acabd..c68dd66fdc 100644 --- a/drivers/video/dw_mipi_dsi.c +++ b/drivers/video/dw_mipi_dsi.c @@ -64

Re: [PATCH/RFC] rockchip: derive GPIO bank from alias if available

2022-07-27 Thread John Keeping
Hi Simon, On Tue, Jul 26, 2022 at 01:53:44PM -0600, Simon Glass wrote: > On Tue, 26 Jul 2022 at 10:25, John Keeping wrote: > > > > Upstream device trees now use standard node names like "gpio@ff..." but > > the rk_gpio driver expects a name like "gpi

Re: [PATCH] image: Ensure image header name is null terminated

2022-08-23 Thread John Keeping
On Tue, Aug 23, 2022 at 03:59:07PM +1000, Joel Stanley wrote: > When building with GCC 12: > > ../include/image.h:779:9: warning: ‘strncpy’ specified bound 32 equals > destination size [-Wstringop-truncation] > 779 | strncpy(image_get_name(hdr), name, IH_NMLEN); > |

Re: [PATCH] drivers: usb: fastboot: Fix full-speed usb descriptor

2022-08-22 Thread John Keeping
; Fastboot device ack both full and high speed interface descriptors when > work in full-speed mode, that's will cause this issue. > > Fix it. > > Signed-off-by: qianfan Zhao Reviewed-by: John Keeping > --- > drivers/usb/gadget/f_fastboot.c | 1 + > 1 file chang

[PATCH] pinctrl: fix buffer size for pinctrl_generic_set_state_prefix()

2022-09-07 Thread John Keeping
This buffer has the concatenated prefix and name written into it, so it must be large enough to cover both strings plus the terminating NUL. Fixes: 92c4a95ec7 ("pinctrl: Add new function pinctrl_generic_set_state_prefix()") Signed-off-by: John Keeping --- drivers/pinctrl/pinctrl-gen

[PATCH v2] video: dw_mipi_dsi: fix [hv]sync active vs back porch

2022-09-07 Thread John Keeping
host controller bridge") Signed-off-by: John Keeping --- v2: - Fix hsync/hbp as well as vsync/vbp drivers/video/dw_mipi_dsi.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/video/dw_mipi_dsi.c b/drivers/video/dw_mipi_dsi.c index a5b38acabd..6d9c5a9

[PATCH] power: regulator: fix autoset error handling

2022-09-08 Thread John Keeping
. It seems that the error handling for regulator_set_suspend_value() is also wrong as if this succeeds then the normal boot-on checks are still required, and again ENOSYS needs special treatment here. Fixes: 11406b8f7e ("dm: regulator: support regulator more state") Signed-off-by: Jo

[PATCH] mmc: dwmmc: only clear handled interrupts

2022-09-15 Thread John Keeping
); if (mask & DWMCI_INTMSK_DTO) { // Unreachable as DTO is cleared without being handled! return 0; } Only clear interrupts that we have seen and are handling so that DTO is not missed. Signed-off-by: John Keeping --- drivers/mmc/dw_mmc.c | 3 ++

[PATCH] phy: rockchip: handle clock without enable function

2022-12-06 Thread John Keeping
If a clock doesn't supply the enable hook, clk_enable() will return -ENOSYS. In this case the clock is always enabled so there is no error and the phy initialisation should continue. Signed-off-by: John Keeping --- drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 2 +- 1 file changed, 1

[PATCH] cmd: fix dependency for CMD_CLS

2022-11-23 Thread John Keeping
It seems this symbol was missed when renaming DM_VIDEO -> VIDEO. Update it. Fixes: b86986c7b3 ("video: Rename CONFIG_DM_VIDEO to CONFIG_VIDEO") Signed-off-by: John Keeping --- cmd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/Kconfig b/cmd/

[PATCH 1/2] rc4: mark key as const

2022-11-18 Thread John Keeping
Key data is never written so the parameter can be const, which allows putting fixed keys in .rodata. Signed-off-by: John Keeping --- include/rc4.h | 2 +- lib/rc4.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/rc4.h b/include/rc4.h index c1ff1349d4

[PATCH 2/2] rockchip: mkimage: make RC4 key const

2022-11-18 Thread John Keeping
This is read-only data, so mark it as such. Signed-off-by: John Keeping --- tools/rkcommon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/rkcommon.c b/tools/rkcommon.c index 0db45c2d41..fab61949e1 100644 --- a/tools/rkcommon.c +++ b/tools/rkcommon.c @@ -154,7 +154,7

[PATCH] power: act8846_pmic: fix number of registers

2023-01-19 Thread John Keeping
The highest register on ACT8846 is 0xf5, so set the number of registers to 0xf6, ensuring that the pmic read/write commands are able to access all of the supported registers (and many that are not valid, since the register space is quite sparse). Signed-off-by: John Keeping --- include/power

[PATCH] MAINTAINERS: add include/power/ to POWER

2023-01-19 Thread John Keeping
Add the related include files to the power MAINTAINERS entry. Signed-off-by: John Keeping --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index b2de50ccfc..282dce67b3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1245,6 +1245,7 @@ M:Jaehoon

Re: [PATCH] rockchip: derive GPIO bank from alias if available

2023-01-18 Thread John Keeping
On Tue, Jan 17, 2023 at 08:52:22PM +0100, Johan Jonker wrote: > > > On 1/17/23 19:15, John Keeping wrote: > > Upstream device trees now use standard node names like "gpio@ff..." but > > the rk_gpio driver expects a name like "gpi

[PATCH] rockchip: derive GPIO bank from alias if available

2023-01-17 Thread John Keeping
dm_gpio_lookup_name() or `gpio` in the boot scripts. Cc: Quentin Schulz Cc: Johan Jonker Signed-off-by: John Keeping --- drivers/gpio/rk_gpio.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/rk_gpio.c b/drivers/gpio/rk_gpio.c index 68f30157a9..8568f10cd0

Re: [PATCH v1] arm: dts: rockchip: sync rk3066/rk3188 DT files from linux-next v6.2-rc4

2023-01-17 Thread John Keeping
Hi Johan, On Tue, Jan 17, 2023 at 03:44:07PM +0100, Johan Jonker wrote: > On 1/17/23 10:46, Quentin Schulz wrote: > > On 1/16/23 20:45, Johan Jonker wrote: > >> Sync rk3066/rk3188 DT files from Linux. > >> This is the state as of linux-next v6.2-rc4. > >> New nfc node for MK808 rk3066a. > >> CRU

[PATCH] mmc: rockchip_dw_mmc: fix DDR52 8-bit mode handling

2023-01-17 Thread John Keeping
. Signed-off-by: John Keeping --- drivers/mmc/rockchip_dw_mmc.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/mmc/rockchip_dw_mmc.c b/drivers/mmc/rockchip_dw_mmc.c index 573bf16c87..3661ce3314 100644 --- a/drivers/mmc/rockchip_dw_mmc.c +++ b/drivers/mmc/rockchip_dw_mmc.c

Re: [PATCH v1] arm: dts: rockchip: sync rk3066/rk3188 DT files from linux-next v6.2-rc4

2023-01-17 Thread John Keeping
Hi Quentin, On Tue, Jan 17, 2023 at 04:58:54PM +0100, Quentin Schulz wrote: > On 1/17/23 16:20, John Keeping wrote: > > Hi Johan, > > > > On Tue, Jan 17, 2023 at 03:44:07PM +0100, Johan Jonker wrote: > > > On 1/17/23 10:46, Quentin Schulz wrote: > > >

Re: [PATCH v8 13/24] rockchip: rk3288: syscon_rk3288: store syscon platdata in regmap

2023-03-14 Thread John Keeping
On Mon, Mar 13, 2023 at 10:09:23PM +0100, Johan Jonker wrote: > On 3/13/23 18:46, John Keeping wrote: > > On Mon, Mar 13, 2023 at 05:53:20PM +0100, Johan Jonker wrote: > >> On 3/13/23 14:26, John Keeping wrote: > >>> On Mon, Mar 13, 2023 at 01:30:57AM +0100, Johan Jon

[PATCH v2 0/2] rockchip: fix efuse/otp misc_read return values

2023-03-20 Thread John Keeping
Fix the return value for misc_read() in the two Rockchip nvmem drivers so that they return the number of bytes read. In v2 the rockchip-efuse patch is change to correctly handle block_size > 1 and the rockchip-otp patch is new. John Keeping (2): rockchip: efuse: fix misc_read() return val

[PATCH v2 1/2] rockchip: efuse: fix misc_read() return values

2023-03-20 Thread John Keeping
operations. Signed-off-by: John Keeping --- v2: - Fix when block_size > 1 by moving the return value to the main rockchip_efuse_read() wrapper and leaving the individual implementations alone (Jonas) drivers/misc/rockchip-efuse.c | 12 1 file changed, 8 insertions(+), 4 deleti

[PATCH v2 2/2] rockchip: otp: fix misc_read() return values

2023-03-20 Thread John Keeping
operations. Signed-off-by: John Keeping --- v2: - New patch drivers/misc/rockchip-otp.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/misc/rockchip-otp.c b/drivers/misc/rockchip-otp.c index c19cd5ce62..4814e0e501 100644 --- a/drivers/misc/rockchip-otp.c

[PATCH] rockchip: efuse: fix misc_read() return values

2023-03-20 Thread John Keeping
operations. Signed-off-by: John Keeping --- drivers/misc/rockchip-efuse.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/misc/rockchip-efuse.c b/drivers/misc/rockchip-efuse.c index 60931a5131..d021a20b1d 100644 --- a/drivers/misc/rockchip

Re: [PATCH v8 13/24] rockchip: rk3288: syscon_rk3288: store syscon platdata in regmap

2023-03-13 Thread John Keeping
On Mon, Mar 13, 2023 at 01:30:57AM +0100, Johan Jonker wrote: > The Rockchip SoC rk3288 has 2 types of device trees floating around. > A 64bit reg size when synced from Linux and a 32bit for U-boot. > A pre-probe function in the syscon class driver assumes only 32bit. > For other odd reg

Re: [PATCH v8 13/24] rockchip: rk3288: syscon_rk3288: store syscon platdata in regmap

2023-03-13 Thread John Keeping
On Mon, Mar 13, 2023 at 05:53:20PM +0100, Johan Jonker wrote: > On 3/13/23 14:26, John Keeping wrote: > > On Mon, Mar 13, 2023 at 01:30:57AM +0100, Johan Jonker wrote: > >> The Rockchip SoC rk3288 has 2 types of device trees floating around. > >> A 64bit reg size when sy

Re: [PATCH v1 1/7] arm: dts: rockchip: rk3288: move io-domains nodes

2023-03-15 Thread John Keeping
in the right direction. Reviewed-by: John Keeping > --- > arch/arm/dts/rk3288-miqi.dtsi| 27 +++-- > arch/arm/dts/rk3288-phycore-som.dtsi | 30 +--- > arch/arm/dts/rk3288-popmetal.dtsi| 30 +--- > arch

[PATCH] rockchip: rk3288: Use ft_system_setup instead of ft_board_setup

2023-02-23 Thread John Keeping
ft_board_setup() should be availble for use in board files but using it in the rk3288 machine file blocks this functionality. ft_system_setup() is the more appropriate function to use in a machine definition. Signed-off-by: John Keeping --- arch/arm/mach-rockchip/Kconfig | 2 +- arch

[PATCH] rockchip: efuse: fix rk3399 reading multiple values

2023-04-17 Thread John Keeping
Update rk3399 to match the pattern in the other device-specific implementations to ensure the previous address is cleared when reading multiple blocks. Signed-off-by: John Keeping --- drivers/misc/rockchip-efuse.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

Re: [PATCH] rockchip: efuse: fix rk3399 reading multiple values

2023-04-17 Thread John Keeping
On Mon, Apr 17, 2023 at 05:39:24PM +, Jonas Karlman wrote: > On 2023-04-17 18:09, John Keeping wrote: > > Update rk3399 to match the pattern in the other device-specific > > implementations to ensure the previous address is cleared when reading > > multiple blocks. >

Re: [PATCH] rockchip: efuse: fix rk3399 reading multiple values

2023-04-20 Thread John Keeping
On Mon, Apr 17, 2023 at 06:58:30PM +0100, John Keeping wrote: > On Mon, Apr 17, 2023 at 05:39:24PM +, Jonas Karlman wrote: > > On 2023-04-17 18:09, John Keeping wrote: > > > Update rk3399 to match the pattern in the other device-specific > > > implementations to

Re: rockpi-e sometimes fails to load u-boot.img

2023-04-27 Thread John Keeping
On Wed, Apr 26, 2023 at 11:35:19AM +0200, Belisko Marek wrote: > I'm using 2022.01 u-boot. Booting from SDcard sometimes shows up this log: > U-Boot SPL 2022.01 (Jan 10 2022 - 18:46:34 +) > Trying to boot from MMC2 > Card did not respond to voltage select! : -110 > spl: mmc init failed with

[PATCH v3 1/3] rockchip: misc: fix misc_read() return check

2023-03-27 Thread John Keeping
on negative values. Suggested-by: Jonas Karlman Signed-off-by: John Keeping --- v3: new patch arch/arm/mach-rockchip/misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-rockchip/misc.c b/arch/arm/mach-rockchip/misc.c index 849014d2fb..7d03f0c2b6 100644 --- a/arch

[PATCH v3 0/3] rockchip: fix efuse/otp misc_read return values

2023-03-27 Thread John Keeping
. John Keeping (3): rockchip: misc: fix misc_read() return check rockchip: efuse: fix misc_read() return values rockchip: otp: fix misc_read() return values arch/arm/mach-rockchip/misc.c | 2 +- drivers/misc/rockchip-efuse.c | 12 drivers/misc/rockchip-otp.c | 12 3

[PATCH v3 3/3] rockchip: otp: fix misc_read() return values

2023-03-27 Thread John Keeping
operations. Reviewed-by: Simon Glass Reviewed-by: Jonas Karlman Signed-off-by: John Keeping --- v3: unchanged v2: new patch drivers/misc/rockchip-otp.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/misc/rockchip-otp.c b/drivers/misc/rockchip-otp.c index

[PATCH v3 2/3] rockchip: efuse: fix misc_read() return values

2023-03-27 Thread John Keeping
operations. Reviewed-by: Simon Glass Reviewed-by: Jonas Karlman Signed-off-by: John Keeping --- v3: unchanged v2: - Fix when block_size > 1 by moving the return value to the main rockchip_efuse_read() wrapper and leaving the individual implementations alone (Jonas) drivers/misc/rockc

[PATCH] tools: env: update lock path in README

2023-04-12 Thread John Keeping
Commit aeb40f1166 ("tools: env: use /run to store lockfile") updated the path to the lockfile but did not update the documentation to match. Use the new path in the documentation. Fixes: aeb40f1166 ("tools: env: use /run to store lockfile") Signed-off-by: John Keeping ---

[PATCH 2/2] rockchip: handle peripheral as well as otg dr_mode

2023-04-12 Thread John Keeping
ctly and the device controller needs to be programmed to override this. Signed-off-by: John Keeping --- arch/arm/mach-rockchip/board.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-rockchip/board.c b/arch/arm/mach-rockchip/board.c index 6d33d65780..45d9eae870 100644 --- a/

[PATCH 1/2] rockchip: use standard dr_mode parsing function

2023-04-12 Thread John Keeping
Instead of duplicating the string values here, use usb_get_dr_mode() to handle the property lookup and converting the values to an enum. This is implemented with a switch in preparation for the next patch which adds extra handling for peripheral mode. Signed-off-by: John Keeping --- arch/arm

[PATCH] core: read: fix dev_read_addr_size()

2023-06-01 Thread John Keeping
passes "reg" and this is the expected property name matching the other similarly named functions. Signed-off-by: John Keeping --- drivers/core/read.c| 5 ++--- drivers/reset/reset-rockchip.c | 2 +- include/dm/read.h | 12 +++- 3 files changed, 6 inserti

[PATCH] video: tweak CONFIG_SPL_VIDEO description

2023-05-09 Thread John Keeping
Make it clear that this is the SPL option to avoid potential confusion when the description for CONFIG_SPL_VIDEO is the same as that for CONFIG_VIDEO. Signed-off-by: John Keeping --- drivers/video/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/Kconfig

[PATCH] spl: fix TPL_SYS_MALLOC_F description

2023-11-14 Thread John Keeping
This config option enables the malloc() pool in TPL not the SPL. Fix the description to accurately reflect this. Fixes: fd8497dae54 (spl: Create proper symbols for enabling the malloc() pool) Signed-off-by: John Keeping --- Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff