Re: [PATCH 0/5] DFU: new entity types and minor improvements

2020-12-20 Thread Marek Szyprowski
Hi Jaehoon, On 20.12.2020 23:17, Jaehoon Chung wrote: > On 12/17/20 9:10 PM, Marek Szyprowski wrote: >> This patchset adds support for SKIP and SCRIPT entity types to the DFU >> subsystem. They significantly extends the flexibility of the DFU >> subsystem. Together with the

Re: [PATCH 4/6] button: add a simple ADC-based button driver

2020-12-21 Thread Marek Szyprowski
Hi Simon, On 19.12.2020 03:28, Simon Glass wrote: > On Mon, 14 Dec 2020 at 04:25, Marek Szyprowski > wrote: >> Add a simple ADC-based button driver. This driver binds to the 'adc-keys' >> device tree node. >> >> Signe

[PATCH v4 1/3] dt-bindings: input: adc-keys bindings documentation

2020-12-22 Thread Marek Szyprowski
Dump adc-keys bindings documentation from Linux kernel source tree v5.10. Signed-off-by: Marek Szyprowski --- doc/device-tree-bindings/input/adc-keys.txt | 49 + 1 file changed, 49 insertions(+) create mode 100644 doc/device-tree-bindings/input/adc-keys.txt diff --git a

[PATCH v4 0/3] VIM3: add support for checking 'Function' button state

2020-12-22 Thread Marek Szyprowski
button-adc drivers. Once applied, one can use following commands in the boot scripts: -->8--- echo Checking Func button state: \\c if button Function then echo Selected alternative boot ... fi --->8--- Best regards Marek Szyprowski Samsung R&D Institute Poland Changelog: v4:

[PATCH v4 2/3] button: add a simple Analog to Digital Converter device based button driver

2020-12-22 Thread Marek Szyprowski
Add a simple Analog to Digital Converter device based button driver. This driver binds to the 'adc-keys' device tree node. Signed-off-by: Marek Szyprowski --- drivers/button/Kconfig | 8 +++ drivers/button/Makefile | 1 + drivers/button/button-a

[PATCH v4 3/3] configs: khadas-vim3(l): enable Function button support

2020-12-22 Thread Marek Szyprowski
Add options required to check the 'Function' button state. Signed-off-by: Marek Szyprowski --- configs/khadas-vim3_defconfig | 2 ++ configs/khadas-vim3l_defconfig | 2 ++ 2 files changed, 4 insertions(+) diff --git a/configs/khadas-vim3_defconfig b/configs/khadas-vim3_defco

[PATCH v2 0/5] DFU: new entity types and minor improvements

2020-12-22 Thread Marek Szyprowski
allows to create the whole partition table during the board flashing. It also easies the flashing by allowing to use the same images for different board variants/types, as each board can now use only the relevant images and skip the other ones without returning a failure. Best regards Marek Szyprows

[PATCH v2 2/5] dfu: add 'SKIP' entity

2020-12-22 Thread Marek Szyprowski
ct to "dfu: add 'SKIP' entity"] Signed-off-by: Marek Szyprowski --- Original version of this patch is available here: https://patchwork.ozlabs.org/project/uboot/patch/20201109115757.24601-1-jh80.ch...@samsung.com/ --- doc/README.dfu| 15 ++- drivers/dfu/

[PATCH v2 5/5] thor: add support for the dfu_alt_info reintialization from the flashed script

2020-12-22 Thread Marek Szyprowski
Reinitialize dfu_env_entities after flashing the 'SCRIPT' entity to ensure that the potential changes to the 'dfu_alt_info' environment variable are applied. Signed-off-by: Marek Szyprowski --- cmd/thordown.c | 19 --- drivers/usb/gadget/f_thor

[PATCH v2 4/5] dfu: add support for the dfu_alt_info reintialization from the flashed script

2020-12-22 Thread Marek Szyprowski
Reinitialize DFU USB gadget after flashing the 'SCRIPT' entity to ensure that the potential changes to the 'dfu_alt_info' environment variable are applied. Signed-off-by: Marek Szyprowski --- cmd/dfu.c| 14 +- common/dfu.c | 3 +++ 2 files changed, 16 inser

[PATCH v2 3/5] dfu: add 'SCRIPT' entity

2020-12-22 Thread Marek Szyprowski
ed script, so add a global variable for tracking the potential need to reinitialize the dfu_alt_info related structures. Signed-off-by: Marek Szyprowski --- doc/README.dfu| 17 - drivers/dfu/dfu.c | 7 ++- drivers/dfu/dfu_mmc.c | 23 +-- incl

[PATCH v2 1/5] dfu: mmc: use the default MMC device if entity specifies it as -1

2020-12-22 Thread Marek Szyprowski
Use the default MMC device set in the command line if entity specifies it as -1. This allows to use the same dfu_alt_info string for different MMC devices (like embedded eMMC and external SD card if data layout is the same on both devices). Signed-off-by: Marek Szyprowski --- drivers/dfu

[PATCH v2 2/6] disk: dos: add some defines for the hardcoded numbers

2020-12-22 Thread Marek Szyprowski
Add some handy defines for some hardcoded magic numbers related to extended partition handling. Signed-off-by: Marek Szyprowski --- disk/part_dos.c | 6 +++--- disk/part_dos.h | 3 +++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/disk/part_dos.c b/disk/part_dos.c index

[PATCH v2 1/6] disk: dos: rename write_mbr_partition to write_mbr_sector

2020-12-22 Thread Marek Szyprowski
write_mbr_partition() function name is a bit misleading, so rename it to write_mbr_sector(). This is a preparation for adding code for writing a complete MBR partition layout. Signed-off-by: Marek Szyprowski --- disk/part_dos.c | 2 +- drivers/fastboot/fb_mmc.c | 2 +- include/part.h

[PATCH v2 4/6] disk: dos: make some functions static

2020-12-22 Thread Marek Szyprowski
Make functions not used outside this file static. Signed-off-by: Marek Szyprowski --- disk/part_dos.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/disk/part_dos.c b/disk/part_dos.c index 3b79b9b1b8..2c4ad0b6ba 100644 --- a/disk/part_dos.c +++ b/disk/part_dos.c

[PATCH v2 5/6] disk: dos: add code for creating MBR partition layout

2020-12-22 Thread Marek Szyprowski
Add a code for creating and writing MBR partition layout. The code generates similar layout of EBRs (Exteneded Block Records) and logical volumes as Linux's fdisk utility. Signed-off-by: Marek Szyprowski --- disk/part_dos.c | 167 disk/part_

[PATCH v2 3/6] disk: dos: use generic macro for unaligned le32 access

2020-12-22 Thread Marek Szyprowski
Use a generic helper for reading LE32 integers. Signed-off-by: Marek Szyprowski --- disk/part_dos.c | 28 +--- 1 file changed, 9 insertions(+), 19 deletions(-) diff --git a/disk/part_dos.c b/disk/part_dos.c index 20d35dc9cd..3b79b9b1b8 100644 --- a/disk/part_dos.c +++ b

[PATCH v2 6/6] cmd: Add MBR partition layout control utility

2020-12-22 Thread Marek Szyprowski
me'), some of the predefined sizes: > setenv mbr_parts 'name=boot,start=4M,size=128M,bootable,id=0x0e; name=rootfs,size=3072M,id=0x83; name=system-data,size=512M,id=0x83; name=[ext],size=-,id=0x05; name=user,size=-,id=0x83; name=modules,size=100M,id=0x83; name=ramdisk

[PATCH v2 0/6] Add MBR partition table creation and verify command

2020-12-22 Thread Marek Szyprowski
27;gpt' command already present in u-boot. Best regards Marek Szyprowski Samsung R&D Institute Poland Changelog: v2: - added docs and minor fixes in the code style v1: https://lists.denx.de/pipermail/u-boot/2020-December/435208.html - initial version Patch summary: Marek Szyprowski

[PATCH v3 3/6] disk: dos: use generic macro for unaligned le32 access

2020-12-23 Thread Marek Szyprowski
Use a generic helper for reading LE32 integers. Signed-off-by: Marek Szyprowski --- disk/part_dos.c | 28 +--- 1 file changed, 9 insertions(+), 19 deletions(-) diff --git a/disk/part_dos.c b/disk/part_dos.c index 20d35dc9cd..3b79b9b1b8 100644 --- a/disk/part_dos.c +++ b

[PATCH v3 1/6] disk: dos: rename write_mbr_partition to write_mbr_sector

2020-12-23 Thread Marek Szyprowski
write_mbr_partition() function name is a bit misleading, so rename it to write_mbr_sector(). This is a preparation for adding code for writing a complete MBR partition layout. Signed-off-by: Marek Szyprowski --- disk/part_dos.c | 2 +- drivers/fastboot/fb_mmc.c | 2 +- include/part.h

[PATCH v3 2/6] disk: dos: add some defines for the hardcoded numbers

2020-12-23 Thread Marek Szyprowski
Add some handy defines for some hardcoded magic numbers related to extended partition handling. Signed-off-by: Marek Szyprowski --- disk/part_dos.c | 6 +++--- disk/part_dos.h | 3 +++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/disk/part_dos.c b/disk/part_dos.c index

[PATCH v3 5/6] disk: dos: add code for creating MBR partition layout

2020-12-23 Thread Marek Szyprowski
Add a code for creating and writing MBR partition layout. The code generates similar layout of EBRs (Exteneded Block Records) and logical volumes as Linux's fdisk utility. Signed-off-by: Marek Szyprowski --- disk/part_dos.c | 167 disk/part_

[PATCH v3 6/6] cmd: Add MBR partition layout control utility

2020-12-23 Thread Marek Szyprowski
me'), some of the predefined sizes: > setenv mbr_parts 'name=boot,start=4M,size=128M,bootable,id=0x0e; name=rootfs,size=3072M,id=0x83; name=system-data,size=512M,id=0x83; name=[ext],size=-,id=0x05; name=user,size=-,id=0x83; name=modules,size=100M,id=0x83; name=ramdisk

[PATCH v3 4/6] disk: dos: make some functions static

2020-12-23 Thread Marek Szyprowski
Make functions not used outside this file static. Signed-off-by: Marek Szyprowski --- disk/part_dos.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/disk/part_dos.c b/disk/part_dos.c index 3b79b9b1b8..2c4ad0b6ba 100644 --- a/disk/part_dos.c +++ b/disk/part_dos.c

[PATCH v3 0/6] Add MBR partition table creation and verify command

2020-12-23 Thread Marek Szyprowski
27;gpt' command already present in u-boot. Best regards Marek Szyprowski Samsung R&D Institute Poland Changelog: v3: - fixed minor issues in the docs v2: https://lists.denx.de/pipermail/u-boot/2020-December/435689.html - added docs and minor fixes in the code style v1: https://lists.

Re: [PATCH] board: amlogic: vim3: fix setup ethernet mac from efuse

2021-01-12 Thread Marek Szyprowski
2X:%02X:%02X:%02X:%02X:%02X\n", > + mac_addr[0],mac_addr[1],mac_addr[2], > + mac_addr[3],mac_addr[4],mac_addr[5]); I'm not really convinced that this message has to be displayed. If so, then use "%pM" for printing MAC address. > } > > return 0; > } > + Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

Re: [PATCH 2/2] usb: xhci: Load Raspberry Pi 4 VL805's firmware

2020-04-28 Thread Marek Szyprowski
ci_hccr **ret_hccr, > struct xhci_hcor *hcor; > u32 cmd; > > +#ifdef CONFIG_BCM2711 > + bcm2711_load_vl805_firmware(); > +#endif > + > hccr = (struct xhci_hccr *)dm_pci_map_bar(dev, > PCI_BASE_ADDRESS_0, PCI_REGION_MEM); > hcor = (struct xhci_hcor *)((uintptr_t) hccr + Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

Re: [Patch V4 3/3] configs: rpi_4 : enable SDHCI_SDMA config

2020-04-29 Thread Marek Szyprowski
eck for such case might be a good idea. Later one can even add a fallback with temporary malloc buffer (or PIO mode if switching on fly is possible) and memcpy for the transfers above the first GiB if there is such need. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

[PATCH] configs: rpi_arm64: sync env size with rpi_{3,4}_defconfig

2020-05-05 Thread Marek Szyprowski
Use the same environment size as the configs dedicated for rpi3 and rpi4. This allows to switch between the builds and not to loose the settings stored on the SD card. Signed-off-by: Marek Szyprowski --- configs/rpi_arm64_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs

Re: [PATCH v2 10/10] config: Enable support for the XHCI controller on RPI4 board

2020-05-05 Thread Marek Szyprowski
Hi On 05.05.2020 13:15, Bin Meng wrote: > On Mon, May 4, 2020 at 8:45 PM Sylwester Nawrocki > wrote: >> From: Marek Szyprowski >> >> This requires enabling BRCMSTB PCIe and XHCI_PCI drivers as well as PCI >> and USB commands. To get it working one has to call t

Re: [PATCH v2 05/10] rpi4: add a mapping for the PCIe XHCI controller MMIO registers (ARM 64bit)

2020-05-05 Thread Marek Szyprowski
Hi Matthias, On 05.05.2020 16:00, Matthias Brugger wrote: > On 04/05/2020 14:45, Sylwester Nawrocki wrote: >> From: Marek Szyprowski >> >> Create a non-cacheable mapping for the 0x6 physical memory region, >> where MMIO registers for the PCIe XHCI control

Re: [PATCH v2 06/10] rpi4: add a mapping for the PCIe XHCI controller MMIO registers (ARM 32bit)

2020-05-05 Thread Marek Szyprowski
Hi Matthias, On 05.05.2020 16:25, Matthias Brugger wrote: > On 04/05/2020 14:45, Sylwester Nawrocki wrote: >> From: Marek Szyprowski >> >> Create a non-cacheable mapping for the 0x6 physical memory region, >> where MMIO registers for the PCIe XHCI control

Re: [PATCH v2 06/10] rpi4: add a mapping for the PCIe XHCI controller MMIO registers (ARM 32bit)

2020-05-12 Thread Marek Szyprowski
Hi Matthias, On 08.05.2020 23:26, Matthias Brugger wrote: > Adding Tom as he is the arm maintainer. > > On 04/05/2020 14:45, Sylwester Nawrocki wrote: >> From: Marek Szyprowski >> >> Create a non-cacheable mapping for the 0x6 physical memory region, >>

[RFC PATCH 2/2] rpi4: add a mapping for the PCIe XHCI controller MMIO registers (ARM 32bit)

2020-05-12 Thread Marek Szyprowski
-off-by: Marek Szyprowski --- arch/arm/mach-bcm283x/Kconfig | 1 + arch/arm/mach-bcm283x/include/mach/base.h | 6 ++ arch/arm/mach-bcm283x/init.c | 14 ++ include/configs/rpi.h | 5 + 4 files changed, 26 insertions(+) diff --git a

[RFC PATCH 1/2] arm: provide a function for boards init code to modify MMU virtual-physical map

2020-05-12 Thread Marek Szyprowski
Provide a function for setting arbitrary virtual-physical MMU mapping for the given region. Signed-off-by: Marek Szyprowski --- arch/arm/include/asm/mmu.h| 8 arch/arm/include/asm/system.h | 18 -- arch/arm/lib/cache-cp15.c | 18 -- 3 files

[RFC PATCH 0/2] ARM: arbitrary virtual-physical mappings for RPi4 XHCI support

2020-05-12 Thread Marek Szyprowski
Hi All, This is a result of the following discussion: https://lists.denx.de/pipermail/u-boot/2020-May/411086.html Those 2 patches are replacement for the patch discussed there. Best regards Marek Szyprowski Samsung R&D Institute Poland Marek Szyprowski (2): arm: provide a function

[RFC PATCH v2 0/2] ARM: arbitrary virtual-physical mappings for RPi4 XHCI support

2020-05-15 Thread Marek Szyprowski
Hi All, This is a result of the following discussion: https://lists.denx.de/pipermail/u-boot/2020-May/411086.html Those 2 patches are replacement for the patch discussed there. V2 fixes ARM64 build. Best regards Marek Szyprowski Samsung R&D Institute Poland Marek Szyprowski (2):

[RFC PATCH v2 1/2] arm: provide a function for boards init code to modify MMU virtual-physical map

2020-05-15 Thread Marek Szyprowski
Provide a function for setting arbitrary virtual-physical MMU mapping for the given region. Signed-off-by: Marek Szyprowski --- arch/arm/include/asm/mmu.h| 8 arch/arm/include/asm/system.h | 11 +++ arch/arm/lib/cache-cp15.c | 24 ++-- 3 files

[RFC PATCH v2 2/2] rpi4: add a mapping for the PCIe XHCI controller MMIO registers (ARM 32bit)

2020-05-15 Thread Marek Szyprowski
-off-by: Marek Szyprowski --- arch/arm/mach-bcm283x/Kconfig | 1 + arch/arm/mach-bcm283x/include/mach/base.h | 6 ++ arch/arm/mach-bcm283x/init.c | 14 ++ include/configs/rpi.h | 5 + 4 files changed, 26 insertions(+) diff --git a

[PATCH] net: ping: reset stored IP once the command finishes

2020-03-25 Thread Marek Szyprowski
Reset stored ping IP address before leaving the netloop to ensure that the subsequent calls to the netloop, especially for the other protocols, won't be interrupted by the received ICMP_ECHO_REPLY packet. Signed-off-by: Marek Szyprowski --- net/ping.c | 5 - 1 file changed, 4 inser

[PATCH] ARM: bcm283x: change the virtual address of the XHCI PCI device base

2021-06-17 Thread Marek Szyprowski
licts with the updated ARM/VideoCore firmware. This also requires to reduce the size of the mapped PCI device region from 8MiB to 4MiB to fit into 32bit address space. This is still enough for the XHCI PCI device. Signed-off-by: Marek Szyprowski --- This fixes the issue observed on ARM 32bit

Re: u-boot on RPi4 32bit - issue after upgrading the firmware

2021-06-17 Thread Marek Szyprowski
Hi On 04.03.2021 02:33, Jaehoon Chung wrote: > On 2/25/21 8:11 PM, Marek Szyprowski wrote: >> On 25.02.2021 11:55, Nicolas Saenz Julienne wrote: >>> On Thu, 2021-02-25 at 11:43 +0100, Marek Szyprowski wrote: >>>> Recently I've upgraded a video core firmware on m

[PATCH] cmd: misc: Fix return value for the sleep command

2021-01-22 Thread Marek Szyprowski
If sleeping has been interrupted, return CMD_RET_FAILURE instead of -1 (CMD_RET_USAGE). Signed-off-by: Marek Szyprowski --- cmd/sleep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/sleep.c b/cmd/sleep.c index f0c78a8efb..1fff400c79 100644 --- a/cmd/sleep.c +++ b/cmd

Re: [PATCH v4 0/3] VIM3: add support for checking 'Function' button state

2021-01-22 Thread Marek Szyprowski
Hi Neil, On 18.01.2021 13:55, Neil Armstrong wrote: > On 18/01/2021 13:48, Heinrich Schuchardt wrote: >> On 18.01.21 11:24, Neil Armstrong wrote: >>> On 22/12/2020 09:56, Marek Szyprowski wrote: >>>> Hi All, >>>> >>>> This patchset adds

[PATCH v5 0/4] VIM3: add support for checking 'Function' button state

2021-01-26 Thread Marek Szyprowski
button-adc drivers. Once applied, one can use following commands in the boot scripts: -->8--- echo Checking Func button state: \\c if button Function then echo Selected alternative boot ... fi --->8--- Best regards Marek Szyprowski Samsung R&D Institute Poland Changelog: v5: -

[PATCH v5 1/4] dt-bindings: input: adc-keys bindings documentation

2021-01-26 Thread Marek Szyprowski
Dump adc-keys bindings documentation from Linux kernel source tree from commit 698dc0cf9447 ("dt-bindings: input: adc-keys: clarify description"). Signed-off-by: Marek Szyprowski --- doc/device-tree-bindings/input/adc-keys.txt | 67 + 1 file changed, 67 insertions(

[PATCH v5 4/4] configs: khadas-vim3(l): enable Function button support

2021-01-26 Thread Marek Szyprowski
Add options required to check the 'Function' button state. Signed-off-by: Marek Szyprowski --- configs/khadas-vim3_defconfig | 2 ++ configs/khadas-vim3l_defconfig | 2 ++ 2 files changed, 4 insertions(+) diff --git a/configs/khadas-vim3_defconfig b/configs/khadas-vim3_defco

[PATCH v5 3/4] adc: meson-saradc: add support for getting reference voltage value

2021-01-26 Thread Marek Szyprowski
Add support for getting the 'vref-supply' regulator and register it as ADC's reference voltage regulator, so clients can translate sampled ADC values to the voltage. Signed-off-by: Marek Szyprowski --- drivers/adc/meson-saradc.c | 21 + 1 file changed, 21 inse

[PATCH v5 2/4] button: add a simple Analog to Digital Converter device based button driver

2021-01-26 Thread Marek Szyprowski
Add a simple Analog to Digital Converter device based button driver. This driver binds to the 'adc-keys' device tree node. Signed-off-by: Marek Szyprowski --- drivers/button/Kconfig | 8 ++ drivers/button/Makefile | 1 + drivers/button/button-a

Re: [PATCH v5 2/4] button: add a simple Analog to Digital Converter device based button driver

2021-01-26 Thread Marek Szyprowski
Hi Heinrich, On 26.01.2021 12:10, Heinrich Schuchardt wrote: > On 1/26/21 10:50 AM, Marek Szyprowski wrote: >> Add a simple Analog to Digital Converter device based button driver. >> This >> driver binds to the 'adc-keys' device tree node. >&g

Re: [PATCH v2] disk: part_dos: update partition table entries after write

2021-01-28 Thread Marek Szyprowski
Hi, On 28.01.2021 09:10, Gary Bisson wrote: > Fixes issues when switching from GPT to MBR partition tables. > > Signed-off-by: Gary Bisson Acked-by: Marek Szyprowski > --- > Changes for v2: > - added part_init() inside write_mbr_partitions(), as suggested by >He

[PATCH] rpi: limit size of the RAM to the multiple of the MMU_SECTION_SIZE

2021-02-01 Thread Marek Szyprowski
, because it relocated itself into that unmapped memory and fails to execute. Fix this by limiting the size of the first bank to the multiple of MMU_SECTION_SIZE. Signed-off-by: Marek Szyprowski --- board/raspberrypi/rpi/rpi.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/board/raspberrypi

[PATCH] board: amlogic: odroid: add runtime detection of the N2/N2+/C4/HC4 variants

2021-02-04 Thread Marek Szyprowski
, adjusted to the 12-bit ADC driver operation mode (vendor code use 10-bit mode). Signed-off-by: Marek Szyprowski --- The relevant vendor's code is here: https://github.com/hardkernel/u-boot/blob/odroidg12-v2015.01/board/hardkernel/odroid-common/board.c#L55 --- arch/arm/dts/meson-g12b-odroid

Re: [PATCH v5 2/4] button: add a simple Analog to Digital Converter device based button driver

2021-02-04 Thread Marek Szyprowski
Hi Simon, On 01.02.2021 21:38, Simon Glass wrote: > On Tue, 26 Jan 2021 at 06:03, Heinrich Schuchardt wrote: >> On 26.01.21 12:25, Marek Szyprowski wrote: >>> On 26.01.2021 12:10, Heinrich Schuchardt wrote: >>>> On 1/26/21 10:50 AM, Marek Szyprowski wrote: >&g

Re: [PATCH v5 2/4] button: add a simple Analog to Digital Converter device based button driver

2021-02-08 Thread Marek Szyprowski
Hi Simon, On 06.02.2021 17:21, Simon Glass wrote: > On Thu, 4 Feb 2021 at 03:36, Marek Szyprowski > wrote: >> ... >> Could you give me a bit more hints or point where to start? I've tried >> to build sandbox, but it fails for v2021.01 release (I've did make &g

Re: [PATCH v5 2/4] button: add a simple Analog to Digital Converter device based button driver

2021-02-09 Thread Marek Szyprowski
Hi Simon, On 08.02.2021 18:08, Simon Glass wrote: > On Mon, 8 Feb 2021 at 09:10, Marek Szyprowski > wrote: >> On 06.02.2021 17:21, Simon Glass wrote: >>> On Thu, 4 Feb 2021 at 03:36, Marek Szyprowski >>> wrote: >>>> ... >>>> Could you

[PATCH v6 3/5] adc: meson-saradc: add support for getting reference voltage value

2021-02-11 Thread Marek Szyprowski
Add support for getting the 'vref-supply' regulator and register it as ADC's reference voltage regulator, so clients can translate sampled ADC values to the voltage. Signed-off-by: Marek Szyprowski Reviewed-by: Simon Glass --- drivers/adc/meson-saradc.c | 21 ++

[PATCH v6 1/5] dt-bindings: input: adc-keys bindings documentation

2021-02-11 Thread Marek Szyprowski
Dump adc-keys bindings documentation from Linux kernel source tree from commit 698dc0cf9447 ("dt-bindings: input: adc-keys: clarify description"). Signed-off-by: Marek Szyprowski Reviewed-by: Simon Glass --- doc/device-tree-bindings/input/adc-keys.txt | 67 + 1 fi

[PATCH v6 0/5] VIM3: add support for checking 'Function' button state

2021-02-11 Thread Marek Szyprowski
dc drivers. Once applied, one can use following commands in the boot scripts: -->8--- echo Checking Func button state: \\c if button Function then echo Selected alternative boot ... fi --->8--- Best regards Marek Szyprowski Samsung R&D Institute Poland Changelog:

[PATCH v6 4/5] configs: khadas-vim3(l): enable Function button support

2021-02-11 Thread Marek Szyprowski
Add options required to check the 'Function' button state. Signed-off-by: Marek Szyprowski Reviewed-by: Simon Glass --- configs/khadas-vim3_defconfig | 2 ++ configs/khadas-vim3l_defconfig | 2 ++ 2 files changed, 4 insertions(+) diff --git a/configs/khadas-vim3_defconfig b/conf

[PATCH v6 5/5] test: add a simple test for the adc-keys button driver

2021-02-11 Thread Marek Szyprowski
Add adc-keys device to the sandbox/test.dts and connect it to the channel #3 of the sandbox_adc driver. The default values sampled by sandbox_adc driver determines that button3 and button4 are released and button5 is pressed. Signed-off-by: Marek Szyprowski --- arch/sandbox/dts/test.dts | 24

[PATCH v6 2/5] button: add a simple Analog to Digital Converter device based button driver

2021-02-11 Thread Marek Szyprowski
Add a simple Analog to Digital Converter device based button driver. This driver binds to the 'adc-keys' device tree node. Signed-off-by: Marek Szyprowski --- drivers/button/Kconfig | 8 ++ drivers/button/Makefile | 1 + drivers/button/button-a

[PATCH v7 5/5] test: add a simple test for the adc-keys button driver

2021-02-18 Thread Marek Szyprowski
Add adc-keys device to the sandbox/test.dts and connect it to the channel #3 of the sandbox_adc driver. The default values sampled by sandbox_adc driver determines that button3 and button4 are released and button5 is pressed. Signed-off-by: Marek Szyprowski Reviewed-by: Simon Glass --- arch

[PATCH v7 4/5] configs: khadas-vim3(l): enable Function button support

2021-02-18 Thread Marek Szyprowski
Add options required to check the 'Function' button state. Signed-off-by: Marek Szyprowski Reviewed-by: Simon Glass --- configs/khadas-vim3_defconfig | 2 ++ configs/khadas-vim3l_defconfig | 2 ++ 2 files changed, 4 insertions(+) diff --git a/configs/khadas-vim3_defconfig b/conf

[PATCH v7 2/5] button: add a simple Analog to Digital Converter device based button driver

2021-02-18 Thread Marek Szyprowski
Add a simple Analog to Digital Converter device based button driver. This driver binds to the 'adc-keys' device tree node. Signed-off-by: Marek Szyprowski Reviewed-by: Simon Glass --- drivers/button/Kconfig | 8 ++ drivers/button/Makefile | 1 + drivers/button/button-a

[PATCH v7 3/5] adc: meson-saradc: add support for getting reference voltage value

2021-02-18 Thread Marek Szyprowski
Add support for getting the 'vref-supply' regulator and register it as ADC's reference voltage regulator, so clients can translate sampled ADC values to the voltage. Signed-off-by: Marek Szyprowski Reviewed-by: Simon Glass --- drivers/adc/meson-saradc.c | 21 ++

[PATCH v7 0/5] VIM3: add support for checking 'Function' button state

2021-02-18 Thread Marek Szyprowski
dc drivers. Once applied, one can use following commands in the boot scripts: -->8--- echo Checking Func button state: \\c if button Function then echo Selected alternative boot ... fi --->8--- Best regards Marek Szyprowski Samsung R&D Institute Poland Changelog: v7

[PATCH v7 1/5] dt-bindings: input: adc-keys bindings documentation

2021-02-18 Thread Marek Szyprowski
Dump adc-keys bindings documentation from Linux kernel source tree from commit 698dc0cf9447 ("dt-bindings: input: adc-keys: clarify description"). Signed-off-by: Marek Szyprowski Reviewed-by: Simon Glass --- doc/device-tree-bindings/input/adc-keys.txt | 67 + 1 fi

Re: [PATCH] button: adc: fix treshold typo

2021-02-23 Thread Marek Szyprowski
On 23.02.2021 16:10, Neil Armstrong wrote: > Fix the treshold typo in code by threshold. > > Fixes: c0165c85c3 ("button: add a simple Analog to Digital Converter device > based button driver") > Suggested-by: Tom Rini > Signed-off-by: Neil Armstrong Acked-by: Marek S

u-boot on RPi4 32bit - issue after upgrading the firmware

2021-02-25 Thread Marek Szyprowski
the firmware change in the mentioned commit is related to the ARM 32bit mode. Does anyone have an idea how to fix this issue? I've checked also the latest version of the RPi firmware, but the issue is still there. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

Re: u-boot on RPi4 32bit - issue after upgrading the firmware

2021-02-25 Thread Marek Szyprowski
Hi Nicolas, On 25.02.2021 11:55, Nicolas Saenz Julienne wrote: > On Thu, 2021-02-25 at 11:43 +0100, Marek Szyprowski wrote: >> Recently I've upgraded a video core firmware on my RPi4 and I've noticed >> that u-boot in ARM 32bit mode stopped working properly or even

Re: [PATCH v5 0/6] ARM: arbitrary virtual-physical mappings for RPi4 XHCI support

2020-07-08 Thread Marek Szyprowski
27;t boot. As soon as the series is > ready I'll take all the RPi4 PCI/USB related patches into the next branch. I've noticed that You took both required patchsets to rpi-next branch. May I ask for taking this one too? Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

Re: [U-Boot] [PATCH v2 6/6] config: enable DFU over USB on Raspberry Pi4 boards

2019-11-12 Thread Marek Szyprowski
Hi Matthias, On 08.11.2019 17:57, Matthias Brugger wrote: > First of all thanks for the patch and sorry for the late response. > > On 24/09/2019 15:11, Marek Szyprowski wrote: >> Enable support for DFU over USB. This requires to enable USB gadget, >> DWC2 UDC OTG driver

[U-Boot] [PATCH v3 6/6] config: enable DFU over USB on Raspberry Pi4 boards

2019-11-15 Thread Marek Szyprowski
Enable support for DFU over USB. This requires to enable USB gadget, DWC2 UDC OTG driver and DFU command. DFU entities are defined for the following firmware objects: u-boot.bin, uboot.env, config.txt and zImage/Image. Signed-off-by: Marek Szyprowski Reviewed-by: Lukasz Majewski --- Changelog

Re: [RFC PATCH 4/9] rpi4: add a mapping for the PCIe XHCI controller MMIO registers (ARM 64bit)

2020-04-22 Thread Marek Szyprowski
Hi Nicolas, On 22.04.2020 11:46, Nicolas Saenz Julienne wrote: > On Tue, 2020-04-21 at 18:50 +0200, Sylwester Nawrocki wrote: >> From: Marek Szyprowski >> >> Create a non-cacheable mapping for the 0x6 physical memory region, >> where MMIO registers for t

Re: [PATCH] fs: ext4: skip journal state if fs has metadata_csum

2020-04-22 Thread Marek Szyprowski
l require e2fsck to be > run manually to boot. > > By bypassing the journal state check, this patch ensures the superblock > won't be corrupted if the filesystem has metadata_csum feature enabled. > > Signed-off-by: Arnaud Ferraris Acked-by: Marek Szyprowski > --- >

Re: [PATCH v1 09/10] pci: Add driver for Broadcom STB PCIe controller

2020-04-27 Thread Marek Szyprowski
ome extra context xhci_malloc() gets its memory from memalign(). And it's > not clear to me how that function decides which memory to use. I think that memalign() allocates memory from the uboot's defined SDRAM (from its end). Assuming that CONFIG_SYS_SDRAM_SIZE is set to 128M in include/configs/rpi.h it should be always safe, but I will check that tomorrow to be 100% sure. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

Re: [PATCH v1 09/10] pci: Add driver for Broadcom STB PCIe controller

2020-04-28 Thread Marek Szyprowski
Hi All, On 27.04.2020 15:54, Marek Szyprowski wrote: > On 27.04.2020 12:15, Nicolas Saenz Julienne wrote: >> On Fri, 2020-04-24 at 18:50 +0200, Sylwester Nawrocki wrote: >>> This patch adds basic driver for the Broadcom STB PCIe host controller. >>> The code is bas

Re: [PATCH] net: ping: reset stored IP once the command finishes

2020-06-15 Thread Marek Szyprowski
Hi Tom, On 12.06.2020 18:04, Tom Rini wrote: > On Wed, Mar 25, 2020 at 02:42:00PM +0100, Marek Szyprowski wrote: >> Reset stored ping IP address before leaving the netloop to ensure that >> the subsequent calls to the netloop, especially for the other protocols, >> won&#x

[PATCH v2] net: ping: reset stored IP address

2020-06-15 Thread Marek Szyprowski
Reset the stored ping IP address before entering a netloop with different protocol to ensure that it won't be interrupted by the received correct ICMP_ECHO_REPLY packet. Signed-off-by: Marek Szyprowski --- v2: - Moved the net_ping_ip reset to the beginning of the net_loop() if the protoc

Re: [PATCH v5 3/6] arm: provide a function for boards init code to modify MMU virtual-physical map

2020-08-03 Thread Marek Szyprowski
Hi Patrick, On 23.07.2020 18:32, Patrick DELAUNAY wrote: > Hi Marek, > >> From: U-Boot On Behalf Of Tom Rini >> Sent: vendredi 10 juillet 2020 22:22 >> >> On Wed, Jun 03, 2020 at 02:43:42PM +0200, Marek Szyprowski wrote: >> >>> Provide function for s

Re: [PATCH v2] arm: exynos: Read default MMC device from XOM[7:5] pins

2020-01-22 Thread Marek Szyprowski
Hi Minkyu, On 23.01.2020 08:09, Minkyu Kang wrote: > On 17/01/2020 22:02, Marek Szyprowski wrote: >> XOM pins provide information for iROM bootloader about the boot device. >> Those pins are mapped to lower bits of OP_MODE register (0x1008), >> which is common for all Exy

Re: [PATCH v2] arm: exynos: Read default MMC device from XOM[7:5] pins

2020-01-22 Thread Marek Szyprowski
Hi On 23.01.2020 08:33, Minkyu Kang wrote: > On 23/01/2020 16:20, Marek Szyprowski wrote: >> On 23.01.2020 08:09, Minkyu Kang wrote: >>> On 17/01/2020 22:02, Marek Szyprowski wrote: >>>> XOM pins provide information for iROM bootloader about the boot device. >&

[PATCH] arm: exynos: Use proper ADC device name

2020-01-14 Thread Marek Szyprowski
Since commit 4213609cc7 ("drivers: core: use strcmp when find device by name") one has to provide full name to get requested object. Fix the code used to detect Odroid board revision to use proper ADC device name then. Signed-off-by: Marek Szyprowski --- board/samsung/common/exynos5-

[PATCH] arm: exynos: Read default MMC device from XOM[7:5] pins

2020-01-15 Thread Marek Szyprowski
eMMC). Signed-off-by: Marek Szyprowski --- arch/arm/mach-exynos/include/mach/cpu.h | 1 + board/samsung/common/board.c| 14 ++ 2 files changed, 15 insertions(+) diff --git a/arch/arm/mach-exynos/include/mach/cpu.h b/arch/arm/mach-exynos/include/mach/cpu.h index

[PATCH] arm: exynos: Use proper PMIC device name

2020-01-15 Thread Marek Szyprowski
Since commit 4213609cc7 ("drivers: core: use strcmp when find device by name") one has to provide full name to get requested object. Fix the code used to detect enable power regulators on Odroid boards to use proper PMIC device device name then. Signed-off-by: Marek Szyprowski --- boa

[PATCH] arm: dts: exynos: Extend board description

2020-01-15 Thread Marek Szyprowski
u-boot uses the same DTS for the all Odroid XU3-based boards, so list them in the model description to let user know that those boards are supported. Signed-off-by: Marek Szyprowski --- arch/arm/dts/exynos5422-odroidxu3.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH v2] arm: exynos: Use proper PMIC device name

2020-01-15 Thread Marek Szyprowski
Since commit 4213609cc7 ("drivers: core: use strcmp when find device by name") one has to provide full name to get requested object. Fix the code used to detect enable power regulators on Odroid boards to use proper PMIC device device name then. Signed-off-by: Marek Szyprowski Reviewed

[PATCH v3] arm: exynos: Use proper PMIC device names

2020-01-16 Thread Marek Szyprowski
Since commit 4213609cc7 ("drivers: core: use strcmp when find device by name") one has to provide full name to get requested object. Fix the code used to detect enable power regulators on the supported Exynos boards to use proper PMIC device device name then. Signed-off-by: Marek

[PATCH 1/3] mmc: s5p_sdhci: Read generic MMC properties from DT

2020-01-16 Thread Marek Szyprowski
Read generic MMC properties from device-tree. This allows to specify for example cd-inverted property and let MMC core to properly handle such case. Signed-off-by: Marek Szyprowski --- drivers/mmc/s5p_sdhci.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/mmc/s5p_sdhci.c b

[PATCH 3/3] arm: dts: exynos: Use common alias for Odroid U3/X2 MMC2 (SD-card)

2020-01-16 Thread Marek Szyprowski
Use MMC0 for eMMC and MMC2 for SD-card as other Exynos-based boards do. This allows to use common code to get MMC device id based on the XOM[7:5] pins. Signed-off-by: Marek Szyprowski --- arch/arm/dts/exynos4412-odroid.dts | 2 +- include/configs/odroid.h | 2 +- 2 files changed, 2

[PATCH 0/3] Fix Odroid U3/X2 SD-card boot

2020-01-16 Thread Marek Szyprowski
Hi All This patchset restores booting from SD-card on Exynos4412-based Odroid U3/X2 boards. It relies on the Exynos MMC device id auto-dectection and PMIC device name fixes: https://patchwork.ozlabs.org/patch/1223558/ https://patchwork.ozlabs.org/patch/1224228/ Best regards Marek Szyprowski

[PATCH 2/3] arm: dts: exynos: Fix card-detect polarity for SD card on Odroid U3/X2

2020-01-16 Thread Marek Szyprowski
Card detect line for SD-card on Odroid U3/X2 boards are active low, so add cd-inverted property to indicate this, as u-boot's GPIO driver doesn't support specifying line polarity. This restores S5P_SDHCI driver operation on Odroid U3/X2 boards. Signed-off-by: Marek Szyprowski --- ar

[PATCH v2] arm: exynos: Read default MMC device from XOM[7:5] pins

2020-01-17 Thread Marek Szyprowski
eMMC). Signed-off-by: Marek Szyprowski --- v2: - store mmc boot device to ${mmcbootdev} env - print information about boot mmc device --- arch/arm/mach-exynos/include/mach/cpu.h | 1 + board/samsung/common/board.c| 28 + configs/odroid-xu3_defconfig

[PATCH] arm: exynos: odroid: Change autoboot script to use ${mmcbootdev}

2020-01-17 Thread Marek Szyprowski
This fixes the default boot command for the SD-card boot case. Signed-off-by: Marek Szyprowski --- This is the continuation of the fixes from this patchset: https://patchwork.ozlabs.org/cover/1224290/ --- include/configs/odroid.h | 8 1 file changed, 4 insertions(+), 4 deletions

Re: [PATCH 0/3] Fix Odroid U3/X2 SD-card boot

2020-01-17 Thread Marek Szyprowski
Hi Anand On 17.01.2020 06:00, Anand Moon wrote: > On Thu, 16 Jan 2020 at 20:56, Marek Szyprowski > wrote: >> This patchset restores booting from SD-card on Exynos4412-based Odroid >> U3/X2 boards. It relies on the Exynos MMC device id auto-dectection and >> PMIC dev

Re: [RFC 1/4] mmc: bcm2835_sdhci: use phys2bus macro when dma address is accessed

2020-01-20 Thread Marek Szyprowski
A_ADDRESS); In such case no if statement is the needed and phys_to_bus() is safe for non-rpi users (it is identity in such case). # git grep SDHCI_DMA_ADDRESS shows 2 places where writel to SDHCI_DMA_ADDRESS is being done. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

Re: [PATCH 00/18] fs: fat: fix long name support

2020-12-08 Thread Marek Szyprowski
me of those FAT issues over a year ago, but I never had enough time to start fixing it. Thanks for doing it! Feel free to add: Acked-by: Marek Szyprowski > The following problems need to be addressed in further patches: > > * When extending a file only available FAT entries af

[PATCH 3/6] adc: meson-saradc: skip hardware init only if ADC is enabled

2020-12-14 Thread Marek Szyprowski
The driver skips hardware initialization if it is already configured by the earlier bootloader stage (BL30). Skip the initialization only if the hardware is really initialized and enabled. Signed-off-by: Marek Szyprowski Change-Id: I3e2e2d270ad3e7e7f38e2bc3ce2a924a47b164af --- drivers/adc/meson

  1   2   3   >