[U-Boot] [PATCH] fat: reset VFAT short alias checksum on first match

2012-01-02 Thread Sergei Shtylyov
The VFAT short alias checksum read from a long file name is only overwritten when another long file name appears in a directory list. Until then it renders short file names invisible that have the same checksum. Reset the checksum on first match. Signed-off-by: Sergei Shtylyov sshtyl

Re: [U-Boot] [RFC/PATCH] common/command.c: Guard strchr/strlen from NULL pointer

2010-11-24 Thread Sergei Shtylyov
Hello. On 24-11-2010 13:15, Thomas Weber wrote: Guard strchr/strlen from being called with NULL pointer. This line is crashing on OMAP3/Devkit8000 when command env is called without subcommand. Toolchain is Codesourcery 2010q1. The cmd is NULL in this case because the calling function

Re: [U-Boot] [PATCH 03/24] e1000: fix compile warning

2010-11-28 Thread Sergei Shtylyov
Hello. On 25-11-2010 19:00, Wolfgang Denk wrote: Get rid of compiler warning: e1000.c: In function 'e1000_transmit': e1000.c:5028: warning: passing argument 1 of 'virt_to_phys' discards qualifiers from pointer target type Signed-off-by: Wolfgang Denkw...@denx.de [...] diff --git

Re: [U-Boot] [PATCH v2] microblaze: Disabling interrupt should return 1 if was enabled

2010-12-21 Thread Sergei Shtylyov
Hello. On 21-12-2010 16:02, Michal Simek wrote: Microblaze implement enable/disable interrupts through MSR that's why disable_interrupts function should return 1 when interrupt was enabled. Return 0 when interrupt was disabled. Signed-off-by: John Linnjohn.l...@xilinx.com Signed-off-by:

Re: [U-Boot] [PATCH v2 1/9] mpc8xxx: Display RDIMM if detected

2010-12-21 Thread Sergei Shtylyov
Hello. On 19-12-2010 1:21, Wolfgang Denk wrote: Print a message when a RDIMM is detected. ... +} else printf(ERROR: Mix of registered buffered and unbuffered DIMMs detected!\n); -} Mutli-line statement needs braces. Well, not only

Re: [U-Boot] [PATCH 1/3] lib/asm-offsets.c: Clean coding style

2010-12-22 Thread Sergei Shtylyov
Hello. On 21-12-2010 21:12, Michal Simek wrote: Clear coding style issues. Signed-off-by: Michal Simekmon...@monstr.eu [...] diff --git a/lib/asm-offsets.c b/lib/asm-offsets.c index 2209561..f1af7e2 100644 --- a/lib/asm-offsets.c +++ b/lib/asm-offsets.c @@ -19,11 +19,11 @@

Re: [U-Boot] [PATCH] Correct chip detect logic

2010-12-27 Thread Sergei Shtylyov
Hello. On 26-12-2010 5:41, Yanjun Yang wrote: The lan91c96_detect_chip routine is not correct according to the manual. Signed-off-by: YanJun Yangyangyj...@gmail.com [...] diff --git a/drivers/net/lan91c96.c b/drivers/net/lan91c96.c index bd6966e..2550aa2 100644 ---

Re: [U-Boot] [PATCH] nios2: add gpio_is_valid

2010-12-27 Thread Sergei Shtylyov
Hello. On 27-12-2010 5:46, Thomas Chou wrote: Signed-off-by: Thomas Choutho...@wytron.com.tw [...] diff --git a/arch/nios2/include/asm/gpio.h b/arch/nios2/include/asm/gpio.h index 36a7132..4b21c8f 100644 --- a/arch/nios2/include/asm/gpio.h +++ b/arch/nios2/include/asm/gpio.h @@ -52,6

Re: [U-Boot] [PATCH 15/28] Blackfin: fix bd_t handling

2010-12-27 Thread Sergei Shtylyov
Hello. On 27-12-2010 7:48, Mike Frysinger wrote: The recent global data changes (making the size autogenerated) broke the board info handling on Blackfin ports as we were lying and lumping the bd_t size in with the gd_t size. So use the new dedicated bd_t size to setup its own address in

Re: [U-Boot] [PATCH V2] mpc83xx: fix pcie configuration space read/write

2011-01-09 Thread Sergei Shtylyov
Hello. On 07-01-2011 15:42, Baidu Boy wrote: This patch fix a problem for the pcie enumeration when the mpc83xx pcie controller is connected with switch or we use both of the two pcie controller. Signed-off-by: Baidu Boyliucai@gmail.com --- Changes for v2: - Avoid line wrap in

Re: [U-Boot] [PATCH] mpc83xx: fix pcie configuration space read/write

2011-01-09 Thread Sergei Shtylyov
Hello. On 07-01-2011 15:29, Baidu Boy wrote: This patch fix a problem for the pcie enumeration when the mpc83xx pcie controller is connected with switch or we use both of the two pcie controller. Signed-off-by: Baidu Boyliucai@gmail.com --- arch/powerpc/cpu/mpc83xx/pcie.c |8

Re: [U-Boot] [PATCH 5/7] powerpc/86xx: Enable common SRIO init code

2011-01-09 Thread Sergei Shtylyov
Hello. On 06-01-2011 19:58, Kumar Gala wrote: Add the needed defines and code to utilize the common 8xxx srio init code to setup LAWs and modify device tree if we have SRIO enabled on a board. Signed-off-by: Kumar Galaga...@kernel.crashing.org --- arch/powerpc/cpu/mpc86xx/fdt.c|

Re: [U-Boot] [V2 patch 4/4] SMDK6400: Fix SMDK6400 SDRAM init

2011-01-12 Thread Sergei Shtylyov
Hello. On 11-01-2011 17:52, seedshope wrote: Since SDRAM init function have already change, So the SDRAM initial function must be change. Signed-off-by: seedshopebocui...@gmail.com diff --git a/board/samsung/smdk6400/smdk6400.c b/board/samsung/smdk6400/smdk6400.c index 35aa40b..52b44a8

Re: [U-Boot] [PATCH 15/28] Blackfin: fix bd_t handling

2011-01-12 Thread Sergei Shtylyov
On 11.01.2011 3:31, Mike Frysinger wrote: it isnt a problem to have the parens, and it keeps things sane if someone does something like: #define CONFIG_SYS_BD_INFO_ADDR SOME_DEFINE + 0x1000 This would be a violation of basic rules of defensive coding. Please drop these parens. i dont

Re: [U-Boot] [V2 patch 4/4] SMDK6400: Fix SMDK6400 SDRAM init

2011-01-13 Thread Sergei Shtylyov
Hello. On 12-01-2011 17:52, seedshope wrote: Since SDRAM init function have already change, So the SDRAM initial function must be change. Signed-off-by: seedshopebocui...@gmail.com diff --git a/board/samsung/smdk6400/smdk6400.c b/board/samsung/smdk6400/smdk6400.c index 35aa40b..52b44a8

Re: [U-Boot] USB storage performance EHCI question

2011-01-13 Thread Sergei Shtylyov
Hello. On 13-01-2011 9:09, Wolfgang Denk wrote: Hm... I just notice the caviumnetworks in your address, so this is probably MIPS? Check if your caches are turned on... BTW, Cavium also produces ARMs (like CNS3xxx)... Best regards, Wolfgang Denk WBR, Sergei

Re: [U-Boot] [PATCH v3] nios2: add gpio support

2010-04-17 Thread Sergei Shtylyov
Hello. Thomas Chou wrote: This patch adds driver for a trivial gpio core, which is described in http://nioswiki.com/GPIO. When CONFIG_SYS_GPIO_BASE is not defined, board may provide its own driver. Signed-off-by: Thomas Chou tho...@wytron.com.tw --- arch dir reorganized.

Re: [U-Boot] [PATCH 1/3] Support for devices with FAT32 PBR

2010-05-10 Thread Sergei Shtylyov
Hello. Igor Luri wrote: Signed-off-by: Igor Luri il...@aotek.es --- disk/part_dos.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/disk/part_dos.c b/disk/part_dos.c index 887b75e..d91f773 100644 --- a/disk/part_dos.c +++ b/disk/part_dos.c @@ -77,7 +77,8 @@

Re: [U-Boot] [PATCH v3] Support for devices with FAT32 PBR

2010-05-10 Thread Sergei Shtylyov
Hello. Igor Luri wrote: Signed-off-by: Igor Luri il...@aotek.es --- disk/part_dos.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/disk/part_dos.c b/disk/part_dos.c index 887b75e..d91f773 100644 --- a/disk/part_dos.c +++ b/disk/part_dos.c @@ -77,7 +77,8 @@

Re: [U-Boot] [PATCH 1/2] fsl/85xx: add clkdvdr to global utilities structure definition

2010-05-20 Thread Sergei Shtylyov
Hello. Timur Tabi wrote: Add the 'clkdvdr' to the 85xx definition of struct ccsr_gur. You're also adding 'pmuxcr2'... Signed-off-by: Timur Tabi ti...@freescale.com --- arch/powerpc/include/asm/immap_85xx.h |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff

[U-Boot] [PATCH] USB: fix create_pipe()

2010-05-26 Thread Sergei Shtylyov
create_pipe() can give wrong result if an expression is passed as the 'endpoint' argument -- due to missing parentheses. Thanks to Martin Mueller for finding the bug and providing the patch. Signed-off-by: Sergei Shtylyov sshtyl...@ru.mvista.com --- include/usb.h |2 +- 1 file changed, 1

Re: [U-Boot] [PATCH 5/5] DockStar: LED support

2010-09-08 Thread Sergei Shtylyov
Hello. On 07-09-2010 18:28, Eric Cooper wrote: derived from patches posted by Jeff Doozan in the uBoot forum at http://forum.doozan.com Signed-off-by: Eric Coopere...@cmu.edu [...] diff --git a/board/Marvell/dockstar/dockstar.c b/board/Marvell/dockstar/dockstar.c index 13cd347..7788837

Re: [U-Boot] [PATCH 1/2] mmc: add boundary check for mmc operation

2010-09-13 Thread Sergei Shtylyov
Hello. On 13-09-2010 8:06, Lei Wen wrote: Signed-off-by: Lei Wenlei...@marvell.com --- drivers/mmc/mmc.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c index cf4ea16..5ff1c54 100644 --- a/drivers/mmc/mmc.c +++

Re: [U-Boot] [PATCH 2/2] mmc: print out avaible partition table

2010-09-13 Thread Sergei Shtylyov
Hello. On 13-09-2010 8:06, Lei Wen wrote: Signed-off-by: Lei Wenlei...@marvell.com --- common/cmd_mmc.c | 20 disk/part.c |3 +++ 2 files changed, 23 insertions(+), 0 deletions(-) diff --git a/common/cmd_mmc.c b/common/cmd_mmc.c index c0b30d8..fe04f8d

Re: [U-Boot] [PATCH 1/2 V2] mmc: add boundary check for mmc operation

2010-09-13 Thread Sergei Shtylyov
Hello. Lei Wen wrote: Change log: change the puts to printf to better formating. This change log should have followed the --- tear-line. Signed-off-by: Lei Wen lei...@marvell.com --- WBR, Sergei ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [PATCH 2/2 V2] mmc: print out avaible partition table

2010-09-13 Thread Sergei Shtylyov
Hello. Lei Wen wrote: Signed-off-by: Lei Wen lei...@marvell.com [...] diff --git a/common/cmd_mmc.c b/common/cmd_mmc.c index c0b30d8..437dd88 100644 --- a/common/cmd_mmc.c +++ b/common/cmd_mmc.c [...] @@ -230,5 +249,6 @@ U_BOOT_CMD( read device num addr blk# cnt\n mmc write

Re: [U-Boot] [PATCH 2/2] [NEXT] edminiv2: enable relocation

2010-09-22 Thread Sergei Shtylyov
Hello. On 21-09-2010 23:35, Albert Aribaud wrote: Signed-off-by: Albert Aribaudalbert.arib...@free.fr [...] diff --git a/board/LaCie/edminiv2/config.mk b/board/LaCie/edminiv2/config.mk index 3dec1aa..b4845ad 100644 --- a/board/LaCie/edminiv2/config.mk +++ b/board/LaCie/edminiv2/config.mk

Re: [U-Boot] [PATCH 13/17] post/i2c: Add ability to ignore I2C devices

2010-09-30 Thread Sergei Shtylyov
Hello. On 29-09-2010 23:05, Peter Tyser wrote: Add the ability to not report an I2C POST error for a set of given I2C addresses on bootup. This is useful for the following cases: - Some form factors such as XMC and Compact PCI Express have an I2C EEPROM whose address changes based on

Re: [U-Boot] [PATCH 13/17] post/i2c: Add ability to ignore I2C devices

2010-09-30 Thread Sergei Shtylyov
Hello. Peter Tyser wrote: +#ifdef I2C_ADDR_IGNORE_LIST + unsigned char i2c_ignore_list[] = I2C_ADDR_IGNORE_LIST; This array is aking to be *static*... ... and *const* as well ? I'll add 'const' in the next version, but I'm not sure if the 'static' adds any benefit since its a local

Re: [U-Boot] [PATCH 13/17] post/i2c: Add ability to ignore I2C devices

2010-09-30 Thread Sergei Shtylyov
Hello. Peter Tyser wrote: +#ifdef I2C_ADDR_IGNORE_LIST +unsigned char i2c_ignore_list[] = I2C_ADDR_IGNORE_LIST; This array is aking to be *static*... ... and *const* as well ? I'll add 'const' in the next version, but I'm not sure if the 'static' adds any benefit since its a

Re: [U-Boot] [PATCH 2/4] OneNAND: Fixup command table on reloc

2010-10-03 Thread Sergei Shtylyov
Hello. On 02-10-2010 21:33, Marek Vasut wrote: Signed-off-by: Marek Vasut marek.va...@gmail.com [...] diff --git a/common/cmd_onenand.c b/common/cmd_onenand.c index 83d967b..fe84c3b 100644 --- a/common/cmd_onenand.c +++ b/common/cmd_onenand.c @@ -525,6 +525,12 @@ static cmd_tbl_t

Re: [U-Boot] [PATCH 03/19] x86: zboot update

2010-10-04 Thread Sergei Shtylyov
Hello. On 04-10-2010 7:37, Graeme Russ wrote: The header of recent Linux Kernels includes the size of the image, and therefore is not needed to be passed to zboot. Still process the third parameter (size of image) in the event that an older kernel is being loaded Signed-off-by: Graeme

Re: [U-Boot] [PATCH 10/19] x86: Move ECC initialisation outside RAM initialisation

2010-10-04 Thread Sergei Shtylyov
Hello. On 04-10-2010 7:37, Graeme Russ wrote: To allow for 'load anywhere' images, the %ebp return pointer 'hack' must be removed, so we cannot have two 'calls' to get_mem_size Signed-off-by: Graeme Russgraeme.r...@gmail.com [...] diff --git a/arch/i386/cpu/start.S b/arch/i386/cpu/start.S

Re: [U-Boot] [PATCH] env: fix cmd_env_sub fct pointers if CONFIG_RELOC_FIXUP_WORKS is not defined

2010-10-05 Thread Sergei Shtylyov
Hello. On 05-10-2010 9:41, Heiko Schocher wrote: commit ea882baf9c17cd142c99e3ff640d3ab01daa5cec introduces a command_sub_table for the env command. On arm, avr32, m68k, mips and sparc architectures, relocation needs manual fixups, so add these fixups for this sub command table too. Tested

Re: [U-Boot] [PATCH 2/4] sf: spansion: fixing erasing when sector size 64KiB

2010-10-06 Thread Sergei Shtylyov
Hello. On 06-10-2010 11:37, Mike Frysinger wrote: From: Marc-André Héberthebert.marcan...@gmail.com The spansion_erase currently only works when the sector size is 64KB. cmd[1] should contain the higher 8 bit of the 24 bit address of the sector to be erased. Currently it is holding the

Re: [U-Boot] [PATCH] Crash in env_relocate_spec() of env_mmc.c

2010-10-08 Thread Sergei Shtylyov
Hello. On 08-10-2010 12:03, Stefano Babic wrote: mmc_initialize is not called at the startup if the relocation takes place and the environment is stored into a MMC card. Signed-off-by: Stefano Babicsba...@denx.de [...] diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c index

Re: [U-Boot] env_mmc: Fix crashing bug encountered after enabling ARM relocation

2010-10-10 Thread Sergei Shtylyov
Hello. On 09-10-2010 1:49, Steve Sakoman wrote: The crash was occuring in env_relocate because it was being called prior to mmc_initialize. This patch moves the MMC initialization earlier in the init process. This patch also cleans up the env_relocate_spec code in env_mmc.c Developed

Re: [U-Boot] env_mmc: Fix crashing bug encountered after enabling ARM relocation

2010-10-10 Thread Sergei Shtylyov
Hello. On 10-10-2010 17:42, Steve Sakoman wrote: The crash was occuring in env_relocate because it was being called prior to mmc_initialize. This patch moves the MMC initialization earlier in the init process. This patch also cleans up the env_relocate_spec code in env_mmc.c Developed

Re: [U-Boot] env_mmc: Fix crashing bug encountered after enabling ARM relocation

2010-10-10 Thread Sergei Shtylyov
On 10-10-2010 19:47, Steve Sakoman wrote: The crash was occuring in env_relocate because it was being called prior to mmc_initialize. This patch moves the MMC initialization earlier in the init process. This patch also cleans up the env_relocate_spec code in env_mmc.c Developed jointly

Re: [U-Boot] [PATCH] net: Fix emaclite driver to support little-endian microblaze

2010-10-14 Thread Sergei Shtylyov
Hello. On 10/11/10 05:41, Michal Simek wrote: Support New emaclite AXI IP. Signed-off-by: Michal Simekmon...@monstr.eu CC: Ben Warrenbiggerbadder...@gmail.com [...] diff --git a/drivers/net/xilinx_emaclite.c b/drivers/net/xilinx_emaclite.c index 455ce0c..76af939 100644 ---

Re: [U-Boot] [PATCH] imx25: Fix reset

2010-10-16 Thread Sergei Shtylyov
Hello. On 12-10-2010 15:49, Matthias Weisser wrote: This patch fixes the reset command on imx25 Signed-off-by: Matthias Weisserweiss...@arcor.de [...] diff --git a/arch/arm/cpu/arm926ejs/mx25/reset.c b/arch/arm/cpu/arm926ejs/mx25/reset.c index 1e33150..a5fd170 100644 ---

Re: [U-Boot] [PATCH 2/2] Blackfin: workaround anomaly 05000440

2010-10-17 Thread Sergei Shtylyov
Hello. On 15-10-2010 04:23, Mike Frysinger wrote: We cannot rely on the syscontrol rom func to program PLL_DIV with anomaly 05000440 is in effect, so manually program the MMR when necessary. Signed-off-by: Mike Frysingervap...@gentoo.org [...] diff --git a/arch/blackfin/cpu/initcode.c

[U-Boot] [PATCH] EHCI: zero out QH transfer overlay in ehci_submit_async()

2010-06-25 Thread Sergei Shtylyov
of the arguments to the memset() call in ehci_alloc(), so the allocated TDs weren't cleared either. While at it, stop needlessly initializing the next pointers in the QH transfer overlay... Signed-off-by: Sergei Shtylyov sshtyl...@mvista.com --- This is quite serious error, so would be good to have

Re: [U-Boot] [PATCH] EHCI: zero out QH transfer overlay in ehci_submit_async()

2010-06-28 Thread Sergei Shtylyov
Hello. Remy Bohmer wrote: 2010/6/25 Sergei Shtylyov sshtyl...@ru.mvista.com: ehci_submit_async() doesn't really zero out the QH transfer overlay (as the EHCI specification suggests) which leads to the controller seeing the 'token' field as the previous call has left it, i.e

[U-Boot] [PATCH v2] EHCI: zero out QH transfer overlay in ehci_submit_async()

2010-06-28 Thread Sergei Shtylyov
of the arguments to the memset() call in ehci_alloc(), so the allocated TDs weren't cleared either. While at it, stop needlessly initializing the alternate next TD pointer in the QH transfer overlay... Signed-off-by: Sergei Shtylyov sshtyl...@ru.mvista.com --- Initialization of 'qh-qh_overlay.qt_next

Re: [U-Boot] [PATCH] Fix condition where bootm_size not set and wrong memory size reported

2010-07-08 Thread Sergei Shtylyov
Hello. Matthew McClintock wrote: If the user sets bootm_low and does not set bootm_size, u-boot will report the memory node in the flat device tree incorrectly. Instead of reporting the remaining size of memory, it will report the total available memory which is incorrect. Specifically

Re: [U-Boot] [PATCH] fdt: Add function to alloc phandle values

2010-07-10 Thread Sergei Shtylyov
Hello. Kumar Gala wrote: If we are creating reference (handles) to nodes in a device tree we need to first create a new phandle in node and this needs a new phandle value. So we search through the whole dtb to find the max phandle value and return the next greater value for a new phandle

Re: [U-Boot] [PATCH] board/purple/flash.c: removed unneded variable

2010-08-01 Thread Sergei Shtylyov
Hello. Frans Meulenbroeks wrote: removed a variable that was not used Signed-off-by: Frans Meulenbroeks fransmeulenbro...@gmail.com [...] diff --git a/board/purple/flash.c b/board/purple/flash.c index 37c7bec..5cee35e 100644 --- a/board/purple/flash.c +++ b/board/purple/flash.c [...]

Re: [U-Boot] [PATCH] disk/part.c: 'usb storage' avoiding overflow when output capacity

2010-08-08 Thread Sergei Shtylyov
Hello. Sergei Trofimovich wrote: Before: Marvell usb storage Device 0: Vendor: StoreJet Rev: Prod: Transcend Type: Hard Disk Capacity: 28759.9 MB = 28.0 GB (488397168 x 512) After: Marvell usb storage Device 0: Vendor: StoreJet Rev:

Re: [U-Boot] [PATCH] usb: musb: set target address for non-multipoint devices

2010-08-09 Thread Sergei Shtylyov
Mike Frysinger wrote: From: Bryan Wu bryan...@analog.com Signed-off-by: Bryan Wu bryan...@analog.com Signed-off-by: Cliff Cai cliff@analog.com Signed-off-by: Mike Frysinger vap...@gentoo.org --- drivers/usb/musb/musb_hcd.c |7 +++ 1 files changed, 7 insertions(+), 0

Re: [U-Boot] [PATCH] usb: musb: only write CLRDATATOG when appropriate

2010-08-10 Thread Sergei Shtylyov
Hello. Mike Frysinger wrote: From: Bryan Wu bryan...@analog.com This is a change similar to what is already in the Linux driver. We should only program the CLRDATATOG bit when the current mode indicates that it is needed. Signed-off-by: Bryan Wu bryan...@analog.com Signed-off-by: Cliff

Re: [U-Boot] [PATCH] Fixing spi erase for S25FL128P_256K

2010-08-10 Thread Sergei Shtylyov
Hello. Marc-André Hébert wrote: The spansion_erase currently only works when the sector size is 64KB. cmd[1] should contain the higher 8 bit of the 24 bit address of the sector to be erased. Currently it is holding the sector index to be erased which happens to be the same thing when the

Re: [U-Boot] [PATCH] USB-CDC: correct wrong alignment in ether.c

2010-08-12 Thread Sergei Shtylyov
Hello. Stefano Babic wrote: The buffer for the status request must be word aligned because it is accessed with 32 bit pointer in the eth_status_complete function. You don't tell anything here about why the size of the array becomes 16x with your patch... Signed-off-by: Stefano Babic

Re: [U-Boot] [PATCH] USB-CDC: add missing variable in ether.c

2010-08-12 Thread Sergei Shtylyov
Hello. Stefano Babic wrote: qmult was not defined if OTG dualspeed is set. Signed-off-by: Stefano Babic sba...@denx.de --- drivers/usb/gadget/ether.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c index

Re: [U-Boot] [PATCH 3/8] USB-CDC: Linux-like debug printout

2010-08-12 Thread Sergei Shtylyov
Hello. Vitaly Kuzmichev wrote: Take debug printout macros back from linux-2.6.27 and make them more useful and more compatible. Signed-off-by: Vitaly Kuzmichev vkuzmic...@mvista.com --- drivers/usb/gadget/ether.c | 65 +++- 1 files changed, 34

Re: [U-Boot] [PATCH] USB-CDC: wrong ep status used

2010-08-12 Thread Sergei Shtylyov
Hello. Stefano Babic wrote: On 08/12/2010 01:41 AM, Stefano Babic wrote: #if defined(DEV_CONFIG_CDC) if (dev-status_ep) { - dev-stat_req = usb_ep_alloc_request(gadget-ep0, GFP_KERNEL); - dev-stat_req-buf = status_req; + dev-stat_req =

Re: [U-Boot] [PATCH 7/8] USB: gadget: ethernet error path potential oops fix

2010-08-12 Thread Sergei Shtylyov
Hello. Vitaly Kuzmichev wrote: From: David Brownell davi...@pacbell.net Fix potential (never-observed) oops on rare error path, bugzilla #9594. Fix uses the same test as used earlier. I think references to bugzilla.kernel.org bugs look out of place in the U-Boot patch's changelog.

Re: [U-Boot] [PATCH] usb: musb: only write CLRDATATOG when appropriate

2010-08-13 Thread Sergei Shtylyov
Hello. Remy Bohmer wrote: Mike Frysinger wrote: --- a/drivers/usb/musb/musb_hcd.c +++ b/drivers/usb/musb/musb_hcd.c } else { - if (!toggle) - writew(MUSB_RXCSR_CLRDATATOG, musbr-rxcsr); - else { + if (!toggle) { +

Re: [U-Boot] [PATCH 3/8] USB-CDC: Linux-like debug printout

2010-08-13 Thread Sergei Shtylyov
Hello. Vitaly Kuzmichev wrote: -printf (enable %s -- %d\n, +DEBUG(dev, enable %s -- %d\n, Well, I think the coding style shouldbe consistent -- you either leave the space before ( or remove it. And as U-Boot seems to follow the Linux coding style now, it seems

Re: [U-Boot] [PATCH v2 3/8] USB-CDC: Use native debug printout macros

2010-08-13 Thread Sergei Shtylyov
Hello. Vitaly Kuzmichev wrote: Rogan Dawes wrote: +#define DEBUG +#undef DEBUG + Eh? Such thing is used to let someone know that this driver supports debug output through native U-Boot macros. So one need to comment #undef to compile ether.c with debug messages. There are at least 67

Re: [U-Boot] [PATCH] Add mvsata support for the Sheevaplug devices

2010-08-14 Thread Sergei Shtylyov
Hello. GEAK wrote: Add mvsata support to SHEEVAPLUG Signed-off-by: Gérald Kerma gera...@gmail.com --- include/configs/sheevaplug.h | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/include/configs/sheevaplug.h

Re: [U-Boot] [PATCH V2 1/2] USB-CDC: correct wrong alignment in ether.c

2010-08-14 Thread Sergei Shtylyov
Hello. Stefano Babic wrote: The buffer for the status request must be word aligned because it is accessed with 32 bit pointer in the eth_status_complete function. Signed-off-by: Stefano Babic sba...@denx.de [...] diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c index

Re: [U-Boot] [PATCH V2 2/2] USB-CDC: called handle_interrupts inside usb_eth_send

2010-08-14 Thread Sergei Shtylyov
Stefano Babic wrote: The patch removes an endless loop in the usb_eth_send if the tx_complete is not called before going in the loop. The driver interrupt routine is called allowing the driver to check if the TX is completed. Signed-off-by: Stefano Babic sba...@denx.de --- [...] diff

Re: [U-Boot] [PATCH] MX51: add structure to access System Reset Controller

2010-08-20 Thread Sergei Shtylyov
Hello. Stefano Babic wrote: Signed-off-by: Stefano Babic sba...@denx.de [...] diff --git a/arch/arm/include/asm/arch-mx51/imx-regs.h b/arch/arm/include/asm/arch-mx51/imx-regs.h index 0e3bc2a..06f2720 100644 --- a/arch/arm/include/asm/arch-mx51/imx-regs.h +++

Re: [U-Boot] [PATCH 05/13] x86: Make CONFIG_RELOC_FIXUP_WORKS generic for all x86 boards

2010-08-23 Thread Sergei Shtylyov
Hello. Graeme Russ wrote: Relocation is not board-specific fir the x86 architectrure, so s/fir/for/ CONFIG_RELOC_FIXUP_WORKS can be defined globally in the common.h You mean config.h? Signed-off-by: Graeme Russ graeme.r...@gmail.com [...] diff --git

Re: [U-Boot] [PATCH 5/8] APM82xxx: Add UIC support

2010-08-27 Thread Sergei Shtylyov
Hello. tma...@apm.com wrote: From: Tirumala Marri tma...@apm.com This patch adds Universal Interrupt Controller support for APM82XXX processor. Signed-off-by: Tirumala R Marri tma...@apm.com [...] diff --git a/arch/powerpc/include/asm/ppc4xx-uic.h b/arch/powerpc/include/asm/ppc4xx-uic.h

Re: [U-Boot] [PATCH 6/8] APM82xxx: Add SRAM support

2010-08-27 Thread Sergei Shtylyov
Hello. tma...@apm.com wrote: From: Tirumala Marri tma...@apm.com This patch adds L2Cache/SRAM and OCM register definitions. Signed-off-by: Tirumala R Marri tma...@apm.com [...] diff --git a/arch/powerpc/include/asm/ppc4xx-isram.h b/arch/powerpc/include/asm/ppc4xx-isram.h index

Re: [U-Boot] [PATCH] arm, orion5x: fix comilerwarning for edminiv2 board

2010-08-31 Thread Sergei Shtylyov
Hello. Heiko Schocher wrote: compiling edminiv2 board throws following warning: Configuring for edminiv2 board... In file included from /home/hs/i2c/u-boot-i2c/include/asm/arch/orion5x.h:39, from cpu.c:32: And? Where's the warning text? :-) introduced from commit

Re: [U-Boot] [PATCH 2/4] cfi_flash: Add weak default for cfi_flash_bank_addr()

2010-09-01 Thread Sergei Shtylyov
Hello. Stefan Roese wrote: cfi_flash_bank_addr(int bank_nr) returns the base addresses of the requested bank. Introducing this weak default enables boards to override this functions with a board specific version when required. This feature will be used in the lwmon5 board update, supporting

Re: [U-Boot] [PATCH] mvsata_ide: adjust port init sequence

2010-09-05 Thread Sergei Shtylyov
Hello. On 04-09-2010 14:34, Albert Aribaud wrote: mvsata_ide_initialize_port(): adjust init sequence (SStatus should be checked only after all writes to SControl) and return success/failure to ide_preinit(). Also, as some tests showed init durations in the hundreds of us, raise the

Re: [U-Boot] [PATCH V2 08/11] mtd: nand: supress 'unknown NAND' warning if no nand is found

2010-09-05 Thread Sergei Shtylyov
Hello. On 02-09-2010 19:33, Steve Sakoman wrote: This printk was added recently and results in ugly output on systems with no NAND: NAND: nand_get_flash_type: unknown NAND device: Manufacturer ID: 0x00, Chip ID: 0x00 0 MiB instead of: NAND: 0 MiB Signed-off-by: Steve

Re: [U-Boot] [PATCH] mvsata_ide: adjust port init sequence

2010-09-06 Thread Sergei Shtylyov
Hello. Albert ARIBAUD wrote: On 05.09.2010 23:33, Albert ARIBAUD wrote: + /* Set control IPM to 3 (no low power) and DET to 1 (initialize) */ control = readl(port-scontrol); control = (control ~MVSATA_SCONTROL_MASK) | MVSATA_PORT_INIT; + /* Toggle control DET back to 0 (normal operation)

Re: [U-Boot] [PATCH V2] mvsata_ide: adjust port init sequence

2010-09-07 Thread Sergei Shtylyov
Hello. On 07-09-2010 3:02, Albert Aribaud wrote: mvsata_ide_initialize_port(): adjust init sequence (SStatus should be checked only after all writes to SControl) and return success/failure to ide_preinit(). Also, as some tests showed init durations in the hundreds of us, raise the time-out

Re: [U-Boot] [PATCHv2] bootp: add ntpserver option to bootp request

2011-05-16 Thread Sergei Shtylyov
Hello. On 16-05-2011 6:24, Chris Packham wrote: From: Luuk Paulussen luuk.paulus...@alliedtelesis.co.nz Signed-off-by: Luuk Paulussenluuk.paulus...@alliedtelesis.co.nz Acked-by: Chris Packhamchris.pack...@alliedtelesis.co.nz Cc: Ben Warrenbiggerbadder...@gmail.com [...] diff --git

[U-Boot] [PATCH] part_dos: fix crash with big sector size

2011-06-03 Thread Sergei Shtylyov
Apple iPod nanos have sector sizes of 2 or 4 KiB, which crashes U-Boot when it tries to read the MBR into 512-byte buffer situated on stack. Instead use the variable length arrays to be safe with any large sector size. Signed-off-by: Sergei Shtylyov sshtyl...@ru.mvista.com --- The same change

Re: [U-Boot] [PATCH 6/8] Adds wait to atmel_usart serial_init function

2011-07-01 Thread Sergei Shtylyov
Hello. On 30-06-2011 23:33, Alex Waterman wrote: Adds a short busy loop wait to the atmel_usart.c serial_init() function. Signed-off-by: Alex Watermanawater...@dawning.com diff --git a/drivers/serial/atmel_usart.c b/drivers/serial/atmel_usart.c index e326b2b..e355706 100644 ---

Re: [U-Boot] [PATCH] part_dos: fix crash with big sector size

2011-07-04 Thread Sergei Shtylyov
Hello. I wrote: Apple iPod nanos have sector sizes of 2 or 4 KiB, which crashes U-Boot when it tries to read the MBR into 512-byte buffer situated on stack. Instead use the variable length arrays to be safe with any large sector size. Signed-off-by: Sergei Shtylyov sshtyl...@ru.mvista.com

Re: [U-Boot] [PATCH 5/5] USB: Set portnr so USB1.1 and 1.0 devices work on EHCI controllers

2011-07-12 Thread Sergei Shtylyov
Hello. Marek Vasut wrote: Signed-off-by: Marek Vasut marek.va...@gmail.com Hm... but EHCI controllers only support high speed (USB 2.0) devices... You need a companion controller (UHCI/OHCI) to support the full/low speed devices. WBR, Sergei

Re: [U-Boot] [PATCH 2/2] integratorap: fixup SDRAM memory size detection

2011-07-14 Thread Sergei Shtylyov
Hello. On 14-07-2011 3:04, Linus Walleij wrote: This fixes up the SDRAM memory detection code to work with the latest relocation code, moves it all into dram_init() and activates memory size detection for the Integrator AP. Signed-off-by: Linus Walleijlinus.wall...@linaro.org ---

[U-Boot] [PATCH 1/4] EHCI: fix root hub device descriptor

2010-02-27 Thread Sergei Shtylyov
On little endian machines, EHCI root hub's USB revision is reported as 0.2 -- cpu_to_le16() was missed in the initializer for the 'bcdUSB' descriptor field. The same should be done for the 'bcdDevice' field. Signed-off-by: Sergei Shtylyov sshtyl...@mvista.com --- drivers/usb/host/ehci-hcd.c

[U-Boot] [PATCH 2/4] EHCI: fix off-by-one error in ehci_submit_root()

2010-02-27 Thread Sergei Shtylyov
USB devices on the 2nd port are not detected and I get the following message: The request port(1) is not configured That's with default CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS value of 2. 'req-index' is 1-based, so the comparison in ehci_submit_root() can't be correct. Signed-off-by: Sergei Shtylyov

[U-Boot] [PATCH 3/4] EHCI: fix port reset reporting

2010-02-27 Thread Sergei Shtylyov
was already completed. Signed-off-by: Sergei Shtylyov sshtyl...@mvista.com --- drivers/usb/host/ehci-hcd.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) Index: u-boot/drivers/usb/host/ehci-hcd.c

[U-Boot] [PATCH 4/4] EHCI: add NEC PCI ID

2010-02-27 Thread Sergei Shtylyov
Add NEC EHCI controller to the list of the supported devices. Signed-off-by: Sergei Shtylyov sshtyl...@mvista.com drivers/usb/host/ehci-pci.c |1 + 1 file changed, 1 insertion(+) Index: u-boot/drivers/usb/host/ehci-pci.c

[U-Boot] [PATCH] part_dos: allocate sector buffer dynamically

2011-04-12 Thread Sergei Shtylyov
Apple iPod nanos have sector sizes of 2 or 4 KiB, which crashes U-Boot when it tries to read the MBR into 512-byte buffer situated on stack. Instead allocate this buffer dynamically to be safe with any large sector size. Signed-off-by: Sergei Shtylyov sshtyl...@ru.mvista.com --- The same change

Re: [U-Boot] [PATCH] MX51: mx51evk: Use struct to access SRSR register instead of offset

2011-04-13 Thread Sergei Shtylyov
Hello. On 13-04-2011 7:02, Fabio Estevam wrote: Signed-off-by: Fabio Estevamfabio.este...@freescale.com --- board/freescale/mx51evk/mx51evk.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/board/freescale/mx51evk/mx51evk.c

Re: [U-Boot] [PATCH] part_dos: allocate sector buffer dynamically

2011-05-03 Thread Sergei Shtylyov
Hello. On 30-04-2011 23:14, Wolfgang Denk wrote: Apple iPod nanos have sector sizes of 2 or 4 KiB, which crashes U-Boot when it tries to read the MBR into 512-byte buffer situated on stack. Instead allocate this buffer dynamically to be safe with any large sector size. Signed-off-by:

Re: [U-Boot] [PATCH] part_dos: allocate sector buffer dynamically

2011-05-03 Thread Sergei Shtylyov
Hello. On 03-05-2011 16:34, Wolfgang Denk wrote: Umm... you _are_ aware that you can put dynamically sized arrays on the stack, aren't you? No, it seems I'm not. Is it a standard C now? Best regards, Wolfgang Denk WBR, Sergei ___ U-Boot

Re: [U-Boot] [PATCH] post: add gpio hotkey support

2011-05-11 Thread Sergei Shtylyov
Hello. On 10-05-2011 21:01, Mike Frysinger wrote: Now that we have the generic GPIO layer, we can easily provide a common implementation for the post_hotkeys_pressed() function based on it. Signed-off-by: Mike Frysingervap...@gentoo.org --- post/post.c | 21 + 1

Re: [U-Boot] [PATCH] post: add gpio hotkey support

2011-05-12 Thread Sergei Shtylyov
Hello. On 11-05-2011 18:54, Mike Frysinger wrote: @@ -68,6 +72,23 @@ int post_init_f (void) int __post_hotkeys_pressed(void) { +#ifdef CONFIG_SYS_POST_HOTKEYS_GPIO + int ret; + unsigned gpio = CONFIG_SYS_POST_HOTKEYS_GPIO; + + ret = gpio_request(gpio, hotkeys); + if (ret)

Re: [U-Boot] [PATCH 1/2] mx31pdk: Disable watchdog

2011-09-16 Thread Sergei Shtylyov
Hello. On 16-09-2011 3:18, Fabio Estevam wrote: When booting a mainline kernel on a mx31pdk the system gets getting resets from the watchdog. That's tautological. Maybe is getting reset? As the kernel has watchdog support, disable it from U-boot. Signed-off-by: Fabio

[U-Boot] [PATCH] DaVinci: correct PDSTAT.STATE mask

2011-09-16 Thread Sergei Shtylyov
MDSTAT.STATE occupies bits 0..5 according to all available documentation, so fix the masks which previously was leaving out the itermediate state indicator bit. Signed-off-by: Sergei Shtylyov sshtyl...@ru.mvista.com --- Analogous Linux patch has been queued in the linux-davinci tree: http

Re: [U-Boot] [PATCH v2] DaVinci: correct MDSTAT.STATE mask

2011-09-16 Thread Sergei Shtylyov
MDSTAT.STATE occupies bits 0..5 according to all available documentation, so fix the masks which previously was leaving out the intermediate state indicator bit. Signed-off-by: Sergei Shtylyov sshtyl...@ru.mvista.com --- Resending with the corrected subject/description... Analogous Linux patch

Re: [U-Boot] [PATCH v2] DaVinci: correct MDSTAT.STATE mask

2011-09-17 Thread Sergei Shtylyov
Hello. On 17-09-2011 1:01, Wolfgang Denk wrote: Dear Sergei Shtylyov, Thank you for the really quick response. :-) MDSTAT.STATE occupies bits 0..5 according to all available documentation, so fix the masks which previously was leaving out the intermediate state indicator bit

Re: [U-Boot] [PATCH v3] DaVinci: correct MDSTAT.STATE mask

2011-09-23 Thread Sergei Shtylyov
asm/arch/hardware.h due to C-specfic constructs in it. Signed-off-by: Sergei Shtylyov sshtyl...@ru.mvista.com --- arch/arm/cpu/arm926ejs/davinci/lowlevel_init.S |8 +--- arch/arm/cpu/arm926ejs/davinci/psc.c |4 ++-- arch/arm/include/asm/arch-davinci/hardware.h |2 ++ 3

Re: [U-Boot] [PATCH 2/2] dm646x: pass board revision info to kernel

2011-09-23 Thread Sergei Shtylyov
Hello. On 09/21/2011 04:40 PM, nagabhushana.netagu...@ti.com wrote: From: Nagabhushana Netagunte nagabhushana.netagu...@ti.com add a function in board file to pass board revision info to kernel. Revision number 0 and 1 are passed in case of DM6467 and DM6467T respectively. Signed-off-by:

Re: [U-Boot] [PATCH] NAND: davinci: choose correct 1-bit h/w ECC reg

2011-09-28 Thread Sergei Shtylyov
Hello. On 26-09-2011 20:02, Laurence Withers wrote: In nand_davinci_readecc(), select the correct NANDFnECC register based on CONFIG_SYS_NAND_CS rather than hardcoding the choice of NANDF1ECC. This allows 1-bit hardware ECC to work with chip select other than CS2. Note this now matches the

Re: [U-Boot] [PATCH V3 3/5] mmc: sdhci: add mmc structure for host

2011-10-08 Thread Sergei Shtylyov
Hello. On 08-10-2011 17:47, Lei Wen wrote: So that sdhci host would tell in the driver that the mmc current attributes. Signed-off-by: Lei Wenlei...@marvell.com [...] diff --git a/include/sdhci.h b/include/sdhci.h index e84d2dc..e4e7ebe 100644 --- a/include/sdhci.h +++ b/include/sdhci.h

Re: [U-Boot] [PATCH 2/4] arm, davinci: Correct the MDSTAT.STATE mask

2011-10-15 Thread Sergei Shtylyov
Hello. On 12-10-2011 15:31, Christian Riesch wrote: MDSTAT.STATE occupies bits 0..5 according to all available documentation, therefore change the bitmask to 0x3f. Signed-off-by: Christian Rieschchristian.rie...@omicron.at Cc: Heiko Schocherh...@denx.de Cc: Paulraj Sandeeps-paul...@ti.com

Re: [U-Boot] [PATCH 1/9 v3] MAINTAINERS: integrator+versatile boards

2011-07-25 Thread Sergei Shtylyov
Hello. On 23-07-2011 17:37, Linus Walleij wrote: - Take maintainership of the unlisted integratorap, and the integratorcp boards - Orphan the versatile maintained by Peter Pearse, as he has retired from ARM Cc: Philippe Robinphilippe.ro...@arm.com Signed-off-by: Linus

Re: [U-Boot] [PATCH 3/9 v3] integratorap: support relocation

2011-07-25 Thread Sergei Shtylyov
Hello. On 23-07-2011 17:37, Linus Walleij wrote: The integrator board was apparently never converted over to support relocation until now. After this the integrator u-boot both compiles and boots on the Integrator AP. Signed-off-by: Linus Walleijlinus.wall...@linaro.org ---

  1   2   >