Re: [PATCH v6 00/14] mtd: spi-nor: Add support for Cypress s25hl-t/s25hs-t

Hi Jagan, On 4/25/2021 9:42 PM, Jagan Teki wrote: > On Tue, Apr 20, 2021 at 9:56 AM Takahiro Kuwano wrote: >> >> On 4/19/2021 4:13 PM, Jagan Teki wrote: >>> On Wed, Apr 7, 2021 at 9:01 AM wrote: >>>> >>>> From: Takahiro Kuwano >>>>

Re: [PATCH v6 00/14] mtd: spi-nor: Add support for Cypress s25hl-t/s25hs-t

On 4/26/2021 10:19 PM, Pratyush Yadav wrote: > On 26/04/21 06:25PM, Jagan Teki wrote: >> On Mon, Apr 26, 2021 at 6:19 PM Pratyush Yadav wrote: >>> >>> On 26/04/21 06:04PM, Jagan Teki wrote: >>>> On Mon, Apr 26, 2021 at 12:30 PM Takahiro Kuwano >>>

Re: [PATCH v7 00/14] mtd: spi-nor: Add support for Cypress s25hl-t/s25hs-t

On 4/28/2021 3:44 PM, Takahiro Kuwano wrote: > On 4/27/2021 7:14 PM, Jagan Teki wrote: >> On Tue, Apr 27, 2021 at 7:54 AM wrote: >>> >>> From: Takahiro Kuwano >>> >>> The S25HL-T/S25HS-T family is the Cypress Semper Flash with Quad SPI

Re: [PATCH v7 00/14] mtd: spi-nor: Add support for Cypress s25hl-t/s25hs-t

On 4/27/2021 7:14 PM, Jagan Teki wrote: > On Tue, Apr 27, 2021 at 7:54 AM wrote: >> >> From: Takahiro Kuwano >> >> The S25HL-T/S25HS-T family is the Cypress Semper Flash with Quad SPI. >> >> The summary datasheets can be found in the following links.

Re: [PATCH v4 2/9] mtd: spi-nor-ids: Add Cypress s25hl-t/s25hs-t

Hi Pratyush, On 1/30/2021 3:08 AM, Pratyush Yadav wrote: > On 28/01/21 01:36PM, tkuw584...@gmail.com wrote: >> From: Takahiro Kuwano >> >> The S25HL-T/S25HS-T family is the Cypress Semper Flash with Quad SPI. >> The datasheets can be found in the following links. &g

Re: [PATCH v4 3/9] mtd: spi-nor-core: Add support for Read/Write Any Register

On 1/30/2021 3:17 AM, Pratyush Yadav wrote: > On 28/01/21 01:36PM, tkuw584...@gmail.com wrote: >> From: Takahiro Kuwano >> >> Some of Spansion/Cypress chips support Read/Write Any Register commands. >> These commands are mainly used to write volatile registers and

Re: [PATCH v4 4/9] mtd: spi-nor-core: Add support for volatile QE bit

Hi Pratyush, On 1/30/2021 3:40 AM, Pratyush Yadav wrote: > Hi, > > On 28/01/21 01:36PM, tkuw584...@gmail.com wrote: >> From: Takahiro Kuwano >> >> Some of Spansion/Cypress chips support volatile version of configuration >> registers and it is recomme

Re: [PATCH v4 5/9] mtd: spi-nor-core: Add the ->ready() hook

Hi Pratyush, Thank you for the feedback. I will address this in v5. On 1/30/2021 3:49 AM, Pratyush Yadav wrote: > Hi, > > On 28/01/21 01:36PM, tkuw584...@gmail.com wrote: >> From: Takahiro Kuwano >> >> For dual/quad die package devices from Spansion/Cypress, t

Re: [PATCH v4 6/9] mtd: spi-nor-core: Add overlaid sector erase feature

Hi Pratyush, On 2/2/2021 3:56 AM, Pratyush Yadav wrote: > Hi Takahiro, > > On 28/01/21 01:36PM, tkuw584...@gmail.com wrote: >> From: Takahiro Kuwano >> >> Some of Spansion/Cypress chips have overlaid 4KB sectors at top and/or >> bottom, depending on the d

Re: [PATCH v4 9/9] mtd: spi-nor-tiny: Add fixups for Cypress s25hl-t/s25hs-t

Hi Pratyush, On 2/2/2021 4:40 AM, Pratyush Yadav wrote: > On 28/01/21 01:37PM, tkuw584...@gmail.com wrote: >> From: Takahiro Kuwano >> >> Fixes mode clocks for SPINOR_OP_READ_FAST_4B and volatile QE bit in tiny. >> The volatile QE bit function, spansion_quad_enable_

Re: [PATCH v8 26/28] mtd: spi-nor-core: Add non-uniform erase for Spansion/Cypress

On 4/2/2021 4:31 AM, Pratyush Yadav wrote: > From: Takahiro Kuwano > > Some of Spansion/Cypress chips have overlaid 4KB sectors at top and/or > bottom, depending on the device configuration, while U-Boot supports > uniform sector layout only. > > The spansion_erase_

Re: [PATCH v5 10/10] mtd: spi-nor-tiny: Add fixups for Cypress s25hl-t/s25hs-t

On 2/24/2021 9:43 PM, Pratyush Yadav wrote: > On 19/02/21 10:56AM, tkuw584...@gmail.com wrote: >> From: Takahiro Kuwano >> >> Fixes mode clocks for SPINOR_OP_READ_FAST_4B and volatile QE bit in tiny. >> The volatile QE bit function, spansion_quad_enable_volatile(

Re: [PATCH v5 07/10] mtd: spi-nor-core: Add non-uniform erase for Spansion/Cypress

Hi Pratyush, On 2/24/2021 9:05 PM, Pratyush Yadav wrote: > On 19/02/21 10:56AM, tkuw584...@gmail.com wrote: >> From: Takahiro Kuwano >> >> Some of Spansion/Cypress chips have overlaid 4KB sectors at top and/or >> bottom, depending on the device configuration, while

Re: [PATCH v5 05/10] mtd: spi-nor-core: Add the ->ready() hook

On 2/19/2021 6:57 PM, Pratyush Yadav wrote: > On 19/02/21 10:55AM, tkuw584...@gmail.com wrote: >> From: Takahiro Kuwano >> >> For dual/quad die package devices from Spansion/Cypress, the device's >> status needs to be checked by reading status registers in all dies, by

Re: [PATCH v5 08/10] mtd: spi-nor-core: Add Cypress manufacturer ID in set_4byte

On 2/24/2021 9:11 PM, Pratyush Yadav wrote: > On 19/02/21 10:56AM, tkuw584...@gmail.com wrote: >> From: Takahiro Kuwano >> >> Cypress chips support SPINOR_OP_EN4B(B7h)/SPINOR_OP_EX4B(E9h) to > > The datasheet says the EN4B command is indeed B7h but EX4B is listed

Re: [PATCH v5 09/10] mtd: spi-nor-core: Add fixups for Cypress s25hl-t/s25hs-t

On 2/24/2021 9:40 PM, Pratyush Yadav wrote: > On 19/02/21 10:56AM, tkuw584...@gmail.com wrote: >> From: Takahiro Kuwano >> >> This patch adds Flash specific fixups and hooks for Cypress >> S25HL-T/S25HS-T family, based on the features introduced in [0][1][2]. > &g

Re: [PATCH v5 02/10] mtd: spi-nor-ids: Add Cypress s25hl-t/s25hs-t

Hi Jagan, On 2/26/2021 7:35 PM, Jagan Teki wrote: > On Fri, Feb 19, 2021 at 7:26 AM wrote: >> >> From: Takahiro Kuwano >> >> The S25HL-T/S25HS-T family is the Cypress Semper Flash with Quad SPI. >> >> https://www.cypress.com/file/424146/download

Re: [PATCH v5 09/10] mtd: spi-nor-core: Add fixups for Cypress s25hl-t/s25hs-t

On 3/8/2021 5:54 PM, Pratyush Yadav wrote: > On 08/03/21 05:47PM, Takahiro Kuwano wrote: >> On 2/24/2021 9:40 PM, Pratyush Yadav wrote: >>> On 19/02/21 10:56AM, tkuw584...@gmail.com wrote: >>>> From: Takahiro Kuwano >>>> >>>> This

Re: [PATCH v5 04/10] mtd: spi-nor-core: Add support for volatile QE bit

Hi Jagan, On 2/26/2021 7:42 PM, Jagan Teki wrote: > On Fri, Feb 19, 2021 at 7:26 AM wrote: >> >> From: Takahiro Kuwano >> >> Some of Spansion/Cypress chips support volatile version of configuration >> registers and it is recommended to update volatile register

Re: [PATCH v6 00/14] mtd: spi-nor: Add support for Cypress s25hl-t/s25hs-t

On 4/19/2021 4:13 PM, Jagan Teki wrote: > On Wed, Apr 7, 2021 at 9:01 AM wrote: >> >> From: Takahiro Kuwano >> >> The S25HL-T/S25HS-T family is the Cypress Semper Flash with Quad SPI. >> >> The summary datasheets can be found in the following links.

Re: [PATCH v4 8/9] mtd: spi-nor-core: Add fixups for Cypress s25hl-t/s25hs-t

Hi Pratyush, On 2/2/2021 4:22 AM, Pratyush Yadav wrote: > On 28/01/21 01:37PM, tkuw584...@gmail.com wrote: >> From: Takahiro Kuwano >> >> Add nor->setup() and fixup hooks to overwrite: >> - volatile QE bit >> - the ->ready() hook for dual/quad

Re: [PATCH 2/2] mtd: spi-nor-core: Add fixups for Spansion S25FL256L

On 9/18/2021 1:51 AM, Pratyush Yadav wrote: > On 08/09/21 05:47PM, tkuw584...@gmail.com wrote: >> From: Takahiro Kuwano >> >> The S25FL256L is 32MB NOR Flash that does not support Bank Address >> Register. This fixup is activated if CONFIG_SPI_FLASH_BAR is enabled and &

Re: [PATCH] mtd: spi-nor-core: Add fixups for s25fs512s

On 9/18/2021 2:01 AM, Pratyush Yadav wrote: > On 15/09/21 12:49PM, tkuw584...@gmail.com wrote: >> From: Takahiro Kuwano >> >> The current S25FS512S support has following issues that need to be fixed. >> >> - Non-uniform sectors by factory default. The s

Re: [PATCH] mtd: spi-nor: Add support for Infineon S25FS-S family

On 4/5/2024 7:10 PM, Pratyush Yadav wrote: > Hi, > > Just a couple small comments. Looks good otherwise. > > On Fri, Apr 05 2024, tkuw584...@gmail.com wrote: > >> From: Takahiro Kuwano >> >> The S25FS064S, S25FS128S, and S25FS256S are the same family of SPI

Re: [PATCH v2 3/3] mtd: spi-nor-id: Add S25FS064S, S25FS128S, S25FS256S IDs

On 4/9/2024 8:54 PM, Pratyush Yadav wrote: > On Tue, Apr 09 2024, tkuw584...@gmail.com wrote: > >> From: Takahiro Kuwano >> >> The S25FS064S, S25FS128S, and S25FS256S are the same family of SPI NOR >> Flash devices with S25FS512S. Some difference depending on the

Re: [PATCH 0/4] mtd: Make sure UBIFS does not do multi-pass page programming on flashes that don't support it

On 4/15/2024 3:56 PM, Tudor Ambarus wrote: > > > On 4/15/24 05:33, tkuw584...@gmail.com wrote: >> From: Takahiro Kuwano >> >> This series is equivalent to the one for Linux MTD submitted by >> Pratyush Yadav. >> >> https://patchwork.ozlabs.org/proje

Re: [PATCH 3/4] mtd: spi-nor-core: Rework default_init() to take flash_parameter

Hi Tudor, On 4/15/2024 3:47 PM, Tudor Ambarus wrote: > > > On 4/15/24 05:33, tkuw584...@gmail.com wrote: >> From: Takahiro Kuwano >> >> default_init() fixup hook should be used to initialize flash parameters >> when its information is not provided in SFDP.

Re: [PATCH 3/4] mtd: spi-nor-core: Rework default_init() to take flash_parameter

On 4/15/2024 4:27 PM, Tudor Ambarus wrote: > > > On 4/15/24 08:09, Takahiro Kuwano wrote: >> Hi Tudor, > > Hi! > >> >> On 4/15/2024 3:47 PM, Tudor Ambarus wrote: >>> >>> >>> On 4/15/24 05:33, tkuw584...@gmail.com wrote: >>