Re: [PATCH 07/11] bootm: Split out bootargs environment reading / writing

2020-10-21 Thread Simon Glass
Hi Wolfgang, On Wed, 21 Oct 2020 at 01:02, Wolfgang Denk wrote: > > Dear Simon, > > In message > you > wrote: > > > > > > It is also useful for zimage to use a buffer, since it does not actually > > > > put the Linux command line in the bootargs variable. > > > > > > ...which I consider a bug

Re: [PATCH 07/11] bootm: Split out bootargs environment reading / writing

2020-10-21 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > > > It is also useful for zimage to use a buffer, since it does not actually > > > put the Linux command line in the bootargs variable. > > > > ...which I consider a bug that should be fixed. > > OK I was wondering about that. > > The messy thing about

Re: [PATCH 07/11] bootm: Split out bootargs environment reading / writing

2020-10-20 Thread Simon Glass
Hi Wolfgang, On Mon, 19 Oct 2020 at 08:45, Wolfgang Denk wrote: > > Dear Simon, > > In message <20201019135602.3943835-8-...@chromium.org> you wrote: > ... > > > > It is also useful for zimage to use a buffer, since it does not actually > > put the Linux command line in the bootargs variable. >

Re: [PATCH 07/11] bootm: Split out bootargs environment reading / writing

2020-10-19 Thread Wolfgang Denk
Dear Simon, In message <20201019135602.3943835-8-...@chromium.org> you wrote: ... > > It is also useful for zimage to use a buffer, since it does not actually > put the Linux command line in the bootargs variable. ...which I consider a bug that should be fixed. Best regards, Wolfgang Denk --

[PATCH 07/11] bootm: Split out bootargs environment reading / writing

2020-10-19 Thread Simon Glass
At present bootm_process_cmdline_env() reads the 'bootargs' variable and then writes it back afterwards. This is painful for tests, which would rather use a simple buffer. It is also useful for zimage to use a buffer, since it does not actually put the Linux command line in the bootargs variable.