Re: [PATCH 07/11] pci: pci_read_config can be static

[Tom Rini]

On Fri, Sep 17, 2021 at 03:11:26PM +0300, Vladimir Oltean wrote:

> To avoid W=1 build warnings, declare this function as static, since it
> is not used outside of this translation module.
> 
> Signed-off-by: Vladimir Oltean 
> Reviewed-by: Bin Meng 

Applied to u-boot/next, thanks!

-- 
Tom


signature.asc
Description: PGP signature

Re: [PATCH 07/11] pci: pci_read_config can be static

[Bin Meng]

On Fri, Sep 17, 2021 at 8:11 PM Vladimir Oltean  wrote:
>
> To avoid W=1 build warnings, declare this function as static, since it
> is not used outside of this translation module.
>
> Signed-off-by: Vladimir Oltean 
> ---
>  drivers/pci/pci-uclass.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>

Reviewed-by: Bin Meng 

[PATCH 07/11] pci: pci_read_config can be static

[Vladimir Oltean]

To avoid W=1 build warnings, declare this function as static, since it
is not used outside of this translation module.

Signed-off-by: Vladimir Oltean 
---
 drivers/pci/pci-uclass.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c
index 20bddb597588..f0313d059042 100644
--- a/drivers/pci/pci-uclass.c
+++ b/drivers/pci/pci-uclass.c
@@ -369,8 +369,8 @@ int pci_bus_read_config(const struct udevice *bus, 
pci_dev_t bdf, int offset,
return ops->read_config(bus, bdf, offset, valuep, size);
 }
 
-int pci_read_config(pci_dev_t bdf, int offset, unsigned long *valuep,
-   enum pci_size_t size)
+static int pci_read_config(pci_dev_t bdf, int offset, unsigned long *valuep,
+  enum pci_size_t size)
 {
struct udevice *bus;
int ret;
-- 
2.25.1