Re: [PATCH 3/3] rockchip: board: add Hardkernel Odroid Go2 board

2020-07-08 Thread Kever Yang



On 2020/7/1 下午5:28, Heiko Stuebner wrote:

From: Heiko Stuebner 

Also known as Odroid Go Advance but named Go2 internally by the
vendor it seems.

Signed-off-by: Heiko Stuebner 


Reviewed-by: Kever Yang

Thanks,
- Kever


---
  arch/arm/dts/rk3326-odroid-go2-u-boot.dtsi |  72 +
  arch/arm/mach-rockchip/px30/Kconfig|   4 +
  board/hardkernel/odroid_go2/Kconfig|  15 +++
  board/hardkernel/odroid_go2/MAINTAINERS|   6 ++
  board/hardkernel/odroid_go2/Makefile   |   7 ++
  board/hardkernel/odroid_go2/go2.c  |   4 +
  configs/odroid-go2_defconfig   | 119 +
  include/configs/odroid_go2.h   |  17 +++
  8 files changed, 244 insertions(+)
  create mode 100644 arch/arm/dts/rk3326-odroid-go2-u-boot.dtsi
  create mode 100644 board/hardkernel/odroid_go2/Kconfig
  create mode 100644 board/hardkernel/odroid_go2/MAINTAINERS
  create mode 100644 board/hardkernel/odroid_go2/Makefile
  create mode 100644 board/hardkernel/odroid_go2/go2.c
  create mode 100644 configs/odroid-go2_defconfig
  create mode 100644 include/configs/odroid_go2.h

diff --git a/arch/arm/dts/rk3326-odroid-go2-u-boot.dtsi 
b/arch/arm/dts/rk3326-odroid-go2-u-boot.dtsi
new file mode 100644
index 00..34c9e62025
--- /dev/null
+++ b/arch/arm/dts/rk3326-odroid-go2-u-boot.dtsi
@@ -0,0 +1,72 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2020 Theobroma Systems Design und Consulting GmbH
+ */
+
+/ {
+   chosen {
+   u-boot,spl-boot-order = 
+   };
+};
+
+ {
+   u-boot,dm-pre-reloc;
+};
+
+ {
+   u-boot,dm-pre-reloc;
+};
+
+ {
+   u-boot,dm-pre-reloc;
+};
+
+ {
+   u-boot,dm-pre-reloc;
+};
+
+ {
+   u-boot,dm-pre-reloc;
+};
+
+ {
+   u-boot,dm-pre-reloc;
+};
+
+ {
+   u-boot,dm-pre-reloc;
+};
+
+ {
+   u-boot,dm-pre-reloc;
+};
+
+ {
+   u-boot,dm-pre-reloc;
+};
+
+ {
+   u-boot,dm-pre-reloc;
+   status = "okay";
+};
+
+ {
+   u-boot,dm-pre-reloc;
+
+   /* mmc to sram can't do dma, prevent aborts transfering TF-A parts */
+   u-boot,spl-fifo-mode;
+};
+
+ {
+   clock-frequency = <2400>;
+   u-boot,dm-pre-reloc;
+};
+
+ {
+   clock-frequency = <2400>;
+   u-boot,dm-pre-reloc;
+};
+
+ {
+   u-boot,dm-pre-reloc;
+};
diff --git a/arch/arm/mach-rockchip/px30/Kconfig 
b/arch/arm/mach-rockchip/px30/Kconfig
index 9f3ad4f623..f5373c6f9f 100644
--- a/arch/arm/mach-rockchip/px30/Kconfig
+++ b/arch/arm/mach-rockchip/px30/Kconfig
@@ -3,6 +3,9 @@ if ROCKCHIP_PX30
  config TARGET_EVB_PX30
bool "EVB_PX30"
  
+config TARGET_ODROID_GO2

+   bool "ODROID_GO2"
+
  config ROCKCHIP_BOOT_MODE_REG
default 0xff010200
  
@@ -36,6 +39,7 @@ config DEBUG_UART_CHANNEL

  For using the UART for early debugging the route to use needs
  to be declared (0 or 1).
  
+source "board/hardkernel/odroid_go2/Kconfig"

  source "board/rockchip/evb_px30/Kconfig"
  
  endif

diff --git a/board/hardkernel/odroid_go2/Kconfig 
b/board/hardkernel/odroid_go2/Kconfig
new file mode 100644
index 00..cf3f7c91d9
--- /dev/null
+++ b/board/hardkernel/odroid_go2/Kconfig
@@ -0,0 +1,15 @@
+if TARGET_ODROID_GO2
+
+config SYS_BOARD
+   default "odroid_go2"
+
+config SYS_VENDOR
+   default "hardkernel"
+
+config SYS_CONFIG_NAME
+   default "odroid_go2"
+
+config BOARD_SPECIFIC_OPTIONS # dummy
+   def_bool y
+
+endif
diff --git a/board/hardkernel/odroid_go2/MAINTAINERS 
b/board/hardkernel/odroid_go2/MAINTAINERS
new file mode 100644
index 00..eab622a70b
--- /dev/null
+++ b/board/hardkernel/odroid_go2/MAINTAINERS
@@ -0,0 +1,6 @@
+GO2
+M:  Heiko Stuebner 
+S:  Maintained
+F:  board/odroid/go2
+F:  include/configs/odroid_go2.h
+F:  configs/odroid-go2_defconfig
diff --git a/board/hardkernel/odroid_go2/Makefile 
b/board/hardkernel/odroid_go2/Makefile
new file mode 100644
index 00..51b9d24cfb
--- /dev/null
+++ b/board/hardkernel/odroid_go2/Makefile
@@ -0,0 +1,7 @@
+#
+# Copyright (c) 2020 Theobroma Systems Design und Consulting GmbH
+#
+# SPDX-License-Identifier: GPL-2.0+
+#
+
+obj-y  += go2.o
diff --git a/board/hardkernel/odroid_go2/go2.c 
b/board/hardkernel/odroid_go2/go2.c
new file mode 100644
index 00..29464ae63e
--- /dev/null
+++ b/board/hardkernel/odroid_go2/go2.c
@@ -0,0 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * (C) Copyright 2019 Rockchip Electronics Co., Ltd
+ */
diff --git a/configs/odroid-go2_defconfig b/configs/odroid-go2_defconfig
new file mode 100644
index 00..6eb85a97f7
--- /dev/null
+++ b/configs/odroid-go2_defconfig
@@ -0,0 +1,119 @@
+CONFIG_ARM=y
+CONFIG_ARCH_ROCKCHIP=y
+CONFIG_SYS_TEXT_BASE=0x0020
+CONFIG_SPL_LIBCOMMON_SUPPORT=y
+CONFIG_SPL_LIBGENERIC_SUPPORT=y
+CONFIG_SYS_MALLOC_F_LEN=0x2000
+CONFIG_ENV_SIZE=0x4000
+CONFIG_ENV_OFFSET=0x4000
+CONFIG_ROCKCHIP_PX30=y
+CONFIG_TARGET_ODROID_GO2=y
+CONFIG_TPL_LIBGENERIC_SUPPORT=y
+CONFIG_SPL_DRIVERS_MISC_SUPPORT=y

[PATCH 3/3] rockchip: board: add Hardkernel Odroid Go2 board

2020-07-02 Thread Heiko Stuebner
From: Heiko Stuebner 

Also known as Odroid Go Advance but named Go2 internally by the
vendor it seems.

Signed-off-by: Heiko Stuebner 
---
 arch/arm/dts/rk3326-odroid-go2-u-boot.dtsi |  72 +
 arch/arm/mach-rockchip/px30/Kconfig|   4 +
 board/hardkernel/odroid_go2/Kconfig|  15 +++
 board/hardkernel/odroid_go2/MAINTAINERS|   6 ++
 board/hardkernel/odroid_go2/Makefile   |   7 ++
 board/hardkernel/odroid_go2/go2.c  |   4 +
 configs/odroid-go2_defconfig   | 119 +
 include/configs/odroid_go2.h   |  17 +++
 8 files changed, 244 insertions(+)
 create mode 100644 arch/arm/dts/rk3326-odroid-go2-u-boot.dtsi
 create mode 100644 board/hardkernel/odroid_go2/Kconfig
 create mode 100644 board/hardkernel/odroid_go2/MAINTAINERS
 create mode 100644 board/hardkernel/odroid_go2/Makefile
 create mode 100644 board/hardkernel/odroid_go2/go2.c
 create mode 100644 configs/odroid-go2_defconfig
 create mode 100644 include/configs/odroid_go2.h

diff --git a/arch/arm/dts/rk3326-odroid-go2-u-boot.dtsi 
b/arch/arm/dts/rk3326-odroid-go2-u-boot.dtsi
new file mode 100644
index 00..34c9e62025
--- /dev/null
+++ b/arch/arm/dts/rk3326-odroid-go2-u-boot.dtsi
@@ -0,0 +1,72 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2020 Theobroma Systems Design und Consulting GmbH
+ */
+
+/ {
+   chosen {
+   u-boot,spl-boot-order = 
+   };
+};
+
+ {
+   u-boot,dm-pre-reloc;
+};
+
+ {
+   u-boot,dm-pre-reloc;
+};
+
+ {
+   u-boot,dm-pre-reloc;
+};
+
+ {
+   u-boot,dm-pre-reloc;
+};
+
+ {
+   u-boot,dm-pre-reloc;
+};
+
+ {
+   u-boot,dm-pre-reloc;
+};
+
+ {
+   u-boot,dm-pre-reloc;
+};
+
+ {
+   u-boot,dm-pre-reloc;
+};
+
+ {
+   u-boot,dm-pre-reloc;
+};
+
+ {
+   u-boot,dm-pre-reloc;
+   status = "okay";
+};
+
+ {
+   u-boot,dm-pre-reloc;
+
+   /* mmc to sram can't do dma, prevent aborts transfering TF-A parts */
+   u-boot,spl-fifo-mode;
+};
+
+ {
+   clock-frequency = <2400>;
+   u-boot,dm-pre-reloc;
+};
+
+ {
+   clock-frequency = <2400>;
+   u-boot,dm-pre-reloc;
+};
+
+ {
+   u-boot,dm-pre-reloc;
+};
diff --git a/arch/arm/mach-rockchip/px30/Kconfig 
b/arch/arm/mach-rockchip/px30/Kconfig
index 9f3ad4f623..f5373c6f9f 100644
--- a/arch/arm/mach-rockchip/px30/Kconfig
+++ b/arch/arm/mach-rockchip/px30/Kconfig
@@ -3,6 +3,9 @@ if ROCKCHIP_PX30
 config TARGET_EVB_PX30
bool "EVB_PX30"
 
+config TARGET_ODROID_GO2
+   bool "ODROID_GO2"
+
 config ROCKCHIP_BOOT_MODE_REG
default 0xff010200
 
@@ -36,6 +39,7 @@ config DEBUG_UART_CHANNEL
  For using the UART for early debugging the route to use needs
  to be declared (0 or 1).
 
+source "board/hardkernel/odroid_go2/Kconfig"
 source "board/rockchip/evb_px30/Kconfig"
 
 endif
diff --git a/board/hardkernel/odroid_go2/Kconfig 
b/board/hardkernel/odroid_go2/Kconfig
new file mode 100644
index 00..cf3f7c91d9
--- /dev/null
+++ b/board/hardkernel/odroid_go2/Kconfig
@@ -0,0 +1,15 @@
+if TARGET_ODROID_GO2
+
+config SYS_BOARD
+   default "odroid_go2"
+
+config SYS_VENDOR
+   default "hardkernel"
+
+config SYS_CONFIG_NAME
+   default "odroid_go2"
+
+config BOARD_SPECIFIC_OPTIONS # dummy
+   def_bool y
+
+endif
diff --git a/board/hardkernel/odroid_go2/MAINTAINERS 
b/board/hardkernel/odroid_go2/MAINTAINERS
new file mode 100644
index 00..eab622a70b
--- /dev/null
+++ b/board/hardkernel/odroid_go2/MAINTAINERS
@@ -0,0 +1,6 @@
+GO2
+M:  Heiko Stuebner 
+S:  Maintained
+F:  board/odroid/go2
+F:  include/configs/odroid_go2.h
+F:  configs/odroid-go2_defconfig
diff --git a/board/hardkernel/odroid_go2/Makefile 
b/board/hardkernel/odroid_go2/Makefile
new file mode 100644
index 00..51b9d24cfb
--- /dev/null
+++ b/board/hardkernel/odroid_go2/Makefile
@@ -0,0 +1,7 @@
+#
+# Copyright (c) 2020 Theobroma Systems Design und Consulting GmbH
+#
+# SPDX-License-Identifier: GPL-2.0+
+#
+
+obj-y  += go2.o
diff --git a/board/hardkernel/odroid_go2/go2.c 
b/board/hardkernel/odroid_go2/go2.c
new file mode 100644
index 00..29464ae63e
--- /dev/null
+++ b/board/hardkernel/odroid_go2/go2.c
@@ -0,0 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * (C) Copyright 2019 Rockchip Electronics Co., Ltd
+ */
diff --git a/configs/odroid-go2_defconfig b/configs/odroid-go2_defconfig
new file mode 100644
index 00..6eb85a97f7
--- /dev/null
+++ b/configs/odroid-go2_defconfig
@@ -0,0 +1,119 @@
+CONFIG_ARM=y
+CONFIG_ARCH_ROCKCHIP=y
+CONFIG_SYS_TEXT_BASE=0x0020
+CONFIG_SPL_LIBCOMMON_SUPPORT=y
+CONFIG_SPL_LIBGENERIC_SUPPORT=y
+CONFIG_SYS_MALLOC_F_LEN=0x2000
+CONFIG_ENV_SIZE=0x4000
+CONFIG_ENV_OFFSET=0x4000
+CONFIG_ROCKCHIP_PX30=y
+CONFIG_TARGET_ODROID_GO2=y
+CONFIG_TPL_LIBGENERIC_SUPPORT=y
+CONFIG_SPL_DRIVERS_MISC_SUPPORT=y
+CONFIG_SPL_STACK_R_ADDR=0x60
+CONFIG_NR_DRAM_BANKS=1
+CONFIG_DEBUG_UART_BASE=0xFF16