Re: [PATCH 7/7] test: rng: Add basic test for random number generator(rng) uclass

2019-12-27 Thread Simon Glass
On Wed, 4 Dec 2019 at 08:12, Patrice CHOTARD  wrote:
>
>
> On 12/4/19 12:53 PM, Sughosh Ganu wrote:
> > Add a unit test for testing the rng uclass functionality using the
> > sandbox rng driver.
> >
> > Signed-off-by: Sughosh Ganu 
> > ---
> >  test/dm/Makefile |  1 +
> >  test/dm/rng.c| 26 ++
> >  2 files changed, 27 insertions(+)
> >  create mode 100644 test/dm/rng.c

Reviewed-by: Simon Glass 


Re: [PATCH 7/7] test: rng: Add basic test for random number generator(rng) uclass

2019-12-04 Thread Patrice CHOTARD

On 12/4/19 12:53 PM, Sughosh Ganu wrote:
> Add a unit test for testing the rng uclass functionality using the
> sandbox rng driver.
>
> Signed-off-by: Sughosh Ganu 
> ---
>  test/dm/Makefile |  1 +
>  test/dm/rng.c| 26 ++
>  2 files changed, 27 insertions(+)
>  create mode 100644 test/dm/rng.c
>
> diff --git a/test/dm/Makefile b/test/dm/Makefile
> index 0c2fd5c..f61bf65 100644
> --- a/test/dm/Makefile
> +++ b/test/dm/Makefile
> @@ -65,4 +65,5 @@ obj-$(CONFIG_VIRTIO_SANDBOX) += virtio.o
>  obj-$(CONFIG_DMA) += dma.o
>  obj-$(CONFIG_DM_MDIO) += mdio.o
>  obj-$(CONFIG_DM_MDIO_MUX) += mdio_mux.o
> +obj-$(CONFIG_DM_RNG) += rng.o
>  endif
> diff --git a/test/dm/rng.c b/test/dm/rng.c
> new file mode 100644
> index 000..879e80a
> --- /dev/null
> +++ b/test/dm/rng.c
> @@ -0,0 +1,26 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * Copyright (c) 2019, Linaro Limited
> + */
> +
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +
> +/* Basic test of the rng uclass */
> +static int dm_test_rng_read(struct unit_test_state *uts)
> +{
> + unsigned long val1 = 0, val2 = 0;
> + struct udevice *dev;
> +
> + ut_assertok(uclass_get_device(UCLASS_RNG, 0, ));
> + ut_assertnonnull(dev);
> + dm_rng_read(dev, , sizeof(val1));
> + dm_rng_read(dev, , sizeof(val2));
> + ut_assert(val1 != val2);
> +
> + return 0;
> +}
> +DM_TEST(dm_test_rng_read, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);

Reviewed-by: Patrice Chotard 

Thanks



[PATCH 7/7] test: rng: Add basic test for random number generator(rng) uclass

2019-12-04 Thread Sughosh Ganu
Add a unit test for testing the rng uclass functionality using the
sandbox rng driver.

Signed-off-by: Sughosh Ganu 
---
 test/dm/Makefile |  1 +
 test/dm/rng.c| 26 ++
 2 files changed, 27 insertions(+)
 create mode 100644 test/dm/rng.c

diff --git a/test/dm/Makefile b/test/dm/Makefile
index 0c2fd5c..f61bf65 100644
--- a/test/dm/Makefile
+++ b/test/dm/Makefile
@@ -65,4 +65,5 @@ obj-$(CONFIG_VIRTIO_SANDBOX) += virtio.o
 obj-$(CONFIG_DMA) += dma.o
 obj-$(CONFIG_DM_MDIO) += mdio.o
 obj-$(CONFIG_DM_MDIO_MUX) += mdio_mux.o
+obj-$(CONFIG_DM_RNG) += rng.o
 endif
diff --git a/test/dm/rng.c b/test/dm/rng.c
new file mode 100644
index 000..879e80a
--- /dev/null
+++ b/test/dm/rng.c
@@ -0,0 +1,26 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (c) 2019, Linaro Limited
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+
+/* Basic test of the rng uclass */
+static int dm_test_rng_read(struct unit_test_state *uts)
+{
+   unsigned long val1 = 0, val2 = 0;
+   struct udevice *dev;
+
+   ut_assertok(uclass_get_device(UCLASS_RNG, 0, ));
+   ut_assertnonnull(dev);
+   dm_rng_read(dev, , sizeof(val1));
+   dm_rng_read(dev, , sizeof(val2));
+   ut_assert(val1 != val2);
+
+   return 0;
+}
+DM_TEST(dm_test_rng_read, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
-- 
2.7.4