RE: [PATCH 8/8] arm: socfpga: vining: Let DWMAC configure PHY reset GPIO

[Chee, Tien Fong]

> -Original Message-
> From: Marek Vasut 
> Sent: Tuesday, 14 September, 2021 11:26 AM
> To: u-boot@lists.denx.de
> Cc: Marek Vasut ; Lim, Elly Siew Chin
> ; Simon Goldschmidt
> ; Chee, Tien Fong
> 
> Subject: [PATCH 8/8] arm: socfpga: vining: Let DWMAC configure PHY reset
> GPIO
> 
> The DM DWMAC driver is perfectly capable of configuring the ethernet PHY
> reset GPIO, let the driver do it instead of doing it in the board file.
> 
> Signed-off-by: Marek Vasut 
> Cc: Siew Chin Lim 
> Cc: Simon Goldschmidt 
> Cc: Tien Fong Chee 
> ---
>  board/softing/vining_fpga/socfpga.c | 7 ---
>  1 file changed, 7 deletions(-)
> 

Reviewed-by: Tien Fong Chee 

Regards,
TF

[PATCH 8/8] arm: socfpga: vining: Let DWMAC configure PHY reset GPIO

[Marek Vasut]

The DM DWMAC driver is perfectly capable of configuring the ethernet
PHY reset GPIO, let the driver do it instead of doing it in the board
file.

Signed-off-by: Marek Vasut 
Cc: Siew Chin Lim 
Cc: Simon Goldschmidt 
Cc: Tien Fong Chee 
---
 board/softing/vining_fpga/socfpga.c | 7 ---
 1 file changed, 7 deletions(-)

diff --git a/board/softing/vining_fpga/socfpga.c 
b/board/softing/vining_fpga/socfpga.c
index aaedf034504..22992273911 100644
--- a/board/softing/vining_fpga/socfpga.c
+++ b/board/softing/vining_fpga/socfpga.c
@@ -23,7 +23,6 @@ DECLARE_GLOBAL_DATA_PTR;
  */
 int board_late_init(void)
 {
-   const unsigned int phy_nrst_gpio = 0;
const unsigned int usb_nrst_gpio = 35;
int ret;
 
@@ -33,12 +32,6 @@ int board_late_init(void)
/* Address of boot parameters for ATAG (if ATAG is used) */
gd->bd->bi_boot_params = CONFIG_SYS_SDRAM_BASE + 0x100;
 
-   ret = gpio_request(phy_nrst_gpio, "phy_nrst_gpio");
-   if (!ret)
-   gpio_direction_output(phy_nrst_gpio, 1);
-   else
-   printf("Cannot remove PHY from reset!\n");
-
ret = gpio_request(usb_nrst_gpio, "usb_nrst_gpio");
if (!ret)
gpio_direction_output(usb_nrst_gpio, 1);
-- 
2.33.0