Re: [PATCH v1 26/43] i2c: designware_i2c: Add a little more debugging
Hello Simon, Am 15.06.2020 um 05:57 schrieb Simon Glass: Add debugging for a few more values and also use log to show return values when something goes wrong. This makes it easier to see the root cause. Signed-off-by: Simon Glass --- Changes in v1: - Add new patch to improve designware_i2c debugging drivers/i2c/designware_i2c.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Heiko Schocher bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: h...@denx.de
Re: [PATCH v1 26/43] i2c: designware_i2c: Add a little more debugging
On Mon, Jun 15, 2020 at 11:58 AM Simon Glass wrote: > > Add debugging for a few more values and also use log to show return values > when something goes wrong. This makes it easier to see the root cause. > > Signed-off-by: Simon Glass > --- > > Changes in v1: > - Add new patch to improve designware_i2c debugging > > drivers/i2c/designware_i2c.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > Reviewed-by: Bin Meng
Re: [PATCH v1 26/43] i2c: designware_i2c: Add a little more debugging
Hi Simon, -"Simon Glass" schrieb: - > Betreff: [PATCH v1 26/43] i2c: designware_i2c: Add a little more debugging > > Add debugging for a few more values and also use log to show return values > when something goes wrong. This makes it easier to see the root cause. > > Signed-off-by: Simon Glass > --- > > Changes in v1: > - Add new patch to improve designware_i2c debugging > > drivers/i2c/designware_i2c.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Wolfgang Wallner
[PATCH v1 26/43] i2c: designware_i2c: Add a little more debugging
Add debugging for a few more values and also use log to show return values when something goes wrong. This makes it easier to see the root cause. Signed-off-by: Simon Glass --- Changes in v1: - Add new patch to improve designware_i2c debugging drivers/i2c/designware_i2c.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/designware_i2c.c b/drivers/i2c/designware_i2c.c index 3616e2105f..44a1f33398 100644 --- a/drivers/i2c/designware_i2c.c +++ b/drivers/i2c/designware_i2c.c @@ -160,9 +160,9 @@ static int dw_i2c_calc_timing(struct dw_i2c *priv, enum i2c_speed_mode mode, min_tlow_cnt = calc_counts(ic_clk, info->min_scl_lowtime_ns); min_thigh_cnt = calc_counts(ic_clk, info->min_scl_hightime_ns); - debug("dw_i2c: period %d rise %d fall %d tlow %d thigh %d spk %d\n", - period_cnt, rise_cnt, fall_cnt, min_tlow_cnt, min_thigh_cnt, - spk_cnt); + debug("dw_i2c: mode %d, ic_clk %d, speed %d, period %d rise %d fall %d tlow %d thigh %d spk %d\n", + mode, ic_clk, info->speed, period_cnt, rise_cnt, fall_cnt, + min_tlow_cnt, min_thigh_cnt, spk_cnt); /* * Back-solve for hcnt and lcnt according to the following equations: @@ -174,7 +174,7 @@ static int dw_i2c_calc_timing(struct dw_i2c *priv, enum i2c_speed_mode mode, if (hcnt < 0 || lcnt < 0) { debug("dw_i2c: bad counts. hcnt = %d lcnt = %d\n", hcnt, lcnt); - return -EINVAL; + return log_msg_ret("counts", -EINVAL); } /* @@ -713,7 +713,7 @@ static int designware_i2c_set_bus_speed(struct udevice *bus, unsigned int speed) #if CONFIG_IS_ENABLED(CLK) rate = clk_get_rate(&i2c->clk); if (IS_ERR_VALUE(rate)) - return -EINVAL; + return log_ret(-EINVAL); #else rate = IC_CLK; #endif -- 2.27.0.290.gba653c62da-goog