Re: [PATCH v2 03/32] mmc: env: Unify the U_BOOT_ENV_LOCATION conditions

[Tom Rini]

On Wed, Nov 15, 2023 at 09:10:03PM -0700, Simon Glass wrote:

> The declaration of U_BOOT_ENV_LOCATION() uses a different #ifdef
> condition from the code it calls. Use the same condition to avoid a
> build warning if CONFIG_CMD_SAVEENV is disabled.
> 
> Signed-off-by: Simon Glass 

Reviewed-by: Tom Rini 

-- 
Tom


signature.asc
Description: PGP signature

[PATCH v2 03/32] mmc: env: Unify the U_BOOT_ENV_LOCATION conditions

[Simon Glass]

The declaration of U_BOOT_ENV_LOCATION() uses a different #ifdef
condition from the code it calls. Use the same condition to avoid a
build warning if CONFIG_CMD_SAVEENV is disabled.

Signed-off-by: Simon Glass 
---

(no changes since v1)

 env/mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/env/mmc.c b/env/mmc.c
index cb14bbb58f13..da84cddd74f0 100644
--- a/env/mmc.c
+++ b/env/mmc.c
@@ -495,7 +495,7 @@ U_BOOT_ENV_LOCATION(mmc) = {
.location   = ENVL_MMC,
ENV_NAME("MMC")
.load   = env_mmc_load,
-#ifndef CONFIG_SPL_BUILD
+#if defined(CONFIG_CMD_SAVEENV) && !defined(CONFIG_SPL_BUILD)
.save   = env_save_ptr(env_mmc_save),
.erase  = ENV_ERASE_PTR(env_mmc_erase)
 #endif
-- 
2.43.0.rc0.421.g78406f8d94-goog