Re: [PATCH v2 1/4] rockchip: Move TEXT_BASE to 8 MiB offset from start of DRAM

2025-05-07 Thread Kever Yang



On 2025/4/5 23:38, Jonas Karlman wrote:

Drop SoC specific TEXT_BASE and use a common TEXT_BASE for all SoCs.

Move the common TEXT_BASE to 8 MiB offset from start of DRAM to help
support RAM boot from maskrom introduced in next patch.

RAM boot from maskrom mode will expect the FIT payload to be located at
2 MiB offset from start or DRAM.

Signed-off-by: Jonas Karlman 
Tested-by: Arnaud Patard 

Reviewed-by: Kever Yang 

Thanks,
- Kever

---
v2: Collect t-b tag
---
  arch/arm/mach-rockchip/Kconfig| 6 +++---
  arch/arm/mach-rockchip/rk3308/Kconfig | 3 ---
  arch/arm/mach-rockchip/rk3568/Kconfig | 3 ---
  arch/arm/mach-rockchip/rk3588/Kconfig | 3 ---
  4 files changed, 3 insertions(+), 12 deletions(-)

diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
index 33a9f7a4dd4b..c9d8f9105083 100644
--- a/arch/arm/mach-rockchip/Kconfig
+++ b/arch/arm/mach-rockchip/Kconfig
@@ -667,9 +667,9 @@ config TPL_SYS_MALLOC_F_LEN
default 0x4000 if CUSTOM_SYS_INIT_SP_ADDR = 0x03f0
  
  config TEXT_BASE

-   default 0x6020 if SPL_TEXT_BASE = 0x6000
-   default 0x4020 if SPL_TEXT_BASE = 0x4000
-   default 0x0020 if SPL_TEXT_BASE = 0x
+   default 0x6080 if SPL_TEXT_BASE = 0x6000
+   default 0x4080 if SPL_TEXT_BASE = 0x4000
+   default 0x0080 if SPL_TEXT_BASE = 0x
  
  config SPL_TEXT_BASE

default 0x6000 if ROCKCHIP_RK3036 || ROCKCHIP_RK3066 || \
diff --git a/arch/arm/mach-rockchip/rk3308/Kconfig 
b/arch/arm/mach-rockchip/rk3308/Kconfig
index 06572d545f6e..b8d25c525424 100644
--- a/arch/arm/mach-rockchip/rk3308/Kconfig
+++ b/arch/arm/mach-rockchip/rk3308/Kconfig
@@ -17,9 +17,6 @@ config ROCKCHIP_STIMER_BASE
  config SYS_SOC
default "rk3308"
  
-config TEXT_BASE

-   default 0x0060
-
  source "board/rockchip/evb_rk3308/Kconfig"
  source "board/firefly/firefly-rk3308/Kconfig"
  
diff --git a/arch/arm/mach-rockchip/rk3568/Kconfig b/arch/arm/mach-rockchip/rk3568/Kconfig

index c589fd586993..a271782fac5c 100644
--- a/arch/arm/mach-rockchip/rk3568/Kconfig
+++ b/arch/arm/mach-rockchip/rk3568/Kconfig
@@ -71,9 +71,6 @@ config ROCKCHIP_STIMER_BASE
  config SYS_SOC
default "rk3568"
  
-config TEXT_BASE

-   default 0x00a0
-
  source "board/rockchip/evb_rk3568/Kconfig"
  source "board/anbernic/rgxx3_rk3566/Kconfig"
  source "board/hardkernel/odroid_m1/Kconfig"
diff --git a/arch/arm/mach-rockchip/rk3588/Kconfig 
b/arch/arm/mach-rockchip/rk3588/Kconfig
index efd192068ad1..1c6a85d07394 100644
--- a/arch/arm/mach-rockchip/rk3588/Kconfig
+++ b/arch/arm/mach-rockchip/rk3588/Kconfig
@@ -420,9 +420,6 @@ config ROCKCHIP_STIMER_BASE
  config SYS_SOC
default "rk3588"
  
-config TEXT_BASE

-   default 0x00a0
-
  source "board/armsom/sige7-rk3588/Kconfig"
  source "board/coolpi/genbook_cm5_rk3588/Kconfig"
  source "board/edgeble/neural-compute-module-6/Kconfig"


[PATCH v2 1/4] rockchip: Move TEXT_BASE to 8 MiB offset from start of DRAM

2025-04-05 Thread Jonas Karlman
Drop SoC specific TEXT_BASE and use a common TEXT_BASE for all SoCs.

Move the common TEXT_BASE to 8 MiB offset from start of DRAM to help
support RAM boot from maskrom introduced in next patch.

RAM boot from maskrom mode will expect the FIT payload to be located at
2 MiB offset from start or DRAM.

Signed-off-by: Jonas Karlman 
Tested-by: Arnaud Patard 
---
v2: Collect t-b tag
---
 arch/arm/mach-rockchip/Kconfig| 6 +++---
 arch/arm/mach-rockchip/rk3308/Kconfig | 3 ---
 arch/arm/mach-rockchip/rk3568/Kconfig | 3 ---
 arch/arm/mach-rockchip/rk3588/Kconfig | 3 ---
 4 files changed, 3 insertions(+), 12 deletions(-)

diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
index 33a9f7a4dd4b..c9d8f9105083 100644
--- a/arch/arm/mach-rockchip/Kconfig
+++ b/arch/arm/mach-rockchip/Kconfig
@@ -667,9 +667,9 @@ config TPL_SYS_MALLOC_F_LEN
default 0x4000 if CUSTOM_SYS_INIT_SP_ADDR = 0x03f0
 
 config TEXT_BASE
-   default 0x6020 if SPL_TEXT_BASE = 0x6000
-   default 0x4020 if SPL_TEXT_BASE = 0x4000
-   default 0x0020 if SPL_TEXT_BASE = 0x
+   default 0x6080 if SPL_TEXT_BASE = 0x6000
+   default 0x4080 if SPL_TEXT_BASE = 0x4000
+   default 0x0080 if SPL_TEXT_BASE = 0x
 
 config SPL_TEXT_BASE
default 0x6000 if ROCKCHIP_RK3036 || ROCKCHIP_RK3066 || \
diff --git a/arch/arm/mach-rockchip/rk3308/Kconfig 
b/arch/arm/mach-rockchip/rk3308/Kconfig
index 06572d545f6e..b8d25c525424 100644
--- a/arch/arm/mach-rockchip/rk3308/Kconfig
+++ b/arch/arm/mach-rockchip/rk3308/Kconfig
@@ -17,9 +17,6 @@ config ROCKCHIP_STIMER_BASE
 config SYS_SOC
default "rk3308"
 
-config TEXT_BASE
-   default 0x0060
-
 source "board/rockchip/evb_rk3308/Kconfig"
 source "board/firefly/firefly-rk3308/Kconfig"
 
diff --git a/arch/arm/mach-rockchip/rk3568/Kconfig 
b/arch/arm/mach-rockchip/rk3568/Kconfig
index c589fd586993..a271782fac5c 100644
--- a/arch/arm/mach-rockchip/rk3568/Kconfig
+++ b/arch/arm/mach-rockchip/rk3568/Kconfig
@@ -71,9 +71,6 @@ config ROCKCHIP_STIMER_BASE
 config SYS_SOC
default "rk3568"
 
-config TEXT_BASE
-   default 0x00a0
-
 source "board/rockchip/evb_rk3568/Kconfig"
 source "board/anbernic/rgxx3_rk3566/Kconfig"
 source "board/hardkernel/odroid_m1/Kconfig"
diff --git a/arch/arm/mach-rockchip/rk3588/Kconfig 
b/arch/arm/mach-rockchip/rk3588/Kconfig
index efd192068ad1..1c6a85d07394 100644
--- a/arch/arm/mach-rockchip/rk3588/Kconfig
+++ b/arch/arm/mach-rockchip/rk3588/Kconfig
@@ -420,9 +420,6 @@ config ROCKCHIP_STIMER_BASE
 config SYS_SOC
default "rk3588"
 
-config TEXT_BASE
-   default 0x00a0
-
 source "board/armsom/sige7-rk3588/Kconfig"
 source "board/coolpi/genbook_cm5_rk3588/Kconfig"
 source "board/edgeble/neural-compute-module-6/Kconfig"
-- 
2.49.0