Re: [RFC PATCH] spi: ich: Drop while loop in hardware sequencing erase case

2020-02-03 Thread Bin Meng
On Thu, Jan 30, 2020 at 10:16 AM Simon Glass wrote: > > Hi Wolfgang, > > On Tue, 14 Jan 2020 at 06:06, Wolfgang Wallner > wrote: > > > > When ich_spi_exec_op_hwseq() is called to erase a 4k block > > (opcode = SPINOR_OP_BE_4K), it expects to find a length value in > > op->data.nbytes, but that

Re: [RFC PATCH] spi: ich: Drop while loop in hardware sequencing erase case

2020-01-29 Thread Simon Glass
Hi Wolfgang, On Tue, 14 Jan 2020 at 06:06, Wolfgang Wallner wrote: > > When ich_spi_exec_op_hwseq() is called to erase a 4k block > (opcode = SPINOR_OP_BE_4K), it expects to find a length value in > op->data.nbytes, but that value is always 0. As a result, the while loop > is never executed and

[RFC PATCH] spi: ich: Drop while loop in hardware sequencing erase case

2020-01-14 Thread Wolfgang Wallner
When ich_spi_exec_op_hwseq() is called to erase a 4k block (opcode = SPINOR_OP_BE_4K), it expects to find a length value in op->data.nbytes, but that value is always 0. As a result, the while loop is never executed and no erase is carried out. Fix this by dropping the loop code entirely, only