Re: [U-Boot] [PATCH] MIPS: qemu_mips: Fix a build failure caused by missing asm/unaligned.h

2009-12-19 Thread Shinya Kuribayashi
On 12/18/09 10:06 PM, Stefan Roese wrote: Don't get me wrong. I'm not NACK'ing the patch. I'm just pointing out that it's different from the Linux version. I'm afraid 'LMO' needlessly makes you confused. Or am I missing something? Yes, LMO was confusing me. Sorry for that, and thanks for

[U-Boot] [PATCH] MIPS: qemu_mips: Fix a build failure caused by missing asm/unaligned.h

2009-12-18 Thread Shinya Kuribayashi
make -C lib_generic/ zlib.c:31:27: error: asm/unaligned.h: No such file or directory zlib.c: In function 'inflate_fast': zlib.c:641: warning: implicit declaration of function 'get_unaligned' make[1]: *** [zlib.o] Error 1 make[1]: Leaving directory `/home/skuribay/git/u-boot.git/lib_generic' make:

Re: [U-Boot] [PATCH] MIPS: qemu_mips: Fix a build failure caused by missing asm/unaligned.h

2009-12-18 Thread Himanshu Chauhan
Shinya Kuribayashi wrote: make -C lib_generic/ zlib.c:31:27: error: asm/unaligned.h: No such file or directory zlib.c: In function 'inflate_fast': zlib.c:641: warning: implicit declaration of function 'get_unaligned' make[1]: *** [zlib.o] Error 1 make[1]: Leaving directory

Re: [U-Boot] [PATCH] MIPS: qemu_mips: Fix a build failure caused by missing asm/unaligned.h

2009-12-18 Thread Himanshu Chauhan
Stefan Roese wrote: On Friday 18 December 2009 11:32:13 Shinya Kuribayashi wrote: make -C lib_generic/ zlib.c:31:27: error: asm/unaligned.h: No such file or directory zlib.c: In function 'inflate_fast': zlib.c:641: warning: implicit declaration of function 'get_unaligned' make[1]: ***

Re: [U-Boot] [PATCH] MIPS: qemu_mips: Fix a build failure caused by missing asm/unaligned.h

2009-12-18 Thread Stefan Roese
On Friday 18 December 2009 13:04:59 Himanshu Chauhan wrote: Import relevant header file from LMO tree (slightly modified to U-Boot). Why don't you import this file from the Linux tree? This should work without modifications. And that's what we've done for PPC and ARM as well. Cheers,

Re: [U-Boot] [PATCH] MIPS: qemu_mips: Fix a build failure caused by missing asm/unaligned.h

2009-12-18 Thread Stefan Roese
On Friday 18 December 2009 13:20:56 Stefan Roese wrote: I think thats what it is. Both are same. No, not exactly. They're nearly identical. But there are differences. Not sure if these differences are important though. Don't get me wrong. I'm not NACK'ing the patch. I'm just pointing out

Re: [U-Boot] [PATCH] MIPS: qemu_mips: Fix a build failure caused by missing asm/unaligned.h

2009-12-18 Thread Himanshu Chauhan
Stefan Roese wrote: On Friday 18 December 2009 13:20:56 Stefan Roese wrote: I think thats what it is. Both are same. No, not exactly. They're nearly identical. But there are differences. Not sure if these differences are important though. Don't get me wrong. I'm not NACK'ing the patch. I'm

Re: [U-Boot] [PATCH] MIPS: qemu_mips: Fix a build failure caused by missing asm/unaligned.h

2009-12-18 Thread Stefan Roese
On Friday 18 December 2009 14:02:01 Shinya Kuribayashi wrote: I think thats what it is. Both are same. No, not exactly. They're nearly identical. But there are differences. Not sure if these differences are important though. Hm, the original header is (lmo = linux-mips.org):

Re: [U-Boot] [PATCH] MIPS: qemu_mips: Fix a build failure caused by missing asm/unaligned.h

2009-12-18 Thread Shinya Kuribayashi
Stefan Roese wrote: On Friday 18 December 2009 13:04:59 Himanshu Chauhan wrote: Import relevant header file from LMO tree (slightly modified to U-Boot). Why don't you import this file from the Linux tree? This should work without modifications. And that's what we've done for PPC and ARM as

Re: [U-Boot] [PATCH] MIPS: qemu_mips: Fix a build failure caused by missing asm/unaligned.h

2009-12-18 Thread Himanshu Chauhan
Shinya Kuribayashi wrote: make -C lib_generic/ zlib.c:31:27: error: asm/unaligned.h: No such file or directory zlib.c: In function 'inflate_fast': zlib.c:641: warning: implicit declaration of function 'get_unaligned' make[1]: *** [zlib.o] Error 1 make[1]: Leaving directory

Re: [U-Boot] [PATCH] MIPS: qemu_mips: Fix a build failure caused by missing asm/unaligned.h

2009-12-18 Thread Shinya Kuribayashi
Himanshu Chauhan wrote: Himanshu Chauhan wrote: I see that in include directory asm points to asm-mips. Inside asm-mips there is another link arch-arch-mips which is a dead link. THere is no directory named arch-mips there. This is another topic, let's ignore here. Is arch-mips scheduled

Re: [U-Boot] [PATCH] MIPS: qemu_mips: Fix a build failure caused by missing asm/unaligned.h

2009-12-18 Thread Himanshu Chauhan
Wolfgang Denk wrote: Dear Himanshu Chauhan, In message 4b2b79a9.1000...@symmetricore.com you wrote: Stefan Roese wrote: On Friday 18 December 2009 13:20:56 Stefan Roese wrote: I think thats what it is. Both are same. No, not exactly. They're nearly identical. But there are differences. Not