Re: [U-Boot] [PATCH] TI: Davinci: NAND Driver Cleanup

2010-03-16 Thread Nick Thompson
On 14/03/10 21:14, s-paul...@ti.com wrote: From: Cyril Chemparathy cy...@ti.com Modified to use IO accessor routines consistently. Eliminated volatile usage to keep checkpatch.pl happy. Patch was tested on DM355, DM365 and DM6446 EVMs Signed-off-by: Cyril Chemparathy cy...@ti.com

Re: [U-Boot] [PATCH] TI: Davinci: NAND Driver Cleanup

2010-03-16 Thread Chemparathy, Cyril
Hi Scott, Configuring for davinci_schmoogie board... ... Should be lowercase? Thank you. I will be sending out a v2 shortly, and this time around all 8 davinci based boards build fine. Also, any particular reason to use the raw version of the accessors? Please correct me if I am wrong

Re: [U-Boot] [PATCH] TI: Davinci: NAND Driver Cleanup

2010-03-16 Thread Scott Wood
Chemparathy, Cyril wrote: Please correct me if I am wrong here, but my understanding is that the raw variants are for native-endian access, while the non-raw ones could potentially force little-endian conversions for PCI. The non-raw ones also provide ordering on some architectures, though I

Re: [U-Boot] [PATCH] TI: Davinci: NAND Driver Cleanup

2010-03-15 Thread Scott Wood
On Sun, Mar 14, 2010 at 05:14:31PM -0400, s-paul...@ti.com wrote: - emif_regs-AB1CR = acfg1; /* CS2 */ + __raw_writel(acfg1, emif_regs-AB1CR); /* CS2 */ Configuring for davinci_schmoogie board... davinci_nand.c: In function ‘nand_flash_init’: davinci_nand.c:586: error: ‘struct

[U-Boot] [PATCH] TI: Davinci: NAND Driver Cleanup

2010-03-14 Thread s-paulraj
From: Cyril Chemparathy cy...@ti.com Modified to use IO accessor routines consistently. Eliminated volatile usage to keep checkpatch.pl happy. Patch was tested on DM355, DM365 and DM6446 EVMs Signed-off-by: Cyril Chemparathy cy...@ti.com Tested-by: Sandeep Paulraj s-paul...@ti.com ---