Re: [U-Boot] [PATCH] cmd/tpm_test: Fix misleading code indentation

[Simon Glass]

On 17 October 2016 at 16:17, Simon Glass  wrote:
> On 16 October 2016 at 09:13, Stefan Brüns  
> wrote:
>> GCC 6.2 reasonably complains about the current code:
>>
>> ../cmd/tpm_test.c: In function ‘do_tpmtest’:
>> ../cmd/tpm_test.c:540:3: warning: this ‘for’ clause does not guard... 
>> [-Wmisleading-indentation]
>>for (i = 0; i < argc; i++)
>>^~~
>> ../cmd/tpm_test.c:542:4: note: ...this statement, but the latter is 
>> misleadingly indented as if it is guarded by the ‘for’
>> printf("\n--\n");
>> ^~
>>
>> Signed-off-by: Stefan Brüns 
>> ---
>>  cmd/tpm_test.c | 11 +--
>>  1 file changed, 5 insertions(+), 6 deletions(-)
>
> Reviewed-by: Simon Glass 

Updated to drop the C99 variable decl.

Applied to u-boot-dm/next, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] cmd/tpm_test: Fix misleading code indentation

[Simon Glass]

On 16 October 2016 at 09:13, Stefan Brüns  wrote:
> GCC 6.2 reasonably complains about the current code:
>
> ../cmd/tpm_test.c: In function ‘do_tpmtest’:
> ../cmd/tpm_test.c:540:3: warning: this ‘for’ clause does not guard... 
> [-Wmisleading-indentation]
>for (i = 0; i < argc; i++)
>^~~
> ../cmd/tpm_test.c:542:4: note: ...this statement, but the latter is 
> misleadingly indented as if it is guarded by the ‘for’
> printf("\n--\n");
> ^~
>
> Signed-off-by: Stefan Brüns 
> ---
>  cmd/tpm_test.c | 11 +--
>  1 file changed, 5 insertions(+), 6 deletions(-)

Reviewed-by: Simon Glass 
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] cmd/tpm_test: Fix misleading code indentation

[Stefan Brüns]

GCC 6.2 reasonably complains about the current code:

../cmd/tpm_test.c: In function ‘do_tpmtest’:
../cmd/tpm_test.c:540:3: warning: this ‘for’ clause does not guard... 
[-Wmisleading-indentation]
   for (i = 0; i < argc; i++)
   ^~~
../cmd/tpm_test.c:542:4: note: ...this statement, but the latter is 
misleadingly indented as if it is guarded by the ‘for’
printf("\n--\n");
^~

Signed-off-by: Stefan Brüns 
---
 cmd/tpm_test.c | 11 +--
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/cmd/tpm_test.c b/cmd/tpm_test.c
index 65332d1..4af4d71 100644
--- a/cmd/tpm_test.c
+++ b/cmd/tpm_test.c
@@ -534,13 +534,12 @@ static int do_tpmtest(cmd_tbl_t *cmdtp, int flag, int 
argc, char * const argv[])
cmd_tbl_t *c;
 
printf("argc = %d, argv = ", argc);
-   do {
-   int i = 0;
 
-   for (i = 0; i < argc; i++)
-   printf(" %s", argv[i]);
-   printf("\n--\n");
-   } while (0);
+   for (int i = 0; i < argc; i++)
+   printf(" %s", argv[i]);
+
+   printf("\n--\n");
+
argc--;
argv++;
c = find_cmd_tbl(argv[0], cmd_cros_tpm_sub,
-- 
2.10.1

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot