Re: [U-Boot] [PATCH] sandboxfs: Fix resource leak

2016-10-25 Thread Simon Glass 
On 17 October 2016 at 19:54, Simon Glass  wrote:
> On 17 October 2016 at 19:09, Tom Rini  wrote:
>> Now that we free resources in sandbox_fs_ls Coverity is letting us know
>> that in some cases we might leak.  So in case of error we should still
>> let os_dirent_free free anything that was allocated.
>>
>> Fixes: 86167089b71c ("sandbox/fs: Free memory allocated by os_dirent_ls")
>> Reported-by: Coverity (CID: 153450)
>> Cc: Stefan Brüns 
>> Cc: Simon Glass 
>> Signed-off-by: Tom Rini 
>> ---
>>  fs/sandbox/sandboxfs.c | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> Reviewed-by: Simon Glass 

Applied to u-boot-dm/next, thanks
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] sandboxfs: Fix resource leak

2016-10-17 Thread Simon Glass 
On 17 October 2016 at 19:09, Tom Rini  wrote:
> Now that we free resources in sandbox_fs_ls Coverity is letting us know
> that in some cases we might leak.  So in case of error we should still
> let os_dirent_free free anything that was allocated.
>
> Fixes: 86167089b71c ("sandbox/fs: Free memory allocated by os_dirent_ls")
> Reported-by: Coverity (CID: 153450)
> Cc: Stefan Brüns 
> Cc: Simon Glass 
> Signed-off-by: Tom Rini 
> ---
>  fs/sandbox/sandboxfs.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Reviewed-by: Simon Glass 
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] sandboxfs: Fix resource leak

2016-10-17 Thread Tom Rini 
Now that we free resources in sandbox_fs_ls Coverity is letting us know
that in some cases we might leak.  So in case of error we should still
let os_dirent_free free anything that was allocated.

Fixes: 86167089b71c ("sandbox/fs: Free memory allocated by os_dirent_ls")
Reported-by: Coverity (CID: 153450)
Cc: Stefan Brüns 
Cc: Simon Glass 
Signed-off-by: Tom Rini 
---
 fs/sandbox/sandboxfs.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/sandbox/sandboxfs.c b/fs/sandbox/sandboxfs.c
index cd10fd6845fb..ca8026133708 100644
--- a/fs/sandbox/sandboxfs.c
+++ b/fs/sandbox/sandboxfs.c
@@ -88,15 +88,16 @@ int sandbox_fs_ls(const char *dirname)
 
ret = os_dirent_ls(dirname, );
if (ret)
-   return ret;
+   goto out;
 
for (node = head; node; node = node->next) {
printf("%s %10lu %s\n", os_dirent_get_typename(node->type),
   node->size, node->name);
}
+out:
os_dirent_free(head);
 
-   return 0;
+   return ret;
 }
 
 int sandbox_fs_exists(const char *filename)
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot