Re: [U-Boot] [PATCH 0/2] Add support for Amlogic Meson MMC controller

2016-05-21 Thread Robert Gadsdon
On 05/20/2016 12:34 PM, Carlo Caione wrote:
> On 20/05/16 11:58, Robert Gadsdon wrote:
>> On 05/20/2016 01:07 AM, Carlo Caione wrote:
>>> On 20/05/16 08:27, Carlo Caione wrote:
 On 19/05/16 21:51, Robert Gadsdon wrote:
> Applied this on my Odroid C2, and it worked OK when installed on the
> SDcard, but failed when installed on the eMMC module:
>>> Oh, reading this again you meant that you put u-boot directly on the
>>> eMMC? Ok then, something is wrong when using the driver with the eMMC.
>>>
>>> Yes, I installed it directly on the eMMC, using the micro-sd adapter,
>>> and following the same instructions as for the SDcard..
> Could you try with this patch?
>
> diff --git a/board/hardkernel/odroid-c2/odroid-c2.c
> b/board/hardkernel/odroid-c2/odroid-c2.c
> index 34b9a95..ab78328 100644
> --- a/board/hardkernel/odroid-c2/odroid-c2.c
> +++ b/board/hardkernel/odroid-c2/odroid-c2.c
> @@ -80,6 +80,11 @@ U_BOOT_DEVICE(meson_mmc) = {
> .platdata = &gxbb_sd_platdata[CONFIG_MMC_MESON_SD_PORT],
>};
> 
> +U_BOOT_DEVICE(meson_emmc) = {
> +   .name = "meson_mmc",
> +   .platdata = &gxbb_sd_platdata[2],
> +};
> +
>  static void meson_mmc_pinmux_setup(unsigned int port)
>   {
>   switch (port) {
>
> Thanks,

Patch applied, and now the eMMC is detected OK:

=> mmc info
Device: 
Manufacturer ID: 15
OEM: 100
Name: BGND3
Tran Speed: 5200
Rd Block Len: 512
MMC version 5.0
High Capacity: Yes
Capacity: 29.1 GiB
Bus Width: 8-bit
Erase Group Size: 512 KiB
HC WP Group Size: 8 MiB
User Capacity: 29.1 GiB WRREL
Boot Capacity: 4 MiB ENH
RPMB Capacity: 4 MiB ENH

...  And I can load/boot the Kernel (as far as the /dev/mmc... prompt..)

Thanks!

Robert Gadsdon.
___
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 0/2] Add support for Amlogic Meson MMC controller

2016-05-20 Thread Carlo Caione
On 20/05/16 11:58, Robert Gadsdon wrote:
> On 05/20/2016 01:07 AM, Carlo Caione wrote:
> > On 20/05/16 08:27, Carlo Caione wrote:
> >> On 19/05/16 21:51, Robert Gadsdon wrote:
> >>> Applied this on my Odroid C2, and it worked OK when installed on the
> >>> SDcard, but failed when installed on the eMMC module:
> > 
> > Oh, reading this again you meant that you put u-boot directly on the
> > eMMC? Ok then, something is wrong when using the driver with the eMMC.
> > 
> 
> Yes, I installed it directly on the eMMC, using the micro-sd adapter,
> and following the same instructions as for the SDcard..

Could you try with this patch?

diff --git a/board/hardkernel/odroid-c2/odroid-c2.c
b/board/hardkernel/odroid-c2/odroid-c2.c
index 34b9a95..ab78328 100644
--- a/board/hardkernel/odroid-c2/odroid-c2.c
+++ b/board/hardkernel/odroid-c2/odroid-c2.c
@@ -80,6 +80,11 @@ U_BOOT_DEVICE(meson_mmc) = {
.platdata = &gxbb_sd_platdata[CONFIG_MMC_MESON_SD_PORT],
 };
  
  +U_BOOT_DEVICE(meson_emmc) = {
  +   .name = "meson_mmc",
  +   .platdata = &gxbb_sd_platdata[2],
  +};
  +
   static void meson_mmc_pinmux_setup(unsigned int port)
{
switch (port) {

Thanks,

-- 
Carlo Caione
___
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 0/2] Add support for Amlogic Meson MMC controller

2016-05-20 Thread Robert Gadsdon
On 05/20/2016 01:07 AM, Carlo Caione wrote:
> On 20/05/16 08:27, Carlo Caione wrote:
>> On 19/05/16 21:51, Robert Gadsdon wrote:
>>> Applied this on my Odroid C2, and it worked OK when installed on the
>>> SDcard, but failed when installed on the eMMC module:
> 
> Oh, reading this again you meant that you put u-boot directly on the
> eMMC? Ok then, something is wrong when using the driver with the eMMC.
> 

Yes, I installed it directly on the eMMC, using the micro-sd adapter,
and following the same instructions as for the SDcard..

Robert Gadsdon.

___
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 0/2] Add support for Amlogic Meson MMC controller

2016-05-20 Thread Carlo Caione
On 19/05/16 21:51, Robert Gadsdon wrote:
> Applied this on my Odroid C2, and it worked OK when installed on the
> SDcard, but failed when installed on the eMMC module:
> 
> => version
> U-Boot 2016.05-rc3 (May 14 2016 - 21:06:28 -0700) odroid-c2
> aarch64-linux-gnu-gcc (GCC) 5.3.1 20160212 (Red Hat Cross 5.3.1-2)
> GNU ld version 2.26.20160125
> 
> => mmc info
> Card did not respond to voltage select!

Yes, this is expected since the muxing in the board file is only
enabling the SDcard. Could you try to set the correct muxing also for
the eMMC and check again?

Unfortunately I don't have an eMMC for the Odroid-C2 to check this out.
I'll try to prepare a board file also for the P20x so I can test this
better.

Thank you for testing this BTW.

Cheers,

-- 
Carlo Caione
___
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 0/2] Add support for Amlogic Meson MMC controller

2016-05-20 Thread Carlo Caione
On 20/05/16 08:27, Carlo Caione wrote:
> On 19/05/16 21:51, Robert Gadsdon wrote:
> > Applied this on my Odroid C2, and it worked OK when installed on the
> > SDcard, but failed when installed on the eMMC module:

Oh, reading this again you meant that you put u-boot directly on the
eMMC? Ok then, something is wrong when using the driver with the eMMC.

I'll try to boot it on the P20x and check what's wrong with it.

Thanks,

-- 
Carlo Caione
___
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 0/2] Add support for Amlogic Meson MMC controller

2016-05-19 Thread Robert Gadsdon
Applied this on my Odroid C2, and it worked OK when installed on the
SDcard, but failed when installed on the eMMC module:

=> version
U-Boot 2016.05-rc3 (May 14 2016 - 21:06:28 -0700) odroid-c2
aarch64-linux-gnu-gcc (GCC) 5.3.1 20160212 (Red Hat Cross 5.3.1-2)
GNU ld version 2.26.20160125

=> mmc info
Card did not respond to voltage select!

Robert Gadsdon.

___
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH 0/2] Add support for Amlogic Meson MMC controller

2016-05-12 Thread Carlo Caione
From: Carlo Caione 

This patchset is a port / rewrite of the Amlogic driver shipped in the SDK for
the Meson GXBB (S905) platform. It has been tested on the Hardkernel Odroid-C2
board.

The driver is enabled using U_BOOT_DEVICE in the board file because there is no
MMC driver yet in the linux kernel.

This patchset depends on the basic support for Amlogic S905 SoCs written by
Beniamino[1]

[1] https://www.mail-archive.com/[email protected]/msg212188.html

Carlo Caione (2):
  mmc: Add Amlogic Meson driver
  arm: amlogic: Enable MMC driver on Odroid-C2

 arch/arm/include/asm/arch-meson/sd_emmc.h | 109 +++
 board/hardkernel/odroid-c2/odroid-c2.c|  42 
 configs/odroid-c2_defconfig   |   5 +
 drivers/mmc/Makefile  |   1 +
 drivers/mmc/meson_mmc.c   | 305 ++
 include/configs/odroid-c2.h   |   7 +
 6 files changed, 469 insertions(+)
 create mode 100644 arch/arm/include/asm/arch-meson/sd_emmc.h
 create mode 100644 drivers/mmc/meson_mmc.c

-- 
2.7.4

___
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot