Re: [U-Boot] [PATCH 1/1] configs: sunxi: enable BLK, DM_MMC for Bananapi
On Tue, Mar 13, 2018 at 08:09:18PM +0100, Heinrich Schuchardt wrote: > On 03/13/2018 07:41 PM, Maxime Ripard wrote: > > Hi, > > > > On Tue, Mar 13, 2018 at 06:37:23PM +0100, Heinrich Schuchardt wrote: > >> doc/driver-model/MIGRATION.txt requires to move block drivers to the > >> the driver model by v2018.05 > >> > >> So make the switch for the Bananapi block drivers. > >> > >> Signed-off-by: Heinrich Schuchardt > >> --- > >> This patch depends on > >> mmc: sunxi: support cd-inverted > >> https://lists.denx.de/pipermail/u-boot/2018-February/319309.html > >> which has been applied to u-boot-sunxi/master. > >> --- > >> configs/Bananapi_defconfig | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/configs/Bananapi_defconfig b/configs/Bananapi_defconfig > >> index 52650448091..300110a5cab 100644 > >> --- a/configs/Bananapi_defconfig > >> +++ b/configs/Bananapi_defconfig > >> @@ -17,6 +17,8 @@ CONFIG_SPL_I2C_SUPPORT=y > >> # CONFIG_SPL_EFI_PARTITION is not set > >> CONFIG_NETCONSOLE=y > >> CONFIG_SCSI_AHCI=y > >> +CONFIG_BLK=y > >> +CONFIG_DM_MMC=y > > > > Please switch all the Allwinner boards at once. > > this is the board I possess and have tested. Who would do the testing if > I switch all 127 boards? The alternative you suggest is that you break 126 boards in the next release. This is core changes, and it should have a minimal impact on the boards if one work. > I guess the best way to switch all SUNXI boards would be to make > CONFIG_SUNXI select CONFIG_DM, CONFIG_BLK, and CONFIG_DM_MMC. Imply it at least, yeah. Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/1] configs: sunxi: enable BLK, DM_MMC for Bananapi
On 03/13/2018 07:41 PM, Maxime Ripard wrote: > Hi, > > On Tue, Mar 13, 2018 at 06:37:23PM +0100, Heinrich Schuchardt wrote: >> doc/driver-model/MIGRATION.txt requires to move block drivers to the >> the driver model by v2018.05 >> >> So make the switch for the Bananapi block drivers. >> >> Signed-off-by: Heinrich Schuchardt >> --- >> This patch depends on >> mmc: sunxi: support cd-inverted >> https://lists.denx.de/pipermail/u-boot/2018-February/319309.html >> which has been applied to u-boot-sunxi/master. >> --- >> configs/Bananapi_defconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/configs/Bananapi_defconfig b/configs/Bananapi_defconfig >> index 52650448091..300110a5cab 100644 >> --- a/configs/Bananapi_defconfig >> +++ b/configs/Bananapi_defconfig >> @@ -17,6 +17,8 @@ CONFIG_SPL_I2C_SUPPORT=y >> # CONFIG_SPL_EFI_PARTITION is not set >> CONFIG_NETCONSOLE=y >> CONFIG_SCSI_AHCI=y >> +CONFIG_BLK=y >> +CONFIG_DM_MMC=y > > Please switch all the Allwinner boards at once. Hello Maxime, this is the board I possess and have tested. Who would do the testing if I switch all 127 boards? I guess the best way to switch all SUNXI boards would be to make CONFIG_SUNXI select CONFIG_DM, CONFIG_BLK, and CONFIG_DM_MMC. @Simon Looking at doc/driver-model/MIGRATION.txt would it make sense to set: CONFIG_DM_MMC default yes, depends on CONFIG_MMC. CONFIG_DM_SCSI default yes, depends on CONFIG_SCSI. ... CONFIG_BLK selected by CONFIG_DM_MMC | CONFIG_DM_SCSI | CONFIG_DM selected by CONFIG_BLK Best regards Heinrich ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/1] configs: sunxi: enable BLK, DM_MMC for Bananapi
Hi, On Tue, Mar 13, 2018 at 06:37:23PM +0100, Heinrich Schuchardt wrote: > doc/driver-model/MIGRATION.txt requires to move block drivers to the > the driver model by v2018.05 > > So make the switch for the Bananapi block drivers. > > Signed-off-by: Heinrich Schuchardt > --- > This patch depends on > mmc: sunxi: support cd-inverted > https://lists.denx.de/pipermail/u-boot/2018-February/319309.html > which has been applied to u-boot-sunxi/master. > --- > configs/Bananapi_defconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/configs/Bananapi_defconfig b/configs/Bananapi_defconfig > index 52650448091..300110a5cab 100644 > --- a/configs/Bananapi_defconfig > +++ b/configs/Bananapi_defconfig > @@ -17,6 +17,8 @@ CONFIG_SPL_I2C_SUPPORT=y > # CONFIG_SPL_EFI_PARTITION is not set > CONFIG_NETCONSOLE=y > CONFIG_SCSI_AHCI=y > +CONFIG_BLK=y > +CONFIG_DM_MMC=y Please switch all the Allwinner boards at once. Thanks! Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH 1/1] configs: sunxi: enable BLK, DM_MMC for Bananapi
doc/driver-model/MIGRATION.txt requires to move block drivers to the the driver model by v2018.05 So make the switch for the Bananapi block drivers. Signed-off-by: Heinrich Schuchardt --- This patch depends on mmc: sunxi: support cd-inverted https://lists.denx.de/pipermail/u-boot/2018-February/319309.html which has been applied to u-boot-sunxi/master. --- configs/Bananapi_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/Bananapi_defconfig b/configs/Bananapi_defconfig index 52650448091..300110a5cab 100644 --- a/configs/Bananapi_defconfig +++ b/configs/Bananapi_defconfig @@ -17,6 +17,8 @@ CONFIG_SPL_I2C_SUPPORT=y # CONFIG_SPL_EFI_PARTITION is not set CONFIG_NETCONSOLE=y CONFIG_SCSI_AHCI=y +CONFIG_BLK=y +CONFIG_DM_MMC=y CONFIG_ETH_DESIGNWARE=y CONFIG_RGMII=y CONFIG_SUN7I_GMAC=y -- 2.11.0 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot