Re: [U-Boot] [PATCH 1/4] phy: add support for bcm6358 usbh phy

[Daniel Schwierzeck]

On 04.02.2018 11:19, Álvaro Fernández Rojas wrote:
> Signed-off-by: Álvaro Fernández Rojas 
> ---
>  drivers/phy/Kconfig|  6 +++
>  drivers/phy/Makefile   |  1 +
>  drivers/phy/bcm6358-usbh-phy.c | 94 
> ++
>  3 files changed, 101 insertions(+)
>  create mode 100644 drivers/phy/bcm6358-usbh-phy.c
> 

Reviewed-by: Daniel Schwierzeck 

-- 
- Daniel



signature.asc
Description: OpenPGP digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 1/4] phy: add support for bcm6358 usbh phy

[Álvaro Fernández Rojas]

Signed-off-by: Álvaro Fernández Rojas 
---
 drivers/phy/Kconfig|  6 +++
 drivers/phy/Makefile   |  1 +
 drivers/phy/bcm6358-usbh-phy.c | 94 ++
 3 files changed, 101 insertions(+)
 create mode 100644 drivers/phy/bcm6358-usbh-phy.c

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index cec2130c05..43fb4c9bfd 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -65,6 +65,12 @@ config BCM6348_USBH_PHY
help
  Support for the Broadcom MIPS BCM6348 USBH PHY.
 
+config BCM6358_USBH_PHY
+   bool "BCM6358 USBH PHY support"
+   depends on PHY && ARCH_BMIPS
+   help
+ Support for the Broadcom MIPS BCM6358 USBH PHY.
+
 config PIPE3_PHY
bool "Support omap's PIPE3 PHY"
depends on PHY && ARCH_OMAP2PLUS
diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile
index 06e01e86eb..04843fd49b 100644
--- a/drivers/phy/Makefile
+++ b/drivers/phy/Makefile
@@ -8,6 +8,7 @@
 obj-$(CONFIG_$(SPL_)PHY) += phy-uclass.o
 obj-$(CONFIG_$(SPL_)NOP_PHY) += nop-phy.o
 obj-$(CONFIG_BCM6348_USBH_PHY) += bcm6348-usbh-phy.o
+obj-$(CONFIG_BCM6358_USBH_PHY) += bcm6358-usbh-phy.o
 obj-$(CONFIG_PHY_SANDBOX) += sandbox-phy.o
 obj-$(CONFIG_$(SPL_)PIPE3_PHY) += ti-pipe3-phy.o
 obj-$(CONFIG_STI_USB_PHY) += sti_usb_phy.o
diff --git a/drivers/phy/bcm6358-usbh-phy.c b/drivers/phy/bcm6358-usbh-phy.c
new file mode 100644
index 00..9583717a8c
--- /dev/null
+++ b/drivers/phy/bcm6358-usbh-phy.c
@@ -0,0 +1,94 @@
+/*
+ * Copyright (C) 2018 Álvaro Fernández Rojas 
+ *
+ * Derived from linux/arch/mips/bcm63xx/usb-common.c:
+ * Copyright 2008 Maxime Bizon 
+ * Copyright 2013 Florian Fainelli 
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+/* USBH Swap Control register */
+#define USBH_SWAP_REG  0x00
+#define USBH_SWAP_OHCI_DATABIT(0)
+#define USBH_SWAP_OHCI_ENDIAN  BIT(1)
+#define USBH_SWAP_EHCI_DATABIT(3)
+#define USBH_SWAP_EHCI_ENDIAN  BIT(4)
+
+/* USBH Test register */
+#define USBH_TEST_REG  0x24
+#define USBH_TEST_PORT_CTL 0x1c0020
+
+struct bcm6358_usbh_priv {
+   void __iomem *regs;
+};
+
+static int bcm6358_usbh_init(struct phy *phy)
+{
+   struct bcm6358_usbh_priv *priv = dev_get_priv(phy->dev);
+
+   /* configure to work in native cpu endian */
+   clrsetbits_be32(priv->regs + USBH_SWAP_REG,
+   USBH_SWAP_EHCI_ENDIAN | USBH_SWAP_OHCI_ENDIAN,
+   USBH_SWAP_EHCI_DATA | USBH_SWAP_OHCI_DATA);
+
+   /* test port control */
+   writel_be(USBH_TEST_PORT_CTL, priv->regs + USBH_TEST_REG);
+
+   return 0;
+}
+
+static struct phy_ops bcm6358_usbh_ops = {
+   .init = bcm6358_usbh_init,
+};
+
+static const struct udevice_id bcm6358_usbh_ids[] = {
+   { .compatible = "brcm,bcm6358-usbh" },
+   { /* sentinel */ }
+};
+
+static int bcm6358_usbh_probe(struct udevice *dev)
+{
+   struct bcm6358_usbh_priv *priv = dev_get_priv(dev);
+   struct reset_ctl rst_ctl;
+   fdt_addr_t addr;
+   fdt_size_t size;
+   int ret;
+
+   addr = devfdt_get_addr_size_index(dev, 0, );
+   if (addr == FDT_ADDR_T_NONE)
+   return -EINVAL;
+
+   priv->regs = ioremap(addr, size);
+
+   /* perform reset */
+   ret = reset_get_by_index(dev, 0, _ctl);
+   if (ret < 0)
+   return ret;
+
+   ret = reset_deassert(_ctl);
+   if (ret < 0)
+   return ret;
+
+   ret = reset_free(_ctl);
+   if (ret < 0)
+   return ret;
+
+   return 0;
+}
+
+U_BOOT_DRIVER(bcm6358_usbh) = {
+   .name = "bcm6358-usbh",
+   .id = UCLASS_PHY,
+   .of_match = bcm6358_usbh_ids,
+   .ops = _usbh_ops,
+   .priv_auto_alloc_size = sizeof(struct bcm6358_usbh_priv),
+   .probe = bcm6358_usbh_probe,
+};
-- 
2.11.0

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot