Re: [U-Boot] [PATCH 2/2] arm: socfpga: use imply instead of select where applicable

[Lukasz Majewski]

On Tue, 13 Feb 2018 06:34:14 +0100
Simon Goldschmidt  wrote:

> Kconfig should only 'select' features that are required for an arch.
> Standard features that can be disabled without breaking board support
> should use 'imply' instead, to allow users to disable it.
> 
> These options are changed for mach-socfpga:
> - DM_SPI & DM_SPI_FLASH: only required with QSPI support enabled
> - SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION: the boot rom supports a
>   partitionless mode also, where SPL is located at address 0
> - HW_WATCHDOG: while all mainline board defconfigs use it, U-Boot
>   should still work without it.
> 
> Signed-off-by: Simon Goldschmidt 
> ---
> 
>  arch/arm/Kconfig | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index b4c79d6499..5edd67c471 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -699,17 +699,17 @@ config ARCH_SOCFPGA
>   select OF_CONTROL
>   select SPL_OF_CONTROL
>   select DM
> - select DM_SPI_FLASH
> - select DM_SPI
>   select ENABLE_ARM_SOC_BOOT0_HOOK
> - select HW_WATCHDOG
>   select ARCH_EARLY_INIT_R
>   select ARCH_MISC_INIT
> - select SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION
>   select SYS_THUMB_BUILD
>   imply CMD_MTDPARTS
>   imply CRC32_VERIFY
> + imply DM_SPI
> + imply DM_SPI_FLASH
>   imply FAT_WRITE
> + imply HW_WATCHDOG
> + imply SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION
>  
>  config ARCH_SUNXI
>   bool "Support sunxi (Allwinner) SoCs"

Reviewed-by: Lukasz Majewski 


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de


pgp2cCU19YDML.pgp
Description: OpenPGP digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 2/2] arm: socfpga: use imply instead of select where applicable

[Simon Goldschmidt]

Kconfig should only 'select' features that are required for an arch.
Standard features that can be disabled without breaking board support
should use 'imply' instead, to allow users to disable it.

These options are changed for mach-socfpga:
- DM_SPI & DM_SPI_FLASH: only required with QSPI support enabled
- SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION: the boot rom supports a
  partitionless mode also, where SPL is located at address 0
- HW_WATCHDOG: while all mainline board defconfigs use it, U-Boot
  should still work without it.

Signed-off-by: Simon Goldschmidt 
---

 arch/arm/Kconfig | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index b4c79d6499..5edd67c471 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -699,17 +699,17 @@ config ARCH_SOCFPGA
select OF_CONTROL
select SPL_OF_CONTROL
select DM
-   select DM_SPI_FLASH
-   select DM_SPI
select ENABLE_ARM_SOC_BOOT0_HOOK
-   select HW_WATCHDOG
select ARCH_EARLY_INIT_R
select ARCH_MISC_INIT
-   select SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION
select SYS_THUMB_BUILD
imply CMD_MTDPARTS
imply CRC32_VERIFY
+   imply DM_SPI
+   imply DM_SPI_FLASH
imply FAT_WRITE
+   imply HW_WATCHDOG
+   imply SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION
 
 config ARCH_SUNXI
bool "Support sunxi (Allwinner) SoCs"
-- 
2.14.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot