Re: [U-Boot] [PATCH 2/2] rk3399: move the USB_XHCI_ROCKCHIP into Kconfig

2016-09-22 Thread Simon Glass
Hi Kever,

On 20 September 2016 at 21:35, Kever Yang  wrote:
> Move USB_XHCI_ROCKCHIP define from soc header file into board defconfig.
>
> Signed-off-by: Kever Yang 
> ---
>
>  configs/evb-rk3399_defconfig| 2 ++
>  include/configs/rk3399_common.h | 4 
>  2 files changed, 2 insertions(+), 4 deletions(-)

I've squashed part of this into the offending patch, thanks.

We cannot put CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS into the defconfig as
it is not in Kconfig yet.

>
> diff --git a/configs/evb-rk3399_defconfig b/configs/evb-rk3399_defconfig
> index 6468620..4ec2e7b 100644
> --- a/configs/evb-rk3399_defconfig
> +++ b/configs/evb-rk3399_defconfig
> @@ -58,6 +58,8 @@ CONFIG_FASTBOOT_BUF_SIZE=0x0800
>  CONFIG_USB_STORAGE=y
>  CONFIG_USB_XHCI_HCD=y
>  CONFIG_USB_XHCI_DWC3=y
> +CONFIG_USB_XHCI_ROCKCHIP=y
> +CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS=2
>  CONFIG_USB_EHCI_HCD=y
>  CONFIG_USB_EHCI_GENERIC=y
>  CONFIG_DM_REGULATOR=y
> diff --git a/include/configs/rk3399_common.h b/include/configs/rk3399_common.h
> index bcc54b7..f5815e5 100644
> --- a/include/configs/rk3399_common.h
> +++ b/include/configs/rk3399_common.h
> @@ -94,8 +94,4 @@
>  #define CONFIG_USB_ETHER_SMSC95XX
>  #define CONFIG_USB_ETHER_RTL8152
>
> -/* rockchip xhci host driver */
> -#define CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS 2
> -#define CONFIG_USB_XHCI_ROCKCHIP
> -
>  #endif
> --
> 1.9.1
>

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH 2/2] rk3399: move the USB_XHCI_ROCKCHIP into Kconfig

2016-09-20 Thread Kever Yang
Move USB_XHCI_ROCKCHIP define from soc header file into board defconfig.

Signed-off-by: Kever Yang 
---

 configs/evb-rk3399_defconfig| 2 ++
 include/configs/rk3399_common.h | 4 
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/configs/evb-rk3399_defconfig b/configs/evb-rk3399_defconfig
index 6468620..4ec2e7b 100644
--- a/configs/evb-rk3399_defconfig
+++ b/configs/evb-rk3399_defconfig
@@ -58,6 +58,8 @@ CONFIG_FASTBOOT_BUF_SIZE=0x0800
 CONFIG_USB_STORAGE=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
+CONFIG_USB_XHCI_ROCKCHIP=y
+CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS=2
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_GENERIC=y
 CONFIG_DM_REGULATOR=y
diff --git a/include/configs/rk3399_common.h b/include/configs/rk3399_common.h
index bcc54b7..f5815e5 100644
--- a/include/configs/rk3399_common.h
+++ b/include/configs/rk3399_common.h
@@ -94,8 +94,4 @@
 #define CONFIG_USB_ETHER_SMSC95XX
 #define CONFIG_USB_ETHER_RTL8152
 
-/* rockchip xhci host driver */
-#define CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS 2
-#define CONFIG_USB_XHCI_ROCKCHIP
-
 #endif
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot