Re: [U-Boot] [PATCH 3/4] Handle NETCONSOLE and SPL enabled

2018-03-07 Thread Joe Hershberger
On Wed, Mar 7, 2018 at 4:40 AM, Jason Kridner  wrote:
> From: Jason Kridner 
>
> NETCONSOLE isn't compiled in with SPL, so the include file needs to recognize 
> that.
>
> Signed-off-by: Jason Kridner 
> Cc: Joe Hershberger 

Acked-by: Joe Hershberger 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] [PATCH 3/4] Handle NETCONSOLE and SPL enabled

2018-03-07 Thread Tom Rini
On Wed, Mar 07, 2018 at 05:40:43AM -0500, Jason Kridner wrote:

> From: Jason Kridner 
> 
> NETCONSOLE isn't compiled in with SPL, so the include file needs to recognize 
> that.
> 
> Signed-off-by: Jason Kridner 
> Cc: Joe Hershberger 

Reviewed-by: Tom Rini 

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


[U-Boot] [PATCH 3/4] Handle NETCONSOLE and SPL enabled

2018-03-07 Thread Jason Kridner
From: Jason Kridner 

NETCONSOLE isn't compiled in with SPL, so the include file needs to recognize 
that.

Signed-off-by: Jason Kridner 
Cc: Joe Hershberger 
---
 include/net.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/net.h b/include/net.h
index 455b48f6c7..3101096e9a 100644
--- a/include/net.h
+++ b/include/net.h
@@ -676,7 +676,7 @@ int net_send_udp_packet(uchar *ether, struct in_addr dest, 
int dport,
 /* Processes a received packet */
 void net_process_received_packet(uchar *in_packet, int len);
 
-#ifdef CONFIG_NETCONSOLE
+#if defined(CONFIG_NETCONSOLE) && !defined(CONFIG_SPL_BUILD)
 void nc_start(void);
 int nc_input_packet(uchar *pkt, struct in_addr src_ip, unsigned dest_port,
unsigned src_port, unsigned len);
@@ -684,7 +684,7 @@ int nc_input_packet(uchar *pkt, struct in_addr src_ip, 
unsigned dest_port,
 
 static __always_inline int eth_is_on_demand_init(void)
 {
-#ifdef CONFIG_NETCONSOLE
+#if defined(CONFIG_NETCONSOLE) && !defined(CONFIG_SPL_BUILD)
extern enum proto_t net_loop_last_protocol;
 
return net_loop_last_protocol != NETCONS;
@@ -695,7 +695,7 @@ static __always_inline int eth_is_on_demand_init(void)
 
 static inline void eth_set_last_protocol(int protocol)
 {
-#ifdef CONFIG_NETCONSOLE
+#if defined(CONFIG_NETCONSOLE) && !defined(CONFIG_SPL_BUILD)
extern enum proto_t net_loop_last_protocol;
 
net_loop_last_protocol = protocol;
-- 
2.15.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot