Re: [U-Boot] [PATCH 4/4] rockchip: dts: rk3328-rock64: fix usb power supply

2019-08-19 Thread Matwey V. Kornilov
чт, 15 авг. 2019 г. в 11:14, Kever Yang :
>
> According to rock64 schemetic, both VCC_HOST1_5V and VCC_HOST_5V are
> controlled by USB20_HOST_DRV(GPIO0A2), fix it so that we can get correct
> power supply for USB HOST ports.
>
> Signed-off-by: Kever Yang 

Tested-by: Matwey V. Kornilov 

> ---
>
>  arch/arm/dts/rk3328-rock64.dts | 23 ++-
>  1 file changed, 2 insertions(+), 21 deletions(-)
>
> diff --git a/arch/arm/dts/rk3328-rock64.dts b/arch/arm/dts/rk3328-rock64.dts
> index 7bcc53fcce..a78eb4ac6f 100644
> --- a/arch/arm/dts/rk3328-rock64.dts
> +++ b/arch/arm/dts/rk3328-rock64.dts
> @@ -34,23 +34,10 @@
>
> vcc_host_5v: vcc-host-5v-regulator {
> compatible = "regulator-fixed";
> -   enable-active-high;
> -   gpio = <&gpio0 RK_PA0 GPIO_ACTIVE_HIGH>;
> -   pinctrl-names = "default";
> -   pinctrl-0 = <&usb30_host_drv>;
> -   regulator-name = "vcc_host_5v";
> -   regulator-always-on;
> -   regulator-boot-on;
> -   vin-supply = <&vcc_sys>;
> -   };
> -
> -   vcc_host1_5v: vcc_otg_5v: vcc-host1-5v-regulator {
> -   compatible = "regulator-fixed";
> -   enable-active-high;
> -   gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_HIGH>;
> +   gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_LOW>;
> pinctrl-names = "default";
> pinctrl-0 = <&usb20_host_drv>;
> -   regulator-name = "vcc_host1_5v";
> +   regulator-name = "vcc_host_5v";
> regulator-always-on;
> regulator-boot-on;
> vin-supply = <&vcc_sys>;
> @@ -244,12 +231,6 @@
> rockchip,pins = <0 RK_PA2 RK_FUNC_GPIO 
> &pcfg_pull_none>;
> };
> };
> -
> -   usb3 {
> -   usb30_host_drv: usb30-host-drv {
> -   rockchip,pins = <0 RK_PA0 RK_FUNC_GPIO 
> &pcfg_pull_none>;
> -   };
> -   };
>  };
>
>  &sdmmc {
> --
> 2.17.1
>


-- 
With best regards,
Matwey V. Kornilov
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


[U-Boot] [PATCH 4/4] rockchip: dts: rk3328-rock64: fix usb power supply

2019-08-15 Thread Kever Yang
According to rock64 schemetic, both VCC_HOST1_5V and VCC_HOST_5V are
controlled by USB20_HOST_DRV(GPIO0A2), fix it so that we can get correct
power supply for USB HOST ports.

Signed-off-by: Kever Yang 
---

 arch/arm/dts/rk3328-rock64.dts | 23 ++-
 1 file changed, 2 insertions(+), 21 deletions(-)

diff --git a/arch/arm/dts/rk3328-rock64.dts b/arch/arm/dts/rk3328-rock64.dts
index 7bcc53fcce..a78eb4ac6f 100644
--- a/arch/arm/dts/rk3328-rock64.dts
+++ b/arch/arm/dts/rk3328-rock64.dts
@@ -34,23 +34,10 @@
 
vcc_host_5v: vcc-host-5v-regulator {
compatible = "regulator-fixed";
-   enable-active-high;
-   gpio = <&gpio0 RK_PA0 GPIO_ACTIVE_HIGH>;
-   pinctrl-names = "default";
-   pinctrl-0 = <&usb30_host_drv>;
-   regulator-name = "vcc_host_5v";
-   regulator-always-on;
-   regulator-boot-on;
-   vin-supply = <&vcc_sys>;
-   };
-
-   vcc_host1_5v: vcc_otg_5v: vcc-host1-5v-regulator {
-   compatible = "regulator-fixed";
-   enable-active-high;
-   gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_HIGH>;
+   gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_LOW>;
pinctrl-names = "default";
pinctrl-0 = <&usb20_host_drv>;
-   regulator-name = "vcc_host1_5v";
+   regulator-name = "vcc_host_5v";
regulator-always-on;
regulator-boot-on;
vin-supply = <&vcc_sys>;
@@ -244,12 +231,6 @@
rockchip,pins = <0 RK_PA2 RK_FUNC_GPIO &pcfg_pull_none>;
};
};
-
-   usb3 {
-   usb30_host_drv: usb30-host-drv {
-   rockchip,pins = <0 RK_PA0 RK_FUNC_GPIO &pcfg_pull_none>;
-   };
-   };
 };
 
 &sdmmc {
-- 
2.17.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot