Re: [U-Boot] [PATCH V3 1/3] imx6: Define 'soc' env var for imx6 SoC

2018-04-12 Thread Guillaume Gardet
Le 12/04/2018 à 14:58, Gary Bisson a écrit : Hi Guillaume, On Thu, Apr 12, 2018 at 02:48:07PM +0200, Guillaume Gardet wrote: Le 12/04/2018 à 14:36, Gary Bisson a écrit : Hi Fabio, Guillaume On Thu, Apr 12, 2018 at 08:14:51AM -0300, Fabio Estevam wrote: On Thu, Apr 12, 2018 at 5:13 AM, Gui

Re: [U-Boot] [PATCH V3 1/3] imx6: Define 'soc' env var for imx6 SoC

2018-04-12 Thread Gary Bisson
Hi Guillaume, On Thu, Apr 12, 2018 at 02:48:07PM +0200, Guillaume Gardet wrote: > > > Le 12/04/2018 à 14:36, Gary Bisson a écrit : > > Hi Fabio, Guillaume > > > > On Thu, Apr 12, 2018 at 08:14:51AM -0300, Fabio Estevam wrote: > > > On Thu, Apr 12, 2018 at 5:13 AM, Guillaume Gardet > > > wrote:

Re: [U-Boot] [PATCH V3 1/3] imx6: Define 'soc' env var for imx6 SoC

2018-04-12 Thread Guillaume Gardet
Le 12/04/2018 à 14:36, Gary Bisson a écrit : Hi Fabio, Guillaume On Thu, Apr 12, 2018 at 08:14:51AM -0300, Fabio Estevam wrote: On Thu, Apr 12, 2018 at 5:13 AM, Guillaume Gardet wrote: script that picks the correct dtb. Ok. So, how would you like to proceed? Remove the generic mx6 'soc' def

Re: [U-Boot] [PATCH V3 1/3] imx6: Define 'soc' env var for imx6 SoC

2018-04-12 Thread Gary Bisson
Hi Fabio, Guillaume On Thu, Apr 12, 2018 at 08:14:51AM -0300, Fabio Estevam wrote: > On Thu, Apr 12, 2018 at 5:13 AM, Guillaume Gardet > wrote: > script that picks the correct dtb. > >> > > Ok. So, how would you like to proceed? > > Remove the generic mx6 'soc' definition and use a board sepcific

Re: [U-Boot] [PATCH V3 1/3] imx6: Define 'soc' env var for imx6 SoC

2018-04-12 Thread Fabio Estevam
On Thu, Apr 12, 2018 at 5:13 AM, Guillaume Gardet wrote: script that picks the correct dtb. >> > Ok. So, how would you like to proceed? > Remove the generic mx6 'soc' definition and use a board sepcific 'board_rev' > (or maybe a static definition if one configuration match a single dtb) to > defin

Re: [U-Boot] [PATCH V3 1/3] imx6: Define 'soc' env var for imx6 SoC

2018-04-12 Thread Guillaume Gardet
Le 11/04/2018 à 18:06, Fabio Estevam a écrit : On Wed, Apr 11, 2018 at 12:52 PM, Guillaume Gardet wrote: So, how to handle dtb filenames? Update with wrong soc definition ? Or drop this patch and define a FDTFILE for each flavor? You can take a look at how we handle this for wandboard, cubo

Re: [U-Boot] [PATCH V3 1/3] imx6: Define 'soc' env var for imx6 SoC

2018-04-11 Thread Fabio Estevam
On Wed, Apr 11, 2018 at 12:52 PM, Guillaume Gardet wrote: > So, how to handle dtb filenames? Update with wrong soc definition ? Or drop > this patch and define a FDTFILE for each flavor? You can take a look at how we handle this for wandboard, cuboxi, sabresd, for example. Taking mx6sabresd as

Re: [U-Boot] [PATCH V3 1/3] imx6: Define 'soc' env var for imx6 SoC

2018-04-11 Thread Guillaume Gardet
Le 11/04/2018 à 17:46, Gary Bisson a écrit : Hi Guillaume, On Wed, Apr 11, 2018 at 12:38:48PM +0200, Guillaume GARDET wrote: Signed-off-by: Guillaume GARDET Cc: Troy Kisky Cc: Stefano Babic Cc: Fabio Estevam Cc: Gary Bisson --- arch/arm/mach-imx/mx6/soc.c | 34

Re: [U-Boot] [PATCH V3 1/3] imx6: Define 'soc' env var for imx6 SoC

2018-04-11 Thread Gary Bisson
Hi Guillaume, On Wed, Apr 11, 2018 at 12:38:48PM +0200, Guillaume GARDET wrote: > Signed-off-by: Guillaume GARDET > Cc: Troy Kisky > Cc: Stefano Babic > Cc: Fabio Estevam > Cc: Gary Bisson > > --- > arch/arm/mach-imx/mx6/soc.c | 34 ++ > 1 file changed, 34 in

Re: [U-Boot] [PATCH V3 1/3] imx6: Define 'soc' env var for imx6 SoC

2018-04-11 Thread Fabio Estevam
On Wed, Apr 11, 2018 at 11:41 AM, Guillaume Gardet wrote: > This is for efi fdtfile fallback definition for default distro config for > nitrogen6x board. > Is it ok for you? Yes, this is the explanation that I was looking for :-) Please send a new version with this info added in the commit log.

Re: [U-Boot] [PATCH V3 1/3] imx6: Define 'soc' env var for imx6 SoC

2018-04-11 Thread Guillaume Gardet
Hi, Le 11/04/2018 à 16:23, Fabio Estevam a écrit : Hi Guillaume, On Wed, Apr 11, 2018 at 7:38 AM, Guillaume GARDET wrote: Please explain in the commit log why this is needed. Thanks This is for efi fdtfile fallback definition for default distro config for nitrogen6x board. Is it ok for yo

Re: [U-Boot] [PATCH V3 1/3] imx6: Define 'soc' env var for imx6 SoC

2018-04-11 Thread Fabio Estevam
Hi Guillaume, On Wed, Apr 11, 2018 at 7:38 AM, Guillaume GARDET wrote: Please explain in the commit log why this is needed. Thanks > Signed-off-by: Guillaume GARDET > Cc: Troy Kisky > Cc: Stefano Babic > Cc: Fabio Estevam > Cc: Gary Bisson ___ U-

[U-Boot] [PATCH V3 1/3] imx6: Define 'soc' env var for imx6 SoC

2018-04-11 Thread Guillaume GARDET
Signed-off-by: Guillaume GARDET Cc: Troy Kisky Cc: Stefano Babic Cc: Fabio Estevam Cc: Gary Bisson --- arch/arm/mach-imx/mx6/soc.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/arch/arm/mach-imx/mx6/soc.c b/arch/arm/mach-imx/mx6/soc.c index 9b3d8f69b