Re: [U-Boot] [PATCH v2 0/3] imx:mx6 add usb support
On Tuesday, November 04, 2014 at 08:49:59 AM, Peng Fan wrote: So uh, what exactly does this patchset do ? It's not clear at all from the subject and any description is completely missing. To my knowledge, i.MX6 already does have USB support in U-Boot, so the subject is misleading as well. Changes v2: - move pinmux setting into board_init - add otg polarity setting in board_ehci_hcd_init - Introduce a new weak function to give board a choice to decide the work mode of the otg port, since a otg port can also work in host mode without touch ID pin. Peng Fan (3): usb:ehci-mx6 add board_ehci_usb_mode function imx:mx6sxsabresd add usb support imx:mx6slevk add usb support arch/arm/include/asm/arch-mx6/mx6sl_pins.h | 5 +++ board/freescale/mx6slevk/mx6slevk.c | 51 + board/freescale/mx6sxsabresd/mx6sxsabresd.c | 51 + drivers/usb/host/ehci-mx6.c | 7 include/configs/mx6slevk.h | 14 include/configs/mx6sxsabresd.h | 14 6 files changed, 142 insertions(+) Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 0/3] imx:mx6 add usb support
在 11/4/2014 6:31 PM, Marek Vasut 写道: On Tuesday, November 04, 2014 at 08:49:59 AM, Peng Fan wrote: So uh, what exactly does this patchset do ? It's not clear at all from the subject and any description is completely missing. To my knowledge, i.MX6 already does have USB support in U-Boot, so the subject is misleading as well. mx6sxsasbresd board and mx6slevk board does not have board level support for usb. This patchset is mainly to add pinmux and implement board_ehci_hcd_init and board_echi_power and add USB CONFIG in header file to make usb work fine. I'll send another patch for review, if usb:ehci-mx6 add board_ehci_usb_mode function is fine. Changes v2: - move pinmux setting into board_init - add otg polarity setting in board_ehci_hcd_init - Introduce a new weak function to give board a choice to decide the work mode of the otg port, since a otg port can also work in host mode without touch ID pin. Peng Fan (3): usb:ehci-mx6 add board_ehci_usb_mode function imx:mx6sxsabresd add usb support imx:mx6slevk add usb support arch/arm/include/asm/arch-mx6/mx6sl_pins.h | 5 +++ board/freescale/mx6slevk/mx6slevk.c | 51 + board/freescale/mx6sxsabresd/mx6sxsabresd.c | 51 + drivers/usb/host/ehci-mx6.c | 7 include/configs/mx6slevk.h | 14 include/configs/mx6sxsabresd.h | 14 6 files changed, 142 insertions(+) Best regards, Marek Vasut Regards, Peng. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 0/3] imx:mx6 add usb support
On Tuesday, November 04, 2014 at 01:05:44 PM, Peng Fan wrote: 在 11/4/2014 6:31 PM, Marek Vasut 写道: On Tuesday, November 04, 2014 at 08:49:59 AM, Peng Fan wrote: So uh, what exactly does this patchset do ? It's not clear at all from the subject and any description is completely missing. To my knowledge, i.MX6 already does have USB support in U-Boot, so the subject is misleading as well. mx6sxsasbresd board and mx6slevk board does not have board level support for usb. This patchset is mainly to add pinmux and implement board_ehci_hcd_init and board_echi_power and add USB CONFIG in header file to make usb work fine. I'll send another patch for review, if usb:ehci-mx6 add board_ehci_usb_mode function is fine. Please see my comment to that patch before you re-submit. Thanks! Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2 0/3] imx:mx6 add usb support
Changes v2: - move pinmux setting into board_init - add otg polarity setting in board_ehci_hcd_init - Introduce a new weak function to give board a choice to decide the work mode of the otg port, since a otg port can also work in host mode without touch ID pin. Peng Fan (3): usb:ehci-mx6 add board_ehci_usb_mode function imx:mx6sxsabresd add usb support imx:mx6slevk add usb support arch/arm/include/asm/arch-mx6/mx6sl_pins.h | 5 +++ board/freescale/mx6slevk/mx6slevk.c | 51 + board/freescale/mx6sxsabresd/mx6sxsabresd.c | 51 + drivers/usb/host/ehci-mx6.c | 7 include/configs/mx6slevk.h | 14 include/configs/mx6sxsabresd.h | 14 6 files changed, 142 insertions(+) -- 1.8.4.5 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
