Re: [U-Boot] [PATCH v2 00/15] nand: device model bringup on am335x evm and am437x gpevm
On Mon, Feb 06, 2017 at 12:50:25PM -0600, Grygorii Strashko wrote: > Hi Tom, > > On 02/05/2017 07:56 PM, Tom Rini wrote: > > On Tue, Jan 31, 2017 at 03:37:02PM -0600, Grygorii Strashko wrote: > > > >> This patch seires adds nand uclass driver and enables omap_gpmc to > >> adopt driver model. This has been tested on AM335x GP EVM and > >> AM437x GP EVM. > >> > >> As preparation for introducing nand uclass driver the new API > >> get_nand_dev_by_index() was added to avoid direct acces to nand_info array > >> and > >> u-boot core files were updated to use it. > >> > >> Patches can be found at: > >> g...@git.ti.com:~gragst/ti-u-boot/gragsts-ti-u-boot.git dm-nand-v2 > > > > My conceptual concern here is that we need to address (as I've stated > > elsewhere) the need to get DM/DT support within SPL on these families > > (and yes, figure out what we'll do with respect to HS and the further > > size constraints) before we push farther down this path of DM/DT > > conversion as it's adding more #if/#else/#endif code that we need to be > > able to drop. Thanks! > > > > I understand your concern and see it's discussed now in [1], but I'd > like to understand how to proceed with this series. > > The original patches from from Mugunthan are at about 1 year old and > and it took me pretty a lot of time to just re-base them properly, > so will it be acceptable if i will re-send only patches 1-10 as they are > do not depend on TI SPL and will unblock DM conversation of other drivers? > Really want to reduce existed patch queue :( > > [1] https://www.mail-archive.com/u-boot@lists.denx.de/msg237938.html We can take up some of the underlying patches now, yes. But we really need to do the DM conversion fully, in order to really unblock progress. -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 00/15] nand: device model bringup on am335x evm and am437x gpevm
Hi Tom, On 02/05/2017 07:56 PM, Tom Rini wrote: > On Tue, Jan 31, 2017 at 03:37:02PM -0600, Grygorii Strashko wrote: > >> This patch seires adds nand uclass driver and enables omap_gpmc to >> adopt driver model. This has been tested on AM335x GP EVM and >> AM437x GP EVM. >> >> As preparation for introducing nand uclass driver the new API >> get_nand_dev_by_index() was added to avoid direct acces to nand_info array >> and >> u-boot core files were updated to use it. >> >> Patches can be found at: >> g...@git.ti.com:~gragst/ti-u-boot/gragsts-ti-u-boot.git dm-nand-v2 > > My conceptual concern here is that we need to address (as I've stated > elsewhere) the need to get DM/DT support within SPL on these families > (and yes, figure out what we'll do with respect to HS and the further > size constraints) before we push farther down this path of DM/DT > conversion as it's adding more #if/#else/#endif code that we need to be > able to drop. Thanks! > I understand your concern and see it's discussed now in [1], but I'd like to understand how to proceed with this series. The original patches from from Mugunthan are at about 1 year old and and it took me pretty a lot of time to just re-base them properly, so will it be acceptable if i will re-send only patches 1-10 as they are do not depend on TI SPL and will unblock DM conversation of other drivers? Really want to reduce existed patch queue :( [1] https://www.mail-archive.com/u-boot@lists.denx.de/msg237938.html -- regards, -grygorii ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 00/15] nand: device model bringup on am335x evm and am437x gpevm
On Tue, Jan 31, 2017 at 03:37:02PM -0600, Grygorii Strashko wrote: > This patch seires adds nand uclass driver and enables omap_gpmc to > adopt driver model. This has been tested on AM335x GP EVM and > AM437x GP EVM. > > As preparation for introducing nand uclass driver the new API > get_nand_dev_by_index() was added to avoid direct acces to nand_info array and > u-boot core files were updated to use it. > > Patches can be found at: > g...@git.ti.com:~gragst/ti-u-boot/gragsts-ti-u-boot.git dm-nand-v2 My conceptual concern here is that we need to address (as I've stated elsewhere) the need to get DM/DT support within SPL on these families (and yes, figure out what we'll do with respect to HS and the further size constraints) before we push farther down this path of DM/DT conversion as it's adding more #if/#else/#endif code that we need to be able to drop. Thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2 00/15] nand: device model bringup on am335x evm and am437x gpevm
This patch seires adds nand uclass driver and enables omap_gpmc to
adopt driver model. This has been tested on AM335x GP EVM and
AM437x GP EVM.
As preparation for introducing nand uclass driver the new API
get_nand_dev_by_index() was added to avoid direct acces to nand_info array and
u-boot core files were updated to use it.
Patches can be found at:
g...@git.ti.com:~gragst/ti-u-boot/gragsts-ti-u-boot.git dm-nand-v2
Test case1:
mmc rescan
fatload mmc 0 ${loadaddr} MLO1
nand erase.part
nand write ${loadaddr}
nand read 0x8400 0 ${filesize}
cmp ${loadaddr} 0x8400 ${filesize}
Test case2:
nand read $loadaddr NAND.kernel
nand read $fdtaddr NAND.u-boot-spl-os
run args_mmc
bootz ${loadaddr} - ${fdtaddr}
Changes in v2:
- series rebased on top of u-boot master
- added more patches to convert u-boot core files to use
get_nand_dev_by_index()
- nand uclass driver was simplified thanks to commits
17cb4b8 mtd: nand: Add+use mtd_to/from_nand and nand_get/set_controller_data
b616d9b nand: Embed mtd_info in struct nand_chip
link on v1:
http://lists.denx.de/pipermail/u-boot/2016-April/250197.html
Grygorii Strashko (8):
cmd: bootm: fix build when CONFIG_CMD_IMLS_NAND
common: env_nand: use get_nand_dev_by_index()
dfu: dfu_nand: use get_nand_dev_by_index()
cmd: bootm: use get_nand_dev_by_index()
cmd: jffs2: use get_nand_dev_by_index()
common: use get_nand_dev_by_index()
fs: use get_nand_dev_by_index()
cmd: nand: remove direct access to struct mtd_info->priv
Mugunthan V N (7):
cmd: nand: abstract global variable usage for dm conversion
drivers: nand: implement a NAND uclass
drivers: nand: omap_gpmc: convert driver to adopt driver model
am43xx_evm: nand: do not define DM_NAND for spl
defconfig: am43xx_evm: enable NAND driver model
am335x_evm: nand: do not define DM_NAND for spl
defconfig: am335x_evm: enable NAND driver model
cmd/bootm.c| 6 +-
cmd/jffs2.c| 7 +-
cmd/nand.c | 69 --
common/env_nand.c | 33 ---
common/fb_nand.c | 2 +-
common/splash_source.c | 5 +-
configs/am335x_evm_defconfig | 1 +
configs/am43xx_evm_defconfig | 1 +
drivers/dfu/dfu_nand.c | 12 +--
drivers/mtd/nand/Kconfig | 10 ++
drivers/mtd/nand/Makefile | 2 +
drivers/mtd/nand/nand-uclass.c | 38
drivers/mtd/nand/nand.c| 40 ++--
drivers/mtd/nand/omap_gpmc.c | 212 -
fs/jffs2/jffs2_1pass.c | 9 +-
fs/jffs2/jffs2_nand_1pass.c| 6 +-
fs/yaffs2/yaffs_uboot_glue.c | 8 +-
include/configs/am335x_evm.h | 1 +
include/configs/am43xx_evm.h | 1 +
include/dm/uclass-id.h | 1 +
include/nand.h | 9 ++
21 files changed, 397 insertions(+), 76 deletions(-)
create mode 100644 drivers/mtd/nand/nand-uclass.c
--
2.10.1.dirty
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
