Re: [U-Boot] [PATCH v2 07/10] powerpc: mpc8xx: get rid of get_immr()

2018-03-04 Thread christophe leroy
Le 04/03/2018 à 15:51, Wolfgang Denk a écrit : Dear Christophe, In message <71a3900b-f61e-e9f8-c12a-5ec5aa142...@c-s.fr> you wrote: - immap_t __iomem *immap = (immap_t __iomem *)(immr & 0x); + immap_t __iomem *immap = (immap_t __iomem *)CONFIG_SYS_IMMR; This is a total

Re: [U-Boot] [PATCH v2 07/10] powerpc: mpc8xx: get rid of get_immr()

2018-03-04 Thread Wolfgang Denk
Dear Christophe, In message <71a3900b-f61e-e9f8-c12a-5ec5aa142...@c-s.fr> you wrote: > > >> - immap_t __iomem *immap = (immap_t __iomem *)(immr & 0x); > >> + immap_t __iomem *immap = (immap_t __iomem *)CONFIG_SYS_IMMR; > > > > This is a totally unrelated change, which additionally chan

Re: [U-Boot] [PATCH v2 07/10] powerpc: mpc8xx: get rid of get_immr()

2018-03-04 Thread christophe leroy
Le 03/03/2018 à 17:46, Wolfgang Denk a écrit : Dear Christophe, In message <622b8aec162cc43e774bde5da990a61fc961b4d9.1519976944.git.christophe.le...@c-s.fr> you wrote: Function get_immr() is almost not used and doesn't bring much added value. Just replace it with mfspr(SPRN_IMMR) at the two

Re: [U-Boot] [PATCH v2 07/10] powerpc: mpc8xx: get rid of get_immr()

2018-03-03 Thread Wolfgang Denk
Dear Christophe, In message <622b8aec162cc43e774bde5da990a61fc961b4d9.1519976944.git.christophe.le...@c-s.fr> you wrote: > Function get_immr() is almost not used and doesn't bring much > added value. Just replace it with mfspr(SPRN_IMMR) at the two > needed places. ... > static int check_CPU(lo

[U-Boot] [PATCH v2 07/10] powerpc: mpc8xx: get rid of get_immr()

2018-03-02 Thread Christophe Leroy
Function get_immr() is almost not used and doesn't bring much added value. Just replace it with mfspr(SPRN_IMMR) at the two needed places. Signed-off-by: Christophe Leroy --- arch/powerpc/cpu/mpc8xx/cpu.c | 7 +++ arch/powerpc/cpu/mpc8xx/reginfo.c | 2 +- arch/powerpc/cpu/mpc8xx/speed.c